[Koha-bugs] [Bug 21366] Add Plack reload

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Aug 23 01:26:39 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366

--- Comment #24 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Marcel de Rooy from comment #23)
> If you enable --preload-app option, however, the code will be only loaded in the startup process and will not pick up the code changes you made. If you want to preload the app and do graceful restarts by reloading the code changes, you're recommended to use Server::Starter, configured to send QUIT signal when superdaemon received HUP ...
> [End of quote]
> While testing with about and inserting a small code change, I notice that
> while I started the about web request before the plack reload, the code
> change already is visible in the web request.
> I think that this is not what we want here ?

What do you mean? The patch doesn't use --preload-app.

I tested changing something in about.pl: once over the ~10 tries the change was
reflected only by reloading the page. Otherwise I had to run `pkill starman
--signal SIGHUP` to get the change.

Your plack_max_requests isn't 1 is it? That would be an explanation of what you
observed.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list