[Koha-bugs] [Bug 25816] Add OPAC messages in SIP display

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #3)
> Works as expected.. signing off.
> 
> QA comment.. we should probably have Unit Tests for this. Also, my brain
> fails me right now; but are there any characters we should be
> escaping/filtering from messages here?

Agreed with the unit test. Also, I wonder if this should be controlled by yet
another sip account level switch in the sip config. Characters should already
get escaped automatically.

However, it's not working for me atm:
CLI:
./misc/sip_cli_emulator.pl -a 127.0.0.1 -su koha -sp koha -l MPL --patron
23529000035676 -m patron_information
Attempting socket connection to 127.0.0.1:6001...connected!
Use of uninitialized value $hold_mode in string eq at
./misc/sip_cli_emulator.pl line 120.
SEND: 9300CNkoha|COkoha|CPMPL|
READ: 941

Trying 'patron_information'
SEND: 6300120220823    155418          AOMPL|AA23529000035676|ACkoha|
Use of uninitialized value $data in concatenation (.) or string at
./misc/sip_cli_emulator.pl line 352, <GEN0> chunk 1.
READ:

Logs:
[2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying 6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying *:6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying 127.0.0.1:6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]: raw_transport: timeout
is 60 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]: read_request trimmed 1
character(s)  C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:51] [26838] [INFO] [undef]@[undef]: INPUT MSG:
'9300CNkoha|COkoha|CPMPL' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm
(223)
[2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]:
Sip::MsgType::new('C4::SIP::Sip::MsgType', '9300CNkoha...', '93'): seq.no '0',
protocol 2 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:51] [26838] [DEBUG] [undef]@[undef]:
Sip::MsgType::_initialize('Login', '00CNkoha|COkoha|CPMPL', 'A1A1', '2', ...)
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:52] [26838] [INFO] [undef]@[undef]: Successful login/auth for
'koha' of 'kohalibrary' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm
(223)
[2022/08/23 15:55:52] [26838] [DEBUG] [undef]@[undef]: login_core: $VAR1 =
'ILS';
 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:52] [26838] [DEBUG] [undef]@[undef]: new ILS 'kohalibrary'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:52] [26838] [INFO] [undef]@[undef]: OUTPUT MSG: '941'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:52] [26838] [DEBUG] koha at 127.0.0.1: raw_transport:
uname/inst: 'koha/kohalibrary' C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:52] [26838] [DEBUG] koha at 127.0.0.1: read_request trimmed 2
character(s)  C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:52] [26838] [INFO] koha at 127.0.0.1: INPUT MSG: '6300120220823 
  155551          AOMPL|AA23529000035676|ACkoha' C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:52] [26838] [DEBUG] koha at 127.0.0.1:
Sip::MsgType::new('C4::SIP::Sip::MsgType', '6300120220...', '63'): seq.no '0',
protocol 2 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:52] [26838] [DEBUG] koha at 127.0.0.1:
Sip::MsgType::_initialize('Patron Info', '00120220823    155551         
AOMPL|AA23529000035676|ACkoha', 'A3A18A10', '31', ...) C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (223)
[2022/08/23 15:55:52] [26838] [INFO] koha at 127.0.0.1: raw_transport: shutting
down C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (223)

-- 
You are receiving this mail because:
You are watching all bug changes.