[Koha-bugs] [Bug 29987] Manual credits are not recorded for a register

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to David Nind from comment #8)
> After testing this, signing off, and adding a draft release note, I noticed
> that:
> 
> 1. In the cash summary for the library, the amounts are now included in the
> income (cash) total (good!).

Correct, I believe this is as expected

> 2. However, they are not included in the bankable column (bad?).

Payment type was not being recorded correctly.. that is now fixed in the first
follow-up. 'Cash' type transactions should be 'bankable' (I think I have a bug
somewhere to make the types included in bankable configurable but for now it's
cash only)

> 3. In the details for the cash register, for transactions there is a total,
> but it says "No data available in table" (and the same for the older
> transactions).

This is the second follow up patch.. though I've only implimented it for
current transactions so far.. we can copy the logic to old transactions if
we're happy it makes sense.

> 4. If you do a cashup, these transactions are not included (if there are no
> other cash transactions, then do a cashup the message is "Please confirm
> that you have removed 0.00 from the cash register and left a float of
> 0.00.").

I think this should be fixed by the first follow-up above.

> My query: If you receive cash (say, paying charges in advance) and create a
> manual credit, then should it be included in items 2-4? 
>
> I think it should, as when you go to do the banking you want it included in
> that total so that everything reconciles.
> 
> However, other manual credits, for example if you write off charges,
> shouldn't be as you have neither added to or taken anything out of the cash
> register.

You are correct.. any process by which money actually changes hands at the
register should be reported.

-- 
You are receiving this mail because:
You are watching all bug changes.