[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Lucas, 

1) Changes to patron name display in general

I am a bit hesitant about the changes to
koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc.

To me the pronouns don't feel like a part of the name and therefore I'd prefer
to keep them separate from the common name include.

My suggestion would be to show them separately but prominently in the brief
patron information on the left side of patron account in the staff interface
instead. At the moment we create a very long display string, even with 'short'
name parts.

But this is certainly something we could argue about and feel free to ask
others for their opinions please!

To give some examples:

Headings in the patron account:
Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559)

Staff detail:
Checked out to Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) :
due 09/02/2022 

Accounting tab:
Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) has no
outstanding fines.

Notices tab, h1:
Sent notices for Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559)


.. if you insist, there are 2 things in the include:

1) Do we need pronouns for organisations? :)

type = I is organisations often used for libraries or schools. I think pronouns
would not be required here:

[%- IF data.category_type == 'I' -%]
-        [%- data.surname | html %] [% IF data.othernames %] ([%
data.othernames | html %])[% END -%]
+        [%- data.surname | html %] [% IF data.othernames %] ([%
data.othernames | html %])[% END -%] [% IF data.pronouns %]([% data.pronouns |
html %])[% END %]


2) Missing space

We are also missing a space:
Floyd Middle (Other_name) Delgado(he/him) 

3) Details tab in staff

And unrelated: currently pronouns show up under "contact information", but that
doesn't feel quite right for placement and I don't like the quotes for some
reason:

Contact information
“she/her”

    6661 Library Rd.
    Springfield, MA 44224

-- 
You are receiving this mail because:
You are watching all bug changes.