[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139126|0                           |1
        is obsolete|                            |

--- Comment #12 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 139930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139930&action=edit
Bug 29658: Fix crash on cancelling cancelled order

Found this crash in our 20.11 logs:
Cannot insert order: Mandatory parameter biblionumber is missing at
/usr/share/koha/acqui/cancelorder.pl line 60.
 at /usr/share/perl/5.28/Carp.pm line 289
        Carp::croak('Cannot insert order: Mandatory parameter biblionumber is
missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79
       
Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)')
called at /usr/share/koha/Koha/Acquisition/Order.pm line 189
       
Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)',
'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60

Not sure how to reproduce this one as it happened. But might be related to
repeated clicking, backspacing etc.

Test plan:
Create a new basket and order.
Open this same basket in two browser tabs.
Cancel the order line (delete catalog record) in tab 1.
Go to second tab, try again.
Without this patch, it will crash. With this patch, an error message.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.