[Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456

--- Comment #6 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Katrin Fischer from comment #5)
> I've quickly looked around a bit:
> 
> Open Library Covers API (optional?)
> https://openlibrary.org/dev/docs/api/covers
> 
> 3) A courtesy link back to Open Library is appreciated, whether it be on
> each individual book's page (where you can link back to the book's page on
> Open Library, for example, using the same ISBN
> https://openlibrary.org/isbn/9780385533225), or on your About page or in
> your footer. 
> 
> 
> Amazon Cover API 
> https://developers.google.com/books/branding ?
> 
> Google must be given attribution, using the appropriate text or brand
> elements, whenever you display Google results, previews, or other content
> made available through the API.
> You must maintain prominent links to Google Books pages and features.

Hi Katrin, 

Thank you for noting this. I think you're right it could be difficult to
upstream this change - because of the mandatory attribution requirements of
Google.

Although, this change is really only giving libraries the option to revert to
pre Koha 21.11 behaviour - not displaying text attribution of where an image is
from.

If libraries want they can hide the text using JavaScript. 

We think the optimal fix might be to add an ID to the parent div, if one
doesn't already exist (i.e.
https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt#L66
and
https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt#L105
) to make it easier to hide the hint with JavaScript if necessary. 

What do you think of that as a solution?

Thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.