[Koha-bugs] [Bug 31458] Remove Koha::Patron::Debarment::AddDebarment and use $patron->add_restriction in preference

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31458

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
I believe we've discussed this elsewhere, but just to make sure it's public;
The field borrowers.debarred was retained so that existing code utilizing the
debarred field would continue to work. In practice, sometimes that field gets
out of sync with the actual debarments. At this point in time, it makes a lot
more sense to remove borrowers.debarred from the database. I think the same can
be said for debarredcomment as well.

(In reply to Martin Renvoize from comment #3)
> Created attachment 139800 [details] [review]
> Add _update_patron_restriction_fields
> 
> This still needs some work.. picking which of the two constructs for
> ordering works and removing new lines from the debarredcomment field.
> 
> Do we even need the local debarredcomment field any more... and should
> the debarred field just become a boolean.. or should we just drop the
> fields from the borrowers table entirely and rely on relations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.