[Koha-bugs] [Bug 30280] Support authority records with common subject headings from different thesaurus

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #43 from Frank Hansen <frank.hansen at ub.lu.se> ---
(In reply to Katrin Fischer from comment #41)
> Thx for the great work on the test plan and sample data, this makes it much
> easier to test :)
> 
> I am happy to add another sign-off, but for this to go through QA, we will
> also need unit tests to cover the changes in the .pm files. Please let us
> know if we can help with that!

Yes, there are already existing tests in these files:
t/db_dependent/Linker_Default.t
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t 

They need some minor changes so they will PASS tests.

This test outputs warnings even if it says OK:
t/db_dependent/Linker_FirstMatch.t
Use of uninitialized value $thesaurus in concatenation (.) or string at
/kohadevbox/koha/C4/Linker/Default.pm line 38.
Use of uninitialized value $thesaurus in concatenation (.) or string at
/kohadevbox/koha/C4/Linker/Default.pm line 79.
Use of uninitialized value $thesaurus in concatenation (.) or string at
/kohadevbox/koha/C4/Linker/Default.pm line 80.
Use of uninitialized value $thesaurus in concatenation (.) or string at
/kohadevbox/koha/C4/Linker/Default.pm line 81.
Use of uninitialized value $thesaurus in concatenation (.) or string at
/kohadevbox/koha/C4/Linker/Default.pm line 82.
t/db_dependent/Linker_FirstMatch.t .. ok
All tests successful.

These warnings doesn't appear in t/db_dependent/Linker_Default.t 

I would like to add a few more test to t/db_dependent/Linker_Default.t to cover
my changes in unit test.

-- 
You are receiving this mail because:
You are watching all bug changes.