From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:16:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 23:16:47 +0000
Subject: [Koha-bugs] [Bug 30359] GetBudgetHierarchy is slow on order receive
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30359
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:16:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 23:16:50 +0000
Subject: [Koha-bugs] [Bug 32377] GetBudgetHierarchy slows down
acqui/histsearch.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32377
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:19:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 23:19:10 +0000
Subject: [Koha-bugs] [Bug 32369] Two factor authentication can be bypassed
if catalog and staff interface URL aren't properly configured
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32369
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #2 from David Cook ---
(In reply to Jonathan Druart from comment #1)
> Not sure this is considered a bug. It's a configuration issue in my opinion.
I'm inclined to say the same.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:23:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 23:23:55 +0000
Subject: [Koha-bugs] [Bug 32095] Remove bullets from statuses in inventory
tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32095
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:24:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 23:24:00 +0000
Subject: [Koha-bugs] [Bug 32095] Remove bullets from statuses in inventory
tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32095
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144344|0 |1
is obsolete| |
--- Comment #4 from David Nind ---
Created attachment 144367
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144367&action=edit
Bug 32095: Remove bullets from inventory tool status
The new design included bullet points in a list where the elements were aligned
to the right. The bullets have now been removed using "list-style: none;" to
make the styling much cleaner.
Test plan:
1) Navigate to Cataloging > Inventory
2) Observe that in the "Optional filters for inventory list or comparing
barcodes" section there are bullet points in the listed items
3) Apply patch
4) Navigate to the same window and observe that the bullet points are now
missing
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:24:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 23:24:30 +0000
Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
effective_name method to patrons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
Juliet Heltibridle changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jheltibridle at rcplib.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:55:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 23:55:47 +0000
Subject: [Koha-bugs] [Bug 32302] "ISBN" label shows when no ISBN data
present when sending list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:55:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 23:55:52 +0000
Subject: [Koha-bugs] [Bug 32302] "ISBN" label shows when no ISBN data
present when sending list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144366|0 |1
is obsolete| |
--- Comment #5 from David Nind ---
Created attachment 144368
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144368&action=edit
Bug 32302: Hide "ISBN" label when no ISBN data when sending list
There is a logic mistake in the opac-sendshelf.tt template where
we test if the "ISBN" key exists in the "BIBLIO_RESULT" hash when
we should really be testing if the arrayref returned by "ISBN" is
empty or not, since that "ISBN" key always exists and contains at least
an empty arrayref.
Test plan:
1. Apply patch and restart your Koha Starman
2. Create a public list containing records with 020 MARC fields and
records without 020 MARC fields
3. View the list in the OPAC
4. Click "Send list" and email it to yourself
5. Note that only records with 020 MARC fields with show "ISBN:"
in the email output
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:55:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 23:55:58 +0000
Subject: [Koha-bugs] [Bug 32302] "ISBN" label shows when no ISBN data
present when sending list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302
--- Comment #6 from David Nind ---
Created attachment 144369
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144369&action=edit
Bug 32302: (follow-up) Hide ISBN label when list sent from the staff interface
This makes the same change to the staff interface. Lists sent
from the staff interface hide the ISBN label in the email message
when there are no ISBNs for a record.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 00:59:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Nov 2022 23:59:28 +0000
Subject: [Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375
--- Comment #3 from Danyon Sewell ---
Created attachment 144370
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144370&action=edit
bug 32375: moving t/AuthoritiesMarc_MARC21.t to t/db_dependent
t/AuthoritiesMarc_MARC21.t is now db dependent so it needs to be in
t/db_dependent to pass the tests
Sponsored-by: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 01:00:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 00:00:22 +0000
Subject: [Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375
Danyon Sewell changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
CC| |danyonsewell at catalyst.net.n
| |z
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 01:06:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 00:06:29 +0000
Subject: [Koha-bugs] [Bug 32302] "ISBN" label shows when no ISBN data
present when sending list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Text to go in the| |This fixes email messages
release notes| |sent when sending lists so
| |that if there are no ISBNs
| |for a record, an empty
| |label is not shown.
CC| |david at davidnind.com
--- Comment #7 from David Nind ---
Hi David.
I added a follow-up for lists sent from the staff interface, as they were doing
exactly the same thing - I didn't read the test plan correctly, and wondered
why it wasn't working from the staff interface.
Hope you don't mind!
David
Testing notes using KTD (koha-testing-docker):
1. Created a list from the search results for 'perl' (11 results, 2 don't have
ISBNs, some results have multiple ISBNs).
2. To setup KTD to send email using a Google account:
2.1 Edit your /etc/koha/sites/kohadev/koha-conf.xml file
2.2 Add this configuration near the end:
. = your Google email address
. = an APP password that you need to create in your Google
account, not your Google account password
smtp.gmail.com
587
5
STARTTLS
GOOGLEACCOUNTUSER
GOOGLEAPPPASSWORD
1
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 01:21:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 00:21:29 +0000
Subject: [Koha-bugs] [Bug 32384] New: Form for sending lists from the OPAC
is misaligned
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32384
Bug ID: 32384
Summary: Form for sending lists from the OPAC is misaligned
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Lists
Assignee: koha-bugs at lists.koha-community.org
Reporter: david at davidnind.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
Created attachment 144371
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144371&action=edit
Screenshot - OPAC form for sending a list
The form used to send a list from the OPAC needs tidying up - the fields go
across the page (see the attached screenshot).
Note that the staff interface form displays correctly.
To replicate:
1. In the staff interface, create a public list (for example, from a search for
perl).
2. In the OPAC, view the list and select the 'Send list' option.
3. Note that the form to enter the email address and comment:
3.1 Opens in a new browser window that expands to fill the whole screen.
3.2 The labels and input fields go across the page, instead of down.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 01:21:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 00:21:50 +0000
Subject: [Koha-bugs] [Bug 32384] Form for sending lists from the OPAC is
misaligned
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32384
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Keywords| |Academy
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 01:37:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 00:37:58 +0000
Subject: [Koha-bugs] [Bug 32302] "ISBN" label shows when no ISBN data
present when sending list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302
--- Comment #8 from David Cook ---
(In reply to David Nind from comment #7)
> Hope you don't mind!
Not at all! Thanks for testing and for the follow-up :).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 01:38:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 00:38:43 +0000
Subject: [Koha-bugs] [Bug 32384] Form for sending lists from the OPAC is
misaligned
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32384
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 01:46:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 00:46:07 +0000
Subject: [Koha-bugs] [Bug 32302] "ISBN" label shows when no ISBN data
present when sending list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302
--- Comment #9 from Adam Styles ---
Hi David and David,
Firstly, apologies if my questions on your initial bug report were not as
coherent as they were in my head lol. I am new to the Koha dev community and
will work on my communication skills.
Thanks for the patch, I was looking for something to fix and this looked like
a quick one, I will look around for others 8-)
Thanks again.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 02:06:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 01:06:27 +0000
Subject: [Koha-bugs] [Bug 32302] "ISBN" label shows when no ISBN data
present when sending list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32302
--- Comment #10 from David Cook ---
(In reply to Adam Styles from comment #9)
> Firstly, apologies if my questions on your initial bug report were not as
> coherent as they were in my head lol. I am new to the Koha dev community and
> will work on my communication skills.
No worries at all. I think my initial description was pretty vague!
Glad to have you aboard. Always good to see other Australians working on Koha!
It's not often I get to share a timezone with another Koha dev ;).
> Thanks for the patch, I was looking for something to fix and this looked
> like a quick one, I will look around for others 8-)
Good instinct. It was a quick one!
If you're looking for easy bugs, you might considering doing a Bugzilla search
on the keyword "Academy".
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 02:09:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 01:09:57 +0000
Subject: [Koha-bugs] [Bug 31208] "Check for embedded item record data"
should default to "No"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31208
--- Comment #1 from David Cook ---
I suppose since this would change existing behaviour, this would need a system
preference...
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 04:38:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 03:38:08 +0000
Subject: [Koha-bugs] [Bug 31675] Remove packages from debian/control that
are no longer used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31675
Danyon Sewell changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 04:38:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 03:38:12 +0000
Subject: [Koha-bugs] [Bug 31675] Remove packages from debian/control that
are no longer used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31675
Danyon Sewell changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #141329|0 |1
is obsolete| |
--- Comment #2 from Danyon Sewell ---
Created attachment 144372
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144372&action=edit
Bug 31675: Remove packages from debian/control that are no longer used
As far as I can tell, we are no longer using CGI::Session::Serialize::YAML or
YAML::Syck, but they are still marked dependencies for the Debian package.
Signed-off-by: Danyon Sewell
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 05:45:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 04:45:17 +0000
Subject: [Koha-bugs] [Bug 28911] Bcrypt settings are required for
pseudonymization but are not set on upgrade
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911
--- Comment #7 from David Cook ---
Created attachment 144373
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144373&action=edit
Example script for koha-conf.xml fixup
This is a script I did that uses a reference koha-conf.xml to update some
configuration, or just generates missing config (like bcrypt_settings -
including comments)
--
I don't think it's particularly robust, so I wouldn't rely on it. I wrote it
for a once-off point in time update.
But maybe it could inspire someone to write a koha-conf.xml upgrade tool.
That said, I don't love the idea of automatically upgrading koha-conf.xml. It
seems a bit dangerous. Although if a backup mechanism is used (like in my
script), then I suppose risk is less as you can always fall back.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:11:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 07:11:05 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
wrong column names (see 32350)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351
--- Comment #25 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #24)
> Pushed to master for 22.11.
>
> Nice work everyone, thanks!
Thx Tomas for your acceleration here :)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:27:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 07:27:37 +0000
Subject: [Koha-bugs] [Bug 32385] New: OPAC and staff (intranet) should not
share the same session and cookie
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32385
Bug ID: 32385
Summary: OPAC and staff (intranet) should not share the same
session and cookie
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Authentication
Assignee: koha-bugs at lists.koha-community.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
CC: dpavlin at rot13.org
See also bug 32369. A login via OPAC should imo not allow you to access staff
too when you share the same domain (and cookies) between them.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:28:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 07:28:22 +0000
Subject: [Koha-bugs] [Bug 32385] OPAC and staff (intranet) should not share
the same session and cookie
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32385
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cslone at camdencountylibrary.
| |org,
| |dcook at prosentient.com.au,
| |jonathan.druart+koha at gmail.
| |com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:28:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 07:28:50 +0000
Subject: [Koha-bugs] [Bug 32369] Two factor authentication can be bypassed
if catalog and staff interface URL aren't properly configured
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32369
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WONTFIX
Status|NEW |RESOLVED
--- Comment #3 from Marcel de Rooy ---
No, this is not a bug. This is design :) It always worked that way already. If
you log in via the OPAC, you have a session (+cookie) that allows you access to
staff too [when having sufficient permissions] when sharing the same domain
between OPAC and staff. So, 2FA works here as expected.
If you do not want that to happen, it is indeed a matter of configuration. Make
sure that OPAC and staff are not using the same domain. They wont share the
cookie, problem solved.
Thats not the final word imo though. We already have reports asking for e.g.
separate timeout settings for OPAC and staff/intranet sessions. We should imo
create a separate OPAC and staff session and session cookie. This probably wont
happen before refactoring/rewriting C4::Auth?
I couldnt find a report for separating the session so quickly, so I opened a
new one. But I think that it must have been submitted already in the past, only
with some other terms or so..
Bug 32385. Closing this one.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:30:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 07:30:09 +0000
Subject: [Koha-bugs] [Bug 32385] OPAC and staff (intranet) should not share
the same session and cookie
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32385
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=32369
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:30:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 07:30:09 +0000
Subject: [Koha-bugs] [Bug 32369] Two factor authentication can be bypassed
if catalog and staff interface URL aren't properly configured
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32369
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=32385
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 08:39:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 07:39:26 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
wrong column names (see 32350)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351
--- Comment #26 from Martin Renvoize ---
Awesome work here, thanks :)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 09:23:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 08:23:09 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
wrong column names
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
|ity.org |
Summary|Fix all TestBuilder calls |Fix all TestBuilder calls
|failing due to wrong column |failing due to wrong column
|names (see 32350) |names
--- Comment #27 from Jonathan Druart ---
Thanks, Tomas!
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 11:22:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 10:22:40 +0000
Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 11:22:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 10:22:44 +0000
Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144226|0 |1
is obsolete| |
--- Comment #3 from Mason James ---
Created attachment 144374
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144374&action=edit
Bug 32349: Remove TEST_QA
There is an env var that we are passing from koha-testing-docker, TEST_QA.
It's used in Koha from a single test file, t/00-testcritic.t.
If not set, no test is run.
Do we really need this? libtest-perl-critic-perl is packaged and automatically
installed.
Signed-off-by: Mason James
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 11:23:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 10:23:16 +0000
Subject: [Koha-bugs] [Bug 32349] Remove TEST_QA
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32349
--- Comment #4 from Mason James ---
(In reply to Jonathan Druart from comment #2)
> Mason, you are the only one this removal could affect. Do you agree with
> this?
hiya, patch looks good to me :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 12:47:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 11:47:52 +0000
Subject: [Koha-bugs] [Bug 29716] [DOCS] Automated screenshots using
Cypress.io testing framework
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29716
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[DOCS] Automated |[DOCS] Automated
|screenshots |screenshots using
| |Cypress.io testing
| |framework
URL|https://gitlab.com/davidnin |https://codeberg.org/davidn
|d/koha-automated-screenshot |ind/koha-automated-screensh
|s |ots
--- Comment #2 from David Nind ---
I've been experimenting with using Cypress.io to generate screenshots - it
seems to work OK.
It uses Node.js and the Cypress.io testing framework library.
See the repository https://codeberg.org/davidnind/koha-automated-screenshots
Just some basic examples for the moment, more to add to more comprehensively
test and generate a wider range of screenshots.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:28:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 12:28:22 +0000
Subject: [Koha-bugs] [Bug 32300] Add page-section to cataloguing plugins
(cat)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32300
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Medium patch
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:28:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 12:28:35 +0000
Subject: [Koha-bugs] [Bug 32300] Add page-section to cataloguing plugins
(cat)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32300
--- Comment #1 from Owen Leonard ---
Created attachment 144375
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144375&action=edit
Bug 32300: Add page-section to cataloguing plugins (cat)
This patch adds a "page-section" container div around the main section
of cataloging plugins which lack it. The patch also adds a "btn
btn-primary" buttons.
This patch contains indentation changes, so please ignore whitespace
when looking at the diff.
These changes are simple enough that checking the diff is probably
enough, but if you want to test a plugin in action, you go to
Administration -> MARC bibliographic framework.
- Choose Actions -> MARC structure on the framework you want to modify
- Choose Actions -> Edit subfields on the tag you want to modify
- Select the tab for the subfield you want to change.
- In the "Other options" section near the bottom, use the "Plugin"
dropdown to select the plugin you want to associate with that
subfield.
- In the basic MARC editor the subfield you updated should now have an
icon next to it for triggering the plugin. Clicking it should trigger
a popup window which shows the updated template.
For plugins with "authorities" in the name, configure the Authorities
structure under Administration -> Authority types.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:28:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 12:28:41 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
column we're not expecting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:29:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 12:29:35 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144347|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:29:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 12:29:39 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144332|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:29:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 12:29:42 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144333|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:30:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 12:30:54 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
--- Comment #14 from Tomás Cohen Arazi ---
Created attachment 144376
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144376&action=edit
Bug 32370: Unit tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:30:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 12:30:59 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
--- Comment #15 from Tomás Cohen Arazi ---
Created attachment 144377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144377&action=edit
Bug 32370: Provide a generic set of tools for JSON fields
This patch introduces a new class for extending Koha::Object-based
classes so they have reusable ways to deal with JSON encoded fields.
As documented in the POD, classes can now
```perl
use base qw(Koha::Object Koha::Object::JSONFields);
```
and will have the following methods available:
* decode_json_field
* set_encoded_json_field
For convenience, the Koha::Auth::Identity::Provider class is tweaked to
make use of this, and also to prove the behavior is correct (expected
results, exceptions, encoding, etc).
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/Koha/Auth/Identity/Provider.t \
t/db_dependent/api/v1/idp.t
=> SUCCESS: Identity provider related tests pass!
2. Apply this patches
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Run the specific tests:
k$ prove t/db_dependent/Koha/Object/JSONField.t
=> SUCCESS: Tests pass!
5. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:31:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 12:31:05 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
--- Comment #16 from Tomás Cohen Arazi ---
Created attachment 144378
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144378&action=edit
Bug 32370: (follow-up) Make Koha::BackgroundJob use Koha::Object::JSONFields
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 13:56:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 12:56:11 +0000
Subject: [Koha-bugs] [Bug 32350] We should die if TestBuilder is passed a
column we're not expecting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32350
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
Version(s)|23.05.00 |23.05.00, 22.11.01
released in| |
--- Comment #37 from Martin Renvoize ---
Thanks everyone, pushing to 22.11.x for 22.11.01.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:04:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 13:04:18 +0000
Subject: [Koha-bugs] [Bug 29274] z_reset.t is wrong
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29274
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |23.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:04:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 13:04:23 +0000
Subject: [Koha-bugs] [Bug 29274] z_reset.t is wrong
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29274
--- Comment #7 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:04:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 13:04:28 +0000
Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups
list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |23.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:04:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 13:04:33 +0000
Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups
list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963
--- Comment #7 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:04:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 13:04:37 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
box for 'Use default values'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |23.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:04:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 13:04:42 +0000
Subject: [Koha-bugs] [Bug 32236] Batch item modification - alignment of tick
box for 'Use default values'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32236
--- Comment #7 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:04:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 13:04:46 +0000
Subject: [Koha-bugs] [Bug 32366] BatchDeleteBiblio task should have tests to
prove indexing all takes place in one step
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32366
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |23.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:04:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 13:04:50 +0000
Subject: [Koha-bugs] [Bug 32366] BatchDeleteBiblio task should have tests to
prove indexing all takes place in one step
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32366
--- Comment #4 from Tomás Cohen Arazi ---
Pushed to master for 23.05.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:10:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 13:10:55 +0000
Subject: [Koha-bugs] [Bug 32386] New: Record Matching rules not being created
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32386
Bug ID: 32386
Summary: Record Matching rules not being created
Change sponsored?: ---
Product: Koha
Version: 22.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: manishalibtech at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
Created attachment 144379
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144379&action=edit
error 500
Creating new record matching rules is not working. Getting error 500 at
attached.
Even editing the sample record matching rules is not working.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:24:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 13:24:05 +0000
Subject: [Koha-bugs] [Bug 28756] Select values by exclusion in facets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28756
Aude Charillon changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |aude.charillon at ptfs-europe.
| |com
Resolution|--- |DUPLICATE
--- Comment #1 from Aude Charillon ---
Duplicate of Bug 27678 - Add option to exclude facets in search results
*** This bug has been marked as a duplicate of bug 27678 ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 14:24:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 13:24:05 +0000
Subject: [Koha-bugs] [Bug 27678] Add option to exclude facets in search
results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27678
Aude Charillon changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mathsabypro at gmail.com
--- Comment #1 from Aude Charillon ---
*** Bug 28756 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 15:10:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 14:10:46 +0000
Subject: [Koha-bugs] [Bug 32369] Two factor authentication can be bypassed
if catalog and staff interface URL aren't properly configured
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32369
--- Comment #4 from Chris Slone ---
Fair enough, just wanted make sure it was known if it wasn't already. Sounds
good on the new bug about the session cookies.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 15:25:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 14:25:11 +0000
Subject: [Koha-bugs] [Bug 27678] Add option to exclude facets in search
results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27678
Susan changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |susan.merner at nhs.net
--- Comment #2 from Susan ---
I would find this a useful feature and it would help save time in viewing
results. Normally we would want in search results (on Catalogue in KOHA Staff
interface) to see Books and Ebooks. We would not want to see ILL Journals, ILL
Ebooks, On Order. as none of those are available to borrow.
Tick boxes beside each item would help to determine what to include/exclude.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 16:10:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 15:10:40 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Hammat wele changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144336|0 |1
is obsolete| |
--- Comment #151 from Hammat wele ---
Created attachment 144380
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144380&action=edit
This patch adds 'XSL-Simple Export' when saving a bibliographic record
To test:
1) Search for a record in the intranet.
2) Click on the 'Save' button and observe the dropdown menu.
3) Notice that 'XSL- Simple Export' is not in the menu.
4) Apply the patch.
5) In System preferences search for OpacExportOptions and enable XSL
6) Repeat the steps 1 and 2.
7) Notice that 'XSL - Simple Export' is in the menu.
8) Click on 'XSL - Simple Export'. A .html file should be downloaded.
9) Open the .html file. You should see the record's informations.
10) Add some items to your Cart
11) Open the Cart
12) Click on the 'Download' button and observe the dropdown menu.
13) Notice that 'XSL - Simple Export' is in the menu.
14) Click on 'XSL - Simple Export'. A .html file should be downloaded.
15) Open the .html file. You should see the record's informations.
16) Add some items to a List
17) Open the List
18) Click on the 'Download' button and observe the dropdown menu.
19) Notice that 'XSL - Simple Export' is in the menu.
20) Click on 'XSL - Simple Export'. A .html file should be downloaded.
21) Open the .html file. You should see the record's informations.
22) Do the same steps in OPAC
23) In System preferences search for OpacExportOptions and disable XSL
24) Repeat all steps
25) Notice that 'XSL - Simple Export' is no more in the menus.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 16:48:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 15:48:03 +0000
Subject: [Koha-bugs] [Bug 32387] New: "Image from Amazon.com" displayed even
if AmazonLocale is not set to american
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32387
Bug ID: 32387
Summary: "Image from Amazon.com" displayed even if AmazonLocale
is not set to american
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Staff interface
Assignee: koha-bugs at lists.koha-community.org
Reporter: caroline.cyr-la-rose at inlibro.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
I noticed that, in the record details in the staff interface, the message under
the amazon cover image is "Image from Amazon.com" even when AmazonLocale is set
to another site than american. The message should either be "Image from Amazon"
for all locales, or the message should change depending on the locale.
To test:
Note: I attached a file of sample records that I use for various image sources,
you can import this file into Koha, if needed
- Download the attached marc file (coverimages.mrc)
- In the Koha staff interface, go to Cataloging > Stage records for
import
- Click the "Choose file" or "Browse" button and choose the downloaded
file
- Click "Upload file"
- Click "Stage for import"
- Click "View detail of the enqueued job"
- Click "View batch"
- Click "Import this batch into the catalog"
1. Enable AmazonCoverImages
1.1. Go to Administration > Global system preferences
1.2. Search for Amazon
1.3. Select "Show" in AmazonCoverImages
1.4. Click "Save all Enhanced content preferences"
2. Set AmazonLocale to canadian (or other locale than american)
2.1. Select "Canadian" in AmazonLocale
2.2. Click "Save all Enhanced content preferences"
3. If using the attached records, search the catalog for "Two gentlemen of
Verona";
if not using the file, search for a record with an ISBN than has an image on
Amazon.ca (or chosen locale)
--> Note that under the image, it says simply "Amazon cover image", this is
ok
4. Click on the title that has an image from Amazon to access the detailed
record
--> In the image box, notice that it says "Image from Amazon.com" even if
AmazonLocale is set to Canadian
5. Click on the image
--> Note that under the image, it says simply "Amazon cover image", this is
ok
Maybe we could use the same message ("Amazon cover image") everywhere?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:13:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 16:13:30 +0000
Subject: [Koha-bugs] [Bug 32387] "Image from Amazon.com" displayed even if
AmazonLocale is not set to american
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32387
--- Comment #1 from Caroline Cyr La Rose ---
Created attachment 144381
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144381&action=edit
Sample records
Oops, I had forgotten the sample records file!
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:17:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 16:17:28 +0000
Subject: [Koha-bugs] [Bug 32388] New: "Image from Amazon.com" displayed even
if AmazonLocale is not set to american (OPAC)
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32388
Bug ID: 32388
Summary: "Image from Amazon.com" displayed even if AmazonLocale
is not set to american (OPAC)
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: caroline.cyr-la-rose at inlibro.com
QA Contact: testopia at bugs.koha-community.org
This is the same as bug 32387 but for the OPAC.
In the records details in the OPAC, the message under the amazon cover image is
"Image from Amazon.com" even when AmazonLocale is set to another site than
american.
To test:
Note: I attached a file of sample records that I use for various image sources,
you can import this file into Koha, if needed
- Download the attached marc file (coverimages.mrc)
- In the Koha staff interface, go to Cataloging > Stage records for
import
- Click the "Choose file" or "Browse" button and choose the downloaded
file
- Click "Upload file"
- Click "Stage for import"
- Click "View detail of the enqueued job"
- Click "View batch"
- Click "Import this batch into the catalog"
1. Enable AmazonCoverImages
1.1. Go to Administration > Global system preferences
1.2. Search for Amazon
1.3. Select "Show" in AmazonCoverImages
1.4. Click "Save all Enhanced content preferences"
2. Set AmazonLocale to canadian (or other locale than american)
2.1. Select "Canadian" in AmazonLocale
2.2. Click "Save all Enhanced content preferences"
3. If using the attached records, search the OPAC for "Two gentlemen of
Verona";
if not using the file, search for a record with an ISBN than has an image on
Amazon.ca (or chosen locale)
4. Click on the title that has an image from Amazon to access the detailed
record
--> In the image box, notice that it says "Image from Amazon.com" even if
AmazonLocale is set to Canadian
5. Click on the image
--> Note that under the image, it says simply "Amazon cover image", this is
ok
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:17:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 16:17:54 +0000
Subject: [Koha-bugs] [Bug 32388] "Image from Amazon.com" displayed even if
AmazonLocale is not set to american (OPAC)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32388
--- Comment #1 from Caroline Cyr La Rose ---
Created attachment 144382
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144382&action=edit
Sample records
File with sample records
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:18:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 16:18:05 +0000
Subject: [Koha-bugs] [Bug 32387] "Image from Amazon.com" displayed even if
AmazonLocale is not set to american
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32387
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=32388
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:18:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 16:18:05 +0000
Subject: [Koha-bugs] [Bug 32388] "Image from Amazon.com" displayed even if
AmazonLocale is not set to american (OPAC)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32388
Caroline Cyr La Rose changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=32387
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:41:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 16:41:36 +0000
Subject: [Koha-bugs] [Bug 32325] Valid 006/00 values should not depend on
Type of Material selection
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32325
Heather changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |heather_hernandez at nps.gov
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 17:55:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 16:55:12 +0000
Subject: [Koha-bugs] [Bug 26482] Add macros ability to basic editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26482
Heather changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |heather_hernandez at nps.gov
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:33:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 17:33:35 +0000
Subject: [Koha-bugs] [Bug 32389] New: Syndetics links are built wrong on the
staff results page
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389
Bug ID: 32389
Summary: Syndetics links are built wrong on the staff results
page
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Tools
Assignee: koha-bugs at lists.koha-community.org
Reporter: lucas at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
TO recreate:
1. Have SyndeticsCoverImages on and Syndetics setup.
2. Do a search that will return some results with Syndetics images
3. Click on the image link and you will get a 404
4. Notice the page you are being directed to is something like:
http://localhost:8081/cgi-bin/koha/catalogue/?biblionumber=117
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:33:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 17:33:43 +0000
Subject: [Koha-bugs] [Bug 32389] Syndetics links are built wrong on the
staff results page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:39:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 17:39:41 +0000
Subject: [Koha-bugs] [Bug 32389] Syndetics links are built wrong on the
staff results page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389
--- Comment #1 from Lucas Gass ---
We are attempting to pass in this template variable: [% DetailPage | url %]
I can't find this anywhere else in the codebase, so maybe we should just
hardcode this bit?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:43:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 17:43:05 +0000
Subject: [Koha-bugs] [Bug 32389] Syndetics links are built wrong on the
staff results page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:43:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 17:43:08 +0000
Subject: [Koha-bugs] [Bug 32389] Syndetics links are built wrong on the
staff results page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389
--- Comment #2 from Lucas Gass ---
Created attachment 144383
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144383&action=edit
Bug 32389: Fix Syndetics link on staff results page
To test:
1. Have SyndeticsCoverImages on and Syndetics setup.
2. Do a search that will return some results with Syndetics images
3. Click on the image link and you will get a 404
4. Apply patch
5. Link works!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 18:47:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 17:47:28 +0000
Subject: [Koha-bugs] [Bug 32389] Syndetics links are built wrong on the
staff results page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 19:17:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 18:17:09 +0000
Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699
Suzanne changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |smhodson123extra at yahoo.com
--- Comment #12 from Suzanne ---
Thank you so much for the quick help and work on this! Looking forward to it!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 19:57:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 18:57:58 +0000
Subject: [Koha-bugs] [Bug 32275] Fill blank record in basic editor using
ISBN with Google Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32275
Lauren Denny changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lauren_denny at sil.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 19:58:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 18:58:25 +0000
Subject: [Koha-bugs] [Bug 31742] Highlight logged-in library holdings on
add/edit items screen (additem.pl)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31742
Lauren Denny changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lauren_denny at sil.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 19:58:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 18:58:37 +0000
Subject: [Koha-bugs] [Bug 26482] Add macros ability to basic editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26482
Lauren Denny changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lauren_denny at sil.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 20:50:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 19:50:51 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Hammat wele changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hammat.wele at inlibro.com
Attachment #141160|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 20:52:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 19:52:34 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Hammat wele changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #141161|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 20:53:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 19:53:31 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Hammat wele changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #141163|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 20:54:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 19:54:01 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Hammat wele changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #141164|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 20:59:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 19:59:46 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Hammat wele changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #141162|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 21:13:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 20:13:49 +0000
Subject: [Koha-bugs] [Bug 32390] New: Allow one to set an override value for
CSVDelimiter per report
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32390
Bug ID: 32390
Summary: Allow one to set an override value for CSVDelimiter
per report
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Reports
Assignee: koha-bugs at lists.koha-community.org
Reporter: andrewfh at dubcolib.org
QA Contact: testopia at bugs.koha-community.org
The syspref CSVDelimiter allows one to pick a delimiter to be used when
exporting CSV results for all reports. Based on the data included and the
intended use, different reports require different delimiters.
It would be helpful to add the field saved_sql.delimiter and save an optional
delimiter value for each report. Reports could default to following the syspref
but allow one to select an alternate value when saving/editing a report.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:19:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 21:19:48 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Hammat wele changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144380|0 |1
is obsolete| |
--- Comment #152 from Hammat wele ---
Created attachment 144384
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144384&action=edit
This patch adds 'XSL-Simple Export' when saving a bibliographic record
To test:
1) Search for a record in the intranet.
2) Click on the 'Save' button and observe the dropdown menu.
3) Notice that 'XSL- Simple Export' is not in the menu.
4) Apply the patch.
5) In System preferences search for OpacExportOptions and enable XSL
6) Repeat the steps 1 and 2.
7) Notice that 'XSL - Simple Export' is in the menu.
8) Click on 'XSL - Simple Export'. A .html file should be downloaded.
9) Open the .html file. You should see the record's informations.
10) Add some items to your Cart
11) Open the Cart
12) Click on the 'Download' button and observe the dropdown menu.
13) Notice that 'XSL - Simple Export' is in the menu.
14) Click on 'XSL - Simple Export'. A .html file should be downloaded.
15) Open the .html file. You should see the record's informations.
16) Add some items to a List
17) Open the List
18) Click on the 'Download' button and observe the dropdown menu.
19) Notice that 'XSL - Simple Export' is in the menu.
20) Click on 'XSL - Simple Export'. A .html file should be downloaded.
21) Open the .html file. You should see the record's informations.
22) Do the same steps in OPAC
23) In System preferences search for OpacExportOptions and disable XSL
24) Repeat all steps
25) Notice that 'XSL - Simple Export' is no more in the menus.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:51:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 21:51:58 +0000
Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245
subfields in search results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911
--- Comment #4 from Lucas Gass ---
Like Katrin said, bcnp are easy because they are now DB fields.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:52:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 21:52:19 +0000
Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245
subfields in search results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |lucas at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 21:59:49 +0000
Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245
subfields in search results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 22:59:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 21:59:54 +0000
Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245
subfields in search results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911
--- Comment #5 from Lucas Gass ---
Created attachment 144385
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144385&action=edit
Bug 14911: Add 245 fields to itemsearch title column
To test:
1. Have some records that have these 245 fields:
-Title 245$a
-Subtitle 245$b
-Medium 245$h
-Part number 245$n
-Part name 245$p
Note: IN KTD I have to run batchRebuildBiblioTables.pl -c
2. Apply patch and do an item search that will turn up items with the 245
fields lists above
3. Notice that those subfields are now included in the title column.
I added them in this manner because it seemed right to be:
-Subfield, included in the title link
-Medium
-Part number
-Part name
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:03:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 22:03:22 +0000
Subject: [Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:08:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 22:08:02 +0000
Subject: [Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375
--- Comment #4 from Lucas Gass ---
Hey all,
I am having trouble making t/AuthoritiesMarc_MARC21.t fail on my 22.05.x
branch.
Maybe I missing a specific configuration that will make this fail?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:21:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 22:21:06 +0000
Subject: [Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375
--- Comment #5 from wainuiwitikapark at catalyst.net.nz ---
(In reply to Lucas Gass from comment #4)
> Hey all,
>
> I am having trouble making t/AuthoritiesMarc_MARC21.t fail on my 22.05.x
> branch.
>
> Maybe I missing a specific configuration that will make this fail?
Hi Lucas,
Can you start mysql and see if it fails then?
Thanks
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:21:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 22:21:20 +0000
Subject: [Koha-bugs] [Bug 32381] Koha should be able to receive and record
reasons for failed SMS notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32381
Christopher Brannon changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cbrannon at cdalibrary.org
--- Comment #1 from Christopher Brannon ---
Yes, I agree. This would be extremely helpful.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:25:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 22:25:34 +0000
Subject: [Koha-bugs] [Bug 32300] Add page-section to cataloguing plugins
(cat)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32300
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:25:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 22:25:42 +0000
Subject: [Koha-bugs] [Bug 32300] Add page-section to cataloguing plugins
(cat)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32300
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144375|0 |1
is obsolete| |
--- Comment #2 from Lucas Gass ---
Created attachment 144386
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144386&action=edit
Bug 32300: Add page-section to cataloguing plugins (cat)
This patch adds a "page-section" container div around the main section
of cataloging plugins which lack it. The patch also adds a "btn
btn-primary" buttons.
This patch contains indentation changes, so please ignore whitespace
when looking at the diff.
These changes are simple enough that checking the diff is probably
enough, but if you want to test a plugin in action, you go to
Administration -> MARC bibliographic framework.
- Choose Actions -> MARC structure on the framework you want to modify
- Choose Actions -> Edit subfields on the tag you want to modify
- Select the tab for the subfield you want to change.
- In the "Other options" section near the bottom, use the "Plugin"
dropdown to select the plugin you want to associate with that
subfield.
- In the basic MARC editor the subfield you updated should now have an
icon next to it for triggering the plugin. Clicking it should trigger
a popup window which shows the updated template.
For plugins with "authorities" in the name, configure the Authorities
structure under Administration -> Authority types.
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu Dec 1 23:39:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 01 Dec 2022 22:39:20 +0000
Subject: [Koha-bugs] [Bug 32381] Koha should be able to receive and record
reasons for failed SMS notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32381
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 01:26:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 00:26:08 +0000
Subject: [Koha-bugs] [Bug 32382] Fund input misaligned on invoice summary
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 01:26:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 00:26:12 +0000
Subject: [Koha-bugs] [Bug 32382] Fund input misaligned on invoice summary
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382
--- Comment #1 from Lucas Gass ---
Created attachment 144387
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144387&action=edit
Bug 32382: Fix alignment on invoice summary page
To test:
1. Apply patch
2. Have some funds from budgets that are both active and inactive
3. Receive a basket and click 'Finish receiving' to get to the invoice page
4. Look at the Fund/Show inactive line and make sure it is aligned right
5. With some inactive funds click 'Show inactive' and make sure they appear in
this dropdown
6. Click 'Add an adjustment'. Make sure the Fund/Show inactive line looks
correct there as well/
7. Make an adjustment and click 'Update adjustments' make sure the line also
looks right in the table that appears.
8. Inside that table make sure you can click the 'Show inactive' checkbox and
the inactive budgets appears.
Note: Some of the HTML was ouside of the HTML body, so I moved it into the HTML
body so it will be valid.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 01:26:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 00:26:31 +0000
Subject: [Koha-bugs] [Bug 32382] Fund input misaligned on invoice summary
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
|ity.org |
CC| |lucas at bywatersolutions.com
Severity|enhancement |normal
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 01:29:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 00:29:03 +0000
Subject: [Koha-bugs] [Bug 32382] Fund input misaligned on invoice summary
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32382
--- Comment #2 from Lucas Gass ---
Maybe this is for another bug but we build an HTML element called
'all_fund_dropdown'. This is never actually shown, we just use the inner HTML
to build all the other '.fund_dropdown' dropdowns on the page.
Would it not be better to handle that all with JS?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:07:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 01:07:43 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
identity provider
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
--- Comment #5 from David Cook ---
Currently testing this and using the following to point to the Keycloak
provided by my customized docker-compose.sso.yml
http://host.docker.internal:8082/realms/test/.well-known/openid-configuration
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:10:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 01:10:50 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
identity provider
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
--- Comment #6 from David Cook ---
(In reply to David Cook from comment #5)
> Currently testing this and using the following to point to the Keycloak
> provided by my customized docker-compose.sso.yml
>
> http://host.docker.internal:8082/realms/test/.well-known/openid-configuration
Note that this is me using Docker Desktop on Windows, so your mileage may
vary...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:16:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 01:16:45 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
identity provider
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:16:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 01:16:51 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
identity provider
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144274|0 |1
is obsolete| |
--- Comment #7 from David Cook ---
Created attachment 144388
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144388&action=edit
Bug 32354: Accept session_state param given by OAuth IdP
This patch ensures Koha doesn't throw an error if the IdP hands back a
session_state parameter.
To test:
1) Set up an identity provider
2) On the IdP's configuration, make it hand back a session_state
3) Confirm authentication using OIDC works with and without the
session_state
Sponsored-by: Plant & Food Research
Signed-off-by: David Cook
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:18:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 01:18:30 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
identity provider
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
--- Comment #8 from Tomás Cohen Arazi ---
(In reply to David Cook from comment #5)
> Currently testing this and using the following to point to the Keycloak
> provided by my customized docker-compose.sso.yml
>
> http://host.docker.internal:8082/realms/test/.well-known/openid-configuration
The one in KTD, documented in the README should be usable as well.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:22:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 01:22:57 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
identity provider
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
--- Comment #9 from David Cook ---
I'm happy with this patch. If anyone needs help QAing this or wants to add
their signoff and count mine towards QA, just let me know...
--
Out of scope side note:
It doesn't look like /oauth/login/{provider_code}/{interface} actually gets
used. It looks like the staff interface uses the
/public/oauth/login/{provider_code}/{interface} endpoint same as the OPAC. I
don't know whether or not this is by design. Agustin and Tomas might be able to
clarify that one...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:25:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 01:25:30 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
identity provider
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
--- Comment #10 from David Cook ---
(In reply to Tomás Cohen Arazi from comment #8)
> The one in KTD, documented in the README should be usable as well.
That's true. I don't like meddling with my /etc/hosts too much but maybe I
should just for the sake of consistency with other KTD users...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:29:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 01:29:57 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
identity provider
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
--- Comment #11 from David Cook ---
(In reply to Tomás Cohen Arazi from comment #8)
> The one in KTD, documented in the README should be usable as well.
Hmmm that doesn't seem to work, since on the workstation it's sso:8082 but in
koha-testing-docker it's sso:8080
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:31:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 01:31:02 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
identity provider
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
--- Comment #12 from David Cook ---
(In reply to David Cook from comment #11)
> Hmmm that doesn't seem to work, since on the workstation it's sso:8082 but
> in koha-testing-docker it's sso:8080
Ah, I'm using an old docker-compose.sso.yml. Nevermind me ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 02:44:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 01:44:06 +0000
Subject: [Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375
--- Comment #6 from Chris Cormack ---
Thats right you have to have no db, so if you stop mariadb, or mysqlserver and
run it will fail.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 03:00:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 02:00:34 +0000
Subject: [Koha-bugs] [Bug 32354] Handle session_state param given by OAuth
identity provider
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32354
--- Comment #13 from David Cook ---
Pulled the latest koha-testing-docker and the http://sso:8082/auth/ URL works
well, so a "test" realm would be
http://sso:8082/auth/realms/test/.well-known/openid-configuration
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 03:25:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 02:25:50 +0000
Subject: [Koha-bugs] [Bug 31897] New hook when indexing with Elasticsearch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31897
--- Comment #15 from Fridolin Somers ---
Ah we should give to the plugin the index name 'biblios' or 'authorities'.
Maybe with $self->index.
> a plugin can change the record so that it better suits the index
In this case we may better hook in
Koha::SearchEngine::Elasticsearch::marc_records_to_documents().
There already is feature for ISBN forms and IncludeSeeFromInSearches.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:37:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 07:37:26 +0000
Subject: [Koha-bugs] [Bug 32391] New: Reorganise the manual contents
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391
Bug ID: 32391
Summary: Reorganise the manual contents
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Documentation
Assignee: koha-bugs at lists.koha-community.org
Reporter: david at davidnind.com
QA Contact: testopia at bugs.koha-community.org
The contents of the manual need reorganising/restructuring.
Currently, the contents is a long list of modules/features/topics in a
randomish order.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 08:37:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 07:37:53 +0000
Subject: [Koha-bugs] [Bug 32391] Reorganise the manual contents
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |david at davidnind.com
|ity.org |
Priority|P5 - low |P1 - high
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:22:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 08:22:45 +0000
Subject: [Koha-bugs] [Bug 32305] Background worker doesn't check jobs
receive from rabbitmq are in 'new' state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305
--- Comment #6 from Martin Renvoize ---
I think Jonathans approach is the right way to go..
Though I must admit, I found it confusing when looking at the 'start' helper
method too.. that already checks status and throws an exception if the status
isn't new.
Having both 'process' and 'start' methods is a tad confusing.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:24:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 08:24:05 +0000
Subject: [Koha-bugs] [Bug 32305] Background worker doesn't check jobs
receive from rabbitmq are in 'new' state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305
--- Comment #7 from Martin Renvoize ---
Created attachment 144389
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144389&action=edit
Bug 32305: Don't process a job if its status is not 'new'
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:25:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 08:25:05 +0000
Subject: [Koha-bugs] [Bug 32330] Table background_jobs is missing indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144186|0 |1
is obsolete| |
--- Comment #4 from Martin Renvoize ---
Created attachment 144390
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144390&action=edit
Bug 32330: Add indexes to table background_jobs
Table background_jobs should have indexes to optimize queries.
Query on borrowernumber :
mainpage.pl: my $already_ran_jobs = Koha::BackgroundJobs->search(
mainpage.pl- { borrowernumber => $logged_in_user->borrowernumber }
)->count ? 1 : 0;
Query on status and queue :
misc/background_jobs_worker.pl: my $jobs =
Koha::BackgroundJobs->search({ status => 'new', queue => \@queues });
Test plan :
Run updatedatabase and play with background jobs
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:25:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 08:25:17 +0000
Subject: [Koha-bugs] [Bug 32330] Table background_jobs is missing indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:25:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 08:25:34 +0000
Subject: [Koha-bugs] [Bug 32330] Table background_jobs is missing indexes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32330
--- Comment #5 from Martin Renvoize ---
Good call
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:27:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 08:27:26 +0000
Subject: [Koha-bugs] [Bug 32305] Background worker doesn't check jobs
receive from rabbitmq are in 'new' state
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32305
--- Comment #8 from Martin Renvoize ---
Should we force a refetch from the DB just prior to checking this status.. just
in case we have a stale object?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:28:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 08:28:48 +0000
Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943
--- Comment #7 from Martin Renvoize ---
OK.. I think this patchset if solid as is if we push the process fix first that
checks for status...
Having both process and start methods is slightly confusing at first ;P
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 09:32:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 08:32:56 +0000
Subject: [Koha-bugs] [Bug 32391] Reorganise the manual contents
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #1 from David Nind ---
Here is a rough outline of what I am thinking about.
Tasks:
- Fine tune the revised contents/structure
- Make available in a shared document for comments/interactive feedback
- Reorganise the index page for feedback (make available as a static site)
Potentially each of the sections could be separate guides, rather than one big
manual, with the contents page organising and linking these together.
Initial focus would be on reorganising the contents, and then later
reorganising content in individual sections/chapters/guides where required -
including adding new sections.
Revised contents outline, with notes
====================================
Using this manual/documentation [about the documentation and how it is
organised]
- Conventions
- Change log [quick notes on what has changed in the documentation, for example
a new guide on a new feature added]
What's new in Koha [more user-friendly 'release' notes]
Koha overview [brief introduction to Koha - key features, modules and tools;
the community]
Getting help
Part X - Getting started [brief outline of process to consider when
implementing, with links to more detailed information/guides/tutorials]
- Implementation [including links to the checklists]
- Data migration
- Installation
- System setup and configuration
- System administration [including managing upgrades]
Part X - Using Koha [sections/chapters/guides on each of the modules, tools and
other features - not sure of the best way to group or organise this yet]
- Finding your way around [getting familiar with the OPAC and staff interface]
- Searching [may be an advanced search guide as well?]
- Patron guide to using the OPAC
- The core modules:
. Circulation
. Patrons
. Cataloging
. Authorities [combine with cataloguing?]
. Serials
. Acquisitions
. Reports
....
- Other modules, features, and tools [not sure how to group yet]
. Course reserves
. ERM
. Interlibrary loans
. Lists
. News
. Notices and slips
. Patrons
. Point of sale
....
- Enhanced content, integration, and web services [separate sections or part of
above topics where appropriate]
- Customising the OPAC and staff interface
. Look and feel [theming]
. JavaScript and CSS
Part X - Implementation guide
Part X - Data migration guide [getting your data into Koha]
Part X - Installation guide
Part X - System setup and configuration
- Using languages other than English
Part X - System administration
- Backups
- Security
- Scheduled jobs [cron jobs]
- Search engines
- Upgrades
Part X - System preferences [Reference]
Part X - Cron jobs [Reference]
Part X - Package commands [Reference]
Index
Glossary
License information
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:12:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 09:12:43 +0000
Subject: [Koha-bugs] [Bug 32392] New: Ability to skip forward serial issues
when receiving double (or more) issue
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392
Bug ID: 32392
Summary: Ability to skip forward serial issues when receiving
double (or more) issue
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Serials
Assignee: koha-bugs at lists.koha-community.org
Reporter: bjorn.nylen at ub.lu.se
QA Contact: testopia at bugs.koha-community.org
When an unexpected double issue is received there needs to be an easy way to
skip forward to generate the next expected issue. Eg I receive no 6/7 so the
next generated issue should be No 8 rather than having to generate No 7 and 8
and then delete No 7.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 10:23:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 09:23:37 +0000
Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when
receiving double (or more) issue
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392
Björn Nylén changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |bjorn.nylen at ub.lu.se
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:41:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 10:41:31 +0000
Subject: [Koha-bugs] [Bug 31381] Searching patrons by letter broken when
using non-mandatory extended attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31381
Jacob O'Mara changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jacob.omara at ptfs-europe.com
Status|Pushed to master |Pushed to stable
Version(s)|23.05.00 |23.05.00, 22.11.01
released in| |
--- Comment #22 from Jacob O'Mara ---
Nice work! Pushed to 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:48:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 10:48:48 +0000
Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority
targets like for bibliographic targets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220
--- Comment #17 from Filippos Kolovos ---
Dear Fridolin Goodmorning,
As far as I am concerned, I have tested it in branches 20.x and 21.x and it
works as expected.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:50:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 10:50:28 +0000
Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:50:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 10:50:32 +0000
Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334
--- Comment #1 from Marcel de Rooy ---
Created attachment 144391
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144391&action=edit
Bug 32334: Exceptions - Add parameter to WrongParameter
Test plan:
Run t/Koha/Exceptions.t
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:50:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 10:50:36 +0000
Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334
--- Comment #2 from Marcel de Rooy ---
Created attachment 144392
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144392&action=edit
Bug 32334: Add general exception FileNotFound
No test plan.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:50:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 10:50:40 +0000
Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334
--- Comment #3 from Marcel de Rooy ---
Created attachment 144393
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144393&action=edit
Bug 32334: Introduce Koha::Database::Commenter
Test plan:
[1] Make a backup of your database. Just for precaution.
[2] Run t/db_dependent/Koha/Database/Commenter.t.
* Note: This test script adds and removes a test table.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:50:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 10:50:44 +0000
Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334
--- Comment #4 from Marcel de Rooy ---
Created attachment 144394
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144394&action=edit
Bug 32334: Add sync_db_comments script
Test plan:
[1] Backup your database, if not done already.
[2] Check output of dry_run when clearing a table:
misc/maintenance/sync_db_comments.pl -clear -table items -dry
[3] Save output of misc/devel/update_dbix_class_files before changing
comments in order to compare later. (Commit your changes.)
You may not have changes after running (at least on a fresh
database). That's fine.
[4] Clear all comments:
misc/maintenance/sync_db_comments.pl -clear
[5] Renumber all comments:
misc/maintenance/sync_db_comments.pl -renum
[6] Reset all comments to schema. Make sure that script finds your
structure in installer/data/mysql folder.
misc/maintenance/sync_db_comments.pl -reset
[7] Run update_dbix_class_files again and inspect changes as compared
to previous run.
Can you explain them? You should only see changes related to
column comments. If you did not have changes in step 3, you
should not have them here too.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:56:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 10:56:52 +0000
Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com, tomascohen at gmail.com
--- Comment #5 from Marcel de Rooy ---
A few excerpts from the POD of the new module and script:
===
SYNOPSIS
perl sync_db_comments.pl [-h] [-v] [-database DB_NAME] [-table
TABLE_NAME] [-dry_run] [-clear|-reset|-renumber]
Synchronize column comments in database with Koha schema. Allows you
to clear comments too. Operates additionally on specific tables only.
And provides a dry run mode that prints sql statements.
This script may prove helpful to track synchronization issues between
Koha schema and actual database structure due to inconsistencies in
database revisions. It reduces the noise from missing column comments
when running script update_dbix_class_files.pl.
and
The advantage of keeping in sync is that you can easily track
differences
between schema and database with the maintenance script
update_dbix_class_files.pl.
===
Yes, it adds another module. But keeping track of schema issues is imo
important enough. The noise of missing or changed comments can be handled in
various ways. This approach was the most practical one for me in the end.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 11:57:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 10:57:53 +0000
Subject: [Koha-bugs] [Bug 32351] Fix all TestBuilder calls failing due to
wrong column names
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32351
Jacob O'Mara changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to master |Pushed to stable
CC| |jacob.omara at ptfs-europe.com
Version(s)|23.05.00 |23.05.00, 22.11.01
released in| |
--- Comment #28 from Jacob O'Mara ---
Nice work! Pushed to 22.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:05:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 11:05:15 +0000
Subject: [Koha-bugs] [Bug 32074] Edit vendor has a floating toolbar,
but still an additional save button at the bottom
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074
--- Comment #1 from Matt Blenkinsop ---
Created attachment 144395
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144395&action=edit
Bug 32074: Edit vendor has two save buttons
When editing a vendor there is a floating toolbar with options to save and
cancel. There is also an additional save and cancel button set at the bottom of
the page and this is superfluous. This has now been removed to leave the
floating toolbar as the only toolbar.
Test plan:
1) Navigate to Acquisitions and select a Vendor.
2) Click edit vendor
3) Scroll down the page and observe that there is a floating save/cancel
toolbar as well as the buttons to save/cancel at the bottom of the page
4) Apply patch
5) Observe that the duplicate buttons at the bottom of the page are now gone
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:07:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 11:07:09 +0000
Subject: [Koha-bugs] [Bug 32074] Edit vendor has a floating toolbar,
but still an additional save button at the bottom
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074
Matt Blenkinsop changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
CC| |matt.blenkinsop at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:45:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 11:45:30 +0000
Subject: [Koha-bugs] [Bug 32381] Koha should be able to receive and record
reasons for failed SMS notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32381
Emmi Takkinen changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |emmi.takkinen at koha-suomi.fi
--- Comment #2 from Emmi Takkinen ---
Could this be a duplicate of bug 31481?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 12:59:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 11:59:57 +0000
Subject: [Koha-bugs] [Bug 30943] Make background job classes use helpers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30943
--- Comment #8 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #7)
> OK.. I think this patchset if solid as is if we push the process fix first
> that checks for status...
>
> Having both process and start methods is slightly confusing at first ;P
I agree the terminology is confusing. But they are really different things, as
->process is really the overloaded method in the job class, and ->start is just
marking the task as started. i.e. if we rename process => start, we will still
want a (say) ->mark_started method that does what this method does.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:18:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:18:23 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Hammat wele changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:18:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:18:25 +0000
Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245
subfields in search results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #6 from Owen Leonard ---
I think biblio-title.inc should be used here instead
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:21:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:21:28 +0000
Subject: [Koha-bugs] [Bug 32074] Edit vendor has a floating toolbar,
but still an additional save button at the bottom
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:21:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:21:33 +0000
Subject: [Koha-bugs] [Bug 32074] Edit vendor has a floating toolbar,
but still an additional save button at the bottom
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144395|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 144396
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144396&action=edit
Bug 32074: Edit vendor has two save buttons
When editing a vendor there is a floating toolbar with options to save
and cancel. There is also an additional save and cancel button set at
the bottom of the page and this is superfluous. This has now been
removed to leave the floating toolbar as the only toolbar.
Test plan:
1) Navigate to Acquisitions and select a Vendor.
2) Click edit vendor
3) Scroll down the page and observe that there is a floating
save/cancel toolbar as well as the buttons to save/cancel at the
bottom of the page
4) Apply patch
5) Observe that the duplicate buttons at the bottom of the page are now
gone
Signed-off-by: Owen
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:21:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:21:41 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Hammat wele changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:32:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:32:40 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
Hammat wele changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:39:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:39:15 +0000
Subject: [Koha-bugs] [Bug 32389] Syndetics links are built wrong on the
staff results page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:39:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:39:21 +0000
Subject: [Koha-bugs] [Bug 32389] Syndetics links are built wrong on the
staff results page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144383|0 |1
is obsolete| |
--- Comment #3 from Owen Leonard ---
Created attachment 144397
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144397&action=edit
Bug 32389: Fix Syndetics link on staff results page
To test:
1. Have SyndeticsCoverImages on and Syndetics setup.
2. Do a search that will return some results with Syndetics images
3. Click on the image link and you will get a 404
4. Apply patch
5. Link works!
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:40:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:40:54 +0000
Subject: [Koha-bugs] [Bug 32389] Syndetics links are built wrong on the
staff results page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32389
--- Comment #4 from Owen Leonard ---
Signed off based on the content of the patch even though I don't have Syndetics
credentials to test live.
I suspect the origin of this bug was some variation on handling the
BiblioDefaultView system preference.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:56:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:56:31 +0000
Subject: [Koha-bugs] [Bug 31490] Terminology: change "staff client" to
"staff interface" in marc-overlay-rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31490
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|oleonard at myacpl.org |caroline.cyr-la-rose at inlibr
| |o.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:59:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:59:22 +0000
Subject: [Koha-bugs] [Bug 31326] Koha::Biblio->get_components_query fetches
too many component parts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31326
Emmi Takkinen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #138886|0 |1
is obsolete| |
CC| |emmi.takkinen at koha-suomi.fi
--- Comment #3 from Emmi Takkinen ---
Created attachment 144398
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144398&action=edit
Bug 31326: Koha::Biblio->get_components_query fetches too many component parts
This patch adds double quotes to rcn and cni when searching component parts
with get_components_query.
Test plan:
1) Apply the patch
2) prove Koha/t/db_dependent/Koha/Biblio.t
Sponsored-by: Koha-Suomi Oy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 13:59:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 12:59:30 +0000
Subject: [Koha-bugs] [Bug 31326] Koha::Biblio->get_components_query fetches
too many component parts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31326
Emmi Takkinen changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:03:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:03:26 +0000
Subject: [Koha-bugs] [Bug 32341] OPAC - Mobile - Items table columns are too
thin
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341
Daphne Hoolahan changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dch at interleaf.ie
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:10:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:10:29 +0000
Subject: [Koha-bugs] [Bug 32291] "library category" messages should be
removed (not used)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:10:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:10:35 +0000
Subject: [Koha-bugs] [Bug 32291] "library category" messages should be
removed (not used)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32291
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #144191|0 |1
is obsolete| |
--- Comment #3 from Owen Leonard ---
Created attachment 144399
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144399&action=edit
Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt
On bug 16735 we rewrite the library groups system. Those references in
branches.tt were part of the previous code, and they can be removed.
Test plan:
Confirm the above and that those code errors are never sent to the
template.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:20:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:20:17 +0000
Subject: [Koha-bugs] [Bug 32393] New: background job worker explodes if JSON
is incorrect
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Bug ID: 32393
Summary: background job worker explodes if JSON is incorrect
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart+koha at gmail.com
Reporter: jonathan.druart+koha at gmail.com
QA Contact: testopia at bugs.koha-community.org
If a message that is not (or incorrect) JSON is received by the worker, the
script will explode.
Additionally, it will restart and get the same frame, over and over again,
which means no other job will be processed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:28:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:28:10 +0000
Subject: [Koha-bugs] [Bug 25314] Make OPAC facets collapse
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314
--- Comment #18 from Owen Leonard ---
I notice the Bootstrap Collapse component uses pseudo elements but adds the
"aria-expanded" attribute:
https://getbootstrap.com/docs/3.4/javascript/#collapse
Would that solve the issue?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:39:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:39:38 +0000
Subject: [Koha-bugs] [Bug 32394] New: Long tasks queue is never used
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
Bug ID: 32394
Summary: Long tasks queue is never used
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: major
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart+koha at gmail.com
Reporter: jonathan.druart+koha at gmail.com
QA Contact: testopia at bugs.koha-community.org
Depends on: 27783
We are sending "queue" as parameter, but "job_queue" is retrieved in
Koha::BackgroundJob->enqueue...
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
[Bug 27783] Introduce background job queues
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:39:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:39:38 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |32394
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
[Bug 32394] Long tasks queue is never used
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:44:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:44:31 +0000
Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
--- Comment #1 from Tomás Cohen Arazi ---
Aren't the parameter confusing but the outcome correct?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:45:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:45:52 +0000
Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
--- Comment #2 from Jonathan Druart ---
This one could be considered critical actually.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:46:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:46:33 +0000
Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:46:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:46:37 +0000
Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
--- Comment #3 from Jonathan Druart ---
Created attachment 144400
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144400&action=edit
Bug 32394: Restore long tasks queue
We are sending "queue" as parameter, but "job_queue" is retrieved in
Koha::BackgroundJob->enqueue...
Test plan:
Read code and confirm the above.
More fun for test plan will be found on bug 32393
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:46:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:46:53 +0000
Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
--- Comment #4 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #1)
> Aren't the parameter confusing but the outcome correct?
All jobs are using the default queue.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:47:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:47:17 +0000
Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |32393
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
[Bug 32393] background job worker explodes if JSON is incorrect
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:47:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:47:17 +0000
Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is
incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |32394
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
[Bug 32394] Long tasks queue is never used
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:55:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:55:13 +0000
Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values
to be used for calculating fund values (spent, ordered)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
|y.org |
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:58:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:58:00 +0000
Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is
incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:58:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:58:05 +0000
Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is
incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
--- Comment #1 from Jonathan Druart ---
Created attachment 144401
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144401&action=edit
Bug 32393: Prevent invalid job to block the job queue
I have faced a problem when testing an incorrect version of bug 32370.
The frame sent to the message broker was not a correct JSON encoded
string, and its decoding was obviously failing, exploding the worker
script.
Additionally, as we don't send a ack for this frame, the next pull will
result in processing the same message, and so in the same explosion.
No more messages can be processed!
This patch is logging the error and ack the message to the broker, in
order to not get stuck.
Test plan:
0. Dont' apply this patch
1. Enqueue a bad message
a. Apply 32370
b. Comment the following line in Koha::BackgroundJob::enqueue
$self->set_encoded_json_field( { data => $job_args, field => 'data' } );
c. restart_all
d. Use the batch item modification tool to enqueue a new job
=> Notice the error in the log
=> Note that the status of the job is "new"
=> Inspect rabbitmq queue:
% rabbitmq-plugins enable rabbitmq_management
% rabbitmqadmin get queue=koha_kohadev-long_tasks
You will notice there is a message in the "long_tasks" queue
2. Enqueue a good message
a. Remove the change from 1.b
b. restart_all
c. Enqueue another job
=> Same error in the log
=> Both jobs are new
=> Inspect rabbitmq, there are 2 messages
3. Apply this patch
4. restart_all
=> Second (good) job is finished
=> rabbitmq long_tasks queue is empty
We cannot mark the first job as done, we have no idea which job it was!
QA: Note that this patch is dealing with another problem, not tested in
this test plan. If an exception is not correctly caught by the ->process
method of the job, we won't crash the worker. The job will be marked as
failed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:58:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:58:51 +0000
Subject: [Koha-bugs] [Bug 32394] Long tasks queue is never used
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au,
| |m.de.rooy at rijksmuseum.nl,
| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 14:58:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 13:58:54 +0000
Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is
incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au,
| |m.de.rooy at rijksmuseum.nl,
| |martin.renvoize at ptfs-europe
| |.com, tomascohen at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:02:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:02:26 +0000
Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values
to be used for calculating fund values (spent, ordered)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #12 from Kyle M Hall ---
Unit tests are failing randomly:
root at kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t
t/db_dependent/Budgets.t .. 153/154 Use of uninitialized value in
multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515.
Use of uninitialized value in numeric eq (==) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 526.
Use of uninitialized value in multiplication (*) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 515.
Use of uninitialized value in numeric eq (==) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 526.
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1243.
# got: '157.6'
# expected: '147.36'
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1247.
# got: '169.44'
# expected: '157.6'
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1270.
# got: '157.6'
# expected: '147.36'
# Failed test 'We expect this value to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1272.
# got: '157.6'
# expected: '147.36'
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1276.
# got: '169.44'
# expected: '157.6'
# Failed test 'We expect this value to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1278.
# got: '169.44'
# expected: '157.6'
# Looks like you failed 6 tests of 34.
t/db_dependent/Budgets.t .. 154/154
# Failed test 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell
FieldsForCalculatingFundValues tests'
# at t/db_dependent/Budgets.t line 1290.
# Looks like you failed 1 test of 154.
t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/154 subtests
Test Summary Report
-------------------
t/db_dependent/Budgets.t (Wstat: 256 Tests: 154 Failed: 1)
Failed test: 154
Non-zero exit status: 1
Files=1, Tests=154, 4 wallclock secs ( 0.02 usr 0.00 sys + 3.43 cusr 0.65
csys = 4.10 CPU)
Result: FAIL
root at kohadevbox:koha(bug31631-qa)$ git log
commit 2a3c15c91467b01802c31a65f3436c9175ef1103 (HEAD -> bug31631-qa)
Author: Aleisha Amohia
Date: Tue Oct 25 03:08:03 2022 +0000
Bug 31631: (follow-up) Use CalculateFundValuesIncludingTax when modifying
existing order
This patch depends on Bug 31840.
To test:
1) Edit an order and increase the price so that you would expect it to
trigger a warning that you will exceed the amount allowed for this Fund
2) Confirm the warning is triggered
Signed-off-by: David Nind
commit cc6bcfe54ea55691bd4ed749b58fac2f9331f8fd
Author: Alex Buckley
Date: Tue Sep 27 17:01:51 2022 +1300
Bug 31631: Unit tests
Test plan:
1. Run tests in koha-shell
sudo koha-shell
prove t/db_dependent/Budgets.t
Sponsored-by: Waikato Institute of Technology, New Zealand
Signed-off-by: David Nind
commit a50a301eacde061376c6a3c0cafc03b56e8d1604
Author: Alex Buckley
Date: Tue Sep 27 16:59:00 2022 +1300
Bug 31631: Optionally use tax-exclusive values for calculating fund values
Test plan:
1. Apply patches
2. sudo koha-upgrade-schema
3. Restart services
4. Set TaxRates syspref = 0.15
5. Create a new fund with amount = 1000
6. Add an order to a basket with the following values:
- Fund = Choose the fund from step #5
- Quantity = 1
- Vendor price = 10
- Tax rate = 15%
- Discount = 20%
- Retail price = 10.00
- Replacement cost = 10.00
- Actual cost = 10.00
7. Go to the Acquisitions home page
8. Confirm the 'Ordered' column for the step #5 fund contains 9.20
9. Click on the 9.20 link and confirm the ordered.pl page that loads
also contains 9.20 as the 'Subtotal'
10. Change 'CalculateFundValuesIncludingTax' = 'Exclude'
root at kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t
t/db_dependent/Budgets.t .. 153/154 Use of uninitialized value in addition (+)
at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490.
Use of uninitialized value in addition (+) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 490.
t/db_dependent/Budgets.t .. ok
All tests successful.
Files=1, Tests=154, 4 wallclock secs ( 0.02 usr 0.01 sys + 2.99 cusr 0.54
csys = 3.56 CPU)
Result: PASS
root at kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t
t/db_dependent/Budgets.t .. 153/154 Use of uninitialized value in
multiplication (*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515.
Use of uninitialized value in numeric eq (==) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 526.
Use of uninitialized value in multiplication (*) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 515.
Use of uninitialized value in numeric eq (==) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 526.
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1243.
# got: '157.6'
# expected: '147.36'
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1247.
# got: '169.44'
# expected: '157.6'
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1270.
# got: '157.6'
# expected: '147.36'
# Failed test 'We expect this value to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1272.
# got: '157.6'
# expected: '147.36'
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1276.
# got: '169.44'
# expected: '157.6'
# Failed test 'We expect this value to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1278.
# got: '169.44'
# expected: '157.6'
# Looks like you failed 6 tests of 34.
t/db_dependent/Budgets.t .. 154/154
# Failed test 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell
FieldsForCalculatingFundValues tests'
# at t/db_dependent/Budgets.t line 1290.
# Looks like you failed 1 test of 154.
t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/154 subtests
Test Summary Report
-------------------
t/db_dependent/Budgets.t (Wstat: 256 Tests: 154 Failed: 1)
Failed test: 154
Non-zero exit status: 1
Files=1, Tests=154, 5 wallclock secs ( 0.02 usr 0.01 sys + 3.41 cusr 0.68
csys = 4.12 CPU)
Result: FAIL
root at kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t
t/db_dependent/Budgets.t .. 2/154 Use of uninitialized value in multiplication
(*) at /kohadevbox/koha/Koha/Acquisition/Order.pm line 515.
Use of uninitialized value in numeric eq (==) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 526.
Use of uninitialized value in multiplication (*) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 515.
Use of uninitialized value in numeric eq (==) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 526.
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1243.
# got: '157.6'
# expected: '147.36'
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1247.
# got: '169.44'
# expected: '157.6'
# Looks like you failed 2 tests of 34.
t/db_dependent/Budgets.t .. 154/154
# Failed test 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell
FieldsForCalculatingFundValues tests'
# at t/db_dependent/Budgets.t line 1290.
# Looks like you failed 1 test of 154.
t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/154 subtests
Test Summary Report
-------------------
t/db_dependent/Budgets.t (Wstat: 256 Tests: 154 Failed: 1)
Failed test: 154
Non-zero exit status: 1
Files=1, Tests=154, 2 wallclock secs ( 0.02 usr 0.00 sys + 2.17 cusr 0.24
csys = 2.43 CPU)
Result: FAIL
root at kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t
t/db_dependent/Budgets.t .. 100/154 Use of uninitialized value in addition (+)
at /kohadevbox/koha/Koha/Acquisition/Order.pm line 490.
Use of uninitialized value in addition (+) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 490.
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1270.
# got: '157.6'
# expected: '147.36'
# Failed test 'We expect this value to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1272.
# got: '157.6'
# expected: '147.36'
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1276.
# got: '169.44'
# expected: '157.6'
# Failed test 'We expect this value to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1278.
# got: '169.44'
# expected: '157.6'
# Looks like you failed 4 tests of 34.
t/db_dependent/Budgets.t .. 154/154
# Failed test 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell
FieldsForCalculatingFundValues tests'
# at t/db_dependent/Budgets.t line 1290.
# Looks like you failed 1 test of 154.
t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/154 subtests
Test Summary Report
-------------------
t/db_dependent/Budgets.t (Wstat: 256 Tests: 154 Failed: 1)
Failed test: 154
Non-zero exit status: 1
Files=1, Tests=154, 3 wallclock secs ( 0.03 usr 0.00 sys + 2.31 cusr 0.37
csys = 2.71 CPU)
Result: FAIL
root at kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t
t/db_dependent/Budgets.t .. 2/154 Use of uninitialized value in addition (+) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 490.
Use of uninitialized value in addition (+) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 490.
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1270.
# got: '157.6'
# expected: '147.36'
# Failed test 'We expect this value to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1272.
# got: '157.6'
# expected: '147.36'
# Failed test 'We expect this to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1276.
# got: '169.44'
# expected: '157.6'
# Failed test 'We expect this value to be the tax exclusive value'
# at t/db_dependent/Budgets.t line 1278.
# got: '169.44'
# expected: '157.6'
# Looks like you failed 4 tests of 34.
t/db_dependent/Budgets.t .. 154/154
# Failed test 'GetBudgetSpent GetBudgetOrdered GetBudgetsPlanCell
FieldsForCalculatingFundValues tests'
# at t/db_dependent/Budgets.t line 1290.
# Looks like you failed 1 test of 154.
t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/154 subtests
Test Summary Report
-------------------
t/db_dependent/Budgets.t (Wstat: 256 Tests: 154 Failed: 1)
Failed test: 154
Non-zero exit status: 1
Files=1, Tests=154, 2 wallclock secs ( 0.03 usr 0.00 sys + 2.09 cusr 0.28
csys = 2.40 CPU)
Result: FAIL
root at kohadevbox:koha(bug31631-qa)$ prove t/db_dependent/Budgets.t
t/db_dependent/Budgets.t .. 2/154 Use of uninitialized value in addition (+) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 490.
Use of uninitialized value in addition (+) at
/kohadevbox/koha/Koha/Acquisition/Order.pm line 490.
t/db_dependent/Budgets.t .. ok
All tests successful.
Files=1, Tests=154, 2 wallclock secs ( 0.01 usr 0.00 sys + 2.15 cusr 0.23
csys = 2.39 CPU)
Result: PASS
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:07:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:07:43 +0000
Subject: [Koha-bugs] [Bug 32395] New: Why do we send job's params to the
broker
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32395
Bug ID: 32395
Summary: Why do we send job's params to the broker
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: jonathan.druart+koha at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: dcook at prosentient.com.au, m.de.rooy at rijksmuseum.nl,
martin.renvoize at ptfs-europe.com, tomascohen at gmail.com
We are:
- Building the parameters
- Insert a job and its parameters in DB
- Send a message to the broken with the parameters
- Retrieve the message from the worker
- Process the job using the parameter from the broker
Why don't we simply pass the job_id to the broker, then retrieve the parameters
from the DB in the worker?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:09:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:09:29 +0000
Subject: [Koha-bugs] [Bug 31481] Pass message_id to SMS drivers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31481
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=32381
CC| |andrewfh at dubcolib.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:09:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:09:29 +0000
Subject: [Koha-bugs] [Bug 32381] Koha should be able to receive and record
reasons for failed SMS notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32381
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=31481
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:09:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:09:31 +0000
Subject: [Koha-bugs] [Bug 32395] Why do we send job's params to the broker
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32395
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |22417
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
[Bug 22417] Add a task queue
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:09:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:09:31 +0000
Subject: [Koha-bugs] [Bug 22417] Add a task queue
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |32395
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32395
[Bug 32395] Why do we send job's params to the broker
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:10:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:10:04 +0000
Subject: [Koha-bugs] [Bug 31561] Background jobs stuck at "New"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31561
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
CC| |jonathan.druart+koha at gmail.
| |com
Status|NEW |RESOLVED
--- Comment #10 from Jonathan Druart ---
*** This bug has been marked as a duplicate of bug 31245 ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:10:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:10:04 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
job not started
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |magnus at libriotech.no
--- Comment #22 from Jonathan Druart ---
*** Bug 31561 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:10:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:10:14 +0000
Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all
libraries even with IndependentBranches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
|y.org |
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:10:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:10:43 +0000
Subject: [Koha-bugs] [Bug 31090] Background jobs needs highlights and
searchability
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31090
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=30982
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:10:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:10:43 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
view
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=31090
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:11:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:11:08 +0000
Subject: [Koha-bugs] [Bug 32395] Why do we send job's params to the broker
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32395
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |In Discussion
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:11:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:11:26 +0000
Subject: [Koha-bugs] [Bug 32381] Koha should be able to receive and record
reasons for failed SMS notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32381
--- Comment #3 from Andrew Fuerste-Henry ---
(In reply to Emmi Takkinen from comment #2)
> Could this be a duplicate of bug 31481?
I don't *think* so, but I'm really not certain. I've got only the vaguest
explanation of why Twilio's unsubscribed user response can't make its way into
Koha.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:12:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:12:21 +0000
Subject: [Koha-bugs] [Bug 32395] Why do we send job's params to the broker
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32395
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=32393
--- Comment #1 from Jonathan Druart ---
We would have avoided all the JSON encoding/decoding stuffs we had recently,
and bug 32393.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:12:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:12:21 +0000
Subject: [Koha-bugs] [Bug 32393] background job worker explodes if JSON is
incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=32395
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:18:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:18:44 +0000
Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all
libraries even with IndependentBranches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:18:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:18:48 +0000
Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all
libraries even with IndependentBranches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #137170|0 |1
is obsolete| |
--- Comment #9 from Kyle M Hall ---
Created attachment 144402
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144402&action=edit
Bug 28975: Holds queue lists can show holds from all libraries even with
IndependentBranches
When using IndependentBranches, usually all branches are removed from the
drop-down menus. But in the Holds Queue page, there is the possibility to
choose "All branches". From there, you can see holds from all libraries.
To recreate :
1) Activate IndependentBranches, IndependentBranchesPatronModifications and
IndependentBranchesTransfers
2) Create a staff user with limited permissions (NOT a superlibrarian),
including holds permissions. Here are mine as an example
- circulate (all)
- catalogue
- borrowers
- delete_borrowers
- edit_borrowers
- reserveforothers (all)
- reports (all)
3) Create (or make sure you already have) a patron in another branch (we'll
call them patron X)
4) Place a hold for patron X on an available item from their own library
5) Run misc/cronjobs/holds/build_holds_queue.pl
6) Go to Circulation > Holds queue and make sure you can see the hold
7) Log in as your limited staff patron
8) Go to Circulation > Holds queue
9) In the drop-down menu, choose "All" and click Submit
-- Notice you see the hold of the patron from another branch under Patron
column: "A patron from library "
11) Apply the patch.
12) Notice that the "All" option is no longer available for the limited patron.
Limited patrons can't see holds from other libraries anymore.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:19:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:19:04 +0000
Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all
libraries even with IndependentBranches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975
--- Comment #10 from Kyle M Hall ---
Created attachment 144403
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144403&action=edit
Bug 28975: (QA follow-up) Fix indentation, simplify if statement
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:21:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:21:50 +0000
Subject: [Koha-bugs] [Bug 32134] Show the bundle size when checked out
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
|y.org |
CC| |kyle at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:26:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:26:52 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
--- Comment #17 from Jonathan Druart ---
108 $self->set_encoded_json_field( { data => $job_args, field => 'data'
} );
120 $job_args->{job_id} = $self->id;
130 my $json_args = $self->data; # we pass the JSON string
137 my $encoded_args = Encode::encode_utf8( $json_args ); # FIXME We
should better leave this to Net::Stomp?
This is terribly wrong, we are loosing job_id...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:29:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:29:00 +0000
Subject: [Koha-bugs] [Bug 32074] Edit vendor has a floating toolbar,
but still an additional save button at the bottom
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|oleonard at myacpl.org |matt.blenkinsop at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:43:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:43:34 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:44:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:44:44 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
--- Comment #18 from Jonathan Druart ---
I think attention must be on bug 32393, bug 32394 and bug 32395 first.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:48:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:48:27 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
--- Comment #19 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > malformed JSON string, neither tag, array, object, number, string or atom,
> > at character offset 0 (before "HASH(0x55ae880d9628)") at
> > /kohadevbox/koha/misc/background_jobs_worker.pl line 93.
>
> Hum, forget that, I guess I need to copy the new version of the misc script.
I have faced some very weird behaviours testing this (and linked bugs).
At some point I got background_jobs.pl processes that were not attached to the
koha-worker daemon, and were using an old version of the code (like this
message that was because of this bug, but was also in the log after a checkout
master && restart_all). Just noting, but good to keep in mind.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:49:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:49:36 +0000
Subject: [Koha-bugs] [Bug 31994] Clicking the next button of a DataTable
loading its data from the HTML does nothing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31994
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor at tuxayo.net
Version|master |21.11
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:56:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:56:53 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
--- Comment #60 from Jonathan Druart ---
Why do we need the DB column background_jobs.queue exactly?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 15:59:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 14:59:12 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783
--- Comment #61 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #60)
> Why do we need the DB column background_jobs.queue exactly?
... In case we are defaulting to the DB (no broker).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:32:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 15:32:17 +0000
Subject: [Koha-bugs] [Bug 32370] Provide a generic set of tools for JSON
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32370
--- Comment #20 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #19)
> (In reply to Jonathan Druart from comment #12)
> > (In reply to Jonathan Druart from comment #11)
> > > malformed JSON string, neither tag, array, object, number, string or atom,
> > > at character offset 0 (before "HASH(0x55ae880d9628)") at
> > > /kohadevbox/koha/misc/background_jobs_worker.pl line 93.
> >
> > Hum, forget that, I guess I need to copy the new version of the misc script.
>
> I have faced some very weird behaviours testing this (and linked bugs).
>
> At some point I got background_jobs.pl processes that were not attached to
> the koha-worker daemon, and were using an old version of the code (like this
> message that was because of this bug, but was also in the log after a
> checkout master && restart_all). Just noting, but good to keep in mind.
Not having the job_id might be a good source for weirdness :-D well spotted,
Jonathan. I should've put the background jobs related change on a separate bug.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:46:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 15:46:07 +0000
Subject: [Koha-bugs] [Bug 32134] Show the bundle size when checked out
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 16:46:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 15:46:11 +0000
Subject: [Koha-bugs] [Bug 32134] Show the bundle size when checked out
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #143625|0 |1
is obsolete| |
--- Comment #3 from Kyle M Hall ---
Created attachment 144404
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144404&action=edit
Bug 32134: Show the bundle size when checked out
When checking out a bundle, it can be useful to know the number of items
in this bundle, so that librarians can quickly check if items are
missing.
Test plan:
1. Create a bundle (see bug 28854 comment 458)
2. Check out the bundle.
3. Verify that you have the bundle size in the message below the barcode
input ("Checked out: [...]. Bundle of X items. Due on [...]")
4. Checkout an item that is not a bundle.
5. Verify that the bundle message does not appear
Signed-off-by: David Nind
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:04:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 16:04:25 +0000
Subject: [Koha-bugs] [Bug 32396] New: CMS page default language link should
still allow to the change language
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32396
Bug ID: 32396
Summary: CMS page default language link should still allow to
the change language
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: I18N/L10N
Assignee: koha-bugs at lists.koha-community.org
Reporter: pascal.uphaus at gwdg.de
QA Contact: testopia at bugs.koha-community.org
CC: frederic at tamil.fr
Test plan:
1. Install a second language to the koha instance
2. Enable the language via the systempreferences (language, OPAClanguages and
opaclanguagesdisplay)
3. Adding a page via
koha-domain/cgi-bin/koha/tools/additional-contents.pl?category=pages
4. added the translations default, english and the second language
5. Opening the default link for OPAC or for the Staff Interface
6. Change the Language and go back to the same url and reload the page.
7. Result: the language of the opac is still the default one
Is this intended that the Link always resets the language to the default
language, when accessing the page via link or go back and reload the page?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:04:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 16:04:32 +0000
Subject: [Koha-bugs] [Bug 32391] Reorganise the manual contents
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391
--- Comment #2 from David Nind ---
I've created a document that anyone should be able to comment on (no login
required):
https://docs.google.com/document/d/1KyrsMVWG_kcVvbFsUkysRC9oovIbFCNTNgCwSyM4SL0/edit?usp=sharing
If you prefer not to use a Google document, you can use
https://annuel.framapad.org/p/koha-manual-contents-reorganisation
Quite a few changes from comment #1 - more a narrowing down of the top-level
items:
Introduction
Koha overview
What's new in Koha
Getting started
Using Koha [where most of the content is]:
- Core modules: Circulation, patrons, etc
- Other modules, tools and features
- Enhanced content
- Customising the OPAC and staff interface
- System configuration
- System administration
Implementing Koha
Installing Koha
System preference [reference]
Glossary
Index
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:04:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 16:04:47 +0000
Subject: [Koha-bugs] [Bug 32391] Reorganise the manual contents
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32391
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://docs.google.com/doc
| |ument/d/1KyrsMVWG_kcVvbFsUk
| |ysRC9oovIbFCNTNgCwSyM4SL0/e
| |dit?usp=sharing
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:19:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 16:19:01 +0000
Subject: [Koha-bugs] [Bug 32396] CMS page default language link should still
allow to the change language
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32396
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor at tuxayo.net
--- Comment #1 from Victor Grousset/tuxayo ---
Got confused as well. On the rest of the Koha, when changing the language, one
is redirected to the homepage.
Then it's usual use the back button of the browser, and with additional
content(CMS pages) it's necessary for the OPAC to have the direct URL otherwise
it's not possible to find back the page. But then one triggers the language
reset.
I think the confusion is that the default language URL is meant to reset the
language.
But then if one wants to check the translation of the additional content, it's
expected to use the language switches instead of the link in the additional
content interface. And then when using the language switch it's expected to
back to the page to check if the right language is shown and oops it's reset
and the language.
I don't know how the UX should be avoid this but this is at least to document
the confusion that can arise, we though the translation mechanism of additional
content was broken and didn't notice the two URL in the additional content
interface are different.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Dec 2 17:19:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 02 Dec 2022 16:19:56 +0000
Subject: [Koha-bugs] [Bug 32396] Pages/Additional contents/CMS page default
language link should still allow to the change language
In-Reply-To: