[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #77 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #75)
> Not sure about the date, actually:
> 
> If you create an unrestricted debarment you get:
> 
> borrowers_debarments.expiration = NULL
> borrowers.debarred = 9999-12-31

Looking at the code, it checked borrowers.debarred:

+            } elsif ($patron->debarred) {
+                if ( $patron->debarred eq "9999-12-31") {

So this would be the correct checked for an unlimited restriction indeed. 

There is some history there as in that debarred and debarredcomment where kept
around when borrowers_debarments were added for backwards compatibility. It
should always contain the longest restriction at that moment with more than one
restriction. And it's also still used in patron import for adding a
restriction.

And in borrowers.debarred we can't use NULL to indicate an unlimited
debarment... as that would mean NO restriction. So the 'magic' date is still
used there.

Setting back to Signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.