[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #112 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Katrin Fischer from comment #96)
> Testing this:
> 
> - Activate branch transfers
> - Library Centerville DISALLOWS transfer to Fairview
> - Library Fairview ALLOWS transfer to Centerville
> 
> Without previous checkout! Just doing a checkin.
> 
> Test A:
> Checkin of Fairview item in Centerville
> Transfer is allowed, correct.

Returning a Fairview item in Centerville should trigger a transfer from
Centerville to Fairview, right ? That transfer is forbidden. I don't understand
why you expect the transfer to be allowed in that case.

> 
> Test B:
> Checkin of Centerville item in Fairview.
> Transfer is allowed - that wasn't the result I expected.

This makes sense to me, the transfer from Fairview to Centerville is allowed

> 
> This is a Centerville item. Centerville hasn't permitted it's items to go to
> Fairview - so should the transfer not be blocked?

I think there is a little bit of confusion over two different things:
1) Is it allowed to return item I to library L ? (which is controlled by
syspref AllowReturnToBranch)
2) Is item I allowed to be transferred from library L1 to library L2 ?
(controlled by transfer limits and related sysprefs)

It looks like you are testing 1 whereas the patch is about 2.

It worked fine for me. Here's what I did:

1. Set syspref AllowReturnToBranch = "to any library"
2. Set syspref UseBranchTransferLimits = "Enforce"
3. Set syspref BranchTransferLimitsType = "item type"
4. Create an item (itemtype BOOK, homebranch Centerville, holdingbranch
Centerville)
5. Disable all transfers for item type BOOK
6. Set library to Fairfield
7. Checkin the item => checkin is blocked (message: "This item must be checked
in at following library: Centerville)
   On master, the checkin is allowed and it starts a transfer from Fairfield to
Centerville, which is forbidden)
8. If I enable the transfer from Fairfield to Centerville for BOOK, the checkin
is allowed.

-- 
You are receiving this mail because:
You are watching all bug changes.