[Koha-bugs] [Bug 30642] We should record the renewal type (Automatic/Manual)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30642

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |lucas at bywatersolutions.com

--- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
This will be very helpful! 

I do encounter a problem when testing with automatic_renewals.pl. They are
showing up as a "Manual" renewal type. 

Looking a Circulation.pm I see that my file name is
"/kohadevbox/koha/misc/cronjobs/automatic_renewals.pl" not
"automatic_renewals.pl".

If I switch this it works:
-my $renewal_type = $filename eq "automatic_renewals.pl" ? "Automatic" :
"Manual";
 +my $renewal_type = $filename =~ m/automatic_renewals.pl/ ? "Automatic" :
"Manual";

-- 
You are receiving this mail because:
You are watching all bug changes.