[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Dec 12 13:01:14 CET 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Julian Maurice from comment #7)
> (In reply to Fridolin Somers from comment #6)
> > Instead of creating get_enabled_plugins(),
> > Why not adding a param "only_enabled" in GetPlugins() ?
> 
> GetPlugins already returns only enabled plugins by default (without the
> 'all' parameter), but it also have other parameters that make it hard for
> its result to be put in cache.

The all parameter is not used often and could perhaps live on its own. The
results of GetPlugins might be filtered by method or metadata, but that could
be done too on the cached results, just limiting them further?

We now have two similar routines. One has been optimized, the other one not.
Note that GetPlugins is still called in the codebase, probably on the first
places when we did not yet have ->call. Feels a bit like unfinished work?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list