[Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've had a look at our current code and it looks the proposed solution is
already part of a FIXME:

sub non_issues_charges {
    my ($self) = @_;

    #NOTE: With bug 23049 these preferences could be moved to being attached
    #to individual debit types to give more flexability and specificity.
    my @not_fines;
    push @not_fines, 'RESERVE'
      unless C4::Context->preference('HoldsInNoissuesCharge');
    push @not_fines, ( 'RENT', 'RENT_DAILY', 'RENT_RENEW', 'RENT_DAILY_RENEW' )
      unless C4::Context->preference('RentalsInNoissuesCharge');
    unless ( C4::Context->preference('ManInvInNoissuesCharge') ) {
        my @man_inv = Koha::Account::DebitTypes->search({ is_system => 0
})->get_column('code');
        push @not_fines, @man_inv;
    }

But looking at the code I also realized another thing 

* ManInvInNoissuesCharge = All manually invoiceable debit types

This is wrong, it's not only the manually invoiceable ones per the checkbox you
can set, but all manually added debit types, which makes this even less
flexible than we had initially thought. 

* ManInvInNoissuesCharge = All manually added debit types, all but the system
internal ones

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.