[Koha-bugs] [Bug 32472] [21.11] The method Koha::Item->count is not covered by tests

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32472

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
git grep -E "return Koha::\w+->search"
Acquisition/Bookseller.pm:    return Koha::Subscriptions->search( {
aqbooksellerid => $self->id } );
=> sub subscriptions This could be LIST context. So needs adjustment in 21.11 ?
Acquisition/Order.pm:    return Koha::Items->search({ itemnumber =>
\@itemnumbers });
=> see previous comment WRONG
ArticleRequests.pm:    return Koha::ArticleRequests->search_limited($params);
ArticleRequests.pm:    return Koha::ArticleRequests->search_limited( $params );
ArticleRequests.pm:    return Koha::ArticleRequests->search_limited( $params );
ArticleRequests.pm:    return Koha::ArticleRequests->search_limited( $params );
ArticleRequests.pm:    return Koha::ArticleRequests->search_limited( $params );
=> sub requested, pending, processing, completed, canceled
=> article-requests.tt:                                Pending (<span
id="ar_pending_count">[% article_requests_pending.count | html %]</span>)
=> article-requests.tt:                                Processing (<span
id="ar_processing_count">[% article_requests_processing.count | html %]</span>)
=> Are passed with scalar to template. FINE
OK Biblio.pm:    return Koha::Libraries->search(
=> sub pickup_locations looks WRONG but no direct template calls?
OK Biblio.pm:    return Koha::Checkouts->search( { "item.biblionumber" =>
$self->id },
=> sub current_checkouts and ALSO old_checkouts NO template calls
OK Biblio.pm:    return Koha::Items->search( { itemnumber => { -in =>
\@itemnumbers } } );
=> host_items looks wrong NO template_calls
OK Biblios.pm:    return Koha::Libraries->search(
=> pickup_locations SEE above
OK Holds.pm:    return Koha::Items->search(
=> get_items_that_can_fill, waiting, unfilled are candidates / No template
calls found
TODO Illrequest.pm:    return Koha::AuthorisedValues->search(
OK ItemType.pm:    return Koha::ItemTypes->search_with_localization({
parent_type => $self->itemtype });
=> children_with_localization
OK Library.pm:    return Koha::Libraries->search({ branchcode => { '-in' => [
keys %seen ] } });
=> get_hold_libraries, validate_hold_sibling
TODO Library/Group.pm:    return Koha::Libraries->search(
TODO SMS/Provider.pm:    return Koha::Patrons->search( { sms_provider_id =>
$self->id } )->count();
TODO SMTP/Server.pm:    return Koha::Libraries->search( { branchcode => { -in
=> \@library_ids } } );
=> libraries
OK Subscription.pm:    return Koha::Patrons->search({ borrowernumber => {-in =>
\@borrowernumbers } });
* subscribers
OK Template/Plugin/AuthorisedValues.pm:    return
Koha::AuthorisedValues->search_with_library_limits(
* GetAuthValueDropbox, GetDescriptionsByKohaField
TODO Template/Plugin/Desks.pm:    return Koha::Desks->search();
OK Template/Plugin/ItemTypes.pm:    return
Koha::ItemTypes->search_with_localization->unblessed;
TODO Util/StockRotation.pm:    return Koha::Libraries->search(
OK Virtualshelves.pm:    return Koha::Virtualshelves->search(
* get_shelves_containing_record

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.