[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Dec 15 14:11:51 CET 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474

--- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> ---
Created attachment 144614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144614&action=edit
Bug 32474: Infinite scrolling of selects

Investigation of this shows that the data is loaded on first mount of the
ERMMain.vue component and then cached in a Pinia store. This commit shows an
example of an infinite scroll without the need for Ajax based scrolling as the
data is already available and injected into AgreementsFormAdd.vue.

I don't think we need Ajax based scrolling on these vendor selects as the data
is front-loaded and cached. Based on that we would have two options:
1) Keep the selects as they are currently with all data available as per
Jonathan's patch in bug 32468
2) Use the infinite scrolling as per this commit and extract that logic into a
new component that we can plug in to all the components that use a select for
vendors

Let me know your thoughts, if you think option 2 is better then I am happy to
pull that together

Test plan for this commit:
1) Create more than 20 new vendors, the more you create the more obvious the
infinite scroll
2) Add a new agreement and observe that the vendor select limits the selection
to 20 vendors
3) Apply patch
4) Add a new agreement and observe that the vendor select now loads more
options as you scroll

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list