[Koha-bugs] [Bug 32356] xx-XX installer dir /kohadevbox/koha/installer/data/mysql/xx-XX already exists.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32356

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Here is a dumb question but couldnt we add TESTS for this module too ?

Interesting that we have misc/translator/translate and
debian/scripts/koha-translate. Shouldnt the latter one only be a very thin
wrapper around the first one? Currently, it is a bit more. It implements an
update option that we are missing in LangInstaller although the POD claims that
it is present (but proposing something else):
=head2 update
For the current language, update .po files.

sub install_installer
=> Nothng better than choosing a good subroutine name :)

sub install_messages
mkdir "$progdir/$self->{lang}/js";
=> No check here ?

Reading the comments, I think that we still need feedback from a few people
(Bernardo, Aleisha, maybe others). And it feels like only removing the -d code
is a bit of trial and error. This area of Koha (also) needs a bit more
attention than that?

-- 
You are receiving this mail because:
You are watching all bug changes.