[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #35 from David Nind <david at davidnind.com> ---
I had a go at testing. Failed QA because tests failed and there were error
traces when renewing items from the OPAC.

Tested using KTD (koha-testing-docker) with the sample data.

Test failures
=============

These tests failed - note that I didn't check whether these failed before the
patch was applied:

prove t/db_dependent/api/v1/biblios.t
prove t/db_dependent/api/v1/checkouts.t
prove t/db_dependent/api/v1/return_claims.t
prove t/db_dependent/Circulation/Returns.t
prove t/db_dependent/Circulation.t
prove t/db_dependent/Circulation/transferbook.t
prove t/db_dependent/Illrequests.t
prove t/db_dependent/Koha/Account/Line.t
prove t/db_dependent/Koha/Items.t
prove t/db_dependent/Koha/Object.t
prove t/db_dependent/Koha/Patrons.t
prove t/db_dependent/Koha/Recalls.t
prove t/db_dependent/Koha/Recall.t
prove t/db_dependent/Letters/TemplateToolkit.t
prove t/db_dependent/Reserves.t
prove t/db_dependent/selenium/regressions.t
prove t/db_dependent/SIP/ILS.t

Renewing from the OPAC - errors
===============================

I checked out three different items to one patron, making one of them already
overdue. The default circulation rule in KTD allows 5 renewals.

Error 1: Renew a single overdue item from the OPAC (Summary > Overdue tab)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: Argument passed to the
'IN' operator can not be undefined at /kohadevbox/koha/Koha/Objects.pm line 312
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

    in DBIx::Class::Exception::throw at
/usr/share/perl5/DBIx/Class/Exception.pm line 77
......

Note that it renewed fine from Summary > Checkout tab.

Error 2: Renew multiple items (two items individually selected) from the
Summary > Checked out tab (where one is overdue)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: unexpected operator
'715' with undef operand at /kohadevbox/koha/Koha/Objects.pm line 312
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

    in DBIx::Class::Exception::throw at
/usr/share/perl5/DBIx/Class/Exception.pm line 77
....


Error 3: Renew multiple items (renew all button selected) from the Summary >
Checked out tab where one is overdue:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: Argument passed to the
'IN' operator can not be undefined at /kohadevbox/koha/Koha/Objects.pm line 312
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

    in DBIx::Class::Exception::throw at
/usr/share/perl5/DBIx/Class/Exception.pm line 77
....

-- 
You are receiving this mail because:
You are watching all bug changes.