[Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507

--- Comment #19 from Thibaud Guillot <thibaud.guillot at biblibre.com> ---
(In reply to Henri-Damien LAURENT from comment #12)
> Dears,
> 
> Your solution seems to fit your environment. But let me state that some
> countries, like France have different signs for thousand delimiter and
> decimal delimiter.
> 
> And I can see no real support for those "oddities" in the proposed js code.
> Worse, there seems to be no way to parametrize those 'locales' for currency.
> 
> For instance, if someone copy pastes 123,13 €, it would be converted into
> 12,313.00 which is counter intuitive for usual french folks.  
> 
> Moreover, it seems that there is no way to add more decimals... (which
> should be enable for some rates, if there is a fine per page printed for
> instance, it could be 0.013 cents per page)
> 
> To that aim, decimal_fill (hardcoded at the moment in Koha::Number::Price
> could be parametrized).
> And the way the proposed patch fixed that would take a system variable for
> number format into account.
> So it has my favour.
>   
> Can it be discussed some time ?

Hi everyone,

I try to make this patch goes forward a bit :) 

So I agree with Henri-Damien, maybe it must be take in case with a new syspref
to force 3 digits after the decimal separator, but I ask you if you agree with
this particular setting : "If user active this syspref to force usage of 3
digits after the decimal separator, he must always enter 3 digits after
separator" because it can be hard to define if it's a decimal or thousand
delimiter.

If you agree with this maybe addition of 'comment 10' algoritm and new syspref
can be the solution ?

-- 
You are receiving this mail because:
You are watching all bug changes.