[Koha-bugs] [Bug 28639] Embed see-from headings (from authorities) into bibliographic records at OAI repository level

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639

--- Comment #10 from Thibaud Guillot <thibaud.guillot at biblibre.com> ---
(In reply to Fridolin Somers from comment #7)
> Hi,
> 
> Atomic update is incorrect :
> +            INSERT IGNORE INTO systempreferences
> (variable,value,options,explanation,type) 
> +            VALUES (
> +                'EmbedSeeFromInBibRecord', '0', NULL, 'Add embed see-from
> headings for OAI', 'YesNo'
> 
> Value should be OAI-PMH:EmbedSeeFromInBibRecord
> 
> Also :
> 
> +    Koha::Filter::MARC::EmbedSeeFromHeadings->filter($record);
> 
> Does this work ?
> Other call use the RecordProcessor :
> 
> https://git.koha-community.org/Koha-community/Koha/src/commit/
> a57278f39b8c5b7a82b21671f266dbf32e2d41a0/t/db_dependent/
> RecordProcessor_EmbedSeeFromHeadings.t#L60
> 
> Best regards,

Hi Fridolin :)

Thanks for your reply ! Yes I miss this thing, I fix that by follow-up. And I
also rebased on 'fresh' master ^^ 

For this :

+ Koha::Filter::MARC::EmbedSeeFromHeadings->filter($record);

It works as intended apparently but you put me in doubt.. did you test it ?
Maybe I miss something

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.