[Koha-bugs] [Bug 32528] Koha::Item->safe_to_delete should short-circuit earlier

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32528

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com
            Summary|Enhance                     |Koha::Item->safe_to_delete
                   |Koha::Item->safe_to_delete  |should short-circuit
                   |                            |earlier
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Koha::Item->safe_to_delete checks 5 conditions, most of which involve querying
the DB. It should return right after one condition is met, but it keeps
checking the rest of them.

This can be particularyl painful on batch deletions. And is incorrect
regardless.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.