[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #13 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Jonathan and Katrin, 

Thank you for your responses. 

Jonathan: I originally removed the 'Clear on loan' link from the batch item
modification and deletion pages for the reason outlined in the description:

This patchset makes items on loan display a red cross, rather than a disabled
checkbox. So giving users the ability to clear on loan items when they could
not be selected in most cases seemed redundant.

However, when the 'IndependentBranches' syspref is set to 'No' then on-loan
items can be displayed with a selectable checkbox in the Batch item
modification page so I have now re-added the 'Clear on loan' link to both batch
item tool pages. 

---

Katrin: I've done some testing: The 'Clear on loan' link only appears on the
batch item modification and deletion pages on master/main (and I have re-added
it in my patches) - loaded from the html_helpers.inc. 

It does not appear on the batch record deletion page - as that uses links from
batch_delete_records.tt (
https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt#L142
).

I do notice, however, the 'Clear on loan' link doesn't appear to work on the
batch item modification page on master/main - so I'll make a new bug report for
that.

---

I've removed the tab char that QA test tools reported in comment #7, and have
updated the test plans on both patches now batch item/record tools exist in the
'Cataloguing' module.

Ready for testing again!

Many thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.