From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 00:54:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jan 2022 23:54:13 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers --- (In reply to Jonathan Druart from comment #11) > This is going backward IMO, why not move to DBIC/Koha::Object instead? Indeed we should be go back to direct SQL even if faster. Se should use DBIC for all tables, with prefetch. But we could start with adding pagination Bug 28974 while working on rewriting to use DBIC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:06:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:06:04 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Useless warning in |Manage call of Template |t/db_dependent/Template/Plu |Plugin Branches with null |gin/Branches.t |or empty branchcode --- Comment #6 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #5) > This report refers to the test. So the suggestion thing might be a different > case. Or widen the scope by changing the title? Ah good point, I change title. > > + return q{} unless defined $branchcode; > This still has the effect of testing if there is a branch with an empty > code. Which makes no sense either? > So you could also return unless $branchcode. Ah indeed. But we must allow branchcode=0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:06:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:06:16 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:15:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:15:43 +0000 Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:15:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:15:48 +0000 Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105411|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers --- Created attachment 130029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130029&action=edit Bug 25616: Uppercase hard coded lower case boolean operators for Elasticsearch Uppercase occurances of all (hopefully) lowercase "and" used in ElasticSearch Query String Query contexts Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:16:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:16:21 +0000 Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #6 from Fridolin Somers --- I found one more in C4::Search::_build_initial_query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:19:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:19:49 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Manage call of Template |Manage call of Template |Plugin Branches with null |Plugin Branches GetName() |or empty branchcode |with null or empty | |branchcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:23:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:23:51 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:23:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:23:57 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 --- Comment #7 from Fridolin Somers --- Created attachment 130030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130030&action=edit Bug 29826: Manage call of Template Plugin Branches GetName() with null or empty branchcode Bug 26587 added a concatenation that sends a warning if var is undef : $ prove t/db_dependent/Template/Plugin/Branches.t Use of uninitialized value $branchcode in concatenation (.) or string at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 35. This patch adds an early return empty string when GetName is called with $branchcode null or empty string. Test plan : 1) Run t/db_dependent/Template/Plugin/Branches.t without patch 2) Run with the patch to see warning disappear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:38:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:38:08 +0000 Subject: [Koha-bugs] [Bug 29424] Replace the table on 'HTML customisations' administration with a visual alternative. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29424 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleypelham at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:39:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:39:31 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128927|0 |1 is obsolete| | --- Comment #10 from Fridolin Somers --- Created attachment 130031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130031&action=edit Bug 29066: Remove text in OPAC search form and use Font Awesome icons In modern front-end websites, first think you see in header region is an large input text with a search icon. No need to say it is a search form. We still tell it in 'title' attribut for accessibility. This patch removes 'Search' text. If 'my library first' feature is enabled, shows a text in title of a question mark icon. In submit button, replaces 'Go' with a seach icon and add title 'Search'. Test plan : 1) 1.1) Set system preferences : OpacAddMastheadLibraryPulldown to 'Add' SearchMyLibraryFirst to 'Don't limit' 1.2) Go to OPAC main page 1.3) You don't see 'Search' anymore 1.4) You see in submit button an icon 1.5) Move mouse over submit button to see tooltip text 'Search' 2) 2.1) Set system preferences : OpacAddMastheadLibraryPulldown to 'Don't add' SearchMyLibraryFirst to 'Limit' 2.2) Go to OPAC main page 2.3) Log in 2.4) You don't see text 'Search (in ) only' 2.5) You see a question mark icon 2.6) Move mouse over submit button to see tooltip text 'Search (in ) only' Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:39:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:39:51 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #11 from Fridolin Somers --- Created attachment 130032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130032&action=edit Bug 29066: (follow-up) add aria-label and aria-hidden on icons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:40:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:40:36 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #12 from Fridolin Somers --- (In reply to Lucas Gass from comment #9) > I think the follow-up is correct, the aria-label belongs on the button. Now > I think the the icon needs the aria-hidden="true" attribute. > > In fact the QA tool thinks so too: > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc > FAIL forbidden patterns > forbidden pattern: Font Awesome icons need the aria-hidden attribute for > accessibility purpose (see bug 25166) (line 169) > forbidden pattern: Font Awesome icons need the aria-hidden attribute for > accessibility purpose (see bug 25166) (line 282) Good catch, I added to follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 01:47:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 00:47:09 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 --- Comment #4 from Fridolin Somers --- Thanks a lot for the real patch Jonathan :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 02:05:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 01:05:10 +0000 Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin Somers --- QA scripts will show : FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt FAIL spelling DONT' ==> DON'T False alert It is not a displayed text it is the value of cookie 'always_show_holds' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 02:06:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 01:06:32 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #22 from Fridolin Somers --- Awesome work ! I add a minor typo fix $tem => $item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 02:06:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 01:06:49 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #23 from Fridolin Somers --- Created attachment 130033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130033&action=edit Bug 29562: (follow-up) typo $tem in opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 02:22:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 01:22:32 +0000 Subject: [Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 02:28:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 01:28:22 +0000 Subject: [Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 --- Comment #21 from Fridolin Somers --- I validated unit test with Bug 29975 applied. Otherwise it fails, independently of this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 03:20:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 02:20:39 +0000 Subject: [Koha-bugs] [Bug 29990] New: Show authority heading use in search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990 Bug ID: 29990 Summary: Show authority heading use in search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org In authority records, 008/14-16 consists of characters which indicate what the heading can be used for. It would be useful to display this information in a human-readable way in authority search results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 03:20:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 02:20:54 +0000 Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 04:22:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 03:22:29 +0000 Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 04:22:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 03:22:36 +0000 Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990 --- Comment #1 from Aleisha Amohia --- Created attachment 130034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130034&action=edit Bug 29990: Add ShowHeadingUse system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 04:22:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 03:22:42 +0000 Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990 --- Comment #2 from Aleisha Amohia --- Created attachment 130035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130035&action=edit Bug 29990: Show authority appropriate heading use on search results Authority heading use is based on authority MARC 008/14-16. This could be useful to show on authority search results, if new system preference ShowHeadingUse is enabled. To test: 1. Apply patches, update database, restart services 2. Go to Koha Administration -> system preferences -> searching tab. Notice new ShowHeadingUse system preference is disabled. Leave it disabled for now. 3. Do an authority search. Confirm it works as expected and no new information is shown since ShowHeadingUse is disabled. 4. Do a biblio search and edit a record. Go to one of the authority fields (1xx, 6xx or 7xx) and launch the authority finder plugin. Do an authority search and confirm it works as expected and no new information is shown since ShowHeadingUse is disabled. 5. Go back to system preferences and enable ShowHeadingUse syspref. 6. Repeat steps 3 and 4 but confirm the 'Heading use' column now shows, and correctly displays what the heading can be used for based on 008/14-16. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 04:24:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 03:24:24 +0000 Subject: [Koha-bugs] [Bug 29990] Show authority heading use in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29990 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Authority heading use is release notes| |based on authority MARC | |008/14-16. This could be | |useful to show on authority | |search results, if new | |system preference | |ShowHeadingUse is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 07:44:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 06:44:24 +0000 Subject: [Koha-bugs] [Bug 29255] Built-in offline circulation broken with SQL error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 07:44:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 06:44:25 +0000 Subject: [Koha-bugs] [Bug 22671] Warn the user in offline circulation if applicationCache isn't supported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671 Bug 22671 depends on bug 29255, which changed state. Bug 29255 Summary: Built-in offline circulation broken with SQL error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 07:44:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 06:44:25 +0000 Subject: [Koha-bugs] [Bug 29228] Use Flatpickr on offline circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Bug 29228 depends on bug 29255, which changed state. Bug 29255 Summary: Built-in offline circulation broken with SQL error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 07:44:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 06:44:26 +0000 Subject: [Koha-bugs] [Bug 29371] Built-in offline circulation broken in SQL strict mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29371 Bug 29371 depends on bug 29255, which changed state. Bug 29255 Summary: Built-in offline circulation broken with SQL error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 07:52:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 06:52:28 +0000 Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #25 from Fridolin Somers --- Great, thanks a lot Owen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:40:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:40:49 +0000 Subject: [Koha-bugs] [Bug 29982] Show itemtype in holds table on patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #7 from Magnus Enger --- > Magnus, it looks like that for me on both pages: > > http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=5 > http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=5 Looks OK when I test... From your screenshot, it looks like the header row is created ok, but then the cells in the column below it are not created, resulting in cells not being under their proper headings. Those cells are created from JavaScript. Did you make a hard reload (Ctrl+Shift+R)? Could you verify you have this code in http://localhost:8081/intranet-tmpl/prog/js/holds_21.1200011.js: { "mDataProp": function( oObj ) { return oObj.itemtype_descr && oObj.itemtype_descr.escapeHtml() || ""; } }, Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:53:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:53:52 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 --- Comment #24 from Fridolin Somers --- I've mailled them directly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:30 +0000 Subject: [Koha-bugs] [Bug 19865] Side scroll bar in z39.50 MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:33 +0000 Subject: [Koha-bugs] [Bug 19865] Side scroll bar in z39.50 MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 --- Comment #9 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:36 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:38 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:40 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:43 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #49 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:45 +0000 Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:47 +0000 Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 --- Comment #17 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:50 +0000 Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:52 +0000 Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #26 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:55 +0000 Subject: [Koha-bugs] [Bug 29482] Terminology: This item belongs to another branch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:57 +0000 Subject: [Koha-bugs] [Bug 29482] Terminology: This item belongs to another branch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:56:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:56:59 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:01 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #24 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:04 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:06 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #24 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:08 +0000 Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium lib is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:10 +0000 Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium lib is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:12 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:14 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 --- Comment #12 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:16 +0000 Subject: [Koha-bugs] [Bug 29862] TestBuilder.t fails with ES enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:19 +0000 Subject: [Koha-bugs] [Bug 29862] TestBuilder.t fails with ES enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:21 +0000 Subject: [Koha-bugs] [Bug 29895] Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:23 +0000 Subject: [Koha-bugs] [Bug 29895] Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:25 +0000 Subject: [Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:27 +0000 Subject: [Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 --- Comment #22 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:30 +0000 Subject: [Koha-bugs] [Bug 29949] Remove use of title-numeric sorting routine from OPAC datatables JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29949 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:32 +0000 Subject: [Koha-bugs] [Bug 29949] Remove use of title-numeric sorting routine from OPAC datatables JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29949 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:34 +0000 Subject: [Koha-bugs] [Bug 29967] Increase size of description fields for authorized values in templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29967 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 08:57:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 07:57:36 +0000 Subject: [Koha-bugs] [Bug 29967] Increase size of description fields for authorized values in templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29967 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 09:08:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 08:08:34 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 09:35:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 08:35:34 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #13 from Jonathan Druart --- (In reply to Fridolin Somers from comment #12) > (In reply to Jonathan Druart from comment #11) > > This is going backward IMO, why not move to DBIC/Koha::Object instead? > > Indeed we should be go back to direct SQL even if faster. Is there a "not" missing here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 09:56:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 08:56:48 +0000 Subject: [Koha-bugs] [Bug 29991] New: Need to use invoice number as matchpoint when loading MARC file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29991 Bug ID: 29991 Summary: Need to use invoice number as matchpoint when loading MARC file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: jeremy.evans at phe.gov.uk QA Contact: testopia at bugs.koha-community.org Our print book suppliers provide shelf ready books. When the items are shipped we receive an email containing the MARC records. These files relate to all of the copies shipped on a specific invoice. The order was done via EDI and the invoice would already be imported via EDI into Koha before we receive this Marc file. The records autocreated in Koha via EDI when the order was placed would not contain the copy barcode as the supplier will place this in the book during servicing before shipping the item. By default the MARC load is expecting the item barcode to be already in Koha to use as a match to update the copy record. This isn't the case for our shelf ready books. If we use the ISBN match to load the MARC file, we often find that a duplicate copy is created during the load. In some cases there are other existing copies held in our stock which should not be updated. What we need is an option to Select the invoice number (& possibly the supplier first), and load the MARC file. it should then update only the copies that are linked to that invoice so the item barcode and call number for those copies can be updated during the load. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 09:57:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 08:57:01 +0000 Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 09:57:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 08:57:37 +0000 Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |nick at bywatersolutions.com |com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 11:21:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 10:21:59 +0000 Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130004|0 |1 is obsolete| | --- Comment #3 from Jérémy Breuillard --- Created attachment 130036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130036&action=edit Bug 29983: Display the pretend claim column in overdue.tt This patch displays the column "Return claims" from the page "moremember.pl" to the page "overdues.pl". Rebase on master. Test plan: 1)Use a patron with at least 1 item who should be checked out soon 2)Home > Patron > Patron details for [name] 3)Click on the 'Checkout' button down the page to show the full table and notice the "Return Claims" column 4)Now go to Home > Circulation > Overdues 5)Find the patron who has to check out and have a look at the table 6)Apply patch and repeat 4) and 5) -> the "Return Claim" column is now displayed on the table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 11:28:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 10:28:19 +0000 Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130036|0 |1 is obsolete| | --- Comment #4 from Jérémy Breuillard --- Created attachment 130037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130037&action=edit Bug 29983: Display the pretend claim column in overdue.tt This patch displays the column "Return claims" from the page "moremember.pl" to the page "overdues.pl". Rebase on master. Test plan: 1)Use a patron with at least 1 item who should be checked out soon 2)Home > Patron > Patron details for [name] 3)Click on the 'Checkout' button down the page to show the full table and notice the "Return Claims" column 4)Now go to Home > Circulation > Overdues 5)Find the patron who has to check out and have a look at the table 6)Apply patch and repeat 4) and 5) -> the "Return Claim" column is now displayed on the table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 11:31:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 10:31:45 +0000 Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 11:44:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 10:44:29 +0000 Subject: [Koha-bugs] [Bug 29992] New: Default Apache config should contain CGIPassAuth directive Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29992 Bug ID: 29992 Summary: Default Apache config should contain CGIPassAuth directive Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org By default, authorization headers are stripped out by Apache and therefore do not reach the underlying CGI script. This causes problems when Koha is receiving API requests that contain them as the client just receives a 401 response, even if a valid token was provided. I propose we add the CGIPassAuth directive to the API Directory blocks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 11:45:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 10:45:04 +0000 Subject: [Koha-bugs] [Bug 29992] Default Apache config should contain CGIPassAuth directive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29992 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 11:47:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 10:47:48 +0000 Subject: [Koha-bugs] [Bug 29992] Default Apache config should contain CGIPassAuth directive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29992 --- Comment #1 from Andrew Isherwood --- Created attachment 130038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130038&action=edit Bug 29992: Add CGIPassAuth directive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 11:48:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 10:48:00 +0000 Subject: [Koha-bugs] [Bug 29992] Default Apache config should contain CGIPassAuth directive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29992 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 12:19:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 11:19:34 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 --- Comment #2 from Jonathan Druart --- Created attachment 130039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130039&action=edit Bug 29136: Ajaxify the patron search when placing a hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 12:19:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 11:19:58 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Status|NEW |Needs Signoff --- Comment #3 from Jonathan Druart --- Nick, would that work for you? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 12:28:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 11:28:05 +0000 Subject: [Koha-bugs] [Bug 29478] flatpickr misses quick shortcut to "Today" date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29239 Depends on|29239 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 12:28:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 11:28:05 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29478 | Depends on| |29478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29478 [Bug 29478] flatpickr misses quick shortcut to "Today" date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 12:28:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 11:28:48 +0000 Subject: [Koha-bugs] [Bug 29228] Use Flatpickr on offline circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28376 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 [Bug 28376] Flatpickr introduction for datetime picker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 12:28:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 11:28:48 +0000 Subject: [Koha-bugs] [Bug 28376] Flatpickr introduction for datetime picker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29228 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 [Bug 29228] Use Flatpickr on offline circulation page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 12:47:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 11:47:22 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 --- Comment #25 from Katrin Fischer --- I think in general the institution should pick what they what want to be listed as. Not everyone has an official English name to use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 12:53:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 11:53:44 +0000 Subject: [Koha-bugs] [Bug 29993] New: Syndetics cover images do not display in browse shelf when scrolling from the first page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Bug ID: 29993 Summary: Syndetics cover images do not display in browse shelf when scrolling from the first page Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucy.vaux-harvey at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org If you have SyndeticsCoverImages enabled the browse shelf display of cover images is broken. The first loaded page of the shelf browse displays the images correctly but if you click Next or Previous to scroll to a new page the images do not display. For example https://libsearch.aub.ac.uk/cgi-bin/koha/opac-detail.pl?biblionumber=1276&shelfbrowse_itemnumber=1539#holdings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:00:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:00:39 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:07:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:07:11 +0000 Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- This seems to be working well except on the checkout page. The "Claim returned" button in the table of checkouts doesn't trigger the modal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:07:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:07:50 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #15 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #14) > Marcel, let me know if you are not going to work on this one in a short > term, please. Thanks! Thanks for your patience. I will have another look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:10:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:10:32 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #21 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #19) > Created attachment 130016 [details] [review] > Bug 29458: Fix selenium test > > The authentication.t selenium tests (and a couple of others) were > failing with: > Error while executing command: element not interactable: Element class="btn btn-primary" type="submit"> could not be scrolled into view at > /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 411. at > /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 356. > > We changed the other of the form, and t::lib::Selenium::submit_form was > not getting the correct (first) form. The one from the auth modal was > retrieved and submit button was clicked. Selenium raised an error as it > is not displayed. > The ->is_displayed selenium method does not work, as per the doc > """ > Note: This does *not* tell you an element's 'visibility' property; as it > still takes up space in the DOM and is therefore considered 'displayed'. > """ > https://metacpan.org/pod/Selenium::Remote::WebElement#is_displayed > > "The internet" is saying we should be able to use the following in our > xpath expression: not(ancestor::div[contains(@style,'display:none')] > but it actually only works if the display:none rule is defined on the > node (not from .css). Which does not work for us. > > The only solution I found is to check for the size of the element, which > is (0,0) if not effectively displayed. Thanks. Too bad that we need such workarounds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:10:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:10:55 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #22 from Marcel de Rooy --- Change status to ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:24:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:24:35 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- This looks like it still needs attention though: =head3 messages my @messages = @{ $bool->messages }; Returns the I objects that were recorded. =cut sub messages { my ( $self ) = @_; $self->{_messages} = [] unless defined $self->{_messages}; return $self->{_messages}; } Kind of strange btw that we add a lot of code there? Koha::Result::Boolean->new(0)->add_message({ message => $error }); Please provide feedback! Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:25:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:25:04 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #16 from Marcel de Rooy --- Back to blocked: base report fails qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:33:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:33:40 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #15 from Marcel de Rooy --- Hmm. Should we have done something like: $image = GD::Barcode->new('QRcode', $barcode, { Ecc => "M", ModuleSize => $qrcode_modulesize } )->plot->png(); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:44:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:44:03 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #16 from Marcel de Rooy --- GD::Barcode::QRcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:44:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:44:51 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:44:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:44:54 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129838|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 130040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130040&action=edit Bug 20894: Add barcode size parameters to /svc/barcode This patch adds a couple of new parameters to the barcode generator service: "modulesize," which controls the size of QRcodes*, and "height," which can be applied to all other barcode types. * The "modulesize" number refers to the pixel dimensions of each black and white square in the generated QRcode. The dimensions in "squares" of the QR code depends on how much data is being encoded. For QRcodes, one default parameters is used: An error-correction level of "M" (Medium, https://en.wikipedia.org/wiki/QR_code#Error_correction). To test, apply the patch and restart services. Test various settings to confirm that barcodes are displayed correctly: http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=QRcode&modulesize=3&barcode=https%3A%2F%2Fkoha-community.org http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=QRcode&modulesize=6&barcode=https%3A%2F%2Fkoha-community.org http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Code39&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Code39&height=20&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=COOP2of5&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=IATA2of5&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Industrial2of5&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=ITF&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Matrix2of5&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=NW7&height=50&barcode=32000000203734 Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:45:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:45:06 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:47:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:47:38 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 --- Comment #6 from Marcel de Rooy --- QA Comment: Just wondering: should I view a QR code as a barcode? Probably. Note also that the QR code comes from GD::Barcode::QRcode. Apparently GD passes it on or so ? Answering my first question: A QR code is a type of barcode that can be read easily by a digital device and which stores information as a series of pixels in a square-shaped grid. OK NP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 13:50:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 12:50:24 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #17 from Marcel de Rooy --- Back to ASSIGNED. If all the stuff that comes before this one, gets clearer, I will resubmit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 14:17:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 13:17:16 +0000 Subject: [Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129873|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 130041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130041&action=edit Bug 29952: [20.11.x] Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 14:18:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 13:18:10 +0000 Subject: [Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #7 from Katrin Fischer --- Tested the 20.11 patch and it works like a charm, thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 14:51:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 13:51:25 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 --- Comment #5 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #4) > This looks like it still needs attention though: > > =head3 messages > > my @messages = @{ $bool->messages }; > > Returns the I objects that were recorded. > > =cut > > sub messages { > my ( $self ) = @_; > > $self->{_messages} = [] > unless defined $self->{_messages}; > > return $self->{_messages}; > } This looks correct to me, Koha::Result::Boolean is not inheriting from Koha::Object. > Kind of strange btw that we add a lot of code there? > Koha::Result::Boolean->new(0)->add_message({ message => $error }); Can you detail what you mean here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 14:52:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 13:52:00 +0000 Subject: [Koha-bugs] [Bug 29994] New: Single label pdf export not working Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994 Bug ID: 29994 Summary: Single label pdf export not working Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: isabel.pineda at ds.edu.sv QA Contact: testopia at bugs.koha-community.org Since update from 21.05 to 21.11 the export of single labels to pdf is not working anymore. If there are at least 2 labels in a label batch, it works, but single labels cannot be exported to pdf. I have just updated from 21.11.01 to 21.11.02, but in the new version this has not been fixed yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 14:52:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 13:52:25 +0000 Subject: [Koha-bugs] [Bug 29995] New: Rest API Authentication Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29995 Bug ID: 29995 Summary: Rest API Authentication Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: lokeshchaudhary at icloudems.com CC: tomascohen at gmail.com Created attachment 130042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130042&action=edit this problem comes under restful api ever the enable the basic auth and o2aurh from staff interface. http://localhost:8080/api/v1/patrons when we hit this url after login in staff interface we get the proper result Response : [{"address":null,"address2":null,"altaddress_address":null,"altaddress_address2":null,"altaddress_city":null,"altaddress_country":null,"altaddress_email":null,"altaddress_notes":null,"altaddress_phone":null,"altaddress_postal_code":null,"altaddress_state":null,"altaddress_street_number":null,"altaddress_street_type":null,"altcontact_address":null,"altcontact_address2":null,"altcontact_city":null,"altcontact_country":null,"altcontact_firstname":null,"altcontact_phone":null,"altcontact_postal_code":null,"altcontact_state":null,"altcontact_surname":null,"anonymized":false,"autorenew_checkouts":true,"cardnumber":"1","category_id":"S","check_previous_checkout":"inherit","city":null,"country":null,"date_enrolled":null,"date_of_birth":null,"date_renewed":null,"email":null,"expiry_date":"2099-12-31","fax":null,"firstname":"Koha","gender":null,"incorrect_address":false,"initials":"","lang":"default","last_seen":null,"library_id":"MPL","login_attempts":0,"mobile":null,"opac_notes":null,"other_name":null,"overdrive_auth_token":null,"patron_card_lost":false,"patron_id":1,"phone":null,"postal_code":null,"privacy":1,"privacy_guarantor_checkouts":0,"privacy_guarantor_fines":false,"relationship_type":null,"restricted":false,"secondary_email":null,"secondary_phone":null,"sms_number":null,"sms_provider_id":null,"staff_notes":null,"state":null,"statistics_1":null,"statistics_2":null,"street_number":null,"street_type":null,"surname":"Admin","title":null,"updated_on":"2021-11-13T21:03:07+05:30","userid":null},{"address":"3438 Library .....}] if we hit the below url like this : http://localhost:8080/api/v1/patrons with api keys and seceret on postman we get the resposnse : { "error": "Authentication failure." } Please try to provide a solution for this problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 14:52:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 13:52:51 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Depends on|29660 |28782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 [Bug 28782] Get rid of custom query param list creation for request.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 [Bug 29660] reserve/request.pl should not deal with biblioitem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 14:52:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 13:52:51 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 [Bug 29136] Patron search on request.pl has performance and display issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 14:52:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 13:52:51 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29136 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 [Bug 29136] Patron search on request.pl has performance and display issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 14:54:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 13:54:16 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #23 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #22) > Change status to ? No need to, there is the additional_work_needed keyword. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 15:02:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 14:02:32 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #5) > (In reply to Marcel de Rooy from comment #4) > This looks correct to me, Koha::Result::Boolean is not inheriting from > Koha::Object. Okay > > Kind of strange btw that we add a lot of code there? > > Koha::Result::Boolean->new(0)->add_message({ message => $error }); > > Can you detail what you mean here? Forget that. Result here confused me a bit. Surely it not a Schema::Result, but what is a Koha::Result actually? No answer needed here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 15:05:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 14:05:44 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 15:05:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 14:05:47 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130018|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 130043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130043&action=edit Bug 29785: Rename Koha::Object->message with ->object_messages It will conflict with other ->messages methods, it's too generic. Bug 29230 needs Koha::Patron->messages to return Koha::Patron::Messages for instance. Test plan: Confirm that the tests modified by this patch still pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 15:06:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 14:06:15 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 15:07:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 14:07:18 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 15:24:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 14:24:07 +0000 Subject: [Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold only updates when printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- I don't really understand the change. Isn't it weird to force the submission when the button has a data-dismiss="modal"? Shouldn't we remove this "dismiss" attribute instead? We had lot of regressions on this page, I am a bit reluctant to submit when we were supposed not to... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 15:24:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 14:24:20 +0000 Subject: [Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold only updates when printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nicolas.legrand at bulac.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 15:40:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 14:40:39 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 15:40:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 14:40:43 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128162|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 130044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130044&action=edit Bug 29230: Add Koha::Patron->messages Add methods to return the messages attached to a patron. It will add the capability to access them from notice templates. Test plan: Define some messages for a given patron Go to the circulation page of the patron and confirm that they are still displayed Test the notice templates: Add to HOLD_SLIP the following content """ [% SET messages = borrower.messages %] [% IF messages.count %] Messages:
    [% FOR m IN messages.search( message_type => 'L' ) %]
  • [% m.message %]
  • [% END %]
[% END %] """ To display all the messages from staff ('L') Adapt following your needs. Signed-off-by: Fridolin Somers Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 15:45:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 14:45:24 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Jonathan Druart --- Tests are missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 15:56:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 14:56:03 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.05.09 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:20:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:20:06 +0000 Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart --- Please have a look at https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:21:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:21:51 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #16 from Jonathan Druart --- Next steps? Is there a plan here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:21:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:21:58 +0000 Subject: [Koha-bugs] [Bug 29996] New: Show an alert on main page when serial issues are late Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996 Bug ID: 29996 Summary: Show an alert on main page when serial issues are late Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:23:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:23:39 +0000 Subject: [Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996 --- Comment #1 from Julian Maurice --- Created attachment 130045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130045&action=edit Bug 29996: Show an alert on main page when serial issues are late The alert is disabled by default and can be enabled for each subscription individually. Alerts are shown on the main page only for subscriptions that have this feature enabled and that are of the same library than the connection library Test plan: 1. Run `installer/data/mysql/updatedatabase.pl` and `misc/devel/update_dbix_class_files.pl --koha-conf`. Restart Koha if needed. 2. Create a subscription, set its library to your connection library and enable "Warn when late" 3. The automatically generated serial issue should have the status "Expected". Change it to "Late". 4. Go back to the main page. You should see an alert with a link to your subscription 5. Change your library using the menu in the upper right corner of the screen. Now the alert should not appear. 6. Set your library back to its original value to make the alert reappear. 7. Edit your subscription and disable "Warn when late". Verify that the alert does not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:23:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:23:57 +0000 Subject: [Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:27:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:27:57 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- Before: https://snipboard.io/HLlery.jpg After : https://snipboard.io/gjpMyc.jpg We are loosing some borders and the tabs are less obvious. Is that expected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:30:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:30:53 +0000 Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Patch doesn't apply --- Comment #5 from Jonathan Druart --- CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:39:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:39:10 +0000 Subject: [Koha-bugs] [Bug 29832] Make library column in desk list sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:39:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:39:14 +0000 Subject: [Koha-bugs] [Bug 29832] Make library column in desk list sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129284|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 130046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130046&action=edit Bug 29832: Make library column in desk list sortable This patch makes minor updates to the DataTable configuration on the Circulation Desks Administration page. Redundant options are removed and existing options are updated to use current DataTables syntax. To test, apply the patch and make sure that the UseCirculationDesks system preference is enabled. - Go to Administration -> Circulation desks. - Add multiple circulation desks if necessary, at multiple libraries. - The "Desk" column should be sorted by default, and the "Actions" column should not be sortable. - The "Library" column should be sortable. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:39:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:39:18 +0000 Subject: [Koha-bugs] [Bug 29832] Make library column in desk list sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 --- Comment #4 from Jonathan Druart --- Created attachment 130047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130047&action=edit Bug 29832: Use KohaTable NoSort is defined in KohaTable Also add noExport Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:47:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:47:04 +0000 Subject: [Koha-bugs] [Bug 29997] New: Allow to send email notification when a serial issue is late Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Bug ID: 29997 Summary: Allow to send email notification when a serial issue is late Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:48:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:48:47 +0000 Subject: [Koha-bugs] [Bug 29997] Allow to send email notification when a serial issue is late In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 --- Comment #1 from Julian Maurice --- Created attachment 130048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130048&action=edit Bug 29997: Allow to send email notification when a serial issue is late This patch adds the ability to define, for each subscription, a letter that will be sent whenever an issue is automatically marked as late by the script misc/cronjobs/serialsUpdate.pl. If no letter is defined for a subscription, then no letter will be sent. The letter will be sent to the subscription's manager (the staff member who created or last modified the subscription). Test plan: 1. Create a letter in Tools › Notices & slips for module "Serials". Fill the Email template. 2. Create a new subscription, with a grace period of 1 day, and set the new field "Late issue notification" to the letter you just created. Set the first issue publication date and subscription start date to two days ago 3. Run `misc/cronjobs/serialsUpdate.pl -v -c`. 4. The first serial issue of your subscription should have been automatically marked as late. Now verify that the table message_queue contains a new message corresponding to this serial issue. The message's contents should be what you defined in step 1. The message should be addressed to the subscription's manager (you) Technical note: The "subscription" table contained a column named "librarian", which contained the userid of the patron who created or last modified the subscription, but there was no foreign key constraint referencing the borrowers table. So this patch also adds a new column "manager_id" which contains the borrowernumber of the patron who created or last modified the subscription, and it also adds the foreign key constraint. The atomicupdate script tries to fill the new "manager_id" column by searching patrons by their "userid", which might fail, so it's normal to have some NULL values in "manager_id" at the end. The "librarian" column is removed at the end of the script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 16:49:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 15:49:00 +0000 Subject: [Koha-bugs] [Bug 29997] Allow to send email notification when a serial issue is late In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 17:03:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 16:03:54 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #34 from Jonathan Druart --- About patch "Bug 23991: (QA follow-up) Save some DB queries". I am not sure about it, I always privileged iterator over retrieving the whole set. If this is what we really want it needs to be deeply investigated and that we agree on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 17:09:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 16:09:08 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 17:09:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 16:09:13 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #35 from Jonathan Druart --- Created attachment 130049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130049&action=edit Bug 23991: Fix conflict with bug 28941 Well, this patchset fixed the security bug... Redoing on top of bug 28941 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 17:18:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 16:18:25 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #68 from Caroline Cyr La Rose --- Patch doesn't apply :/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 17:36:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 16:36:21 +0000 Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 17:36:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 16:36:25 +0000 Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129815|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 130050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130050&action=edit Bug 29713: Make item table when placing an item level hold sortable This patch modifies the holds page in the OPAC so that users selecting a specific item to place a hold on can sort the table of items. Note: This patch includes some whitespace changes, so diff accordingly. To test, apply the patch and go to Administration -> Circulation and fine rules to make sure at least one item type in your system has "OPAC item level holds" set to "allow." - Log in to the OPAC as a user who can place holds. - Search the catalog for items which will accept item-level holds. - Place a hold on one of the results, and click the "Show more options" link on the holds page. - Check the "specific item" radio button. - A table of items should be displayed. Confirm that the table is sortable. - Perform the same test when placing a hold on multiple titles. Confirm that each table of items is sortable. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 17:43:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 16:43:47 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 --- Comment #4 from Owen Leonard --- (In reply to Jonathan Druart from comment #3) > We are loosing some borders and the tabs are less obvious. Is that expected? No, I think you are seeing cached CSS. Please clear the browser cache and try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 17:52:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 16:52:33 +0000 Subject: [Koha-bugs] [Bug 29982] Show itemtype in holds table on patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #8 from Lucas Gass --- OK, my apologies Magnus. As soon as I cleared my cache everything looks fine. It must have been the JS. The only thing now is the QA tool would git you to rename your commit message: "Bug 29982 - Show itemtype in holds table on patron details" * Commit title does not start with 'Bug XXXXX: ' - 55787708a3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:00:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:00:42 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:00:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:00:47 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121537|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 130051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130051&action=edit Bug 11083: Add ability to generate authority summary using XSLT This patch only affects authority search results in the staff interface. It adds a new system preference AuthorityXSLTResultsDisplay. If set, each authority search result MARCXML will be transformed using the XSLT at the given filename or URL. The output will be displayed in place of the default summary. If errors occur, the XSLT is ignored and the default summary is displayed. The syspref value can contain {langcode} and {authtypecode} which will be replaced by the appropriate value (resp. current language and authority type code) Test plan: 1. Apply patch and run updatedatabase 2. Verify that authority search results are not affected yet. 3. Create an XSLT file (for instance in /home/koha/xslt/en/GEOGR_NAME.xsl) 4. Set AuthorityXSLTResultsDisplay syspref value to /home/koha/xslt/{langcode}/{authtypecode}.xsl 5. Do an authority search that returns GEOGR_NAME results. Verify that the summary matches what you expect from your XSLT 6. Do an authority search that returns authorities of other types. Verify that the default summary is displayed. Example of a minimal XSLT: authority-summary Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:00:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:00:52 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128913|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 130052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130052&action=edit Bug 11083: Add sample XSLT for UNIMARC authorities Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:06:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:06:05 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #10 from David Nind --- Testing notes (koha-testing-docker): - Tested using provided example XSLT files for MARC21 and UNIMARC. - Visual differences in the authority search results that I noticed: . MARC21: removes the summary text . UNIMARC: adds bullet points in front of the summary text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:07:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:07:43 +0000 Subject: [Koha-bugs] [Bug 29998] New: Replace the use of jQueryUI tabs on item types administration page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Bug ID: 29998 Summary: Replace the use of jQueryUI tabs on item types administration page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 29277 Blocks: 29226 As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should replace the use of the jQueryUI tabs component on the item types administration page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:07:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:07:43 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 [Bug 29998] Replace the use of jQueryUI tabs on item types administration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:07:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:07:43 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 [Bug 29998] Replace the use of jQueryUI tabs on item types administration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:09:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:09:27 +0000 Subject: [Koha-bugs] [Bug 29999] New: Replace the use of jQueryUI tabs on authorized values administration page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 Bug ID: 29999 Summary: Replace the use of jQueryUI tabs on authorized values administration page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 29277 Blocks: 29226 As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should replace the use of the jQueryUI tabs component on the authorized values administration page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:09:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:09:27 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:09:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:09:27 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:11:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:11:06 +0000 Subject: [Koha-bugs] [Bug 30000] New: Replace the use of jQueryUI tabs on the search engine configuration page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30000 Bug ID: 30000 Summary: Replace the use of jQueryUI tabs on the search engine configuration page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 29277 Blocks: 29226 As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should replace the use of the jQueryUI tabs component on the search engine configuration (Elasticsearch) page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:11:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:11:06 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30000 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30000 [Bug 30000] Replace the use of jQueryUI tabs on the search engine configuration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:11:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:11:06 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30000 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30000 [Bug 30000] Replace the use of jQueryUI tabs on the search engine configuration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 18:23:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 17:23:14 +0000 Subject: [Koha-bugs] [Bug 11083] Authority Search Result Display should be XSLT Driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement enables release notes| |customising the authority | |search results summary in | |the staff interface using | |XSLT (for MARC21 and | |UNIMARC). | | | |Key features; | |- | |Use the new system | |preference | |AuthorityXSLTResultsDisplay | |to set the location of the | |XSLT file, either the full | |path to a file on the Koha | |server or a URL. | |- The | |system preference value can | |contain {langcode} and | |{authtypecode} which will | |be replaced by the | |appropriate value. | |- If | |errors occur, the custom | |XSLT file is ignored and | |the default summary is | |displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 19:21:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 18:21:17 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker Priority|P5 - low |P1 - high --- Comment #5 from Mason James --- bump severity to fix ktd/jenkins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 19:25:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 18:25:39 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #36 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #34) > About patch "Bug 23991: (QA follow-up) Save some DB queries". I am not sure > about it, I always privileged iterator over retrieving the whole set. > If this is what we really want it needs to be deeply investigated and that > we agree on it. Another option would've been to calculate the count and add a new template param. I decided to minimize the changes to your patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 19:25:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 18:25:49 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #13 from Lucas Gass --- Sorry to say, I cannot get this patchset to apply cleanly to master now. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 20:38:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 19:38:13 +0000 Subject: [Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 20:38:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 19:38:16 +0000 Subject: [Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 --- Comment #1 from Owen Leonard --- Created attachment 130053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130053&action=edit Bug 29999: Replace the use of jQueryUI tabs on authorized values administration page This patch updates the authorized values edit interface so that it uses Bootstrap tabs instead of jQueryUI tabs for displaying icon sets. Normally Bootstrap tabs don't have to be initiated via JavaScript, but this page requires some JS to select the first tab as active if no other tabs are active. Because of the way the template works it's not simple to do it via template logic, so in this case some JS helps. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Authorized values in the staff interface. - Select a category and then add or edit an authorized value in that category. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 21:11:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 20:11:55 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 --- Comment #16 from The Minh Luong --- Created attachment 130054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130054&action=edit Bug 28576: Update the maximum size of an image. This patch modifies the maximum size of a patron's image, from 500KB to 2MB. Also, in Home/Patrons/anyPatron, when you try to add an image to a patron, you can now see the supported file types AND the maximum size. The following places are affected by this patch: - Home/Patrons/anyPatron - Home/Tools/Upload patron images - Home/Tools/Patron card creator/Images To test: 1)Search for any patron and go to his page. 2)Hover over the image area on the left and click on the "Add" button. 3)Notice that the message above the choose file button only specifies file types without the maximum size. 4)Add an image bigger than 500KB. 5)Nothing happens. (This is because the maximum size is 5KB) 6)Apply the patch. 7)Repeat steps from 1 to 3. 8)Notice that the message now includes the maximum size. 9)Add an image bigger than 500KB, but smaller than 2MB. 10)The image is succesfully uploaded. 11)Add an image bigger than 2MB. 12)Nothing happens. (The maximum size is now 2MB) 13)Repeat the steps 9 to 12 in "Home/Tools/Upload patron images" and "Home/Tools/Patron card creator/Images". 14)Notice that the maximum size is updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 21:13:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 20:13:25 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the-minh.luong at inlibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 21:19:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 20:19:15 +0000 Subject: [Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 21:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 20:19:18 +0000 Subject: [Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130053|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 130055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130055&action=edit Bug 29999: Replace the use of jQueryUI tabs on authorized values administration page This patch updates the authorized values edit interface so that it uses Bootstrap tabs instead of jQueryUI tabs for displaying icon sets. Normally Bootstrap tabs don't have to be initiated via JavaScript, but this page requires some JS to select the first tab as active if no other tabs are active. Because of the way the template works it's not simple to do it via template logic, so in this case some JS helps. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Authorized values in the staff interface. - Select a category and then add or edit an authorized value in that category. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit page. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 21:21:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 20:21:09 +0000 Subject: [Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #3 from Lucas Gass --- Note: To get this to look right it was necessary for me clear my cache after running 'yarn build'. Once I did it looks and feels exactly the same as when using jQueryUI tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 21:21:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 20:21:22 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 21:23:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 20:23:27 +0000 Subject: [Koha-bugs] [Bug 30001] New: Bridge icons change missing in authorized values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30001 Bug ID: 30001 Summary: Bridge icons change missing in authorized values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 23148 changed bridge icons from GIF to PNG, with an update on database on itemtypes table. Those images can also be used in authorized values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 21:23:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 20:23:36 +0000 Subject: [Koha-bugs] [Bug 30001] Bridge icons change missing in authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30001 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23148 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148 [Bug 23148] Replace Bridge icons with transparent PNG files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 21:23:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 20:23:36 +0000 Subject: [Koha-bugs] [Bug 23148] Replace Bridge icons with transparent PNG files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23148 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30001 [Bug 30001] Bridge icons change missing in authorized values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 21:59:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 20:59:42 +0000 Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com --- Comment #9 from Blou --- Hello David, I read through this thread... which ended on an ellipsis. Amusingly quite on point. I find the discussion on the standard fascinating (exchange is stretched, I realized it was only you keeping notes), but I was lazingly hoping for something practical. Unfortunate, I was so happy to find this bz after such a lenghty search to understand why our biblios with big notes (505$a) indexed on zebra would give us crappy results entries with no title or bib number, where notes is not even considered in results.tt Do you have a suggestion? Where is the 9999 limit, in the end? Because I don't see it anywhere in the code, nor in MARC perl libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 22:40:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 21:40:17 +0000 Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365 --- Comment #10 from Katrin Fischer --- I think I was told you could change the 'record size limit' somewhere in the Zebra config files, but I don't remember where exactly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 22:44:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 21:44:55 +0000 Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365 --- Comment #11 from Katrin Fischer --- > Do you have a suggestion? Where is the 9999 limit, in the end? Because I > don't see it anywhere in the code, nor in MARC perl libraries. This here looks helpful: https://git.koha-community.org/Koha-community/Koha/commit/2660cc8f0bbb7f8d0903aa2145095a43c84c5a8e -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 22:55:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 21:55:54 +0000 Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365 --- Comment #12 from Blou --- Damn, I said Zebra out of habit. I meant Elastic Search. We moved most of our users to ES already. I've never seen that error before when using zebra, btw... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 22:59:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 21:59:12 +0000 Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365 --- Comment #13 from Katrin Fischer --- (In reply to Blou from comment #12) > Damn, I said Zebra out of habit. I meant Elastic Search. We moved most of > our users to ES already. I've never seen that error before when using > zebra, btw... We've recently managed to have some that Zebra would not index. I haven't read about any limitations on size with Elastic, maybe it's another issue there? Filing a separate bug or an email to the mailing list might turn up some ideas. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 1 23:02:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 22:02:47 +0000 Subject: [Koha-bugs] [Bug 29995] Rest API Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29995 --- Comment #1 from Katrin Fischer --- Hi Lokesh, this is likely to be a configuration issue or similar, please consider asking on the mailing list or on IRC where you will reach many more users. Bugzilla should only be used for filing bugs or enhancement requests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 00:00:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 23:00:50 +0000 Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365 --- Comment #14 from David Cook --- (In reply to Blou from comment #9) > Unfortunate, I was so happy to find this bz after such a lenghty search to > understand why our biblios with big notes (505$a) indexed on zebra would > give us crappy results entries with no title or bib number, where notes is > not even considered in results.tt > > Do you have a suggestion? Where is the 9999 limit, in the end? Because I > don't see it anywhere in the code, nor in MARC perl libraries. Yeah... I can't see why the 9999 limit would necessarily cause a problem in Koha unless one was exporting as "usmarc"? If you can provide more details, I can have a think. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 00:59:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 23:59:44 +0000 Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106409|0 |1 is obsolete| | --- Comment #10 from Lari Taskula --- Created attachment 130056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130056&action=edit Bug 24239: Let the ILL module set ad hoc hard due dates The Swedish Libris ILL backend lets librarians store a specific due date when an ILL loan is received. This is stored as a ILL request attribute. This patch adds a syspref that can take the name of the illrequestattribute used to store the specific date. If the syspref is set, and if an item is connected to an ILL request, the due date will be taken from the illrequestattribute, instead of being calculated in the regular way, based on patroncategory and itemtype. To test: - Apply the patch and make sure the atomic database update is run - Use the FreeForm backend to add one ILL request. Take note of the illrequest_id of the request you created. We refer to this as "x" below. - Connect a biblio (with biblionumber y), that has an item with a barcode, to the ILL request directly in the database: UPADTE illrequests SET biblio_id = y WHERE illrequest_id = x; - Add an attribute to the ILL request directly in the database: INSERT INTO illrequestattributes SET illrequest_id = x, type = 'illduedate', value = '2023-01-01'; - Enter 'illduedate' as a value for the ILLUseExactDueDate syspref. - Go to circulation and issue the barcode of the item to the patron associated with the FreeForm ILL request. Verify that the loan gets a due date of 2023-01-01. - Ideally: return the item and issue it again through SIP2 and SCO, and verify that the due date is still 2023-01-01. (I don't think the REST API supports issuing yet?) - Verify that there are no regressions, so that regular calculation of due dates still work, if ILLUseExactDueDate is empty or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 00:59:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Feb 2022 23:59:48 +0000 Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 --- Comment #11 from Lari Taskula --- Created attachment 130057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130057&action=edit Bug 24239: Replace syspref with illrequests column date_due This patch replaces system preference introduced in previous patch with a column "date_due" for table illrequests. To test: 1. prove t/db_dependent/Circulation.t Sponsored-by: imCode Partner AB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 01:08:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 00:08:45 +0000 Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at hypernova.fi --- Comment #12 from Lari Taskula --- As Tomas proposed, I've added a new column illrequests.date_due and it now replaces the attribute/syspref introduced in Magnus's original patch. Populated by backend, and if defined, AddIssue will use it as the due date, but if left null (default behavior), default due date calculation will be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 02:21:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 01:21:10 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #8 from David Cook --- This would be good for self-registered patrons too. I feel like there is a separate bugzilla ticket for that... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 02:53:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 01:53:35 +0000 Subject: [Koha-bugs] [Bug 29992] Default Apache config should contain CGIPassAuth directive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29992 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- That's interesting, although why are you running the API as CGI and not as PSGI through Starman? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 06:57:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 05:57:25 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 06:58:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 05:58:52 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #14 from Fridolin Somers --- Ah I forgot to obsolete a patch after commit message change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:03:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:03:54 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #14 from Fridolin Somers --- Oupsy : > Indeed we should be go back to direct SQL even if faster. Indeed we should not go back to direct SQL even if faster. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:08:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:08:26 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:09:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:09:59 +0000 Subject: [Koha-bugs] [Bug 30002] New: Remove unused xt/perltidyrc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 Bug ID: 30002 Summary: Remove unused xt/perltidyrc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: victor at tuxayo.net QA Contact: testopia at bugs.koha-community.org It doesn't influence the tests at all. After emptying it or removing or setting the max line length to 40 char no error pops. So it was proposed for removal in last dev meeting: http://irc.koha-community.org/koha/2022-01-19#i_2400452 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:10:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:10:24 +0000 Subject: [Koha-bugs] [Bug 30002] Remove unused xt/perltidyrc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2269 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:10:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:10:24 +0000 Subject: [Koha-bugs] [Bug 2269] add a perltidyrc configuration file for perltidy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2269 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30002 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:10:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:10:32 +0000 Subject: [Koha-bugs] [Bug 30002] Remove unused xt/perltidyrc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6986 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:10:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:10:32 +0000 Subject: [Koha-bugs] [Bug 6986] Update perltidyrc file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6986 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30002 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:41:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:41:32 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:41:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:41:36 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129988|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers --- Created attachment 130058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130058&action=edit Bug 29975: (bug 21729 follow-up) Fix api/v1/holds.t Unknown column 'patron_expiration_date' in 'field list' The REST API routes don't need to be aware of the new column patron_expiration_date Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:54:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:54:10 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29605 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 [Bug 29605] DB structure may not be synced with kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:54:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:54:10 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 [Bug 29596] Add Yiddish language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 07:54:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 06:54:58 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 --- Comment #10 from Fridolin Somers --- (In reply to David Nind from comment #8) > I have tested on top of bug 15067. > > After applying 29956 I ran databaseupdate several times (x4) - this makes > the language appear multiple times (x4) as well. > > I'm not sure that is what you meant though... I reproduce. I think we must have Bug 29605 to have constraints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 08:17:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 07:17:51 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 08:17:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 07:17:59 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 08:40:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 07:40:44 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 08:40:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 07:40:46 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 --- Comment #11 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 08:40:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 07:40:48 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 08:40:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 07:40:51 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #49 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 08:40:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 07:40:53 +0000 Subject: [Koha-bugs] [Bug 29943] Fix typo in notices yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29943 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 08:40:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 07:40:55 +0000 Subject: [Koha-bugs] [Bug 29943] Fix typo in notices yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29943 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 08:40:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 07:40:58 +0000 Subject: [Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 08:41:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 07:41:00 +0000 Subject: [Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 09:01:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 08:01:16 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate --- Comment #50 from Jonathan Druart --- This needs to be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 09:04:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 08:04:37 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #51 from Fridolin Somers --- (In reply to Jonathan Druart from comment #50) > This needs to be backported. Ah sure, sorry I misunderstood the meaning of this keyword. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 09:52:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 08:52:08 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |Yiddish (יידיש) language to | |Koha. Yiddish now appears | |as an option for refining | |search results in the staff | |interface advanced search | |(Search > Advanced search > | |More options > Language and | |Language of original) and | |the OPAC (Advanced search > | |More options > Language). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:02:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:02:46 +0000 Subject: [Koha-bugs] [Bug 24991] make restart sip start sip if it isn't running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24993 --- Comment #5 from Jonathan Druart --- This patch looks trivial, but it's not. 1. There is blank line if restart called and sip is stopped. I will fix. 2. There is no consistency on --restart behaviour for debian scripts. Some stop && start, others don't start if was stopped. Not considering blocker but noting it. 3. Wondering if we won't hit the same problem as bug 24993, but for the start command: 170 if [ "$verbose" != "no" ]; then 171 log_daemon_msg "Warning: SIP server not running for ${name}... trying to start" 172 log_end_msg 0 173 fi 174 if is_sip_running ${name}; then 175 return 0 176 else We may not return 0 here if the startup was slow. Do you have this patch applied on production servers? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:02:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:02:46 +0000 Subject: [Koha-bugs] [Bug 24993] koha-sip --restart is too fast, doesn't always start SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24991 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:05:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:05:26 +0000 Subject: [Koha-bugs] [Bug 24991] make restart sip start sip if it isn't running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 --- Comment #6 from Jonathan Druart --- % koha-sip --stop kohadev $ koha-sip --verbose --restart kohadev Starting SIP server for kohadev:. Warning: SIP server not running for kohadev... trying to start:. Not sure this is the best we can do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:06:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:06:32 +0000 Subject: [Koha-bugs] [Bug 24991] make restart sip start sip if it isn't running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129807|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 130059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130059&action=edit Bug 24991: make koha-sip --restart start sip if it is not already running. To test: - make sure SIP is enabled sudo koha-sip --enable inst - make sure SIP is running sudo koha-sip --start inst sudo koha-sip --status inst - restart SIP, make sure it does this normally sudo koha-sip --restart inst - stop SIP, make sure it does this normally sudo koha-sip --stop inst - make sure SIP is not running (wild scenario: oomkiller or similar has killed this or some other thing has happened) sudo koha-sip --status inst - restart sip, make sure it starts SIP instead of silently failing sudo koha-sip --restart inst - check SIP is now running, or that there is an error message if it can't start sudo koha-sip --status inst Signed-off-by: Owen Leonard JD Amended patch: tidy the whole block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:06:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:06:36 +0000 Subject: [Koha-bugs] [Bug 24991] make restart sip start sip if it isn't running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24991 --- Comment #8 from Jonathan Druart --- Created attachment 130060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130060&action=edit Bug 24991: Define noLF for the else block as well An empty line was displayed if --restart was called after --stop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:09:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:09:37 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 --- Comment #69 from Jonathan Druart --- Wainui, ping? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:11:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:11:14 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:11:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:11:19 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129714|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 130061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130061&action=edit Bug 29277: Replace the use of jQueryUI tabs on item circulation alerts page This patch replaces jQueryUI tabs on the item circulation alerts page as a simple example to start the process of switching how we implement tabbed interfaces. The patch bumps the Bootstrap version from 3.3.7 to 3.4.1 and adds the tabs component. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Item circulation alerts. - Confirm that the "Checkout" and "Check-in" tabs look correct and work correctly. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:11:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:11:53 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 --- Comment #6 from Jonathan Druart --- (In reply to Owen Leonard from comment #4) > (In reply to Jonathan Druart from comment #3) > > > We are loosing some borders and the tabs are less obvious. Is that expected? > > No, I think you are seeing cached CSS. Please clear the browser cache and > try again. Indeed! It was sticky! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:36:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:36:39 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:36:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:36:43 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129631|0 |1 is obsolete| | Attachment #129632|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 130062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130062&action=edit Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:36:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:36:47 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #6 from Jonathan Druart --- Created attachment 130063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130063&action=edit Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:38:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:38:03 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:38:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:38:09 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129633|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 130064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130064&action=edit Bug 7374: Add remote image option for authorized values This patch adds the option of using a remote image for an authorized value, just as you can with item types. To test, apply the patch and go to Administration -> Authorized values. - Click "CCODE" to view the collection authorized values. - Edit a collection code. - In the form, under "Choose an icon," there should now be a "Remote image" tab. - Enter a remote image url, e.g. https://via.placeholder.com/50/FF0000/FFFFFF.png - Click "Save." - After the page redirects to the list of collection codes you should see your image in the table next to the code you edited. - Test that you can still edit a collection to set "No image" or to use one of the local image sets. - Test that remote images can also be added when adding a new collection. - Make sure "ccode" is in the "AdvancedSearchTypes" sytem preference. - Go to the catalog's advanced search page and click the "Collection" tab. - You should see your collection image in the list of collections. - Perform the same check in the OPAC. Signed-off-by: Lucas Gass JD amended patch: fix indentation Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:40:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:40:29 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 --- Comment #21 from Jonathan Druart --- All good for me as well. Christopher, it would be great if you could test again once this gets pushed, in case we all missed something! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:47:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:47:43 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128559|0 |1 is obsolete| | Attachment #128560|0 |1 is obsolete| | Attachment #128561|0 |1 is obsolete| | Attachment #128562|0 |1 is obsolete| | Attachment #128563|0 |1 is obsolete| | Attachment #128564|0 |1 is obsolete| | Attachment #128565|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 130065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130065&action=edit Bug 29695: Add new module Koha::Database::Columns This module will contain new strings and make them translatable using Koha::I18N. We will need to improve this module to prevent the dozens of __ calls each time we retrieve the column list. We could either use memcached or add a method to only retrieve columns for a given table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:47:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:47:47 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #18 from Jonathan Druart --- Created attachment 130066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130066&action=edit Bug 29695: Remove GetColumnDefs C4::Templates::GetColumnDefs can easily be replaced using the new Koha::Database::Columns module. Test plan: Go to the import patron tool and confirm that you see the same list of patron's attribute on the import patron form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:47:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:47:51 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #19 from Jonathan Druart --- Created attachment 130067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130067&action=edit Bug 29695: Remove C4::Reports::Guided::_get_column_defs This subroutine was mostly the same as GetColumnDefs, we replace it identically as in the previous patch. Test plan: Translate some strings in another language % gulp po:update --lang es-ES % cd misc/translate # Translate the relevant strings in po/es-ES-messages.po # For instance "Alternate contact: Surname" % perl translate install es-ES Select the language for the interface (enable it in the 'language' syspref first) Create a new guided report and confirm that the columns for the borrowers table are translated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:47:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:47:56 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #20 from Jonathan Druart --- Created attachment 130068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130068&action=edit Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs Same as the previous patch but for the inventory. Test plan: Same as before but test the inventory tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:48:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:48:00 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #21 from Jonathan Druart --- Created attachment 130069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130069&action=edit Bug 29695: Make "modalselect" syspref's values translatable We are using json files to retrieve the list of the DB columns. We can reuse what we have done in the previous patch and display translated strings. Test plan: Search for "unwanted" in the sysprefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:48:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:48:05 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #22 from Jonathan Druart --- Created attachment 130070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130070&action=edit Bug 29695: Remove json files We do no longer need them. Test plan: Confirm that their content are in Koha::Database::Columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:48:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:48:10 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #23 from Jonathan Druart --- Created attachment 130071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130071&action=edit Bug 29695: Remove columns.def No longer in use Test plan: % git grep 'columns.def' does not return relevant occurrences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 10:48:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 09:48:56 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com, oleonard at myacpl.org, | |tomascohen at gmail.com --- Comment #24 from Jonathan Druart --- I think this change is great, could you have a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:04:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:04:14 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124957|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize --- Created attachment 130072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130072&action=edit Bug 27378: Add new 'modaljs' syspref type This commit adds a new 'modaljs' syspref type. This is similar to the existing 'modalselect' syspref type but instead of using a file to create a list of selectable options which are displayed in the modal, it assumes that anything can happen within the modal driven by JS, and whatever happens is going to return a string, that will be saved as the syspref value. In our case, the string will be all the details of the “chunks” concatenated into a string Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:04:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:04:19 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124958|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize --- Created attachment 130073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130073&action=edit Bug 27378: Add sysprefs This commit adds 4 new sysprefs: - CookieConsent - the master on/off for this functionality - ConsentJS - The configuration for JS code that requires consent prior to running. - CookieConsentBar: Allows the admin to specify the HTML that will be displayed in the consent bar that appears at the bottom of the page - CookieConsentPopup: Allows the admin to specify the HTML that will be displayed in the cookie consent popup Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:04:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:04:24 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124959|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize --- Created attachment 130074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130074&action=edit Bug 27378: Add JS to power modaljs This commit adds the Javascript that provides the functionality within the consentJS modaljs modal. It provides the ability to display the current state of any consentJS values and to amend them, as well as add new ones. There is also some refactoring of the existing modalselect functions to allow re-use of existing code between modalselect & modaljs. This refactoring has been minimal and consists of abstracting functionality into functions to allow more wide use. Styles for the consentJS UI were also added. Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:04:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:04:29 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124960|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize --- Created attachment 130075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130075&action=edit Bug 27378: Add cookie consent display to OPAC This commit adds the display of the cookie consent bar and modal to the OPAC. - Adds a new JSConsents template plugin that enables a template to be populated with the contents of the ConsentJS syspref in a prepared, usable form - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate - Adds the ability for both authenticated and unauthenticated users to view and modify their consents either via "your consents" or a new unobtrusive "Your cookies" button in the bottom right of the screen. - Adds unit test for JSConsents.pm Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:04:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:04:34 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124961|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize --- Created attachment 130076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130076&action=edit Bug 27378: Add cookie consent display to staff UI This commit adds the display of the cookie consent bar and modal to the staff interface: - Adds a new cookieconsent.js script that drives the display and functionality of the cookie consent bar and modal - Adds styles for the cookie consent bar and modal - Adds the creation and population of the cookie consent bar and modal, if appropriate Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:04:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:04:40 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124962|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize --- Created attachment 130077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130077&action=edit Bug 27378: Move "Your cookies" to existing bar The new "Your cookies" button that appeared at the bottom right when an unauthenticated user had made their cookie consent selections wasn't ideal. It has now been moved to the top bar, next to "Lists", this feels like a much more sensible place for it. Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:04:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:04:45 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124963|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize --- Created attachment 130078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130078&action=edit Bug 27378: Delete cookies when consent removed We have provided the ability for a user to remove previously granted consent, but we were not removing the cookie associated with that consent. This was a complete oversight on my part. I've introduced an additional bit of metadata for each "consent" defined in the ConsentJS syspref, this allows the admin defining a "consent" to specify a string (which is treated as a regex) that allows us to identify a cookie name associated with that consent. So, for example, if Google Analytics was being added, an identifying string might be '_ga'. This allows us to subsequently remove a cookie that a previously granted consent has set. This commit also adds some missing 'html' filters in koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:04:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:04:51 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124964|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize --- Created attachment 130079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130079&action=edit Bug 27378: Add cookie domain and path A subtlety I missed was that some tracking services, such as Google Analytics, specify a cookie domain and path that differ from the default. E.g. on a site with a domain of demostaff.koha-ptfs.co.uk, the GA cookie will have a domain of '.koha-ptfs.co.uk' and a path of '/', even though the cookie may have been set at a different path. Both of these things makes sense, but of course unless we also specify both of those things when we try to delete a previously set cookie, we cannot. Therefore, I have added two more bits of metadata to each "consent", Cookie Domain and Cookie Path. It is necessary for an admin creating a "consent" entry to know and specify these values. They can be established by looking a cookie set by the service being configured. This adds more complexity to setting up a consent, but we cannot remove previously set cookies without it. Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:04:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:04:56 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124965|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize --- Created attachment 130080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130080&action=edit Bug 27378: (follow-up) Fix update delimiter As suggested by Nick in Comment #64 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:05:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:05:16 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:05:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:05:27 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #87 from Martin Renvoize --- Rebased and ready for QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:05:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:05:38 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #25 from Fridolin Somers --- Oupsy looks like it breaks the test suite, see : https://jenkins.koha-community.org/job/Koha_Master_D10/519/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:15:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:15:08 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #26 from Jonathan Druart --- t/db_dependent/Letters/TemplateToolkit.t .. 5/28 # No tests run! # Failed test 'No tests run for subtest "AR_*"' # at t/db_dependent/Letters/TemplateToolkit.t line 408. # Looks like you planned 8 tests but ran 2. # Looks like you failed 1 test of 2 run. t/db_dependent/Letters/TemplateToolkit.t .. 24/28 # Failed test 'regression tests' # at t/db_dependent/Letters/TemplateToolkit.t line 1028. Account line 24 is not a debit# Looks like your test exited with 11 just after 24. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:16:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:16:41 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:47:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:47:42 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:47:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:47:46 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129982|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 130081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130081&action=edit Bug 28977: Fix cat_issues_top.pl report with strict SQL modes To get the 'Most circulated items' report to run in ONLY_FULL_GROUP_BY Sql mode. Test plan: Turn on strict_sql_modes ( make sure is 1 in KOHA_CONF ) Go to Reports -> Most circulated items submit the form. Without the patch you get an error like: CGI::Compile::ROOT::usr_local_koha_master_reports_cat_issues_top_2epl::calculate(): DBI Exception: DBD::mysql::st execute failed: Expression #4 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'koha_main_v4.items.itemcallnumber' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by [for Statement "SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS `RANK`, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues` LEFT JOIN items USING(itemnumber) LEFT JOIN biblio USING(biblionumber) LEFT JOIN biblioitems USING(biblionumber) LEFT JOIN borrowers USING(borrowernumber) WHERE 1 AND old_issues.issuedate > '2020-08-03' AND old_issues.issuedate < '2021-05-17' AND old_issues.returndate > '2020-08-27' AND old_issues.returndate < '2021-06-01' AND old_issues.branchcode like '403' AND items.itype like 'F' AND ccode like 'FIC' AND borrowers.categorycode like 'ST' group by biblio.biblionumber order by `RANK` DESC"] at /usr/local/koha_master/reports/cat_issues_top.pl line 67 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 With the patch you will see the report results view. Signed-off-by: David Nind JD Amended patch - adjust commit's title Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:48:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:48:43 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121714|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 130082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130082&action=edit Bug 28294: Add 'WrongTransfer' to transfer reason enum This patch adds the 'WrongTransfer' value to the 'reason' enum in the branchtransfers table. This is so we can use it as a reason for the subsequent transfer when a trainsfer is triggered by a checkin at an incorrect branch after transfer has been initiated. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:48:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:48:46 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 --- Comment #22 from Martin Renvoize --- Created attachment 130083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130083&action=edit Bug 28294: Add Koha::Item::Transfer->remedy method and use in updateWrongTransfer This patch is an interim patch to prove that the new remedy method achieves the same as updateWrongTransfer. Test plan 1/ Run t/db_dependant/Circulation.t before and after applying this patch. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:48:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:48:50 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 --- Comment #23 from Martin Renvoize --- Created attachment 130084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130084&action=edit Bug 28294: Unit Tests This patch adds unit tests for the new 'remedy' method we are introducing to Koha::Item::Transfer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:48:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:48:54 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121716|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 130085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130085&action=edit Bug 28294: Remove use of updateWrongTransfer This patch removes the last remaining use of updateWrongTransfer. Test plan 1/ git grep updateWrongTransfer to confirm there are no more uses of the method. 2/ Confirm an incorrect transfer still behaves as expected at circulation returns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:48:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:48:57 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 --- Comment #25 from Martin Renvoize --- Created attachment 130086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130086&action=edit Bug 28294: Remove updateWrongTransfer method This patch removes the updateWrongTransfer method entirely from C4/Circulation.pm. Test plan 1/ Confirm that there are no longer any mentions of updateWrongTransfer in the codebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:49:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:49:00 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 --- Comment #26 from Martin Renvoize --- Created attachment 130087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130087&action=edit Bug 28294: Remove unit tests for updateWrongTransfer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:49:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:49:34 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121715|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 11:50:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 10:50:01 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #27 from Martin Renvoize --- Rebased and unit tests added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:20:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:20:49 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:20:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:20:53 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122759|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 130088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130088&action=edit Bug 28576: Add patron image in patron detail section does not specify image size limit When you try to add an image to a patron in Home/Patrons/anyPatron, it only states the file types that are supported but not the maximum size. If you try to add an image that is bigger than 500 kb, nothing happens and the reason is not presented. This is not the case with the 2 other places where we can add patron images in which they give warnings: Home/Tools/Upload patron images Home/Tools/Patron card creator/Images For now, i simply added the size limit to the file supported message. To test: 1)Search for any patron and go to his page 2)Hover over the image area on the left and click on add 3)Notice the message above the choose file button only specifies file types not size. 4)Add an image bigger than 500 kb 5)Nothing happens 6)Apply patch 7)Repeat steps from 1 to 3 8)Notice the message now includes the maximum size Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:20:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:20:59 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130054|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 130089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130089&action=edit Bug 28576: Update the maximum size of an image. This patch modifies the maximum size of a patron's image, from 500KB to 2MB. Also, in Home/Patrons/anyPatron, when you try to add an image to a patron, you can now see the supported file types AND the maximum size. The following places are affected by this patch: - Home/Patrons/anyPatron - Home/Tools/Upload patron images - Home/Tools/Patron card creator/Images To test: 1)Search for any patron and go to his page. 2)Hover over the image area on the left and click on the "Add" button. 3)Notice that the message above the choose file button only specifies file types without the maximum size. 4)Add an image bigger than 500KB. 5)Nothing happens. (This is because the maximum size is 5KB) 6)Apply the patch. 7)Repeat steps from 1 to 3. 8)Notice that the message now includes the maximum size. 9)Add an image bigger than 500KB, but smaller than 2MB. 10)The image is succesfully uploaded. 11)Add an image bigger than 2MB. 12)Nothing happens. (The maximum size is now 2MB) 13)Repeat the steps 9 to 12 in "Home/Tools/Upload patron images" and "Home/Tools/Patron card creator/Images". 14)Notice that the maximum size is updated. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:22:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:22:49 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This updates the add patron |This updates the add patron release notes|image screen to specify |image screen to specify |that the maximum image size |that the maximum image size |is 500KB. If it is larger, |is 2 MB. If it is larger, |the patron image is not |the patron image is not |added. |added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:26:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:26:34 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28294 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:26:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:26:34 +0000 Subject: [Koha-bugs] [Bug 28294] C4::Circulation::updateWrongTransfer should be moved into Koha:: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28294 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29792 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:29:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:29:59 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #23 from Thomas Dukleth --- Unmodified text files which are not part of code used for MediaWiki database migration and updating are now included in the "binary" [non-version controlled] files archive allowing version controlled code for database migration and wiki updating to not be lost in a larger set of unrelated files. Such unmodified text files along with binary files and symlinks previously excluded from version control as inappropriate for version control are now included in https://test01.agogme.com/koha_migrate_mwiki_db_and_upgrade_test.tgz . [Symlinks are mostly built by the migration and update code but we have also started with some created for the legacy wiki.] A link to the version control repository with the unmodified text files excluded will be rebuilt and posted after another run of tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:34:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:34:43 +0000 Subject: [Koha-bugs] [Bug 24968] Add Syspref controls for cronjobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:34:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:34:57 +0000 Subject: [Koha-bugs] [Bug 27096] Add option to message_queue to exclude specific letter codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27096 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:35:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:35:22 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:41:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:41:20 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:51:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:51:55 +0000 Subject: [Koha-bugs] [Bug 30003] New: When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Bug ID: 30003 Summary: When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: jake.deery at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org (Possibly related to #28163 at a code level) Hi, One of our customers has raised a curious bug involving the Point of Sale module within Koha. Specifically, when processing a payment in Koha, if the 'amount tendered' field is left blank, then filled in after the 'this field is mandatory' text appears, the transaction seems to be recorded twice. Please see here for a visual demo: https://i.imgur.com/upH5zlk.gifv Steps to reproduce: 1. Navigate to /cgi-bin/koha/pos/pay.pl 2. Add an item from 'items to purchase' 3. Under 'collect payment', click submit without altering the form 4. See 'This field is required.' 5. Now, fill a value in 'Amount tendered' that satisfies or exceeds 'Amount being paid' 6. The payment should succeed 7. Navigate to /cgi-bin/koha/pos/register.pl 8. See duplicate lines in Transactions I hope we can see this resolved quickly, as it has the potential to cause major accounting issues. Many thanks, Jake Deery -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 12:52:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 11:52:02 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Jake Deery changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:02:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:02:48 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 --- Comment #20 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #13) > 3) I think David is right about having a system preference for this to make > it easier to use on multi-instance systems, but I wonder if this should be a > hard requirement. One advantage of doing it right from the beginning is that > it's much easier than introducing later when you might break/change peoples > workflows. > > But I am not sure if a lot of instances would use that in the same way, it > looks more like a 'once a year' type of thing then a very regular cronjob. > So for me this would not be a blocker right now. This is indeed 'once a year' cronjob. Some of our instances have a policy to set blocks to patrons whose fines are over accepted limit after New Year. Setting this as system preference and be triggered every time someone exceeds that limit would go against these policies. Patrons still need some respite to pay their fines :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:14:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:14:33 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 130090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130090&action=edit Bug 29975: Add missing patron_expiration_date attribute to hold spec On bug 21729 a new attribute was added to the holds objects, but we forgot to add it to the spec. This broke the holds routes. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail, boo. 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:15:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:15:05 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130058|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:15:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:15:44 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:17:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:17:28 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #1 from Jake Deery --- Just to update, I have applied a quick-fix to IntranetUserJS. See attached. I will look into creating a proper patch tonight - -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:18:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:18:08 +0000 Subject: [Koha-bugs] [Bug 28696] Point of sale: attempting to pay with the "Enter" key cause an overcharge in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28696 Jake Deery changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery at ptfs-europe.com --- Comment #4 from Jake Deery --- Created attachment 130091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130091&action=edit IntranetUserJS - to base patch upon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:22:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:22:06 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130090|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:22:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:22:12 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |tomascohen at gmail.com |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:22:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:22:34 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130058|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:23:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:23:30 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 --- Comment #7 from Tomás Cohen Arazi --- I revert what I did because Jonathan is right, this attribute is not strictly required on the API (yet?) so we should delay exposing it until there's a real need for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:24:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:24:55 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:24:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:24:59 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130058|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi --- Created attachment 130092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130092&action=edit Bug 29975: (bug 21729 follow-up) Fix api/v1/holds.t Unknown column 'patron_expiration_date' in 'field list' The REST API routes don't need to be aware of the new column patron_expiration_date Signed-off-by: Fridolin Somers Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:35:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:35:57 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 130093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130093&action=edit Bug 29759: (follow-up) Fix TemplateToolkit.t This patch makes the tests set debit_id to undef instead of random data. This way tests don't break when $article_request->cancel is invoked and a refund is tried. To test: 1. Run: $ kshell k$ prove t/db_dependent/Letters/TemplateToolkit.t => FAIL: Boo, tests fail, random garbage is not a debit 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:40:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:40:05 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130093|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 130094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130094&action=edit Bug 29759: (follow-up) Fix TemplateToolkit.t This patch makes the tests set debit_id to undef instead of random data. This way tests don't break when $article_request->cancel is invoked and a refund is tried. To test: 1. Run: $ kshell k$ prove t/db_dependent/Letters/TemplateToolkit.t => FAIL: Boo, tests fail, random garbage is not a debit 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:51:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:51:03 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 130095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130095&action=edit Bug 29759: (follow-up) Fix api/v1/article_requests.t This patch makes the tests set debit_id to undef instead of random data. This way tests don't break when $article_request->cancel is invoked and a refund is tried. To test: 1. Run: $ kshell k$ prove t/db_dependent/Letters/TemplateToolkit.t => FAIL: Boo, tests fail, random garbage is not a debit 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:53:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:53:32 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130095|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 130096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130096&action=edit Bug 29759: (follow-up) Fix api/v1/article_requests.t This patch makes the tests set debit_id to undef instead of random data. This way tests don't break when $article_request->cancel is invoked and a refund is tried. To test: 1. Run: $ kshell k$ prove t/db_dependent/Letters/TemplateToolkit.t => FAIL: Boo, tests fail, random garbage is not a debit 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 13:58:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 12:58:19 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart+koha at gmail. |kyle at bywatersolutions.com |com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:00:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:00:35 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:00:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:00:38 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130044|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 130097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130097&action=edit Bug 29230: Add Koha::Patron->messages Add methods to return the messages attached to a patron. It will add the capability to access them from notice templates. Test plan: Define some messages for a given patron Go to the circulation page of the patron and confirm that they are still displayed Test the notice templates: Add to HOLD_SLIP the following content """ [% SET messages = borrower.messages %] [% IF messages.count %] Messages:
    [% FOR m IN messages.search( message_type => 'L' ) %]
  • [% m.message %]
  • [% END %]
[% END %] """ To display all the messages from staff ('L') Adapt following your needs. Signed-off-by: Fridolin Somers Signed-off-by: Stina Hallin Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:01:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:01:45 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #19 from Marcel de Rooy --- Do we actually have a rule for empty test descriptions? :) # Subtest: messages 1..4 ok 1 - No message yet ok 2 - There are two messages for this patron ok 3 ok 4 ok 14 - messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:08:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:08:53 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:08:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:08:55 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:08:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:08:58 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129997|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:09:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:09:02 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:09:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:09:05 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129999|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:12:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:12:47 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 130098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130098&action=edit Bug 29844: Fix t/db_dependent/Koha/* Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:12:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:12:52 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 130099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130099&action=edit Bug 29844: Remove use of wantarray from Koha::Objects This patch removes the use of `wantarray` from the following methods in the Koha::Objects class: - search - search_related In both cases, the change is trivial. And the tests get the 'list context' portion removed as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Caveat: we broke many things by removing the feature. Check follow-up patches as well. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:13:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:13:01 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 130100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130100&action=edit Bug 29844: Fix ->search occurrences and some more... There are lot of inconsistencies in our ->search calls. We could simplify some of them, but not in this patch. Here we want to prevent regressions as much as possible and so don't add unecessary changes. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:13:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:13:07 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 130101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130101&action=edit Bug 29844: Some more uncaught cases Some more cases found using $ git grep '\->search(' | grep -v -e '\->as_list' -e '\->get_column' \ | grep '@' and then manually looking at them. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:19:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:19:03 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from Emmi Takkinen --- (In reply to Martin Renvoize from comment #19) > I started working through the feedback here, but ran out of tuits. > > I think we should probably use system preferences instead of passing > parameters in the script call as David suggests.. I'm also not sure at this > point how cron vs background tasks are working.. this is really designed as > an 'auto debar users' feature I think? > > This wasn't ever something I intended to work on, nor have anyone using.. so > I'm not really sure where it should be going.. I just picked it up to > modernise the code and help things to move forwards. Any feedback welcome. Thanks for picking this up Martin! I noticed couple quick fixes, there's no my $amount declared and also --confirm option no longer needs string. And for some reason amount limit is not working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:22:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:22:25 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 --- Comment #22 from Emmi Takkinen --- (In reply to Emmi Takkinen from comment #21) > (In reply to Martin Renvoize from comment #19) > > I started working through the feedback here, but ran out of tuits. > > > > I think we should probably use system preferences instead of passing > > parameters in the script call as David suggests.. I'm also not sure at this > > point how cron vs background tasks are working.. this is really designed as > > an 'auto debar users' feature I think? > > > > This wasn't ever something I intended to work on, nor have anyone using.. so > > I'm not really sure where it should be going.. I just picked it up to > > modernise the code and help things to move forwards. Any feedback welcome. > > Thanks for picking this up Martin! I noticed couple quick fixes, there's no > my $amount declared and also --confirm option no longer needs string. And > for some reason amount limit is not working. Oh, it needs to be 'a|amount:i'... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:24:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:24:33 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:28:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:28:07 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:28:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:28:12 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129350|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi --- Created attachment 130102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130102&action=edit Bug 29859: Use iterator instead of as_list On bug 29844 we decided to remove wantarray from Koha::Objects->search. Reviewing the difference occurrences I found some unnecessary uses of ->as_list, where iterators should be used instead. This patch only removes the obvious places, not the tricky ones. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:31:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:31:19 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #20 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #19) > Do we actually have a rule for empty test descriptions? :) IMO the descriptions are like comments, they should be there when it's not obvious. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:34:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:34:39 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 --- Comment #23 from Emmi Takkinen --- Created attachment 130103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130103&action=edit Bug 15157: Add my $amount and fix options Variable my $amount was missing. Also option amount has to be declared as integer and option confirm is no longer string. Sponsored by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:34:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:34:47 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:40:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:40:06 +0000 Subject: [Koha-bugs] [Bug 29970] 500 Error when a record cannot be displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29970 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |11175, 28734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 [Bug 11175] Show the parent record's component parts in the detailed views https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:40:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:40:06 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29970 [Bug 29970] 500 Error when a record cannot be displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:40:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:40:06 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29970 [Bug 29970] 500 Error when a record cannot be displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:40:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:40:10 +0000 Subject: [Koha-bugs] [Bug 29970] 500 Error when a record cannot be displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29970 --- Comment #2 from Nick Clemens --- Created attachment 130104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130104&action=edit Bug 29970: eval processing of MARC record to avoid crash detail.pl displays a warning at the top of the page when a record contains parsing errors Bug 28734 and bug 11175 added additional parsing of the MARC record, but they did not catch the thrown errors. The existing pattern in the script is to eval responses to avoid crashing This patch wraps the new calls in eval{} To test: 1 - Find a record in the staff catalog 2 - Edit the record 3 - In the 520 notes field, add an ASCII escape character (27 decimal, 1b hex) On ubuntu Ctrl+Shift+u, then 1b, enter 4 - Save the record 5 - 500 Error 6 - Apply patch 7 - Reload 8 - The record displays with a warning at the top -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:40:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:40:32 +0000 Subject: [Koha-bugs] [Bug 29970] 500 Error when a record cannot be displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29970 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:44:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:44:32 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:44:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:44:46 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 130105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130105&action=edit Bug 29847: Make Koha::Patron::HouseboundProfile->housebound_visits return a resultset This patch makes the method consistent with the rest of the codebase, by making it return a proper resultset. To test: 1. Run: $ kshell k$ prove t/db_dependent/Patron/HouseboundProfiles.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Check the UI hasn't got broken either. => SUCCESS: It hasn't! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:45:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:45:30 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com Assignee|martin.renvoize at ptfs-europe |tomascohen at gmail.com |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 14:51:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 13:51:14 +0000 Subject: [Koha-bugs] [Bug 16156] Do not ensure the dbh is connected all the time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16156 --- Comment #9 from Jonathan Druart --- I don't think this is still valid. I am not seeing ensure_connect calls anymore (or at least way less), but I had a bit of trouble to make Nytprof working with the last ktd (?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:00:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:00:53 +0000 Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365 --- Comment #15 from Blou --- We have the problem in searches (opac/staff). ES indexes without any problem. I see the data returned when turning on trace_to in koha-conf.xml. But somewhere in Koha or MARC library, something breaks. The records with a 505$a longer than 9999 characters are not displayed correctly in the results. Actually, NO data shows up. But there's an empty entry in the results. The other records are listed without problem. Considering that the xslt for the results never infer to 505 the slightest, it seems to me its the marcxml that breaks down. Somewhere, somehow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:02:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:02:13 +0000 Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:08:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:08:21 +0000 Subject: [Koha-bugs] [Bug 29970] 500 Error when a record cannot be displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- I don't understand, we were supposed to have fixed that few days ago, with bug 29690. If the problem still persists, please have a look at the solution there (test $marc_record) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:09:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:09:51 +0000 Subject: [Koha-bugs] [Bug 29970] 500 Error when a record cannot be displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #4 from Jonathan Druart --- You patch does not apply, I think it's a duplicate. *** This bug has been marked as a duplicate of bug 29690 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:09:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:09:51 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #57 from Jonathan Druart --- *** Bug 29970 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:10:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:10:25 +0000 Subject: [Koha-bugs] [Bug 30004] New: Prevent TooMany from executing too many SQL queries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 Bug ID: 30004 Summary: Prevent TooMany from executing too many SQL queries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org If a maximum number of checkouts allowed is defined in circulation rules, C4::Circulation::TooMany will loop over all patron's checkouts. When a patron has several hundreds of checkouts, it can really slow down the checkout process by several seconds (or even tens of seconds) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:11:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:11:54 +0000 Subject: [Koha-bugs] [Bug 30005] New: statuses are not translated in loan requests table of opac user account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30005 Bug ID: 30005 Summary: statuses are not translated in loan requests table of opac user account Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr I'm speaking of the statuses in the status column such as "New request", "Reverted","Queued request","Cancellation requested","Completed" and so on. In the staff loan requests table, these are translated via the include template "ill-list-table-strings.inc" but it seems there is no equivalent in the opac interface. I don't think this has been changed in master either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:17:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:17:02 +0000 Subject: [Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 --- Comment #1 from Julian Maurice --- Created attachment 130106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130106&action=edit Bug 30004: Prevent TooMany from executing too many SQL queries If a maximum number of checkouts allowed is defined in circulation rules, C4::Circulation::TooMany will loop over all patron's checkouts. When a patron has several hundreds of checkouts, it can really slow down the checkout process by several seconds (or even tens of seconds) This patch does two things: - Always prefetch item data so that `$c->item` does not execute an additional SQL query at every iteration of the loop. Item data is always needed at the first line of the loop, so there is really no downside for doing this. - Build the `@types` array only once, out of the checkouts loop. Since it does not depend at all on patron's checkouts data, it does not make sense to build it inside the loop. Test plan: 1. Before applying the patch, create a patron with a lot of checkouts. I tested with 1000 checkouts, but the slowness should be noticeable with less. 2. Make sure you have a circulation rule (one that apply to your patron and the item(s) you will check out for testing) with a maximum number of checkouts allowed 3. Check out an item for the patron with a lot of checkouts. Measure the time it takes. 4. Apply the patch 5. Check out another item (or check in and then check out the same item used in step 3). Measure the time it takes and compare it to step 3. It should be faster now. 6. Run `prove t/db_dependent/Circulation/TooMany.t` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:17:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:17:16 +0000 Subject: [Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:18:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:18:44 +0000 Subject: [Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 --- Comment #2 from Julian Maurice --- This problem affects at least versions 20.11, 21.05, 21.11, and master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:19:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:19:09 +0000 Subject: [Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:30:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:30:41 +0000 Subject: [Koha-bugs] [Bug 30006] New: Article requests: Checkbox for non-commercial use Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30006 Bug ID: 30006 Summary: Article requests: Checkbox for non-commercial use Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice if there was an option for adding a mandatory additional checkbox to the article requests form in the OPAC that allowed asking for legal requirements. Example: Copies will only be used for non-commercial purposes. Also if there is a fee for the article, there could be a need to have the patron confirm that before submitting the article request. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:43:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:43:58 +0000 Subject: [Koha-bugs] [Bug 20653] Issue expected from irregularities don't display right month In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20653 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca, | |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:52:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:52:29 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:52:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:52:33 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130065|0 |1 is obsolete| | Attachment #130066|0 |1 is obsolete| | Attachment #130067|0 |1 is obsolete| | Attachment #130068|0 |1 is obsolete| | Attachment #130069|0 |1 is obsolete| | Attachment #130070|0 |1 is obsolete| | Attachment #130071|0 |1 is obsolete| | --- Comment #25 from Owen Leonard --- Created attachment 130107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130107&action=edit Bug 29695: Add new module Koha::Database::Columns This module will contain new strings and make them translatable using Koha::I18N. We will need to improve this module to prevent the dozens of __ calls each time we retrieve the column list. We could either use memcached or add a method to only retrieve columns for a given table. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:52:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:52:37 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #26 from Owen Leonard --- Created attachment 130108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130108&action=edit Bug 29695: Remove GetColumnDefs C4::Templates::GetColumnDefs can easily be replaced using the new Koha::Database::Columns module. Test plan: Go to the import patron tool and confirm that you see the same list of patron's attribute on the import patron form. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:52:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:52:41 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #27 from Owen Leonard --- Created attachment 130109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130109&action=edit Bug 29695: Remove C4::Reports::Guided::_get_column_defs This subroutine was mostly the same as GetColumnDefs, we replace it identically as in the previous patch. Test plan: Translate some strings in another language % gulp po:update --lang es-ES % cd misc/translate # Translate the relevant strings in po/es-ES-messages.po # For instance "Alternate contact: Surname" % perl translate install es-ES Select the language for the interface (enable it in the 'language' syspref first) Create a new guided report and confirm that the columns for the borrowers table are translated Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:52:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:52:45 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #28 from Owen Leonard --- Created attachment 130110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130110&action=edit Bug 29695: (follow-up) Remove C4::Reports::Guided::_get_column_defs Same as the previous patch but for the inventory. Test plan: Same as before but test the inventory tool Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:52:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:52:49 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #29 from Owen Leonard --- Created attachment 130111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130111&action=edit Bug 29695: Make "modalselect" syspref's values translatable We are using json files to retrieve the list of the DB columns. We can reuse what we have done in the previous patch and display translated strings. Test plan: Search for "unwanted" in the sysprefs Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:52:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:52:53 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #30 from Owen Leonard --- Created attachment 130112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130112&action=edit Bug 29695: Remove json files We do no longer need them. Test plan: Confirm that their content are in Koha::Database::Columns Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:52:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:52:56 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 --- Comment #31 from Owen Leonard --- Created attachment 130113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130113&action=edit Bug 29695: Remove columns.def No longer in use Test plan: % git grep 'columns.def' does not return relevant occurrences Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:58:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:58:32 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:58:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:58:36 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130031|0 |1 is obsolete| | --- Comment #15 from Lucas Gass --- Created attachment 130114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130114&action=edit Bug 29066: Remove text in OPAC search form and use Font Awesome icons In modern front-end websites, first think you see in header region is an large input text with a search icon. No need to say it is a search form. We still tell it in 'title' attribut for accessibility. This patch removes 'Search' text. If 'my library first' feature is enabled, shows a text in title of a question mark icon. In submit button, replaces 'Go' with a seach icon and add title 'Search'. Test plan : 1) 1.1) Set system preferences : OpacAddMastheadLibraryPulldown to 'Add' SearchMyLibraryFirst to 'Don't limit' 1.2) Go to OPAC main page 1.3) You don't see 'Search' anymore 1.4) You see in submit button an icon 1.5) Move mouse over submit button to see tooltip text 'Search' 2) 2.1) Set system preferences : OpacAddMastheadLibraryPulldown to 'Don't add' SearchMyLibraryFirst to 'Limit' 2.2) Go to OPAC main page 2.3) Log in 2.4) You don't see text 'Search (in ) only' 2.5) You see a question mark icon 2.6) Move mouse over submit button to see tooltip text 'Search (in ) only' Signed-off-by: Samu Heiskanen Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 15:58:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 14:58:39 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130032|0 |1 is obsolete| | --- Comment #16 from Lucas Gass --- Created attachment 130115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130115&action=edit Bug 29066: (follow-up) add aria-label and aria-hidden on icons Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:01:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:01:12 +0000 Subject: [Koha-bugs] [Bug 30007] New: Make ->anonymize methods throw an exception if AnonymousPatron is not set Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Bug ID: 30007 Summary: Make ->anonymize methods throw an exception if AnonymousPatron is not set Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org If the system preference AnonymousPatron is not set, the following methods should throw an exception: - Koha::Old::Hold(s)->anonymize - Koha::Old::Checkout(s)->anonymize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:01:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:01:55 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |29843 CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:01:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:01:55 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:07:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:07:10 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129953|0 |1 is obsolete| | Attachment #129954|0 |1 is obsolete| | Attachment #129955|0 |1 is obsolete| | Attachment #129956|0 |1 is obsolete| | Attachment #129957|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 130116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130116&action=edit Bug 29924: Database updates Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:07:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:07:13 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #19 from Nick Clemens --- Created attachment 130117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130117&action=edit Bug 29924: DO NOT PUSH - Schema updates Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:07:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:07:17 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #20 from Nick Clemens --- Created attachment 130118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130118&action=edit Bug 29924: Add password expiration feature This patch adds the ability to define password_expiry_days for a patron category. When defined a patron's password will expire after X days and they will be required to reset their password. If OPAC resets are enabled for the catgeory they may do so on their own, otherwise they will need to contact the library To test: 1 - Apply patch, updatedatabase 2 - Set 'Password expiration' for a patron category Home-> Administration-> Patron categories-> Edit 3 - Create a new patron in this category with a userid/password set, and an email 4 - Confirm their password_expiration_date field is set SELECT password_expiration_date FROM borrowers WHERE borrowernumber=51; 5 - Create a new patron, do not set a password 6 - Confirm their password_expiration_date field is NULL 7 - Update the patron with an expiration to be expired UPDATE borrowers SET password_expiration_date='2022-01-01' WHERE borrowernumber=51; 8 - Give the borrower catalogue permission 9 - Attempt to log in to Straff interface 10 - Confirm you are signed out and notified that password must be reset 11 - Attempt to sign in to OPAC 12 - Confirm you are signed out and notified password must be reset 13 - Enable password reset for the patron's category and perform a password reset Note: you will have to find the link in the message_queue unless you have emails setup on your test environment SELECT * FROM message_queue WHERE borrowernumber=51; 14 - Confirm that you can now sign in and password_expiration_date field is set 10 days in the future 15 - Expire the patron's password again 16 - Change the patron's password via the staff interface 17 - Confirm they can sign in and the expiration is updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:07:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:07:20 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #21 from Nick Clemens --- Created attachment 130119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130119&action=edit Bug 29924: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:07:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:07:25 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #22 from Nick Clemens --- Created attachment 130120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130120&action=edit Bug 29924: (follow-up) Add bug number to atomicupdate; Style OPAC message - The atomicupdate didn't have "bug_number" defined. - The "Your password has expired" message is now styled with the same class as other OPAC login messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:10:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:10:23 +0000 Subject: [Koha-bugs] [Bug 30008] New: Software error in details.pl when invalid MARCXML and showing component records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008 Bug ID: 30008 Summary: Software error in details.pl when invalid MARCXML and showing component records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Find a record in the staff catalog 2 - Edit the record 3 - In the 520 notes field, add an ASCII escape character (27 decimal, 1b hex) On ubuntu Ctrl+Shift+u, then 1b, enter 4 - Save the record 5 - Set syspref ShowComponentRecords to 'both...' 6 - On record details: New->New child record 7 - Save the record 8 - Attempt to view the parent record in the staff client and opac - FAIL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:10:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:10:59 +0000 Subject: [Koha-bugs] [Bug 30008] Software error in details.pl when invalid MARCXML and showing component records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 [Bug 29690] Software error in details.pl when invalid MARCXML -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:10:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:10:59 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008 [Bug 30008] Software error in details.pl when invalid MARCXML and showing component records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:11:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:11:39 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:13:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:13:42 +0000 Subject: [Koha-bugs] [Bug 30009] New: Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30009 Bug ID: 30009 Summary: Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org See bug 29690 - find/create a record with invalid marc Notes tab shows but is empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:13:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:13:57 +0000 Subject: [Koha-bugs] [Bug 30009] Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30009 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 [Bug 29690] Software error in details.pl when invalid MARCXML -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:13:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:13:57 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30009 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30009 [Bug 30009] Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 16:37:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 15:37:07 +0000 Subject: [Koha-bugs] [Bug 20653] Issue expected from irregularities don't display right month In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20653 --- Comment #2 from Marjorie Barry-Vila --- still valid in 21.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 17:21:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 16:21:30 +0000 Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130037|0 |1 is obsolete| | --- Comment #6 from Jérémy Breuillard --- Created attachment 130121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130121&action=edit Bug 29983: Display the pretend claim column in overdue.tt This patch displays the column "Return claims" from the page "moremember.pl" to the page "overdues.pl". Rebase on master. Test plan: 1)Use a patron with at least 1 item who should be checked out soon 2)Home > Patron > Patron details for [name] 3)Click on the 'Checkout' button down the page to show the full table and notice the "Return Claims" column 4)Now go to Home > Circulation > Overdues 5)Find the patron who has to check out and have a look at the table 6)Apply patch and repeat 4) and 5) -> the "Return Claim" column is now displayed on the table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 17:23:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 16:23:13 +0000 Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130037|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 17:37:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 16:37:30 +0000 Subject: [Koha-bugs] [Bug 20653] Issue expected from irregularities don't display right month In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20653 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 18:13:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 17:13:53 +0000 Subject: [Koha-bugs] [Bug 30010] New: Website can't be reached Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30010 Bug ID: 30010 Summary: Website can't be reached Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: library at waypointmontessori.org QA Contact: testopia at bugs.koha-community.org The Koha library site for our school says "Can't be reached" for the last week. We have not done a recent update so I'm unsure of the current Koha version we are using at our school. Our internet is working fine on campus this is the only website that is giving this message when I type in the url. Please help! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 18:26:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 17:26:54 +0000 Subject: [Koha-bugs] [Bug 30011] New: Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 Bug ID: 30011 Summary: Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Blocks: 29115 I would like to upgrade jQueryUI to 1.13.1 everywhere. At the same time, the library will be re-compiled to get rid of unused modules like datepicker. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 18:26:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 17:26:54 +0000 Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 18:27:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 17:27:19 +0000 Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29115 |29155 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 [Bug 29155] Upgrade jquery version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 18:27:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 17:27:19 +0000 Subject: [Koha-bugs] [Bug 29115] Placing a club hold is not showing warnings when unable to place a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29115 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30011 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 18:27:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 17:27:19 +0000 Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 18:28:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 17:28:55 +0000 Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 [Bug 29228] Use Flatpickr on offline circulation page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 18:28:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 17:28:55 +0000 Subject: [Koha-bugs] [Bug 29228] Use Flatpickr on offline circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 18:32:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 17:32:45 +0000 Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 20:11:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 19:11:11 +0000 Subject: [Koha-bugs] [Bug 27464] Extend functionality of AllowHoldsPolicyOverride to prevent some overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27464 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- Since the topic is on AllowHoldsPolicyOverride, I would also like to suggest that there be a permission in patron permissions for this. We don't want everyone being able to override holds. While we don't want everyone being able to place holds on lost items, there are situations where we want to have a staff member place a hold on a lost item, as they may have to decide if this item will continue circulating. Currently we can't do that unless we turn this setting on, but we don't want to just turn it on for everyone to override. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 20:18:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 19:18:53 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 20:39:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 19:39:59 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #31 from Fridolin Somers --- New patches pushed to master : b62fcec5cc Bug 29759: (follow-up) Fix api/v1/article_requests.t 8c80db886a Bug 29759: (follow-up) Fix TemplateToolkit.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 20:44:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 19:44:20 +0000 Subject: [Koha-bugs] [Bug 28993] Switch magnifying glass in staff detail pages to FA icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Switch magnifying class in |Switch magnifying glass in |staff detail pages to FA |staff detail pages to FA |icon |icon CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 20:45:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 19:45:36 +0000 Subject: [Koha-bugs] [Bug 28993] Switch magnifying glass in staff detail pages to FA icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #7 from Fridolin Somers --- magnifying "glass" 🔍 I'll fix commit message when pushing to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 20:48:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 19:48:01 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 20:48:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 19:48:03 +0000 Subject: [Koha-bugs] [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 --- Comment #9 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 20:50:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 19:50:24 +0000 Subject: [Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Severity|enhancement |major Blocks| |7923 --- Comment #3 from Fridolin Somers --- Performance issue so i change from enhancement to major bug Good catch Julian ;) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 20:50:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 19:50:24 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 [Bug 30004] Prevent TooMany from executing too many SQL queries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 21:23:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 20:23:56 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 21:24:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 20:24:38 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 130122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130122&action=edit Bug 29570: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 21:24:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 20:24:42 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 130123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130123&action=edit Bug 29570: Fix sorting orders by biblioitems columns The API representation of Koha::Biblio objects includes the biblioitems.* columns too. This proved problematic as queries had to get translated so they work (i.e. if a query passes q={"biblio.ean":"123%"} then the query needs to be tweaked so biblio.ean is translated into biblio.biblioitem.ean. This is solved, locally, in the controller. But sorting needs the same kind of tweak, and it was missing. This patch solves that by doing a similar conversion. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail, searching on a 'biblioitems' column generates a 500 error. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! We can sort on those fields 5. Sign off :-D Note: you will notice the tests only cover sorting by ISBN. I consider it enough as sorting is a DB problem, and we only want to know if the generated ORDER BY is valid for the underlying query, and MySQL would complain if it wasn't the case. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 21:24:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 20:24:47 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 130124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130124&action=edit Bug 29570: Enable sorting orders by summary This patch enables (on receiving) sorting orders by the summary column. It needs the previous patches to work. Title is given more precedence as expressed by users on the bug report. Which, by the way, makes sense. To test: 1. Create a basket 2. Create orders 3. Close basket 4. Receive shipment 5. Enter invoice information => SUCCESS: You should see your pending orders => FAIL: Verify the 'Summary' column is not sortable 7. Apply this patches 8. Restart Plack 9. Reload the page => SUCCESS: Can sort by the summary column 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 21:46:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 20:46:58 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unable to sort |Unable to sort summary |pending_orders table on |column of pending_orders |parcel.pl by summary column |table on parcel.pl by | |summary column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 21:51:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 20:51:47 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 21:51:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 20:51:50 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130122|0 |1 is obsolete| | --- Comment #9 from Lucas Gass --- Created attachment 130125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130125&action=edit Bug 29570: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 21:51:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 20:51:54 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130123|0 |1 is obsolete| | --- Comment #10 from Lucas Gass --- Created attachment 130126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130126&action=edit Bug 29570: Fix sorting orders by biblioitems columns The API representation of Koha::Biblio objects includes the biblioitems.* columns too. This proved problematic as queries had to get translated so they work (i.e. if a query passes q={"biblio.ean":"123%"} then the query needs to be tweaked so biblio.ean is translated into biblio.biblioitem.ean. This is solved, locally, in the controller. But sorting needs the same kind of tweak, and it was missing. This patch solves that by doing a similar conversion. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail, searching on a 'biblioitems' column generates a 500 error. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! We can sort on those fields 5. Sign off :-D Note: you will notice the tests only cover sorting by ISBN. I consider it enough as sorting is a DB problem, and we only want to know if the generated ORDER BY is valid for the underlying query, and MySQL would complain if it wasn't the case. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 21:51:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 20:51:58 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130124|0 |1 is obsolete| | --- Comment #11 from Lucas Gass --- Created attachment 130127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130127&action=edit Bug 29570: Enable sorting orders by summary This patch enables (on receiving) sorting orders by the summary column. It needs the previous patches to work. Title is given more precedence as expressed by users on the bug report. Which, by the way, makes sense. To test: 1. Create a basket 2. Create orders 3. Close basket 4. Receive shipment 5. Enter invoice information => SUCCESS: You should see your pending orders => FAIL: Verify the 'Summary' column is not sortable 7. Apply this patches 8. Restart Plack 9. Reload the page => SUCCESS: Can sort by the summary column 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 23:35:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 22:35:25 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #8 from Katrin Fischer --- I don't think we should push this as multiple, because we lose the ability to determine the sequence of the tabs. This is a feature we have used for several libraries depending on how they set up locations, collections and itemtypes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 2 23:37:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 22:37:27 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 --- Comment #9 from Katrin Fischer --- (In reply to Katrin Fischer from comment #8) > I don't think we should push this as multiple, because we lose the ability > to determine the sequence of the tabs. This is a feature we have used for > several libraries depending on how they set up locations, collections and > itemtypes. This is a new feature, but being aware you want the same change for the existing pref. (dependency on bug 29878) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 00:15:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 23:15:34 +0000 Subject: [Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 --- Comment #8 from Lucas Gass --- (In reply to Katrin Fischer from comment #7) > I am still not sure we should bend the standard like that... especially as > it will break things like the sample below with the <> as part of the text. I think you are correct and we should not bend the standard like this, marking this as wont fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 00:15:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 23:15:43 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 00:38:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 23:38:12 +0000 Subject: [Koha-bugs] [Bug 27212] Add column configuration to the acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 00:38:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Feb 2022 23:38:15 +0000 Subject: [Koha-bugs] [Bug 27212] Add column configuration to the acquisitions home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114412|0 |1 is obsolete| | --- Comment #6 from Lucas Gass --- Created attachment 130128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130128&action=edit Bug 27212: Add Table configuration to acqui-home.pl accounts table To test, apply the patch and clear your browser cache 1. Go to acqui-home.pl 2. Test that the "Columns" button works to show and hide columns. 3. Go to Administration -> Table settings and look under the Acquisitions tab for the page 'acq_acqui-home' and the table 'accounts'. 4. Hide each column and make sure it hides correctly on acqui-home.pl 5. Test the export options (Excel, CSV, etc) and make sure hidden columns do not show up. 6. Make sure the totals at the bottom of the screen can still be calculated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 01:01:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 00:01:28 +0000 Subject: [Koha-bugs] [Bug 27632] Add a more easily Javascript accessible biblionumber to each record in OPAC results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27632 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 07:24:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 06:24:31 +0000 Subject: [Koha-bugs] [Bug 26102] Javascript injection in intranet search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26102 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia at bugs.koha-communit | |y.org Product|Koha security |Koha Component|Koha |Templates Group|Koha security | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 07:29:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 06:29:48 +0000 Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Group|Koha security | Version|unspecified |master QA Contact| |testopia at bugs.koha-communit | |y.org Component|Koha |Self checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 07:32:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 06:32:26 +0000 Subject: [Koha-bugs] [Bug 28735] Self-checkout users can access opac-user.pl for sco user when not using AutoSelfCheckID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28735 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|Passed QA |Pushed to oldoldstable Component|Koha |Self checkout Group|Koha security | Product|Koha security |Koha Version(s)|21.05.09,20.11.14 |22.05.00,21.11.02,21.05.09, released in| |20.11.14,19.11.25 QA Contact| |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 07:34:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 06:34:34 +0000 Subject: [Koha-bugs] [Bug 29540] Accounts with just 'catalogue' permission can modify/delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29540 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Component|Koha |Staff Client Group|Koha security | Product|Koha security |Koha Status|Passed QA |Pushed to oldoldstable Version(s)|21.05.09,20.11.14 |22.05.00,21.11.02,21.05.09, released in| |20.11.14,19.11.25 QA Contact| |testopia at bugs.koha-communit | |y.org CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 07:36:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 06:36:42 +0000 Subject: [Koha-bugs] [Bug 29541] Patron images can be accessed with just 'catalogue' permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29541 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Status|Passed QA |Pushed to oldoldstable Version|unspecified |master CC| |gmcharlt at gmail.com Group|Koha security | Version(s)|21.05.09,20.11.14 |22.05.00,21.11.02,21.05.09, released in| |20.11.14,19.11.25 Component|Koha |Staff Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 07:38:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 06:38:28 +0000 Subject: [Koha-bugs] [Bug 29542] User with 'catalogue' permission can view everybody's (private) virtualshelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29542 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |Staff Client QA Contact| |testopia at bugs.koha-communit | |y.org Group|Koha security | CC| |gmcharlt at gmail.com Version|unspecified |master Version(s)|21.05.09,20.11.14 |22.05.00,21.11.02,21.05.09, released in| |20.11.14,19.11.25 Product|Koha security |Koha Status|Passed QA |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 07:41:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 06:41:37 +0000 Subject: [Koha-bugs] [Bug 29544] A patron can set everybody's checkout notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29544 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Status|Passed QA |Pushed to oldoldstable Product|Koha security |Koha Version|unspecified |master Component|Koha |OPAC Version(s)|21.05.09,20.11.14 |22.05.00,21.11.02,21.05.09, released in| |20.11.14,19.11.25 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 07:43:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 06:43:27 +0000 Subject: [Koha-bugs] [Bug 29903] Message deletion possible from different branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29903 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldoldstable Component|Koha |Staff Client Product|Koha security |Koha Version|unspecified |master QA Contact| |testopia at bugs.koha-communit | |y.org Version(s)|21.05.09,20.11.14 |22.05.00,21.11.02,21.05.09, released in| |20.11.14,19.11.25 Group|Koha security | CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 07:45:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 06:45:37 +0000 Subject: [Koha-bugs] [Bug 29914] check_cookie_auth not strict enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29914 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Component|Koha |Architecture, internals, | |and plumbing Product|Koha security |Koha QA Contact| |testopia at bugs.koha-communit | |y.org Group|Koha security | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 07:53:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 06:53:23 +0000 Subject: [Koha-bugs] [Bug 30012] New: How to cancel a pending transaction on the cash app effortlessly? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30012 Bug ID: 30012 Summary: How to cancel a pending transaction on the cash app effortlessly? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: tobycarter75 at gmail.com QA Contact: testopia at bugs.koha-community.org Different kinds of tech problems give rise to the requirement for How to cancel a pending transaction on the cash app. this is why taking the proper initiative via the activity tab can prove useful. Now customers can also additionally click on the cancel alternative to follow the later process. The most remarkable aspect is that cash app support professionals work honestly to help out their customers. https://www.emailsupport-contact.com/blog/can-you-cancel-a-pending-cash-app-transaction/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 09:46:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 08:46:08 +0000 Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 09:54:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 08:54:40 +0000 Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 --- Comment #7 from Jérémy Breuillard --- Bug found and fixed. Let me know if its done correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 10:38:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 09:38:08 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 --- Comment #2 from Martin Renvoize --- OOh, thanks for jumping on this Tomas.. I'll have a look today :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 10:55:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 09:55:30 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #22 from Martin Renvoize --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 11:38:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 10:38:07 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 11:38:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 10:38:10 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130098|0 |1 is obsolete| | Attachment #130099|0 |1 is obsolete| | Attachment #130100|0 |1 is obsolete| | Attachment #130101|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 130129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130129&action=edit Bug 29844: Fix t/db_dependent/Koha/* Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 11:41:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 10:41:34 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 11:41:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 10:41:40 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 12:28:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 11:28:05 +0000 Subject: [Koha-bugs] [Bug 30010] Website can't be reached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30010 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 12:34:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 11:34:30 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130129|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 130130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130130&action=edit Bug 29844: Fix t/db_dependent/Koha/* Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 12:34:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 11:34:40 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #25 from Kyle M Hall --- Created attachment 130131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130131&action=edit Bug 29844: Remove use of wantarray from Koha::Objects This patch removes the use of `wantarray` from the following methods in the Koha::Objects class: - search - search_related In both cases, the change is trivial. And the tests get the 'list context' portion removed as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Caveat: we broke many things by removing the feature. Check follow-up patches as well. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 12:34:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 11:34:44 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #26 from Kyle M Hall --- Created attachment 130132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130132&action=edit Bug 29844: Fix ->search occurrences and some more... There are lot of inconsistencies in our ->search calls. We could simplify some of them, but not in this patch. Here we want to prevent regressions as much as possible and so don't add unecessary changes. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 12:34:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 11:34:49 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #27 from Kyle M Hall --- Created attachment 130133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130133&action=edit Bug 29844: Some more uncaught cases Some more cases found using $ git grep '\->search(' | grep -v -e '\->as_list' -e '\->get_column' \ | grep '@' and then manually looking at them. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 12:53:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 11:53:45 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #28 from Martin Renvoize --- oh, oh... Did you run t/db_dependant/Koha/Libraries.t Kyle.. that's failing for me.. looks like a missing change required in Koha::Library::Groups::all_libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 12:54:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 11:54:20 +0000 Subject: [Koha-bugs] [Bug 30013] New: Limit/throttle SMTP connections Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 Bug ID: 30013 Summary: Limit/throttle SMTP connections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org We have a setup where Koha is sending email through the SMTP server of the library's mother institution. We are seeing a problem with sending lots of emails in one go, where the first emails are sent ok, but then the rest fail with an error like this: unable to establish SMTP connection to (mail.x.y) port 25 It looks like this is due to some limit on the server, making it unresponsive if there are too many connections from the same source in a short time. I don't know a lot about SMTP but I can imagine a couple of solutions: - Introduce a configurable "sleep" period between each call to the external SMTP server (or batches of a configurable number, with a configurable sleep between each batch) - Looking at the response from the server and if "unable to establish SMTP connection" is received, wait for a configurable amount of time before trying to resend the failed message and the rest of the queue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 12:58:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 11:58:12 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #29 from Kyle M Hall --- These patches are failing some unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 13:14:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 12:14:35 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #30 from Martin Renvoize --- Created attachment 130134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130134&action=edit Bug 29844: (QA follow-up) Fix Koha::Library::Groups->all_libraries I think a rebase perhaps lost a change here.. this fix gets the unit tests passing again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 13:43:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 12:43:55 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130130|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 130135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130135&action=edit Bug 29844: Fix t/db_dependent/Koha/* Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 13:43:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 12:43:59 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130131|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize --- Created attachment 130136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130136&action=edit Bug 29844: Remove use of wantarray from Koha::Objects This patch removes the use of `wantarray` from the following methods in the Koha::Objects class: - search - search_related In both cases, the change is trivial. And the tests get the 'list context' portion removed as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Caveat: we broke many things by removing the feature. Check follow-up patches as well. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 13:44:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 12:44:04 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130132|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 130137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130137&action=edit Bug 29844: Fix ->search occurrences and some more... There are lot of inconsistencies in our ->search calls. We could simplify some of them, but not in this patch. Here we want to prevent regressions as much as possible and so don't add unecessary changes. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 13:44:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 12:44:08 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130133|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 130138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130138&action=edit Bug 29844: Some more uncaught cases Some more cases found using $ git grep '\->search(' | grep -v -e '\->as_list' -e '\->get_column' \ | grep '@' and then manually looking at them. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 13:44:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 12:44:12 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130134|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 130139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130139&action=edit Bug 29844: (QA follow-up) Fix Koha::Library::Groups->all_libraries I think a rebase perhaps lost a change here.. this fix gets the unit tests passing again. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 13:45:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 12:45:31 +0000 Subject: [Koha-bugs] [Bug 30014] New: When a lost item is marked returned on payment the checkout is not anonymized Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30014 Bug ID: 30014 Summary: When a lost item is marked returned on payment the checkout is not anonymized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1 - Set syspref MarkLostItemsAsReturned to 'when receiving payment for the item' only 2 - Find an item, add a replacement cost, check it out to a patron 3 - Ensure system preference OpacPrivacy is set to Allow 4 - Sign in to OPAC as the patron and set privacy to 'Never' 5 - Pay the lost fine on the item 6 - Item is returned 7 - Check circulation history in staff client - you are told no history is kept 8 - Check patron's checkout history on OPAC 9 - You still see the lost item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 13:49:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 12:49:42 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 13:51:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 12:51:00 +0000 Subject: [Koha-bugs] [Bug 30014] When a lost item is marked returned on payment the checkout is not anonymized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30014 --- Comment #1 from Nick Clemens --- Koha/Account/Line uses 'ReturnLostItem' which calls MarkIssueReturned without passing the privacy parameter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:01:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:01:15 +0000 Subject: [Koha-bugs] [Bug 30015] New: Incomplete LEADER when creating new child record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30015 Bug ID: 30015 Summary: Incomplete LEADER when creating new child record Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: mik at adminkuhn.ch QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When displaying a bibliographic record in the normal view of the staff client, the clicking "New > New child record" the LEADER will just contain the following: "␣␣␣␣␣␣␣␣␣a␣␣␣␣␣␣␣␣␣␣␣␣␣␣" (I have replaced the space character by ␣ to make it visible). It stays the same when we click into the field. So when we fill the rest of the required fields and save the record we will end up with a record that is not properly linked to the parent record. This is irritating since when just creating a "normal" (non-child) new record, the LEADER is automatically filled with the correct content when clicking the field resp. trying to save the record. This happens through plugin "marc21_leader.pl". However, when creating A new child record if we click the tag editor symbol at the far right, the popup "000- Leader" opens and we can click "OK" which will eventually result in the following LEADER content: "␣␣␣␣␣aaa␣a22␣␣␣␣␣␣␣␣4500". This seems somehow cumbersome since we don't want to change anything there. It would be desirable if this content would just appear when clicking the field resp. trying to save the record as it does when just creating a "normal" (non-child) record. Seemingly the logic in the code seems to not consider that use case. As the form is preloaded with that "a" character, it concludes no default filling needs to be done. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:02:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:02:05 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #36 from Martin Renvoize --- OK, * I ran the whole test suite - Everything now passes * I ran the QA scripts - Everything happy * I tried a bunch of stuff in the UI and nothing failed I'm happy to PQA this.. no doubt there will be a little fallout with such a large change, but this is a great step towards consistency. Go, go, go! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:06:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:06:18 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130105|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 130140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130140&action=edit Bug 29847: Make Koha::Patron::HouseboundProfile->housebound_visits return a resultset This patch makes the method consistent with the rest of the codebase, by making it return a proper resultset. To test: 1. Run: $ kshell k$ prove t/db_dependent/Patron/HouseboundProfiles.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Check the UI hasn't got broken either. => SUCCESS: It hasn't! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:11:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:11:33 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:14:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:14:20 +0000 Subject: [Koha-bugs] [Bug 30016] New: Remove GetOpenIssue subroutine Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 Bug ID: 30016 Summary: Remove GetOpenIssue subroutine Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This routine is just a SQL fetch of the issue row for an itemnumber - we should use Koha::Checkouts->find({itemnumber=>$itemnumber}) instead -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:22:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:22:54 +0000 Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:23:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:23:03 +0000 Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:24:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:24:11 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:24:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:24:14 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 --- Comment #1 from Nick Clemens --- Created attachment 130141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130141&action=edit Bug 30016: Remove GetOpenIssue subroutine This patch adjusts the code that uses GetOpenIssue to use/find a Koha::Checkout object instead To test: 1 - Add a course to course reserves 2 - Create an item with barcode TESTKOC 3 - Add the item to a course 4 - Checkout the item 5 - View course details on stff and opac and confirm item shows as checked out and due date displays 6 - prove t/db_dependent/Circulation/issue.t t/db_dependent/Circulation.t t/db_dependent/CourseReserves.t 7 - Browse to Circulation->Upload offline circulation 8 - Upload a file to return the item: https://wiki.koha-community.org/wiki/Koha_offline_circulation_file_format 9 - Confirm item is returned -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:25:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:25:02 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 --- Comment #2 from Nick Clemens --- Created attachment 130142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130142&action=edit Sample koc file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:28:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:28:28 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #37 from Martin Renvoize --- Just found an issue with patron clubs whilst I moved on to test bug 29847.. setting back to Signed off whilst Tomas takes a look for me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:32:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:32:15 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130139|0 |1 is obsolete| | --- Comment #38 from Tomás Cohen Arazi --- Created attachment 130143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130143&action=edit Bug 29844: (QA follow-up) Fix Koha::Library::Groups->all_libraries I think a rebase perhaps lost a change here.. this fix gets the unit tests passing again. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:37:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:37:31 +0000 Subject: [Koha-bugs] [Bug 29982] Show itemtype in holds table on patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:37:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:37:35 +0000 Subject: [Koha-bugs] [Bug 29982] Show itemtype in holds table on patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #9 from Magnus Enger --- Created attachment 130144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130144&action=edit Bug 29982: Show itemtype in holds table on patron details Show item type in the holds tables on "Check out" and "Details" tabs in the intranet. To test: - Add an item level hold - Go to patron details and look at the "Check out" tab - Click on the "Holds" horizontal tab and verify the item type is shown in a column between "Title" and "Call number" - Go to the "Details" tab - Click on the "Holds" horizontal tab and verify the display is the same as above - Make a record level hold and verify the item type is not shown in the tables described above - Check in an item from the record level hold, so it is "waiting" for the patron - Verify the item type is now shown in the same way as for the item level hold, as described above -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:38:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:38:44 +0000 Subject: [Koha-bugs] [Bug 29982] Show itemtype in holds table on patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129995|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:39:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:39:22 +0000 Subject: [Koha-bugs] [Bug 29982] Show itemtype in holds table on patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 --- Comment #10 from Magnus Enger --- Sorry, bad habit of copying from Bugzilla. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:40:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:40:25 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:46:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:46:59 +0000 Subject: [Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow patron attributes in |Show searchable patron |DefaultPatronSearchFields |attributes in patron search |syspref and patron search |dropdown |dropdown | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:48:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:48:16 +0000 Subject: [Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 --- Comment #1 from Andrew Fuerste-Henry --- Flagging an attribute as "searchable" makes it part of the standard patron search, but leaves one without a way to search *only* within that attribute. Adding it to the dropdown would all ow that specificity. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:53:01 +0000 Subject: [Koha-bugs] [Bug 30013] Limit/throttle SMTP connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 --- Comment #1 from Magnus Enger --- Is this the sort of functionality that was taken care of when we used postfix or similar on the server, and that we loose when moving to using the SMTP functionality in Koha? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 14:58:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 13:58:33 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 130145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130145&action=edit Bug 29844: Simplify Koha::Clubs->get_enrollable This patch removes the wantarray use in Koha::Clubs->get_enrollable and adjusts the callers. Also, reference to some unused params in Koha::Patron clubs-related methods are removed as well. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 15:03:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 14:03:41 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130145|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize --- Created attachment 130146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130146&action=edit Bug 29844: Simplify Koha::Clubs->get_enrollable This patch removes the wantarray use in Koha::Clubs->get_enrollable and adjusts the callers. Also, reference to some unused params in Koha::Patron clubs-related methods are removed as well. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 15:04:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 14:04:08 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #41 from Martin Renvoize --- Back to PQA.. I'm sure things will drop out once we're using this in earnest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 15:05:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 14:05:04 +0000 Subject: [Koha-bugs] [Bug 30015] Incomplete LEADER when creating new child record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30015 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 15:07:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 14:07:32 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Tests passing, QA script happy and functionality unaffected.. all working great. Going straight for QA on this trivial improvement. Pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 15:07:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 14:07:37 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 15:30:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 14:30:44 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 --- Comment #5 from Martin Renvoize --- Comment on attachment 130102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130102 Bug 29859: Use iterator instead of as_list Review of attachment 130102: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29859&attachment=130102) ----------------------------------------------------------------- We introduce a few .count calls in templates here.. which will add a DB hit per call unless I'm mistaken? Now, I don't think a count call has much impact on performance, but it may be worth taking into consideration at some point.. for the pattern [% IF whatevers.count %]boiler[% FOREACH whatever IN whatever %]list of stuff[% END %][% END %] we could perhaps just add the boiler in the first iteration of the loop using the 'first' or 'index' methods of the TT iterator? instead of testing for count explicitly? ::: Koha/Holds.pm @@ +122,5 @@ > + { > + columns => ['itemnumber'], > + collapse => 1, > + } > + )->get_columns('itemnumber'); get_column vs get_columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 15:43:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 14:43:28 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen at gmail.com CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 15:45:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 14:45:29 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|kyle at bywatersolutions.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 15:58:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 14:58:21 +0000 Subject: [Koha-bugs] [Bug 29982] Show itemtype in holds table on patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 15:58:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 14:58:25 +0000 Subject: [Koha-bugs] [Bug 29982] Show itemtype in holds table on patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130144|0 |1 is obsolete| | --- Comment #11 from Lucas Gass --- Created attachment 130147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130147&action=edit Bug 29982: Show itemtype in holds table on patron details Show item type in the holds tables on "Check out" and "Details" tabs in the intranet. To test: - Add an item level hold - Go to patron details and look at the "Check out" tab - Click on the "Holds" horizontal tab and verify the item type is shown in a column between "Title" and "Call number" - Go to the "Details" tab - Click on the "Holds" horizontal tab and verify the display is the same as above - Make a record level hold and verify the item type is not shown in the tables described above - Check in an item from the record level hold, so it is "waiting" for the patron - Verify the item type is now shown in the same way as for the item level hold, as described above Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:05:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:05:13 +0000 Subject: [Koha-bugs] [Bug 30017] New: Should we prefer iterator.first over calling variable.count to reduce our DB hits Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30017 Bug ID: 30017 Summary: Should we prefer iterator.first over calling variable.count to reduce our DB hits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org I noticed a pattern recently whereby we often call a count prior to iterating over the resultset: [% IF things.count %] . . . [% FOREACH thing IN things %] [% END %]
[% thing.whatever %]
[% END %] This introduces a count(*) DB call. We could instead use the first iteration of the iterator to setup the boilerplate and reduce our DB hits. [% FOREACH thing IN things %] [% IF thing.first %] [% END %] [% IF thing.last %]
[% thing.whatever %]
[% END %] [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:06:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:06:06 +0000 Subject: [Koha-bugs] [Bug 30017] Should we prefer iterator.first over calling variable.count to reduce our DB hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30017 --- Comment #1 from Martin Renvoize --- Doh.. it's wouldn'y be 'thing.first' and 'thing.last'.. it would be the special variables.. 'loop.first' and 'loop.last' in the above example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:06:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:06:48 +0000 Subject: [Koha-bugs] [Bug 30017] Should we prefer iterator.first over calling variable.count to reduce our DB hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30017 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:07:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:07:00 +0000 Subject: [Koha-bugs] [Bug 30017] Should we prefer iterator.first over calling variable.count to reduce our DB hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30017 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:07:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:07:09 +0000 Subject: [Koha-bugs] [Bug 30017] Should we prefer iterator.first over calling variable.count to reduce our DB hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30017 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:07:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:07:24 +0000 Subject: [Koha-bugs] [Bug 30017] Should we prefer iterator.first over calling variable.count to reduce our DB hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30017 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:07:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:07:41 +0000 Subject: [Koha-bugs] [Bug 30017] Should we prefer iterator.first over calling variable.count to reduce our DB hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30017 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29859 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:07:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:07:41 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30017 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:09:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:09:35 +0000 Subject: [Koha-bugs] [Bug 30017] Should we prefer `loop.first` and `loop.last` over calling `variable.count` to reduce our DB hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30017 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Should we prefer |Should we prefer |iterator.first over calling |`loop.first` and |variable.count to reduce |`loop.last` over calling |our DB hits |`variable.count` to reduce | |our DB hits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:12:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:12:21 +0000 Subject: [Koha-bugs] [Bug 30018] New: Title statment punctuation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30018 Bug ID: 30018 Summary: Title statment punctuation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: paliotti at mdp.edu.ar QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, perhaps i don´t understand koha punctuation "rules". The question is: I put leader position 18 to "c" (ISBD without punctuation) because we are cataloguing in RDA without punctuation and this is the correct position for us. 245$a = Title 245$b = subtitle Intranet and Opac interfaces shows me "Title(space)subtitle" when the expected view must be "Title : subtitle". Is there any parameter or way for a correct fields format? Thks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:13:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:13:20 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130102|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 130148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130148&action=edit Bug 29859: Use iterator instead of as_list On bug 29844 we decided to remove wantarray from Koha::Objects->search. Reviewing the difference occurrences I found some unnecessary uses of ->as_list, where iterators should be used instead. This patch only removes the obvious places, not the tricky ones. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:13:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:13:23 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 --- Comment #7 from Martin Renvoize --- Created attachment 130149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130149&action=edit Bug 29859: (QA follow-up) Minor typo correction We introduced a tiny bug with a typo in the patchset, the accessor method is called 'get_column' not 'get_columns'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:14:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:14:44 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- A nice improvement.. I fixed the minor typo with a followup and moved the discussion around .count vs loop variables to a new bug. QA scripts are happy and I couldn't find any errors in the UI. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:18:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:18:07 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:20:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:20:50 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30017 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:20:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:20:50 +0000 Subject: [Koha-bugs] [Bug 30017] Should we prefer `loop.first` and `loop.last` over calling `variable.count` to reduce our DB hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30017 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23991 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:31:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:31:03 +0000 Subject: [Koha-bugs] [Bug 30018] Title statment punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30018 --- Comment #1 from Katrin Fischer --- It's correct that LDR pos. 18 = c would indicate that, but that has been a more "recent" addition to the MARC format, so the majority of records still include ISBD punctuation. Koha has no functionality depending on LDR pos. 18. It can currently not generate ISBD punctuation for display. Your options here are a bit limited. You can add the punctuation or try to adapt the display files, i.e. the XSLT files used to build the result list and detail page from the MARCXML record. See also bug 21303 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:34:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:34:35 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- This is the third Koha::PluralClass::search_limited method we've introduced recently.. and they're all nearly the same. Should we not DRY this code out and adopt something similar to Koha::Objects::Limit::Library here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 16:36:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 15:36:04 +0000 Subject: [Koha-bugs] [Bug 30000] Replace the use of jQueryUI tabs on the search engine configuration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30000 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Marcel de Rooy --- Great bug number ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:06:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:06:33 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 --- Comment #7 from Martin Renvoize --- Hmm.. this is very different to our other search_limited methods.. Instead of using the Koha::Patron->libraries_where_can_see_patrons we're doing some special cases IndependantBranches stuff.. I'm wondering if we ought to be using the existing limitation method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:08:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:08:49 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 --- Comment #8 from Martin Renvoize --- The 'C4::Context::only_my_library' call in the other search_limited form should catch the same IndependantBranches stuff as this does.. Given we have good tests written here, I'll try to adapt it and use the tests to prove the route. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:18:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:18:14 +0000 Subject: [Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:18:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:18:14 +0000 Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29616 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 [Bug 29616] Replace library information popup in the OPAC with a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:22:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:22:07 +0000 Subject: [Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 --- Comment #9 from Lucas Gass --- (In reply to Katrin Fischer from comment #8) > There is a bright dark blue on the buttons when clicking them, but I notice > that this is true for all the buttons (like "Go") right now - so not a > blocker. That appears to be from this rule in the OPAC CSS file: .btn-primary:not(:disabled):not(.disabled).active, .btn-primary:not(:disabled):not(.disabled):active, .show > .btn-primary.dropdown-toggle { color: #fff; background-color: #0062cc; border-color: #005cbf; } Do we file a new bug? It seems like perhaps it was intentional to have the blue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:23:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:23:39 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 --- Comment #9 from Martin Renvoize --- Ack, more confusion here.. We are limiting by Suggestion branch.. which I think makes sense.. but could expose more than we're expecting (we could perhaps limit on suggester.branchcode to limit to only suggestions made by users from the branches you are allowed to see). ArticleRequests takes the above approach and limits by the requester.branchcode.. (but this could also be seen as a possible bug.. as you may want to see all article requests at the current branch.. regardless of who requested them and where they're based) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:28:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:28:56 +0000 Subject: [Koha-bugs] [Bug 30018] Title statment punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30018 --- Comment #2 from Pablo López Liotti --- Thks Katrin for the answer, edit or replace standard XSLT files never looks me a good practice because we may lost koha updates in the future. For many similars situations with a Jquery or CSS "touch" it was enough. The same problem then is for field 264 and his subfields. RDA manuals says not add elements (puntuaction) that not belong to the description. Cheers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:53:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:53:39 +0000 Subject: [Koha-bugs] [Bug 30019] New: We should DRY out search_limited (and rename it) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30019 Bug ID: 30019 Summary: We should DRY out search_limited (and rename it) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We've started adding a few search_limited methods to Koha::PluralClass objects to limit searches to only return patron related rows the current logged in user should be allowed to see. We should a) rename search_limited to search_with_patron_limits (to match search_with_library_limits that already exists) and b) DRY out the code along the lines of Koha::Objects::Limit::Library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:55:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:55:01 +0000 Subject: [Koha-bugs] [Bug 30019] We should DRY out search_limited (and rename it) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30019 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:55:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:55:12 +0000 Subject: [Koha-bugs] [Bug 30019] We should DRY out search_limited (and rename it) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30019 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:55:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:55:22 +0000 Subject: [Koha-bugs] [Bug 30019] We should DRY out search_limited (and rename it) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30019 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:55:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:55:34 +0000 Subject: [Koha-bugs] [Bug 30019] We should DRY out search_limited (and rename it) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30019 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:56:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:56:09 +0000 Subject: [Koha-bugs] [Bug 30019] We should DRY out search_limited (and rename it) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30019 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29888 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:56:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:56:09 +0000 Subject: [Koha-bugs] [Bug 29888] ->search_limited logic breaks searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29888 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:56:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:56:20 +0000 Subject: [Koha-bugs] [Bug 30019] We should DRY out search_limited (and rename it) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30019 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29886 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:56:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:56:20 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:57:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:57:03 +0000 Subject: [Koha-bugs] [Bug 30019] We should DRY out search_limited (and rename it) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30019 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18403 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 17:57:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 16:57:03 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 18:12:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 17:12:26 +0000 Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 18:17:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 17:17:36 +0000 Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 --- Comment #1 from Owen Leonard --- This patch is too large to attach here, so please find it here: https://gitlab.com/koha-dev/koha-dev/-/tree/bug-30011-upgrade-jqueryui There are two commits: Bug 30011: Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface This patch updates jQueryUI in the OPAC and staff interface. Old assets are removed and new assets added. jQueryUI has been re-compiled in each interface to include only the required features. In the OPAC: tabs and tooltip. In the staff interface: accordion, autocomplete, sortable, and tabs. The next patch will make the required updates to templates. ------------------------- Bug 30011: Update links to jQueryUI assets, remove datepicker references, etc. This patch updates templates to include the new version of jQueryUI. It removes some references to the now unused datepicker widget as well as the jQuery timepicker addon. Some minor JavaScript and style updates to fix issues resulting from the upgrade. To test, apply the patch and update the CSS in the staff interface AND in the OPAC (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). IN THE OPAC: - The OPAC only uses the tabs jQueryUI widget. - View pages where tabs are used: Bibliographic details, user summary, advanced search. IN THE STAFF INTERFACE: - The staff interface uses four jQueryUI widgets: accordion, autocomplete, sortable, and tabs - Test the accordion widget on two pages: Administration -> Table settings and Patrons -> Patrons requesting modifications. - Test autocomplete (requires PatronAutoComplete to be enabled) on various pages. For example: - From the "Check out" tab in the header search box. - From the "Search patrons" tab in the header search box, e.g. from the main Patrons page. - Place hold -> Search patrons. - Tools -> Patron lists -> Add patrons to list -> Patron search. - Test sortable: - Administration -> System preferences -> Language. - With more than one language installed you should be able to drag to re-order the enabled languages. Confirm that your change is saved successfully. - Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields on a tag with multiple subfields. You should be able to drag to re-order the tabs at the top of the subfield constraints edit page. Confirm that your changes are saved successfully. - Cataloging -> New record. Test that you can re-order subfields under a tag with multiple subfields and that your changes are saved. - Tabs: View various pages with tabs: Check out, bibliographic details, basic MARC editor. They're everywhere. Also confirm that the removal of the leftover datepicker doesn't affect pages which use the calendar include: Test various pages which use Flatpickr, e.g. check out, renew, reports, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 18:52:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 17:52:14 +0000 Subject: [Koha-bugs] [Bug 30018] Title statment punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30018 --- Comment #3 from Katrin Fischer --- I think using CSS or jQuery is a great idea. I don't know about the RDA handbook, but the LOC examples for 264 include the punctuation: https://www.loc.gov/marc/bibliographic/bd264.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 19:07:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 18:07:39 +0000 Subject: [Koha-bugs] [Bug 30018] Title statment punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30018 --- Comment #4 from Pablo López Liotti --- Hi, I´d think that a "common sense" solution is put "i" in Leader position 18 (ISBD WITH puntuaction) for RDA and how you say, type punctuation in 264 y 245 fields. Looks fine in OPAC and Intra ;) For me, the common sense is no add puntuaction to field content because there are not valid bibliographic description data. But, by the moment, is a valid "transition" solution. Thanks again and cheers from Mar del Plata, Argentina Pablo -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 19:59:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 18:59:36 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 20:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 19:16:17 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 [Bug 29857] We must stringify our exceptions correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 20:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 19:16:17 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 21:26:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 20:26:40 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #69 from Aleisha Amohia --- Sorry this applied cleanly for me! Can you please paste your merge conflict output? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 21:27:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 20:27:34 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #70 from Aleisha Amohia --- Oops commented on the wrong bug! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 21:42:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 20:42:52 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 21:43:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 20:43:00 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126544|0 |1 is obsolete| | --- Comment #71 from Aleisha Amohia --- Created attachment 130150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130150&action=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 21:43:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 20:43:07 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126545|0 |1 is obsolete| | --- Comment #72 from Aleisha Amohia --- Created attachment 130151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130151&action=edit Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 21:43:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 20:43:14 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126546|0 |1 is obsolete| | --- Comment #73 from Aleisha Amohia --- Created attachment 130152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130152&action=edit Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 21:43:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 20:43:20 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126547|0 |1 is obsolete| | --- Comment #74 from Aleisha Amohia --- Created attachment 130153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130153&action=edit Bug 3150: (follow-up) Add missing bracket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 22:48:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 21:48:31 +0000 Subject: [Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 23:28:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 22:28:36 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 23:28:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 22:28:40 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #27 from Aleisha Amohia --- Created attachment 130154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130154&action=edit Bug 17748: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 23:38:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 22:38:11 +0000 Subject: [Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 3 23:38:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Feb 2022 22:38:15 +0000 Subject: [Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127133|0 |1 is obsolete| | --- Comment #8 from Lucas Gass --- Created attachment 130155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130155&action=edit Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and create some new additional content. 3. Notice a Save and continue button 4. Try saving and contining. 5. Make sure if you are using the CodeMirror editor that you are still in the CodeMirror editor 6. Try 2 - 5 again but with the wysiwyg editor, make sure when you save and continue you remain in the wysiwyg editor. 7. If you are saving and contining from News make sure you remain in News, when you are saving and contining from HTML customizations make sure you remain there. 8. Turn on the NewsLog system preference 9. With the NewsLog on make sure your content is being logged correctly when you sabe and continue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 01:22:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 00:22:01 +0000 Subject: [Koha-bugs] [Bug 30015] Incomplete LEADER when creating new child record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30015 Charles Kelley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmkelleymls at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 08:11:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 07:11:30 +0000 Subject: [Koha-bugs] [Bug 30020] New: How Can I Find Out An Easy Mode To Activate Cash App Card? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30020 Bug ID: 30020 Summary: How Can I Find Out An Easy Mode To Activate Cash App Card? Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.druart+koha at gmail.com Reporter: kevin1996andrew at gmail.com First of all, you have to order a Cash App card through your Cash App mobile application. To Activate Cash App Card, you will need to fetch the details of the Cash App card either manually and automatically. As a result, you will be able to get your Cash App card activated without any kind of hassle. https://www.numbersforsupport.net/blog/how-to-activate-cash-app-card/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 08:11:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 07:11:58 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 08:13:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 07:13:11 +0000 Subject: [Koha-bugs] [Bug 30021] New: Can i do my Cash app card activation before its arrival? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30021 Bug ID: 30021 Summary: Can i do my Cash app card activation before its arrival? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: andrewdrew938 at gmail.com QA Contact: testopia at bugs.koha-community.org The Cash app card activation can be done easily by opening your Cash app on your smart phone, and then you need to find and click on “Cash card” and then tap the image of Cash card and then look for the “activate Cash app card” and you need to tap on this option. After this, the Cash app will ask you to use your camera so that the QR code can be scanned. Please go through the link here to learn more about the Cash app card activation. https://www.numbersforsupport.net/blog/how-to-activate-cash-app-card/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 08:13:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 07:13:50 +0000 Subject: [Koha-bugs] [Bug 30013] Limit/throttle SMTP connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 --- Comment #2 from Magnus Enger --- >From RFC5321, page 66: The sender MUST delay retrying a particular destination after one attempt has failed. In general, the retry interval SHOULD be at least 30 minutes; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 08:14:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 07:14:07 +0000 Subject: [Koha-bugs] [Bug 30013] Limit/throttle/retry SMTP connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit/throttle SMTP |Limit/throttle/retry SMTP |connections |connections -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 08:54:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 07:54:07 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #105 from Marcel de Rooy --- This will need another QA review -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 09:01:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 08:01:52 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #18 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 09:08:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 08:08:44 +0000 Subject: [Koha-bugs] [Bug 30021] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30021 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Can i do my Cash app card |SPAM |activation before its | |arrival? | Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 09:09:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 08:09:10 +0000 Subject: [Koha-bugs] [Bug 30020] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30020 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|How Can I Find Out An Easy |SPAM |Mode To Activate Cash App | |Card? | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 09:42:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 08:42:30 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #19 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #0) > We must have a generic full_message method in the Koha::Exceptions base > class to display all the info we have about the exception. > The current state is bad as we are displaying the "description" of the > exception but it does not contain useful information. Exception 'Koha::Exception::TestMR' thrown 'Something went wrong!' with status => x, type => HASH(0x5653eb753278) How useful is HASH(0x5653eb753278) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 11:09:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 10:09:24 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #20 from Marcel de Rooy --- Looks quite good to me. I am wondering if we should remove the confusion between singular and plural completely now. We have a base class Koha::Exception. And we could define subclasses in Koha/Exception/ like Koha/Exception/Generic.pm to contain those now in Exceptions.pm. And the rest already in Exceptions/. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 11:32:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 10:32:55 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #21 from Marcel de Rooy --- Created attachment 130156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130156&action=edit Bug 29857: (CONCEPT) Switch to singular, add a load method The load method calls the Class::Exception import. Allowing you to skip a use Class::Exception everywhere, and define 'nicer' exception lists? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 11:33:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 10:33:11 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #22 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #21) > Created attachment 130156 [details] [review] > Bug 29857: (CONCEPT) Switch to singular, add a load method > > The load method calls the Class::Exception import. Allowing you > to skip a use Class::Exception everywhere, and define 'nicer' > exception lists? Any thoughts ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 11:39:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 10:39:42 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #23 from Marcel de Rooy --- Created attachment 130157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130157&action=edit Bug 29857: (QA follow-up) Add license -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 11:39:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 10:39:46 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130156|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy --- Created attachment 130158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130158&action=edit Bug 29857: (CONCEPT) Switch to singular, add a load method The load method calls the Class::Exception import. Allowing you to skip a use Class::Exception everywhere, and define 'nicer' exception lists? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 12:03:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 11:03:58 +0000 Subject: [Koha-bugs] [Bug 30022] New: Only show patron modifications for patrons of the staff users library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30022 Bug ID: 30022 Summary: Only show patron modifications for patrons of the staff users library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On the start page of Koha the "patrons requesting modifications" link always shows all requests for all libraries and has no limit on the logged in users branch. It would be nice to have the option to only show the requets of your own users or alternatively have a split display (my library/all librareis) like for suggestions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 12:08:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 11:08:12 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #40 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #38) > Same remarks than bug 29843 comment 30 apply here > "In MarkIssueReturned we crash if AnonymousPatron is not set to a valid > borrowernumber. Here we are setting it to NULL. Both behaviours must be > identical." Moved this bit to bug 30007. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 12:11:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 11:11:18 +0000 Subject: [Koha-bugs] [Bug 16623] Limit patron discharge management by library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16623 --- Comment #1 from Katrin Fischer --- +1 We've just run into this and it would be really nice if the display could be limited. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 12:13:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 11:13:15 +0000 Subject: [Koha-bugs] [Bug 30022] Only show patron modifications for patrons of the staff users library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30022 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer --- Just found out about IndependentBranchesPatronModifications that didn't turn up in my research before, this will work :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 12:15:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 11:15:49 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #32 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #30) > In MarkIssueReturned we crash if AnonymousPatron is not set to a valid > borrowernumber. Here we are setting it to NULL. Both behaviours must be > identical. Moved this bit to bug 30007. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 12:16:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 11:16:31 +0000 Subject: [Koha-bugs] [Bug 28584] Remove hyphens from EAN when adding a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122059|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 130159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130159&action=edit Bug 28584: Remove hyphens from EAN when adding new record Add functionality to TransformMarcToKoha so that hyphens are removed from biblioitem tables "ean" column but EAN value in MARC record is not touched. To test: 1. Apply patch. 2. Create new record with EAN field(s) having hyphen(s) e.g. 74628-8972 3. Check records MARC details => EAN has hyphen 4. Check record from biblioitem table in database => EAN doesn't have hyphen(s) Prove t/db_dependent/Biblio/TransfornMarcToKoha.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 12:17:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 11:17:57 +0000 Subject: [Koha-bugs] [Bug 28584] Remove hyphens from EAN when adding a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 12:39:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 11:39:42 +0000 Subject: [Koha-bugs] [Bug 30023] New: Add Koha::Old::Checkout->anonymize Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Bug ID: 30023 Summary: Add Koha::Old::Checkout->anonymize Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Not sure why, but I forgot to add this method earlier on the bug tree. Needed for consistency and completion of the refactoring. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 12:39:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 11:39:52 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30007 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 12:39:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 11:39:52 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30023 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 [Bug 30023] Add Koha::Old::Checkout->anonymize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 13:09:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 12:09:11 +0000 Subject: [Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 13:09:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 12:09:15 +0000 Subject: [Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129874|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 130160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130160&action=edit Bug 29952: Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 13:10:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 12:10:21 +0000 Subject: [Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #9 from David Nind --- Tested and signed off the patch for master (20.11 patch already tested by Katrin). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 13:49:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 12:49:59 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 Frank Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 14:04:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 13:04:44 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 Frank Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Frank Hansen --- The patch doesn't apply anymore. Rebase please. Using index info to reconstruct a base tree... M misc/migration_tools/bulkmarcimport.pl Falling back to patching base and 3-way merge... Auto-merging misc/migration_tools/bulkmarcimport.pl CONFLICT (content): Merge conflict in misc/migration_tools/bulkmarcimport.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 29654: Add match_record_id option to bulkmarimport.pl hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-29654-Add-matchrecordid-option-to-bulkmarimpor-rJcwEW.patch vagrant at kohadevbox:kohaclone(bug29654|AM 1/1)$ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:09:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:09:38 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:09:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:09:43 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 130161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130161&action=edit Bug 30023: Add Koha::Old::Checkout->anonymize This patch adds the mentioned method. It replicates the Koha::Old::Hold behavior, including the exception thrown on bad configuration. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkout.t => SUCCESS: Test pass 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:09:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:09:49 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 130162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130162&action=edit Bug 30023: Make MarkIssueReturned use ->anonymize Koha::Old::Checkout->anonymize takes care of checking the syspref and raises an exception if not set. So no we can now leverage on it, instead of checking manually and then tweaking the checkout object manually as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:11:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:11:47 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:11:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:11:53 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 130163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130163&action=edit Bug 30007: Add Koha::Exceptions::SysPref Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:11:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:11:57 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 130164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130164&action=edit Bug 30007: Regression tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:12:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:12:01 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 130165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130165&action=edit Bug 30007: Make ->anonymize methods throw an exception if AnonymousPatron is not set This patch makes the ->anonymize methods throw a Koha::Exceptions::SysPref::NotSet exception when trying to anonymize holds and checkouts without AnonymousPatron properly set. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t \ t/db_dependent/Koha/Old/Holds.t \ t/db_dependent/Koha/Old/Hold.t => FAIL: Tests fail, no exception thrown 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:35:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:35:34 +0000 Subject: [Koha-bugs] [Bug 26269] "Download file of displayed overdues" in Circulation->Overdues produces .csv with fewer results than the displayed list under certain circumstances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 --- Comment #4 from marion.durand at biblibre.com --- Created attachment 130166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130166&action=edit MT28016: "Date due to" and "Show any items currently checked out" filters doesn't work properly in overdues.pl Filter "Date due to" is now taken into account even when filled with a future date for the displayed result and downloaded results. Filter "Show any items currently checked out" is now taken into account for the downloaded results. To test: 1- Go to Circulation then to overdues 2a- Add a filter with "Date due To" > today 2b- Check that only the results with "Due date" < today are displayed (not those with "Due date" between today and the date requested) 2c- Click on "Download file of displayed overdues" 2d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 3a- Reset filter and then add the filter "Show any items currently checked out" 3b- Check that all the results are displayed (even those with "Due date" > today) 3c- Click on "Download file of displayed overdues" 3d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 9- Apply the patch 10- Repeat step 1 to 8, checking that all the results corresponding to the selected filter are now displayed/downloaded -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:41:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:41:28 +0000 Subject: [Koha-bugs] [Bug 26269] "Download file of displayed overdues" in Circulation->Overdues produces .csv with fewer results than the displayed list under certain circumstances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand at biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:48:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:48:14 +0000 Subject: [Koha-bugs] [Bug 30024] New: link_bibs_to_authorities.pl relies on CatalogModuleRelink Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30024 Bug ID: 30024 Summary: link_bibs_to_authorities.pl relies on CatalogModuleRelink Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This is confusing - CatalogModule Relink is described as: Do/Don't automatically relink headings that have previously been linked when saving records in the cataloging module. The cronjob interface is not the cataloging module? LinkerRelink describes itself in the DB: ('LinkerRelink','1',NULL,'If ON the authority linker will relink headings that have previously been linked every time it runs.','YesNo') In the cronjob: my $allowrelink = C4::Context->preference("CatalogModuleRelink") || ''; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:48:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:48:41 +0000 Subject: [Koha-bugs] [Bug 30024] link_bibs_to_authorities.pl relies on CatalogModuleRelink In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30024 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |enica at bywatersolutions.com, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:58:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:58:01 +0000 Subject: [Koha-bugs] [Bug 30025] New: BiblioAddsAuthorities is poorly named Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Bug ID: 30025 Summary: BiblioAddsAuthorities is poorly named Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org What it says it does: When editing records, (allow/don't allow) them to automatically create new authority records if needed, rather than having to reference existing authorities. What is actually does: 1 - Allow user to directly edit authority controlled fields in the cataloging module 2 - Link bibs to authorities when a record is added/updated 3 - Only if AutoCreateAuthorities is enabled are new authorities created, otherwise headings manually added in cataloging will remain unlinked -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:59:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:59:24 +0000 Subject: [Koha-bugs] [Bug 26269] "Download file of displayed overdues" in Circulation->Overdues produces .csv with fewer results than the displayed list under certain circumstances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |marion.durand at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 15:59:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 14:59:47 +0000 Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 16:35:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 15:35:45 +0000 Subject: [Koha-bugs] [Bug 30026] New: International Phone Number Not supported for SMSAlert Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 Bug ID: 30026 Summary: International Phone Number Not supported for SMSAlert Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: florian.bontemps at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The SMSNumber field used when registering a phone number for SMS alerts does not work with some international number formats. Currently, the format 00 AAAXXXXXXXXX (A = country indicator between 1 and 3 digits, X = regular digits) is not supported. While the format +AAAXXXXXXXXX can sometimes work, some network providers don't accept the latter format. These formats are very used in Europe for instance (Germany, Sweden, France, etc) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 16:51:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 15:51:15 +0000 Subject: [Koha-bugs] [Bug 29597] Add tomarcplugin option to bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29597 Frank Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 16:53:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 15:53:53 +0000 Subject: [Koha-bugs] [Bug 30027] New: Koha::Account->payout_amount should not total the lines in perl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30027 Bug ID: 30027 Summary: Koha::Account->payout_amount should not total the lines in perl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently the routine calls: 585 my $outstanding_credits = 586 exists( $params->{credits} ) 587 ? $params->{credits} 588 : $self->outstanding_credits->as_list; 589 for my $credit ( @{$outstanding_credits} ) { 590 $outstanding += $credit->amountoutstanding; 591 } We should instead call: Koha::Account::Lines->total_outstanding on the Resultlines in order to avoid floating point rounding errors Currently we see some amounts for refunds Throwing a 500 error, and in plack-error.log: Amount to payout (81.98) is higher than amountoutstanding (81.98) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 16:58:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 15:58:13 +0000 Subject: [Koha-bugs] [Bug 29905] Superlibrarians should be able to delete any patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29905 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose --- I just came across this as I was testing something else. Still valid! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 17:04:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 16:04:50 +0000 Subject: [Koha-bugs] [Bug 30026] International Phone Number Not supported for SMSAlert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 --- Comment #1 from Florian --- Created attachment 130167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130167&action=edit Bug 30026: SMSAlert regex fixed for international When registering a phone number for SMS alerts, the number goes through a regex filter to make sure the number is valid. One of the formats used in Europe is 00 AAA XXXXXXXXX (A = country indicator) and it is not supported. This patch adjusts the regex to either accept 00 AAA XXXXXXXXX or +AAAXXXXXXXXX in this case. (Note : +AAA and 00AAA are mutually exclusive). To test: 1) You need to have installed a SMSAlert plugin. Make sure the SMSSendDriver syspref is also set up with your SMS plugin of choice. 2) Pick a patron and edit its profile. 3) In the messaging preferences fieldset, under SMS number, enter any number with the format 00 AAA XXXXXXXXX (ie : 00111123456789). Try to save the modification : you should have an error message. 4) Try instead a number with the format +AAAXXXXXXXXX (ie : 111123456789), that one should be accepted. 5) Save your modification then check that the number has been changed. 6) Apply patch. 7) Repeat step 3 to 5. 8) Observe the error is gone. 9) Try it once more with the format +00 AAA XXXXXXXXX (+00111123456789), that format should not be accepted: this is intentional. 10) Sign off. Thanks-to: Didier Gautheron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 17:12:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 16:12:54 +0000 Subject: [Koha-bugs] [Bug 30028] New: Patron message delete confirmation untranslatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028 Bug ID: 30028 Summary: Patron message delete confirmation untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When we delete a patron message, there is a confirmation message that is untranslatable. It may be because it's a browser message or something, rather than a Koha modal? To get to this message: 1) Add a message to a patron account from your own branch (or make sure AllowAllMessageDeletion is on) 2) Click "Delete" next to the message --> a confirmation message appears "Are you sure you want to delete this message? This cannot be undone." with options "Cancel" and "OK". This sentence is in koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc but it is not in any .po file. Caroline -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 18:43:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 17:43:24 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 18:43:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 17:43:27 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129674|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 18:43:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 17:43:29 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129675|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 18:43:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 17:43:32 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129814|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 18:44:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 17:44:01 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 130168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130168&action=edit Bug 27424: Update schema file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 18:44:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 17:44:06 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 130169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130169&action=edit Bug 27424: Add ability to specify an SMTP server in the database as the default server Bug 22343 adds the ability to defined SMTP servers via the UI; But to then utilise them you have to go to each individual library via the libraries admin area and select the SMTP server. We should have a way to override the fallback/default SMTP server right from the SMTP servers administration page.. setting one of our defined SMTP Servers as the system default rather than using the hard coded fallback options. Test Plan: 1) Apply this patch set 2) Restart all the things! 3) Browser to the SMTP servers editor, verify only one server can be set as the default server 4) Set a default server, verify that server was used to send email from a cronjob, AND/OR prove t/db_dependent/Koha/SMTP/Server.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 18:44:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 17:44:11 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 130170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130170&action=edit Bug 27424: Update database Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 18:44:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 17:44:15 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 130171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130171&action=edit Bug 27424: (QA follow-up) Make Koha::SMTP::Server->store deal with defaults This patch makes the ->store method take care of setting the server as the only default one. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => SUCCESS: Tests pass! 3. The UI keeps working as it should. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 18:44:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 17:44:19 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 130172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130172&action=edit Bug 27424: Clarify logic This patch simplifies how Koha::SMTP::Servers->get_default is written, to help readability. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 19:10:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 18:10:05 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 --- Comment #12 from Tomás Cohen Arazi --- OK, works as expected. Moved the 'set default' logic to Koha::SMTP::Server->store proper and added tests. Also minor style tweaks. Good job! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 19:26:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 18:26:08 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 19:32:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 18:32:18 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #47 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 19:34:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 18:34:34 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind --- Patch no longer applies 8-(... Applying: Bug 29960: Remove Modernizr dependency in the OPAC Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc M koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt Falling back to patching base and 3-way merge... Removing koha-tmpl/opac-tmpl/bootstrap/lib/modernizr.min.js Removing koha-tmpl/opac-tmpl/bootstrap/js/script.js Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29960: Remove Modernizr dependency in the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 19:57:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 18:57:46 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 19:58:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 18:58:45 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 19:59:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 18:59:59 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #9 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:00:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:00:23 +0000 Subject: [Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #30 from Kelly McElligott --- Upon testing this, I found that the Not for Loan status was not showing accurately in the Course Reserve table on the OPAC. Testing for the status availability is correct on Staff Interface. A not-for-loan status shows available regardless of what is chosen (Ordered, Staff Collection, Not for Loan) in the Course Reserve table on the OPAC. Looking at the specific item within the OPAC, the not-for-loan status is showing correctly- specifically, it is using what is on the Authorized Value OPAC description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:01:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:01:54 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:05:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:05:29 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:08:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:08:56 +0000 Subject: [Koha-bugs] [Bug 29984] Remove unused method Koha::Patrons->anonymise_issue_history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29984 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 130173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130173&action=edit Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history The method is no longer used, and replaced by Koha::Old::Checkouts->anonymize. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests still pass 3. Run: $ git grep anonymise_issue_history => SUCCESS: The code doesn't mention it 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:09:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:09:11 +0000 Subject: [Koha-bugs] [Bug 29984] Remove unused method Koha::Patrons->anonymise_issue_history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29984 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:15:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:15:37 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |tomascohen at gmail.com --- Comment #3 from Tomás Cohen Arazi --- Hi, this looks fine, but I think you meant to use $item->checkout, otherwise it is a DBIC row you're dealing with? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:17:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:17:53 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle at bywatersolutions.com --- Comment #52 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:20:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:20:22 +0000 Subject: [Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:20:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:20:46 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:21:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:21:56 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00,21.05.09 |22.05.00,21.05.09,21.11.03 released in| | --- Comment #21 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:22:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:22:57 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #22 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:24:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:24:15 +0000 Subject: [Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #4 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:25:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:25:33 +0000 Subject: [Koha-bugs] [Bug 29984] Remove unused method Koha::Patrons->anonymise_issue_history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29984 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:25:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:25:38 +0000 Subject: [Koha-bugs] [Bug 29984] Remove unused method Koha::Patrons->anonymise_issue_history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29984 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130173|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 130174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130174&action=edit Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history The method is no longer used, and replaced by Koha::Old::Checkouts->anonymize. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests still pass 3. Run: $ git grep anonymise_issue_history => SUCCESS: The code doesn't mention it 4. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:36:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:36:49 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:36:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:36:54 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130164|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 130175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130175&action=edit Bug 30007: Regression tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:36:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:36:59 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130163|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 130176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130176&action=edit Bug 30007: Add Koha::Exceptions::SysPref Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:37:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:37:03 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130165|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 130177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130177&action=edit Bug 30007: Make ->anonymize methods throw an exception if AnonymousPatron is not set This patch makes the ->anonymize methods throw a Koha::Exceptions::SysPref::NotSet exception when trying to anonymize holds and checkouts without AnonymousPatron properly set. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t \ t/db_dependent/Koha/Old/Holds.t \ t/db_dependent/Koha/Old/Hold.t => FAIL: Tests fail, no exception thrown 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:43:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:43:18 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:43:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:43:22 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130161|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 130178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130178&action=edit Bug 30023: Add Koha::Old::Checkout->anonymize This patch adds the mentioned method. It replicates the Koha::Old::Hold behavior, including the exception thrown on bad configuration. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkout.t => SUCCESS: Test pass 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 20:43:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 19:43:26 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130162|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 130179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130179&action=edit Bug 30023: Make MarkIssueReturned use ->anonymize Koha::Old::Checkout->anonymize takes care of checking the syspref and raises an exception if not set. So no we can now leverage on it, instead of checking manually and then tweaking the checkout object manually as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 21:00:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 20:00:14 +0000 Subject: [Koha-bugs] [Bug 30029] New: XSLT can chop off too much punctuation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30029 Bug ID: 30029 Summary: XSLT can chop off too much punctuation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To recreate: -Add an 100a like "Griffin, W. E. B." -Go look at that record in either staff results, staff detail, OPAC results, or OPAC detail -It displays as "Griffin, W. E. B" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 21:00:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 20:00:48 +0000 Subject: [Koha-bugs] [Bug 30029] XSLT can chop off too much punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30029 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 21:10:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 20:10:01 +0000 Subject: [Koha-bugs] [Bug 30030] New: Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Bug ID: 30030 Summary: Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails randomly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org See https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/lastCompletedBuild/testReport/ not ok 9 - On invalid "is going to expire" date, the method should not crash with "Invalid local time for date in time zone" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 21:11:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 20:11:15 +0000 Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 21:11:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 20:11:15 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 21:11:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 20:11:41 +0000 Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Test |Test |t/db_dependent/Koha/Patrons |t/db_dependent/Koha/Patrons |.t is_going_to_expire fails |.t is_going_to_expire fails |randomly |on U18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 21:12:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 20:12:54 +0000 Subject: [Koha-bugs] [Bug 30031] New: Add lists to table settings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Bug ID: 30031 Summary: Add lists to table settings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: hebah at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The contents table of List columns in the staff client are not configurable via table settings and should be. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 21:13:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 20:13:35 +0000 Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 21:35:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 20:35:25 +0000 Subject: [Koha-bugs] [Bug 30032] New: Can't reserve from local holds group from OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30032 Bug ID: 30032 Summary: Can't reserve from local holds group from OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This is my understanding of local hold groups: you can limit holds to users from a group of libraries to items from the same group of libraries. Maybe I misunderstand the local holds group functionality, but it doesn't seem to work with OPAC holds. Here's what I did: (note: OPACAllowUserToChooseBranch is set to don't allow) (note bis: CircControl is set to library where the item is from) 1) Create a local hold group 1- Go to Administration > Library groups 2- Click "Add group" 3- Fill out form - Name: RES - Description: For holds tests - Features: Is local hold group 4- Click "Save" 5- In the RES group, click "Add library" and choose "Centreville" 6- In the RES group, click "Add library" and choose "Franklin" 2) Adjust circulation rules 1- Go to Administration > Circulation and fines rules 2- In "Select a library", choose "Franklin" 3- In "Default checkout, hold and return policy for Franklin" (the second table), fill out like so - Total current checkouts allowed: leave empty - Total current on-site checkouts allowed: leave empty - Maximum total holds allowed: leave empty - Hold policy: from local hold group - Hold pickup library match: item's hold group - Return policy: item returns home 4- Click "Save" (also make sure patrons can place holds from the opac, ideally on available items (on shelf holds), otherwise you will have to borrow the items before placing holds) 3) Create a Franklin patron 1- Go to Patrons 2- Click "New patron" 3- Choose a category (that can place holds) 4- Fill out mandatory fields, making sure the patron is attached to Franklin library (and note userid and password) 5- Click "Save" 4) Create a Centreville patron 1- Go to Patrons 2- Click "New patron" 3- Choose a category (that can place holds) 4- Fill out mandatory fields, making sure the patron is attached to Centreville library (and note userid and password) 5- Click "Save" 5) If none exist, catalog a record and add an item belonging to Franklin library 1- Go to Cataloging 2- Click "New record" 3- Fill out mandatory fields (usually 000, 003, 005, 008, 040, 245, 942) 4- Click "Save" 5- In the item fields, change a and b to Franklin 6- Click "Add item" 7- Click "Normal" 8- Click "OPAC view: Open in new window" 6) Try to place hold with Franklin patron 1- Click "Place hold" 2- Log in with Franklin patron 3- Click "Confirm hold" ---> Hold is placed successfully 7) Try to place hold with Centreville patron 1- Log out from the Franklin patron's account 2- Go back to the record 3- Click "Place hold" 4- Log in as Centreville patron ---> There are no items that can be placed on hold. Am I wrong in thinking the Centreville patron should be able to place that item on hold because they are from the same hold group as the item? If not, am I doing something wrong in the process? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 22:14:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 21:14:19 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 22:14:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 21:14:24 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121527|0 |1 is obsolete| | Attachment #121530|0 |1 is obsolete| | Attachment #128505|0 |1 is obsolete| | --- Comment #66 from Arthur Suzuki --- Created attachment 130180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130180&action=edit Bug 25408: Added unit tests for opacitemholds policy Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 22:15:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 21:15:03 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #67 from Arthur Suzuki --- Created attachment 130181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130181&action=edit Bug 25408: Add "opacitemholds" checks in CanBookBeReserved & CanItemBeReserved The rule "opacitemholds" seemed not to be controlled in some cases. This patch adds a control for this issuingrule in such a way it is checked across all interfaces (staff, opac, api) Added error message when trying to hold on the record and opacitemhold is set to "Force" to item-level hold To test: 0 - Apply patches 1 - Set rule to "Don't allow" item specific holds on opac 2 - Attempt to place hold on staff side 3 - Hold is still allowed 4 - Attempt to place hold from opac or api 5 - Hold is not allowed 6 - Change rule to 'force' 7 - Item-level hold can be placed in all interfaces 8 - Record-level hold cannot be placed in all interfaces Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 23:19:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 22:19:25 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Component|System Administration |Tools CC| |lucas at bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 23:19:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 22:19:47 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 23:20:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 22:20:13 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 4 23:20:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Feb 2022 22:20:15 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 --- Comment #1 from Lucas Gass --- Created attachment 130182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130182&action=edit Bug 30031: Add table settings to staff lists (op=view) To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 5. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 08:18:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 07:18:52 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 08:18:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 07:18:57 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130182|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 130183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130183&action=edit Bug 30031: Add table settings to staff lists (op=view) To test: 1. Apply patch and restart_all 2. Create a list 3. GO to Administration > Table settings 4. In Table settings look under Catalog for lists. 6. The search results table should be listed, with the ability to hide the author, date_added, or call_number 5. Go to the view of your list ( /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=1 ) 7. Make sure you can hide the columns properly. ( The checkbox and Title columns should not be hidable ) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 08:27:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 07:27:17 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement makes the release notes| |columns for lists in the | |staff interface | |configurable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 13:42:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 12:42:13 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Tested suing KTD. Noted this issue when testing: . Generate two or more pages of results - use a or e as the patron search term. . Clicking on 3 or Last results in: . koha_sip (koha_sip) patron being selected as the patron, and . being returned to the area to finish placing a hold . With only two pages of results (search for i) this doesn't occur. Test plan: 1. Search for a record in the staff interface. 2. Go the detail page for an item in the search results. 3. Click 'Place hold'. 4. In the patron search box enter an a or e. 5. Note that the results are unpaginated and all results that match are displayed on one page. 6. Apply the patch and repeat steps 1 to 5. 7. Note that the results are now paginated using the standard DataTables layout and features. 8. Check that everything works as expected: pagination, including Next, last, previous, each number; select columns; change number of results; export. 9. Sign off :D! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 13:48:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 12:48:16 +0000 Subject: [Koha-bugs] [Bug 30004] Prevent TooMany from executing too many SQL queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30004 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Is there an easy way to generate 1,000 checkouts for a patron? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 13:58:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 12:58:48 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #14 from Katrin Fischer --- Why the WONTFIX? I hope it was not my comment, I'd be happy just with the double punctuation removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 14:13:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 13:13:44 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 14:13:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 13:13:49 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129532|0 |1 is obsolete| | Attachment #129534|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 130184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130184&action=edit Bug 29684: fix warn about not found file js/locale_data.js To reproduce (memberentry.pl): 1) Head over to the patron details page, press edit button to open the memberentry.pl page. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 14:13:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 13:13:53 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #13 from David Nind --- Created attachment 130185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130185&action=edit Bug 29684: fix warn about not found file js/locale_data.js To reproduce (paycollect.pl): 1) Prepare or use some existing patron with outstanding fines, go to the accounting section and open page where you make payment towards all fines. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 14:13:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 13:13:58 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129536|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 130186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130186&action=edit Bug 29684: add honeypot to catch other warnings in the future Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 14:25:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 13:25:05 +0000 Subject: [Koha-bugs] [Bug 29995] Rest API Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 14:31:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 13:31:41 +0000 Subject: [Koha-bugs] [Bug 30012] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30012 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|How to cancel a pending |SPAM |transaction on the cash app | |effortlessly? | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 14:36:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 13:36:46 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 14:36:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 13:36:52 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128549|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 130187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130187&action=edit Bug 29504: Allow 'ADDITIONAL_MATERIALS' check to be confirmed The additional materials check when CircConfirmParts is enabled was errantly relying upon the 'FORCE_CHECKOUT' permission. This patch updates the template to allow confirmation as well as cancellation of chekout. Test plan 1. Set a staff member with circ permissions, but not FORCE_CHECKOUT 2. Turn on CircConfirmItemParts 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 5. The only option given is the Continue button (with a red X) and when clicked, the item does not get checked out. 6. Apply patch 7. Repeat step 4. 8. You should now have the option to 'Yes, check out (Y)' or 'No, don't check out (N)' Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 14:36:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 13:36:57 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128550|0 |1 is obsolete| | --- Comment #16 from David Nind --- Created attachment 130188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130188&action=edit Bug 29504: (follow-up) Account for other blockers Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 14:38:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 13:38:44 +0000 Subject: [Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 18:35:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 17:35:02 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 18:35:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 17:35:06 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128904|0 |1 is obsolete| | --- Comment #31 from David Nind --- Created attachment 130189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130189&action=edit Bug 26129: Add new 'configurations' table This patch introduces a new table to kohastructure.sql and an atomic update script to add the table on update. It also includes the corresponding schema file. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 18:35:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 17:35:11 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128905|0 |1 is obsolete| | --- Comment #32 from David Nind --- Created attachment 130190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130190&action=edit Bug 26129: Add Koha::Configuration(s) classes This patch adds the Koha::Configuration(s) classes and tests. It is similar to the Koha::CirculationRules(s) classes, but with simpler use cases for now. There's no special handling for '*' as it is expected to be passed undef instead. It allows to set arbitrary configuration entries either globally or for specific library_id, category_id or item_type. Attribute names match the ones agreed for the API. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: The atomic update is applied correctly 3. Run: $ reset_all => SUCCESS: kohastructure.sql is loaded without issues 4. Run: $ kshell k$ prove t/db_dependent/Koha/Configurations.t => SUCCESS: Tests pass! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 18:35:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 17:35:16 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128906|0 |1 is obsolete| | --- Comment #33 from David Nind --- Created attachment 130191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130191&action=edit Bug 26129: DBIx::Class schema updates [DO NOT PUSH] Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 20:06:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 19:06:43 +0000 Subject: [Koha-bugs] [Bug 29742] Make deletemem.pl use Koha::Patron->safe_to_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29742 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #2 from David Nind --- Hi Tomás. After applying the patch (plus a flush_memcached + restart_all) I get this error when deleting a patron with no conditions that should stop the deletion: Operation "eq": no method found, left argument in overloaded package Koha::Result::Boolean, right argument has no overloaded magic at /kohadevbox/koha/members/deletemem.pl line 86 in (eval) at /kohadevbox/koha/members/deletemem.pl line 86 83: 84: my $safe_to_delete = $patron->safe_to_delete; 85: 86: if ( $safe_to_delete eq 'is_anonymous_patron' ) { 87: print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member&error=CANT_DELETE_ANONYMOUS_PATRON"); 88: exit 0; # Exit without error 89: } in CGI::Compile::ROOT::kohadevbox_koha_members_deletemem_2epl::__ANON__ at /kohadevbox/koha/members/deletemem.pl line 2 1: #!/usr/bin/perl 2: 3: #script to delete items 4: #written 2/5/00 5: #by chris at katipo.co.nz Show function arguments in CGI::Compile::ROOT::kohadevbox_koha_members_deletemem_2epl::deletemem_2epl at /usr/share/perl5/CGI/Compile.pm line 151 148: # this is necessary for MSWin32 149: my $orig_warn = $SIG{__WARN__} || sub { warn(@_) }; 150: local $SIG{__WARN__} = sub { $orig_warn->(@_) unless $_[0] =~ /^No such signal/ }; 151: $code->($self, $data, $path, $dir, \@args) 152: }; 153: }; 154: in CGI::Emulate::PSGI::__ANON__ at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 27: local *STDOUT = $stdout; 28: local *STDERR = $env->{'psgi.errors'}; 29: 30: $code->(); 31: } 32: } 33: Show function arguments in Plack::App::WrapCGI::call at /usr/share/perl5/Plack/App/WrapCGI.pm line 95 92: 93: sub call { 94: my($self, $env) = @_; 95: $self->_app->($env); 96: } 97: 98: 1; Show function arguments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 20:50:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 19:50:48 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 20:50:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 19:50:52 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128410|0 |1 is obsolete| | --- Comment #17 from David Nind --- Created attachment 130192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130192&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now https://bugs.koha-community.org/show_bug.cgi?id=29173 Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 20:50:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 19:50:57 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128756|0 |1 is obsolete| | --- Comment #18 from David Nind --- Created attachment 130193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130193&action=edit Bug 29173: (follow-up) add marcflavour preference in conditions Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 21:14:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 20:14:58 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #19 from David Nind --- Testing notes (using koha-testing-docker): - Tested using both a MARC21 and UNIMARC installation. - For a UNIMARC installation there is only one way to replace (both before and after the patch is applied): . Select Edit > Edit record . Click on the 'Replace record via Z39.50/SRU search' button => There is no option in the dropdown list to change like a MARC21 installation (Edit > Replace record via Z39.50/SRU search) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 22:03:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 21:03:32 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #19 from David Nind --- I have tested this and it works as expected. I would suggest these changes: 1. System preference name: change from HighlightedWords to StaffHighlightedWords 2.System preference wording: . Current: Don't highlight|Highlight words the patron searched for in their search results and detail pages. . Suggested: Don't highlight|Highlight words searched for in the staff interface search results pages. . Notes: For me the highlighting is only working on the search listing results pages, not on the record detail pages. - Location in the system preferences area: I would put under Staff interface > Appearance as this is consistent with the OPAC system preference, rather than under Searching > Results display. - Enable highlighting by default: as this is a change in the default behavour I would tend to leave the default (highlighting) enabled, rather than disabling it (that is, set the default to Highlight). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 23:14:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 22:14:49 +0000 Subject: [Koha-bugs] [Bug 29883] Uninitialized value warning when GetAuthorisedValues gets called with no parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- Happy to test, but how can I generate the warning? Want to generate the warning, however that is done), then see if it goes away after the patch is applied. I updated the description for the OPAC for authorised values for CCODE and viewed records in the OPAC. This didn't generate the warning. (There is a different warning though when accessing the details page in the OPAC and staff interface: [2022/02/05 22:08:30] [WARN] Use of uninitialized value $value in concatenation (.) or string at /kohadevbox/koha/C4/XSLT.pm line 289.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 23:41:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 22:41:08 +0000 Subject: [Koha-bugs] [Bug 29858] Item.pm "Use of uninitialized value" warn when $field var is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29858 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- Happy to test if you could provide the steps to set things up so that the warning is generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 23:53:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 22:53:29 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 23:53:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 22:53:33 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128284|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 130194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130194&action=edit Bug 15594: preserve sequence of 260 subfields in detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 23:53:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 22:53:38 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128369|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 130195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130195&action=edit Bug 15594: preserve sequence of 260 subfields in (staff) detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to staff detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 23:56:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 22:56:29 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the|Improved display of MARC |This enhancement improves release notes|field 260 in the detail |the display of MARC field |page by respecting the |260 in the detail page for |order of subfields in the |the OPAC and staff |record. Previously, |interface by using the |$a$b$a$b would be displayed |order of subfields in the |as aabb. |record. Previously, | |$a$b$a$b would display as | |aabb. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 5 23:59:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 22:59:34 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- I tried testing this using koha-testing-koha. However, I couldn't create a report that would run long enough as there are only 400-500 records in the sample database. Do you have a complicated report that takes a while to run, or do I just need to import a large number of MARC records? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 00:56:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 23:56:43 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #44 from Victor Grousset/tuxayo --- Various pages broken due to TT tags broken due to missing % -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 00:57:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 23:57:00 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128542|0 |1 is obsolete| | --- Comment #45 from Victor Grousset/tuxayo --- Created attachment 130196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130196&action=edit Bug 29602: Surround strings with span tag To be nicer with translators. Update the PO files for whichever languages will show how this is useful. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 00:57:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 23:57:05 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128543|0 |1 is obsolete| | --- Comment #46 from Victor Grousset/tuxayo --- Created attachment 130197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130197&action=edit Bug 29602: (follow-up) Surround strings with span tag To be nicer with translators. Update the PO files for whichever languages will show how this is useful. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 00:57:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 23:57:10 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #47 from Victor Grousset/tuxayo --- Created attachment 130198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130198&action=edit Bug 29602: (follow-up) Fix TT tags broken due to missing % -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 00:57:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 23:57:15 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #48 from Victor Grousset/tuxayo --- Created attachment 130199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130199&action=edit Bug 29602: (follow-up) fix crash: SET KohaSpan → USE KohaSpan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 00:57:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Feb 2022 23:57:20 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #49 from Victor Grousset/tuxayo --- Created attachment 130200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130200&action=edit Bug 29602: (follow-up) fix duplicate, missing or mismatching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 01:04:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Feb 2022 00:04:32 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #50 from Victor Grousset/tuxayo --- Patches rebased. And followups added that fix various issues. After rereading carefully the diff (`git diff --color-words=.` was very useful!) and using some greps, rg --glob '{*.tt,*.inc}' '\-]' rg --glob '{*.tt,*.inc}' ' ] References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #51 from Victor Grousset/tuxayo --- If someone proofreads my follow-ups and retests some of the pages then we should be good to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 07:15:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Feb 2022 06:15:10 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Attachment #129630|0 |1 is obsolete| | --- Comment #8 from David Nind --- Comment on attachment 129630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129630 Bug 29826: Remove warning in t/db_dependent/Template/Plugin/Branches.t Replaced by later patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 07:18:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Feb 2022 06:18:30 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 07:18:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Feb 2022 06:18:34 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130030|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 130201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130201&action=edit Bug 29826: Manage call of Template Plugin Branches GetName() with null or empty branchcode Bug 26587 added a concatenation that sends a warning if var is undef : $ prove t/db_dependent/Template/Plugin/Branches.t Use of uninitialized value $branchcode in concatenation (.) or string at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 35. This patch adds an early return empty string when GetName is called with $branchcode null or empty string. Test plan : 1) Run t/db_dependent/Template/Plugin/Branches.t without patch 2) Run with the patch to see warning disappear Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 23:11:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Feb 2022 22:11:10 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #52 from Victor Grousset/tuxayo --- Updating the .po files on master and then updating with the patches allows to see that it cleans up a lot of stuff <3 It seems the net change is +400 strings but the ~200 removed are generally terrible and long and the ~600 are generally simple. The most weird stuff I've found in a few minutes of skimming are like: msgid "\", \"dt_count\": \"%s\", \"dt_is_shared\": \"%s" It looks like the extraction script that takes things that it shouldn't but at least these don't have work to do besides copy and paste. Counting: git diff | grep "\-msgid" | wc -l 218 git diff | grep "\+msgid" | wc -l 647 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 23:21:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Feb 2022 22:21:31 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 23:46:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Feb 2022 22:46:54 +0000 Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365 --- Comment #16 from David Cook --- (In reply to Blou from comment #15) > We have the problem in searches (opac/staff). ES indexes without any > problem. I see the data returned when turning on trace_to in koha-conf.xml. > > But somewhere in Koha or MARC library, something breaks. The records with a > 505$a longer than 9999 characters are not displayed correctly in the results. > > Actually, NO data shows up. But there's an empty entry in the results. The > other records are listed without problem. > > Considering that the xslt for the results never infer to 505 the slightest, > it seems to me its the marcxml that breaks down. Somewhere, somehow. Are you able to reliably reproduce that problem? If so, attach a copy of that record here with the steps needed to reproduce it. Someone might be able to take it somewhere then. Long ago, I locally customized the Zebra indexing to only index 5000 characters for the notes fields, as I think that 9999+ notes fields were causing us problems, but I think the original record would still be retrieved and used in Koha. Since you're using ES, that's probably not relevant. Sounds like more investigation is needed, but also sounds like an edgecase, so perhaps more of a support issue... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 6 23:50:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Feb 2022 22:50:27 +0000 Subject: [Koha-bugs] [Bug 27365] Koha doesn't check marcxml field size is < 10000 and fails in various places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27365 --- Comment #17 from David Cook --- (You may also want to change the issue report title to something more specific. 'fails in various places' is too vague I think.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 02:18:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 01:18:18 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #13 from David Cook --- Glad to see this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 02:28:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 01:28:53 +0000 Subject: [Koha-bugs] [Bug 30026] International Phone Number Not supported for SMSAlert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- That's interesting. So that 00 is an exit code which is very country specific, so I don't think this patch will work in all contexts. While I wouldn't call it Euro-centric per se, since 00 is used elsewhere, it doesn't cover all international use cases. For instance, the exit code for Australia is 0011 (instead of 00). Canada/USA is 011. Russia is 810. Some places like Israel also use carrier codes instead of exit codes. Perhaps we should have a system preference that allows a library to specify 1+ exit codes to use in lieu of a "+" for the regex. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 02:31:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 01:31:52 +0000 Subject: [Koha-bugs] [Bug 30026] International Phone Number Not supported for SMSAlert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 --- Comment #3 from David Cook --- Since the exit code is specific to the dialler rather than the recipient maybe the data input isn't the right place to check this either. Maybe the SMSAlert plugin should check if the phone number has a "+" prefix and if not... then add an exit code? Is the use case that the library would be SMSing mobiles outside their own national area? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 03:55:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 02:55:35 +0000 Subject: [Koha-bugs] [Bug 30013] Limit/throttle/retry SMTP connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 03:55:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 02:55:50 +0000 Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 03:57:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 02:57:44 +0000 Subject: [Koha-bugs] [Bug 30017] Should we prefer `loop.first` and `loop.last` over calling `variable.count` to reduce our DB hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30017 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- Sounds reasonable to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 04:25:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 03:25:26 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #14 from Mason James --- (In reply to Victor Grousset/tuxayo from comment #13) > I have the following conflict with 20.11.x > > <<<<<<< HEAD > requires 'YAML', '0.71'; > requires 'YAML::Syck', '0.71'; > ||||||| parent of 81ce0e2db5 (Bug 28926: Update cpanfile for > Mojolicious::Plugin::OpenAPI v2.16) > requires 'YAML::XS', '0.67'; > ======= > requires 'YAML::XS', '0.76'; > >>>>>>> 81ce0e2db5 (Bug 28926: Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16) > > > This diff3 conflictstyle tells that 20.11.x has YAML and YAML::Syck which on > the next Koha versions were replaced by YAML::XS. > > Should I just add YAML::XS 0.76 ? lets attempt to add this patch without any YAML::* updates first if problems occue with CI testing, we can add 27673 and 22824, or revert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 04:35:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 03:35:20 +0000 Subject: [Koha-bugs] [Bug 30034] New: Automatic debian/control updates (testing) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Bug ID: 30034 Summary: Automatic debian/control updates (testing) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com a bug to use for testing debian/control updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 04:35:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 03:35:34 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |mtj at kohaaloha.com |y.org | Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 06:04:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 05:04:36 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #1 from Mason James --- Created attachment 130202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130202&action=edit buildbot 19.11.25-0 for stretch: update debian/changelog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 06:06:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 05:06:58 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #2 from Mason James --- Created attachment 130203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130203&action=edit new file: test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 07:56:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 06:56:31 +0000 Subject: [Koha-bugs] [Bug 26269] "Download file of displayed overdues" in Circulation->Overdues produces .csv with fewer results than the displayed list under certain circumstances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130166|0 |1 is obsolete| | --- Comment #5 from sandboxes at biblibre.com --- Created attachment 130204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130204&action=edit MT28016: "Date due to" and "Show any items currently checked out" filters doesn't work properly in overdues.pl Filter "Date due to" is now taken into account even when filled with a future date for the displayed result and downloaded results. Filter "Show any items currently checked out" is now taken into account for the downloaded results. To test: 1- Go to Circulation then to overdues 2a- Add a filter with "Date due To" > today 2b- Check that only the results with "Due date" < today are displayed (not those with "Due date" between today and the date requested) 2c- Click on "Download file of displayed overdues" 2d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 3a- Reset filter and then add the filter "Show any items currently checked out" 3b- Check that all the results are displayed (even those with "Due date" > today) 3c- Click on "Download file of displayed overdues" 3d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 9- Apply the patch 10- Repeat step 1 to 8, checking that all the results corresponding to the selected filter are now displayed/downloaded https://bugs.koha-community.org/show_bug.cgi?id=26269 Signed-off-by: Theodoros Theodoropoulos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 08:03:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 07:03:50 +0000 Subject: [Koha-bugs] [Bug 26269] "Download file of displayed overdues" in Circulation->Overdues produces .csv with fewer results than the displayed list under certain circumstances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Theodoros Theodoropoulos --- Patch provided by Marion seems to do the trick! Thank you BibLibre :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 08:44:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 07:44:33 +0000 Subject: [Koha-bugs] [Bug 30034] Test Attachment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatic debian/control |Test Attachment |updates (testing) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 08:48:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 07:48:04 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Test Attachment |Automatic debian/control | |updates (testing) --- Comment #3 from Mason James --- 130203 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 08:58:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 07:58:01 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #4 from Mason James --- Created attachment 130205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130205&action=edit Test Attachment This is a new attachment comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 09:10:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 08:10:40 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130202|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 09:30:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 08:30:08 +0000 Subject: [Koha-bugs] [Bug 30026] International Phone Number Not supported for SMSAlert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 --- Comment #4 from Florian --- I did take a look at other countries' exit code to make sure none would be penalized by this regex, and from what I could find online, all of your examples would still work. The regex isn't exactly foolproof but it should be flexible enough to allow for all valid phones numbers. I did consider the alternative of switching the SMSAlert input field from a text to a tel, since it seems to naturally check for valid phone numbers. > That's interesting. > > So that 00 is an exit code which is very country specific, so I don't think > this patch will work in all contexts. While I wouldn't call it Euro-centric > per se, since 00 is used elsewhere, it doesn't cover all international use > cases. > > For instance, the exit code for Australia is 0011 (instead of 00). > Canada/USA is 011. Russia is 810. Some places like Israel also use carrier > codes instead of exit codes. > > Perhaps we should have a system preference that allows a library to specify > 1+ exit codes to use in lieu of a "+" for the regex. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 09:33:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 08:33:46 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130203|0 |1 is obsolete| | Attachment #130205|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 09:37:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 08:37:19 +0000 Subject: [Koha-bugs] [Bug 30026] International Phone Number Not supported for SMSAlert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 --- Comment #5 from Florian --- (In reply to David Cook from comment #3) > Since the exit code is specific to the dialler rather than the recipient > maybe the data input isn't the right place to check this either. > > Maybe the SMSAlert plugin should check if the phone number has a "+" prefix > and if not... then add an exit code? > > Is the use case that the library would be SMSing mobiles outside their own > national area? It seems to me that forcing the addition of an exit code might cause a lot more problems down the line, since you would need to check if, for instance, a number starting with 011 is for the USA/Canada or just a local territorial number in your country. We do have some libraries that are located next to country borders, and it's not uncommon for residents of these areas to use two phones or sim cards, one for each side of the border. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 09:49:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 08:49:48 +0000 Subject: [Koha-bugs] [Bug 30035] New: Wrong month name in numbering pattern Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 Bug ID: 30035 Summary: Wrong month name in numbering pattern Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Serials Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org In some languages (at least Catalan) the display for "month name" in the numbering pattern is wrong. For January for instance we use "de gener" when it should be "gener". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 09:50:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 08:50:04 +0000 Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |hagud at orex.es -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 09:50:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 08:50:48 +0000 Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 09:50:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 08:50:52 +0000 Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 --- Comment #1 from Jonathan Druart --- Created attachment 130206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130206&action=edit Bug 30035: Fix month name in prediction pattern We are using %B to display the month name but it seems that using the CLDR pattern LLLL would be more appropriated. https://metacpan.org/pod/DateTime#CLDR-Patterns %B - The full month name. LLLL - The wide stand-alone form for the month. For instance in Catalan: https://metacpan.org/pod/DateTime::Locale::ca %B will display "de gener" when LLLL will be "gener" Test plan: Create a new numbering pattern: Home > Serials > Numbering patterns > New numbering pattern Numbering formula: {X} Label: monthname Add: 1 Every: 1 Set back to: 1 When more than: 999 Formatting: Name of month And test it at the bottom of the form Locale: Catalan The number column should contain "gener", not "de gener" Test other locales and confirm that the output is correct (no change expected for English, French and Spanish for instance). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 10:00:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 09:00:56 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #5 from Mason James --- Created attachment 130207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130207&action=edit new file: test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 10:55:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 09:55:50 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 11:48:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 10:48:40 +0000 Subject: [Koha-bugs] [Bug 30036] New: Add xslt for authority results normal view in OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Bug ID: 30036 Summary: Add xslt for authority results normal view in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jeremy.breuillard at biblibre.com QA Contact: testopia at bugs.koha-community.org https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 offers to display OPAC details in XSLT. We could do the same thing for the authority OPAC results searching ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 11:52:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 10:52:06 +0000 Subject: [Koha-bugs] [Bug 30036] Add xslt for authority results normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21330 CC| |jeremy.breuillard at biblibre. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 [Bug 21330] Add xslt for authority normal view in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 11:52:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 10:52:06 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30036 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 [Bug 30036] Add xslt for authority results normal view in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 11:59:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 10:59:50 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02,21.05.08 |22.05.00,21.11.02,21.05.08, released in| |20.11.15 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net --- Comment #13 from Victor Grousset/tuxayo --- Backported: Pushed to 20.11.x branch for 20.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:17:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:17:02 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:17:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:17:37 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:29:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:29:06 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 --- Comment #2 from Jérémy Breuillard --- Created attachment 130208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130208&action=edit Bug 21330: Add xslt for authority normal view in OPAC This patch provides a xslt stylesheet on authority normal view in OPAC. Have a look on opac-authoritiesdetail.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Click details on a result and notice the view 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 2) and 3) and notice the display This is a similar bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:32:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:32:09 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:32:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:32:24 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #32 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:33:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:33:10 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:33:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:33:39 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:33:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:33:43 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129591|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi --- Created attachment 130209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130209&action=edit Bug 29881: libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) to test... - attempt to install koha-common pkg on deb12 confirm error... The following packages have unmet dependencies: koha-common : Depends: libdbd-sqlite2-perl but it is not installable - apply patch, rebuild new package - install new koha-common pkg on deb12 successfully Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:34:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:34:22 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:35:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:35:28 +0000 Subject: [Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:36:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:36:48 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #14 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:39:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:39:41 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #11 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:44:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:44:04 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:44:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:44:07 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:44:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:44:10 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:44:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:44:13 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:44:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:44:34 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 130210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130210&action=edit Bug 29684: Fix warn about js/locale_data.js (memberentry.pl) To reproduce (memberentry.pl): 1) Head over to the patron details page, press edit button to open the memberentry.pl page. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:44:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:44:39 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 130211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130211&action=edit Bug 29684: Fix warn about js/locale_data.js (paycollect.pl) To reproduce (paycollect.pl): 1) Prepare or use some existing patron with outstanding fines, go to the accounting section and open page where you make payment towards all fines. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:44:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:44:43 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 130212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130212&action=edit Bug 29684: add honeypot to catch other warnings in the future Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:46:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:46:08 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:47:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:47:12 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:48:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:48:26 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:49:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:49:36 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:50:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:50:23 +0000 Subject: [Koha-bugs] [Bug 29604] Term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:50:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:50:39 +0000 Subject: [Koha-bugs] [Bug 29646] Bad or repeated opac-password-recovery attempt crashes on wrong borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:51:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:51:25 +0000 Subject: [Koha-bugs] [Bug 29729] If serials_stats.pl returns no results dataTables get angry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:51:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:51:49 +0000 Subject: [Koha-bugs] [Bug 29865] Wrong includes in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:52:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:52:23 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:52:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:52:24 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Bug 29695 depends on bug 29591, which changed state. Bug 29591 Summary: Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:52:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:52:42 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #16 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:53:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:53:02 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:53:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:53:07 +0000 Subject: [Koha-bugs] [Bug 29865] Wrong includes in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.11.03 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:53:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:53:47 +0000 Subject: [Koha-bugs] [Bug 29840] opac-reserve explodes if invalid biblionumber is passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29840 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:56:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:56:26 +0000 Subject: [Koha-bugs] [Bug 28943] Lower the risk of accidental patron deletion by cleanup_database.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #24 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:57:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:57:42 +0000 Subject: [Koha-bugs] [Bug 29837] JS error during installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:59:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:59:08 +0000 Subject: [Koha-bugs] [Bug 29156] File missing warning in Koha::UploadedFile should be for permanent files only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 12:59:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 11:59:53 +0000 Subject: [Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:03:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:03:11 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:03:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:03:14 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129732|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:03:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:03:17 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:03:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:03:38 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 130213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130213&action=edit Bug 29754: Unit test This adds a unit test to the SIP code It also adds some spacing and dividers to make the tests for 'relationships_debt' easier to read To test: prove -v t/db_dependent/Koha/Patron.t - passes and is readable prove -v t/db_dependent/SIP/Patron.t - fails Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:03:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:03:43 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 130214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130214&action=edit Bug 29754: Don't include patron when fetching guarantees fines This patch removes the flag to fetch the patrons own debts as we have already calculated them This test plan highlights another issue - the value of NoIssuesChargeGuarantorsWithGuarantees is not checked in SIP code - we merely get the total owed including guarantees and compares to noissuescharge See bug 29755 To test: 1 - Apply first patch only 2 - prove t/db_dependent/SIP/Patron.t 3 - It fails 4 - Enable NoIssuesChargeGuarantorsWithGuarantees, you can set to 1 5 - Create/find a patron 6 - Add a $10 charge to parons account 7 - Add a guarantee to patron 8 - Add a $5 charge to guarantee 9 - Set noissuescharge to 15.01 10 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron BARCODE 11 - Note the 64 message starts with Y's that mean patron is blocked 12 - Patron shouldn't be blocked as under 15.01 13 - Apply patch 14 - Restart all 15 - repeat 10 16 - Patron is no longer blocked Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:03:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:03:47 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 130215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130215&action=edit Bug 29754: (QA follow-up) Minor tests tweaks This patch does two things: - Wraps the new SIP tests in a single transaction. We do that to avoid sub-test interference, specially when test files get big. The provided tests are correct and don't require previous tests data. - Migrated from the introduced 'diag' calls to 'note', as I just learned they are the same, but 'note' is only displayed when in verbose mode. Which is great to avoid unnecessary noise in Jenkins. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:04:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:04:07 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 --- Comment #15 from Kyle M Hall --- (In reply to Martin Renvoize from comment #14) > I've un-obsoleted the two patches.. did you test these too Kyle.. looks like > a simple git-bz mishap to me. I believe you are correct sir! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:05:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:05:28 +0000 Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:15:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:15:37 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:15:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:15:40 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129892|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 130216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130216&action=edit Bug 29960: Remove Modernizr dependency in the OPAC This patch refactors the code around JavaScript-driven responsive behavior in the OPAC. The use of Modernizr dropped and the dependency removed. This patch also adds a missing listing for Enquire.js licensing on the "About" page. To test, apply the patch and perform a catalog search in the OPAC. - Narrow your browser window until its width falls below 609 pixels (Using your browser's Responsive Design Mode is helpful for this, e.g. https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode) - The window should automatically scroll to the "main content" area, in this case the section headed by "Your search returned..." - Change your browser window's width until it falls below 768 pixels. - Scroll to the bottom of the search results where you should find the "Refine your search" facets box collapsed. - As you increase your browser width above 768 pixels the facets box should expand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:21:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:21:37 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #6 from Mason James --- Created attachment 130217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130217&action=edit buildbot 19.11.25-0 for stretch: update debian/control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:25:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:25:35 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:48:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:48:27 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #7 from Mason James --- Created attachment 130218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130218&action=edit new file: test2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:51:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:51:45 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130218|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:51:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:51:56 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #8 from Mason James --- Created attachment 130219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130219&action=edit buildbot 19.11.25-0 for stretch: update debian/control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:54:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:54:19 +0000 Subject: [Koha-bugs] [Bug 27162] Automatic debian/control updates (19.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27162 --- Comment #1 from Mason James --- Created attachment 130220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130220&action=edit buildbot 19.11.25-0 for stretch: update debian/control https://bugs.koha-community.org/show_bug.cgi?id=30034 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:56:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:56:46 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 --- Comment #3 from Jérémy Breuillard --- Comment on attachment 130208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130208 Bug 21330: Add xslt for authority normal view in OPAC >From fb4cd8de85a004d6a51b48cca1f1fcb1638495c0 Mon Sep 17 00:00:00 2001 >From: jeremy breuillard >Date: Mon, 7 Feb 2022 12:00:00 +0100 >Subject: [PATCH] Bug 21330: Add xslt for authority normal view in OPAC > >This patch provides a xslt stylesheet on authority normal view in OPAC. Have a look on opac-authoritiesdetail.pl > >Test plan: >1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 >2)For testing make sure to have at least one or more authorities defined > >3)OPAC: Home > Authority search(Submit) > Authority search results >4)Click details on a result and notice the view >5)Apply patch >6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacDetailsDisplay" >7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' >8)Save changes >9)Repeat 2) and 3) and notice the display > >This is a similar bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 >--- > .gitignore | 1 + > ...spref-AuthorityXSLTOpacDetailsDisplay.perl | 9 ++ > installer/data/mysql/mandatory/sysprefs.sql | 1 + > .../admin/preferences/staff_interface.pref | 4 + > .../bootstrap/en/modules/opac-auth-detail.tt | 96 ++----------------- > opac/opac-authoritiesdetail.pl | 29 +++++- > 6 files changed, 45 insertions(+), 95 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/add-syspref-AuthorityXSLTOpacDetailsDisplay.perl > >diff --git a/.gitignore b/.gitignore >index c70d94a1dd..b0f5f623e8 100644 >--- a/.gitignore >+++ b/.gitignore >@@ -5,3 +5,4 @@ > node_modules/ > koha-tmpl/opac-tmpl/bootstrap/css/maps/ > koha-tmpl/intranet-tmpl/prog/css/maps/ >+UNIMARCauthResults.xsl >\ No newline at end of file >diff --git a/installer/data/mysql/atomicupdate/add-syspref-AuthorityXSLTOpacDetailsDisplay.perl b/installer/data/mysql/atomicupdate/add-syspref-AuthorityXSLTOpacDetailsDisplay.perl >new file mode 100644 >index 0000000000..868113b885 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/add-syspref-AuthorityXSLTOpacDetailsDisplay.perl >@@ -0,0 +1,9 @@ >+$DBversion = 'XXX'; >+if (CheckVersion($DBversion)) { >+ $dbh->do(q{ >+ INSERT IGNORE INTO systempreferences (`variable`, `value`, `options`, `explanation`, `type`) >+ VALUES ('AuthorityXSLTResultsDisplay','','','Enable XSL stylesheet control over authority results page display on intranet','Free') >+ }); >+ >+ NewVersion($DBversion, '11083', 'Add syspref AuthorityXSLTResultsDisplay'); >+} >\ No newline at end of file >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index dd83a00fd8..01cbd8f8e8 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -69,6 +69,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('AuthorityMergeLimit','50',NULL,'Maximum number of biblio records updated immediately when an authority record has been modified.','integer'), > ('AuthorityMergeMode','loose','loose|strict','Authority merge mode','Choice'), > ('AuthoritySeparator','--','10','Used to separate a list of authorities in a display. Usually --','free'), >+('AuthorityXSLTOpacDetailsDisplay','','','Enable XSL stylesheet control over authority details page display on opac','Free'), > ('AuthSuccessLog','0',NULL,'If enabled, log successful authentications','YesNo'), > ('autoBarcode','OFF','incremental|annual|hbyymmincr|EAN13|OFF','Used to autogenerate a barcode: incremental will be of the form 1, 2, 3; annual of the form 2007-0001, 2007-0002; hbyymmincr of the form HB08010001 where HB=Home Branch','Choice'), > ('AutoCreateAuthorities','0',NULL,'Automatically create authorities that do not exist when cataloging records.','YesNo'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref >index 10c41c581d..4e63e68439 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref >@@ -1,6 +1,10 @@ > Staff interface: > Appearance: > - >+ - 'Display authority details in the opac interface using XSLT stylesheet at: ' >+ - pref: AuthorityXSLTOpacDetailsDisplay >+ class: file >+ - '
Options:
  • Put a path to define a xslt file
  • Put an URL for an external specific stylesheet.
{langcode} will be replaced with current interface language and {authtypecode} will be replaced by the authority type code' > - "Display language selector on " > - pref: StaffLangSelectorMode > choices: >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt >index f0d9fbcc2d..9629aaf05f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt >@@ -50,17 +50,12 @@ >
> > >- [% IF ( displayhierarchy ) %] >-
>- [% PROCESS showhierarchy trees = loophierarchies %] >-
>- [% END %] >- >

[% summary.mainentry | html %][% IF authtypetext %] ([% authtypetext | html %])[% END %]

> >
> [% IF count %]Number of records used in: [% count | html %][% ELSE %]This authority is not used in any records.[% END %] >
>+
> >
> [% FOREACH authorize IN summary.authorized %] >@@ -72,91 +67,12 @@ > [% PROCESS otherscript headings=summary.otherscript wantcategory='preferred' %] >
> >- [% IF summary.seefrom.size %] >-
>-
Used for/see from:
>-
    >- [% FOREACH seefro IN summary.seefrom %] >-
  • >- [% IF seefro.type && seefro.type != 'seefrom' %] >- [% PROCESS authtypelabel type=seefro.type | trim %]: >- [% END %] >- [% PROCESS authheadingdisplay heading=seefro.heading search=seefrosearch authid=seefro.authid %] >-
  • >- [% END %] >- [% PROCESS otherscript headings=summary.otherscript wantcategory='seefrom' %] >-
>-
>- [% END %] >- >- [% IF summary.seealso.size %] >-
>-
See also:
>-
    >- [% FOREACH seeals IN summary.seealso %] >-
  • >- [% IF seeals.type && seeals.type != 'seealso' %] >- [% PROCESS authtypelabel type=seeals.type | trim %]: >- [% END %] >- [% PROCESS authheadingdisplay heading=seeals.heading search=seeals.search authid=seeals.authid %] >-
  • >- [% END %] >- [% PROCESS otherscript headings=summary.otherscript wantcategory='seealso' %] >-
>-
>- [% END %] >- >- [% IF marcflavour == 'UNIMARC' && summary.otherscript %] >-
>-
Other forms:
>-
    >- [% FOREACH otherscrip IN summary.otherscript %] >-
  • >- [% PROCESS language lang=otherscrip.lang | trim %]: >- [% otherscrip.term | html %] >-
  • >- [% END %] >-
>-
>+ [% IF authresult.html %] >+ [% authresult.html | $raw %] >+ [% ELSE %] >+ [% PROCESS authresult summary=authresult.summary authid=authresult.authid %] > [% END %] >- >- [% IF ( MARCURLS ) %] >-
>- Online resources: >-
    >- [% FOREACH MARCurl IN MARCURLS %] >-
  • [% IF ( MARCurl.part ) %][% MARCurl.part | html %]
    [% END %] >- [% IF ( Koha.Preference('OPACURLOpenInNewWindow') ) %] >- >- [% ELSE %] >- >- [% END %] >- [% MARCurl.linktext | html %] >- [% IF ( MARCurl.notes ) %] >-
      >- [% FOREACH note IN MARCurl.notes %] >-
    • [% note.note | html %]
    • >- [% END %] >-
    >- [% END %] >-
  • >- [% END # /FOREACH MARCURLS %] >-
>-
>- [% END # / IF MARCURLS %] >- >-
>- >-
>-
>- [% FOREACH note IN summary.notes %] >-

[% note.note | html %]

>- [% END %] >-
>-
>-
>+ > > > >diff --git a/opac/opac-authoritiesdetail.pl b/opac/opac-authoritiesdetail.pl >index ed0a1c7014..c3ac12fed2 100755 >--- a/opac/opac-authoritiesdetail.pl >+++ b/opac/opac-authoritiesdetail.pl >@@ -69,8 +69,8 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > > my $authid = $query->param('authid'); > $authid = int($authid); >-my $record = GetAuthority( $authid ); >-if ( ! $record ) { >+my $authresult = GetAuthority( $authid ); >+if ( ! $authresult ) { > print $query->redirect("/cgi-bin/koha/errors/404.pl"); # escape early > exit; > } >@@ -86,7 +86,25 @@ if ($display_hierarchy){ > my $count = $authority ? $authority->get_usage_count : 0; > > my $authority_types = Koha::Authority::Types->search( {}, { order_by => ['authtypecode'] } ); >-my $marcurlsarray = GetMarcUrls( $record, $marcflavour ); >+my $marcurlsarray = GetMarcUrls( $authresult, $marcflavour ); >+ >+my $AuthorityXSLTResultsDisplay = C4::Context->preference('AuthorityXSLTResultsDisplay'); >+ if ($authresult && $AuthorityXSLTResultsDisplay) { >+ my $lang = C4::Languages::getlanguage(); >+ >+ my $xsl = $AuthorityXSLTResultsDisplay; >+ >+ $xsl =~ s/\{langcode\}/$lang/g; >+ $xsl =~ s/\{authtypecode\}/$authtypecode/g; >+ my $xslt_engine = Koha::XSLT::Base->new; >+ my $output = $xslt_engine->transform({ xml => $authority->marcxml, file => $xsl }); >+ if ($xslt_engine->err) { >+ warn "XSL transformation failed ($xsl): " . $xslt_engine->err; >+ next; >+ } >+ $authresult->{html} = $output; >+ >+ } > > $template->param( > authority_types => $authority_types, >@@ -94,6 +112,7 @@ $template->param( > authid => $authid, > count => $count, > MARCURLS => $marcurlsarray, >+ authresult => $authresult, > ); > > # find the marc field/subfield used in biblio by this authority >@@ -114,7 +133,7 @@ if ($show_marc) { > my @loop_data = (); > > # loop through each tag >- my @fields = $record->fields(); >+ my @fields = $authresult->fields(); > foreach my $field (@fields) { > my @subfields_data; > >@@ -166,7 +185,7 @@ if ($show_marc) { > } > $template->param( "Tab0XX" => \@loop_data ); > } else { >- my $summary = BuildSummary($record, $authid, $authtypecode); >+ my $summary = BuildSummary($authresult, $authid, $authtypecode); > $template->{VARS}->{'summary'} = $summary; > } > >-- >2.17.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:57:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:57:17 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.breuillard at biblibre. | |com Attachment #130208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:57:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:57:18 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:57:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:57:21 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:57:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:57:24 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127322|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:57:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:57:47 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 130221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130221&action=edit Bug 29397: Add function documentation Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 13:57:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 12:57:51 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 130222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130222&action=edit Bug 29397: Use kohaSelect for pickup locations This patch makes the pickup location dropdowns that rely on Select2 and the API use the new wrapper. The original transport function is removed as it is now embedded in the wrapper. To test: 1. Follow bug 29404 test plan => SUCCESS: All works 2. Apply this patches 3. Repeat 1 => SUCCESS: All works! 4. sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:00:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:00:59 +0000 Subject: [Koha-bugs] [Bug 30036] Add xslt for authority results normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 --- Comment #1 from Jérémy Breuillard --- Created attachment 130223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130223&action=edit Bug 30036: Add xslt for authority results normal view in OPAC This patch provides a xslt stylesheet on authority results normal view in OPAC. Have a look on opac-authorities-home.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Notice the normal view of results 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the xslt view of results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:04:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:04:34 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 --- Comment #4 from Jérémy Breuillard --- Created attachment 130224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130224&action=edit Bug 21330: Add xslt for authority normal view in OPAC This patch provides a xslt stylesheet on authority normal view in OPAC. Have a look on opac-authoritiesdetail.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Click details on a result and notice the view 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacDetailsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the display This is a similar bug: Bug 30036 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:05:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:05:57 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130208|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:06:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:06:20 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:06:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:06:53 +0000 Subject: [Koha-bugs] [Bug 30036] Add xslt for authority results normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:08:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:08:07 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:08:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:08:48 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA --- Comment #18 from Tomás Cohen Arazi --- Back to the RM queue. Fridolin: the last two patches are missing in master. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:10:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:10:38 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:11:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:11:10 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:11:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:11:32 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:11:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:11:32 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Bug 29403 depends on bug 29718, which changed state. Bug 29718 Summary: DateTime - our 'iso' is not ISO 8601 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:11:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:11:53 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:11:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:11:54 +0000 Subject: [Koha-bugs] [Bug 29711] Release date not passed as ISO to about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Bug 29711 depends on bug 29403, which changed state. Bug 29403 Summary: dt_from_string should fail if passed more data than expected for the format https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:12:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:12:53 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:13:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:13:13 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #9 from Mason James --- Created attachment 130225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130225&action=edit new file: test3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:13:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:13:41 +0000 Subject: [Koha-bugs] [Bug 29481] Terminology: Collection code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29481 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #11 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:19:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:19:55 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:19:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:19:56 +0000 Subject: [Koha-bugs] [Bug 28652] Enforce maximum on article request charges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28652 Bug 28652 depends on bug 27946, which changed state. Bug 27946 Summary: Add a charge per article request to patron categories https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:19:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:19:56 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Bug 29759 depends on bug 27946, which changed state. Bug 27946 Summary: Add a charge per article request to patron categories https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:19:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:19:57 +0000 Subject: [Koha-bugs] [Bug 29819] Allow setting AR fees at item type level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29819 Bug 29819 depends on bug 27946, which changed state. Bug 27946 Summary: Add a charge per article request to patron categories https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:20:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:20:38 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:24:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:24:53 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #10 from Mason James --- Created attachment 130226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130226&action=edit new file: test4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:31:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:31:32 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #11 from Mason James --- Created attachment 130227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130227&action=edit new file: test5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:37:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:37:48 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #12 from Mason James --- Created attachment 130228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130228&action=edit new file: test6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:40:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:40:28 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #13 from Mason James --- Created attachment 130229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130229&action=edit new file: test7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 14:47:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 13:47:38 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #14 from Mason James --- Created attachment 130230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130230&action=edit new file: test7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:05:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:05:43 +0000 Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:09:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:09:40 +0000 Subject: [Koha-bugs] [Bug 29946] Sort profiles alphabetically when staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29946 Florian changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |florian.bontemps at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:12:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:12:06 +0000 Subject: [Koha-bugs] [Bug 30036] Add xslt for authority results normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:19:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:19:21 +0000 Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 --- Comment #3 from Owen Leonard --- Remote branch here: https://gitlab.com/koha-dev/koha-dev/-/commits/bug-29155-upgrade-jquery With these patches, jQuery versions in the OPAC and staff interface are both updated to 3.6.0. The latest version of jQuery Migrate is installed to allow us to take a slower approach to updating out-of-date syntax. To test, apply the patches and try as many pages as you can, paying attention to the browser console to watch for errors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:22:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:22:19 +0000 Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:26:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:26:43 +0000 Subject: [Koha-bugs] [Bug 30037] New: Set Default Profile when staging MARC notices on import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Bug ID: 30037 Summary: Set Default Profile when staging MARC notices on import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: florian.bontemps at biblibre.com QA Contact: testopia at bugs.koha-community.org When staging MARC notices on import, the default profile will always be "Do not use profile", even if you have multiple profiles already set up. It would be more intuitive to have a way for the users to set up their own default profile so it shows up on page load. That way, it would also reduce the chances of accidently making a duplicate profile. On our side, we have a fix with a function that makes the profile input search and automatically pick any profile labeled 'default', but this isn't ideal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:29:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:29:06 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130224|0 |1 is obsolete| | --- Comment #5 from Jérémy Breuillard --- Created attachment 130231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130231&action=edit Bug 21330: Add xslt for authority normal view in OPAC This patch provides a xslt stylesheet on authority normal view in OPAC. Have a look on opac-authoritiesdetail.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Click details on a result and notice the view 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacDetailsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the display This is a similar bug: Bug 30036 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:36:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:36:48 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #26 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:37:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:37:07 +0000 Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:37:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:37:21 +0000 Subject: [Koha-bugs] [Bug 29629] Remove two unused intranet MODS XSLT sheets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29629 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:37:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:37:38 +0000 Subject: [Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:37:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:37:38 +0000 Subject: [Koha-bugs] [Bug 29972] The "select a specific item" table on opac-reserve.tt should be column configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29972 Bug 29972 depends on bug 29899, which changed state. Bug 29899 Summary: Show public note to patrons when placing a hold https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:37:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:37:54 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:38:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:38:27 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in full and brief subscription history in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:38:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:38:41 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:38:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:38:41 +0000 Subject: [Koha-bugs] [Bug 28656] Cancellations should be allowed on paid/partially paid debts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28656 Bug 28656 depends on bug 29757, which changed state. Bug 29757 Summary: Add filter_by_non_reversible/reversible methods for offsets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:38:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:38:42 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Bug 29759 depends on bug 29757, which changed state. Bug 29757 Summary: Add filter_by_non_reversible/reversible methods for offsets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:43:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:43:22 +0000 Subject: [Koha-bugs] [Bug 30036] Add xslt for authority results normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130223|0 |1 is obsolete| | --- Comment #2 from Jérémy Breuillard --- Created attachment 130232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130232&action=edit Bug 30036: Add xslt for authority results normal view in OPAC This patch provides a xslt stylesheet on authority results normal view in OPAC. Have a look on opac-authorities-home.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Notice the normal view of results 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the xslt view of results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:44:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:44:37 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 pierre.fagot at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128282|0 |1 is obsolete| | --- Comment #9 from pierre.fagot at biblibre.com --- Created attachment 130233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130233&action=edit Bug 29621: Add link for Lists on opac-detail.pl When logged into the OPAC and viewing a results list of titles on opac-search.pl it is possible to see if a title is contained in a List. The link allows the user to click on it to get to the contents of the List. It would be helpful if the link for the List was also displayed on opac-detail.pl so the user could get to the results of the List from that page as well. This patch uses Koha::Virtualshelves->get_shelves_containing_record() in opac detail page like it is used in opac results page. Test plan : 1) Connect to OPAC as user U1 2) Create a public and a private list 3) Add a record B1 to both lists 4) Go to opac detail page of record B1 5) Without patch your see only link to public list, with patch you also see link to private list 6) Connect to OPAC as another user U2 7) Add record B1 to a private list 8) Go to opac detail page of record B1 9) With patch, check you see only link to your private list, not to list of user U1 Signed-off-by: Owen Leonard Signed-off-by: Pierre Fagot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:44:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:44:42 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 pierre.fagot at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128283|0 |1 is obsolete| | --- Comment #10 from pierre.fagot at biblibre.com --- Created attachment 130234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130234&action=edit Bug 29621: (follow-up) Make all views consistent This follow-up makes various views more consistent: OPAC search results, OPAC details, staff search results, and staff details. The patch also adds an indication to the user which lists are private. To test, apply the patch and rebuild the OPAC and staff CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Repeat the previous test plan in the OPAC and staff client. Signed-off-by: Pierre Fagot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:47:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:47:22 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 pierre.fagot at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.fagot at biblibre.com Status|Needs Signoff |Signed Off --- Comment #11 from pierre.fagot at biblibre.com --- I have executed the test plan everything is working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:49:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:49:13 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 pierre.fagot at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC|pierre.fagot at biblibre.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 15:54:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 14:54:36 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130231|0 |1 is obsolete| | --- Comment #6 from Jérémy Breuillard --- Created attachment 130235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130235&action=edit Bug 21330: Add xslt for authority normal view in OPAC This patch provides a xslt stylesheet on authority normal view in OPAC. Have a look on opac-authoritiesdetail.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Click details on a result and notice the view 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacDetailsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the display This is a similar bug: Bug 30036 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 16:01:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 15:01:19 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|RESOLVED |REOPENED --- Comment #15 from Lucas Gass --- (In reply to Katrin Fischer from comment #14) > Why the WONTFIX? > > I hope it was not my comment, I'd be happy just with the double punctuation > removed. If I set this to WONTFIX, it was accidental. I believe the proper status should now be 'Signed off' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 16:01:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 15:01:33 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 16:01:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 15:01:46 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 16:26:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 15:26:09 +0000 Subject: [Koha-bugs] [Bug 29795] if branchcode is included in PatronSelfRegistrationBorrowerMandatoryField it should default to an empty value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129016|0 |1 is obsolete| | --- Comment #2 from sandboxes at biblibre.com --- Created attachment 130236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130236&action=edit Bug 29795: add empty value for branchcode on self-reg form 1. Set branch code as a PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self reg form and look at the Home library field, it defaults to the first choice alphabetically 3. Fill out the other required fields and the captcha. Don't change the branchcode value. 4. Submit the form, it submits. 5. If branchcode is required it should default to an empty value and force the user to make a choice. 6. Apply patch 7. Repeat 1-3 8. Now you cannot submit the form unless you choose a branchcode 9. Make sure it still works normally when branchcode is not in PatronSelfRegistrationBorrowerMandatoryField Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 16:26:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 15:26:11 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #58 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 16:26:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 15:26:57 +0000 Subject: [Koha-bugs] [Bug 29795] if branchcode is included in PatronSelfRegistrationBorrowerMandatoryField it should default to an empty value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #3 from Sally --- Works as described, thanks for the patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 16:44:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 15:44:25 +0000 Subject: [Koha-bugs] [Bug 29320] Use OverDrive availability API V2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29320 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 16:46:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 15:46:17 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 16:48:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 15:48:51 +0000 Subject: [Koha-bugs] [Bug 30017] Should we prefer `loop.first` and `loop.last` over calling `variable.count` to reduce our DB hits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30017 --- Comment #3 from Jonathan Druart --- Sometimes we need to know if there is are least 1 row, to display a title for instance, or actions (check/uncheck all) at the top of the table. We will then end up with 2 patterns. Not a big deal, but worst noting it. Maybe better to have a TT var defined at the top of the template then reused all along? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:07:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:07:03 +0000 Subject: [Koha-bugs] [Bug 29511] While editing MARC records, blank subfields appear in varying order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29511 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #12 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:07:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:07:34 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:11:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:11:43 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:11:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:11:47 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129571|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 130237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130237&action=edit Bug 29893: Prevent ES mappings UI to remove hidden rows If you are editing ES mappings and you use the DataTable filtering option, the table won't contain all the mappings you have in the DB. If the form is submitted they will be removed and data will be lost! Test plan: Edit ES mappings, filter and submit the form. Confirm that the table are redrawn before the form submission which prevent data loss -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:14:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:14:18 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 --- Comment #6 from Jonathan Druart --- Nick told me the previous patch didn't work for him. This method is using what is described on the DataTable's website https://datatables.net/examples/api/form.html and so might be a better approach. See also https://www.gyrocode.com/articles/jquery-datatables-how-to-submit-all-pages-form-data/#solution-ajax This seems quite ugly to me, especially the redirect, but I don't have anything else to suggest for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:18:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:18:29 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #50 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:19:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:19:32 +0000 Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:19:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:19:33 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Bug 29562 depends on bug 29058, which changed state. Bug 29058 Summary: Add option to not load existing holds table automatically https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:20:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:20:25 +0000 Subject: [Koha-bugs] [Bug 29482] Terminology: This item belongs to another branch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:23:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:23:25 +0000 Subject: [Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130155|0 |1 is obsolete| | --- Comment #9 from sandboxes at biblibre.com --- Created attachment 130238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130238&action=edit Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and create some new additional content. 3. Notice a Save and continue button 4. Try saving and contining. 5. Make sure if you are using the CodeMirror editor that you are still in the CodeMirror editor 6. Try 2 - 5 again but with the wysiwyg editor, make sure when you save and continue you remain in the wysiwyg editor. 7. If you are saving and contining from News make sure you remain in News, when you are saving and contining from HTML customizations make sure you remain there. 8. Turn on the NewsLog system preference 9. With the NewsLog on make sure your content is being logged correctly when you sabe and continue. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:25:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:25:03 +0000 Subject: [Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #10 from Sally --- Tested with the original and amended test plans. Works great, thanks for the patch - this is a superb idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:27:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:27:25 +0000 Subject: [Koha-bugs] [Bug 22659] Add 'save and continue' functionality to news editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds the ability to Save & release notes| |continue when working with | |either News or HTML | |customizations in | |additional_contents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:28:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:28:25 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 --- Comment #5 from Jonathan Druart --- Created attachment 130239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130239&action=edit Bug 29136: Don't redirect if the whole set is > 1 To prevent a redirect when we click on a page with only 1 result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:28:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:28:38 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 --- Comment #6 from Jonathan Druart --- Good catch, David. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:37:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:37:32 +0000 Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium lib is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:38:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:38:20 +0000 Subject: [Koha-bugs] [Bug 29862] TestBuilder.t fails with ES enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:38:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:38:42 +0000 Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130121|0 |1 is obsolete| | --- Comment #8 from sandboxes at biblibre.com --- Created attachment 130240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130240&action=edit Bug 29983: Display the pretend claim column in overdue.tt This patch displays the column "Return claims" from the page "moremember.pl" to the page "overdues.pl". Rebase on master. Test plan: 1)Use a patron with at least 1 item who should be checked out soon 2)Home > Patron > Patron details for [name] 3)Click on the 'Checkout' button down the page to show the full table and notice the "Return Claims" column 4)Now go to Home > Circulation > Overdues 5)Find the patron who has to check out and have a look at the table 6)Apply patch and repeat 4) and 5) -> the "Return Claim" column is now displayed on the table Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:39:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:39:48 +0000 Subject: [Koha-bugs] [Bug 29983] Display the pretend claim column in overdue.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #9 from Sally --- Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:41:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:41:49 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:46:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:46:19 +0000 Subject: [Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #23 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:50:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:50:07 +0000 Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated expiration date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127024|0 |1 is obsolete| | --- Comment #5 from sandboxes at biblibre.com --- Created attachment 130241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130241&action=edit Bug 29338: Add print hold/transfer button to request.tt 1. Apply patch 2. Make some holds, have some item level and some bib level 3. On request.tt notice a new column on the holds_table called 'Print hold/transfer slip' 4. Make sure the button works and takes you to the proper hold/transfer slip 5. Make sure it works well with both item/bib level holds Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:50:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:50:11 +0000 Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated expiration date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128849|0 |1 is obsolete| | --- Comment #6 from sandboxes at biblibre.com --- Created attachment 130242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130242&action=edit Bug 29338: (follow-up) only show print button when hold is waiting or intransit Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:51:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:51:00 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:51:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:51:23 +0000 Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated expiration date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #7 from Sally --- Really like this - great idea. Works as described, signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:51:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:51:46 +0000 Subject: [Koha-bugs] [Bug 29895] Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:52:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:52:19 +0000 Subject: [Koha-bugs] [Bug 19865] Side scroll bar in z39.50 MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #10 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:54:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:54:57 +0000 Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 17:54:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 16:54:57 +0000 Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 Bug 29239 depends on bug 29212, which changed state. Bug 29212 Summary: Use Flatpickr on OPAC pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:18:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:18:33 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:18:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:18:37 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130216|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 130243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130243&action=edit Bug 29960: Remove Modernizr dependency in the OPAC This patch refactors the code around JavaScript-driven responsive behavior in the OPAC. The use of Modernizr dropped and the dependency removed. This patch also adds a missing listing for Enquire.js licensing on the "About" page. To test, apply the patch and perform a catalog search in the OPAC. - Narrow your browser window until its width falls below 609 pixels (Using your browser's Responsive Design Mode is helpful for this, e.g. https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode) - The window should automatically scroll to the "main content" area, in this case the section headed by "Your search returned..." - Change your browser window's width until it falls below 768 pixels. - Scroll to the bottom of the search results where you should find the "Refine your search" facets box collapsed. - As you increase your browser width above 768 pixels the facets box should expand. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:25:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:25:45 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129735|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 130244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130244&action=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson Signed-off-by: AUTHORNAME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:26:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:26:49 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 --- Comment #10 from Tomás Cohen Arazi --- Those limits are inherited from C4::Suggestions::SearchSuggestion, which is to be removed on bug 23991. I stripped this from that bug report in order to backport it to 21.11, which implements /suggestions routes that really need this filter. If the logic is not correct, then it is not correct in Koha already. And we should probably discuss it in a follow-up bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:29:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:29:09 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:29:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:29:10 +0000 Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 Bug 26050 depends on bug 24220, which changed state. Bug 24220 Summary: Convert OpacMoreSearches system preference to news block https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:30:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:30:07 +0000 Subject: [Koha-bugs] [Bug 29967] Increase size of description fields for authorized values in templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29967 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:30:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:30:24 +0000 Subject: [Koha-bugs] [Bug 29949] Remove use of title-numeric sorting routine from OPAC datatables JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29949 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:33:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:33:34 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch refactors the release notes| |code around | |JavaScript-driven | |responsive behavior in the | |OPAC. The use of Modernizr | |removed as it is no longer | |needed. | | | |It also adds a | |missing entry for | |Enquire.js licensing on the | |About page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:42:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:42:15 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:42:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:42:20 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130039|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 130245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130245&action=edit Bug 29136: Ajaxify the patron search when placing a hold Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:42:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:42:25 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130239|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 130246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130246&action=edit Bug 29136: Don't redirect if the whole set is > 1 To prevent a redirect when we click on a page with only 1 result Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:44:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:44:53 +0000 Subject: [Koha-bugs] [Bug 9244] Authorities sorting should take subdivisions into account thanks to DOM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9244 --- Comment #3 from Heather --- We're on 21.05 with MARC21 and authorities are now sorting *with* subdivisions being taken into account, e.g. the following where a subdivision is indicated by a capital letter in the word following the word "Ships" (without capitalization indicates a phrase heading): Topical Term: Ships Heating and ventilation used for/see from: Ships Ventilation see also: Marine machinery (Broader heading) Topical Term 3 record(s) Topical Term: Ships Hydraulic equipment see also: Hydraulic machinery (Broader heading) Topical Term 1 record(s) Topical Term: Ships Hydrodynamics used for/see from: Ships Dynamics see also: Hydrodynamics (Broader heading) Naval architecture (Broader heading) Stability of ships Topical Term 7 record(s) Topical Term: Ships in art Topical Term 101 record(s) Topical Term: Ships in literature Topical Term 2 record(s) Topical Term: Ships in motion pictures see also: Motion pictures (Broader heading) Topical Term 8 record(s) Topical Term: Ships in numismatics used for/see from: Ships on coins see also: Numismatics (Broader heading) Topical Term 5 record(s) Topical Term: Ships Inspection used for/see from: Marine surveying Ship inspection Steamboats Inspection see also: Maritime law (Broader heading) Topical Term 33 record(s) Topical Term: Ships Inspection United States Topical Term 20 record(s) Topical Term: Ships Launching used for/see from: Launching of ships see also: Shipyards (Broader heading) Topical Term 26 record(s) Topical Term: Ships Maintenance and repair used for/see from: Merchant ships Maintenance and repair Ship maintenance Ship repairing Ships Repairing see also: Damage control (Warships) Shipbuilding (Broader heading) Topical Term 57 record(s) Topical Term: Ships Maneuverability used for/see from: Maneuverability of ships see also: Ship handling (Broader heading) Ships Hydrodynamics (Broader heading) Topical Term 6 record(s) Topical Term: Ships Manning used for/see from: Manning of vessels Topical Term 10 record(s) Topical Term: Ships Measurement Topical Term 13 record(s) Topical Term: Ships of the line used for/see from: Warships, Sail see also: Sailing ships (Broader heading) Warships (Broader heading) Topical Term 20 record(s) Topical Term: Ships on postage stamps see also: Postage stamps (Broader heading) Topical Term 15 record(s) Topical Term: Ships Painting see also: Painting, Industrial (Broader heading) Topical Term 9 record(s) Topical Term: Ships Passenger lists used for/see from: Passenger lists see also: Lists (Broader heading) Topical Term 21 record(s) Topical Term: Ships Preservation used for/see from: Mothballing of ships Topical Term 2 record(s) Topical Term: Ships Ratproof construction see also: Ratproof construction (Broader heading) It's also working in the OPAC: https://keys.bywatersolutions.com/cgi-bin/koha/opac-authorities-home.pl?marclist=mainentry&and_or=and&excluding=&operator=start&value=ships&resultsperpage=20&type=opac&op=do_search&authtypecode=TOPIC_TERM&orderby=HeadingAsc&startfrom=2 So this seems to have been fixed during one of the upgrades. Woo-hoo!! Cheerio! h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:45:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:45:36 +0000 Subject: [Koha-bugs] [Bug 24548] Show different status in OPAC for items that have holds but have not yet been captured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24548 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #2 from Koha Team University Lyon 3 --- Created attachment 130247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130247&action=edit screen copy pending hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:45:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:45:54 +0000 Subject: [Koha-bugs] [Bug 24548] Show different status in OPAC for items that have holds but have not yet been captured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24548 --- Comment #3 from Koha Team University Lyon 3 --- Actually, we have in our OPAC a status "pending hold" in a 20.11.09 koha version, but, we don't want to :-( In our library, we want that holds concerned only books already on loan. We left items on shelves for students that prefer to go and see through the library. In the circulation rules, we have "on shelf holds allowed = If any unavailable" and we don't allow OPAC item level holds. It means for us that if one item is borrowed, it is possible to put an hold on the biblio level, but the hold will be filled only if an item is returned. I'm a bit confused because I tried several possibilities for OPACShowHoldQueueDetails but it didn't change anything :-( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:47:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:47:06 +0000 Subject: [Koha-bugs] [Bug 2234] Make cart email from/reply-to/return-path address configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2234 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry --- This bug is still valid and is problematic for large multi-library systems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:52:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:52:18 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #52 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:52:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:52:42 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:52:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:52:43 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Bug 18493 depends on bug 29596, which changed state. Bug 29596 Summary: Add Yiddish language https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:53:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:53:27 +0000 Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement replaces release notes| |the jQueryUI date picker | |used on OPAC pages with | |Flatpickr. The jQueryUI | |date picker is no longer | |supported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 18:55:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 17:55:02 +0000 Subject: [Koha-bugs] [Bug 29943] Fix typo in notices yaml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29943 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:00:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:00:04 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the performance release notes| |and display of patron | |search results when placing | |a hold from a record | |details page using the | |staff interface. Patron | |results are now paginated | |and all the results are now | |available - previously all | |results were listed on one | |page, which could cause | |performance issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:20:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:20:08 +0000 Subject: [Koha-bugs] [Bug 30038] New: Check in error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30038 Bug ID: 30038 Summary: Check in error Change sponsored?: --- Product: Koha Version: 21.05 Hardware: HP OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: d.paolo.berti at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I did a fresh install of Koha and uploaded biographic data and am testing the program. I was able to check out an item but .. when I check in the item using the right barcode I get a general error message. In the intranet-error.log it si reported: [Mon Feb 07 19:19:57.552543 2022] [cgi:error] [pid 7561] [client ::1:57816] AH01215: Use of uninitialized value $returnbranch in string ne at /usr/share/koha/lib/C4/Circulation.pm line 2289.: /usr/share/koha/intranet/cgi-bin/circ/returns.pl, referer: http://localhost:8080/cgi-bin/koha/mainpage.pl [Mon Feb 07 19:19:57.560086 2022] [cgi:error] [pid 7561] [client ::1:57816] AH01215: The to parameter is mandatory: /usr/share/koha/intranet/cgi-bin/circ/returns.pl, referer: http://localhost:8080/cgi-bin/koha/mainpage.pl [Mon Feb 07 19:19:57.621340 2022] [cgi:error] [pid 7561] [client ::1:57816] End of script output before headers: returns.pl, referer: http://localhost:8080/cgi-bin/koha/mainpage.pl so it looks like the problem is in a uninitialized value of $returnbranch I looked for a solution from the koha markmail forum but without result. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:20:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:20:55 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:20:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:20:56 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Bug 18493 depends on bug 29596, which changed state. Bug 29596 Summary: Add Yiddish language https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:21:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:21:10 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:21:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:21:16 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:21:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:21:24 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:21:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:21:31 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:21:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:21:43 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #12 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:51:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:51:26 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net Version(s)|22.05.00,21.11.02,21.05.08 |22.05.00,21.11.02,21.05.08, released in| |20.11.15 --- Comment #19 from Victor Grousset/tuxayo --- Backported: Pushed to 20.11.x branch for 20.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:52:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:52:43 +0000 Subject: [Koha-bugs] [Bug 29503] GET /patrons should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29503 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #14 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:52:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:52:44 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Bug 29506 depends on bug 29503, which changed state. Bug 29503 Summary: GET /patrons should use Koha::Patrons->search_limited https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29503 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:53:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:53:12 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #18 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:53:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:53:12 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Bug 29508 depends on bug 29506, which changed state. Bug 29506 Summary: objects.search should call search_limited if present https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:53:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:53:13 +0000 Subject: [Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Bug 29509 depends on bug 29506, which changed state. Bug 29506 Summary: objects.search should call search_limited if present https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:53:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:53:48 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:54:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:54:07 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:54:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:54:37 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:54:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:54:37 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Bug 29788 depends on bug 29789, which changed state. Bug 29789 Summary: Unused $error in cataloguing/additem.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:55:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:55:13 +0000 Subject: [Koha-bugs] [Bug 29419] Suggest for purchase clears item type, quantity, library and reason if bib exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:55:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:55:31 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #20 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:55:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:55:55 +0000 Subject: [Koha-bugs] [Bug 29557] Auto renew notices should handle failed renewal due to patron expiration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:57:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:57:13 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:58:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:58:29 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,v21.05.09 released in| | CC| |victor at tuxayo.net --- Comment #31 from Victor Grousset/tuxayo --- I see that it was pushed to 21.05.x for v21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 19:58:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 18:58:39 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #32 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 20:00:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 19:00:16 +0000 Subject: [Koha-bugs] [Bug 30039] New: Add published_on column to missing issues table on claims.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039 Bug ID: 30039 Summary: Add published_on column to missing issues table on claims.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be handy if there was a 'Published on' column on the Missing issues table ( #claimst ) on claims.tt There is already a 'Since' column corresponding to serial.planneddate. Thh 'Published on' column would correspond to serial.publisheddate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 20:09:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 19:09:48 +0000 Subject: [Koha-bugs] [Bug 30039] Add published_on column to missing issues table on claims.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 20:09:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 19:09:50 +0000 Subject: [Koha-bugs] [Bug 30039] Add published_on column to missing issues table on claims.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039 --- Comment #1 from Lucas Gass --- Created attachment 130248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130248&action=edit Bug 30039: Add published on column to claims.pl To test: 1. Have a vendor setup 2. Go to serials and add a new serial w/ that vendor. 3. When creating a serial make this first issues sometime in the past. 4. Go to Claims, choose your vendor and load the table. 5. No published on column. 6. Apply patch 7. Try step 4 again and now you should see a published on column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 20:32:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 19:32:59 +0000 Subject: [Koha-bugs] [Bug 29946] Sort profiles alphabetically when staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29946 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129813|0 |1 is obsolete| | --- Comment #2 from sandboxes at biblibre.com --- Created attachment 130249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130249&action=edit Bug 29946: Sort Marc profiles alphabetically To test: 1- Go to Tools > Stage MARC records for import 2- You'll need a MARC file, choose one and hit 'Upload file' 3- Create many Profiles with different names. I used ( ATop, ZTop, JTop, STop, etc. ) 4- Notice that the profiles sort in the order in which you create them 5- Apply patch 6- Try steps 1-2 again 7- Now the dropdown should be sorted alphabetically 8- Make a few more profiles and make sure they are being inserted in the right order alphabetically Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 20:33:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 19:33:58 +0000 Subject: [Koha-bugs] [Bug 29946] Sort profiles alphabetically when staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29946 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 21:27:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 20:27:42 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|These fixes the REST API |This fixes the REST API release notes|route for deleting patrons |route for deleting patrons |so that it now checks for |so that it now checks for |guarantees, debts, and |guarantees, debts, and |current checkouts. If any |current checkouts. If any |of these checks fail, the |of these checks fail, the |patron is not deleted. |patron is not deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 22:14:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 21:14:29 +0000 Subject: [Koha-bugs] [Bug 9244] Authorities sorting should take subdivisions into account thanks to DOM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9244 --- Comment #4 from Katrin Fischer --- Hi Heather, are you using Zebra or Elasticserach? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 22:15:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 21:15:38 +0000 Subject: [Koha-bugs] [Bug 30040] New: Patron attributes in self-registration should work with PatronSelfRegistrationVerifyByEmail Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30040 Bug ID: 30040 Summary: Patron attributes in self-registration should work with PatronSelfRegistrationVerifyByEmail Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Libraries are finding it essential to use extended patron attributes during self-registration. Unfortunately, as clearly stated in the attribute set up, they will not work with PatronSelfRegistrationVerifyByEmail. Libraries need to be able to use both of these functions, together. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 22:17:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 21:17:44 +0000 Subject: [Koha-bugs] [Bug 30038] Check in error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Hardware|HP |All Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Paolo, this sounds more like a support request/configuration issue that should go on the mailing list or IRC. Bugzilla should only be used to report bugs and enhancement requests. For a start: check that in your item you have homebranch and holding branch set to a valid branch of your Koha instance. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 22:37:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 21:37:40 +0000 Subject: [Koha-bugs] [Bug 9244] Authorities sorting should take subdivisions into account thanks to DOM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9244 --- Comment #5 from Heather --- Hi, Katrin! Silly me--I forgot to mention that we're on Elasticsearch. Thank you for reminding me--sorry for forgetting it! --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 22:39:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 21:39:15 +0000 Subject: [Koha-bugs] [Bug 9244] Authorities sorting should take subdivisions into account thanks to DOM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9244 --- Comment #6 from Katrin Fischer --- Hi Heather, no problem at all, I seemed to remember, but was not sure either. Was wondering if we should close this, but maybe we should wait for someone to confirm behaviur for Zebra first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 22:52:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 21:52:15 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 22:57:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 21:57:15 +0000 Subject: [Koha-bugs] [Bug 9244] Authorities sorting should take subdivisions into account thanks to DOM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9244 --- Comment #7 from Heather --- Hey, Katrin-- I just logged into the Bywater demo, and I didn't see any mention of Elasticsearch in the "About" screen, so I think their demo is on Zebra. I did several searches in the authority file (staff client & OPAC), and the authority records all sorted correctly. This is the demo's About page--on our catalog running Elasticsearch, the Elasticsearch line appears just above the Memcached line, which is missing here: --MySQL version: mysql Ver 15.1 Distrib 10.1.48-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 --Apache version: Server version: Apache/2.4.25 (Debian) --PSGI: Plack (deployment) --Memcached: Servers: 127.0.0.1:11211 | Namespace: koha_demo | Status: running. | Config read from: koha-conf.xml --Zebra version: Zebra 2.0.59 (C) 1994-2014, Index Data Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: c00bfddbf0f3608340d61298acc61dafb167f9b2 Using ICU --Zebra status: Running So if this really was a test under Zebra, then I think it's also fixed under Zebra. Cheerio! h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 22:57:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 21:57:59 +0000 Subject: [Koha-bugs] [Bug 28852] Extend options in SelfCheckoutByLogin syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28852 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 22:59:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 21:59:39 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer --- QA test tools fail: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL valid_template Attempt to reload Koha/Template/Plugin/Branches.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Plugins.pm line 206. Can you also check Jonathan's comment on batch checkouts please? Should we also be testing batch checkouts here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 23:04:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 22:04:45 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 --- Comment #5 from Katrin Fischer --- I am having these in the QA test tools: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/about.tt FAIL valid_template Attempt to reload Koha/Template/Plugin/Branches.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Plugins.pm line 206. OK koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc FAIL valid_template Attempt to reload Koha/Template/Plugin/AdditionalContents.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Plugins.pm line 206. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 23:05:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 22:05:53 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 --- Comment #6 from Katrin Fischer --- (In reply to Katrin Fischer from comment #5) > I am having these in the QA test tools: > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/about.tt > FAIL valid_template > Attempt to reload Koha/Template/Plugin/Branches.pm aborted. > Compilation failed in require at > /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Plugins.pm line 206. > > > > OK koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc > FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc > FAIL valid_template > Attempt to reload Koha/Template/Plugin/AdditionalContents.pm aborted. > Compilation failed in require at > /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Plugins.pm line 206. These appear unrelated to the patch, wondering if something is broken in master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 23:06:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 22:06:27 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #18 from Katrin Fischer --- Resetting status, looks like something is wrong with master or my dev setup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 23:14:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 22:14:53 +0000 Subject: [Koha-bugs] [Bug 9244] Authorities sorting should take subdivisions into account thanks to DOM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #8 from Katrin Fischer --- Thx Heather, super helpful! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 23:21:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 22:21:54 +0000 Subject: [Koha-bugs] [Bug 9244] Authorities sorting should take subdivisions into account thanks to DOM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9244 --- Comment #9 from Heather --- So glad I could help in some small way, Katrin! And so satisfying to have something from 2012 taken care of, especially something SO helpful to we catalogers!! ::happy dance:: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 7 23:25:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Feb 2022 22:25:32 +0000 Subject: [Koha-bugs] [Bug 9244] Authorities sorting should take subdivisions into account thanks to DOM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9244 --- Comment #10 from Katrin Fischer --- Closing one of the 4 digit bugs is always a treat for sure! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:22:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:22:06 +0000 Subject: [Koha-bugs] [Bug 26102] Javascript injection in intranet search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26102 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:25:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:25:26 +0000 Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:26:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:26:39 +0000 Subject: [Koha-bugs] [Bug 28735] Self-checkout users can access opac-user.pl for sco user when not using AutoSelfCheckID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28735 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:27:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:27:20 +0000 Subject: [Koha-bugs] [Bug 29540] Accounts with just 'catalogue' permission can modify/delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29540 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:35:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:35:30 +0000 Subject: [Koha-bugs] [Bug 29541] Patron images can be accessed with just 'catalogue' permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29541 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:36:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:36:28 +0000 Subject: [Koha-bugs] [Bug 29542] User with 'catalogue' permission can view everybody's (private) virtualshelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29542 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:36:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:36:53 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:36:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:36:58 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120425|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 130250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130250&action=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_host_item_entries in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - opac list - opac cart - opac send list email email - opac send cart email To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. confirm tests pass: t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:37:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:37:17 +0000 Subject: [Koha-bugs] [Bug 29544] A patron can set everybody's checkout notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29544 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:39:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:39:42 +0000 Subject: [Koha-bugs] [Bug 29903] Message deletion possible from different branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29903 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:40:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:40:43 +0000 Subject: [Koha-bugs] [Bug 29914] check_cookie_auth not strict enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29914 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:43:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:43:22 +0000 Subject: [Koha-bugs] [Bug 30041] New: Add MARC and Card preview to biblio search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30041 Bug ID: 30041 Summary: Add MARC and Card preview to biblio search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The cataloguing search (which searches both the catalogue and the reservoir) provides options for both a MARC preview and Card preview for each search result. These options would be useful to show on the normal biblio search results ('search the catalogue'). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:43:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:43:31 +0000 Subject: [Koha-bugs] [Bug 30041] Add MARC and Card preview to biblio search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30041 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:55:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:55:51 +0000 Subject: [Koha-bugs] [Bug 30041] Add MARC and Card preview to biblio search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30041 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 01:55:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 00:55:55 +0000 Subject: [Koha-bugs] [Bug 30041] Add MARC and Card preview to biblio search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30041 --- Comment #1 from Aleisha Amohia --- Created attachment 130251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130251&action=edit Bug 30041: Add MARC and Card preview to biblio search results This enhancement adds MARC preview and Card preview links to the normal catalogue search results. To test: 1) Do a catalogue search in the staff client (use the 'Search the catalogue' tab, do not do a search that searches both the catalogue and the reservoir). 2) Notice there is no quick way to view the MARC and Card previews for each search result. 3) Apply patch and refresh the search results page 4) Confirm there are now links for both the MARC and Card previews 5) Confirm these popups show details of the records as expected Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 02:53:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 01:53:55 +0000 Subject: [Koha-bugs] [Bug 30026] International Phone Number Not supported for SMSAlert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 --- Comment #6 from David Cook --- (In reply to Florian from comment #5) > It seems to me that forcing the addition of an exit code might cause a lot > more problems down the line 100% agreed. I think for many/most libraries, they'll never want to have exit codes included. I still don't see the utility of adding exit codes. It sounds like it's something you'd need for your plugin, but it seems to me that is something you could add via your plugin and doesn't need to be in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 07:13:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 06:13:18 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 --- Comment #10 from Andrew Nugged --- (In reply to Kyle M Hall from comment #6) > Pushed to 21.11.x for 21.11.02 Kyle, this post-publishing patch probably lost: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735#c8 from just-happened 21.11.03, so maybe to include it to 21.11.04? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 07:43:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 06:43:08 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #18 from Fridolin Somers --- Hi, - Relationship: + borrower_data.Relationship: Sure about this change (twice) ? It is a text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:03:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:03:49 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128978|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 130252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130252&action=edit Bug 29780: Add Koha::Old::Holds->anonymize This patch adds a handy method for anonymizing a Koha::Old::Holds resultset. It is planned to be used on bug 29526. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:03:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:03:53 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128979|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 130253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130253&action=edit Bug 29780: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:04:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:04:27 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- A simple and clear patch that works as expected and contains thorough unit tests. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:11:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:11:44 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129432|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize --- Created attachment 130254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130254&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:11:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:11:49 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129433|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize --- Created attachment 130255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130255&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev > UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY); 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:11:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:11:53 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129434|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 130256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130256&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:11:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:11:58 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129544|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 130257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130257&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required This patch makes cancelling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, cancelling a hold, noticing it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:12:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:12:02 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129545|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 130258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130258&action=edit Bug 29525: Make Koha::Hold->fill anonymize if required This patch makes filling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, notice it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:13:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:13:17 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #46 from Martin Renvoize --- All works as described, new methods work and are well tested and the QA scripts are happy. QA feedback is being addressed in a distinct bug to catch all cases. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:17:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:17:17 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129027|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 130259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130259&action=edit Bug 29526: Add a way for patrons to delete their hold history The same way we have a button to immediately delete the checkouts history in the OPAC, we should have a similar option for the holds history. This patch implements that. To test: 1. Have a patron with some old checkouts and old holds. 2. Have OPACPrivacy, OPACHoldsHistory and opacreadinghistory enabled. 3. Notice in the OPAC the patron has some old checkouts and holds. 4. Use the Privacy tab to clean checkouts => SUCCESS: They are still cleaned as before this patch 5. Try to clean the old holds => SUCCESS: They are cleaned! 6. Add some old checkouts and holds 7. Use the new 'All' button => SUCCESS: All cleaned 8. Sign off :-D Signed-off-by: Barbara Johnson Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:17:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:17:18 +0000 Subject: [Koha-bugs] [Bug 30026] International Phone Number Not supported for SMSAlert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 --- Comment #7 from Florian --- (In reply to David Cook from comment #6) > (In reply to Florian from comment #5) > > It seems to me that forcing the addition of an exit code might cause a lot > > more problems down the line > > 100% agreed. I think for many/most libraries, they'll never want to have > exit codes included. > > I still don't see the utility of adding exit codes. It sounds like it's > something you'd need for your plugin, but it seems to me that is something > you could add via your plugin and doesn't need to be in Koha. But it's already there in the code. The current version already supports vast majority of exit codes, this patch aims to make sure we support even more. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:17:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:17:21 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129028|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 130260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130260&action=edit Bug 29526: (follow-up) Put delete buttons in HTML table Signed-off-by: Barbara Johnson Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:17:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:17:24 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129029|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 130261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130261&action=edit Bug 29526: (follow-up) change wording on opac-holdshistory.tt when table is empty Signed-off-by: Barbara Johnson Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:18:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:18:00 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #16 from Martin Renvoize --- Great work, all works as expected. QA script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:19:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:19:01 +0000 Subject: [Koha-bugs] [Bug 30036] Add xslt for authority results normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:20:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:20:33 +0000 Subject: [Koha-bugs] [Bug 28584] Remove hyphens from EAN when adding a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:29:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:29:55 +0000 Subject: [Koha-bugs] [Bug 28584] Remove hyphens from EAN when adding a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 --- Comment #5 from e.betemps --- I'm sorry but I tested once again today and it doesn't work. The first test I did was on February the 4th, at noon. - when I ran the sandbox, Kyle M Hall's comment wasn't here - when I signed-off, I saw his comment I don't know what patch I used for my first test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:34:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:34:25 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29525 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:34:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:34:25 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29843 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:51:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:51:36 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:53:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:53:13 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #12 from Jonathan Druart --- Tomas, shouldn't we deal with all biblioitem's attributes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:54:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:54:19 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #13 from Jonathan Druart --- Comment on attachment 130126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130126 Bug 29570: Fix sorting orders by biblioitems columns Review of attachment 130126: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29570&attachment=130126) ----------------------------------------------------------------- ::: Koha/REST/V1/Acquisitions/Orders.pm @@ +76,5 @@ > } > > + if ( exists $reserved_params->{_order_by} ) { > + # _order_by passed, fix if required > + for ( my $i = 0; $i < scalar @{$reserved_params->{_order_by}}; $i++ ) { You could write it in perl instead of javascript ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 09:57:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 08:57:05 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #19 from Katrin Fischer --- (In reply to Fridolin Somers from comment #18) > Hi, > - Relationship: > + borrower_data.Relationship: > > Sure about this change (twice) ? > It is a text. Good catch Frido :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:11:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:11:19 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:11:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:11:23 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128580|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 130262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130262&action=edit Bug 29706: Improve table elements This patch add a thead and tbody element to the 'copiesrow' table Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:11:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:11:27 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129196|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 130263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130263&action=edit Bug 29706: Hide items that cannot be held by default when placing hold on OPAC This patch adds a 'holdable' and 'unholdable' class to the rows of the table Additionally I rename the 'backgroundcolor' field to 'onloan' as that is what it contains. Note: Out of the box, there is no css associated with this class I add a div around the table to allow hiding the new buttons as well when optiuons are hidden It would be nice in the future to utilise a Koha table here, however, it is complicated by multi-holds To test: 1 - Add a number of items to a record, ensuring they belong to different libraries 2 - Set 'Default checkout, hold and return policy'->'Hold policy' to 'From home library' 3 - Sign in to opac and attempt to placehold on the record 4 - Click 'show more options' and 'a specificitem' 5 - Note holds table includes items that cannot be held 6 - Apply patch 7 - Reload holds page 8 - Note items that cannot be heldare hidden 9 - Click 'Show unholdable items' and note they appear 10 - Click 'Hide unholdable items' and veriofy they hide 11 - Test with multi holds Signed-off-by: The Minh Luong Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:12:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:12:34 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart --- I would have put the button at the top of the table, but not considering blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:14:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:14:45 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Jonathan Druart --- It actually does not work for multi holds, the button will show/hide the items for the other biblios as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:39:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:39:56 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #7 from Jonathan Druart --- I am expecting sco print slip to be broken, 'enquire' won't be defined in global.js when included from sco/printslip.tt. But the print slip feature is broken in master right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:39:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:39:57 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129492|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 130264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130264&action=edit Bug 29843: Unit tests This patch adds unit tests for the introduced methods. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:40:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:40:01 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129493|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 130265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130265&action=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:40:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:40:06 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129494|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 130266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130266&action=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:40:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:40:11 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129495|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 130267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130267&action=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:40:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:40:15 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129496|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize --- Created attachment 130268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130268&action=edit Bug 29843: Use in tools/cleanborrowers.pl This patch makes tools/cleanborrowers.pl use the new methods. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:42:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:42:07 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #38 from Martin Renvoize --- This is a nice improvement, I like the pattern here. All works well, QA script is happy, and tests coverage is high. This did get me looking at the cron script, it would be good to add the standard --confirm to this script at some point.. and if possible it would be great to drop the Date::Calc module at some point. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:42:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:42:17 +0000 Subject: [Koha-bugs] [Bug 28584] Remove hyphens from EAN when adding a new record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28584 --- Comment #6 from Emmi Takkinen --- (In reply to e.betemps from comment #5) > I'm sorry but I tested once again today and it doesn't work. Could you describe in more detail how this doesn't work? Tested this on my test environment, hyphens are removed from biblioitems but not from MARC and test pass. So in my end, everything works as expected. > The first test I did was on February the 4th, at noon. > - when I ran the sandbox, Kyle M Hall's comment wasn't here > - when I signed-off, I saw his comment > > I don't know what patch I used for my first test. You probably used first patch provided here (id 122059, one without sign-off), but it seems Kyle somehow hijacked your sign-off :D I'm unsure how sandbox testing works, so no idea how this is possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:47:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:47:27 +0000 Subject: [Koha-bugs] [Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 --- Comment #6 from Martin Renvoize --- Created attachment 130269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130269&action=edit Bug 30007: Regression tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:47:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:47:31 +0000 Subject: [Koha-bugs] [Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 --- Comment #7 from Martin Renvoize --- Created attachment 130270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130270&action=edit Bug 30007: Add Koha::Exceptions::SysPref Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:47:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:47:34 +0000 Subject: [Koha-bugs] [Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 --- Comment #8 from Martin Renvoize --- Created attachment 130271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130271&action=edit Bug 30007: Make ->anonymize methods throw an exception if AnonymousPatron is not set This patch makes the ->anonymize methods throw a Koha::Exceptions::SysPref::NotSet exception when trying to anonymize holds and checkouts without AnonymousPatron properly set. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t \ t/db_dependent/Koha/Old/Holds.t \ t/db_dependent/Koha/Old/Hold.t => FAIL: Tests fail, no exception thrown 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:48:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:48:16 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130175|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 130272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130272&action=edit Bug 30007: Regression tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=3007 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:48:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:48:19 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130176|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 130273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130273&action=edit Bug 30007: Add Koha::Exceptions::SysPref Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=3007 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:48:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:48:24 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130177|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 130274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130274&action=edit Bug 30007: Make ->anonymize methods throw an exception if AnonymousPatron is not set This patch makes the ->anonymize methods throw a Koha::Exceptions::SysPref::NotSet exception when trying to anonymize holds and checkouts without AnonymousPatron properly set. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t \ t/db_dependent/Koha/Old/Holds.t \ t/db_dependent/Koha/Old/Hold.t => FAIL: Tests fail, no exception thrown 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=3007 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:48:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:48:34 +0000 Subject: [Koha-bugs] [Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #130269|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:48:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:48:42 +0000 Subject: [Koha-bugs] [Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130270|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:48:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:48:51 +0000 Subject: [Koha-bugs] [Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130271|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:49:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:49:12 +0000 Subject: [Koha-bugs] [Bug 3007] Translate UNIMARC value builders macles and unimarc_field_700-4 into English for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3007 --- Comment #9 from Martin Renvoize --- Oops. wrong bug! Obsoleted patches -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:49:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:49:41 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- Solid improvement, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:52:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:52:38 +0000 Subject: [Koha-bugs] [Bug 29984] Remove unused method Koha::Patrons->anonymise_issue_history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29984 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130174|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 130275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130275&action=edit Bug 29984: Remove unused method Koha::Patrons->anonymise_issue_history The method is no longer used, and replaced by Koha::Old::Checkouts->anonymize. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests still pass 3. Run: $ git grep anonymise_issue_history => SUCCESS: The code doesn't mention it 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:53:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:53:10 +0000 Subject: [Koha-bugs] [Bug 29984] Remove unused method Koha::Patrons->anonymise_issue_history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29984 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- As described.. passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:56:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:56:21 +0000 Subject: [Koha-bugs] [Bug 29914] check_cookie_auth not strict enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29914 --- Comment #51 from Jonathan Druart --- We broke SCO completely here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:58:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:58:00 +0000 Subject: [Koha-bugs] [Bug 29914] check_cookie_auth not strict enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29914 --- Comment #52 from Jonathan Druart --- (In reply to Jonathan Druart from comment #51) > We broke SCO completely here. * print slip is broken * whole SCO is broken if AutoSelfCheckAllowed = don't allow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 10:59:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 09:59:42 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130235|0 |1 is obsolete| | --- Comment #7 from Jérémy Breuillard --- Created attachment 130276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130276&action=edit Bug 21330: Add xslt for authority normal view in OPAC This patch provides a xslt stylesheet on authority normal view in OPAC. Have a look on opac-authoritiesdetail.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Click details on a result and notice the view 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacDetailsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the display This is a similar bug: Bug 30036 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:00:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:00:51 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130178|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 130277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130277&action=edit Bug 30023: Add Koha::Old::Checkout->anonymize This patch adds the mentioned method. It replicates the Koha::Old::Hold behavior, including the exception thrown on bad configuration. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkout.t => SUCCESS: Test pass 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:00:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:00:54 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130179|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 130278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130278&action=edit Bug 30023: Make MarkIssueReturned use ->anonymize Koha::Old::Checkout->anonymize takes care of checking the syspref and raises an exception if not set. So no we can now leverage on it, instead of checking manually and then tweaking the checkout object manually as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:01:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:01:48 +0000 Subject: [Koha-bugs] [Bug 21330] Add xslt for authority normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Jérémy Breuillard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:02:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:02:09 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- All works as designed and clarifies the code. Tested, and QA scripts happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:14:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:14:29 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #39 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #38) > This did get me looking at the cron script, it would be good to add the > standard --confirm to this script at some point.. and if possible it would > be great to drop the Date::Calc module at some point. Yeah, saw that. It is mostly used for displaying purposes. Can do on another report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:15:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:15:03 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:17:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:17:59 +0000 Subject: [Koha-bugs] [Bug 30042] New: Remove Date::Calc use in cleanborrowers.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Bug ID: 30042 Summary: Remove Date::Calc use in cleanborrowers.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:18:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:18:11 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use in cleanborrowers.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29843 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:18:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:18:11 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30042 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 [Bug 30042] Remove Date::Calc use in cleanborrowers.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:28:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:28:08 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #12) > Tomas, shouldn't we deal with all biblioitem's attributes? It is your fault :P https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115963 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:33:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:33:32 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #15 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #14) > (In reply to Jonathan Druart from comment #12) > > Tomas, shouldn't we deal with all biblioitem's attributes? > > It is your fault :P > > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115963 Yes, do it like that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:46:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:46:16 +0000 Subject: [Koha-bugs] [Bug 30043] New: Malformed records shown as not existing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30043 Bug ID: 30043 Summary: Malformed records shown as not existing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org I just had a case where a batch MARC import script (not part of Koha, but maintained separately) had put some records with an empty 942 field into the database. The MARCXML looked something like this: x y When trying to view these records, the following message was displayed: The record you requested does not exist But all the data were in the biblio, biblioitems, biblio_metadata tables. It was not possible to view the the record in the editor either. Would it be possible to catch this error and say something like "The record you requested has fatal errors" instead of telling the user it does not exist? Relevant code in catalogue/detail.pl: 78 my $record = GetMarcBiblio({ biblionumber => $biblionumber }); 79 my $biblio = Koha::Biblios->find( $biblionumber ); 80 $template->param( 'biblio', $biblio ); 81 82 if ( not defined $record ) { 83 # biblionumber invalid -> report and exit 84 $template->param( unknownbiblionumber => 1, 85 biblionumber => $biblionumber ); 86 output_html_with_http_headers $query, $cookie, $template->output; 87 exit; 88 } This reports unknownbiblionumber => 1 when $record is not defined, but it does not differentiate between "biblionumber does not exist" and "biblionumber points to a broken MARCXML record". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 11:47:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 10:47:53 +0000 Subject: [Koha-bugs] [Bug 30043] Malformed records shown as not existing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30043 --- Comment #1 from Magnus Enger --- SQL to find and fix records with an empty 942 field: SELECT biblionumber, timestamp, ExtractValue( metadata, 'count( //datafield[@tag="942"] )' ) AS count_fields, ExtractValue( metadata, 'count( //datafield[@tag="942"]/* )' ) AS count_subfields FROM biblio_metadata HAVING count_fields > 0 AND count_subfields = 0; UPDATE biblio_metadata SET metadata = UpdateXML( metadata, '//datafield[@tag="942"]', '' ) WHERE biblionumber IN ( x,y,z ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:09:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:09:03 +0000 Subject: [Koha-bugs] [Bug 30044] New: Z39.50/SRU search button broken by update to 19.11.25 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 Bug ID: 30044 Summary: Z39.50/SRU search button broken by update to 19.11.25 Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: alexander.borkowski at kau.se QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl After updating to 19.11.25 the Z39.50 search button in the catalogue search results page (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt) does no longer work. I think that this is because versions 20.05 and up contain the changes made in bug #23885, while 19.11 does not and the backport to 19.11 for #26102 does not take this into account and removes too much code from koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt. Steps to reproduce: 1. Click on "Search the catalogue" 2. Enter a search term that will give no results 3. Click on the button labeled "Submit" 4. On the page without results that comes up, click on the button labeled "Z39.50/SRU search" 5. Note that nothing happens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:11:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:11:47 +0000 Subject: [Koha-bugs] [Bug 30045] New: SCO print slip is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 Bug ID: 30045 Summary: SCO print slip is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: OPAC Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 29543, 29914 Certainly since bug 29543 and bug 29914. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 [Bug 29543] Self-checkout allows returning everybody's loans https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29914 [Bug 29914] check_cookie_auth not strict enough -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:11:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:11:47 +0000 Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 [Bug 30045] SCO print slip is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:11:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:11:47 +0000 Subject: [Koha-bugs] [Bug 29914] check_cookie_auth not strict enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29914 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 [Bug 30045] SCO print slip is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:12:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:12:14 +0000 Subject: [Koha-bugs] [Bug 29914] check_cookie_auth not strict enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29914 --- Comment #53 from Jonathan Druart --- (In reply to Jonathan Druart from comment #52) > (In reply to Jonathan Druart from comment #51) > > We broke SCO completely here. > > * print slip is broken > * whole SCO is broken if AutoSelfCheckAllowed = don't allow Only print slip is broken actually, see bug 30045. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:14:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:14:53 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:14:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:14:57 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 --- Comment #1 from Jonathan Druart --- Created attachment 130279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130279&action=edit Bug 30045: (bug 29543 follow-up) Fix SCO print slip Certainly since bug 29543 and bug 29914. We should do the same authentication check than sco-main.pl, and also make sure to generate the checkout history only for the logged in patron (the OPAC one, not staff member) Test plan: Use the different combinations of the SCO config (AutoSelfCheckAllowed, SelfCheckoutByLogin and WebBasedSelfCheck) and confirm that this patch fixes the SCO print slip feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:22:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:22:37 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30045 Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart --- (In reply to Jonathan Druart from comment #7) > I am expecting sco print slip to be broken, 'enquire' won't be defined in > global.js when included from sco/printslip.tt. > But the print slip feature is broken in master right now. Confirmed, "Uncaught ReferenceError: enquire is not defined". Tested on top of bug 30045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 [Bug 30045] SCO print slip is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:22:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:22:37 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 [Bug 29960] Remove Modernizr dependency in the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:51:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:51:44 +0000 Subject: [Koha-bugs] [Bug 15786] specify a default framework on a per-login basis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15786 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:51:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:51:53 +0000 Subject: [Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:57:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:57:01 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #2 from Jake Deery --- Created attachment 130280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130280&action=edit Applied a fix to stop point-of-sale items being added twice to till transaction lists -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:58:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:58:58 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:59:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:59:08 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28163 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 12:59:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 11:59:08 +0000 Subject: [Koha-bugs] [Bug 28163] Register entries doubled up if form is submitted first without a selected register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28163 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30003 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 13:26:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 12:26:20 +0000 Subject: [Koha-bugs] [Bug 29914] check_cookie_auth not strict enough In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29914 --- Comment #54 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #51) > We broke SCO completely here. 29543 is in the game too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 13:30:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 12:30:44 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 13:30:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 12:30:48 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 --- Comment #8 from Nick Clemens --- Created attachment 130281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130281&action=edit Bug 29706: (follow-up) Adjust code to work for multi-holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 13:39:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 12:39:39 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 13:39:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 12:39:42 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130279|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 130282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130282&action=edit Bug 30045: (bug 29543 follow-up) Fix SCO print slip Certainly since bug 29543 and bug 29914. We should do the same authentication check than sco-main.pl, and also make sure to generate the checkout history only for the logged in patron (the OPAC one, not staff member) Test plan: Use the different combinations of the SCO config (AutoSelfCheckAllowed, SelfCheckoutByLogin and WebBasedSelfCheck) and confirm that this patch fixes the SCO print slip feature. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 13:43:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 12:43:08 +0000 Subject: [Koha-bugs] [Bug 30046] New: GetPatronInfo doesn't return the category description Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30046 Bug ID: 30046 Summary: GetPatronInfo doesn't return the category description Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: arthur.suzuki at biblibre.com QA Contact: testopia at bugs.koha-community.org Although the documentation contains a field "description" which should show the borrower category label, this field is not present in the result. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 13:44:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 12:44:44 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 13:44:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 12:44:54 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 --- Comment #3 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 14:29:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 13:29:20 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112956|0 |1 is obsolete| | Attachment #112957|0 |1 is obsolete| | Attachment #112958|0 |1 is obsolete| | Attachment #112959|0 |1 is obsolete| | --- Comment #85 from The Minh Luong --- Created attachment 130283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130283&action=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 14:29:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 13:29:26 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #86 from The Minh Luong --- Created attachment 130284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130284&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 14:29:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 13:29:31 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #87 from The Minh Luong --- Created attachment 130285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130285&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 14:29:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 13:29:36 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #88 from The Minh Luong --- Created attachment 130286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130286&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails :
$ prove -l t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. 1/3
    #   Failed test 'This list comes from the cache and that is fine'
    #   at t/db_dependent/XSLT.t line 122.
    #          got: '1'
    #     expected: '2'
    # Looks like you failed 1 test of 1.

 #   Failed test 'CustomXSLTExportList: Caching'
 #   at t/db_dependent/XSLT.t line 124.
 # Looks like you failed 1 test of 3.
t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
-------------------
t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
csys =  1.91 CPU)
Result: FAIL
This one works fine :
$ prove -l t/XSLT.t
t/XSLT.t .. ok
All tests successful.
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
csys =  2.74 CPU)
Result: PASS
-- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 14:29:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 13:29:42 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #89 from The Minh Luong --- Created attachment 130287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130287&action=edit Bug 17385: Add custum export format option when saving a record This patch adds "XSL-Simple Export" when saving a bibliographic record. Previous patches are combined into this one. To test: 1) Search for a record in the intranet. 2) Click on the "Save" button and observe the dropdown menu. 3) Notice that "XSL- Simple Export" is not in the menu. 4) Apply the patch. 5) Repeat the steps 1 and 2. 6) Notice that "XSL - Simple Export" is in the menu. 7) Click on "XSL - Simple Export". A .html file should be downloaded. 8) Open the .html file. You should see the record's informations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 14:30:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 13:30:39 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |the-minh.luong at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 14:35:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 13:35:17 +0000 Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 --- Comment #50 from Marcel de Rooy --- Question when looking in sco-main my $jwt = $query->cookie('JWT'); if ($op eq "logout") { $template->param( loggedout => 1 ); $query->param( patronlogin => undef, patronpw => undef ); undef $jwt; } Shouldnt we do some cleaning up here and just exit ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 14:37:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 13:37:16 +0000 Subject: [Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #39 from Frank Hansen --- (In reply to David Gustafsson from comment #37) > Created attachment 127980 [details] [review] > Bug 25539: Remove AddBiblio option "defer_marc_save" > > 2) Enable MARC overlay rules and add a rule (with source => "*" or > 'bulkmarcimport') to protect some field. Hi David. It is not possible to configure bulkmarcimport as source filter in home->administration->Marc overlay rules because bulkmarcimport.pl is commented out in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt template. Is it commented out by intention? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 14:37:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 13:37:32 +0000 Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 --- Comment #51 from Marcel de Rooy --- Hmm. Why are we doing this in sco-main: L47 my ( $template, $loggedinuser, $cookie ) = get_template_and_user( So the CGISESSID cookie is used here and we check permissions. L371 $cookie = $query->cookie( -name => 'JWT', We create a new cookie JWT. But ignore the session cookie. L381 output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 }; We output now without the CGISESSID, only JWT. Why dont you pass the session cookie? You could pass something like [ $cookie1, $cookie2 ] ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 14:39:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 13:39:31 +0000 Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 --- Comment #52 from Marcel de Rooy --- L362 csrf_token => Koha::Token->new->generate_csrf( { session_id => scalar $query->cookie('CGISESSID') . $patron->cardnumber, id => $patron->userid } ), Where is the corresponding csrf check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:21:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:21:23 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #13) > Comment on attachment 130126 [details] [review] > Bug 29570: Fix sorting orders by biblioitems columns > > Review of attachment 130126 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/REST/V1/Acquisitions/Orders.pm > @@ +76,5 @@ > > } > > > > + if ( exists $reserved_params->{_order_by} ) { > > + # _order_by passed, fix if required > > + for ( my $i = 0; $i < scalar @{$reserved_params->{_order_by}}; $i++ ) { > > You could write it in perl instead of javascript ;) This is more C-ish -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:36:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:36:02 +0000 Subject: [Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes at ub.lu.se --- Comment #4 from Kevin Carnes --- Since it's not necessary to use the type name in Elasticsearch 7, it's possible to use data as the type name in Elasticsearch 6, upgrade to Elasticsearch 7, and then no longer use the type name. It would be possible to check if a new index is being created and then use _doc for the type name, but it could complicate things if the indexes had different type names and it was necessary to check which type name they had before using them. One can always recreate the indexes in Elasticsearch 7 if desired. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:38:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:38:41 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 --- Comment #1 from Katrin Fischer --- Just came up again as a question in training - would still be a nice addition :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:40:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:40:20 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 --- Comment #1 from Kevin Carnes --- Created attachment 130288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130288&action=edit Bug 25669: ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) Starting with version 7.0 of Elasticsearch type names should not be used and in version 6.8 there is a warning if you don't use include_type_name when using put_mapping (requires Search::Elasticsearch at 6.8). To test: 1) Reindex records with koha-elasticsearch or rebuild_elasticsearch.pl 2) Observe any deprecation warnings or errors 3) Apply patch 4) Install Search::Elasticsearch with the same version as Elasticsearch 5) Reindex records with koha-elasticsearch or rebuild_elasticsearch.pl 6) Observe no warning or errors 7) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:42:14 +0000 Subject: [Koha-bugs] [Bug 25684] ElasticSearch 7 start crash: at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25684 --- Comment #3 from Kevin Carnes --- Created attachment 130289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130289&action=edit Bug 25684: ElasticSearch 7 start crash: at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured With Elasticsearch 7 it is necessary to specify if using a single node To test: 1) run ku-es7 2) Observe that Elasticsearch stops with an error 3) Apply patch 4) run ku-es7 5) Observe that Elasticsearch starts successfully 6) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:43:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:43:26 +0000 Subject: [Koha-bugs] [Bug 27770] ES: Deprecated aggregation order key [_term] used, replaced by [_key] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #1 from Kevin Carnes --- Created attachment 130290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130290&action=edit Bug 27770: ES: Deprecated aggregation order key [_term] used, replaced by [_key] Starting in Elasticsearch 6.0 _key should be used instead of _term to order buckets by their term To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) If you observe an error about types, apply patch for bug 25669 3) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4) Observe if you get a deprecation warning about order key 5) Apply patch 6) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 7) Observe no deprecation warning about order key 8) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:45:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:45:09 +0000 Subject: [Koha-bugs] [Bug 27771] ES: The parameter include_type_name should be explicitly specified in put mapping requests to prepare for 7.0. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27771 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes at ub.lu.se --- Comment #1 from Kevin Carnes --- Is this a duplicate of bug 25669? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:45:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:45:11 +0000 Subject: [Koha-bugs] [Bug 29791] KohaOpacLanguage cookie should set the secure flag if using https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:45:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:45:58 +0000 Subject: [Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 --- Comment #1 from Kevin Carnes --- Created attachment 130291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130291&action=edit Bug 28610: Elasticsearch 7 - hits.total is now an object In Elasticsearch 7 hits.total is now an object which is not always an exact value. You can always get an exact total by adding a track_total_hits parameter set to true when using the Elasticsearch search method To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) If you observe an error about types, apply patch for bug 25669 3) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4) Observe that tests with count fail 5) Apply patch 6) Observe that tests with count pass 7) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:48:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:48:22 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes at ub.lu.se --- Comment #2 from Kevin Carnes --- This is a possible solution. The version checking can be made cleaner or there can be a configuration to specify which version of Elasticsearch is being used. It's also important to have the correct version of Search::Elasticsearch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:51:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:51:24 +0000 Subject: [Koha-bugs] [Bug 27770] ES: Deprecated aggregation order key [_term] used, replaced by [_key] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes at ub.lu.se --- Comment #2 from Kevin Carnes --- This solution includes a check for versions prior to Elasticsearch 6. I don't know if there are any plans to drop support for Elasticsearch 5. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:51:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:51:55 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:51:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:51:59 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130282|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 130292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130292&action=edit Bug 30045: (bug 29543 follow-up) Fix SCO print slip Certainly since bug 29543 and bug 29914. We should do the same authentication check than sco-main.pl, and also make sure to generate the checkout history only for the logged in patron (the OPAC one, not staff member) Test plan: Use the different combinations of the SCO config (AutoSelfCheckAllowed, SelfCheckoutByLogin and WebBasedSelfCheck) and confirm that this patch fixes the SCO print slip feature. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:53:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:53:04 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:53:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:53:34 +0000 Subject: [Koha-bugs] [Bug 25684] ElasticSearch 7 start crash: at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25684 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:53:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:53:49 +0000 Subject: [Koha-bugs] [Bug 27770] ES: Deprecated aggregation order key [_term] used, replaced by [_key] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:54:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:54:05 +0000 Subject: [Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:54:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:54:57 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 --- Comment #5 from Marcel de Rooy --- The code in sco-main and printslip does not really convince me, but it seems to work. Passing QA to allow for a quick fix. Posted comments too on 29543. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 15:55:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 14:55:58 +0000 Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 --- Comment #53 from Marcel de Rooy --- Iiuc JWT is not encrypted. So this may be a bit more secure, but could be improved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:19:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:19:13 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130288|0 |1 is obsolete| | --- Comment #3 from Kevin Carnes --- Created attachment 130293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130293&action=edit Bug 25669: ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) Starting with version 7.0 of Elasticsearch type names should not be used and in version 6.8 there is a warning if you don't use include_type_name when using put_mapping (requires Search::Elasticsearch at 6.8). To test: 1) Reindex records with koha-elasticsearch or rebuild_elasticsearch.pl 2) Observe any deprecation warnings or errors 3) Apply patch 4) Install Search::Elasticsearch with the same version as Elasticsearch 5) Reindex records with koha-elasticsearch or rebuild_elasticsearch.pl 6) Observe no warning or errors 7) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:24:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:24:35 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129709|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 130294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130294&action=edit Bug 29886: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:24:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:24:40 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129710|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 130295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130295&action=edit Bug 29886: Add Koha::Suggestions->search_limited Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:24:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:24:44 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 --- Comment #13 from Martin Renvoize --- Created attachment 130296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130296&action=edit Bug 29886: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:24:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:24:59 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130296|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:25:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:25:17 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 --- Comment #14 from Martin Renvoize --- Oops, didn't mean to upload that last one.. deprecating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:26:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:26:10 +0000 Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 --- Comment #54 from Marcel de Rooy --- $cookie = $query->cookie( -name => 'JWT', -value => $jwt // '', -expires => $jwt ? '+1d' : '', Expiry should be shorter and in line with the expiry for sco. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:26:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:26:15 +0000 Subject: [Koha-bugs] [Bug 30047] New: Add a field to auth_header to record main heading as text string Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30047 Bug ID: 30047 Summary: Add a field to auth_header to record main heading as text string Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org SQL queries looking at authority records are complicated by the fact that authorities don't have an equivalent to a biblio's title. It would be helpful to create a new database field (auth_header.main_heading) in which we record a text string. The specific value we record here would be determined by the authority type, following the mappings defined in authtypes.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:27:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:27:41 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize --- Right.. I decided to PQA this as it stands. It makes sense that we limit only by IndependantBranches, though I'd love to see it moved to utilise the library groups feature in the future. As for the different style of search_limited, it also makes sense here.. we're limiting the object by it's branch and the current users permission to see that branch.. it has nothing to do with the patrons attached to the suggestion (that should be getting handled at another level) I will open a bug to discuss how I believe the same method in ArticleRequests is wrong on this matter. So.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:27:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:27:46 +0000 Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 --- Comment #55 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #50) > Question when looking in sco-main > > my $jwt = $query->cookie('JWT'); > if ($op eq "logout") { > $template->param( loggedout => 1 ); > $query->param( patronlogin => undef, patronpw => undef ); > undef $jwt; > } > > Shouldnt we do some cleaning up here and just exit ? exit and what? Here we are going to display the login form, that's the expected behaviour (In reply to Marcel de Rooy from comment #51) > Hmm. Why are we doing this in sco-main: > > L47 > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > So the CGISESSID cookie is used here and we check permissions. We check authentication for the staff member (who has logged in, or the credential from the sysprefs) > L371 > $cookie = $query->cookie( -name => 'JWT', > We create a new cookie JWT. But ignore the session cookie. The JWT is used to authorised the OPAC user that has been authenticate in the previous step (cardnumber or login+password, depending on SelfCheckoutByLogin. > L381 > output_html_with_http_headers $query, $cookie, $template->output, undef, { > force_no_caching => 1 }; > We output now without the CGISESSID, only JWT. > Why dont you pass the session cookie? > You could pass something like [ $cookie1, $cookie2 ] ? I think CGISESSID is in the CGI object already. (In reply to Marcel de Rooy from comment #52) > L362 > csrf_token => Koha::Token->new->generate_csrf( { > session_id => scalar $query->cookie('CGISESSID') . $patron->cardnumber, id > => $patron->userid } ), > > Where is the corresponding csrf check? in sco-patron-image.pl (In reply to Marcel de Rooy from comment #53) > Iiuc JWT is not encrypted. So this may be a bit more secure, but could be > improved. It is encoded using a secret, see Koha::Token::_gen_jwt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:29:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:29:11 +0000 Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 --- Comment #56 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #54) > $cookie = $query->cookie( > -name => 'JWT', > -value => $jwt // '', > -expires => $jwt ? '+1d' : '', > > Expiry should be shorter and in line with the expiry for sco. Yes, correct. That could be shorter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:31:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:31:45 +0000 Subject: [Koha-bugs] [Bug 30048] New: Koha::ArticleRequests->search_limited may be malformed. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30048 Bug ID: 30048 Summary: Koha::ArticleRequests->search_limited may be malformed. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Whilst digging through Koha::Suggestions with bug 29886 it highlighted to me that our 'search_limited' method differs somewhat between different Koha classes. My initial understanding, from Koha::Patrons->search_limited, was that the idea of search_limited was to protect patron data across branches. In actual fact, it's more about restricting the object class in questions data from being leaked across branches. As such, I think the construction used in ArticleRequests is incorrect. Instead of limiting based on the requesting patrons attached to the requests the currently logged in patron can see.. we should be limiting simply by which libraries the current patron is allowed to see... and the linked patron details should be getting obfuscated in their own right. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:32:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:32:28 +0000 Subject: [Koha-bugs] [Bug 30048] Koha::ArticleRequests->search_limited may be malformed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30048 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29886 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:32:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:32:28 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30048 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:32:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:32:40 +0000 Subject: [Koha-bugs] [Bug 30048] Koha::ArticleRequests->search_limited may be malformed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30048 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29888 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:32:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:32:40 +0000 Subject: [Koha-bugs] [Bug 29888] ->search_limited logic breaks searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29888 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30048 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:34:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:34:11 +0000 Subject: [Koha-bugs] [Bug 30048] Koha::ArticleRequests->search_limited may be malformed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30048 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30019 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:34:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:34:11 +0000 Subject: [Koha-bugs] [Bug 30019] We should DRY out search_limited (and rename it) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30019 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30048 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:35:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:35:05 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:35:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:35:05 +0000 Subject: [Koha-bugs] [Bug 30019] We should DRY out search_limited (and rename it) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30019 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29523 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:35:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:35:07 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 --- Comment #4 from Kevin Carnes --- Should I create a new bug to remove support for multiple types when using mappings in Elasticsearch? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:37:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:37:55 +0000 Subject: [Koha-bugs] [Bug 30048] Koha::ArticleRequests->search_limited may be malformed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30048 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:50:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:50:10 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:50:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:50:15 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130262|0 |1 is obsolete| | Attachment #130263|0 |1 is obsolete| | Attachment #130281|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 130297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130297&action=edit Bug 29706: Improve table elements This patch add a thead and tbody element to the 'copiesrow' table Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:50:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:50:19 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 --- Comment #10 from Jonathan Druart --- Created attachment 130298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130298&action=edit Bug 29706: Hide items that cannot be held by default when placing hold on OPAC This patch adds a 'holdable' and 'unholdable' class to the rows of the table Additionally I rename the 'backgroundcolor' field to 'onloan' as that is what it contains. Note: Out of the box, there is no css associated with this class I add a div around the table to allow hiding the new buttons as well when optiuons are hidden It would be nice in the future to utilise a Koha table here, however, it is complicated by multi-holds To test: 1 - Add a number of items to a record, ensuring they belong to different libraries 2 - Set 'Default checkout, hold and return policy'->'Hold policy' to 'From home library' 3 - Sign in to opac and attempt to placehold on the record 4 - Click 'show more options' and 'a specificitem' 5 - Note holds table includes items that cannot be held 6 - Apply patch 7 - Reload holds page 8 - Note items that cannot be heldare hidden 9 - Click 'Show unholdable items' and note they appear 10 - Click 'Hide unholdable items' and veriofy they hide 11 - Test with multi holds Signed-off-by: The Minh Luong Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:50:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:50:23 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 --- Comment #11 from Jonathan Druart --- Created attachment 130299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130299&action=edit Bug 29706: (follow-up) Adjust code to work for multi-holds Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:52:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:52:52 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130168|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 130300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130300&action=edit Bug 27424: Update schema file Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:52:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:52:56 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130169|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 130301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130301&action=edit Bug 27424: Add ability to specify an SMTP server in the database as the default server Bug 22343 adds the ability to defined SMTP servers via the UI; But to then utilise them you have to go to each individual library via the libraries admin area and select the SMTP server. We should have a way to override the fallback/default SMTP server right from the SMTP servers administration page.. setting one of our defined SMTP Servers as the system default rather than using the hard coded fallback options. Test Plan: 1) Apply this patch set 2) Restart all the things! 3) Browser to the SMTP servers editor, verify only one server can be set as the default server 4) Set a default server, verify that server was used to send email from a cronjob, AND/OR prove t/db_dependent/Koha/SMTP/Server.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:52:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:52:59 +0000 Subject: [Koha-bugs] [Bug 29543] Self-checkout allows returning everybody's loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 --- Comment #57 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #55) > (In reply to Marcel de Rooy from comment #50) > > Why dont you pass the session cookie? > > You could pass something like [ $cookie1, $cookie2 ] ? > > I think CGISESSID is in the CGI object already. Cookies need to be sent out. If they have changed, they will only be updated at client side when you sent them explicitly to the output subs. output_html_with_http_headers and friends actually assume that it is the authentication cookie; so you are cheating here. > (In reply to Marcel de Rooy from comment #53) > > Iiuc JWT is not encrypted. So this may be a bit more secure, but could be > > improved. > > It is encoded using a secret, see Koha::Token::_gen_jwt OK. It is bit hidden but I found it in the _default_params sub. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:53:01 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130170|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 130302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130302&action=edit Bug 27424: Update database Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:53:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:53:06 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130171|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 130303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130303&action=edit Bug 27424: (QA follow-up) Make Koha::SMTP::Server->store deal with defaults This patch makes the ->store method take care of setting the server as the only default one. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/SMTP/Server.t => SUCCESS: Tests pass! 3. The UI keeps working as it should. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:53:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:53:10 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130172|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 130304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130304&action=edit Bug 27424: Clarify logic This patch simplifies how Koha::SMTP::Servers->get_default is written, to help readability. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:53:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:53:49 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Martin Renvoize --- Nice one! Works as described, code is good and covered by tests.. QA script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:53:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:53:57 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:59:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:59:20 +0000 Subject: [Koha-bugs] [Bug 29966] SCO Help page passes flags while not needing authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29966 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129921|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 130305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130305&action=edit Bug 29966: Dont pass authnotrequired true and flags together Test plan: Logout in OPAC. Goto sco help page. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 16:59:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 15:59:38 +0000 Subject: [Koha-bugs] [Bug 29966] SCO Help page passes flags while not needing authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29966 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Trivial patch, no breakage, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:05:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:05:57 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130088|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 130306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130306&action=edit Bug 28576: Add patron image in patron detail section does not specify image size limit When you try to add an image to a patron in Home/Patrons/anyPatron, it only states the file types that are supported but not the maximum size. If you try to add an image that is bigger than 500 kb, nothing happens and the reason is not presented. This is not the case with the 2 other places where we can add patron images in which they give warnings: Home/Tools/Upload patron images Home/Tools/Patron card creator/Images For now, i simply added the size limit to the file supported message. To test: 1)Search for any patron and go to his page 2)Hover over the image area on the left and click on add 3)Notice the message above the choose file button only specifies file types not size. 4)Add an image bigger than 500 kb 5)Nothing happens 6)Apply patch 7)Repeat steps from 1 to 3 8)Notice the message now includes the maximum size Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:06:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:06:02 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130089|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 130307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130307&action=edit Bug 28576: Update the maximum size of an image. This patch modifies the maximum size of a patron's image, from 500KB to 2MB. Also, in Home/Patrons/anyPatron, when you try to add an image to a patron, you can now see the supported file types AND the maximum size. The following places are affected by this patch: - Home/Patrons/anyPatron - Home/Tools/Upload patron images - Home/Tools/Patron card creator/Images To test: 1)Search for any patron and go to his page. 2)Hover over the image area on the left and click on the "Add" button. 3)Notice that the message above the choose file button only specifies file types without the maximum size. 4)Add an image bigger than 500KB. 5)Nothing happens. (This is because the maximum size is 5KB) 6)Apply the patch. 7)Repeat steps from 1 to 3. 8)Notice that the message now includes the maximum size. 9)Add an image bigger than 500KB, but smaller than 2MB. 10)The image is succesfully uploaded. 11)Add an image bigger than 2MB. 12)Nothing happens. (The maximum size is now 2MB) 13)Repeat the steps 9 to 12 in "Home/Tools/Upload patron images" and "Home/Tools/Patron card creator/Images". 14)Notice that the maximum size is updated. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:06:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:06:46 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #21 from Martin Renvoize --- All works as described, new allowance hard coded. Everything works here and QA script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:06:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:06:51 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:09:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:09:13 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #25 from Jonathan Druart --- IMO we are going too far here. Please provide patches on follow-up bug reports instead. I don't understand why the "Virtualshelves exceptions" part is in Koha::Exception::Generic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:10:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:10:18 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #26 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #19) > (In reply to Jonathan Druart from comment #0) > > We must have a generic full_message method in the Koha::Exceptions base > > class to display all the info we have about the exception. > > The current state is bad as we are displaying the "description" of the > > exception but it does not contain useful information. > > Exception 'Koha::Exception::TestMR' thrown 'Something went wrong!' with > status => x, type => HASH(0x5653eb753278) > > How useful is HASH(0x5653eb753278) ? We should call Dumper if it's a struct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:13:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:13:01 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #27 from Jonathan Druart --- (In reply to Jonathan Druart from comment #26) > (In reply to Marcel de Rooy from comment #19) > > (In reply to Jonathan Druart from comment #0) > > > We must have a generic full_message method in the Koha::Exceptions base > > > class to display all the info we have about the exception. > > > The current state is bad as we are displaying the "description" of the > > > exception but it does not contain useful information. > > > > Exception 'Koha::Exception::TestMR' thrown 'Something went wrong!' with > > status => x, type => HASH(0x5653eb753278) > > > > How useful is HASH(0x5653eb753278) ? > > We should call Dumper if it's a struct. Marcel, did you find an example in the code or it's theoretical? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:22:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:22:12 +0000 Subject: [Koha-bugs] [Bug 28852] Extend options in SelfCheckoutByLogin syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28852 Andy Boze changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Boze.1 at nd.edu --- Comment #1 from Andy Boze --- I especially agree with Andrew Fuerste-Henry that a unique patron attribute might be used at checkout on a selfcheck. We will soon find ourselves in that situation. My university will enable students to use up to three smart devices (phones and watches) instead of their barcoded ID cards. Each smart device will have its own unique ID number. It will be important that students be able to use those devices at our self-check stations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:31:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:31:56 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #17 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #14) > (In reply to Jonathan Druart from comment #12) > > Tomas, shouldn't we deal with all biblioitem's attributes? > > It is your fault :P > > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115963 Sorry, misunderstood what you were referring to. Fair enough then! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:35:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:35:51 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:35:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:35:55 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130125|0 |1 is obsolete| | Attachment #130126|0 |1 is obsolete| | Attachment #130127|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 130308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130308&action=edit Bug 29570: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:36:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:36:00 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #19 from Jonathan Druart --- Created attachment 130309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130309&action=edit Bug 29570: Fix sorting orders by biblioitems columns The API representation of Koha::Biblio objects includes the biblioitems.* columns too. This proved problematic as queries had to get translated so they work (i.e. if a query passes q={"biblio.ean":"123%"} then the query needs to be tweaked so biblio.ean is translated into biblio.biblioitem.ean. This is solved, locally, in the controller. But sorting needs the same kind of tweak, and it was missing. This patch solves that by doing a similar conversion. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail, searching on a 'biblioitems' column generates a 500 error. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! We can sort on those fields 5. Sign off :-D Note: you will notice the tests only cover sorting by ISBN. I consider it enough as sorting is a DB problem, and we only want to know if the generated ORDER BY is valid for the underlying query, and MySQL would complain if it wasn't the case. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:36:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:36:05 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #20 from Jonathan Druart --- Created attachment 130310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130310&action=edit Bug 29570: Enable sorting orders by summary This patch enables (on receiving) sorting orders by the summary column. It needs the previous patches to work. Title is given more precedence as expressed by users on the bug report. Which, by the way, makes sense. To test: 1. Create a basket 2. Create orders 3. Close basket 4. Receive shipment 5. Enter invoice information => SUCCESS: You should see your pending orders => FAIL: Verify the 'Summary' column is not sortable 7. Apply this patches 8. Restart Plack 9. Reload the page => SUCCESS: Can sort by the summary column 10. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:36:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:36:10 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #21 from Jonathan Druart --- Created attachment 130311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130311&action=edit Bug 29570: Simplify for loop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:36:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:36:42 +0000 Subject: [Koha-bugs] [Bug 30041] Add MARC and Card preview to biblio search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30041 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:36:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:36:45 +0000 Subject: [Koha-bugs] [Bug 30041] Add MARC and Card preview to biblio search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30041 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130251|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 130312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130312&action=edit Bug 30041: Add MARC and Card preview to biblio search results This enhancement adds MARC preview and Card preview links to the normal catalogue search results. To test: 1) Do a catalogue search in the staff client (use the 'Search the catalogue' tab, do not do a search that searches both the catalogue and the reservoir). 2) Notice there is no quick way to view the MARC and Card previews for each search result. 3) Apply patch and refresh the search results page 4) Confirm there are now links for both the MARC and Card previews 5) Confirm these popups show details of the records as expected Sponsored-by: Education Services Australia SCIS Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:37:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:37:17 +0000 Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart --- What about batch checkouts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:39:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:39:05 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |jonathan.druart+koha at gmail. |.com |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:52:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:52:38 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #67 from Martin Renvoize --- Created attachment 130313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130313&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:52:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:52:44 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #68 from Martin Renvoize --- Created attachment 130314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130314&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:52:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:52:51 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #69 from Martin Renvoize --- Created attachment 130315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130315&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:52:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:52:57 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #70 from Martin Renvoize --- Created attachment 130316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130316&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:53:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:53:07 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #71 from Martin Renvoize --- Created attachment 130317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130317&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:53:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:53:16 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #72 from Martin Renvoize --- Created attachment 130318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130318&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:53:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:53:22 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #73 from Martin Renvoize --- Created attachment 130319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130319&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:53:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:53:28 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #74 from Martin Renvoize --- Created attachment 130320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130320&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:53:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:53:34 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #75 from Martin Renvoize --- Created attachment 130321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130321&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:53:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:53:41 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #76 from Martin Renvoize --- Created attachment 130322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130322&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:53:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:53:50 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #77 from Martin Renvoize --- Created attachment 130323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130323&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:53:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:53:59 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #78 from Martin Renvoize --- Created attachment 130324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130324&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:54:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:54:05 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #79 from Martin Renvoize --- Created attachment 130325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130325&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:54:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:54:11 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #80 from Martin Renvoize --- Created attachment 130326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130326&action=edit Bug 28854: Highlight when a scanned item is unexpected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:54:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:54:17 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #81 from Martin Renvoize --- Created attachment 130327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130327&action=edit Bug 28854: Add count of scanned items to verification modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:54:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:54:23 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #82 from Martin Renvoize --- Created attachment 130328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130328&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:54:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:54:28 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #83 from Martin Renvoize --- Created attachment 130329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130329&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:54:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:54:34 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #84 from Martin Renvoize --- Created attachment 130330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130330&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:54:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:54:40 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #85 from Martin Renvoize --- Created attachment 130331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130331&action=edit Bug 28854: Make barcode comparison case insensative -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:54:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:54:46 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #86 from Martin Renvoize --- Created attachment 130332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130332&action=edit Bug 28854: (follow-up) Fix rebase re-indroduction of .json The API schema's all changed to .yaml but a rebase here re-introduced the .json links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:56:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:56:16 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #40 from Jonathan Druart --- +my $patron = Koha::Patrons->find( $borrowernumber );; Trailing semi-colon here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 17:58:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 16:58:00 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use in cleanborrowers.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- There is no occurrence of Date::Calc in tools/cleanborrowers.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:09:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:09:43 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #87 from Martin Renvoize --- We wrote some documentation for this, but bugzilla doesn't want to allow me to attach it.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:31:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:31:04 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use in batch_anonymize.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove Date::Calc use in |Remove Date::Calc use in |cleanborrowers.pl |batch_anonymize.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:35:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:35:19 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #20 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > (In reply to Katrin Fischer from comment #8) > > Also I wonder if we could avoid querying the record twice, but someone else > > might be better suited to comment on that: > > > > my $record = GetAuthority($authid); > > my $authobj = Koha::Authorities->find($authid); > > Agreed, that certainly could be replaced with > > my $authority = Koha::Authorities->find($authid); > my $record = $authority->record; What about this, Thibaud? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:38:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:38:36 +0000 Subject: [Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:38:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:38:40 +0000 Subject: [Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130160|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 130333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130333&action=edit Bug 29952: Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:43:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:43:17 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #34 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #26) > (In reply to Marcel de Rooy from comment #6) > > Just reading diagonally, sounds like yet another configuration to manage? > > Moving all preferences into it would be a dramatic refactoring that we > > probably do not finish? > > I agree. I will probably abandon this bug. Hum... What's next here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:48:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:48:33 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use in batch_anonymize.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:48:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:48:38 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use in batch_anonymize.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 130334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130334&action=edit Bug 30042: Remove Date::Calc dependency in batch_anonymize.pl This patch makes the script use the Koha::DateUtils tools instead. To test: 1. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --verbose --days 7 => SUCCESS: You see (the date may vary): Checkouts and holds before 2022-02-15 will be anonymised. 2. Apply this patch 3. Repeat 1 => SUCCESS: Same output 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:49:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:49:31 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use in batch_anonymize.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #3 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #1) > There is no occurrence of Date::Calc in tools/cleanborrowers.pl Right, sorry for that. I read 'the cronjob' on bug 29843 and jumped to file this one so we don't forget, but didn't check if the file was the right one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:50:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:50:24 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #34 from Jonathan Druart --- Alex, what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:50:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:50:29 +0000 Subject: [Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart --- Blocked by bug 23291. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:51:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:51:57 +0000 Subject: [Koha-bugs] [Bug 24630] UNIMARC XSLT Update for bug 7611 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Passed QA --- Comment #10 from Jonathan Druart --- No UNIMARC user in the QA team, trusting author and testers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:53:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:53:32 +0000 Subject: [Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the "Filter paid release notes| |transactions" link in the | |staff interface on the | |Patron account > Accounting | |> Transactions tab. It now | |correctly filters the list | |of transactions - only | |transactions with an | |outstanding amount greater | |than zero are shown ("Show | |all transactions" clears | |the filter). Before this | |fix, clicking on the link | |didn't do anything and | |didn't filter any of the | |transactions as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:54:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:54:20 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #35 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #34) > (In reply to Tomás Cohen Arazi from comment #26) > > (In reply to Marcel de Rooy from comment #6) > > > Just reading diagonally, sounds like yet another configuration to manage? > > > Moving all preferences into it would be a dramatic refactoring that we > > > probably do not finish? > > > > I agree. I will probably abandon this bug. > > Hum... What's next here? I see this pattern will become useful, I thought we would assign SMTP servers to libraries in a circ rules-like fashion, but I couldn't have that dev depend on this one so it moved forward in another direction. But it is not a priority until devs find it useful. As of the question, to make it useful: - It should consider library groups from the beginning - We need some UI for dealing with this, that can be reused to make configuration pages for modules/tools relying on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:55:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:55:03 +0000 Subject: [Koha-bugs] [Bug 30049] New: Add ability to download list as a spreadsheet. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30049 Bug ID: 30049 Summary: Add ability to download list as a spreadsheet. Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: estherm at sodaspringsid.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently the only options for downloading a list in the list tab is iso2709, RIS, Bibtex. It would be nice to be able to download a list as an Excel or LibreOffice Calc file, perhaps a CSV too. The ability to download a spreadsheet is available in other areas of Koha, and it would be nice if it was available in Lists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:59:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:59:07 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130267|0 |1 is obsolete| | --- Comment #41 from Tomás Cohen Arazi --- Created attachment 130335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130335&action=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 18:59:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 17:59:57 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #42 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #40) > +my $patron = Koha::Patrons->find( $borrowernumber );; > > Trailing semi-colon here. Good catch, fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:02:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:02:54 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130311|0 |1 is obsolete| | --- Comment #22 from Tomás Cohen Arazi --- Created attachment 130336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130336&action=edit Bug 29570: Simplify for loop Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:03:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:03:42 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:04:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:04:19 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #17 from Jonathan Druart --- Created attachment 130337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130337&action=edit Bug 28405: Add author for multi holds view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:04:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:04:40 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #18 from Jonathan Druart --- Do we want to display the author for the multi-holds view as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:06:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:06:14 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:06:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:06:20 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #36 from Jonathan Druart --- Should we then move it out of the NQA queue and revive it when we will need it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:08:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:08:21 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use in batch_anonymize.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #4 from Jonathan Druart --- Why this script and not all other occurrences then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:15:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:15:12 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |LATER -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:28:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:28:26 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #7 from David Nind --- Issues from testing: 1. The patch works for me - it stops mappings being deleted as reported. I had to clear the browser cache for this to work. 2. However, with mappings either filtered or unfiltered, if you: 2.1: Change one (for example: Authorities > Heading-Main, 155a - change the Yess to Nos), save, the change to the mapping is not saved. 2.2: Delete one, save, the deleted mapping is not deleted. 2.3: Add a new one (for example: Heading-Main, Yes for all options, 155b), the new mapping is not saved. 3. I also noted that when adding a new mapping, the options available for the sortable column are Undef, 0 and 1. For all the other columns the options are Yes and No. I'm not familiar enough with Elastic to know whether this is correct or not. Tested using Firefox Developer Edition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:32:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:32:36 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #79 from Andrew Fuerste-Henry --- On parcel.pl, when selecting orders to receive, we should have a "Select all" option to check the boxes for all orders currently onscreen. In this multi-receiving workflow, for order set to create items in cataloging, quantity received is defaulting to 0 and requiring the user to manually change it to match quantity ordered. When following the normal single order receiving workflow, Koha will assume that quantity received = quantity ordered if your basket was set to create items in cataloging. This change needs to be corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:48:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:48:01 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:48:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:48:06 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129700|0 |1 is obsolete| | --- Comment #18 from Tomás Cohen Arazi --- Created attachment 130338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130338&action=edit Bug 29519: Allow resolution of claims return at checkin Add a 'Resolve' button in the alert dialogue that is displayed when a lost item with a return claim is checked in. The button will trigger the usual resolution modal allowing the user to pick their resolution. This patch splits the resolution modal out of checkouts.js and checkouts-table.inc so it can be used outside of the checkouts table. We then reload it, optionally based upon the presence of the claims preference, where needed. This has the added benefit that it saves a little bit of page load data in cases where the feature is not enabled. Test plan 1. As we alter the file locations of the resolution handling code we need to test that normal claims functionality continue to work as expected. 2. Test the new functoinality by checking in an item that has been claimed as returned (but not yet resolved). The dialogue box should now contain a 'resolve' button next to each claimant and clicking upon it should trigger the resolution modal where the librarian can subsequently pick the resolution and submit it. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 19:49:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 18:49:46 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 --- Comment #19 from Tomás Cohen Arazi --- I like it. Maybe the interaction between marking the return claim as resolved and the previous checkin modal could be revisited at some point (i.e. it still lets you choose the 'Resolve' button). Not a blocker IMHO. Great -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 20:04:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 19:04:44 +0000 Subject: [Koha-bugs] [Bug 30050] New: Koha::DateUtils needs usable POD Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30050 Bug ID: 30050 Summary: Koha::DateUtils needs usable POD Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org There's no mention of the possible values. For example, the valid formats. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 20:05:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 19:05:19 +0000 Subject: [Koha-bugs] [Bug 30050] Koha::DateUtils needs usable POD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30050 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 20:08:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 19:08:02 +0000 Subject: [Koha-bugs] [Bug 30051] New: Changing AcqCreateItems value impacts baskets set to follow default behavior Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30051 Bug ID: 30051 Summary: Changing AcqCreateItems value impacts baskets set to follow default behavior Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When creating a basket in acquisitions, we record the user's choice for item creation in aqbasket.create_items. However, if one sets the basket to follow the default behavior determined in the AcqCreateItems syspref then we leave aqbasket.create_items NULL. This can create issues if the syspref gets changed. For example: - set AcqCreateItems to "placing an order" - create a basket, leaving item creation set to the default - confirm aqbasket.create_items is null - add an order to your basket from a new bib. confirm your bib and 1 item are created. - close your basket - set AcqCreateItems to "receiving an order" - receive your order - confirm receiving the order creates a second item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 20:15:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 19:15:58 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #12 from Tomás Cohen Arazi --- Hi, I would like us to not get distracted by Koha lacking things or not ideal, and focus on the fact that this is the current behavior, and the API is not respecting it and is affecting stable. I'm more than happy to rewrite it all on a follow-up bug, add an on/off switch for holds and remove maxreserves too :-D On a separate bug :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 20:29:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 19:29:04 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove Date::Calc use in |Remove Date::Calc use |batch_anonymize.pl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 20:29:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 19:29:13 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 20:52:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 19:52:12 +0000 Subject: [Koha-bugs] [Bug 30052] New: When adding a 'New child record' the 773 field is not pre-populated in advanced editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30052 Bug ID: 30052 Summary: When adding a 'New child record' the 773 field is not pre-populated in advanced editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To recreate: 1 - Enable Advanced Cataloging Editor 2 - Edit a record and confirm you are using, or switch to advanced editor 3 - From an existing record Click 'New->New child record' 4 - Fill in required fields and save 5 - Record is not linked to parent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 21:30:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 20:30:19 +0000 Subject: [Koha-bugs] [Bug 30053] New: Separate serials enum/pub date into columns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30053 Bug ID: 30053 Summary: Separate serials enum/pub date into columns Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org Currently in the holdings table for a serial the enum column forces the enum value, numbering pattern, and pub date. While these can individually be hidden, often a library needs all three pieces of data, but needs them to display in separate columns. With the table settings controlling the display now, this would be a welcomed addition. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 22:57:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 21:57:04 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #78 from Andrew Fuerste-Henry --- I see this bug is a bit stuck, but commenting to say I like the idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 22:57:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 21:57:32 +0000 Subject: [Koha-bugs] [Bug 28852] Extend options in SelfCheckoutByLogin syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28852 Charles Kelley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmkelleymls at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 23:07:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 22:07:18 +0000 Subject: [Koha-bugs] [Bug 30054] New: Add SMS equivalent to EmailOverduesNoEmail Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30054 Bug ID: 30054 Summary: Add SMS equivalent to EmailOverduesNoEmail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 20076 introduced a new system preference 'EmailOverduesNoEmail' which is great. Koha will still generate a print notice when SMS is selected in overdue notice/status triggers and a patron does not have an smsalertnumber. It would be nice if there was an SMS equivalent system pref like 'SMSOverduesNoSMS' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 23:09:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 22:09:43 +0000 Subject: [Koha-bugs] [Bug 30053] Separate serials enum/pub date into columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30053 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 23:23:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 22:23:31 +0000 Subject: [Koha-bugs] [Bug 28556] Make guarantor information available in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 --- Comment #1 from The Minh Luong --- Created attachment 130339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130339&action=edit Bug 28556: Guarantor's information is available in notice This patch adds the guarantor's information when sending sending overdue notice. To test: 1. Make sure that there is an overdue letter. a) Go in Tools/Notices & Slips. b) Search for the code "ODUE" and note the "Name" of the letter. c) Click on "Edit". d) Click on "Email" and make sure that there is text inside the box. e) Add the following code in the textbox: C/O <> <>
f) Click on "Save". 2. Set up the status trigger. a) Go in Tools/Overdue notice/status triggers. b) In "First" tab, put a number of days in the "Delay" column (ex: 1). c) In the column "Letter", put the "Name" of the letter of step 1a) . d) Check "Email". e) Click "Save". 3. Create a patron with a guarantor. a) Go in Administration/Patron categories. b) Create a child category AND a adult category. c) Create an adult patron. d) Create a child patron. e) Go in the child patron's page and click "Edit". f) In the "Patron guarantor" section, click add guarantor. g) Search for your adult patron and click "Select". h) Select a relationship for the guarantor (ex: Mother). i) Click on "Save". 4. Borrow an overdue item. a) Click on the arrow next to "Search button" (Top of the screen). b) Click on "Items search". c) Click on search. d) Copy a barcode in the list. e) Search for your child patron. f) Go in his page and click on "Checkout". g) Paste the barcode copied at step 4d) . h) Click on "Checkout settings". i) Put a date in the past greater than the number of days that you put on step 2b). j) Click on "Check out". k) Click on "Yes" Notice tht there is a message saying that Patron has ITEMS OVERDUE. 5. Test the patch. a) In the terminal, run ./misc/cronjobs/overdue_notices.pl b) Return in your child patron's page. c) Click on "Notice" and you should see a letter. d) Click on the letter to see the content. c) Notice that you can't see the guarantor's informations (Adult patron). d) Apply the patch. e) Notice that you can see the guarantor's informations. NOTE: If you want to delete the letters, do in your terminal: - my - delete from message_queue; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 23:26:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 22:26:44 +0000 Subject: [Koha-bugs] [Bug 28556] Make guarantor information available in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130339|0 |1 is obsolete| | --- Comment #2 from The Minh Luong --- Created attachment 130340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130340&action=edit Bug 28556: Guarantor's information is available in notice This patch adds the guarantor's information when sending sending overdue notice. To test: 1. Make sure that there is an overdue letter. a) Go in Tools/Notices & Slips. b) Search for the code "ODUE" and note the "Name" of the letter. c) Click on "Edit". d) Click on "Email" and make sure that there is text inside the box. e) Add the following code in the textbox: C/O <> <>
f) Click on "Save". 2. Set up the status trigger. a) Go in Tools/Overdue notice/status triggers. b) In "First" tab, put a number of days in the "Delay" column (ex: 1). c) In the column "Letter", put the "Name" of the letter of step 1a) . d) Check "Email". e) Click "Save". 3. Create a patron with a guarantor. a) Go in Administration/Patron categories. b) Create a child category AND a adult category. c) Create an adult patron. d) Create a child patron. e) Go in the child patron's page and click "Edit". f) In the "Patron guarantor" section, click add guarantor. g) Search for your adult patron and click "Select". h) Select a relationship for the guarantor (ex: Mother). i) Click on "Save". 4. Borrow an overdue item. a) Click on the arrow next to "Search button" (Top of the screen). b) Click on "Items search". c) Click on search. d) Copy a barcode in the list. e) Search for your child patron. f) Go in his page and click on "Checkout". g) Paste the barcode copied at step 4d) . h) Click on "Checkout settings". i) Put a date in the past greater than the number of days that you put on step 2b). j) Click on "Check out". k) Click on "Yes" Notice tht there is a message saying that Patron has ITEMS OVERDUE. 5. Test the patch. a) In the terminal, run ./misc/cronjobs/overdue_notices.pl b) Return in your child patron's page. c) Click on "Notice" and you should see a letter. d) Click on the letter to see the content. c) Notice that you can't see the guarantor's informations (Adult patron). d) Apply the patch. e) Reapeat steps a) to d) f) Notice that you can see the guarantor's informations. NOTE: If you want to delete the letters, do in your terminal: - my - delete from message_queue; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 23:28:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 22:28:48 +0000 Subject: [Koha-bugs] [Bug 28556] Make guarantor information available in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |philippe.blouin at inlibro.com | |, | |the-minh.luong at inlibro.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Feb 8 23:44:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 22:44:34 +0000 Subject: [Koha-bugs] [Bug 30054] Add SMS equivalent to EmailOverduesNoEmail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30054 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 00:22:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 23:22:21 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 --- Comment #13 from Katrin Fischer --- Sorry, was not clear enough maybe: not super happy, but ok with the patch as is. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 00:26:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 23:26:58 +0000 Subject: [Koha-bugs] [Bug 30046] ILS-DI: GetPatronInfo doesn't return the category description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30046 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|GetPatronInfo doesn't |ILS-DI: GetPatronInfo |return the category |doesn't return the category |description |description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 00:28:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 23:28:10 +0000 Subject: [Koha-bugs] [Bug 30049] Add ability to download list as a spreadsheet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30049 --- Comment #1 from Katrin Fischer --- Hi Esther, have a look at tools > CSV profiles. You can make up your own spreadsheet format to export the cart and lists there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 00:35:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 23:35:26 +0000 Subject: [Koha-bugs] [Bug 30026] International Phone Number Not supported for SMSAlert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 --- Comment #8 from David Cook --- (In reply to Florian from comment #7) > But it's already there in the code. The current version already supports > vast majority of exit codes, this patch aims to make sure we support even > more. I'm not sure if you're referring to Koha or your Koha plugin here. If it's Koha, no it doesn't? Anyway, that's just my 2 cents. Testers and QA might think differently. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 00:41:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Feb 2022 23:41:04 +0000 Subject: [Koha-bugs] [Bug 30039] Add published_on column to missing issues table on claims.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 01:55:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 00:55:31 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #14 from David Cook --- (In reply to Tomás Cohen Arazi from comment #12) > I'm more than happy to rewrite it all on a follow-up bug, add an on/off > switch for holds and remove maxreserves too :-D On a separate bug :-D Yes please :3. I had some thoughts on this at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565#c266 but didn't have funds/scope to do anything about it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 03:11:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 02:11:01 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #29 from David Cook --- Anyone interested in this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 08:43:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 07:43:12 +0000 Subject: [Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #30 from Jonathan Druart --- (In reply to David Cook from comment #29) > Anyone interested in this one? I will have a look again if you provide a patch on the follow-up bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 09:41:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 08:41:42 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130293|0 |1 is obsolete| | --- Comment #5 from Kevin Carnes --- Created attachment 130341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130341&action=edit Bug 25669: ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) Starting with version 7.0 of Elasticsearch type names should not be used and in version 6.8 there is a warning if you don't use include_type_name when using put_mapping (requires Search::Elasticsearch at 6.8). To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) Observe any deprecation warnings or errors about types 3) Apply patch 4) Install Search::Elasticsearch with the same version as Elasticsearch 5) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 6) Observe no warning or errors about types 7) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 09:42:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 08:42:59 +0000 Subject: [Koha-bugs] [Bug 27770] ES: Deprecated aggregation order key [_term] used, replaced by [_key] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130290|0 |1 is obsolete| | --- Comment #3 from Kevin Carnes --- Created attachment 130342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130342&action=edit Bug 27770: ES: Deprecated aggregation order key [_term] used, replaced by [_key] Starting in Elasticsearch 6.0 _key should be used instead of _term to order buckets by their term To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) If you observe an error about types, apply patch for bug 25669 3) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4) Observe if you get a deprecation warning about order key 5) Apply patch 6) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 7) Observe no deprecation warning about order key 8) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 09:44:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 08:44:16 +0000 Subject: [Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130291|0 |1 is obsolete| | --- Comment #2 from Kevin Carnes --- Created attachment 130343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130343&action=edit Bug 28610: Elasticsearch 7 - hits.total is now an object In Elasticsearch 7 hits.total is now an object which is not always an exact value. You can always get an exact total by adding a track_total_hits parameter set to true when using the Elasticsearch search method To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) If you observe an error about types, apply patch for bug 25669 3) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4) Observe that tests with count fail 5) Apply patch 6) Observe that tests with count pass 7) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:00:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:00:59 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123708|0 |1 is obsolete| | Attachment #127488|0 |1 is obsolete| | Attachment #127490|0 |1 is obsolete| | Attachment #127492|0 |1 is obsolete| | --- Comment #26 from Björn Nylén --- Created attachment 130344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130344&action=edit Bug 14783: Change pickup location from opac. This patch allows users to change the pickup location for their holds from the opac. A syspref (OPACAllowUserToChangeBranch) controls at what stage a hold can be changed. To test: 1. Set up holds with diffrent statuses for a patron (pending, waiting, in transit, suspended) 2. No pickup locations for any hold should be able to be changed. 3. Turn on and off the different options under OPACAllowUserToChangeBranch. Make sure that only the corresponding holds can be changed from the opac. Check eg in the staff client that pickup location has changed. 4. The available pickup locations should respect any transfer restrictions. (Same as the holds list for a biblio in staff client) 5. For an in-transit hold: Check in the item at the original pickup location. 6. Note that it will be redirected to the new location. Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: Owen Leonard Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:01:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:01:04 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #27 from Björn Nylén --- Created attachment 130345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130345&action=edit Bug 14783: (QA follow-up) Add unit tests. This commit adds unit tests for Bug 14783. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:01:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:01:08 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #28 from Björn Nylén --- Created attachment 130346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130346&action=edit Bug 14783: (follow-up) Move pickup library form into modal This patch attemps to simplify the list of holds by moving the form for changing a hold's pickup library into a modal dialog. This patch also makes minor tweaks to the CSS for the "X" close button shown in modal in windows. Instances where modal markup used "x" have been updated to use the Bootstrap 4 standard "×" To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Turn on the OPACAllowUserToChangeBranch system preference. - Log in to the OPAC as a user with holds. - In the view of your holds, confirm that each hold which can be modified shows a "Change" link. - Clicking the link should show a modal window with the title of the item on hold shown in the header. - Confirm that changing the pickup location works correctly. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:01:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:01:13 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #29 from Björn Nylén --- Created attachment 130347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130347&action=edit Bug 14783: (QA follow-up) Change "Pick up location" to "Pickup location" in table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:05:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:05:25 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #30 from Björn Nylén --- Got around to this. Rebased the patchset onto current master as there was some conflicts. Fixed the warning in the tests and commit-titles. Test and qa-tool passes for me now. Setting back to Signed off as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:36:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:36:43 +0000 Subject: [Koha-bugs] [Bug 30055] New: Rewrite patron searches to make them use the REST API routes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Bug ID: 30055 Summary: Rewrite patron searches to make them use the REST API routes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:37:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:37:15 +0000 Subject: [Koha-bugs] [Bug 29125] Use Koha::Patron object in C4:Utils::DataTables::Members.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29125 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30055 --- Comment #6 from Jonathan Druart --- Bug 30055 will make this bug obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:37:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:37:15 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29125 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:37:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:37:37 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 [Bug 29844] Remove uses of wantarray in Koha::Objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:37:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:37:37 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:38:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:38:26 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:38:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:38:26 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 [Bug 29136] Patron search on request.pl has performance and display issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:39:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:39:40 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30055 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:39:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:39:40 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=1707 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:40:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:40:50 +0000 Subject: [Koha-bugs] [Bug 22316] Double quotes in some patron's attributes breaks patrons search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22316 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart --- Will be fixed by bug 30055. *** This bug has been marked as a duplicate of bug 30055 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:40:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:40:50 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #1 from Jonathan Druart --- *** Bug 22316 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:41:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:41:00 +0000 Subject: [Koha-bugs] [Bug 27912] Quotes break guarantor search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27912 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- Will be fixed by bug 30055. *** This bug has been marked as a duplicate of bug 30055 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 10:41:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 09:41:00 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Jonathan Druart --- *** Bug 27912 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 11:08:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 10:08:08 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 11:08:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 10:08:12 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130237|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 130348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130348&action=edit Bug 29893: Prevent ES mappings UI to remove hidden rows If you are editing ES mappings and you use the DataTable filtering option, the table won't contain all the mappings you have in the DB. If the form is submitted they will be removed and data will be lost! Test plan: Edit ES mappings, filter and submit the form. Confirm that the table are redrawn before the form submission which prevent data loss -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 11:08:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 10:08:16 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 --- Comment #9 from Jonathan Druart --- Created attachment 130349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130349&action=edit Bug 29893: Make sure the form will be submitted after the draw calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 11:09:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 10:09:04 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 --- Comment #10 from Jonathan Druart --- Sorry David, the previous patch was terribly wrong. I kept the first approach and fix what I think was a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 12:26:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 11:26:02 +0000 Subject: [Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 --- Comment #4 from Tomás Cohen Arazi --- We need a new 'list_borrowers' subpermission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 12:43:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 11:43:34 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 --- Comment #1 from Martin Renvoize --- Created attachment 130350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130350&action=edit Bug 29453: Add endpoints for fetching patron credits & debits This patch adds two new API endpoints for fetching a patrons credits and a patrons debits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 12:43:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 11:43:56 +0000 Subject: [Koha-bugs] [Bug 17735] Merge boraccount and pay pages into one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29453 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 [Bug 29453] Add routes to fetch patron credits/debits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 12:43:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 11:43:56 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 [Bug 17735] Merge boraccount and pay pages into one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 12:44:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 11:44:33 +0000 Subject: [Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the ability to hide categorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128145|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 130351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130351&action=edit Bug 29617: exclude categorycode from BorrowerUnwantedField To test: 1. Go to BorrowerUnwantedField and select categorycode as unwanted 2. Try adding a new patron, you will see an error message in the staff client "Something went wrong when creating the patron. Check the logs." You will be unable to make a new patron. 3. Apply patch 4. Go to BorrowerUnwantedField, you are unable to exlcude it. Patrons need categorycodes Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:03:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:03:45 +0000 Subject: [Koha-bugs] [Bug 29509] GET /patrons* routes permissions excessive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30055 --- Comment #5 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #4) > We need a new 'list_borrowers' subpermission. On top of bug 30055 please. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:03:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:03:45 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 [Bug 29509] GET /patrons* routes permissions excessive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:10:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:10:58 +0000 Subject: [Koha-bugs] [Bug 28852] Extend options in SelfCheckoutByLogin syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28852 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- I know Swedish libraries are often used to having multiple cardnumbers/IDs per patron from their old systems, and are somewhat disappointed when this is not possible in Koha (although we have usually found a way to work around it, so far). If we do allow for this, we must make sure it works for all sorts of loggings in, like SIP2 and ILS-DI too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:18:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:18:54 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #28 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #27) > (In reply to Jonathan Druart from comment #26) > > (In reply to Marcel de Rooy from comment #19) > > > (In reply to Jonathan Druart from comment #0) > > > > We must have a generic full_message method in the Koha::Exceptions base > > > > class to display all the info we have about the exception. > > > > The current state is bad as we are displaying the "description" of the > > > > exception but it does not contain useful information. > > > > > > Exception 'Koha::Exception::TestMR' thrown 'Something went wrong!' with > > > status => x, type => HASH(0x5653eb753278) > > > > > > How useful is HASH(0x5653eb753278) ? > > > > We should call Dumper if it's a struct. > > Marcel, did you find an example in the code or it's theoretical? I do not have a real example. So I am not sure about that. But it isn't far fetched if we are starting to use this more. Dumper could do it indeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:19:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:19:30 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #29 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > IMO we are going too far here. Please provide patches on follow-up bug > reports instead. > > I don't understand why the "Virtualshelves exceptions" part is in > Koha::Exception::Generic. Because it is now in Exceptions.pm where it does not belong either :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:23:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:23:32 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #30 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > IMO we are going too far here. Please provide patches on follow-up bug > reports instead. Heh. I see this happen all the time :) As to singular, I think we do half of the work here and then leave it. And we should try more to finish what we started? But you can remove the concept patch. Not sure if it will reach another report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:31:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:31:44 +0000 Subject: [Koha-bugs] [Bug 30056] New: autoBarcode and serial supplemental issue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30056 Bug ID: 30056 Summary: autoBarcode and serial supplemental issue Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: pierre.genty at biblibre.com QA Contact: testopia at bugs.koha-community.org Hi, In administration module, autoBarcode preference is set to "generated in the form yymm001". In framework structure, barcode.pl plugin is called in the item barcode field. I am editing a serial (Create an item record when receiving this serial is set), change the status to "Arrived", automatically create a barcode by clicking on barcode box, then create a supplemental issue (before to save). The automatic barcode for this supplemental issue is equal to the regular issue above. Don't know if it is possible but the plugin barcode.pl should check for a previous auto generated barcode in the current page in order to avoid duplicate barcode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:32:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:32:10 +0000 Subject: [Koha-bugs] [Bug 30056] autoBarcode and serial supplemental issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30056 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:37:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:37:43 +0000 Subject: [Koha-bugs] [Bug 26129] Add a new 'configurations' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #37 from Tomás Cohen Arazi --- Bug 29924 could be done with this... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:38:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:38:19 +0000 Subject: [Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the ability to hide categorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:43:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:43:44 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:43:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:43:47 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129934|0 |1 is obsolete| | Attachment #129935|0 |1 is obsolete| | Attachment #129936|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 130352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130352&action=edit Bug 29660: Remove hostitemsflag Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:43:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:43:51 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 --- Comment #11 from Nick Clemens --- Created attachment 130353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130353&action=edit Bug 29660: Unused code in placerequest.pl Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:43:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:43:56 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 --- Comment #12 from Nick Clemens --- Created attachment 130354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130354&action=edit Bug 29660: Remove biblioitem loop from request.pl It seems that hiddencount didn't work prior to this patch (to confirm) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:46:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:46:02 +0000 Subject: [Koha-bugs] [Bug 30057] New: Move Virtualshwlves exceptions to their own file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057 Bug ID: 30057 Summary: Move Virtualshwlves exceptions to their own file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org They are wrongly placed right now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:46:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:46:10 +0000 Subject: [Koha-bugs] [Bug 30057] Move Virtualshwlves exceptions to their own file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29857 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 [Bug 29857] We must stringify our exceptions correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:46:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:46:10 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30057 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057 [Bug 30057] Move Virtualshwlves exceptions to their own file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:47:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:47:47 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130157|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:47:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:47:53 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:48:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:48:01 +0000 Subject: [Koha-bugs] [Bug 30058] New: Add a Koha::Patrons method to filter by permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30058 Bug ID: 30058 Summary: Add a Koha::Patrons method to filter by permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:48:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:48:01 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30058 [Bug 30058] Add a Koha::Patrons method to filter by permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:48:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:48:27 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 130355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130355&action=edit Bug 29857: (QA follow-up) Add license Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:48:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:48:34 +0000 Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move Virtualshwlves |Move Virtualshelves |exceptions to their own |exceptions to their own |file |file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:50:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:50:02 +0000 Subject: [Koha-bugs] [Bug 30059] New: Add a JS equivalent to Koha::Patron->get_age Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 Bug ID: 30059 Summary: Add a JS equivalent to Koha::Patron->get_age Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 30055 To display the age of patrons in a table we will need to do the calculation in JS Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:50:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:50:02 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30059 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 [Bug 30059] Add a JS equivalent to Koha::Patron->get_age -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:52:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:52:03 +0000 Subject: [Koha-bugs] [Bug 30060] New: Missing primary key on user_permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 Bug ID: 30060 Summary: Missing primary key on user_permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Blocks: 30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:52:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:52:03 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30060 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 [Bug 30060] Missing primary key on user_permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:52:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:52:56 +0000 Subject: [Koha-bugs] [Bug 29125] Use Koha::Patron object in C4:Utils::DataTables::Members.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29125 --- Comment #7 from Jonathan Druart --- I am going to move the following patch to bug 30060: Bug 29125: Add primary key to user_permissions table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:53:01 +0000 Subject: [Koha-bugs] [Bug 29125] Use Koha::Patron object in C4:Utils::DataTables::Members.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29125 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30060 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 [Bug 30060] Missing primary key on user_permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:53:01 +0000 Subject: [Koha-bugs] [Bug 30060] Missing primary key on user_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29125 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29125 [Bug 29125] Use Koha::Patron object in C4:Utils::DataTables::Members.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:54:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:54:32 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 --- Comment #13 from Nick Clemens --- This works well, it also fixes what I th8ink is a bug Test plan: 1 - Enable EasyAnalyticalRecords 2 - Find a record, Edit->Link to host record 3 - Paste a barcode from another record 4 - The item now shows in the holdings list 5 - Attempt to place hold 6 - Linked item shows in holdings block 7 - Alter rules to prevent linked item from being holdable, only linked item holdable etc. 8 - All works as expected 9 - Also test placing holds on two records, including the record with linked item 10 - Can place hold as long as 1 item available on eahc, or can only hold record with holdable items Before these patches: - The linked item appeared in its own table, when not holdable there was a warning that the hold could not be placed as no items were available even when the regular items were available and it was possible to place a hold. - This seems to exist in 19.11 and forwards - I did not check farther back -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:55:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:55:28 +0000 Subject: [Koha-bugs] [Bug 30060] Missing primary key on user_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 --- Comment #1 from Jonathan Druart --- Without primary key DBIC is failing with something like: GET /api/v1/suggestions/managers: unhandled exception (DBIx::Class::Exception)< user_permissions chain): fetch more unique non-nullable columns at /kohadevbox/koha/Koha/Objects.pm line 394>> Koha::REST::Plugin::Exceptions::__ANON__ / kohadevbox/koha/Koha/REST/Plugin/Exceptions.pm (73) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:55:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:55:54 +0000 Subject: [Koha-bugs] [Bug 30060] Missing primary key on user_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:55:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:55:58 +0000 Subject: [Koha-bugs] [Bug 30060] Missing primary key on user_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 --- Comment #2 from Jonathan Druart --- Created attachment 130356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130356&action=edit Bug 30060: Add primary key to user_permissions table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:57:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:57:35 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #32 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #22) > (In reply to Marcel de Rooy from comment #21) > > Created attachment 130156 [details] [review] [review] > > Bug 29857: (CONCEPT) Switch to singular, add a load method > > > > The load method calls the Class::Exception import. Allowing you > > to skip a use Class::Exception everywhere, and define 'nicer' > > exception lists? > > Any thoughts ? I like it. It deserves its own bug IMHO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:58:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:58:48 +0000 Subject: [Koha-bugs] [Bug 30060] Missing primary key on user_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 --- Comment #3 from Jonathan Druart --- Test plan: Execute the atomic update and confirm that the new PK has been added to the user_permissions table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 13:59:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 12:59:17 +0000 Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's with expired passwords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129958|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 130357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130357&action=edit Bug 29925: Add a password reset page for expired passwords This patch adds a new page opac-reset-password where a user cna enter their login (userid or carndumber), current password, and new password. If the user has a password expiration date and the current password is correct and the new passwords match and meet requirements their password will be updated and the expiration date reset A patron whose password does not expire will be reidrected to login to change their password To test: 1 - Apply patch, updatedatabase, enable new syspref EnableExpiredPasswordReset 2 - Set 'Password expiration' for a patron category Home->Administration->Patron categories->Edit 3 - Create a new patron in this category with a userid/password set, and an email 4 - Update the patron with an expiration to be expired UPDATE borrowers SET password_expiration='2022-01-01' WHERE borrowernumber=51; 5 - Give the borrower catalogue permission 6 - Attempt to log in to Straff interface 7 - Confirm you are signed out and notified that password must be reset 8 - Click 'Reset your password' link 9 - You should see the reset password page with fields for: login, current password, new password, conmfirm password 10 - enter invalid/incomplete credentials 11 - Confirm you are notified of invlaid credentials 12 - Fill in all fields, but enter current password as new password 13 - Confirm you are notified of no change 14 - Set minimum password length / strong password requirement for category 15 - Confirm you receive error if new password too short or not secure 16 - Enter a valid new password and submit and confirm update is successful 17 - Confirm you have buttons to go to OPAC or Staff and that both work 18 - Confirm you cna log in (i.e. expiration has been reset) 19 - Expire the users password 20 - Remove catalogue permission 21 - Reset password again and confirm only OPAC link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:05:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:05:39 +0000 Subject: [Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:05:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:05:43 +0000 Subject: [Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 --- Comment #1 from Jonathan Druart --- Created attachment 130358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130358&action=edit Bug 30059: Add JS equivalent for Koha::Patron->get_age On bug 30055 we are going to use the REST API to display the patron search result, we will then need to calculate patron's age client-side. This is moved to its own bug report in case we need to reuse it somewhere else. Test plan: Copy/paste the JS function in your browser's console then call it and confirm that the result is correct For instance: $get_age('2000-01-01') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:07:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:07:27 +0000 Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 130359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130359&action=edit Bug 30057: Move virtualshelf-related exceptions to a separate library This patch moves the not-generic virtualshelf-related exceptions to their own file. Callers are adjusted as required. To test: 1. Run: $ kshell k$ prove t/db_dependent/Virtualshelves.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass 4. Check virtualshelves work as expected 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:07:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:07:40 +0000 Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:10:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:10:34 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:19:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:19:14 +0000 Subject: [Koha-bugs] [Bug 30060] Missing primary key on user_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:19:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:19:17 +0000 Subject: [Koha-bugs] [Bug 30060] Missing primary key on user_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130356|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi --- Created attachment 130360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130360&action=edit Bug 30060: Add primary key to user_permissions table Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:21:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:21:18 +0000 Subject: [Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:44:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:44:04 +0000 Subject: [Koha-bugs] [Bug 30061] New: Simplify Koha::Patron->get_age Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30061 Bug ID: 30061 Summary: Simplify Koha::Patron->get_age Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The method could just use regular DateTime/DateTime::Duration arithmetic instead of parsing strings and doing math manually. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:44:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:44:27 +0000 Subject: [Koha-bugs] [Bug 30061] Simplify Koha::Patron->get_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30061 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:44:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:44:37 +0000 Subject: [Koha-bugs] [Bug 30058] Add a Koha::Patrons method to filter by permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30058 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:44:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:44:40 +0000 Subject: [Koha-bugs] [Bug 30058] Add a Koha::Patrons method to filter by permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30058 --- Comment #1 from Jonathan Druart --- Created attachment 130361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130361&action=edit Bug 30058: Add Koha::Patrons->filter_by_have_subpermission This method will allow to filter a patron set by a given subpermission. It will be useful on bug 30055 where we want to display only patron with suggestion or acquisition subpermission. Note that it could be extended to allow several subpermissions, but we don't need it so far. Test plan: prove t/db_dependent/Koha/Patrons.t must return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:47:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:47:44 +0000 Subject: [Koha-bugs] [Bug 30061] Simplify Koha::Patron->get_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30061 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 130362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130362&action=edit Bug 30061: Make Koha::Patron->get_age use DateTime math This patch does what the title says. Instead of converting dates to strings and performing math manually, we can just use the DateTime objects we have and calculate the DateTime::Duration there's between them, to get the years count. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:52:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:52:59 +0000 Subject: [Koha-bugs] [Bug 30062] New: Add ability in patron attributes to use an authorized value with an "Other" option Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30062 Bug ID: 30062 Summary: Add ability in patron attributes to use an authorized value with an "Other" option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com For patron attributes, libraries sometimes want a semi-controlled list of values with the ability to pick "Other" and enter a one-time non-authorized value. For example, a library uses a patron attribute to store the hometown of guest patrons to whom they've issued a card. In order to promote consistency of data, they've created an authorized value that lists all the most common hometown they encounter. But sometimes a patron shows up with a hometown the library hasn't allowed for. They may go back and add this new town to the authorized value later, but for now they just want to put it in the patron record. I suggest we add an option in patron attribute setup so that if one connects an attribute to an authorized value one can also check a box for "include an 'Other' option." If that box is checked in the attribute setup, when one is editing a patron the dropdown for the attribute will include the option "Other." If the user selects "Other," then a text box appears and the user can enter a free text value. That value gets saved in borrower_attributes.attribute but not added to the authorized value. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 14:56:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 13:56:30 +0000 Subject: [Koha-bugs] [Bug 30062] Add ability in patron attributes to use an authorized value with an "Other" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30062 --- Comment #1 from Andrew Fuerste-Henry --- Currently, one could accomplish something similar by using 2 attributes, one tied to the authorized value and a second with a free text box and a note of "If your desired value isn't in the dropdown, type it here." This makes reporting and searching harder and also presents a difficulty for enforcing mandatory fields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:18:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:18:09 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 --- Comment #15 from Thibaud Guillot --- Created attachment 130363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130363&action=edit Bug 18064 : Add syspref to launch longOverdue script with calendar support The problem here is that the longOverdue script does not support calendars and when libraries set their holidays, long overdues do not take this into account. For example, during the covid pandemic, some libraries were closed for days, maybe months, but longOverdue didn't care and set "lost" or other values on the items. This fix / enhancement based on taking calendars into account to test it, regardless of your rules related to longOverdue, I propose this test plan: Test plan : 1) For clearer vision on what the patch does, have at least "2" libraries 2) Go to Tools/Calendar and place holidays, on each of the libraries for example, of any kind (special, repeated, as you want) 3) Manually run the misc/cronjobs/longoverdue.pl script with the -v (verbose) argument to get as much information as possible 4) You will see a common "block", with today's date + 366 days (by default if you don't pass any arguments to the script), holidays are not taken into account in this date range 5) Apply my patch 6) Launch the updatedatabase 7) Set the new system preference "LongOverdueNoticeCalendar" to "use calendar" 8) Repeat step 3 9) You will see in output one line per library and according to the number of days off in the interval of dates, the start date of the analysis will have been postponed by as many days in order to take these holidays into account. If something is not completely clear, we can of course discuss it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:19:18 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |thibaud.guillot at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:25:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:25:00 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:25:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:25:05 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #3 from Jonathan Druart --- Created attachment 130364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130364&action=edit Bug 30055: Make patron searches use the REST API This patch will rewrite some of our patron searches to make them use the REST API routes (and so the powerful the DataTables wrapper which will bring all the nice DT feature to filter, sort, etc.) The patron searches we will take into account here are those that we use to select a patron in a pop-up: * Guarantor * Suggestion's manager * Patron's card * Serial routing list * Users to notify when order is received * Manager of an acquisition basket * Owner and users of a fund Regarding permissions there are two main problematics: * Filter a patron set by patrons having a specific subpermissions (in case of adding a manager to a suggestion or when we deal with acquisition and funds). We added a new Koha::Patrons->filter_by_have_subpermission method that will take in parameter a subpermission. To make thing transparent for the callers we are adding new routes, like /suggestions/managers to list the possible managers of suggestions. * Restrict/allow access to the default patron searches /patrons We need to access it when a logged in patron does not have borrowers permission. Ideally we need a separate "search_borrowers" subpermissions but it's considered outside the scope of this change. For each patch you will take care of testing the different permissions that are into effect (either for the logged in patron or the patrons returned by the search). The tables should contain the same columns as prior to this patch, except for "categories" and "library". We have the filter on top of the page and so we need to add them to the table as new columns if they weren't there before. Test plan (for this patch): Search for guarantor and select Test plan (for all patches): Add/Select patrons from the correct place where you can search for patrons, play extensively with the filters/pagination/etc Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:25:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:25:09 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #4 from Jonathan Druart --- Created attachment 130365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130365&action=edit Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions Test plan: Select a manager for a suggestion Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:25:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:25:14 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #5 from Jonathan Druart --- Created attachment 130366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130366&action=edit Bug 30055: Use /patrons for patron's cards Test plan: Create a new card batch and add new borrowernumber using the "Add patron(s)" button. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:25:19 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #6 from Jonathan Druart --- Created attachment 130367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130367&action=edit Bug 30055: Use /patrons for routing list Test plan: Add new users to a serial routing list Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:25:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:25:23 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #7 from Jonathan Druart --- Created attachment 130368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130368&action=edit Bug 30055: Use /patrons for neworderempty Test plan: Create or edit an order, add users to notify on receiving Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:25:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:25:28 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #8 from Jonathan Druart --- Created attachment 130369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130369&action=edit Bug 30055: Use /acquisitions/baskets/managers for basket's manager Test plan: Add a manager to a basket Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:25:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:25:32 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #9 from Jonathan Druart --- Created attachment 130370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130370&action=edit Bug 30055: /api/v1/acquisitions/funds/owners and users for funds Two new routes that do the same thing /api/v1/acquisitions/funds/owners /api/v1/acquisitions/funds/users To list the possible owners and users for a fund Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:25:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:25:36 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #10 from Jonathan Druart --- Created attachment 130371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130371&action=edit Bug 30055: Adjust hint about permissions Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:25:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:25:54 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29136 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 [Bug 29136] Patron search on request.pl has performance and display issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:25:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:25:54 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30055 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:26:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:26:04 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rewrite patron searches to |Rewrite some of the patron |make them use the REST API |searches to make them use |routes |the REST API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:26:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:26:31 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:27:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:27:21 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #11 from Jonathan Druart --- Tests are missing for the new API routes. I can provide them (even if they will be dumb), but I'd like to make sure you won't make me rewrite the whole thing before... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:34:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:34:06 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com --- Comment #9 from Lucy Vaux-Harvey --- I agree it would be good if the Welcome email could be sent to self-registered patrons (without the password included - see bug 27812). We have library customers who would like to use this facility. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:35:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:35:22 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #12 from Jonathan Druart --- Created attachment 130372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130372&action=edit Bug 30055: Prevent blink when page is loading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:37:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:37:01 +0000 Subject: [Koha-bugs] [Bug 19464] emailLibrarianWhenHoldIsPlaced email enhancement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19464 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:37:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:37:39 +0000 Subject: [Koha-bugs] [Bug 30063] New: Make the main patron search use the /patrons REST API route Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Bug ID: 30063 Summary: Make the main patron search use the /patrons REST API route Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:37:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:37:39 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 [Bug 30063] Make the main patron search use the /patrons REST API route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:37:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:37:58 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99893|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize --- Created attachment 130373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130373&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:38:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:38:04 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99894|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize --- Created attachment 130374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130374&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:38:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:38:09 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99895|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize --- Created attachment 130375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130375&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:38:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:38:14 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99896|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize --- Created attachment 130376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130376&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:38:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:38:20 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99897|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize --- Created attachment 130377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130377&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:38:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:38:24 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99898|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize --- Created attachment 130378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130378&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:38:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:38:29 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99899|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize --- Created attachment 130379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130379&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:38:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:38:34 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99900|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize --- Created attachment 130380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130380&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:38:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:38:39 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99901|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize --- Created attachment 130381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130381&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:38:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:38:44 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99902|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize --- Created attachment 130382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130382&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:38:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:38:49 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #89 from Martin Renvoize --- Created attachment 130383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130383&action=edit Bug 23681: (follow-up) Fix rebase issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:38:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:38:54 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #90 from Martin Renvoize --- Created attachment 130384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130384&action=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:39:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:39:09 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24975 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 [Bug 24975] Refactor database translations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:39:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:39:09 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23681 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 [Bug 23681] Patron restrictions should be user definable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:40:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:40:18 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #91 from Martin Renvoize --- Rebased and added a follow-up to do as Katrin suggested.. we now use hardcoded translations in the template if the defaults are left unaltered in the existing debarment types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:43:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:43:14 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #13 from Jonathan Druart --- Hum, found something here. I removed the "patron_preview" thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:52:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:52:01 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:52:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:52:07 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130364|0 |1 is obsolete| | Attachment #130365|0 |1 is obsolete| | Attachment #130366|0 |1 is obsolete| | Attachment #130367|0 |1 is obsolete| | Attachment #130368|0 |1 is obsolete| | Attachment #130369|0 |1 is obsolete| | Attachment #130370|0 |1 is obsolete| | Attachment #130371|0 |1 is obsolete| | Attachment #130372|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 130385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130385&action=edit Bug 30055: Make patron searches use the REST API This patch will rewrite some of our patron searches to make them use the REST API routes (and so the powerful the DataTables wrapper which will bring all the nice DT feature to filter, sort, etc.) The patron searches we will take into account here are those that we use to select a patron in a pop-up: * Guarantor * Suggestion's manager * Patron's card * Serial routing list * Users to notify when order is received * Manager of an acquisition basket * Owner and users of a fund Regarding permissions there are two main problematics: * Filter a patron set by patrons having a specific subpermissions (in case of adding a manager to a suggestion or when we deal with acquisition and funds). We added a new Koha::Patrons->filter_by_have_subpermission method that will take in parameter a subpermission. To make thing transparent for the callers we are adding new routes, like /suggestions/managers to list the possible managers of suggestions. * Restrict/allow access to the default patron searches /patrons We need to access it when a logged in patron does not have borrowers permission. Ideally we need a separate "search_borrowers" subpermissions but it's considered outside the scope of this change. For each patch you will take care of testing the different permissions that are into effect (either for the logged in patron or the patrons returned by the search). The tables should contain the same columns as prior to this patch, except for "categories" and "library". We have the filter on top of the page and so we need to add them to the table as new columns if they weren't there before. Test plan (for this patch): Search for guarantor and select Test plan (for all patches): Add/Select patrons from the correct place where you can search for patrons, play extensively with the filters/pagination/etc Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:52:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:52:11 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #15 from Jonathan Druart --- Created attachment 130386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130386&action=edit Bug 30055: Use /api/v1/suggestions/managers to list managers or suggestions Test plan: Select a manager for a suggestion Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:52:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:52:17 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #16 from Jonathan Druart --- Created attachment 130387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130387&action=edit Bug 30055: Use /patrons for patron's cards Test plan: Create a new card batch and add new borrowernumber using the "Add patron(s)" button. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:52:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:52:23 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #17 from Jonathan Druart --- Created attachment 130388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130388&action=edit Bug 30055: Use /patrons for routing list Test plan: Add new users to a serial routing list Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:52:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:52:28 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #18 from Jonathan Druart --- Created attachment 130389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130389&action=edit Bug 30055: Use /patrons for neworderempty Test plan: Create or edit an order, add users to notify on receiving Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:52:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:52:33 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #19 from Jonathan Druart --- Created attachment 130390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130390&action=edit Bug 30055: Use /acquisitions/baskets/managers for basket's manager Test plan: Add a manager to a basket Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:52:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:52:38 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #20 from Jonathan Druart --- Created attachment 130391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130391&action=edit Bug 30055: /api/v1/acquisitions/funds/owners and users for funds Two new routes that do the same thing /api/v1/acquisitions/funds/owners /api/v1/acquisitions/funds/users To list the possible owners and users for a fund Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:52:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:52:43 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #21 from Jonathan Druart --- Created attachment 130392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130392&action=edit Bug 30055: Adjust hint about permissions Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:52:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:52:47 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #22 from Jonathan Druart --- Created attachment 130393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130393&action=edit Bug 30055: Prevent blink when page is loading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:52:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:52:52 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #23 from Jonathan Druart --- Created attachment 130394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130394&action=edit Bug 30055: Restore patron's preview links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 15:57:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 14:57:07 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com --- Comment #90 from e.betemps --- I made 3 tests and none of them was fully satisfying. 1) to 5) : no problem 6) I had to "Restart services" for "XSL - Simple Export" to appear in the menu (but i don't know if this really is a problem) 7) is ok 8) the downloaded file seems to be empty and contains no info on the record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 16:13:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 15:13:32 +0000 Subject: [Koha-bugs] [Bug 17735] Merge boraccount and pay pages into one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/mrenvoiz | |e/Koha/-/compare/master...b | |ug_17735 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 16:30:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 15:30:40 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #24 from Jonathan Druart --- Created attachment 130395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130395&action=edit Bug 30055: Add missing include to format addresses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 16:34:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 15:34:37 +0000 Subject: [Koha-bugs] [Bug 30064] New: Dates in issues table on subscriptions tab in OPAC are not sorting correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30064 Bug ID: 30064 Summary: Dates in issues table on subscriptions tab in OPAC are not sorting correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The publication date and received date columns in the issues table in the OPAC are not sorting correctly. To recreate: - Create a subscription - Receive mulitple issues, manipulate the published and received dates to be in different months and years - Open the record in the OPAC and switch to the subscription tab - The sorting on top of the table indicates that it should be sorted by publication date - Verify it is not sorted correctly, also not after clicking on the column header -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 16:56:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 15:56:06 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #20 from Thibaud Guillot --- Created attachment 130396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130396&action=edit Added a syspref to highlight or not highlight search terms in results on the staff interface There is a possibility on OPAC but not yet on the staff interface, so I added this syspref which has the same behaviour as the OPAC highlighting syspref. When you choose to disable highlighting on the syspref, the toggle anchor in the result page does not appear at all. But if you keep the default state (highlighting on), you still have the option to switch between "Unhighlight" and "Highlight" modes. Test plan : 1. Go to the syspref named "HighlightedWords" and see that the default state is "Highlight". 2. Look for something in the catalogue for example and see that the words are highlighted and that it is also possible to change between "Unhighlight" and "Highlight". 3. Go back to syspref and choose to disable highlighting by choosing "Don't Highlight". 4. Refresh your results page if you have not closed it or reload a new search. 5. There is no highlighting at all and anchors do not exist (same behaviour as the OPAC interface). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 16:57:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 15:57:39 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128359|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 17:02:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 16:02:48 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #21 from Thibaud Guillot --- (In reply to David Nind from comment #19) > I have tested this and it works as expected. I would suggest these changes: > > 1. System preference name: change from HighlightedWords to > StaffHighlightedWords > > 2.System preference wording: > . Current: Don't highlight|Highlight words the patron searched for in > their search results and detail pages. > . Suggested: Don't highlight|Highlight words searched for in the staff > interface search results pages. > . Notes: For me the highlighting is only working on the search listing > results pages, not on the record detail pages. > > - Location in the system preferences area: I would put under Staff > interface > Appearance as this is consistent with the OPAC system > preference, rather than under Searching > Results display. > > - Enable highlighting by default: as this is a change in the default > behavour I would tend to leave the default (highlighting) enabled, rather > than disabling it (that is, set the default to Highlight). Hello David, Thanks for you feedback :) I completely understand your notes, I'm agree for the syspref name : the more precise, the better it will be. Also for the description, my english is not as good as i would like ^^ so I change this too. And for the location... yes totally correct and adequate I concede it, like the default behavior as you notice. So I push again the patch with all this changes, thanks to tell me your opinion :) And if other people test it of course we can discuss -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 17:12:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 16:12:28 +0000 Subject: [Koha-bugs] [Bug 30062] Add ability in patron attributes to use an authorized value with an "Other" option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30062 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 17:15:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 16:15:49 +0000 Subject: [Koha-bugs] [Bug 30065] New: Correct errors in backporting of database updates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30065 Bug ID: 30065 Summary: Correct errors in backporting of database updates Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 25078 changed how database updates are handled at upgrade for versions 21.11 and later. In backporting bug 29457 and bug 29557 to 21.05.09, I mistakenly followed the new updatedatabase structure. This bug is to correct those errors. As I understand the changes from 25078, this error won't cause an upgrade to 21.05.09 to fail, but the changes from the two bugs linked above will not be made. Those changes are a correction to a notice script and two informational notes to be output when updatedatabase runs, so the impact here is minimal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 17:30:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 16:30:24 +0000 Subject: [Koha-bugs] [Bug 30066] New: POD for chargeable_units on CalcFine wrong? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30066 Bug ID: 30066 Summary: POD for chargeable_units on CalcFine wrong? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Developer documentation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org POD reads: C<$chargeable_units> is the number of chargeable units (days between start and end dates, Calendar adjusted where needed, minus any applicable grace period, or hours) But actually it looks like the grace period (firstremind) is still included. Otherwise this would make no sense: my $chargeable_units = get_chargeable_units($fine_unit, $start_date, $end_date, $branchcode); my $units_minus_grace = $chargeable_units - ($issuing_rule->{firstremind} || 0); my $units = C4::Context->preference('FinesIncludeGracePeriod') ? $chargeable_units : $units_minus_grace; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:19:18 +0000 Subject: [Koha-bugs] [Bug 30065] Correct errors in backporting of database updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30065 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 130397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130397&action=edit Bug 30065: Correct errors in updatedatabase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:21:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:21:59 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122184|0 |1 is obsolete| | Attachment #122185|0 |1 is obsolete| | Attachment #122186|0 |1 is obsolete| | Attachment #122187|0 |1 is obsolete| | --- Comment #168 from The Minh Luong --- Created attachment 130398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130398&action=edit Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:22:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:22:08 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #169 from The Minh Luong --- Created attachment 130399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130399&action=edit Bug 12446: Schema update Category.pm Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:22:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:22:16 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #170 from The Minh Luong --- Created attachment 130400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130400&action=edit Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:22:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:22:23 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #171 from The Minh Luong --- Created attachment 130401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130401&action=edit Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali Signed-off-by: Salman Ali Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:22:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:22:33 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #172 from The Minh Luong --- Created attachment 130402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130402&action=edit Bug 12446: Adult can now have guarantors This patch allows adult patrons to have guarantors. It adds the field "Can be guarantee" to patron categories, so it becomes possible for any category type to have a guarantor. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" gor the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:26:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:26:05 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the-minh.luong at inlibro.com Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:31:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:31:36 +0000 Subject: [Koha-bugs] [Bug 30065] Correct errors in backporting of database updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:31:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:31:39 +0000 Subject: [Koha-bugs] [Bug 30065] Correct errors in backporting of database updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130397|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 130403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130403&action=edit Bug 30065: Correct errors in updatedatabase Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:32:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:32:24 +0000 Subject: [Koha-bugs] [Bug 30065] Correct errors in backporting of database updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:32:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:32:29 +0000 Subject: [Koha-bugs] [Bug 30065] Correct errors in backporting of database updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:33:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:33:32 +0000 Subject: [Koha-bugs] [Bug 30065] Correct errors in backporting of database updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130403|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 130404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130404&action=edit Bug 30065: Correct errors in updatedatabase Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:37:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:37:27 +0000 Subject: [Koha-bugs] [Bug 30065] Correct errors in backporting of database updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130404|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 130405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130405&action=edit Bug 30065: Correct errors in updatedatabase Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:47:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:47:23 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #25 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #11) > Tests are missing for the new API routes. I can provide them (even if they > will be dumb), but I'd like to make sure you won't make me rewrite the whole > thing before... I find this implementation lovely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:48:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:48:51 +0000 Subject: [Koha-bugs] [Bug 30065] Correct errors in backporting of database updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30065 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.09 released in| | Resolution|--- |FIXED Status|Passed QA |RESOLVED --- Comment #5 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.10 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:48:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:48:53 +0000 Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 --- Comment #2 from Owen Leonard --- Created attachment 130406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130406&action=edit Bug 30011: Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface This patch updates jQueryUI in the OPAC and staff interface. Old assets are removed and new assets added. jQueryUI has been re-compiled in each interface to include only the required features. In the OPAC: tabs and tooltip. In the staff interface: accordion, autocomplete, sortable, and tabs. The next patch will make the required updates to templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:48:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:48:57 +0000 Subject: [Koha-bugs] [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 --- Comment #3 from Owen Leonard --- Created attachment 130407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130407&action=edit Bug 30011: Update links to jQueryUI assets, remove datepicker references, etc. This patch updates templates to include the new version of jQueryUI. It removes some references to the now unused datepicker widget as well as the jQuery timepicker addon. Some minor JavaScript and style updates to fix issues resulting from the upgrade. To test, apply the patch and update the CSS in the staff interface AND in the OPAC (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). IN THE OPAC: - The OPAC only uses the tabs jQueryUI widget. - View pages where tabs are used: Bibliographic details, user summary, advanced search. IN THE STAFF INTERFACE: - The staff interface uses four jQueryUI widgets: accordion, autocomplete, sortable, and tabs - Test the accordion widget on two pages: Administration -> Table settings and Patrons -> Patrons requesting modifications. - Test autocomplete (requires PatronAutoComplete to be enabled) on various pages. For example: - From the "Check out" tab in the header search box. - From the "Search patrons" tab in the header search box, e.g. from the main Patrons page. - Place hold -> Search patrons. - Tools -> Patron lists -> Add patrons to list -> Patron search. - Test sortable: - Administration -> System preferences -> Language. - With more than one language installed you should be able to drag to re-order the enabled languages. Confirm that your change is saved successfully. - Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields on a tag with multiple subfields. You should be able to drag to re-order the tabs at the top of the subfield constraints edit page. Confirm that your changes are saved successfully. - Cataloging -> New record. Test that you can re-order subfields under a tag with multiple subfields and that your changes are saved. - Tabs: View various pages with tabs: Check out, bibliographic details, basic MARC editor. They're everywhere. Also confirm that the removal of the leftover datepicker doesn't affect pages which use the calendar include: Test various pages which use Flatpickr, e.g. check out, renew, reports, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:50:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:50:52 +0000 Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 --- Comment #4 from Owen Leonard --- Created attachment 130408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130408&action=edit Bug 29155: Upgrade jQuery and jQuery Migrate to latest versions jQuery is upgraded from 2.2.3 to 3.6.0. jQuery Migrate is upgraded from 1.3.0 to 3.3.2. The next patch will update links to point to the new assets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 18:50:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 17:50:56 +0000 Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 --- Comment #5 from Owen Leonard --- Created attachment 130409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130409&action=edit Bug 29155: Update links to jQuery and jQuery Migrate files With these patches, jQuery versions in the OPAC and staff interface are both updated to 3.6.0. The latest version of jQuery Migrate is installed to allow us to take a slower approach to updating out-of-date syntax. To test, apply the patch and try as many pages as you can, paying attention to the browser console to watch for errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 19:16:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 18:16:01 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 --- Comment #11 from David Nind --- Thanks Jonathan! However, I am now getting these messages in yellow boxes above the "Search engine configuration (Elasticsearch)" heading: "You attempted to delete all mappings for a required index, you must leave at least one mapping" "An error occurred when updating mappings: ." This occurs any time the save button is clicked. On the positive side, the mappings are no longer deleted. On the downside, you can't edit, add or delete any mappings. Consolidated test plan: 1. In the staff interface go to Administration > Catalog > Search engine configuration (Elasticsearch). 2. Select the authorities tab. 3. You should see ~67 entries. 4. Enter "Heading-Main" into the search field, you now see ~8 entries (filtered from 67 entries). 5. Cick the save button. 6. Go back to the authorities tab. 7. You will now see ~8 entries - all the other entries were deleted! 8. Apply the patch, flush_memcached, restart_all, and you may also need to clear your browser cache (or open a private window). 9. Repeat steps 1-7 - this time the expected number of entries should be visible after clicking save (~67), that is, all the entries are not deleted when you click save! 10. With mappings filtered and unfiltered, check that everything works as expected if you: . Change an entry (for example: Authorities > Heading-Main, 155a - change the Yess to Nos). . Delete an entry. . Add a new entry. (for example: Heading-Main, Yes for all options, 155b). 11. Sign off :D! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 19:58:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 18:58:48 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #22 from David Nind --- (In reply to Thibaud Guillot from comment #21) > Also for the description, my english is not as good as i would like ^^ so I > change this too. Hi Thibaud. Thanks for incorporating my suggestions - writing things in another language can be challenging, so hopefully that is where testing can help! I've retested, but for some reason highlighting doesn't seem to be working for me now - with either 'Highlight' or 'Don't highlight' selected for the new system preference. Also, I would suggest: - Setting the default to 'Highlight' (that is, leave the current behavour in place) (I'm not a developer, but from reading the code it should do that, but I'm not sure why it isn't). - For the patch add the bug number at the start, that is: Bug 20398: Added... (the QA Team will most likely pick this up). David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 21:17:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 20:17:38 +0000 Subject: [Koha-bugs] [Bug 29287] Display of funds on acquisitions home is not consistent with display on funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29287 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129356|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 130410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130410&action=edit Bug 29287: Add child funds to display of parent funds on acqui home Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Michael Sutherland -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 21:51:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 20:51:53 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #3 from Andrew Fuerste-Henry --- In step 15, my non-superlibrarian user can access the Set Library feature, but is presented with a dropdown that only offers their current library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 22:29:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 21:29:45 +0000 Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's with expired passwords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry --- There's a typo in the new syspref description. It says "If not enable patrons must either use the 'Forgot your password' feature or have staff reset their password." That should be "If not enabled." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 22:43:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 21:43:02 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |thibaud.guillot at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 9 23:10:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Feb 2022 22:10:39 +0000 Subject: [Koha-bugs] [Bug 30067] New: Create a template plugin for currencies Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30067 Bug ID: 30067 Summary: Create a template plugin for currencies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org A select for currencies exists in several places : > git grep 'select name=".*currency"' koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt: but for some reason it was only ONE place (two times) where it was: how hell it can be so? :) So complicated solution to bring $borrower unblessed through a such number of code lines just to get ... title? :) I assume these are some oooold times refactoring remnants, but - ... so please mates check if my patch to paycollect part is the correct solution (and I see the strong hivemind we have here :) ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 01:04:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 00:04:40 +0000 Subject: [Koha-bugs] [Bug 29883] Uninitialized value warning when GetAuthorisedValues gets called with no parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883 --- Comment #3 from Andrew Nugged --- Let me help with this, I will try to find where... I see there's dry call to: my $avs = C4::Koha::GetAuthorisedValues(); in svc url: /cgi-bin/koha/svc/cataloguing/framework Aha, ... so here: David: if you go from the usual MARC-editor (new record): http://localhost:8080/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= into the advanced editor (Settings -> Switch to the advanced editor): so URL will be: /cgi-bin/koha/cataloguing/editor.pl you will get that warning without this patch and won't get with the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:25:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:25:43 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #17 from Fridolin Somers --- Patch Bug 11873: Remove decoration on current authority removes a [% END %] in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt I fix that and reattach the patch Plus a patch to add missing TT filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:26:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:26:15 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130412|0 |1 is obsolete| | --- Comment #18 from Fridolin Somers --- Created attachment 130418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130418&action=edit Bug 11873: Remove decoration on current authority Previously the current authority was not styled like a link. It was useful to have a visual feedback knowing which authority is currently displayed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:27:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:27:03 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #19 from Fridolin Somers --- Created attachment 130419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130419&action=edit Bug 11873: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:35:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:35:04 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:19 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:21 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #20 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:23 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:26 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #42 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:29 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:31 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:34 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:36 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 --- Comment #9 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:38 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:41 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:43 +0000 Subject: [Koha-bugs] [Bug 29932] Phase out jquery.cookie.js: bibs_selected (Browse selected records) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:45 +0000 Subject: [Koha-bugs] [Bug 29932] Phase out jquery.cookie.js: bibs_selected (Browse selected records) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29932 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:49 +0000 Subject: [Koha-bugs] [Bug 29933] Fix stray usage of jquery.cookie.js plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29933 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:52 +0000 Subject: [Koha-bugs] [Bug 29933] Fix stray usage of jquery.cookie.js plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29933 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:54 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 02:36:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 01:36:57 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 05:34:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 04:34:45 +0000 Subject: [Koha-bugs] [Bug 29376] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29376 zackefron789 at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://www.arrowmeds.com/ CC| |zackefron789 at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 06:46:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 05:46:16 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 --- Comment #35 from Alex Buckley --- Hi Jonathan, My apologies for my delay in replying. I agree that bug 27380 now looks to have addressed the problem that Katrin noted in comment #7 and it means librarians can now easily batch modify by sms, primary, or secondary phone numbers easily. My feeling is it's fine for this bug report to be closed. I do think bug 29761 is necessary, however, because a librarian could still upload a list of cardnumbers or borrowernumbers containing duplicates. Thanks Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 08:20:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 07:20:39 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- I'm really sorry patch does not apply anymore on master. Looks like it is because of Bug 29859. I'll push fastly after rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 08:22:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 07:22:50 +0000 Subject: [Koha-bugs] [Bug 29767] Add cash registers, debit and credit types to report runtime parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 08:37:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 07:37:45 +0000 Subject: [Koha-bugs] [Bug 29767] Add cash registers, debit and credit types to report runtime parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 --- Comment #11 from Fridolin Somers --- Please add a nice release note ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:02:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:02:50 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:02:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:02:53 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:02:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:02:55 +0000 Subject: [Koha-bugs] [Bug 27904] Improve display in creating profile for staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:02:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:02:57 +0000 Subject: [Koha-bugs] [Bug 27904] Improve display in creating profile for staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:00 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:02 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #20 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:05 +0000 Subject: [Koha-bugs] [Bug 28993] Switch magnifying glass in staff detail pages to FA icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:07 +0000 Subject: [Koha-bugs] [Bug 28993] Switch magnifying glass in staff detail pages to FA icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:09 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:11 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #21 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:14 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:16 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:19 +0000 Subject: [Koha-bugs] [Bug 29767] Add cash registers, debit and credit types to report runtime parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:21 +0000 Subject: [Koha-bugs] [Bug 29767] Add cash registers, debit and credit types to report runtime parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 --- Comment #12 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:23 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:25 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:28 +0000 Subject: [Koha-bugs] [Bug 29966] SCO Help page passes flags while not needing authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29966 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:03:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:03:30 +0000 Subject: [Koha-bugs] [Bug 29966] SCO Help page passes flags while not needing authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29966 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:06:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:06:27 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Should we also rename Koha::Object::add_message ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:10:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:10:31 +0000 Subject: [Koha-bugs] [Bug 29876] Style report id in report results heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- (In reply to Katrin Fischer from comment #5) > Only a small thing: Should we make this read Report ID to match the label on > the saved reports table? +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:22:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:22:34 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130396|0 |1 is obsolete| | --- Comment #23 from Thibaud Guillot --- Created attachment 130420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130420&action=edit Bug 20398 : Added a syspref to highlight or not highlight search terms in results on the staff interface There is a possibility on OPAC but not yet on the staff interface, so I added this syspref which has the same behaviour as the OPAC highlighting syspref. When you choose to disable highlighting on the syspref, the toggle anchor in the result page does not appear at all. But if you keep the default state (highlighting on), you still have the option to switch between "Unhighlight" and "Highlight" modes. Test plan : 1. Go to the syspref named "HighlightedWords" and see that the default state is "Highlight". 2. Look for something in the catalogue for example and see that the words are highlighted and that it is also possible to change between "Unhighlight" and "Highlight". 3. Go back to syspref and choose to disable highlighting by choosing "Don't Highlight". 4. Refresh your results page if you have not closed it or reload a new search. 5. There is no highlighting at all and anchors do not exist (same behaviour as the OPAC interface). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:24:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:24:33 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130417|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 130421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130421&action=edit Bug 29684: (QA follow-up) paycollect.pl don't needs borrower_data at all Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:25:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:25:28 +0000 Subject: [Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #20 from Fridolin Somers --- Seeing both 'Default configuration' and 'Is default' looks very confusing. Same for setting checkbox 'is default' when already defined. Could we add a 'is default' checkbox in table ? with JavaScript to ensure only one is checked ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:26:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:26:58 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #24 from Thibaud Guillot --- (In reply to David Nind from comment #22) > (In reply to Thibaud Guillot from comment #21) > > > Also for the description, my english is not as good as i would like ^^ so I > > change this too. > Hi Thibaud. > > Thanks for incorporating my suggestions - writing things in another language > can be challenging, so hopefully that is where testing can help! > > I've retested, but for some reason highlighting doesn't seem to be working > for me now - with either 'Highlight' or 'Don't highlight' selected for the > new system preference. > > Also, I would suggest: > > - Setting the default to 'Highlight' (that is, leave the current behavour in > place) (I'm not a developer, but from reading the code it should do that, > but I'm not sure why it isn't). > > - For the patch add the bug number at the start, that is: Bug 20398: > Added... (the QA Team will most likely pick this up). > > David Yes David you are absolutely right, yesterday when I rebased the patch I forgot to change some variable names on the script that manages the feature... my apologies, now its works. And I adjust the commit by the way with the bug number :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:46:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:46:51 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #21 from Thibaud Guillot --- Created attachment 130422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130422&action=edit Bug 29173 : (follow-up) replace method to get the record from the authority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 09:49:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 08:49:33 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #22 from Thibaud Guillot --- (In reply to Jonathan Druart from comment #20) > (In reply to Jonathan Druart from comment #15) > > (In reply to Katrin Fischer from comment #8) > > > Also I wonder if we could avoid querying the record twice, but someone else > > > might be better suited to comment on that: > > > > > > my $record = GetAuthority($authid); > > > my $authobj = Koha::Authorities->find($authid); > > > > Agreed, that certainly could be replaced with > > > > my $authority = Koha::Authorities->find($authid); > > my $record = $authority->record; > > What about this, Thibaud? Yes it's simpler.. I don't know why the first time that I tested I found that it doesn't work.. its my mistake, sorry. Changed and tested, it seems to be ok now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 10:36:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 09:36:28 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #23 from Thibaud Guillot --- (In reply to David Nind from comment #19) > Testing notes (using koha-testing-docker): > > - Tested using both a MARC21 and UNIMARC installation. > > - For a UNIMARC installation there is only one way to replace (both before > and after the patch is applied): > . Select Edit > Edit record > . Click on the 'Replace record via Z39.50/SRU search' button > => There is no option in the dropdown list to change like a MARC21 > installation (Edit > Replace record via Z39.50/SRU search) Oh ok, I see what you mean, but maybe this dropdown list is about another issue or enhancement and not directly on this BZ. Its my opinion but I can make a mistake, I'm just a newbie on Koha :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 10:50:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 09:50:05 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:06:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:06:20 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #24 from David Nind --- (In reply to Thibaud Guillot from comment #23) > Oh ok, I see what you mean, but maybe this dropdown list is about another > issue or enhancement and not directly on this BZ. Its my opinion but I can > make a mistake, I'm just a newbie on Koha :) It was more just an observation, so not something that needs to be "fixed" if someone wants to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:20:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:20:57 +0000 Subject: [Koha-bugs] [Bug 30068] New: Wrong reference to table_borrowers in circulation.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Bug ID: 30068 Summary: Wrong reference to table_borrowers in circulation.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 17353, 21034 There is a reference to table_borrowers in the table settings yaml file, and this: 985 columns_settings_borrowers_table = [% TablesSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] in circulation.tt But #table_borrowers is not a table displaying patrons, but items. The confusion is coming from this commit that first introduced the id on this table: commit 7d598d9130c3d171af1e1a6a0a168cea043c277d Bug 21034: Re-indent circulation.tt Then: commit f6599b2c5480d2e096bac71e4e7ac759686b9fbc Bug 17353: Add phone number column to checkout search That added the columns settings line. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 [Bug 17353] Add phone number column to checkout search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 [Bug 21034] Re-indent circulation.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:20:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:20:57 +0000 Subject: [Koha-bugs] [Bug 17353] Add phone number column to checkout search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 [Bug 30068] Wrong reference to table_borrowers in circulation.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:20:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:20:57 +0000 Subject: [Koha-bugs] [Bug 21034] Re-indent circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 [Bug 30068] Wrong reference to table_borrowers in circulation.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:21:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:21:31 +0000 Subject: [Koha-bugs] [Bug 30068] Wrong reference to table_borrowers in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:26:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:26:08 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #25 from David Nind --- Patch no longer applies 8-(... things move too fast sometimes! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20398 : Added a syspref to highlight or not highlight search terms in results on the staff interface Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/pages/results.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/pages/results.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/pages/results.js error: Failed to merge in the changes. Patch failed at 0001 Bug 20398 : Added a syspref to highlight or not highlight search terms in results on the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:30:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:30:23 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #26 from David Nind --- (In reply to Thibaud Guillot from comment #24) > > Yes David you are absolutely right, yesterday when I rebased the patch I > forgot to change some variable names on the script that manages the > feature... my apologies, now its works. And I adjust the commit by the way > with the bug number :) No worries and excellent! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:32:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:32:55 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130280|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 130423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130423&action=edit Applied a fix to stop point-of-sale items being added twice to till transaction lists https://bugs.koha-community.org/show_bug.cgi?id=30003 Signed-off-by: Sally -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:34:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:34:10 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Sally --- Works great, thanks Jake! We have this problem with a couple of staff at one library, and we couldn't get to the bottom of it; invariably, whenever we were watching them process a transaction, they did it perfectly. Now we know the cause! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:36:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:36:04 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 --- Comment #8 from Mason James --- (In reply to Fridolin Somers from comment #7) > Pushed to master for 22.05, thanks to everybody involved 🦄 thanks, can we push this to all branches to 19.11 please -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:37:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:37:27 +0000 Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |mtj at kohaaloha.com, | |wainuiwitikapark at catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:38:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:38:07 +0000 Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:39:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:39:03 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |kyle at bywatersolutions.com, | |wainuiwitikapark at catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:46:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:46:21 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127898|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 130424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130424&action=edit Bug 29515: Make title for HTML customizations optional This adds code to make the title field for HTML customizations optional while it stays mandatory for news entries. 1) Add a new HTML customization, verify you are forced to enter a title 2) Apply patch 3) Repeat and verify that you can now save without title 4) Add a new news entry 5) Verify that the title field remained mandatory there. Signed-off-by: Barbara Johnson Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:47:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:47:16 +0000 Subject: [Koha-bugs] [Bug 29515] Don't require title for HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29515 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- All appears to continue to work.. I'm not entirely sure why title was required in the first place though.. it's not required for languages other than 'default' ? Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:48:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:48:52 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #5 from Martin Renvoize --- Jake is just fixing up the commit message to adhere to guidelines.. you guys we so quick :). I'll help him re-apply the signoff line ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:54:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:54:47 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #6 from Jake Deery --- Created attachment 130425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130425&action=edit Bug 30003: Fix to stop point-of-sale items being added twice to transactions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:55:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:55:00 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:56:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:56:40 +0000 Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all libraries even with IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:56:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:56:43 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Jake Deery changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130423|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:57:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:57:40 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130420|0 |1 is obsolete| | --- Comment #27 from Thibaud Guillot --- Created attachment 130426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130426&action=edit Bug 20398 : Added a syspref to highlight or not highlight search terms in results on the staff interface There is a possibility on OPAC but not yet on the staff interface, so I added this syspref which has the same behaviour as the OPAC highlighting syspref. When you choose to disable highlighting on the syspref, the toggle anchor in the result page does not appear at all. But if you keep the default state (highlighting on), you still have the option to switch between "Unhighlight" and "Highlight" modes. Test plan : 1. Go to the syspref named "HighlightedWords" and see that the default state is "Highlight". 2. Look for something in the catalogue for example and see that the words are highlighted and that it is also possible to change between "Unhighlight" and "Highlight". 3. Go back to syspref and choose to disable highlighting by choosing "Don't Highlight". 4. Refresh your results page if you have not closed it or reload a new search. 5. There is no highlighting at all and anchors do not exist (same behaviour as the OPAC interface). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:58:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:58:03 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Jake Deery changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130425|0 |1 is obsolete| | --- Comment #7 from Jake Deery --- Created attachment 130427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130427&action=edit Bug 30003: Fix to stop point-of-sale items being added twice to transactions https://bugs.koha-community.org/show_bug.cgi?id=30003 Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:58:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:58:50 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 11:59:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 10:59:32 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #28 from Thibaud Guillot --- (In reply to David Nind from comment #25) > Patch no longer applies 8-(... things move too fast sometimes! > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 20398 : Added a syspref to highlight or not highlight search > terms in results on the staff interface > Using index info to reconstruct a base tree... > M koha-tmpl/intranet-tmpl/prog/js/pages/results.js > Falling back to patching base and 3-way merge... > Auto-merging koha-tmpl/intranet-tmpl/prog/js/pages/results.js > CONFLICT (content): Merge conflict in > koha-tmpl/intranet-tmpl/prog/js/pages/results.js > error: Failed to merge in the changes. > Patch failed at 0001 Bug 20398 : Added a syspref to highlight or not > highlight search terms in results on the staff interface Normally I solved the conflict, thanks to you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:01:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:01:39 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #8 from Jake Deery --- Created attachment 130428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130428&action=edit Bug 30003: Prevent double up of point-of-sale items This patch prevents the double submission of point-of-sale items when form validation fails at the first submission Test plan 1. Navigate to /cgi-bin/koha/pos/pay.pl 2. Add an item from 'items to purchase' 3. Under 'collect payment', click submit without altering the form 4. See 'This field is required.' 5. Now, fill a value in 'Amount tendered' that satisfies or exceeds 'Amount being paid' 6. The payment should succeed 7. Navigate to /cgi-bin/koha/pos/register.pl 8. See duplicate lines in Transactions Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:02:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:02:02 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Jake Deery changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130427|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:03:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:03:35 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #9 from Jake Deery --- Right - apologies for the repeated attachments. Still getting the hang of git-bz ;-) Big thanks to Martin and Sally for taking a look at this, and Kyle for adding the sign-off line! Let me know how I can assist in the next steps. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:12:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:12:24 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jake.deery at ptfs-europe.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:12:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:12:42 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:13:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:13:03 +0000 Subject: [Koha-bugs] [Bug 28163] Register entries doubled up if form is submitted first without a selected register In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28163 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 30003 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:13:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:13:03 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Martin Renvoize --- *** Bug 28163 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:13:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:13:33 +0000 Subject: [Koha-bugs] [Bug 30003] When leaving 'Amount Tendered' blank, then filling in a value, two transactions are recorded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:14:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:14:37 +0000 Subject: [Koha-bugs] [Bug 30003] Register entries doubled up if form fails validation on first submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When leaving 'Amount |Register entries doubled up |Tendered' blank, then |if form fails validation on |filling in a value, two |first submission |transactions are recorded | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:16:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:16:37 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130426|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 130429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130429&action=edit Bug 20398 : Added a syspref to highlight or not highlight search terms in results on the staff interface There is a possibility on OPAC but not yet on the staff interface, so I added this syspref which has the same behaviour as the OPAC highlighting syspref. When you choose to disable highlighting on the syspref, the toggle anchor in the result page does not appear at all. But if you keep the default state (highlighting on), you still have the option to switch between "Unhighlight" and "Highlight" modes. Test plan : 1. Go to the syspref named "HighlightedWords" and see that the default state is "Highlight". 2. Look for something in the catalogue for example and see that the words are highlighted and that it is also possible to change between "Unhighlight" and "Highlight". 3. Go back to syspref and choose to disable highlighting by choosing "Don't Highlight". 4. Refresh your results page if you have not closed it or reload a new search. 5. There is no highlighting at all and anchors do not exist (same behaviour as the OPAC interface). Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:18:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:18:59 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #30 from e.betemps --- This patch applies. I encountered problems this morning (patch uninstalled or ineffective) but they seem solved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:25:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:25:07 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #31 from e.betemps --- (but the name of the syspref is 'StaffHighlightedWords') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:33:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:33:30 +0000 Subject: [Koha-bugs] [Bug 30065] Correct errors in backporting of database updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30065 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version(s)|21.05.09 |21.05.10 released in| | QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 12:53:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 11:53:05 +0000 Subject: [Koha-bugs] [Bug 29376] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29376 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://www.arrowmeds.com/ | CC|zackefron789 at gmail.com | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:00:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:00:52 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127465|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize --- Created attachment 130430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130430&action=edit Bug 24295: Remove GetTransfer from Z3950Responder Replace the GetTrasfer call in Z3950Responder/Session.pm with a call to the Koha::Item method 'get_transfer'. Test plan 1/ Configure your system to use the Z3950 responder 2/ Trigger an item transfer for an item 3/ Search for the item via Z3950 and varify the transfer status is set 4/ Apply the patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:00:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:00:57 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127466|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize --- Created attachment 130431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130431&action=edit Bug 24295: Remove GetTransfers from opac-reserve.pl This patch replaces the call to GetTransfers in opac-reserve with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the opac-reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:01:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:01:01 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127467|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize --- Created attachment 130432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130432&action=edit Bug 24295: Remove GetTransfers from opac-detail.pl This patch replaces the call to GetTransfers in opac-detail with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:01:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:01:06 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127468|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize --- Created attachment 130433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130433&action=edit Bug 24295: Remove GetTransfers from opac-basket.pl This patch replaces the call to GetTransfers in opac-basket with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-basket page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:01:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:01:10 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127469|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize --- Created attachment 130434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130434&action=edit Bug 24295: Remove GetTransfers from request.pl This patch replaces the call to GetTransfers in reserve.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:01:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:01:15 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127470|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize --- Created attachment 130435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130435&action=edit Bug 24295: Remove GetTransfers from detail.pl This patch replaces the call to GetTransfers in detail.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:01:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:01:19 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127471|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize --- Created attachment 130436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130436&action=edit Bug 24295: Remove GetTransfers from svc/holds This patch replaces the call to C4::GetTransfers in svc/holds with a call to the get_transfer method in the Koha::Item object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:01:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:01:23 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127472|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize --- Created attachment 130437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130437&action=edit Bug 24295: Replace mock in t/db_dependent/Search.t Replace the mock of GetTransfers in this test with a mock of transfers data Test plan 1/ Run t/db_dependent/Search.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:01:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:01:27 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127473|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize --- Created attachment 130438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130438&action=edit Bug 24295: Replace mock in t/db_dependent/Circulation/transferbook.t Replace the call to GetTransfers with the get_transfer method in Koha::Item in transferbook.t Test plan 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:01:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:01:31 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127474|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize --- Created attachment 130439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130439&action=edit Bug 24295: Remove GetTransfers call from C4/HoldsQueue.pm This patch removes the GetTransfers call from GetItemsAvailableToFillHoldRequestsForBib instead replacing it with an inline JOIN in the initial query. Test plan 1/ Run the holds queue 2/ Check the results 3/ Put one of the items in the holds queue into transit 4/ Run the holds queue again 5/ Check that the results do not contain the item that is in transit 6/ Apply the patch 7/ Run the holds queue again 8/ Check that the results still do not contain the item that is in transit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:01:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:01:36 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127475|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize --- Created attachment 130440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130440&action=edit Bug 24295: Remove GetTransfers from C4/Search.pm This patch removes the final use of GetTransfers from C4::Search. Test plan 1/ Perform a search that will include results for some items that have transfers of various states assigned to them 2/ Check the results match expectations (before and after applying the patch should look the same) 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:01:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:01:40 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127477|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize --- Created attachment 130441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130441&action=edit Bug 24295: Remove GetTransfers from circ/transferstoreceive.pl Just drop the import of GetTransfers from circ/transferstoreceive.pl is it's never actually used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:01:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:01:44 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127476|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize --- Created attachment 130442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130442&action=edit Bug 24295: Finally remove GetTransfers from C4/Circulation This patch handles the final removal of GetTransfers from C4::Circulation. Test plan 1/ Check that there is no mention of the GetTransfers method codebase wide now 2/ Run the circulation and transfers tests and check nothing fails.. perhaps even run the full test suit in k-t-d 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:04:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:04:31 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #70 from Martin Renvoize --- (In reply to Joonas Kylmälä from comment #56) Thanks for the review Joonas, it was really helpful! > 1. Some of the patches are missing check if there is any transfer at all > before proceeding to check in_transit status: > > + my $transfer = $item->get_transfer; > + if ( $transfer->in_transit ) { > Great catch, fixed inline in all patches now. > 2. The patch "Bug 24295: Finally remove GetTransfers from C4/Circulation" > needs to come last in the patch series, so just reorder and reattach the > patches. Done > 3. Need to add "use Koha::DateUtils qw( output_pref );" to those patches > that use the output_pref function here. Another good catch, done inline in all patches now. > 4. "Bug 24295: Remove GetTransfers from detail.pl" removes hours and > minutes, please bring them back :) Doh, sorted now. > 5. "Bug 24295: Remove GetTransfer from Z3950Responder" now only lists the > in_transit transfers, it used to return all transfers previously, even those > not yet sent (so in queue). Could you double-check on this? I think it is > okay and the previous behaviour was buggy as it says they are IN_TRANSIT > transfers, not queued ones. I agree with your conclusion here. It took a bit of digging first time around to come to that conclusion but I did the change by design here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:16:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:16:31 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.08 |21.11.00,21.05.08,20.11.15 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #15 from Victor Grousset/tuxayo --- > lets attempt to add this patch without any YAML::* updates first Thanks, it works! :) Backported: Pushed to 20.11.x branch for 20.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:20:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:20:41 +0000 Subject: [Koha-bugs] [Bug 29925] Add a 'set new password' page for patron's with expired passwords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29925 --- Comment #5 from Nick Clemens --- Created attachment 130443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130443&action=edit Bug 29925: (follow-up) Allow password reset when OpacPublic not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:28:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:28:28 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:28:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:28:32 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130062|0 |1 is obsolete| | Attachment #130063|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 130444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130444&action=edit Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:28:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:28:36 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #9 from Owen Leonard --- Created attachment 130445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130445&action=edit Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:31:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:31:50 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130429|0 |1 is obsolete| | --- Comment #32 from Thibaud Guillot --- Created attachment 130446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130446&action=edit Bug 20398 : Added a syspref to highlight or not highlight search terms in results on the staff interface There is a possibility on OPAC but not yet on the staff interface, so I added this syspref which has the same behaviour as the OPAC highlighting syspref. When you choose to disable highlighting on the syspref, the toggle anchor in the result page does not appear at all. But if you keep the default state (highlighting on), you still have the option to switch between "Unhighlight" and "Highlight" modes. Test plan : 1. Go to the syspref named "StaffHighlightedWords" and see that the default state is "Highlight". 2. Look for something in the catalogue for example and see that the words are highlighted and that it is also possible to change between "Unhighlight" and "Highlight". 3. Go back to syspref and choose to disable highlighting by choosing "Don't Highlight". 4. Refresh your results page if you have not closed it or reload a new search. 5. There is no highlighting at all and anchors do not exist (same behaviour as the OPAC interface). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 13:32:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 12:32:59 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #33 from Thibaud Guillot --- (In reply to e.betemps from comment #31) > (but the name of the syspref is 'StaffHighlightedWords') yes.. I saw that I forgot to change the name in my test plan with latest changes... this is fixed now, thanks for your feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 14:17:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 13:17:59 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|colin.campbell at ptfs-europe. |martin.renvoize at ptfs-europe |com |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 14:18:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 13:18:51 +0000 Subject: [Koha-bugs] [Bug 30069] New: Add edifact_messages to cleanup_database.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30069 Bug ID: 30069 Summary: Add edifact_messages to cleanup_database.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz We should add the ability to clean up old edifact messages with cleanup database. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 14:23:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 13:23:02 +0000 Subject: [Koha-bugs] [Bug 30070] New: There are performance issues with edifactmsgs when you have a large number of messages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Bug ID: 30070 Summary: There are performance issues with edifactmsgs when you have a large number of messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The edifact messages table can grow to a very large size over time, and the page to display them has issues with this growth as it always loads all messages. We should switch this to an ajax driven datatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 14:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 13:25:19 +0000 Subject: [Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 14:25:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 13:25:25 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 --- Comment #14 from Jonathan Druart --- Created attachment 130447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130447&action=edit Bug 29660: Fix conflict with bug 29844 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 14:43:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 13:43:16 +0000 Subject: [Koha-bugs] [Bug 30069] Add edifact_messages to cleanup_database.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30069 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 14:43:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 13:43:22 +0000 Subject: [Koha-bugs] [Bug 30070] There are performance issues with edifactmsgs when you have a large number of messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30070 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 14:46:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 13:46:56 +0000 Subject: [Koha-bugs] [Bug 30040] Patron attributes in self-registration should work with PatronSelfRegistrationVerifyByEmail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30040 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- The patron is not created in the borrowers table until the email verification link has been clicked. We need a place to store those authorised values temporarily. Perhaps an additional field in borrower_modifications to store the AV values as JSON temporarily. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:02:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:02:56 +0000 Subject: [Koha-bugs] [Bug 30072] New: Add more holds hooks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Bug ID: 30072 Summary: Add more holds hooks Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org We should add more plugin hooks. At least: - after_hold_fill - after_hold_cancel -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:03:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:03:27 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |andrew at bywatersolutions.com | |, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:03:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:03:56 +0000 Subject: [Koha-bugs] [Bug 30073] New: Information on installation of plugins missing from manual Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30073 Bug ID: 30073 Summary: Information on installation of plugins missing from manual Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Manual Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The chapter on the plugin system explains how to activate it and where to find specific sorts of plugins, but it doesn't explain how and where plugins are installed in the first place: https://koha-community.org/manual/21.11/en/html/plugins.html?highlight=plugin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:26:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:26:50 +0000 Subject: [Koha-bugs] [Bug 30074] New: Missing extended_attributes relationship in DBIC schema Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30074 Bug ID: 30074 Summary: Missing extended_attributes relationship in DBIC schema Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: REST API Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: tomascohen at gmail.com REST API route /patrons has extended_attributes available (x-koha-embed) but it's actually not working. GET /api/v1/patrons: unhandled exception (Koha::Exceptions::BadParameter)<> Koha::REST::Plugin::Exceptions::__ANON__ /kohadevbo x/koha/Koha/REST/Plugin/Exceptions.pm (73) It's missing the relationship named "extended_attributes". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:27:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:27:10 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:27:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:27:18 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30074 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30074 [Bug 30074] Missing extended_attributes relationship in DBIC schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:27:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:27:18 +0000 Subject: [Koha-bugs] [Bug 30074] Missing extended_attributes relationship in DBIC schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30074 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:29:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:29:25 +0000 Subject: [Koha-bugs] [Bug 30074] Missing extended_attributes relationship in DBIC schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30074 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:29:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:29:29 +0000 Subject: [Koha-bugs] [Bug 30074] Missing extended_attributes relationship in DBIC schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30074 --- Comment #1 from Jonathan Druart --- Created attachment 130448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130448&action=edit Bug 30074: Add missing extended_attributes rs in DBIC schema REST API route /patrons has extended_attributes available (x-koha-embed) but it's actually not working. GET /api/v1/patrons: unhandled exception (Koha::Exceptions::BadParameter)<> Koha::REST::Plugin::Exceptions::__ANON__ /kohadevbo x/koha/Koha/REST/Plugin/Exceptions.pm (73) It's missing the relationship named "extended_attributes". Test plan: Create a new patron attribute CODE and a value for a patron Hit /api/v1/patrons?q={"extended_attributes.type":"CODE"} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:29:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:29:53 +0000 Subject: [Koha-bugs] [Bug 30074] Missing extended_attributes relationship in DBIC schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30074 --- Comment #2 from Jonathan Druart --- A test would be nice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:30:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:30:21 +0000 Subject: [Koha-bugs] [Bug 28473] Add REST endpoint for searching extended patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #1) > It is a good idea. > > Remember there's the possibility to search patrons with x-koha-embed: > extended_attributes, and then filter by extended_attributes.type using the > q= parameter It's not working, you will need bug 30074. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:37:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:37:56 +0000 Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:37:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:37:59 +0000 Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 --- Comment #1 from Nick Clemens --- Created attachment 130449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130449&action=edit Bug 29755: Check each NoIssuesCharge separately This patch updates SIP patron code to use account methods to calculate balances over the patronflags returns. It also checks if patron should be blocked for each 'No Issues charge' preference Tests are added for NoIssuesChargeGuarantees To test: 1 - Set noissuescharge preference to 5 2 - Add a $10 charge to a patron 3 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron BARCODE 4 - Note the 64 message starts with Y's that mean patron is blocked 5 - Set noissuescharge to 11 6 - Repeat 3, patron is no longer blocked 7 - Set NoIssuesChargeGuarantees to 8 8 - Repeat 3, patron is blocked 9 - Pay $3 on patron so they owe 7 10 - Repeat 3, patron is not blocked 11 - Add a child account with patron as guarantor 12 - Repeat 3, patron is not blocked 13 - Add a $4 charge to child 14 - Repeat 3, patron is blocked 15 - Repeat 3, but with child barcode, child is not blocked 16 - Set NoIssuesChargeGuarantorsWithGuarantees to 11 17 - Repeat 3, patron is blocked 18 - Repeat 3 with child barcode, child is blocked -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:38:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:38:10 +0000 Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 15:42:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 14:42:23 +0000 Subject: [Koha-bugs] [Bug 30075] New: We should centralize No issues charge code in Patron object Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30075 Bug ID: 30075 Summary: We should centralize No issues charge code in Patron object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We have several places in the code where we fetch the no issues charge preferences and calculate amount owed by patron and/or guarantees and/or related guarantors This should all be a single method in Koha::Patron which returns: relevant amount(s) owed whether patron is blocked by fines the reason patron is blocked (their fines, guarantees fines, all related fines) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 16:00:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 15:00:17 +0000 Subject: [Koha-bugs] [Bug 30068] Wrong reference to table_borrowers in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 --- Comment #1 from Nick Clemens --- olumns_settings_borrowers_table = [% TablesSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] This is just fetching the settings from the yaml, they are only applied to "#table_borrowers" in circ-patron-search-results.js The table_borrowers that shows items is simply a class on the itemSearchFallBack table - this class is not referenced anywhere so can simply be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 16:22:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 15:22:02 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 --- Comment #3 from Marcel de Rooy --- Line number may vary: Use of uninitialized value in string ne at /usr/share/koha/Koha/Item.pm line 169 if ( exists $updated_columns{location} - and $self->location ne 'CART' - and $self->location ne 'PROC' - and $self->location ne 'MOVE' # RMA + and ( !defined($self->location) or $self->location !~ /^(CART|PROC)$/ ) and not exists $updated_columns{permanent_location} ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 16:25:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 15:25:33 +0000 Subject: [Koha-bugs] [Bug 28781] Elasticsearch facets may be inaccurate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28781 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 16:39:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 15:39:00 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130446|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 130450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130450&action=edit Bug 20398 : Added a syspref to highlight or not highlight search terms in results on the staff interface There is a possibility on OPAC but not yet on the staff interface, so I added this syspref which has the same behaviour as the OPAC highlighting syspref. When you choose to disable highlighting on the syspref, the toggle anchor in the result page does not appear at all. But if you keep the default state (highlighting on), you still have the option to switch between "Unhighlight" and "Highlight" modes. Test plan : 1. Go to the syspref named "StaffHighlightedWords" and see that the default state is "Highlight". 2. Look for something in the catalogue for example and see that the words are highlighted and that it is also possible to change between "Unhighlight" and "Highlight". 3. Go back to syspref and choose to disable highlighting by choosing "Don't Highlight". 4. Refresh your results page if you have not closed it or reload a new search. 5. There is no highlighting at all and anchors do not exist (same behaviour as the OPAC interface). Signed-off-by: ManuB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 16:45:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 15:45:40 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54539|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 130451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130451&action=edit Bug 16258 Add a syspref to govern EDIFACT functionality Adds an "Edifact" systempreference to govern whether edifact processing is enabled. In most places this is hidden if the current vendor does not appear in the edi vendors table. This preference hides the admin screens which define this and a couple of links. Also fixes an anomaly whereby the basketgroup screen was not making the same check on whether edi ordering should be enabled as the basket screen. Both now use the same logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 16:47:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 15:47:19 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.11 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com --- Comment #19 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 16:49:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 15:49:31 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #9 from Andrew Fuerste-Henry --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:07:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:07:35 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:07:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:07:38 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #4 from Lucas Gass --- Created attachment 130452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130452&action=edit Bug 29887: (follow-up) show all branches to non superlibraians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:11:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:11:27 +0000 Subject: [Koha-bugs] [Bug 30064] Dates in issues table on subscriptions tab in OPAC are not sorting correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30064 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:20:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:20:53 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130451|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 130453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130453&action=edit Bug 16258 Add a syspref to govern EDIFACT functionality Adds an "Edifact" systempreference to govern whether edifact processing is enabled. In most places this is hidden if the current vendor does not appear in the edi vendors table. This preference hides the admin screens which define this and a couple of links. Also fixes an anomaly whereby the basketgroup screen was not making the same check on whether edi ordering should be enabled as the basket screen. Both now use the same logic. Rebased-by: Mark Tompsett Rebased-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:20:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:20:56 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 --- Comment #15 from Martin Renvoize --- Created attachment 130454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130454&action=edit Bug 16258: (follow-up) Handle admin-menu.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:22:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:22:09 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:23:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:23:50 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 --- Comment #16 from Martin Renvoize --- Created attachment 130455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130455&action=edit Bug 16258: (follow-up) Handle 'Create EDIFACT order' button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:24:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:24:10 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54567|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:24:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:24:40 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 --- Comment #17 from Martin Renvoize --- Brought this back up to date and fixed the issues mentioned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:35:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:35:29 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #26 from Martin Renvoize --- I'm on board too, great work Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:44:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:44:33 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #48 from Andrew Fuerste-Henry --- I'm getting a qa failure after applying these to 21.05. Should this maybe depend on bug 28588? Please rebase for backport to 21.05 if possible. Thanks! Here's the error I got: FAIL t/db_dependent/Koha/Checkouts/ReturnClaim.t FAIL valid Version control conflict marker Version control conflict marker Type of arg 1 to Test::Exception::throws_ok must be block or sub {} (not reference constructor) Type of arg 1 to Test::Exception::throws_ok must be block or sub {} (not reference constructor) Type of arg 1 to Test::Exception::throws_ok must be block or sub {} (not reference constructor) Version control conflict marker t/db_dependent/Koha/Checkouts/ReturnClaim.t had compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:50:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:50:11 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #88 from Martin Renvoize --- Created attachment 130456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130456&action=edit Documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:54:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:54:17 +0000 Subject: [Koha-bugs] [Bug 30003] Register entries doubled up if form fails validation on first submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 17:58:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 16:58:48 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | --- Comment #11 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 18:00:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 17:00:41 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch corrects an release notes| |issue with the Holds to | |Pull report in which an | |incorrect barcode number | |could be shown for an | |item-level hold. The | |correct barcode will now be | |shown. CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 18:00:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 17:00:48 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 18:13:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 17:13:51 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #27 from Jonathan Druart --- Created attachment 130457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130457&action=edit Bug 30055: Put extended attributes search back Last patches remove the ability to search on extended attributes. C4::Utils::DataTables::Members::search is searching on all the attributes that are flagged as "searchable", we want to keep this behaviour. I have tried several things and this is the simplest I have found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 18:14:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 17:14:06 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 18:18:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 17:18:54 +0000 Subject: [Koha-bugs] [Bug 30076] New: Add ability to check patron messaging preferences from a notice Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076 Bug ID: 30076 Summary: Add ability to check patron messaging preferences from a notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries want to be able to use a patron's messaging preferences to conditionally change the contents of a notice depending on the patron's other messaging preference. For example, a library has requested to have the note on the hold slip if the patron has requested phone messages for waiting holds. This really only entails adding a method to the Koha::Patron class to allow this type of looking. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 18:19:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 17:19:39 +0000 Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging preferences from a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 18:23:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 17:23:11 +0000 Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging preferences from a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 18:23:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 17:23:14 +0000 Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging preferences from a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076 --- Comment #1 from Kyle M Hall --- Created attachment 130458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130458&action=edit Bug 30076: Add ability to check patron messaging preferences from a notice Some libraries want to be able to use a patron's messaging preferences to conditionally change the contents of a notice depending on the patron's other messaging preference. For example, a library has requested to have the note on the hold slip if the patron has requested phone messages for waiting holds. This really only entails adding a method to the Koha::Patron class to allow this type of looking. Test plan: 1) Apply this patch 2) Enable item checkout notices for a patron for email, but not sms 3) Include the following in the notice: TEST1: [% patron.has_messaging_preference({ message_name => 'Item_Checkout', message_transport_type => 'email' }) %]
TEST2: [% patron.has_messaging_preference({ message_name => 'Item_Checkout', message_transport_type => 'sms' }) %] 4) Generate a checkout and notice for that patron 5) Note the generated notice has a 1 for TEST1, but not for TEST2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 18:39:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 17:39:22 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a new release notes| |system preference | |StaffHghlightWords. This | |enables highlighting of | |words in search results for | |the staff interface to be | |turned on or off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 18:43:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 17:43:05 +0000 Subject: [Koha-bugs] [Bug 28854] [ALTERNATIVE] Add ability to create bundles of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #89 from David Nind --- Thanks Martin for creating the documentation! I will have a go at testing over the weekend, unless someone beats me to it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 19:20:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 18:20:30 +0000 Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging preferences from a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 19:47:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 18:47:42 +0000 Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging preferences from a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130458|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 130459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130459&action=edit Bug 30076: Add ability to check patron messaging preferences from a notice Some libraries want to be able to use a patron's messaging preferences to conditionally change the contents of a notice depending on the patron's other messaging preference. For example, a library has requested to have the note on the hold slip if the patron has requested phone messages for waiting holds. This really only entails adding a method to the Koha::Patron class to allow this type of looking. Test plan: 1) Apply this patch 2) Enable item checkout notices for a patron for email, but not sms 3) Include the following in the notice: TEST1: [% borrower.has_messaging_preference({ message_name => 'Item_Checkout', message_transport_type => 'email' }) %]
TEST2: [% borrower.has_messaging_preference({ message_name => 'Item_Checkout', message_transport_type => 'sms' }) %] 4) Generate a checkout and notice for that patron 5) Note the generated notice has a 1 for TEST1, but not for TEST2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 19:57:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 18:57:13 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #49 from Tomás Cohen Arazi --- Created attachment 130460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130460&action=edit [21.05.x] Bug 29495: Unit Tests Test plan 1. Run updated tests prior to applying new patches.. pass 2. Run updated tests after applying new patches.. pass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 19:57:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 18:57:17 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #50 from Tomás Cohen Arazi --- Created attachment 130461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130461&action=edit [21.05.x] Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 19:57:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 18:57:22 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #51 from Tomás Cohen Arazi --- Created attachment 130462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130462&action=edit [21.05.x] Bug 29495: DBIC Schema Rebuild Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 19:57:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 18:57:28 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #52 from Tomás Cohen Arazi --- Created attachment 130463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130463&action=edit [21.05.x] Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 19:57:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 18:57:33 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #53 from Tomás Cohen Arazi --- Created attachment 130464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130464&action=edit [21.05.x] Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 19:57:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 18:57:37 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #54 from Tomás Cohen Arazi --- Created attachment 130465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130465&action=edit [21.05.x] Bug 29495: Update relationship methods This patch updates the relationship methods found in Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on the API. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 19:57:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 18:57:43 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #55 from Tomás Cohen Arazi --- Created attachment 130466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130466&action=edit [21.05.x] Bug 29495: (follow-up) Use 'item' relationship This patch adds the missing 'item' relationship in Checkouts::ReturnClaim and then uses it from the resolve method. This improve the reliability of the resolution code so it works when the item has already been checked in (without having to check Old::Checkouts). Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 19:57:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 18:57:48 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #56 from Tomás Cohen Arazi --- Created attachment 130467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130467&action=edit [21.05.x] Bug 29495: Fix TestBuilder.t Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 387. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:03:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:03:54 +0000 Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging preferences from a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:03:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:03:58 +0000 Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging preferences from a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130459|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 130468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130468&action=edit Bug 30076: Add ability to check patron messaging preferences from a notice Some libraries want to be able to use a patron's messaging preferences to conditionally change the contents of a notice depending on the patron's other messaging preference. For example, a library has requested to have the note on the hold slip if the patron has requested phone messages for waiting holds. This really only entails adding a method to the Koha::Patron class to allow this type of looking. Test plan: 1) Apply this patch 2) Enable item checkout notices for a patron for email, but not sms 3) Include the following in the notice: TEST1: [% borrower.has_messaging_preference({ message_name => 'Item_Checkout', message_transport_type => 'email' }) %]
TEST2: [% borrower.has_messaging_preference({ message_name => 'Item_Checkout', message_transport_type => 'sms' }) %] 4) Generate a checkout and notice for that patron 5) Note the generated notice has a 1 for TEST1, but not for TEST2 Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:07:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:07:45 +0000 Subject: [Koha-bugs] [Bug 30076] Add ability to check patron messaging preferences from a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30076 --- Comment #4 from Lucas Gass --- This is cool. It also works well in other notices with different message_names. I tried: Hold_filled Item_check-in Item_checkout Auto_renewal Hold_reminder Tested in these notices: CHECKOUT CHECKIN HOLD_SLIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:11:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:11:19 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:11:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:11:23 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129583|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 130469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130469&action=edit Bug 29385: Catch register_id for payments against fees This patch refactors the pay method in SIP FeePayment such that we consistently pass parameters to both invocations of Koha::Account->pay. It ensure the missing cash_register definition is passed when a set of account lines to pay is defined. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:35:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:35:49 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130453|0 |1 is obsolete| | Attachment #130454|0 |1 is obsolete| | Attachment #130455|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 130470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130470&action=edit Bug 16258: Add a syspref to govern EDIFACT functionality Adds an "Edifact" systempreference to govern whether edifact processing is enabled. In most places this is hidden if the current vendor does not appear in the edi vendors table. This preference hides the admin screens which define this and a couple of links. Also fixes an anomaly whereby the basketgroup screen was not making the same check on whether edi ordering should be enabled as the basket screen. Both now use the same logic. Rebased-by: Mark Tompsett Rebased-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:36:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:36:01 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 --- Comment #19 from Kyle M Hall --- Created attachment 130471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130471&action=edit Bug 16258: (follow-up) Handle admin-menu.inc Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:36:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:36:05 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 --- Comment #20 from Kyle M Hall --- Created attachment 130472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130472&action=edit Bug 16258: (follow-up) Handle 'Create EDIFACT order' button Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:36:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:36:08 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 --- Comment #21 from Kyle M Hall --- Created attachment 130473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130473&action=edit Bug 16258: (QA follow-up) Add a guard to the cron script Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:36:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:36:12 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 --- Comment #22 from Kyle M Hall --- Created attachment 130474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130474&action=edit Bug 16258: (QA follow-up) Don't set to off for existing install, they may be using EDI Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:36:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:36:15 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 --- Comment #23 from Kyle M Hall --- Created attachment 130475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130475&action=edit Bug 16258: (QA follow-up) Include Koha plugin for basket.tt Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 20:37:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 19:37:17 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 21:27:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 20:27:50 +0000 Subject: [Koha-bugs] [Bug 3142] Standardize how OPAC and staff determine requestability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.11 released in| | CC| |andrew at bywatersolutions.com --- Comment #68 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 21:47:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 20:47:18 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | --- Comment #11 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.11 I also backported 3142, which is seemed like this might require. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 21:54:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 20:54:47 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121717|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 130476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130476&action=edit Bug 27265: Enable message queue cron to accept multiple codes and types It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines Test Plan: 1) Apply this patch 2) Run process_message_queue.pl with a single -c parameter 3) Note behavior is unchanged 4) Run process_message_queue.pl with multiple -c parameters 5) Note all the codes specified are processed 6) Repeat 2-5 with -t for type limits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 22:21:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 21:21:03 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual-updated CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 22:50:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 21:50:07 +0000 Subject: [Koha-bugs] [Bug 22789] Establish non-priority holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Keywords| |Manual-updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 22:56:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 21:56:02 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 22:57:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 21:57:24 +0000 Subject: [Koha-bugs] [Bug 30077] New: Add option for library dropdown in search function for staff interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Bug ID: 30077 Summary: Add option for library dropdown in search function for staff interface Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The functionality of OpacAddMastheadLibraryPulldown would be helpful to have on the staff interface. Often staff need to limit their search a specific library, without having to go to the advanced search. This would be an excellent addition, and by default, should limit to the library you are logged in to, with the option via the dropdown to search all libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 22:57:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 21:57:27 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #28 from Fridolin Somers --- Great enhancement, more API \o/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 22:57:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 21:57:55 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 10 23:52:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 22:52:29 +0000 Subject: [Koha-bugs] [Bug 27607] Add the ability to compare patron records during merge process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27607 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual-updated CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 00:34:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 23:34:34 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #25 from Andrew Nugged --- I agree it's a very messy and huge template so it's easy to lose variables :)... That's why hivemind is needed. switching the ticket to "Failed QA": I am adding some more lost fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 00:36:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 23:36:34 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 00:45:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 23:45:10 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 00:45:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 23:45:14 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #26 from Andrew Nugged --- Created attachment 130477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130477&action=edit Bug 29684: (QA follow-up) add lost borrower_data. prefix in memberentrygen.tt for: - primary_contact_method - autorenew_checkouts - sort1 - sort2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 00:47:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 23:47:41 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #27 from Andrew Nugged --- umph! It's a complicated thing - we have interleaved usage of "patron." for some elements (for a reason?) in memberentrygen.tt, I at least re-checked once more all variables, might miss even, but found +4 more lost (patch above). I propose to re-do "Sign Off" once more, but Fridolin/Jonathan: you say? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 00:49:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 23:49:32 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #1 from Lucas Gass --- Created attachment 130478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130478&action=edit Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 00:52:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 23:52:22 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Lucas Gass --- I setting this to ASSIGNED and not NSO because I have a couple questions: 1. If by default it sets the limit to the logged in branch and you do a search at a different branch, should the limiter then be set to the branch you just searched or still your logged in branch? 2. Does these need to account for IndependentBranches? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 00:55:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Feb 2022 23:55:50 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #10 from Fridolin Somers --- Thanks a lot Owen. This template looks a looooot more clear now ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:00:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:00:24 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Keywords| |release-notes-needed --- Comment #22 from Fridolin Somers --- This long time wanted enhancement needs a good release note ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:06:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:06:43 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Passed QA |Pushed to master --- Comment #19 from Fridolin Somers --- (In reply to Tomás Cohen Arazi from comment #18) > Back to the RM queue. > > Fridolin: the last two patches are missing in master. Thanks! Done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:19:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:19:04 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Created attachment 130479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130479&action=edit Screenshot with patch Indeed it works after a refresh of browser cache. Here is a screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:26:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:26:23 +0000 Subject: [Koha-bugs] [Bug 29224] OMNIBUS: Replace the use of jQueryUI Accordion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- For 'Tools -> Notices' it should be better to use tabs no ? The values are limited to email, print, SMS and phone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:26 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:29 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 --- Comment #23 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:32 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:35 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:38 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:40 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #47 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:43 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:45 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #17 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:48 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:50 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:52 +0000 Subject: [Koha-bugs] [Bug 29832] Make library column in desk list sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:55 +0000 Subject: [Koha-bugs] [Bug 29832] Make library column in desk list sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:57 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:37:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:37:59 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #43 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:38:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:38:02 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:38:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:38:04 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #11 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:38:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:38:06 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:38:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:38:08 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:38:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:38:10 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:38:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:38:13 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #31 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:38:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:38:15 +0000 Subject: [Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:38:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:38:18 +0000 Subject: [Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:38:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:38:20 +0000 Subject: [Koha-bugs] [Bug 29984] Remove unused method Koha::Patrons->anonymise_issue_history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29984 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:38:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:38:22 +0000 Subject: [Koha-bugs] [Bug 29984] Remove unused method Koha::Patrons->anonymise_issue_history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29984 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:51:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:51:23 +0000 Subject: [Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin Somers --- + my @object_messages = @{ $updated_item->messages }; I think this needs to be adapted since Bug 29785 is pushed. Check if there are other impacts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 01:51:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 00:51:33 +0000 Subject: [Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 08:04:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 07:04:01 +0000 Subject: [Koha-bugs] [Bug 30037] Set Default Profile when staging MARC notices on import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 08:07:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 07:07:40 +0000 Subject: [Koha-bugs] [Bug 30029] XSLT can chop off too much punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30029 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28976 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 08:07:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 07:07:40 +0000 Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30029 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 08:08:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 07:08:33 +0000 Subject: [Koha-bugs] [Bug 30029] XSLT can chop off too much punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30029 --- Comment #1 from Fridolin Somers --- Maybe fixed by Bug 28976 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 08:13:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 07:13:30 +0000 Subject: [Koha-bugs] [Bug 29978] System preferences messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29978 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |INVALID --- Comment #7 from Fridolin Somers --- viva Mozilla ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 08:14:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 07:14:38 +0000 Subject: [Koha-bugs] [Bug 29964] SMTP server list not populating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- Can you try with Mozilla Firefox please ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 08:17:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 07:17:24 +0000 Subject: [Koha-bugs] [Bug 29938] Allow a secondary database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29938 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 08:23:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 07:23:36 +0000 Subject: [Koha-bugs] [Bug 29964] SMTP server list not populating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 --- Comment #3 from Father Vlasie --- Thank you for looking at this issue! It does not work in Firefox either... The browser console contains these messages: /api/v1/config/smtp_servers?_page=1&_per_page=20&q=%5B%5D&_match=contains&_order_by=%2Bme.name:1 Failed to load resource: the server responded with a status of 404 (Not Found) datatables_21.1101000.js:515 DataTables warning: table id=smtp_servers - Ajax error. For more information about this error, please see http://datatables.net/tn/7 jQuery.fn.dataTable.ext.errMode @ datatables_21.1101000.js:515 K @ datatables.min_21.1101000.js:113 error @ datatables.min_21.1101000.js:74 i @ jquery-2.2.3.min_21.1101000.js:2 fireWith @ jquery-2.2.3.min_21.1101000.js:2 z @ jquery-2.2.3.min_21.1101000.js:4 (anonymous) @ jquery-2.2.3.min_21.1101000.js:4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 09:16:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 08:16:28 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 --- Comment #10 from Jonathan Druart --- Created attachment 130480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130480&action=edit Bug 29859: (follow-up) Use iterator instead of as_list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 09:16:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 08:16:45 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 09:17:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 08:17:17 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #43 from Jonathan Druart --- Created attachment 130481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130481&action=edit Bug 29844: Fix selenium/administration_tasks.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 09:17:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 08:17:41 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 09:55:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 08:55:21 +0000 Subject: [Koha-bugs] [Bug 30068] Wrong reference to table_borrowers in circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |koha-bugs at lists.koha-commun |com |ity.org Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 10:24:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 09:24:54 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 --- Comment #11 from Jonathan Druart --- Created attachment 130483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130483&action=edit Bug 29859: Fix currencies display Oops! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 11:30:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 10:30:22 +0000 Subject: [Koha-bugs] [Bug 30078] New: Holds to pull list does not show available item if already another item on pickup shelf Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30078 Bug ID: 30078 Summary: Holds to pull list does not show available item if already another item on pickup shelf Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: minna.kivinen at hamk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Holds to pull list does not show available item, if there already is another item in that library waiting for pickup. Steps to get the problem: 1. Make sure that your circulation rules allow holds to available items 2. Make two holds for a book to library A where there are more than one available items 3. Check in one item and confirm hold -> item is now in pick up shelf 4. Look at holds to pull list - library A does not show on holds to pull list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 11:35:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 10:35:09 +0000 Subject: [Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130027|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 130484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130484&action=edit Bug 26704: Update Koha::Item to use Koha::Object::Messages Use the newly introduced Koha::Object::Messages system to pass additional information provided by object methods internally in the objects themselves. This patch updates the existing bespoke passing scheme to something we've formally agreed to adopt going forward. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 11:35:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 10:35:13 +0000 Subject: [Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130028|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 130485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130485&action=edit Bug 26704: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 11:35:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 10:35:17 +0000 Subject: [Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 --- Comment #17 from Martin Renvoize --- Created attachment 130486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130486&action=edit Bug 26704: (follow-up) Rebase for bug 29785 Update newly introduced calls from '->messages' to '->object_messages' Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 11:35:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 10:35:56 +0000 Subject: [Koha-bugs] [Bug 26704] Koha::Item store triggers should utilise Koha::Object::Messages for message passing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26704 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #18 from Martin Renvoize --- Rebased and follow-up added to take account of bug 29785. Ready for push :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:14:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:14:44 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:14:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:14:45 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 Bug 29847 depends on bug 29844, which changed state. Bug 29844 Summary: Remove uses of wantarray in Koha::Objects https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:14:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:14:45 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Bug 29859 depends on bug 29844, which changed state. Bug 29844 Summary: Remove uses of wantarray in Koha::Objects https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:14:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:14:45 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Bug 30055 depends on bug 29844, which changed state. Bug 29844 Summary: Remove uses of wantarray in Koha::Objects https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:15:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:15:19 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:17:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:17:15 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:20:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:20:40 +0000 Subject: [Koha-bugs] [Bug 30045] SCO print slip is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30045 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:23:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:23:33 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | --- Comment #9 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:24:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:24:59 +0000 Subject: [Koha-bugs] [Bug 29933] Fix stray usage of jquery.cookie.js plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:26:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:26:58 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #21 from Kyle M Hall --- It this does need backported, please let me know! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:26:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:26:58 +0000 Subject: [Koha-bugs] [Bug 27750] Remove jquery.cookie.js plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750 Bug 27750 depends on bug 11873, which changed state. Bug 11873 Summary: Upgrade jstree jQuery plugin to the latest version https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:26:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:26:58 +0000 Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Bug 29155 depends on bug 11873, which changed state. Bug 11873 Summary: Upgrade jstree jQuery plugin to the latest version https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:26:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:26:59 +0000 Subject: [Koha-bugs] [Bug 29940] Phase out jquery.cookie.js in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 Bug 29940 depends on bug 11873, which changed state. Bug 11873 Summary: Upgrade jstree jQuery plugin to the latest version https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:29:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:29:02 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #29 from Martin Renvoize --- Hmm, right now I'm getting 404's on the API requests in my testing.. continuing to investigate. Couple of comments to get us started though.. * It might be nice to enable `"header_filter": true,` on the kohaTable.. the URL's are pretty crazy to read without it. * Was it a deliberate choice to use 'add_filters'.. for the guarantor search at least, this is a change and I'm not sure it makes sense to have the both sets of filters visible at the same time in the popup window? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:33:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:33:19 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #30 from Martin Renvoize --- Also, could we get a little update for the jsdoc for kohaTable for the changes/enhancements you've made.. especially the signature update for default_filters? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:37:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:37:30 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #21 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:39:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:39:44 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:40:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:40:10 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 12:58:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 11:58:49 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #22 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:00:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:00:07 +0000 Subject: [Koha-bugs] [Bug 29966] SCO Help page passes flags while not needing authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:01:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:01:34 +0000 Subject: [Koha-bugs] [Bug 29754] Patron fines counted twice for SIP when NoIssuesChargeGuarantorsWithGuarantees is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29754 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:04:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:04:05 +0000 Subject: [Koha-bugs] [Bug 27904] Improve display in creating profile for staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27904 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:04:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:04:28 +0000 Subject: [Koha-bugs] [Bug 28993] Switch magnifying glass in staff detail pages to FA icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:04:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:04:48 +0000 Subject: [Koha-bugs] [Bug 29767] Add cash registers, debit and credit types to report runtime parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:05:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:05:14 +0000 Subject: [Koha-bugs] [Bug 30079] New: Add missing documentation to kohaTable api wrapper Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30079 Bug ID: 30079 Summary: Add missing documentation to kohaTable api wrapper Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org There are some additional hidden options that we don't yet document. "header_filter" and "embed" for example.. there may be more. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:05:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:05:25 +0000 Subject: [Koha-bugs] [Bug 30079] Add missing documentation to kohaTable api wrapper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30079 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:11:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:11:10 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #31 from Jonathan Druart --- Created attachment 130487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130487&action=edit Bug 30055: Add missing spec file for baskets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:17:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:17:12 +0000 Subject: [Koha-bugs] [Bug 30080] New: OPACFineNoRenewalsIncludeCredits does not seem to work as indicated Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30080 Bug ID: 30080 Summary: OPACFineNoRenewalsIncludeCredits does not seem to work as indicated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: andrew at bywatersolutions.com, gmcharlt at gmail.com, jzairo at bywatersolutions.com This system preference: OPACFineNoRenewalsIncludeCredits has two options, Include/Don't Include. According to the manual, this preference controls whether the OPACFineNoRenewals function uses the account balance or account amount outstanding (which excludes any credits) to make the calculation. Test Plan. 1. Set OPACNOFineNoRenewals to $5 2. Have a patron with a Credit on their account of $20 but also have this patron have fines of $7, therefore the patron should have a $13 credit. 3.Set the system preference OPACFineNoRenewalsIncludeCredits to Include. 4. Attempt to renew an item from the OPAC. Koha says, the patron owes $7 and can't renew- Koha is not taking into account this system preference- as the patron should be able to renew because they have a credit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:18:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:18:29 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #32 from Jonathan Druart --- Created attachment 130488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130488&action=edit Bug 30055: Fix when there is no searchable attr type No idea why we need that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:24:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:24:50 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #57 from Andrew Fuerste-Henry --- Thanks for the 21.05 patches, Tomas! You did not make a 21.05 version of the "Add relationship tests" patch. The merge errors on that one seemed pretty simple to clear, so I'm not sure what's the source of the qa error I'm getting now (with all of your 21.05 patches and the regular version of Add Relationship Tests): root at kohadevbox:koha(rmain2105)$ qa -c 9 -v 2 testing 9 commit(s) (applied to 774e847 '94 Bug 29804: Fix Koha::Hold->is_pick') Processing files before patches |========================>| 7 / 7 (100.00%) Processing files after patches |========================>| 7 / 7 (100.00%) OK Koha/Checkouts/ReturnClaim.pm OK Koha/Schema/Result/Issue.pm OK Koha/Schema/Result/OldIssue.pm OK Koha/Schema/Result/ReturnClaim.pm OK installer/data/mysql/kohastructure.sql FAIL t/db_dependent/Koha/Checkouts/ReturnClaim.t FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use t/db_dependent/Koha/Checkouts/ReturnClaim.t had compilation errors. OK t/lib/TestBuilder.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:28:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:28:13 +0000 Subject: [Koha-bugs] [Bug 22115] Table of checkouts doesn't respect CurrencyFormat setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22115 --- Comment #3 from Jonathan Druart --- We already have koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc: Number.prototype.format_price = function( value, params ) { -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:31:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:31:29 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | CC| |andrew at bywatersolutions.com --- Comment #10 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:53:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:53:35 +0000 Subject: [Koha-bugs] [Bug 30081] New: Display item type in patron's holds table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 Bug ID: 30081 Summary: Display item type in patron's holds table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Add new column item type to holds table in patron's details and check out views. Some libraries will find this information useful for distinguishing inter library holds from normal holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:54:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:54:32 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 13:54:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 12:54:35 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 --- Comment #9 from Owen Leonard --- Created attachment 130489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130489&action=edit Bug 29960: (follow-up) Include enquire.js in print slip template This patch adds enquire.js to the print slip template in order to prevent a JS error. Also removed is a line from global.js which was added in the previous patch and which was an unwanted change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:01:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:01:03 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 --- Comment #1 from Lari Taskula --- Created attachment 130490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130490&action=edit Bug 30081: Add item type column to holds table Add new column item type to holds table in patron's details and check out views. Some libraries will find this information useful for distinguishing inter library holds from normal holds. To test: 1. Apply patch 2. Place a hold and confirm it 3. Go to cgi-bin/koha/circ/circulation.pl?borrowernumber=1 with borrowernumber being the id of your patron 4. Click "1 Hold(s)" tab 5. Observe new column "Item type" 6. Confirm the item type is correct 7. Go to moremember.pl?borrowernumber=1 with borrowernumber being the id of your patron 8. Repeat steps 4-6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:05:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:05:23 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch updates release notes| |authorized values | |management to add the | |option of specifying a | |remote image to be | |associated with an | |authorized value. This | |functionality matches what | |was already available for | |item types: The ability to | |specify a full URL to an | |image file. Modifying a | |collection code with a | |remote image will make the | |image visible on catalog | |advanced search pages in | |the OPAC and staff | |interface when the option | |to select a collection is | |enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:07:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:07:30 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #33 from Jonathan Druart --- Created attachment 130491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130491&action=edit Bug 30055: Missing search on othernames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:08:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:08:15 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:08:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:08:54 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:08:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:08:57 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 --- Comment #2 from Lari Taskula --- Created attachment 130492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130492&action=edit Bug 30081: Use itemtype description instead of itemtype code To test: 1. Use same plan as previous patch, but observe full item type description instead of item type code -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:09:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:09:40 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:13:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:13:22 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:13:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:13:22 +0000 Subject: [Koha-bugs] [Bug 29821] Add interface for generating barcodes using svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29821 Bug 29821 depends on bug 20894, which changed state. Bug 20894 Summary: Add barcode size parameters to /svc/barcode https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:14:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:14:59 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:15:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:15:03 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130490|0 |1 is obsolete| | Attachment #130492|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 130493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130493&action=edit Bug 30081: Add item type column to holds table Add new column item type to holds table in patron's details and check out views. Some libraries will find this information useful for distinguishing inter library holds from normal holds. To test: 1. Apply patch 2. Place a hold and confirm it 3. Go to cgi-bin/koha/circ/circulation.pl?borrowernumber=1 with borrowernumber being the id of your patron 4. Click "1 Hold(s)" tab 5. Observe new column "Item type" 6. Confirm the item type is correct 7. Go to moremember.pl?borrowernumber=1 with borrowernumber being the id of your patron 8. Repeat steps 4-6 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:15:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:15:07 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 --- Comment #4 from Owen Leonard --- Created attachment 130494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130494&action=edit Bug 30081: Use itemtype description instead of itemtype code To test: 1. Use same plan as previous patch, but observe full item type description instead of item type code Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:17:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:17:39 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:17:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:17:40 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Bug 29525 depends on bug 29780, which changed state. Bug 29780 Summary: Add Koha::Old::Holds->anonymize https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:18:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:18:00 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:18:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:18:01 +0000 Subject: [Koha-bugs] [Bug 17728] Move C4::Reserves code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 Bug 17728 depends on bug 29869, which changed state. Bug 29869 Summary: Add Koha::Hold->fill https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:18:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:18:01 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Bug 29868 depends on bug 29869, which changed state. Bug 29869 Summary: Add Koha::Hold->fill https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:18:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:18:01 +0000 Subject: [Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Bug 29874 depends on bug 29869, which changed state. Bug 29869 Summary: Add Koha::Hold->fill https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:18:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:18:01 +0000 Subject: [Koha-bugs] [Bug 29891] Add Koha::Holds->fix_priorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29891 Bug 29891 depends on bug 29869, which changed state. Bug 29869 Summary: Add Koha::Hold->fill https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:18:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:18:20 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:18:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:18:20 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Bug 29525 depends on bug 29868, which changed state. Bug 29868 Summary: Add Koha::Old::Hold->anonymize https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:19:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:19:17 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:19:18 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Bug 29526 depends on bug 29525, which changed state. Bug 29525 Summary: Privacy settings for patrons should also affect holds history https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:19:18 +0000 Subject: [Koha-bugs] [Bug 29879] Make sure objects moved to old_* is not tried to be saved again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29879 Bug 29879 depends on bug 29525, which changed state. Bug 29525 Summary: Privacy settings for patrons should also affect holds history https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:20:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:20:08 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 --- Comment #5 from Lari Taskula --- That has to be the quickest sign-off I've seen in all these years :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:21:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:21:59 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:22:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:22:00 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Bug 29843 depends on bug 29526, which changed state. Bug 29526 Summary: Add 'Immediately delete holds history' button to patron privacy tab in opac https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:24:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:24:27 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:24:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:24:28 +0000 Subject: [Koha-bugs] [Bug 29984] Remove unused method Koha::Patrons->anonymise_issue_history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29984 Bug 29984 depends on bug 29843, which changed state. Bug 29843 Summary: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:24:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:24:28 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Bug 30007 depends on bug 29843, which changed state. Bug 29843 Summary: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:24:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:24:28 +0000 Subject: [Koha-bugs] [Bug 30042] Remove Date::Calc use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Bug 30042 depends on bug 29843, which changed state. Bug 29843 Summary: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:26:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:26:37 +0000 Subject: [Koha-bugs] [Bug 29984] Remove unused method Koha::Patrons->anonymise_issue_history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29984 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:27:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:27:03 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:27:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:27:04 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Bug 7374 depends on bug 29867, which changed state. Bug 29867 Summary: Reindent authorized values administration template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:28:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:28:23 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:29:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:29:01 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:29:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:29:01 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Bug 29002 depends on bug 29397, which changed state. Bug 29397 Summary: Add a select2 wrapper for the API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:29:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:29:27 +0000 Subject: [Koha-bugs] [Bug 29832] Make library column in desk list sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:30:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:30:18 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:30:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:30:19 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Bug 29226 depends on bug 29277, which changed state. Bug 29277 Summary: Replace the use of jQueryUI tabs on item circulation alerts page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:30:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:30:19 +0000 Subject: [Koha-bugs] [Bug 29998] Replace the use of jQueryUI tabs on item types administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Bug 29998 depends on bug 29277, which changed state. Bug 29277 Summary: Replace the use of jQueryUI tabs on item circulation alerts page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:30:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:30:19 +0000 Subject: [Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 Bug 29999 depends on bug 29277, which changed state. Bug 29277 Summary: Replace the use of jQueryUI tabs on item circulation alerts page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:30:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:30:19 +0000 Subject: [Koha-bugs] [Bug 30000] Replace the use of jQueryUI tabs on the search engine configuration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30000 Bug 30000 depends on bug 29277, which changed state. Bug 29277 Summary: Replace the use of jQueryUI tabs on item circulation alerts page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:34:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:34:57 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #23 from Nick Clemens --- Created attachment 130495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130495&action=edit Bug 29924: (follow-up) Add password_expiration_date to API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:46:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:46:03 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:46:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:46:07 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128037|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 130496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130496&action=edit Bug 29579: Show saved SQL report ID in database query When trying to figure out which saved SQL report caused too much load, it's useful to have the report id show in the mysql process list. This patch adds the saved SQL ID number as a comment line in front of the SQL before passing it to the database. To test: 1) Run a saved report that takes long enough time, so you can: 2) Connect to the database with your preferred client, and use "show processlist;" to list all the running mysql processes. 3) The running saved SQL report should show up with "-- saved_sql.id=123" in the process info field. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:46:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:46:35 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 --- Comment #4 from Owen Leonard --- Tested using the query "select sleep(10)" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 14:58:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 13:58:16 +0000 Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130141|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 130497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130497&action=edit Bug 30016: Remove GetOpenIssue subroutine This patch adjusts the code that uses GetOpenIssue to use/find a Koha::Checkout object instead To test: 1 - Add a course to course reserves 2 - Create an item with barcode TESTKOC 3 - Add the item to a course 4 - Checkout the item 5 - View course details on stff and opac and confirm item shows as checked out and due date displays 6 - prove t/db_dependent/Circulation/issue.t t/db_dependent/Circulation.t t/db_dependent/CourseReserves.t 7 - Browse to Circulation->Upload offline circulation 8 - Upload a file to return the item: https://wiki.koha-community.org/wiki/Koha_offline_circulation_file_format 9 - Confirm item is returned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 15:47:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 14:47:46 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129573|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 130498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130498&action=edit Bug 29781: Unit test This patch adds a unit test for capture groups support in Koha::Items Test plan 1) Run the test prior to applying the capture groups fix, note it fails. 2) Apply the capture groups fix patch 3) Run the test again, it should now pass Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jo Hunter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 15:47:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 14:47:50 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129574|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 130499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130499&action=edit Bug 29781: Enable capture groups in batch item modification This patch adds support for regular expression capture groups in MarcModificationTemplates. We escape double quotes in the replacement string, then quote the whole string before applying the `ee` modifier to the final regex application. See https://blog.james.rcpt.to/2010/10/25/perl-search-and-replace-using-variables/ for further details. Test plan 1) Attempt to use capture groups in your regular expression based batch item modification and note it does not work. 2) Apply the patch and try again, this time the capture group should yield the expected results. 3) Run t/SimpleMARC.t and confirm the tests still pass. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jo Hunter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 15:57:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 14:57:11 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 15:57:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 14:57:15 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130116|0 |1 is obsolete| | Attachment #130117|0 |1 is obsolete| | Attachment #130118|0 |1 is obsolete| | Attachment #130119|0 |1 is obsolete| | Attachment #130120|0 |1 is obsolete| | Attachment #130495|0 |1 is obsolete| | --- Comment #24 from Owen Leonard --- Created attachment 130500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130500&action=edit Bug 29924: Database updates Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 15:57:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 14:57:19 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #25 from Owen Leonard --- Created attachment 130501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130501&action=edit Bug 29924: DO NOT PUSH - Schema updates Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 15:57:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 14:57:23 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #26 from Owen Leonard --- Created attachment 130502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130502&action=edit Bug 29924: Add password expiration feature This patch adds the ability to define password_expiry_days for a patron category. When defined a patron's password will expire after X days and they will be required to reset their password. If OPAC resets are enabled for the catgeory they may do so on their own, otherwise they will need to contact the library To test: 1 - Apply patch, updatedatabase 2 - Set 'Password expiration' for a patron category Home-> Administration-> Patron categories-> Edit 3 - Create a new patron in this category with a userid/password set, and an email 4 - Confirm their password_expiration_date field is set SELECT password_expiration_date FROM borrowers WHERE borrowernumber=51; 5 - Create a new patron, do not set a password 6 - Confirm their password_expiration_date field is NULL 7 - Update the patron with an expiration to be expired UPDATE borrowers SET password_expiration_date='2022-01-01' WHERE borrowernumber=51; 8 - Give the borrower catalogue permission 9 - Attempt to log in to Straff interface 10 - Confirm you are signed out and notified that password must be reset 11 - Attempt to sign in to OPAC 12 - Confirm you are signed out and notified password must be reset 13 - Enable password reset for the patron's category and perform a password reset Note: you will have to find the link in the message_queue unless you have emails setup on your test environment SELECT * FROM message_queue WHERE borrowernumber=51; 14 - Confirm that you can now sign in and password_expiration_date field is set 10 days in the future 15 - Expire the patron's password again 16 - Change the patron's password via the staff interface 17 - Confirm they can sign in and the expiration is updated Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 15:57:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 14:57:26 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #27 from Owen Leonard --- Created attachment 130503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130503&action=edit Bug 29924: Unit tests Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 15:57:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 14:57:31 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #28 from Owen Leonard --- Created attachment 130504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130504&action=edit Bug 29924: (follow-up) Add bug number to atomicupdate; Style OPAC message - The atomicupdate didn't have "bug_number" defined. - The "Your password has expired" message is now styled with the same class as other OPAC login messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 15:57:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 14:57:35 +0000 Subject: [Koha-bugs] [Bug 29924] Introduce password expiration to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #29 from Owen Leonard --- Created attachment 130505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130505&action=edit Bug 29924: (follow-up) Add password_expiration_date to API Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:04:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:04:27 +0000 Subject: [Koha-bugs] [Bug 30036] Add xslt for authority results normal view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jeremy.breuillard at biblibre. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:20:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:20:02 +0000 Subject: [Koha-bugs] [Bug 30082] New: Bibliographic details tab missing when user can't add local cover image Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Bug ID: 30082 Summary: Bibliographic details tab missing when user can't add local cover image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 130506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130506&action=edit Screenshot showing the problem There is an error in the logic controlling whether the "Images" tab appears on the bibliographic detail page in the staff interface. If the LocalCoverImages preference is enabled but the logged-in user doesn't have CAN_user_tools_upload_local_cover_images permission the "No images..." text appears outside of the tabs. This is because the logic for displaying the message differs from the logic for displaying the corresponding tab link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:22:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:22:50 +0000 Subject: [Koha-bugs] [Bug 30082] Bibliographic details tab missing when user can't add local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 [Bug 22032] Improve local cover image tab on detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:22:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:22:50 +0000 Subject: [Koha-bugs] [Bug 22032] Improve local cover image tab on detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 [Bug 30082] Bibliographic details tab missing when user can't add local cover image -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:24:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:24:03 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #34 from Jonathan Druart --- Created attachment 130507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130507&action=edit Bug 30055: Restore DefaultPatronSearchFields and fix extended attrs search We lost the DefaultPatronSearchFields behaviour, we don't want to search on all data but only DefaultPatronSearchFields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:24:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:24:23 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:24:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:24:27 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130498|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 130508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130508&action=edit Bug 29781: Unit test This patch adds a unit test for capture groups support in Koha::Items Test plan 1) Run the test prior to applying the capture groups fix, note it fails. 2) Apply the capture groups fix patch 3) Run the test again, it should now pass Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jo Hunter Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:24:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:24:31 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130499|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 130509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130509&action=edit Bug 29781: Enable capture groups in batch item modification This patch adds support for regular expression capture groups in MarcModificationTemplates. We escape double quotes in the replacement string, then quote the whole string before applying the `ee` modifier to the final regex application. See https://blog.james.rcpt.to/2010/10/25/perl-search-and-replace-using-variables/ for further details. Test plan 1) Attempt to use capture groups in your regular expression based batch item modification and note it does not work. 2) Apply the patch and try again, this time the capture group should yield the expected results. 3) Run t/SimpleMARC.t and confirm the tests still pass. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jo Hunter Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:26:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:26:30 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #13 from Nick Clemens --- I tried executing code and couldn't exploit it perl -e 'use Koha::Items; warn Koha::Items::apply_regex({value=>q{KF 123 .A987 c. 11 v. 22},search=>q{(^[A-Z]+ \d+\b)\s+(\.[A-Z]+\d+\b)\s+(c\.\s\d+\b)\s+(v\.\s\d+\b)}, replace=>q{ $1 $2 $4 $3 object_class() }});' If I comment out the lines that quote the replace I get 'Koha::Items' - so that protection seems to work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:26:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:26:38 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:27:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:27:21 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #35 from Jonathan Druart --- (In reply to Martin Renvoize from comment #29) > Hmm, right now I'm getting 404's on the API requests in my testing.. > continuing to investigate. > > Couple of comments to get us started though.. > > * It might be nice to enable `"header_filter": true,` on the kohaTable.. the > URL's are pretty crazy to read without it. Not strongly attached to that. Could switch to header_filter if your prefer. > * Was it a deliberate choice to use 'add_filters'.. for the guarantor search > at least, this is a change and I'm not sure it makes sense to have the both > sets of filters visible at the same time in the popup window? Yes, that's definitely a deliberate choice. The idea is to keep the same filters as before on top of the table, but provide a way to refine the search with the column's filters. I would like to have the same behaviour/UI on all patrons search. You also noticed the "Browse by last name" that will be there as well. (In reply to Martin Renvoize from comment #30) > Also, could we get a little update for the jsdoc for kohaTable for the > changes/enhancements you've made.. especially the signature update for > default_filters? Yep, I was waiting for the other bug follow-ups and feedbacks to make sure it's the correct way to accomplish that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:31:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:31:10 +0000 Subject: [Koha-bugs] [Bug 30082] Bibliographic details tab missing when user can't add local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:31:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:31:13 +0000 Subject: [Koha-bugs] [Bug 30082] Bibliographic details tab missing when user can't add local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 --- Comment #1 from Owen Leonard --- Created attachment 130510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130510&action=edit Bug 30082: Bibliographic details tab missing when user can't add local cover image This patch corrects the template logic which determines whether the "Images" tab should be displayed on the bibliographic detail page. The "Images" tab should display whenever local cover images are enabled, not just if the user has permission to manage cover images. To test, apply the patch and go to Administration -> System preferences. - Enable the LocalCoverImages system preference. - Locate and view the detail page for a bibliographic record in the catalog which doesn't have a local cover image attached. - If you are logged in as a user with upload_local_cover_images permission you should see an "Images" tab with the message "No images have been uploaded for this bibliographic record yet" and an upload button. - If you are logged in as a user without upload_local_cover_images permission you should see an "Images" tab with just the "No images..." message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:39:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:39:39 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | CC| |andrew at bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:39:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:39:40 +0000 Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on cookies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:42:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:42:03 +0000 Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on cookies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 [Bug 29940] Phase out jquery.cookie.js in the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:42:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:42:03 +0000 Subject: [Koha-bugs] [Bug 29940] Phase out jquery.cookie.js in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26019 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019 [Bug 26019] Koha should set SameSite attribute on cookies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:43:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:43:17 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 --- Comment #3 from Donna --- > 1. If by default it sets the limit to the logged in branch and you do a > search at a different branch, should the limiter then be set to the branch > you just searched or still your logged in branch? My expectation would be to set my search back to the branch I am logged in at. If I need to do an extensive search at another location, then I would change My Library. > > 2. Does these need to account for IndependentBranches? Maybe? What I typically see with independent branches is that the libraries are not interested in seeing/looking for any materials other than their own. So I would imagine they would use this to keep the search at their own location and not change it. BUT, I don't have a lot of experience with independent branches, so if anyone else can add to this, that would be great! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:44:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:44:29 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130491|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart --- Created attachment 130511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130511&action=edit Bug 30055: Missing search on othernames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 16:44:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 15:44:56 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | CC| |andrew at bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 17:06:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 16:06:47 +0000 Subject: [Koha-bugs] [Bug 30083] New: Bug fixes 29914 and 28785 make 'Browse result' feature disappear for anonymous user Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30083 Bug ID: 30083 Summary: Bug fixes 29914 and 28785 make 'Browse result' feature disappear for anonymous user Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: januszop at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 130512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130512&action=edit Browse results In OPAC, having OpacBrowseResults on, a Browse results widget should be available, with a very helpful feature of moving to the next / previous record (cf. the graphics attached). However, in version 21.05.10 the bug fix 29914, and in version 21.11 both the bug fixes 29914 and 28785 (changes to C4/Auth.pm) make the widget not appear for an anonymous (not logged in) user. Which is pity and annoying. As far as I was able to investigate, this is because a session information is not being maintained for an anonymous user and so the 'busc' parameter is not passed to the opac-detail.pl script. Reverting the bug fixes makes the widget reappear. Obviously, this is not a solution. Nevertheless, it reveals the cause. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 17:11:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 16:11:59 +0000 Subject: [Koha-bugs] [Bug 30083] Bug fixes 29914 and 28785 make 'Browse result' feature disappear for anonymous user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30083 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 17:16:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 16:16:15 +0000 Subject: [Koha-bugs] [Bug 30083] Bug fixes 29914 and 28785 make 'Browse result' feature disappear for anonymous user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30083 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 17:16:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 16:16:18 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 17:16:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 16:16:21 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130478|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 130513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130513&action=edit Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown To test: 1. Apply patch, updatedatabase, restart_all 2. Search for the system pref 'IntranetAddMastheadLibraryPulldown' 3. Set it to 'Show'. 4. Go to any page that contains header search box and click on 'Search the catalog'. 5. To the left of the search bar you should see a dropdown for branches. 6. This should be defaulted to the branch you are logged in at. 7. Do a search and make sure it is correctly limiting to your logged in branch. 8. Try changing to a different branch and doing another search. It should correcrly limit to that branch BUT it should also default back to your logged in branch for the next search. 9. Try selecting 'All libraries' from the top of the dropdown and make sure it is correctly searching all branches. 10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it looks nice with both of those dropdowns and functions when you use limiters from both dropdowns. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 17:16:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 16:16:35 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 17:16:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 16:16:50 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 17:53:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 16:53:41 +0000 Subject: [Koha-bugs] [Bug 30083] Bug fixes 29914 and 28785 make 'Browse result' feature disappear for anonymous user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30083 --- Comment #1 from Janusz Kaczmarek --- To be precise: Browse results widget should be available on the OPAC detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 17:59:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 16:59:07 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 17:59:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 16:59:11 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #15 from Owen Leonard --- Created attachment 130514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130514&action=edit Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 18:15:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 17:15:04 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |andrew at bywatersolutions.com --- Comment #53 from Andrew Fuerste-Henry --- Missing dependency (bug 27032), not backported to 21.05. Please request if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 18:15:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 17:15:05 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Bug 29483 depends on bug 29474, which changed state. Bug 29474 Summary: Automatic renewals cronjob is slow on systems with large numbers of reserves https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 18:15:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 17:15:05 +0000 Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Bug 29537 depends on bug 29474, which changed state. Bug 29474 Summary: Automatic renewals cronjob is slow on systems with large numbers of reserves https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 18:19:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 17:19:57 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130514|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 130515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130515&action=edit Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 18:21:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 17:21:35 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Lisette Scheer --- Worked great. I also ran a report: SELECT * FROM messages WHERE borrowernumber="51" and the patron_read_date was included: 2022-02-11 17:16:58. I know we have plenty of patrons who will be excited about this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 18:28:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 17:28:25 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Andrew Fuerste-Henry --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 18:43:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 17:43:54 +0000 Subject: [Koha-bugs] [Bug 30083] Bug fixes 29914 and 28785 make 'Browse result' feature disappear for anonymous user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30083 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com --- Comment #2 from Lucy Vaux-Harvey --- Thanks for logging this bug, we are seeing the same issue on the OPAC at 21.11 for users who are not logged in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:16:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:16:02 +0000 Subject: [Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:22:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:22:31 +0000 Subject: [Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew at bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry --- Not backporting to 21.05, please ask if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:23:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:23:49 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130515|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 130516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130516&action=edit Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" Signed-off-by: Lisette Scheer Signed-off-by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:33:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:33:35 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:36:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:36:40 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:36:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:36:51 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 130517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130517&action=edit Bug 30072: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:37:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:37:03 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 130518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130518&action=edit Bug 30072: Add missing hold actions plugin hooks This patch introduces the after_hold_action plugin hook, with 4 different 'action' parameters: - fill - cancel - suspend - resume To test: 1. Apply the unit tests 2. Run: $ kshell k$ t/db_dependent/Koha/Plugins/Holds_hooks.t -v => FAIL: The hooks are not in the code, so the expected output from the Koha::Plugin::Test plugin is not there, and the tests fail 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Note: I think we could deprecate 'after_hold_create' and migrate it to the one introduced here, using the 'place' action. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:37:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:37:10 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 130519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130519&action=edit Bug 30072: (follow-up) Silence useless warning Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:38:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:38:30 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:41:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:41:08 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #4 from Tomás Cohen Arazi --- I have doubts about relying on ->get_from_storage, as the current Koha::Plugins->call design will refetch the object even if there are no installed plugins. I submit this as-is because it is what is being done in places like AddReturn anyway. But my gut feeling was telling me to pass the id only, and let the plugin writers decide what to do with it. But, for consistency, we should fix the existing calls... Hard call. Ideas welcome. I like this as-is and will provide a patchset for branches that don't have bug 29869 in them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:44:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:44:21 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #24 from Fridolin Somers --- > Bug 29458: Fix selenium test Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:46:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:46:23 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:49:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:49:36 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #44 from Fridolin Somers --- > Bug 29844: Fix selenium/administration_tasks.t Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:50:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:50:12 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | --- Comment #9 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:51:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:51:06 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers --- > Bug 29859: (follow-up) Use iterator instead of as_list > Bug 29859: Fix currencies display Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:54:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:54:51 +0000 Subject: [Koha-bugs] [Bug 30084] New: Remove explicit dependency of liblocale-codes-perl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 Bug ID: 30084 Summary: Remove explicit dependency of liblocale-codes-perl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com Bug 25920 follow work on liblocale-codes-perl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:54:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:54:57 +0000 Subject: [Koha-bugs] [Bug 30084] Remove explicit dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25920 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:54:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:54:57 +0000 Subject: [Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30084 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 [Bug 30084] Remove explicit dependency of liblocale-codes-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:55:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:55:18 +0000 Subject: [Koha-bugs] [Bug 30084] Remove explicit dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:55:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:55:42 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:56:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:56:29 +0000 Subject: [Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #22 from Fridolin Somers --- (In reply to Jonathan Druart from comment #21) > (In reply to Jonathan Druart from comment #20) > > Mason, we need a separate bug report for this last patch. The original one > > has been backported already. > > This is still pending. I've created Bug 30084 for that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:56:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:56:41 +0000 Subject: [Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:56:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:56:55 +0000 Subject: [Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121343|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:58:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:58:10 +0000 Subject: [Koha-bugs] [Bug 30084] Remove explicit dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 --- Comment #1 from Fridolin Somers --- Created attachment 130520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130520&action=edit Bug 25920: Remove explicit dependency of liblocale-codes-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 19:58:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 18:58:18 +0000 Subject: [Koha-bugs] [Bug 30084] Remove explicit dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 20:01:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 19:01:24 +0000 Subject: [Koha-bugs] [Bug 30084] Remove explicit dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 20:01:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 19:01:28 +0000 Subject: [Koha-bugs] [Bug 30084] Remove explicit dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130520|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 130521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130521&action=edit Bug 30084: Remove explicit dependency of liblocale-codes-perl 1/ apply patch 2/ build and install new koha-common package 3/ confirm liblocale-codes-perl pkg is installed $ apt-cache policy liblocale-codes-perl | grep Installed Installed: 3.62-1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 20:10:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 19:10:57 +0000 Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium lib is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Test was failing : https://jenkins.koha-community.org/view/master/job/Koha_Master/1910/ Commit in master : 090c70b746 Bug 29779: Fix unit tests count Also in 21.11.x : 4729fd7881 Bug 29779: Fix unit tests count for 21.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 20:20:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 19:20:44 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 130522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130522&action=edit [STABLE] Bug 30072: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 20:20:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 19:20:48 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 130523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130523&action=edit [STABLE] Bug 30072: Add missing hold actions plugin hooks This patch introduces the after_hold_action plugin hook, with 4 different 'action' parameters: - fill - cancel - suspend - resume To test: 1. Apply the unit tests 2. Run: $ kshell k$ t/db_dependent/Koha/Plugins/Holds_hooks.t -v => FAIL: The hooks are not in the code, so the expected output from the Koha::Plugin::Test plugin is not there, and the tests fail 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Note: I think we could deprecate 'after_hold_create' and migrate it to the one introduced here, using the 'place' action. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 20:20:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 19:20:52 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 130524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130524&action=edit [STABLE] Bug 30072: (follow-up) Silence useless warning Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 20:21:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 19:21:13 +0000 Subject: [Koha-bugs] [Bug 25670] Add useful methods to Koha::Acquisition::Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 --- Comment #19 from Fridolin Somers --- Still additional_work_needed ? Looks like there has been : Bug 20212: Fix test after 25670 follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 20:21:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 19:21:15 +0000 Subject: [Koha-bugs] [Bug 30085] New: Improve performance of CanItemBeReserved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 Bug ID: 30085 Summary: Improve performance of CanItemBeReserved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 20:22:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 19:22:47 +0000 Subject: [Koha-bugs] [Bug 27771] ES: The parameter include_type_name should be explicitly specified in put mapping requests to prepare for 7.0. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27771 --- Comment #2 from Victor Grousset/tuxayo --- I opened the ticket based on the messages, as I don't know much about ES it could indeed be a duplicate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 20:26:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 19:26:27 +0000 Subject: [Koha-bugs] [Bug 27770] ES: Deprecated aggregation order key [_term] used, replaced by [_key] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #4 from Victor Grousset/tuxayo --- (In reply to Kevin Carnes from comment #2) > This solution includes a check for versions prior to Elasticsearch 6. I > don't know if there are any plans to drop support for Elasticsearch 5. It has been dropped from some time ago, Bug 27252 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 21:00:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 20:00:10 +0000 Subject: [Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 21:00:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 20:00:14 +0000 Subject: [Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 --- Comment #1 from Nick Clemens --- Created attachment 130525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130525&action=edit Bug 30085: Reduce scope of holds count / today holds count We retrieve two counts that are only needed if rules for hold limits are defined. The DB counts should only be fetched once the rules are confirmed to exist Further improvement would be possiblke by allowing them to be passed in (or cached?) from CanBookBeReserved as they rely only on patron/biblionumber and not item specific information -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 21:00:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 20:00:17 +0000 Subject: [Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 --- Comment #2 from Nick Clemens --- Created attachment 130526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130526&action=edit Bug 30085: Don't fetch ReservesControlBranch twice We essentially copy the code from GetReservesControlBranch here, because we also calculate 'branchfield' Setting it to "" vs undef makes no difference in this code, so lets not fetch this again later. Rename the variable to make it clearer where the branchcode came from -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 21:00:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 20:00:21 +0000 Subject: [Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 --- Comment #3 from Nick Clemens --- Created attachment 130527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130527&action=edit Bug 30085: Consolidate querycoutn code and only check if needed Similar to first patch, move a count only conditionally used into the conditional This could be updated to use DBIC, but the itemtype conditionals add complexity -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 21:00:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 20:00:24 +0000 Subject: [Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 --- Comment #4 from Nick Clemens --- Created attachment 130528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130528&action=edit Bug 30085: Move IndependentBranches check sooner This doesn't rely on the other statuses, and requires only cached preference check, so lets allow the possibiliy of an early exit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 21:00:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 20:00:59 +0000 Subject: [Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 21:31:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 20:31:34 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #14 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 21:31:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 20:31:35 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Bug 29648 depends on bug 29530, which changed state. Bug 29530 Summary: When NumSavedReports is set, show value in pull down of entries https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 21:32:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 20:32:01 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #21 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 21:32:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 20:32:02 +0000 Subject: [Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Bug 29537 depends on bug 29476, which changed state. Bug 29476 Summary: Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 21:56:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 20:56:31 +0000 Subject: [Koha-bugs] [Bug 19814] Batch Check-in function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 Nathan Walker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nathan.walker at citruslibrari | |es.org --- Comment #24 from Nathan Walker --- Have there been any updates on this? Our team was discussing workflows for our department and a batch check-in feature for the batch-item modification would be greatly beneficial to us as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 23:06:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 22:06:09 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|22.05.00,21.11.02,21.05.09 |22.05.00,21.11.02,21.05.09, released in| |20.11.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #13 from Victor Grousset/tuxayo --- Backported: Pushed to 20.11.x branch for 20.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 23:07:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 22:07:27 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 23:10:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 22:10:38 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #23 from Victor Grousset/tuxayo --- Missing dependencies for 20.11.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 23:10:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 22:10:39 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort summary column of pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Bug 29570 depends on bug 29464, which changed state. Bug 29464 Summary: GET /acquisitions/orders doesn't honour sorting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 23:56:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 22:56:38 +0000 Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass --- *** Bug 30029 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 11 23:56:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 22:56:38 +0000 Subject: [Koha-bugs] [Bug 30029] XSLT can chop off too much punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30029 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 28976 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 00:03:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 23:03:58 +0000 Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #6 from Lucas Gass --- This works as intended with the test plan. However, now when I view search results ( OPAC or staff client ) there is often two periods. I am using koha testing docker sample data. An example is this in the 100: Dina, Anca (ed.). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 00:04:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 23:04:28 +0000 Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #7 from Lucas Gass --- Created attachment 130529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130529&action=edit example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 00:04:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 23:04:47 +0000 Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 00:12:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 23:12:20 +0000 Subject: [Koha-bugs] [Bug 29962] Table of items on item edit page missing columns button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- This patch works and restores the Columns button. However the order of the columns is wrong in the tool is wrong. This is a bit confusing. On every other page I looked at with a Columns button, the order in the tool is the same as the order in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 00:15:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Feb 2022 23:15:06 +0000 Subject: [Koha-bugs] [Bug 29962] Table of items on item edit page missing columns button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 04:25:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Feb 2022 03:25:20 +0000 Subject: [Koha-bugs] [Bug 30082] Bibliographic details tab missing when user can't add local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 04:25:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Feb 2022 03:25:23 +0000 Subject: [Koha-bugs] [Bug 30082] Bibliographic details tab missing when user can't add local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130510|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 130530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130530&action=edit Bug 30082: Bibliographic details tab missing when user can't add local cover image This patch corrects the template logic which determines whether the "Images" tab should be displayed on the bibliographic detail page. The "Images" tab should display whenever local cover images are enabled, not just if the user has permission to manage cover images. To test, apply the patch and go to Administration -> System preferences. - Enable the LocalCoverImages system preference. - Locate and view the detail page for a bibliographic record in the catalog which doesn't have a local cover image attached. - If you are logged in as a user with upload_local_cover_images permission you should see an "Images" tab with the message "No images have been uploaded for this bibliographic record yet" and an upload button. - If you are logged in as a user without upload_local_cover_images permission you should see an "Images" tab with just the "No images..." message. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 12:54:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Feb 2022 11:54:51 +0000 Subject: [Koha-bugs] [Bug 29224] OMNIBUS: Replace the use of jQueryUI Accordion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29224 --- Comment #2 from Katrin Fischer --- We do also have tabs for the translations (visibility pending on the pref) there, it could get a bit much with the tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 14:55:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Feb 2022 13:55:34 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02,21.05.08 |22.05.00,21.11.02,21.05.08, released in| |20.11.15 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net --- Comment #47 from Victor Grousset/tuxayo --- Backported: Pushed to 20.11.x branch for 20.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 21:29:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Feb 2022 20:29:30 +0000 Subject: [Koha-bugs] [Bug 30083] Bug fixes 29914 and 28785 make 'Browse result' feature disappear for anonymous user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30083 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 21:33:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Feb 2022 20:33:54 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #20 from Victor Grousset/tuxayo --- This one is tricky for 20.11.X The patch fixes one of the tests but there are others failing. Digging the differences with 21.05.x showed that bug 27793 wasn't on 20.11.x and bingo, that's what makes the difference in output and fixes the tests :D So I'll backport it to have this one. 27793 doesn't seem too scary since no regression has been found after all this time and the missing automated tests are coming with this very ticket. And the functional change shouldn't bother users. An alternative is reverting bug 27708 Tell me in the next week (before the release) if the alternative would actually be better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 21:35:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Feb 2022 20:35:19 +0000 Subject: [Koha-bugs] [Bug 27793] Store Contents of FTX segment of EDI quotes for inclusion in orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27793 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.15 released in| | CC| |victor at tuxayo.net --- Comment #13 from Victor Grousset/tuxayo --- Surprise backport! Backported: Pushed to 20.11.x branch for 20.11.15 It's for bug 29670 comment 20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Feb 12 21:36:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Feb 2022 20:36:13 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|22.05.00,21.11.02,21.05.11 |22.05.00,21.11.02,21.05.11, released in| |20.11.15 --- Comment #21 from Victor Grousset/tuxayo --- Backported: Pushed to 20.11.x branch for 20.11.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 00:40:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Feb 2022 23:40:02 +0000 Subject: [Koha-bugs] [Bug 30087] New: Checkout on ILL hangs on when statistical patron(s) not have cardnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30087 Bug ID: 30087 Summary: Checkout on ILL hangs on when statistical patron(s) not have cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: gveranis at dataly.gr When I try to do a check-out for an item on ILL process , Koha tries to go to /cgi-bin/koha/ill/ill-requests.pl?method=check_out&illrequest_id=XX but if the library has at least a patron on statistical category without cardnumber, then I get "The timeout specified has expired" and "AH00898: Error reading from remote server returned by /cgi-bin/koha/ill/ill-requests.pl" and if you use plack you get finally Proxy error, without any other explanation or something on logs. At line 1116 at Illrequest.pm where gather all statistical patrons, it should search only for those with cardnumber otherwise will faill on the other side of tt . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 00:40:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Feb 2022 23:40:34 +0000 Subject: [Koha-bugs] [Bug 30087] Checkout on ILL hangs on when statistical patron(s) not have cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30087 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 02:46:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 01:46:58 +0000 Subject: [Koha-bugs] [Bug 30088] New: Forgotten password Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30088 Bug ID: 30088 Summary: Forgotten password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Two thoughts: Is there a reason patrons have to be presented with two fields, one for login or one for e-mail address? The prompt says to enter one or the other. Since there is the possibility for more than one account to have the same e-mail address, should we only ask for the username? The second thought is, should Koha e-mail the account user if a request has been made to reset the password? This seems to be common practice these days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 09:41:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 08:41:09 +0000 Subject: [Koha-bugs] [Bug 19814] Batch Check-in function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 10:50:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 09:50:55 +0000 Subject: [Koha-bugs] [Bug 30088] Forgotten password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30088 --- Comment #1 from Katrin Fischer --- I think the idea is that the user can pick what they know/have on hand, which varies with different use cases. The email AND the login are only required if there are users with the same email address. I think often it's easier for users to give their institutional email than a cardnumber/userid. For your second question I am not sure: the user is always emailed in this process? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 13:35:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 12:35:02 +0000 Subject: [Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer --- There is 2 small things so far: * When an order is added, there is a column "supplier report" in the basket summary table that I think should also be removed with the pref set to off. * The doubled description here doesn't look right: ('EasyAnalyticalRecords','0','','If on, display in the catalogue screens tools to easily setup analytical record relationships','YesNo'), +('Edifact','0','Enables edifact acquisitions functions','Enables use of Edifact electronic message exchange for acquisitions','YesNo'), * There is now an EDIFACT heading on the acq syspref page, so I think we should move the pref there :) * Spelling: EDIFACT is an abbreviation and we should spell it as such. Edifact for the syspref name makes sense, but in the descriptions we should use EDIFACT consistently (updatedatabase, syspref.sql, acquisitions.pref) Rest looks great as far as I can tell! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 13:47:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 12:47:11 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 13:47:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 12:47:16 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130450|0 |1 is obsolete| | --- Comment #35 from Katrin Fischer --- Created attachment 130531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130531&action=edit Bug 20398 : Added a syspref to highlight or not highlight search terms in results on the staff interface There is a possibility on OPAC but not yet on the staff interface, so I added this syspref which has the same behaviour as the OPAC highlighting syspref. When you choose to disable highlighting on the syspref, the toggle anchor in the result page does not appear at all. But if you keep the default state (highlighting on), you still have the option to switch between "Unhighlight" and "Highlight" modes. Test plan : 1. Go to the syspref named "StaffHighlightedWords" and see that the default state is "Highlight". 2. Look for something in the catalogue for example and see that the words are highlighted and that it is also possible to change between "Unhighlight" and "Highlight". 3. Go back to syspref and choose to disable highlighting by choosing "Don't Highlight". 4. Refresh your results page if you have not closed it or reload a new search. 5. There is no highlighting at all and anchors do not exist (same behaviour as the OPAC interface). Signed-off-by: ManuB Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 13:47:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 12:47:22 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #36 from Katrin Fischer --- Created attachment 130532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130532&action=edit Bug 20398: (QA follow-up) Fix alphabetical order in sysprefs.sql Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 13:47:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 12:47:54 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #37 from Katrin Fischer --- Hi Thibaud, 1) Commit message Please make sure to run the QA test tools on your patches - they can highlight things like mistakes with the commit message and give other helpful hints. In this case there is an extra space that needs to be removed: Bug xxxx : should be Bug xxxx: 2) b/installer/data/mysql/mandatory/sysprefs.sql This file is sorted alphabetically, as you are dealing with librarians here, we take this seriously :) 3) Database update For some time we are using a new format for database updates, see here: https://wiki.koha-community.org/wiki/Database_updates That's for next time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 13:52:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 12:52:57 +0000 Subject: [Koha-bugs] [Bug 30060] Missing primary key on user_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 13:53:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 12:53:06 +0000 Subject: [Koha-bugs] [Bug 30060] Missing primary key on user_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130360|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 130533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130533&action=edit Bug 30060: Add primary key to user_permissions table Without primary key DBIC is failing with something like: GET /api/v1/suggestions/managers: unhandled exception (DBIx::Class::Exception)< user_permissions chain): fetch more unique non-nullable columns at /kohadevbox/koha/Koha/Objects.pm line 394>> Koha::REST::Plugin::Exceptions::__ANON__ / kohadevbox/koha/Koha/REST/Plugin/Exceptions.pm (73) Test plan: Execute the atomic update and confirm that the new PK has been added to the user_permissions table. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 13:54:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 12:54:15 +0000 Subject: [Koha-bugs] [Bug 30060] Missing primary key on user_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 --- Comment #6 from Katrin Fischer --- Please remember guidelines for commit messages :) Do we need to worry about potentially doubled up entries? I recently managed to do that with SQL manipulations, but haven't seen it happen from within Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 13:58:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 12:58:58 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 13:59:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 12:59:02 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130244|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 130534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130534&action=edit Bug 28405: add author name to request.tt when it exists To test: 1. Place a hold and observe request.tt 2. No author name 3. Apply patch 4. Reload request.tt 5. Author name should appear on the same line as the title. Signed-off-by: Barbara Johnson Signed-off-by: George Williams Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 13:59:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 12:59:07 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130337|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Created attachment 130535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130535&action=edit Bug 28405: Add author for multi holds view Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:00:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:00:02 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page (reserve/request.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 --- Comment #21 from Katrin Fischer --- (In reply to Jonathan Druart from comment #18) > Do we want to display the author for the multi-holds view as well? Yes, but you've already done it :) I have updated George's sign-off line: Signed-off-by: AUTHORNAME Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:00:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:00:22 +0000 Subject: [Koha-bugs] [Bug 28405] Add author info to the holds page in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28405 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add author info to the |Add author info to the |holds page |holds page in the staff |(reserve/request.pl) |interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:03:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:03:36 +0000 Subject: [Koha-bugs] [Bug 30089] New: Placing holds on OPAC broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30089 Bug ID: 30089 Summary: Placing holds on OPAC broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When trying to place a hold in the OPAC, either multi hold or a single hold, the page explodes with: The method Koha::AuthorisedValues->authorised_value is not covered by tests! I am using ktd, the sample database and my search term is 'perl'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:13:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:13:46 +0000 Subject: [Koha-bugs] [Bug 30090] New: Don't export action buttons from patron results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30090 Bug ID: 30090 Summary: Don't export action buttons from patron results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The checkout and Edit buttons should not export (Exel, Print) on the patron search result list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:13:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:13:53 +0000 Subject: [Koha-bugs] [Bug 30090] Don't export action buttons from patron results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30090 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:15:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:15:16 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 --- Comment #10 from Katrin Fischer --- I am testing this with LibreOffice, but all amounts export with 00.00 for FR for me :( Not sure if this is because I am running my laptop with English default language or because LibreOffice is not Excel... could someone else give this a go? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:19:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:19:22 +0000 Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Janik changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ldjamison at marywood.edu |janik.hilser at icloud.com Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:32:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:32:26 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer --- Hi Alex, can you please make a couple fixes? 1) QA test tools FAIL installer/data/mysql/atomicupdate/bug_23352-add_ccode_column_to_subscriptions_table.pl FAIL file permissions File must have the exec flag FAIL valid Useless use of anonymous hash ({}) in void context 2) Handling of default on existing items I am in doubt about these lines: + if ( $itemrecord and $defaultvalues and not $itemrecord->subfield($tag,$subfield->{subfield}) ) { + # if the item record exists, only use default value if the item has no ccode + $defaultvalue = $defaultvalues->{ccode}; I believe that would affect what happens if an item is edited from the serials module? If the item has been created without a collection, we should not 'force' it later. The rule is that if it was emptied out intentionally it should remain empty. 3) Terminology [% IF ( ccode ) %]
  • Collection code: [% ccode | html %]
  • [% END %] As we always display the descriptions and not the codes, we have updated the GUI to always say "Collection". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:35:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:35:25 +0000 Subject: [Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #5 from Katrin Fischer --- As I can't test Overdrive I am a bit hesitant to try my hands on the rebase: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29845: add IDs to overdrive results action buttons Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js error: Failed to merge in the changes. Patch failed at 0001 Bug 29845: add IDs to overdrive results action buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:39:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:39:56 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- I gather from the discussion that this should be changed to use DBIC/Koha::Object instead of SQL. Moving to Failed QA for now to trigger action. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:40:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:40:52 +0000 Subject: [Koha-bugs] [Bug 28974] Add pagination to holds queue viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #26 from Katrin Fischer --- There is an issue with the depending bug needing some more work, but this also doesn't apply cleanly on top: Bug 28974 Depends on bug 28966 (Signed Off) Follow? [(y)es, (n)o] y Bug 28966 - Holds queue viewer too slow to load for large numbers of holds 125377 - Bug 28966: Prefetch patron data for holds queue viewer Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28966: Prefetch patron data for holds queue viewer Bug 28974 - Add pagination to holds queue viewer 125424 - Bug 28974: Add pagination to holds queue viewer 125425 - Bug 28974: Start at first page when change number of results per page 125426 - Bug 28974: Hard code page = 1 instead of using javascript 126277 - Bug 28974: (follow-up) Pass total number of items instead of count per page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28974: Add pagination to holds queue viewer error: sha1 information is lacking or useless (C4/HoldsQueue.pm). error: could not build fake ancestor Patch failed at 0001 Bug 28974: Add pagination to holds queue viewer hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28974-Add-pagination-to-holds-queue-viewer-HdA_x4.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 14:58:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 13:58:47 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #161 from Katrin Fischer --- We'll need a small fix here: 1) QA test tools FAIL admin/import_export_authtype.pl FAIL critic Subroutine "new" called using indirect syntax at line 36, column 13. See page 349 of PBP. 2) Text +Export all the information of a MARC or Authority Type Framework to an excel "xml" file, comma separated values "csv" file or OpenDocument SpreadSheet "ods" file. As the authority types are also MARC... maybe we could make this read: Export all information of a bibliographic or authority MARC framework to an Excel "xml" file, comma separated values "csv" or OpenDocument SpreadSheet "ods". 3) Unit tests The unit tests pass, but there is 'tons' of these with the patches, while the output without the patches is clean: Use of uninitialized value $frameworktype in string eq at /kohadevbox/koha/C4/ImportExportFramework.pm line 1004, <$dom> line 21. Use of uninitialized value $frameworktype in string eq at /kohadevbox/koha/C4/ImportExportFramework.pm line 678. 4) Translatability In .js files you need to use a double undescore for making things translatable: alert(_("Error importing the authority type %s").format(decodeURIComponent(matches[1]))); Should be: __("Error... 5) First import/export test looks great :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:05:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:05:18 +0000 Subject: [Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the ability to hide categorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:05:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:05:22 +0000 Subject: [Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the ability to hide categorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130351|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 130536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130536&action=edit Bug 29617: exclude categorycode from BorrowerUnwantedField To test: 1. Go to BorrowerUnwantedField and select categorycode as unwanted 2. Try adding a new patron, you will see an error message in the staff client "Something went wrong when creating the patron. Check the logs." You will be unable to make a new patron. 3. Apply patch 4. Go to BorrowerUnwantedField, you are unable to exlcude it. Patrons need categorycodes Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:09:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:09:41 +0000 Subject: [Koha-bugs] [Bug 30082] Bibliographic details tab missing when user can't add local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:09:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:09:45 +0000 Subject: [Koha-bugs] [Bug 30082] Bibliographic details tab missing when user can't add local cover image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130530|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 130537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130537&action=edit Bug 30082: Bibliographic details tab missing when user can't add local cover image This patch corrects the template logic which determines whether the "Images" tab should be displayed on the bibliographic detail page. The "Images" tab should display whenever local cover images are enabled, not just if the user has permission to manage cover images. To test, apply the patch and go to Administration -> System preferences. - Enable the LocalCoverImages system preference. - Locate and view the detail page for a bibliographic record in the catalog which doesn't have a local cover image attached. - If you are logged in as a user with upload_local_cover_images permission you should see an "Images" tab with the message "No images have been uploaded for this bibliographic record yet" and an upload button. - If you are logged in as a user without upload_local_cover_images permission you should see an "Images" tab with just the "No images..." message. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:14:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:14:30 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:14:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:14:34 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130496|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 130538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130538&action=edit Bug 29579: Show saved SQL report ID in database query When trying to figure out which saved SQL report caused too much load, it's useful to have the report id show in the mysql process list. This patch adds the saved SQL ID number as a comment line in front of the SQL before passing it to the database. To test: 1) Run a saved report that takes long enough time, so you can: 2) Connect to the database with your preferred client, and use "show processlist;" to list all the running mysql processes. 3) The running saved SQL report should show up with "-- saved_sql.id=123" in the process info field. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:20:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:20:21 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:20:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:20:25 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130493|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 130539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130539&action=edit Bug 30081: Add item type column to holds table Add new column item type to holds table in patron's details and check out views. Some libraries will find this information useful for distinguishing inter library holds from normal holds. To test: 1. Apply patch 2. Place a hold and confirm it 3. Go to cgi-bin/koha/circ/circulation.pl?borrowernumber=1 with borrowernumber being the id of your patron 4. Click "1 Hold(s)" tab 5. Observe new column "Item type" 6. Confirm the item type is correct 7. Go to moremember.pl?borrowernumber=1 with borrowernumber being the id of your patron 8. Repeat steps 4-6 Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:20:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:20:28 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130494|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 130540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130540&action=edit Bug 30081: Use itemtype description instead of itemtype code To test: 1. Use same plan as previous patch, but observe full item type description instead of item type code Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:21:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:21:03 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 --- Comment #8 from Katrin Fischer --- (In reply to Lari Taskula from comment #5) > That has to be the quickest sign-off I've seen in all these years :D Maybe fastest QA too? The wonder of small changes :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:33:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:33:05 +0000 Subject: [Koha-bugs] [Bug 29946] Sort profiles alphabetically when staging MARC records for import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29946 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- I am sorry, but while this works for A-z and therefor for English, it doesn't work for other languages like German with Umlauts or French with accents/diacritics. If you enter for example a description starting with Á, it will sort at the end, instead of as A. I think we need to use a sort that accounts for that and that we already have that in Koha - using cmp instead of >? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:36:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:36:38 +0000 Subject: [Koha-bugs] [Bug 29982] Show itemtype in holds table on patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29982 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #12 from Katrin Fischer --- This looks like a perfect duplicate of bug 30081 - can you please check? *** This bug has been marked as a duplicate of bug 30081 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:36:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:36:38 +0000 Subject: [Koha-bugs] [Bug 30081] Display item type in patron's holds table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30081 --- Comment #9 from Katrin Fischer --- *** Bug 29982 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:43:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:43:36 +0000 Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- This looks all good, but I think we might need to fix tests: t/db_dependent/Search.t .. # Failed test 'Built composed implicit-and CCL keyword query' # at t/db_dependent/Search.t line 423. # 'kw,wrdl=(rk=(salud)) AND kw,wrdl=(rk=(higiene)) ' # doesn't match '(?^u:kw\W.*salud\W.*and.*kw\W.*higiene)' # Looks like you failed 1 test of 90. t/db_dependent/Search.t .. 1/3 # Failed test 'MARC21 + DOM' # at t/db_dependent/Search.t line 906. t/db_dependent/Search.t .. 2/3 # Looks like you failed 1 test of 3. t/db_dependent/Search.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/Search.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 1 Non-zero exit status: 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:45:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:45:39 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Adds the patron category to |Adds the patron category as release notes|the holds queue on |a new column to Circulation |view_holdsqueue.tt |> Holds queue. Summary|Show patron category in |Show patron category in |Holds Queue |Holds queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:47:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:47:53 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:47:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:47:57 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129414|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 130541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130541&action=edit Bug 29760: Add patron category column to view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category column 3. Apply patch 4. Look again, there should now be a column for 'Patron category' showing both the caterory name and the category code. 5. Make sure you can sort and filter by this new column 6. Go to table settings and make sure you can properly hide this column and all other columns in the Holds queue. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:49:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:49:55 +0000 Subject: [Koha-bugs] [Bug 29795] If branch is mandatory on patron self registration form, the pull down should default to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|if branchcode is included |If branch is mandatory on |in |patron self registration |PatronSelfRegistrationBorro |form, the pull down should |werMandatoryField it should |default to empty |default to an empty value | Text to go in the|Creates an empty value and |Creates an empty value and release notes|defaults to it when |defaults to it when |PatronSelfRegistrationBorro |PatronSelfRegistrationBorro |werMandatoryField includes |werMandatoryField includes |branchcode. This forces |branchcode. This forces |self registering users to |self registering users to |make a choice for |make a choice for the |branchcode. |library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:52:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:52:58 +0000 Subject: [Koha-bugs] [Bug 30091] New: Sending an empty simple search results in error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30091 Bug ID: 30091 Summary: Sending an empty simple search results in error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In master, with a fresh ktd sample database, sending an empty simple search results in: Template process failed: undef error - The method Koha::Library::Groups->id is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:55:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:55:35 +0000 Subject: [Koha-bugs] [Bug 29795] If branch is mandatory on patron self registration form, the pull down should default to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:55:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:55:39 +0000 Subject: [Koha-bugs] [Bug 29795] If branch is mandatory on patron self registration form, the pull down should default to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130236|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 130542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130542&action=edit Bug 29795: add empty value for branchcode on self-reg form 1. Set branch code as a PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self reg form and look at the Home library field, it defaults to the first choice alphabetically 3. Fill out the other required fields and the captcha. Don't change the branchcode value. 4. Submit the form, it submits. 5. If branchcode is required it should default to an empty value and force the user to make a choice. 6. Apply patch 7. Repeat 1-3 8. Now you cannot submit the form unless you choose a branchcode 9. Make sure it still works normally when branchcode is not in PatronSelfRegistrationBorrowerMandatoryField Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 15:56:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 14:56:46 +0000 Subject: [Koha-bugs] [Bug 29603] Fix responsive behavior of facets menu in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #3 from Katrin Fischer --- This is blocked by the dependent patch still awaiting sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 18:26:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 17:26:24 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #13 from Martin Morris --- Good afternoon I've just upgraded to 21.11.02 and this problem has returned. Can I just reapply the patches which I previously applied for 21.11.01? Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 23:48:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 22:48:17 +0000 Subject: [Koha-bugs] [Bug 29795] If branch is mandatory on patron self registration form, the pull down should default to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Feb 13 23:49:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Feb 2022 22:49:26 +0000 Subject: [Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the ability to hide categorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 09:03:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 08:03:26 +0000 Subject: [Koha-bugs] [Bug 25670] Add useful methods to Koha::Acquisition::Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 --- Comment #20 from Jonathan Druart --- (In reply to Fridolin Somers from comment #19) > Still additional_work_needed ? > > Looks like there has been : > Bug 20212: Fix test after 25670 follow-up CommitDate: Thu Jan 28 16:44:12 2021 +0100 Last comment is from March. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 09:04:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 08:04:05 +0000 Subject: [Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 --- Comment #38 from Thibaud Guillot --- Hi Katrin, Thanks to you, I will remember that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 09:11:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 08:11:18 +0000 Subject: [Koha-bugs] [Bug 29962] Table of items on item edit page missing columns button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29962 --- Comment #3 from Jonathan Druart --- (In reply to Lucas Gass from comment #2) > This patch works and restores the Columns button. However the order of the > columns is wrong in the tool is wrong. This is a bit confusing. > > On every other page I looked at with a Columns button, the order in the tool > is the same as the order in the table. I would report this on a separate bug report. This one is restoring a regression from bug 27526. The way we deal with the table settings is different on this view, we pass the bKohaColumnsUseNames flag to KohaTable: we won't display all the columns defined in the yaml file, only those that have at least a non-empty value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 09:21:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 08:21:04 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #14 from Jonathan Druart --- (In reply to Martin Morris from comment #13) > Good afternoon > > I've just upgraded to 21.11.02 and this problem has returned. Can I just > reapply the patches which I previously applied for 21.11.01? > > Martin Can you add your Signed-off-by lines to them? That will make them move forward. https://wiki.koha-community.org/wiki/Sign_off_on_patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 09:21:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 08:21:45 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 09:24:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 08:24:06 +0000 Subject: [Koha-bugs] [Bug 27770] ES: Deprecated aggregation order key [_term] used, replaced by [_key] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130342|0 |1 is obsolete| | --- Comment #5 from Kevin Carnes --- Created attachment 130543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130543&action=edit Bug 27770: ES: Deprecated aggregation order key [_term] used, replaced by [_key] Starting in Elasticsearch 6.0 _key should be used instead of _term to order buckets by their term To test: 1) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 2) If you observe an error about types, apply patch for bug 25669 3) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 4) Observe if you get a deprecation warning about order key 5) Apply patch 6) Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t 7) Observe no deprecation warning about order key 8) Sign off Sponsored-by: Lund University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 12:30:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 11:30:33 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 12:30:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 11:30:37 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #2 from Lari Taskula --- Created attachment 130544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130544&action=edit Bug 22321: Add unit tests To test: 1. prove t/db_dependent/Illrequests.t 2. Observe test failure 1..3 ok 1 - before change, original borrowernumber found not ok 2 - after change, changed borrowernumber found in holds # Failed test 'after change, changed borrowernumber found in holds' # at t/db_dependent/Illrequests.t line 167. # got: '3786' # expected: '3787' ok 3 - after change, changed borrowernumber found in illrequests # Looks like you failed 1 test of 3. not ok 4 - store borrowernumber change also updates holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 12:30:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 11:30:41 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #3 from Lari Taskula --- Created attachment 130545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130545&action=edit Bug 22321: Update holds borrowernumber when ILL request borrowernumber changes To test: 1. prove t/db_dependent/Illrequests.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 12:30:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 11:30:44 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 --- Comment #4 from Lari Taskula --- Created attachment 130546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130546&action=edit Bug 22321: Allow managing the borrowernumber tied to ILL request Sometimes an ILL request is connected to the wrong borrower, and it would be nice to be able to connect it to the right one. In Swedish ILL the cardnumber of the patron connected with an ILL request is entered into the central Libris system and then propagated to Koha through the Libris API. This can lead to errors, and we have created a dummy "ILL patron" to catch these. It would then be good to be able to connect the ILL to the right patron in Koha. This commit makes it possible to edit illrequests.borrowernumber. To test: 1. Apply patch 2. Create two patrons, A and B 3. Create a new ILL request for patron A 4. Add a hold for patron A where biblionumber is the biblio tied to this ILL request 5. Go to cgi-bin/koha/ill/ill-requests.pl?method=edit_action&illrequest_id=161 6. Observe Patron ID is editable 7. Change borrowernumber to patron B's borrowernumber 8. Click save 9. Observe ILL request is now for patron B 10. Go to patron B's details at cgi-bin/koha/members/moremember.pl?borrowernumber=B_borrowernumber 11. At the bottom section of the page, click 1 Hold(s) 12. Observe the hold you placed at step 4 has transferred to patron b -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 12:32:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 11:32:47 +0000 Subject: [Koha-bugs] [Bug 30092] New: Random failure in t/db_dependent/Koha/Acquisition/Orders.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30092 Bug ID: 30092 Summary: Random failure in t/db_dependent/Koha/Acquisition/Orders.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org This was introduced by bug 25670: Master_D10 (#484) 14:03:26 koha_1 | # Failed test 'The 2 orders are returned' 14:03:26 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 152. 14:03:26 koha_1 | # Structures begin differing at: 14:03:26 koha_1 | # $got->[0] = '10' 14:03:26 koha_1 | # $expected->[0] = '9' 14:03:26 koha_1 | # Looks like you failed 1 test of 4. 14:03:26 koha_1 | 14:03:26 koha_1 | # Failed test 'filter_by_id_including_transfers() tests' 14:03:26 koha_1 | # at t/db_dependent/Koha/Acquisition/Orders.t line 160. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 12:33:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 11:33:01 +0000 Subject: [Koha-bugs] [Bug 30092] Random failure in t/db_dependent/Koha/Acquisition/Orders.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30092 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com Depends on| |25670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 [Bug 25670] Add useful methods to Koha::Acquisition::Orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 12:33:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 11:33:01 +0000 Subject: [Koha-bugs] [Bug 25670] Add useful methods to Koha::Acquisition::Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30092 [Bug 30092] Random failure in t/db_dependent/Koha/Acquisition/Orders.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 13:11:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 12:11:10 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 13:17:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 12:17:35 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #33 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #25) > I don't understand why the "Virtualshelves exceptions" part is in > Koha::Exception::Generic. I filed bug 30057 and submitted patches. Test plz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 13:32:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 12:32:44 +0000 Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 14:12:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 13:12:48 +0000 Subject: [Koha-bugs] [Bug 29853] Text needs HTML filter before KohaSpan filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29853 Solene D changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129325|0 |1 is obsolete| | --- Comment #4 from Solene D --- Created attachment 130547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130547&action=edit Bug 29853: Add HTML filter before KohaSpan filter Usage of Template Toolkit plugin KohaSpan as filter is actually : Group [% added.title | $KohaSpan class = 'name' | $raw %] created. But KohaSpan filter does not escape HTML characters. Whe should filter HTML then KohaSpan. This patch adds TT html filter before KohaSpan. Also replaces in Javascript html() with text() to ensure special caracters are still encoded. See https://api.jquery.com/text/ Test plan : 1) Create a library with name Libra'rie 2) Create a library group with name Grou'pe 3) Play with this group 4) Add library 5) Remove library 6) Edit group 7) Delete group 8) Each time check that &apos, is not interpreted as single quote Signed-off-by: Solène Desvaux -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 14:14:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 13:14:50 +0000 Subject: [Koha-bugs] [Bug 29853] Text needs HTML filter before KohaSpan filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29853 Solene D changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |solene.desvaux at biblibre.com --- Comment #5 from Solene D --- I have executed the test plan, it is working for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 14:27:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 13:27:20 +0000 Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 Solene D changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129938|0 |1 is obsolete| | --- Comment #2 from Solene D --- Created attachment 130548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130548&action=edit Bug 22276: Add client storage of user-selected DataTables configuration This patch enables use of DataTables' built-in session storage of table configurations. DataTables by default uses the browser's localstorage feature to store the state of each DataTable, including which columns have been hidden by the user. Our table settings system has always overridden this saved state. This patch adds a check for a saved configuration state and if present loads the saved state instead of the default state. The system is enabled in this patch on the libraries administration page. To test, apply the patch and open go to Administration -> Libraries. - Use the "Columns" button to change the visibility setting of multiple columns. - Navigate away from the page and then back to test that the visibility settings have been kept. - Go to Administration -> Table settings -> Administration and change the visibility settings for the "libraries" table in a way that it differs from the visibility settings you set manually. - Return to the libraries administration page and confirm that your manual settings are still being loaded instead of the defaults from table settings. Signed-off-by: Solène Desvaux -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 14:28:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 13:28:12 +0000 Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 Solene D changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |solene.desvaux at biblibre.com --- Comment #3 from Solene D --- I have executed the test, it is working for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 14:28:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 13:28:57 +0000 Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 Solene D changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:17:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:17:08 +0000 Subject: [Koha-bugs] [Bug 29921] Allow to index in Elasticsearch all records modified since a given date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29921 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:29:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:29:00 +0000 Subject: [Koha-bugs] [Bug 30093] New: Rewrite some of the patron searches when placing a hold with the REST API route Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Bug ID: 30093 Summary: Rewrite some of the patron searches when placing a hold with the REST API route Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:29:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:29:41 +0000 Subject: [Koha-bugs] [Bug 30094] New: Rewrite some of the patron searches when requesting an article with the REST API route Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094 Bug ID: 30094 Summary: Rewrite some of the patron searches when requesting an article with the REST API route Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:29:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:29:48 +0000 Subject: [Koha-bugs] [Bug 30093] Rewrite some of the patron searches when placing a hold with the REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:29:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:29:48 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 [Bug 30093] Rewrite some of the patron searches when placing a hold with the REST API route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:29:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:29:53 +0000 Subject: [Koha-bugs] [Bug 30094] Rewrite some of the patron searches when requesting an article with the REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 [Bug 30093] Rewrite some of the patron searches when placing a hold with the REST API route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:29:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:29:53 +0000 Subject: [Koha-bugs] [Bug 30093] Rewrite some of the patron searches when placing a hold with the REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094 [Bug 30094] Rewrite some of the patron searches when requesting an article with the REST API route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:30:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:30:06 +0000 Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30055 |30094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094 [Bug 30094] Rewrite some of the patron searches when requesting an article with the REST API route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:30:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:30:06 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30063 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 [Bug 30063] Make the main patron search use the /patrons REST API route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:30:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:30:06 +0000 Subject: [Koha-bugs] [Bug 30094] Rewrite some of the patron searches when requesting an article with the REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 [Bug 30063] Make the main patron search use the /patrons REST API route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:30:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:30:50 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|dependency | Depends on|29878 | Status|In Discussion |ASSIGNED --- Comment #10 from Owen Leonard --- I will re-work without the dependency on Bug 29878. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:30:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:30:50 +0000 Subject: [Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17018 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 [Bug 17018] Split AdvancedSearchTypes for staff and OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:31:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:31:49 +0000 Subject: [Koha-bugs] [Bug 30094] Rewrite the patron search when requesting an article with the REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30094 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rewrite some of the patron |Rewrite the patron search |searches when requesting an |when requesting an article |article with the REST API |with the REST API route |route | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:40:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:40:06 +0000 Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/-/tree/bug_30063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 15:41:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 14:41:03 +0000 Subject: [Koha-bugs] [Bug 30093] Rewrite the patron search when placing a hold with the REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rewrite some of the patron |Rewrite the patron search |searches when placing a |when placing a hold with |hold with the REST API |the REST API route |route | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 16:25:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 15:25:37 +0000 Subject: [Koha-bugs] [Bug 30095] New: Allow to change "warn when late" setting in subscriptions batch modification tool Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Bug ID: 30095 Summary: Allow to change "warn when late" setting in subscriptions batch modification tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 29996 Bug 29996 adds a "warn when late" setting for subscriptions. This bug is for being able to modify this setting in the subscriptions batch modification tool. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996 [Bug 29996] Show an alert on main page when serial issues are late -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 16:25:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 15:25:37 +0000 Subject: [Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 [Bug 30095] Allow to change "warn when late" setting in subscriptions batch modification tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 16:37:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 15:37:00 +0000 Subject: [Koha-bugs] [Bug 30095] Allow to change "warn when late" setting in subscriptions batch modification tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 --- Comment #1 from Julian Maurice --- Created attachment 130549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130549&action=edit Bug 30095: Add "warn when late" to subscriptions batch mod tool This patch depends on bug 29996 Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Warn when late" column 4. Submit the form without changing anything. Verify that the setting "warn when late" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Warn when late" to "No" and submit the form. Verify that the setting "warn when late" was changed to "No" for all selected subscriptions 6. Repeat steps 1 and 2. Set "Warn when late" to "Yes" and submit the form. Verify that the setting "warn when late" was changed to "Yes" for all selected subscriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 16:37:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 15:37:40 +0000 Subject: [Koha-bugs] [Bug 30095] Allow to change "warn when late" setting in subscriptions batch modification tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 16:39:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 15:39:37 +0000 Subject: [Koha-bugs] [Bug 29997] Allow to send email notification when a serial issue is late In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30096 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 [Bug 30096] Allow to change "late issue notification" setting in subscriptions batch modification tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 16:39:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 15:39:37 +0000 Subject: [Koha-bugs] [Bug 30096] New: Allow to change "late issue notification" setting in subscriptions batch modification tool Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 Bug ID: 30096 Summary: Allow to change "late issue notification" setting in subscriptions batch modification tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 29997 Bug 29997 adds a "late issue notification" setting for subscriptions. This bug is for being able to modify this setting in the subscriptions batch modification tool. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29997 [Bug 29997] Allow to send email notification when a serial issue is late -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 16:47:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 15:47:27 +0000 Subject: [Koha-bugs] [Bug 30096] Allow to change "late issue notification" setting in subscriptions batch modification tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 --- Comment #1 from Julian Maurice --- Created attachment 130550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130550&action=edit Bug 30096: Add "late issue notification" to subscriptions batch mod tool This patch depends on bug 29997 Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Late issue notification" column 4. Submit the form without changing anything. Verify that the setting "late issue notification" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Late issue notification" to one of the available options and submit the form. Verify that the setting "late issue notification" was changed to the selected option for all selected subscriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 16:47:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 15:47:44 +0000 Subject: [Koha-bugs] [Bug 30096] Allow to change "late issue notification" setting in subscriptions batch modification tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30096 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 17:41:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 16:41:29 +0000 Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit password expiration dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 17:41:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 16:41:32 +0000 Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit password expiration dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926 --- Comment #1 from Nick Clemens --- Created attachment 130551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130551&action=edit Bug 29926: Add pasword expiration route for API To test: 1 - prove -v t/db_dependent/api/v1/patrons_password_expiration.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 17:41:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 16:41:35 +0000 Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit password expiration dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926 --- Comment #2 from Nick Clemens --- Created attachment 130552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130552&action=edit Bug 29926: Add ability for superlibrarian to view/edit password expiration To test: 1 - Sign in as a superlibrarian 2 - Find a patron account with no password expiration set 3 - View member detials 4 - note expiration says 'Never' 5 - Edit patron 6 - Set patron expiration 7- Save 8 - View details, confirm password expiration shows correctly 9 - Sign in as non-superlibrarian 10 - Confirm you don't see expirationdate on details page 11 - Edit patron and confirm password expiration does not show 12 - Edit HTML and confirm you epxiration date not saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 17:41:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 16:41:38 +0000 Subject: [Koha-bugs] [Bug 29926] Add ability for superlibrarians to edit password expiration dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926 --- Comment #3 from Nick Clemens --- Created attachment 130553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130553&action=edit Bug 29926: Add ability for superlibrarians to batch edit password expiration dates To test: 1 - Sign in as a superlibrarian 2 - Tools->Batch patron modification 3 - Add patrons with and without pasword expiration set 4 - Confirm dates display correctly on modification page, or show never 5 - Check the box to delete all dates 6 - Confirm patrons now show 'Never' 7 - Edit patrons again, set a date 8 - Confirm date is set correctly 9 - Sign in as a user with catalogue/tools/borrowers permissions, but not superlibrarian 10 - Confirm y9ou do not see, and cannnot edit password expiration dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 17:43:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 16:43:37 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 --- Comment #6 from David Nind --- (In reply to Owen Leonard from comment #4) > Tested using the query "select sleep(10)" Nice tip - thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 17:54:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 16:54:35 +0000 Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement shows a release notes| |saved SQL report's ID in | |the database process list | |(from example, "-- | |saved_sql.id=123"). This | |can help when | |troubleshooting reports | |that are causing issues, | |such as taking too long to | |run or taking up too many | |system resources. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 18:36:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 17:36:20 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 18:36:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 17:36:23 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130243|0 |1 is obsolete| | --- Comment #10 from David Nind --- Created attachment 130554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130554&action=edit Bug 29960: Remove Modernizr dependency in the OPAC This patch refactors the code around JavaScript-driven responsive behavior in the OPAC. The use of Modernizr dropped and the dependency removed. This patch also adds a missing listing for Enquire.js licensing on the "About" page. To test, apply the patch and perform a catalog search in the OPAC. - Narrow your browser window until its width falls below 609 pixels (Using your browser's Responsive Design Mode is helpful for this, e.g. https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode) - The window should automatically scroll to the "main content" area, in this case the section headed by "Your search returned..." - Change your browser window's width until it falls below 768 pixels. - Scroll to the bottom of the search results where you should find the "Refine your search" facets box collapsed. - As you increase your browser width above 768 pixels the facets box should expand. Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 18:36:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 17:36:28 +0000 Subject: [Koha-bugs] [Bug 29960] Remove Modernizr dependency in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29960 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130489|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 130555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130555&action=edit Bug 29960: (follow-up) Include enquire.js in print slip template This patch adds enquire.js to the print slip template in order to prevent a JS error. Also removed is a line from global.js which was added in the previous patch and which was an unwanted change. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 18:46:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 17:46:57 +0000 Subject: [Koha-bugs] [Bug 30088] Forgotten password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30088 --- Comment #2 from Christopher Brannon --- Oh, yeah! I'm having problems with ideas, apparently. Of course they already get an e-mail. As far as the two lines go, I guess perhaps it should be reworded, or maybe guided? Even though it says to enter either, it looks like you should enter both. Maybe it should start with picking one, then prompting for the info. Then if it needs more (in the case of the e-mail address being detected on more than one account) it should ask for a username. That might make it a little more clear. It just seems if you present patrons with an option to use either, and then go for the e-mail, and they actually need both, then they are going to get frustrated or give up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 18:47:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 17:47:58 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cbrannon at cdalibrary.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 18:49:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 17:49:42 +0000 Subject: [Koha-bugs] [Bug 20161] Show same information for format, material type etc. on the detail page as in the result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20161 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 19:02:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 18:02:02 +0000 Subject: [Koha-bugs] [Bug 30097] New: Cataloguing - advanced editor not loading Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30097 Bug ID: 30097 Summary: Cataloguing - advanced editor not loading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: david at davidnind.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 130556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130556&action=edit Screenshot - Loading message fro advanced cataloguing editor When accessing the advanced editor for cataloguing it does not load - see the screenshot. The screen says "Loading, please wait.." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 14 19:09:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Feb 2022 18:09:44 +0000 Subject: [Koha-bugs] [Bug 30097] Cataloguing - advanced editor not loading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30097 --- Comment #1 from David Nind --- Browser console errors when trying to load the advanced cataloguing editor in master: 1. Internal server error - see also bug 29973: 06:56:33.005 GEThttp://127.0.0.1:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define [HTTP/1.1 500 Internal Server Error 107ms] GET http://127.0.0.1:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define Status 500 Internal Server Error VersionHTTP/1.1 Transferred15.05 KB (14.85 KB size) Referrer Policystrict-origin-when-cross-origin .... 2. Loading failed error: 06:56:33.114 Loading failed for the [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 18:18:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 17:18:10 +0000 Subject: [Koha-bugs] [Bug 30196] Odd number of elements warning caused by dt_from_string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30196 --- Comment #1 from Blou --- Created attachment 131170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131170&action=edit Bug 30196: Odd number of elements warning caused by dt_from_string Koha/DateUtils' dt_from_string is a sub expected to return a scalar, but does not in all case. In one instance, tt simply return... nothing, which cause one common call output_pref( { dt => dt_from_string( $serinfo->{$d} ), dateonly => 1 } ); to output a warning. Simply returning undef instead will solve the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 18:18:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 17:18:57 +0000 Subject: [Koha-bugs] [Bug 30196] Odd number of elements warning caused by dt_from_string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30196 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 18:25:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 17:25:48 +0000 Subject: [Koha-bugs] [Bug 30150] Dutch option in language limits is garbled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30150 --- Comment #2 from Eric Phetteplace --- I just used a report `select * FROM language_descriptions` and found the Dutch entries further down. If I run your query I get this: subtag type lang description id nl language de Niederländisch 138 nl language en Dutch 26 nl language fr Néerlandais 27 nl language nl nedərlɑns 25 NL region en Netherlands 299 NL region nl Nederland 300 Should we change the "nedərlɑns" description in the database to "Nederlands" then? It displays right in the reports results, the only problem is on the advanced search page. I see the same results you've shown on koha-testing-docker so perhaps this was changed at some point? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 18:31:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 17:31:13 +0000 Subject: [Koha-bugs] [Bug 19859] Add option to return to the search result in authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19859 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 19:16:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 18:16:57 +0000 Subject: [Koha-bugs] [Bug 12469] Add more information to the ILS-DI results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469 --- Comment #15 from Koha Team University Lyon 3 --- Hi, I don't know for the return date but the callnumber is now part of the ilsi result : cf https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 19:20:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 18:20:36 +0000 Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131065|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes --- Created attachment 131171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131171&action=edit Bug 20615: Add the link of number of times the authority are used in edit mode Currently when show an authority record you can see the count of records linked with that authority, but when edit that authority record the that detail is dissapeared. Applying this patch will have that information also on edit mode of authority. Test plan: 1) Search for an authority that is already connected with at least one record 2) On detail view of an authority you can check that authority is linked with x records. 3) Edit that authority and the information about in how many records that authority is linked is missing. 4) Apply this patch 5) Edit again that authrity and you can find now the count in how many records is used that authority Signed-off-by: Marjorie Barry-Vila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 19:22:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 18:22:50 +0000 Subject: [Koha-bugs] [Bug 30179] Make OPAC moresearches menu more responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30179 --- Comment #6 from Katrin Fischer --- Hi Lucas, is something wrong with the patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 19:25:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 18:25:43 +0000 Subject: [Koha-bugs] [Bug 30179] Make OPAC moresearches menu more responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30179 --- Comment #7 from Lucas Gass --- (In reply to Katrin Fischer from comment #6) > Hi Lucas, is something wrong with the patch? Yes! Sorry, I meant to update. I realized, after looking again, this doesn't work good from an accessibility standpoint. The responsive menu cannot be navigated with well with a screen reader to tabbed through easily. I will work on a follow-up ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 19:26:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 18:26:31 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #11 from Katrin Fischer --- (In reply to Jonathan Druart from comment #10) > This follow-up is a no-op, we shouldn't need it. It would be just to silence the QA test tools. But you are right, it's no funtional change (are raw filters ever?) :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 19:30:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 18:30:18 +0000 Subject: [Koha-bugs] [Bug 30150] Dutch option in language limits is garbled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30150 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Katrin Fischer --- (In reply to Eric Phetteplace from comment #2) > I just used a report `select * FROM language_descriptions` and found the > Dutch entries further down. If I run your query I get this: > > subtag type lang description id > nl language de Niederländisch 138 > nl language en Dutch 26 > nl language fr Néerlandais 27 > nl language nl nedərlɑns 25 > NL region en Netherlands 299 > NL region nl Nederland 300 > > Should we change the "nedərlɑns" description in the database to "Nederlands" > then? It displays right in the reports results, the only problem is on the > advanced search page. I see the same results you've shown on > koha-testing-docker so perhaps this was changed at some point? I am not sure if we can trust the report here... what you see here are nedərlɑns HTML-entities that would look correct in the browser as it renders them (unless they are escaped, as it probably happens on the advanced search. Could you try and download the CSV export to compare? About the right naming I am not sure, but adding Marcel for maybe some help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 19:31:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 18:31:34 +0000 Subject: [Koha-bugs] [Bug 30179] Make OPAC moresearches menu more responsive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30179 --- Comment #8 from Katrin Fischer --- Thx for clarifying and great to hear about your testing for accessibility! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 19:34:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 18:34:19 +0000 Subject: [Koha-bugs] [Bug 5598] More Granular Cloning Circulation & Fine Rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5598 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 19:36:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 18:36:49 +0000 Subject: [Koha-bugs] [Bug 19745] Add Edit button for all the areas in circulation and fines rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19745 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 19:46:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 18:46:34 +0000 Subject: [Koha-bugs] [Bug 22240] Add possibility to specify a category of patron in calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22240 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Feb 28 19:49:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 18:49:57 +0000 Subject: [Koha-bugs] [Bug 30150] Dutch option in language limits is garbled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30150 --- Comment #4 from Eric Phetteplace --- You're correct, it's stored in the database with HTML character references, but renders as you would want on the reports page. This is the CSV export's content from our live Koha instance (21.05.09.000): subtag,type,lang,description,id nl,language,de,Niederländisch,138 nl,language,en,Dutch,26 nl,language,fr,Néerlandais,27 nl,language,nl,nedərlɑns,25 NL,region,en,Netherlands,299 NL,region,nl,Nederland,300 So the question is why the character references aren't interpreted in the