[Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches with null or empty branchcode

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Useless warning in          |Manage call of Template
                   |t/db_dependent/Template/Plu |Plugin Branches with null
                   |gin/Branches.t              |or empty branchcode

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Marcel de Rooy from comment #5)
> This report refers to the test. So the suggestion thing might be a different
> case. Or widen the scope by changing the title?
Ah good point, I change title.

> 
> +    return q{} unless defined $branchcode;
> This still has the effect of testing if there is a branch with an empty
> code. Which makes no sense either?
> So you could also return unless $branchcode.
Ah indeed.
But we must allow branchcode=0.

-- 
You are receiving this mail because:
You are watching all bug changes.