[Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Feb 1 01:23:57 CET 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826

--- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 130030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130030&action=edit
Bug 29826: Manage call of Template Plugin Branches GetName() with null or empty
branchcode

Bug 26587 added a concatenation that sends a warning if var is undef :
$ prove t/db_dependent/Template/Plugin/Branches.t
Use of uninitialized value $branchcode in concatenation (.) or string at
/kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 35.

This patch adds an early return empty string when GetName is called with
$branchcode null or empty string.

Test plan :
1) Run t/db_dependent/Template/Plugin/Branches.t without patch
2) Run with the patch to see warning disappear

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list