[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #19)
> Created attachment 130016 [details] [review]
> Bug 29458: Fix selenium test
> 
> The authentication.t selenium tests (and a couple of others) were
> failing with:
> Error while executing command: element not interactable: Element <input
> class="btn btn-primary" type="submit"> could not be scrolled into view at
> /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 411. at
> /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 356.
> 
> We changed the other of the form, and t::lib::Selenium::submit_form was
> not getting the correct (first) form. The one from the auth modal was
> retrieved and submit button was clicked. Selenium raised an error as it
> is not displayed.
> The ->is_displayed selenium method does not work, as per the doc
> """
> Note: This does *not* tell you an element's 'visibility' property; as it
> still takes up space in the DOM and is therefore considered 'displayed'.
> """
> https://metacpan.org/pod/Selenium::Remote::WebElement#is_displayed
> 
> "The internet" is saying we should be able to use the following in our
> xpath expression: not(ancestor::div[contains(@style,'display:none')]
> but it actually only works if the display:none rule is defined on the
> node (not from .css). Which does not work for us.
> 
> The only solution I found is to check for the size of the element, which
> is (0,0) if not effectively displayed.

Thanks. Too bad that we need such workarounds.

-- 
You are receiving this mail because:
You are watching all bug changes.