[Koha-bugs] [Bug 30027] New: Koha::Account->payout_amount should not total the lines in perl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30027

            Bug ID: 30027
           Summary: Koha::Account->payout_amount should not total the
                    lines in perl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Currently the routine calls:
585     my $outstanding_credits =
586       exists( $params->{credits} )
587       ? $params->{credits}
588       : $self->outstanding_credits->as_list;
589     for my $credit ( @{$outstanding_credits} ) {
590         $outstanding += $credit->amountoutstanding;
591     }

We should instead call: Koha::Account::Lines->total_outstanding on the
Resultlines in order to avoid floating point rounding errors


Currently we see some amounts for refunds Throwing a 500 error, and in
plack-error.log:
Amount to payout (81.98) is higher than amountoutstanding (81.98)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.