[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398

--- Comment #21 from Thibaud Guillot <thibaud.guillot at biblibre.com> ---
(In reply to David Nind from comment #19)
> I have tested this and it works as expected. I would suggest these changes:
>  
> 1. System preference name: change from HighlightedWords to
> StaffHighlightedWords
>  
> 2.System preference wording:
>   . Current: Don't highlight|Highlight words the patron searched for in
> their search results and detail pages.
>   . Suggested: Don't highlight|Highlight words searched for in the staff
> interface search results pages.
>   . Notes: For me the highlighting is only working on the search listing
> results pages, not on the record detail pages.
>  
>  - Location in the system preferences area: I would put under Staff
> interface > Appearance as this is consistent with the OPAC system
> preference, rather than under Searching > Results display.
>  
>  - Enable highlighting by default: as this is a change in the default
> behavour I would tend to leave the default (highlighting) enabled, rather
> than disabling it (that is, set the default to Highlight).

Hello David, 

Thanks for you feedback :)

I completely understand your notes, I'm agree for the syspref name : the more
precise, the better it will be.

Also for the description, my english is not as good as i would like ^^ so I
change this too.

And for the location... yes totally correct and adequate I concede it, like the
default behavior as you notice.

So I push again the patch with all this changes, thanks to tell me your opinion
:) 
And if other people test it of course we can discuss

-- 
You are receiving this mail because:
You are watching all bug changes.