[Koha-bugs] [Bug 30066] New: POD for chargeable_units on CalcFine wrong?

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30066

            Bug ID: 30066
           Summary: POD for chargeable_units on CalcFine wrong?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Developer documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

POD reads:

C<$chargeable_units> is the number of chargeable units (days between start and
end dates, Calendar adjusted where needed,
minus any applicable grace period, or hours)

But actually it looks like the grace period (firstremind) is still included.

Otherwise this would make no sense:

my $chargeable_units = get_chargeable_units($fine_unit, $start_date, $end_date,
$branchcode);
my $units_minus_grace = $chargeable_units - ($issuing_rule->{firstremind} ||
0);
my $units = C4::Context->preference('FinesIncludeGracePeriod') ?
$chargeable_units : $units_minus_grace;

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.