[Koha-bugs] [Bug 13952] Import and export of authority types

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #161 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We'll need a small fix here:

1) QA test tools

 FAIL   admin/import_export_authtype.pl
   FAIL   critic
                Subroutine "new" called using indirect syntax at line 36,
column 13. See page 349 of PBP.

2) Text

+Export all the information of a MARC or Authority Type Framework to an excel
"xml" file, comma separated values "csv" file or OpenDocument SpreadSheet "ods"
file.

As the authority types are also MARC... maybe we could make this read:

Export all information of a bibliographic or authority MARC framework to an
Excel "xml" file, comma separated values "csv" or OpenDocument SpreadSheet
"ods".

3) Unit tests

The unit tests pass, but there is 'tons' of these with the patches, while the
output without the patches is clean:

Use of uninitialized value $frameworktype in string eq at
/kohadevbox/koha/C4/ImportExportFramework.pm line 1004, <$dom> line 21.
Use of uninitialized value $frameworktype in string eq at
/kohadevbox/koha/C4/ImportExportFramework.pm line 678.

4) Translatability

In .js files you need to use a double undescore for making things translatable:

alert(_("Error importing the authority type
%s").format(decodeURIComponent(matches[1])));

Should be: __("Error...

5) First import/export test looks great :)

-- 
You are receiving this mail because:
You are watching all bug changes.