[Koha-bugs] [Bug 30089] Placing holds on OPAC broken

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30089

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130581|0                           |1
        is obsolete|                            |

--- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 130583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130583&action=edit
Bug 30089: Fix placing holds on OPAC after Bug 29844

When trying to place a hold in the OPAC, either multi hold or a single hold,
the page explodes with:
The method Koha::AuthorisedValues->authorised_value is not covered by tests!

We could fix by adding ->as_list.
This patch fixes by using
Koha::AuthorisedValues->get_description_by_koha_field on each item
instead of Koha::AuthorisedValues->search_by_koha_field list.
Performance should be OK because this method as cache.
This is used a lot in staff interface.

Test plan :
1) In staff interface find a record with several items available
   For example in KTD biblionumer=126
2) Edit on item and change 'not for loan' to a non-zero value
   For example in KTD $7 = Staff Collection
3) Go to OPAC on this record
4) Place hold
5) Click on 'A specific item'
=> Check you see not for loan authorised value description
   For example in KTD '(Staff Collection)'

-- 
You are receiving this mail because:
You are watching all bug changes.