[Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Feb 18 17:20:59 CET 2022
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782
Nick Clemens <nick at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #129939|0 |1
is obsolete| |
Attachment #129940|0 |1
is obsolete| |
Attachment #130663|0 |1
is obsolete| |
Attachment #130664|0 |1
is obsolete| |
--- Comment #30 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 130868
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130868&action=edit
Bug 28782: Use query param list instead of splitting elements using '/'
This removes the need to handle single and multiple cases separately,
thus removing bunch if-else cases and simplifying our code. This
coding style is also in line with our other .pl scripts.
To test:
1) Make sure placing a hold still works from the following pages:
/cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX
/cgi-bin/koha/catalogue/search.pl?q=a
/cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=XXXX
/cgi-bin/koha/clubs/clubs.pl (create a new club and add a patron
there and through the clubs.pl create a hold to a bib)
Signed-off-by: Hayley Pelham <hayleypelham at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list