[Koha-bugs] [Bug 30133] Pagination broken on pickup_locations routes when AllowHoldPolicyOverride=1
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Feb 21 12:51:52 CET 2022
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30133
--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 130955
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130955&action=edit
Bug 30133: Simplify code
This patch simplifies the code, and also fixes a problem with branchcode
comparisson failing, highlighted when running the tests
To test:
1. Apply the regression tests
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/items.t
=> FAIL: Tests fail. Notably:
- Link header pagination is wrong
- X-*Total-Count headers have two values (dupicated)
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list