[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lari.taskula at hypernova.fi

--- Comment #7 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Magnus Enger from comment #5)
> After applying these patches I get this when I try to create a new
> illrequest:
> 
> Can't call method "borrowernumber" on an undefined value at
> /home/me/kohaclone/Koha/Illrequest.pm line 1643.
> 
> 1637     my @holds;
> 1638     if( defined $updated_columns{'borrowernumber'} and
> 1639         Koha::Patrons->find( $updated_columns{'borrowernumber'} ) )
> 1640     {
> 1641         # borrowernumber has changed
> 1642         my $old_illreq = $self->get_from_storage;
> 1643         @holds = Koha::Holds->search( {
> 1644             borrowernumber => $old_illreq->borrowernumber,
> 1645             biblionumber   => $self->biblio_id,
> 1646         } )->as_list;
> 1647     }
> 
> Not sure what the problem is, but could it be that this works for existing
> requests, but for new ones there just isn't an $old_illreq to get the
> borrowernumber from?

Good catch. I've added an unit test to cover this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.