[Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Feb 25 20:20:27 CET 2022
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771
Nick Clemens <nick at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128910|0 |1
is obsolete| |
--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 131130
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131130&action=edit
Bug 29771: Scalar context for split
This patch tackles a very specific scenario. Calling split(...,
CGI::param) makes it be called in list context. The split docs say:
split /PATTERN/,EXPR,LIMIT
this means the first CGI param will be used as EXPR and the second one
as LIMIT, which is wrong anyway. So the fix is to just force scalar
context.
To test:
1. Not sure, just make sure nothing breaks when using the scripts in the
browser.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list