[Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Janusz Kaczmarek from comment #5)
> Katrin, you are right, it is confusing.  I wish it was a branch code, but it
> is not--it is the name.  Have a look at columns_to_str here
> (cataloguing/additem.pl):
> 
> my @items;
> for my $item ( $biblio->items->as_list, $biblio->host_items->as_list ) {
>     push @items, $item->columns_to_str;
> }
> 
> It took me some time to figure this out.  The values of item.homebranch are
> then put directly into the table for users, so--I guess--it has been decided
> to pass this like this...

We just arrived at the same spot :) I first confirmed it by adding the line to
the templates:

[% item.homebranch %] | [% Branches.GetLoggedInBranchname() %]

So the fix is correct, but I feel we might want to revisit this confusing
variable at some point. Changing code to name is an easy template task, so
passing it like this appears not necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.