[Koha-bugs] [Bug 27123] Add messages to batch patrons modification

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
            Summary|Add messaging preferences   |Add messages to batch
                   |to batch patrons            |patrons modification
                   |modification                |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jeremy,

0) Please assign yourself the bugs you plan to work on :)

1) QA test tools

A good habit to start is to always run the QA test tools against your patches
before submitting, so simple stuff doesn't get your patches sent back:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
   FAIL   filters
                missing_filter at line 265 (                                   
                        [% patron_message.message %] <br>)

 FAIL   tools/modborrowers.pl
   FAIL   spelling
                 bloc ==> block

For adding the filter, this might be helpful in the future:
misc/devel/add_missing_filters.pl

2) Code comments in English please :)

+        # Créer un bloc pour enregistrer en bdd l'update de la table
patron_messages + sécurité : 'si' tel champ est remplit alors.... etc

Can you please provide a follow-up and switch back to signed off?

-- 
You are receiving this mail because:
You are watching all bug changes.