From bugzilla-daemon at bugs.koha-community.org Sat Jan 1 13:27:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jan 2022 12:27:12 +0000
Subject: [Koha-bugs] [Bug 29778] New: Deleted additional_contents remain
visible
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778
Bug ID: 29778
Summary: Deleted additional_contents remain visible
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
We have had 2 reports about this on the mailing list from 3 different people so
far. It was not possible yet to determine the cause:
https://lists.katipo.co.nz/pipermail/koha/2021-December/057161.html
https://lists.katipo.co.nz/pipermail/koha/2021-December/057186.html
I've tried to replicate on master, but no luck so far.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jan 1 14:08:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jan 2022 13:08:45 +0000
Subject: [Koha-bugs] [Bug 28832] [21.05] Batch modification always clears
permanent_location if it is mapped in frameworks
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Batch modification always |[21.05] Batch modification
|clears permanent_location |always clears
|if it is mapped in |permanent_location if it is
|frameworks |mapped in frameworks
--- Comment #17 from Katrin Fischer ---
I missed that this was for an older version only - I have added to the
description to make it more visible.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 12:30:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 11:30:53 +0000
Subject: [Koha-bugs] [Bug 27978] Marc modification templates should allow
for copying an entire field to a field/subfield and vice versa
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27978
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mathsabypro at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 12:31:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 11:31:45 +0000
Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when
adding/updating bibliographic records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mathsabypro at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 12:32:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 11:32:03 +0000
Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications
templates are not added in an ordered way
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480
mathieu saby changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mathsabypro at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 15:55:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 14:55:27 +0000
Subject: [Koha-bugs] [Bug 29778] Deleted additional_contents remain visible
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |critical
--- Comment #1 from Katrin Fischer ---
I have managed to find the steps to make this bug visible:
1) Install an additional language, like de-DE
2) Activate language
3) Add a new HTML customization entry
* Fill in default and Englis
* Fill in the additional installed language
* Save
4) Verify the contents show as they should
5) Delete the entry
6) Verify the content remain for the additional language
This can also be verified by running: select * from additional_contents;
In my case I deleted everything else and now only this entry remains that is
not visible from the GUI:
+-------+---------------------+---------------------+-------------------+------------+-------+---------+-------+--------------+---------------------+----------------+--------+----------------+
| idnew | category | code | location |
branchcode | title | content | lang | published_on | updated_on |
expirationdate | number | borrowernumber |
+-------+---------------------+---------------------+-------------------+------------+-------+---------+-------+--------------+---------------------+----------------+--------+----------------+
| 7 | html_customizations | OpacMainUserBlock_6 | OpacMainUserBlock | NULL
| test | test | de-DE | 2022-01-02 | 2022-01-02 01:46:58 | NULL
| NULL | 51 |
+-------+---------------------+---------------------+-------------------+------------+-------+---------+-------+--------------+---------------------+----------------+--------+----------------+
Updating severity as this means people have no way to change or remove unwanted
content - we need to fix this and also include a database update.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 15:56:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 14:56:07 +0000
Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents is incomplete
and leaves entries for additional languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Deleted additional_contents |Deleting
|remain visible |additional_contents is
| |incomplete and leaves
| |entries for additional
| |languages
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 15:58:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 14:58:18 +0000
Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries
for additional languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Deleting |Deleting
|additional_contents is |additional_contents leaves
|incomplete and leaves |entries for additional
|entries for additional |languages
|languages |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:10:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:10:37 +0000
Subject: [Koha-bugs] [Bug 27189] Unable to delete patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27189
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |MOVED
--- Comment #3 from Katrin Fischer ---
We finally tracked this down to a DBD::mysql::db do failed: Row size too large.
error on the borrower_modifications table. The failed update would have added
the extended_attributes column which than caused the issue on patron deletion.
I am reclosing this, but with a link to bug 28267.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:13:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:13:45 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
20.05.xx to 20.11.04-1
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267
--- Comment #25 from Katrin Fischer ---
It looks like the borrower_modifications table can also be affected as we had
this one failing with the known "Row size too large." error:
$DBversion = "16.12.00.001";
if ( CheckVersion($DBversion) ) {
$dbh->do(q{
ALTER TABLE borrower_modifications
ADD COLUMN extended_attributes text DEFAULT NULL
AFTER privacy
});
print "Upgrade to $DBversion done (Bug 17767 - Let
Koha::Patron::Modification handle extended attributes)\n";
SetVersion($DBversion);
}
Is there a way we could fix this once and for all? Or at least provide
information/warning to users?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:13:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:13:59 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
20.05.xx to 20.11.04-1
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=27189
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:13:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:13:59 +0000
Subject: [Koha-bugs] [Bug 27189] Unable to delete patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27189
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=28267
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:14:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:14:51 +0000
Subject: [Koha-bugs] [Bug 29756] No Place hold button on OPAC details page
if number of items exceeds OpacMaxItemsToDisplay
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29756
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|minor |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:18:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:18:15 +0000
Subject: [Koha-bugs] [Bug 29774] Self registration notification management
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29774
--- Comment #1 from Katrin Fischer ---
If you require email verification there won't be a patron account added
immediately, so there is no borrowernumber the notice could be linked to. The
patron account is only created after the user has clicked on the link in the
email.
But you might be referring to a different workflow? Maybe using the patron
import tool or the ACCTDETAILS email?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:19:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:19:42 +0000
Subject: [Koha-bugs] [Bug 29769] Claim return status cannot be changed
without checking item in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29769
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |24279
Version|21.05 |master
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279
[Bug 24279] Claims Returned does not work when set from moredetail.pl or
additem.pl
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:19:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:19:42 +0000
Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from
moredetail.pl or additem.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |29769
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29769
[Bug 29769] Claim return status cannot be changed without checking item in
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:22:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:22:32 +0000
Subject: [Koha-bugs] [Bug 24115] patron import tool should have option to
not overwrite specific fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24115
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #2 from Katrin Fischer ---
Hi, I believe this is a duplicate to bug 27883 which implemented this in 21.11.
*** This bug has been marked as a duplicate of bug 27883 ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:22:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:22:32 +0000
Subject: [Koha-bugs] [Bug 27883] Add ability to preserve patron field from
being overwritten by import
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeremy.evans at phe.gov.uk
--- Comment #27 from Katrin Fischer ---
*** Bug 24115 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:27:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:27:22 +0000
Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in
export_records.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #56 from Katrin Fischer ---
(In reply to Cab Vinton from comment #55)
> Will this enhancement be available from the staff interface? i.e., Tools >
> Export data (.../cgi-bin/koha/tools/export.pl)
>From looking at the patch set this will only appear in the command line script.
But as this has been waiting a while now, I suggest we file a separate report
for making this available on GUI side. What do you think?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:29:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:29:23 +0000
Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on
borrower edit screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:31:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:31:26 +0000
Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds Queue
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|21.05 |master
--- Comment #1 from Katrin Fischer ---
+1
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:34:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:34:21 +0000
Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not
running in verbose mode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054
--- Comment #5 from Katrin Fischer ---
I agree with only giving this note with -v as at the moment if you have
scheduled this on a server with multiple instances where the pref is turned off
intentionally, it creates quite a bit of noise.
It's not a fatal one I think, so would fit the description of -v, just
referring to a configuration issue.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:37:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 15:37:33 +0000
Subject: [Koha-bugs] [Bug 29739] Add a staff counterpart for
OPACURLOpenInNewWindow
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29739
--- Comment #1 from Katrin Fischer ---
+1
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:08:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:08:48 +0000
Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to
notice templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208
Björn Nylén changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128587|0 |1
is obsolete| |
Attachment #128588|0 |1
is obsolete| |
Attachment #128589|0 |1
is obsolete| |
Attachment #128590|0 |1
is obsolete| |
--- Comment #15 from Björn Nylén ---
Created attachment 128948
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128948&action=edit
Bug 27208: Add the ability to delay pickup notices.
This bug adds the ability to delay sending a pickup notice. This can be done in
two
ways, either by a fixed configurable delay of all pickup notices or a time
selectable
by staff at checkin. This is controlled by two new system preferences,
PickupNoticeDelayMode and PickupNoticeDelayDuration. A delayed notice will also
be
visible in the patron notice log.
To test:
1. Apply patch and run updatedatabase.pl to add new column to message_queue.
2. Check in items with holds with different delay modes ('no delay','fixed
delay','selectable by staff').
3. Check the patron notice logs to check notice delay. Delayed notices have
status 'pending, delayed until...'
4. Expected behaviour is:
'No delay': No notices are delayed.
'Fixed delay': All pickup notices are delayed by the no of hours set in
PickupNoticeDelayDuration.
'Delay selectable by staff': Pickup notice is delayed until the time set in
UI. If no delay is set,
notice will not be delayed. Also note the
warning at the checkin page
when a delay is set.
5. Run process_message_queue.pl before and after the delay times above. Notices
without delay are sent
immediatly, delayed notices are only sent after the set time.
6. Tests should pass.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:08:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:08:52 +0000
Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to
notice templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208
--- Comment #16 from Björn Nylén ---
Created attachment 128949
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128949&action=edit
Bug 27208: Atomicupdate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:08:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:08:57 +0000
Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to
notice templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208
--- Comment #17 from Björn Nylén ---
Created attachment 128950
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128950&action=edit
Bug 27208: Schema changes
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:09:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:09:01 +0000
Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to
notice templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208
--- Comment #18 from Björn Nylén ---
Created attachment 128951
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128951&action=edit
Bug 27208: Unit tests
This commit adds unit test for changes in C4/Letters.pm and C4/Reserves.pm
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:11:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:11:13 +0000
Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to
notice templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208
--- Comment #19 from Björn Nylén ---
Updated patch. Behavior is now controlled by PickupNoticeDelayMode and allows
either a fixed delay or one set by the librarian at checkin.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:36:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:36:50 +0000
Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club
without members
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128836|0 |1
is obsolete| |
--- Comment #6 from Katrin Fischer ---
Created attachment 128953
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128953&action=edit
Bug 29736: Don't return empty clubs
There is an error when placing a hold for a club without members:
Uncaught TypeError: err.responseJSON.error is undefined
It seems that we should remove clubs without members from the search.
Test plan:
Create 1 club xx with 2 patrons
Create 1 club xxx with 1 patron and cancel their enrolment
Create 1 club xxxx without patron
Place a hold for club "x", only the first one should be returned with
this patch.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:36:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:36:53 +0000
Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club
without members
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128837|0 |1
is obsolete| |
--- Comment #7 from Katrin Fischer ---
Created attachment 128954
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128954&action=edit
Bug 29736: Restore searching
Without this patch, the list will always display all clubs.
To test:
1. Have two clubs, with enrollemnts:
- Cthulhu fans
- The Shadow Out of Time fans
2. Search for the letter c
=> FAIL: You get both results
3. Apply this patch
4. Repeat 2
=> SUCCESS: Only Cthulhu is returned
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:36:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:36:58 +0000
Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club
without members
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128838|0 |1
is obsolete| |
--- Comment #8 from Katrin Fischer ---
Created attachment 128955
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128955&action=edit
Bug 29736: (QA follow-up) No need to delete all clubs
There's no real need to delete all the existing clubs in the tests.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:37:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:37:06 +0000
Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club
without members
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:39:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:39:30 +0000
Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on
request.pl before a patron is selected
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
--- Comment #28 from Katrin Fischer ---
Sorry Nick, can you please rebase?
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 29043: Don't load items unless a p[atron has been chosen on
request.pl
Using index info to reconstruct a base tree...
M reserve/request.pl
Falling back to patching base and 3-way merge...
Auto-merging reserve/request.pl
CONFLICT (content): Merge conflict in reserve/request.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 29043: Don't load items unless a p[atron has been
chosen on request.pl
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-29043-Dont-load-items-unless-a-patron-has-been-vtn8py.patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:43:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:43:40 +0000
Subject: [Koha-bugs] [Bug 29320] Use OverDrive availability API V2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29320
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:43:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:43:44 +0000
Subject: [Koha-bugs] [Bug 29320] Use OverDrive availability API V2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29320
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #126920|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 128956
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128956&action=edit
Bug 29320: Update OverDrive availability to V2
This patch updates the call to overdrive_proxy to allow passing a version
and updates the code to use V2 for availability
To test:
1 - Enable OverDrive integration by setting the sysprefs
2 - Log in to your overdrive account in the Koha opac
3 - Perform a search and note availability display
4 - Confirm you can checkout/hold/return books
5 - Apply patch
6 - Repeat search and test functionality
7 - Note that title with '0 out of 0 copies available' now say 'Currently
unavailable'
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:45:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jan 2022 16:45:01 +0000
Subject: [Koha-bugs] [Bug 29320] Use OverDrive availability API V2
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29320
--- Comment #4 from Katrin Fischer ---
Obviously I couldn't test this, but fully trusting Owen on the functional
testing and I am confident that these code changes won't have any side effects.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 11:35:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 10:35:24 +0000
Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries
for additional languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 11:35:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 10:35:28 +0000
Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries
for additional languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778
--- Comment #2 from Jonathan Druart ---
Created attachment 128957
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128957&action=edit
Bug 29778: Prevent orphan additional contents
When deleting a content, only the main one (lang="default") is removed,
which leads to orphan contents in the DB that are still displayed on the
UI.
Test plan:
0. Don't apply this patch
1. Create some contents, translate them in different languages
2. Delete some of them
=> Note that they are still displayed on the UI and that the entries
with lang!="default" are still in the DB
3. Apply this patch
4. Repeat 1
5. Run updatedatabase
6. Delete from of the contents
=> Note that the orphan entries created before you applied the patch
have been removed and that the "delete" behaviour is now working
correnctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 11:35:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 10:35:48 +0000
Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries
for additional languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail.
| |com
CC| |jonathan.druart+koha at gmail.
| |com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 11:45:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 10:45:04 +0000
Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in
staff pickup location is empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|jonathan.druart+koha at gmail. |tomascohen at gmail.com
|com |
Status|In Discussion |ASSIGNED
--- Comment #19 from Jonathan Druart ---
Tomas, I think you are the best placed to finish the work here.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:09:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:09:16 +0000
Subject: [Koha-bugs] [Bug 28152] Hidden error when importing an item with an
existing itemnumber
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #3 from Jonathan Druart ---
Hi Hayley, what you are describing is the correct behaviour, the row in
import_items should be there. The problem here is that, depending on the DBMS
version, there is an error creating the row and it's missing.
I should have added more information as I don't remember exactly the context,
but a guess is that it may be an error with a more recent version, like MySQL
8.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:11:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:11:41 +0000
Subject: [Koha-bugs] [Bug 29749] Clean up OpacStarRatings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29749
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
--- Comment #2 from Jonathan Druart ---
Lucas, is this patch ready for testing?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:14:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:14:58 +0000
Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from
template notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230
--- Comment #11 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #10)
> Although it looks good to me on itself, we have a clash with
> Koha::Object::messages.
>
> cc: Tomas
In my opinion Koha::Object->messages should be renamed. ->_messages maybe?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:16:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:16:52 +0000
Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from
template notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230
--- Comment #12 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #11)
> (In reply to Marcel de Rooy from comment #10)
> > Although it looks good to me on itself, we have a clash with
> > Koha::Object::messages.
> >
> > cc: Tomas
>
> In my opinion Koha::Object->messages should be renamed. ->_messages maybe?
Maybe, but you need to think of an accessor? Or maybe bug 29746 is the way to
avoid it completely?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:29:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:29:51 +0000
Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid
MARCXML
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #31 from Jonathan Druart ---
Hayley, your dev box is not configured correctly for selenium tests. You should
first install Selenium::Remote::Driver.
However there is a bug as the tests should return green even if the module is
not installed. But it's not related to these patches.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:33:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:33:31 +0000
Subject: [Koha-bugs] [Bug 29779] New: selenium/regressions.t fails if
Selenium lib is not installed
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779
Bug ID: 29779
Summary: selenium/regressions.t fails if Selenium lib is not
installed
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: major
Priority: P5 - low
Component: Test Suite
Assignee: jonathan.druart+koha at gmail.com
Reporter: jonathan.druart+koha at gmail.com
QA Contact: testopia at bugs.koha-community.org
t/db_dependent/selenium/regressions.t .. 1/7 Label not found for "last SKIP" at
/usr/share/perl/5.28/Test/More.pm line 1370.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:33:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:33:47 +0000
Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid
MARCXML
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
--- Comment #32 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #31)
> However there is a bug as the tests should return green even if the module
> is not installed. But it's not related to these patches.
Opened bug 29779.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:33:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:33:51 +0000
Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid
MARCXML
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=29779
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:33:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:33:51 +0000
Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium
lib is not installed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=29690
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:40:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:40:03 +0000
Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium
lib is not installed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:40:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:40:07 +0000
Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium
lib is not installed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779
--- Comment #1 from Jonathan Druart ---
Created attachment 128958
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128958&action=edit
Bug 29779: Make selenium tests return green even if lib is missing
Some selenium tests are not correctly written and they fail is
Selenium::Remote::Driver is missing.
Test plan:
1. Remove the lib rm `pmpath Selenium::Remote::Driver`
2. prove t/db_dependent/selenium/
should return green
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:41:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:41:23 +0000
Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602
--- Comment #42 from Jonathan Druart ---
(In reply to Victor Grousset/tuxayo from comment #41)
> (In reply to Jonathan Druart from comment #20)
> > Do we move forward with this patch or abandon it? It's now or never.
> > Or with bug 20988, maybe one day.
>
> +1 to move forward. Even without t()
>
> Thanks for fixes.
>
> Would the replacing of the be easy latter? Or does that set them in
> stone because it would be too hard to tell the that have a role in
> the layout or CSS vs these ones? (that influence our translation system to
> break down the strings)
We can still keep the spans and use t(). Why would that be a problem?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:54:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 11:54:47 +0000
Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033
--- Comment #10 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #9)
> (In reply to Tomás Cohen Arazi from comment #8)
> > (In reply to Marcel de Rooy from comment #7)
> > > +sub multivalue_preference {
> > > + my ( $self, $preference ) = @_;
> > > +
> > > + my $syspref = $self->preference($preference) // q{};
> > > + my $values = [ split qr{\|}, $syspref ];
> > > +
> > > + return $values;
> > > +}
> > >
> > > I agree that we need a parameter here to pass other separators.
> > > Multi value, multi sepa :)
> >
> > Counter proposal:
> > 1. Accept this as-is
> > 2. Implement a nice UI to abstract users from the separator being used
> > 3. Migrate sysprefs into using this
>
> Point 1: No ! :)
> Point 2: Fine with me.
> Point 3: Great. (Just gradually move away from sending the sepa param.)
>
> You need 5 mins to do the thing. We need 5 years for the rest ;)
Well, it is always the same chicken-egg situation: one proposes something, for
enhancing things, and waits for feedback before moving into changing all the
things. And some people want you to do all the things to get convinced of the
idea. It's a hard one. I'm fine with ad-hoc splitting code for now. But this is
something we could do better, specially point 2. Plus, I don't think there are
that many sysprefs that require this (many == more than 20).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:02:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 12:02:01 +0000
Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on
parcel.pl by summary column
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #2 from Tomás Cohen Arazi ---
*** This bug has been marked as a duplicate of bug 29464 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:02:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 12:02:01 +0000
Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour
sorting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464
--- Comment #11 from Tomás Cohen Arazi ---
*** Bug 29570 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:02:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 12:02:54 +0000
Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on
parcel.pl by summary column
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|DUPLICATE |---
Status|RESOLVED |REOPENED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:03:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 12:03:11 +0000
Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on
parcel.pl by summary column
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |ASSIGNED
--- Comment #3 from Tomás Cohen Arazi ---
I forgot where this was at, sorry :-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:03:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 12:03:59 +0000
Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD
incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|dcook at prosentient.com.au |testopia at bugs.koha-communit
| |y.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:55:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 12:55:32 +0000
Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context
warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:32:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:32:02 +0000
Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups
make a DB call per member of group
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:36:06 +0000
Subject: [Koha-bugs] [Bug 29780] New: Add Koha::Old::Holds->anonymize
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
Bug ID: 29780
Summary: Add Koha::Old::Holds->anonymize
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: tomascohen at gmail.com
QA Contact: testopia at bugs.koha-community.org
Add high-level methods to anonymize holds history as needed by bug 29526.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:36:17 +0000
Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |29526
Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
|ity.org |
Status|NEW |Needs Signoff
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526
[Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab
in opac
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:36:17 +0000
Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history'
button to patron privacy tab in opac
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |29780
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
[Bug 29780] Add Koha::Old::Holds->anonymize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:36:41 +0000
Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do
any checks or move to deletedborrowers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:36:45 +0000
Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do
any checks or move to deletedborrowers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128812|0 |1
is obsolete| |
Attachment #128813|0 |1
is obsolete| |
--- Comment #10 from Jonathan Druart ---
Created attachment 128959
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128959&action=edit
Bug 29018: Regression tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:36:49 +0000
Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do
any checks or move to deletedborrowers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018
--- Comment #11 from Jonathan Druart ---
Created attachment 128960
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128960&action=edit
Bug 29018: Make DELETE /patrons/:patron_id check things
When the route was implemented, the checks were overlooked. This patch
adds checks for:
- Guarantees
- Debts
- Current checkouts
Any of those will block deletion, as it should.
To test:
1. Apply the regression tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: Tests fail, the route misses checks
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! The three conditions prevent deletion!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: David Nind
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:39:07 +0000
Subject: [Koha-bugs] [Bug 28020] Error responses should return a code
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:39:11 +0000
Subject: [Koha-bugs] [Bug 28020] Error responses should return a code
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128921|0 |1
is obsolete| |
Attachment #128922|0 |1
is obsolete| |
Attachment #128923|0 |1
is obsolete| |
--- Comment #12 from Jonathan Druart ---
Created attachment 128961
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128961&action=edit
Bug 28020: Unit tests
The unhandled_exception() Mojo helper didn't have proper tests. As this
bug is adding a slight behavior change, I tried to add some. As it
relies on the OpenAPI plugin, it cannot be done the usual way using
Mojo::Lite. So I picked a route and forced an exception through mocking
to be able to write tests.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/unhandled_exceptions.t
=> FAIL: The unhandled_exception() helper doesn't return an error_code
in the response payload.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:39:15 +0000
Subject: [Koha-bugs] [Bug 28020] Error responses should return a code
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020
--- Comment #13 from Jonathan Druart ---
Created attachment 128962
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128962&action=edit
Bug 28020: Add error_code to error responses
This patch adds the *error_code* attribute to the error response
definition. This way it can be added when returning an error.
I also made a sample usage of it on the generic unhandled_exception
helper, which the unit tests on this patchset expect.
To test:
1. Apply the unit tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/unhandled_exceptions.t
=> FAIL: The unhandled_exception() helper doesn't return an error_code
in the response payload.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:39:20 +0000
Subject: [Koha-bugs] [Bug 28020] Error responses should return a code
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020
--- Comment #14 from Jonathan Druart ---
Created attachment 128963
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128963&action=edit
Bug 28020: (follow-up) Add docs about error_code on the API
This patch intends to be a guide for inserting Markdown documentation
for error codes. The idea is that it can be copied and pasted as-is in
new routes. And adapted to new error codes.
To test:
1. Apply this patch
2. Run:
$ npx redoc-cli at 0.10.4 bundle --cdn --output index.html \
api/v1/swagger/swagger.yaml
=> SUCCESS: It builds correctly
3. Open index.tml on your browser
4. Pick a route, and see the 500 status description includes information
about the possible `error_code` values.
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:39:47 +0000
Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 128964
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128964&action=edit
Bug 29780: Unit tests
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:39:50 +0000
Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 128965
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128965&action=edit
Bug 29780: Add Koha::Old::Holds->anonymize
This patch adds a handy method for anonymizing a Koha::Old::Holds
resultset. It is planned to be used on bug 29526.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Old/Holds.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:42:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:42:22 +0000
Subject: [Koha-bugs] [Bug 25387] Avoid merge different type of authorities
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25387
--- Comment #14 from marion.durand at biblibre.com ---
Hi !
In my understanding (I can be wrong), Marcel is saying that we shouldn't only
allow merging when the losing record is unused, because if we notice two record
we want to merge and both of them are used, we will have to manually relink
them (to make one used and the other not). And only then we can merge the
record.
So it's not the actual merging that would be a problem but the process before,
to make the merge possible.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:46:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:46:43 +0000
Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse
authorised values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andrew at bywatersolutions.com
--- Comment #32 from Jonathan Druart ---
(In reply to Pablo AB from comment #31)
> Will be backported to 21.05.x?
Yes, it should be backported.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:48:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:48:40 +0000
Subject: [Koha-bugs] [Bug 29665] Claims Returned status cannot be removed if
BlockReturnofLostItems set to Block
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29665
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #1 from Andrew Fuerste-Henry ---
Marking as duplicate of broader bug.
*** This bug has been marked as a duplicate of bug 29769 ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:48:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 13:48:40 +0000
Subject: [Koha-bugs] [Bug 29769] Claim return status cannot be changed
without checking item in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29769
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andrew at bywatersolutions.com
--- Comment #1 from Andrew Fuerste-Henry ---
*** Bug 29665 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:18:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 14:18:51 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
period if borrower has an 'unfound' hold
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102
--- Comment #5 from Nick Clemens ---
(In reply to Christopher Brannon from comment #4)
> I'm using a sandbox, and I haven't applied the patch yet and I am not
> running into the problem in step 5. It just checks out the item and removes
> the hold.
Ah, I described it in initial comment "and there are other holds"
When set to dynamic we check:
$threshold = $items_count + $decreaseLoanHighHoldsValue;
$holds->count() <= $threshold
items_count will be 0 (none holdable) but holds count is still 1, so not over
the threshold
Amended steps below:
step 4 - place title level holds for 2 patrons
step 5 - attempt to checkout to one of the patrons who have a hold
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:35:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 14:35:35 +0000
Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128964|0 |1
is obsolete| |
--- Comment #3 from Tomás Cohen Arazi ---
Created attachment 128966
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128966&action=edit
Bug 29780: Unit tests
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:38:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 14:38:37 +0000
Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail.
|y.org |com
--- Comment #9 from Jonathan Druart ---
+use overload bool => \&as_bool;
I didn't notice that the first time I read this patch, and it's awesome!
I will provide you a QA feedback soon.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:39:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 14:39:27 +0000
Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a
Koha::Result::Boolean object
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart+koha at gmail.
| |com
--- Comment #6 from Jonathan Druart ---
If we are using Koha::Result::Boolean for Koha::Patron->safe_to_delete we
certainly need to implement it for Koha::Item->safe_to_delete as well (same
time, same push).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:42:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 14:42:08 +0000
Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746
--- Comment #10 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #9)
> +use overload bool => \&as_bool;
>
> I didn't notice that the first time I read this patch, and it's awesome!
>
> I will provide you a QA feedback soon.
And, to explain a bit more:
"""
use Koha::Result::Boolean;
sub ok {
return Koha::Result::Boolean->new(1)->add_message({message => "this is not
an error"});
}
sub nok {
return Koha::Result::Boolean->new(0)->add_message({message => "this is an
error"});
}
if ( ok() ) {
say "all good";
}
unless ( nok() ) {
say "there was an error";
}
"""
=> will display "all good" and "there was an error"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:46:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 14:46:29 +0000
Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746
--- Comment #11 from Jonathan Druart ---
I don't think "Koha::Result::Boolean" is good. What is then a Koha::Result?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:48:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 14:48:43 +0000
Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746
--- Comment #12 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #9)
> +use overload bool => \&as_bool;
>
> I didn't notice that the first time I read this patch, and it's awesome!
>
> I will provide you a QA feedback soon.
Thank you! That was my feeling when I noticed overload existed as well :-D
(In reply to Jonathan Druart from comment #11)
> I don't think "Koha::Result::Boolean" is good. What is then a Koha::Result?
Right, I was not sure about the name. Maybe I'm going too far thinking we could
need another result types. I'd go with whatever to be honest. Koha::Result
sounds correct as well.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:49:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 14:49:18 +0000
Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club
without members
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736
--- Comment #9 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #4)
> Created attachment 128837 [details] [review]
> Bug 29736: Restore searching
Oops, thanks Tomas!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:05:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:05:30 +0000
Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history'
button to patron privacy tab in opac
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:07:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:07:50 +0000
Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history'
button to patron privacy tab in opac
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 128967
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128967&action=edit
Bug 29526: Add a way for patrons to delete their hold history
The same way we have a button to immediately delete the checkouts history in
the OPAC, we should have a similar option for the holds history.
This patch implements that.
To test:
1. Have a patron with some old checkouts and old holds.
2. Have OPACPrivacy, OPACHoldsHistory and opacreadinghistory enabled.
3. Notice in the OPAC the patron has some old checkouts and holds.
4. Use the Privacy tab to clean checkouts
=> SUCCESS: They are still cleaned as before this patch
5. Try to clean the old holds
=> SUCCESS: They are cleaned!
6. Add some old checkouts and holds
7. Use the new 'All' button
=> SUCCESS: All cleaned
8. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:09:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:09:02 +0000
Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history'
button to patron privacy tab in opac
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--- Comment #3 from Tomás Cohen Arazi ---
This works correctly. I have doubts about the buttons on the page and the
layout. Any ideas are welcome!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:11:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:11:09 +0000
Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a
Koha::Result::Boolean object
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765
--- Comment #7 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #6)
> If we are using Koha::Result::Boolean for Koha::Patron->safe_to_delete we
> certainly need to implement it for Koha::Item->safe_to_delete as well (same
> time, same push).
Sure, if we have consensus on things, I can do it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:21:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:21:06 +0000
Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
--- Comment #4 from Tomás Cohen Arazi ---
Just added some more tests, for the empty restultset case, which returns the
weird '0E0' value instead of plain zero [1], and wanted to highlight it, as I
stumbled upon it on bug 29526.
[1]
https://stackoverflow.com/questions/13358793/why-does-dbis-do-method-return-0e0-if-zero-rows-were-affected
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:21:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:21:47 +0000
Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also
affect holds history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |29780
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
[Bug 29780] Add Koha::Old::Holds->anonymize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:21:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:21:47 +0000
Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |29525
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525
[Bug 29525] Privacy settings for patrons should also affect holds history
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:21:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:21:55 +0000
Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also
affect holds history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:33:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:33:31 +0000
Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
effective_name method to patrons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:33:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:33:34 +0000
Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
effective_name method to patrons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125497|0 |1
is obsolete| |
Attachment #125498|0 |1
is obsolete| |
Attachment #125499|0 |1
is obsolete| |
Attachment #126591|0 |1
is obsolete| |
--- Comment #21 from Nick Clemens ---
Created attachment 128968
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128968&action=edit
Bug 28633: DB update
This adds the field to necessary tables and updates API and columns def
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:33:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:33:38 +0000
Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
effective_name method to patrons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
--- Comment #22 from Nick Clemens ---
Created attachment 128969
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128969&action=edit
Bug 28633: Add preferred name field to patrons
This patch adds a new field 'preferred_name' to the patron record.
Additionally it adds a method 'effective_name' to choose the preferred name if
present
and fall back to firstname
The 'firstname' is displayed as 'First name' on the details page, with id/class
patron_first_name to allow ajusting via JS/CSS if library wants to
highlight/hide
the non-preferred name
PatronAutoComplete/ysearch is updated to use 'effective_name' method
To test:
1 - Apply patches
2 - Update database and restart all, clear browser cache
3 - Load a patron in staff module
4 - Confirm you see and can add a preferred name
5 - Confirm the preferred name and first name now displays on patron details
6 - Remove first name from patron record and confirm it no longer shows
7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to
confirm you can make
new field required or hidden
8 - Sign in as patron to opac
9 - Confirm preferred name shows
10 - Edit account on opac and confirm field is present
11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had
firstname
12 - Perform checkout and patron search using preferred_name, confirm patron is
found
13 - Enable PatronAutoComplete system preference
14 - Type patron's surname into Checkout or patron search but don't hit enter
15 - Confirm patron is displayed with 'preferred_name' in the preview
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:33:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:33:42 +0000
Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an
effective_name method to patrons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633
--- Comment #23 from Nick Clemens ---
Created attachment 128970
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128970&action=edit
Bug 28633: DO NOT PUSH Schema Changes
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:45:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:45:23 +0000
Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on
request.pl before a patron is selected
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:45:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:45:26 +0000
Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on
request.pl before a patron is selected
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128474|0 |1
is obsolete| |
Attachment #128475|0 |1
is obsolete| |
Attachment #128476|0 |1
is obsolete| |
--- Comment #29 from Nick Clemens ---
Created attachment 128971
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128971&action=edit
Bug 29043: Don't load items unless a p[atron has been chosen on request.pl
This patch moves the code that we sh9ould run if there is no patron to the head
of
the biblio loop. If we have no patron we execute this and go to the next loop.
A few variables that were being passed to the template in the loop are moved
outside - no
reason to overwrite each loop
To test:
1 - Browse to a bib in the staff client
2 - Click on the holds tab
3 - Note loading time
4 - Add 500 items to bib
5 - Note loading time - it takes longer
6 - Note items are not displayed
7 - Apply patch
8 - Reload page - is much faster
9 - Find/choose a patron
10 - Confirm items are loaded correctly
Signed-off-by: Samu Heiskanen
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:45:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:45:30 +0000
Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on
request.pl before a patron is selected
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043
--- Comment #30 from Nick Clemens ---
Created attachment 128972
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128972&action=edit
Bug 29043: Prune dead code
Remove sort_borrowerlist as it was not used
Remove "time" for form name
I don't see nay reason we needed this
Remove messagetransfert from template
Never passed in code
Remove totalcount variable
Assigned and never referenced
Remove 'alreadyres'/'alreadyreserved' from template
All references in coide were in template - never set or passed
Signed-off-by: Samu Heiskanen
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:45:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:45:34 +0000
Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on
request.pl before a patron is selected
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043
--- Comment #31 from Nick Clemens ---
Created attachment 128973
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128973&action=edit
Bug 29043: Remaining bug is the incorrect title "Place a hold on No title"
This version takes account of the batch-mode.
I only just add the line:
$template->param( biblio => $biblio ) if scalar @biblionumbers == 1;
inside the foreach loop. All my other patch-fixes are obsolete.
Signed-off-by: Samu Heiskanen
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:52:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 15:52:48 +0000
Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746
--- Comment #13 from Jonathan Druart ---
"Return value" sounds better to me.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 17:11:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 16:11:11 +0000
Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on
every cron run
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)|21.11.00 |21.11.00,21.05.09
released in| |
CC| |andrew at bywatersolutions.com
Status|Pushed to master |Pushed to stable
--- Comment #14 from Andrew Fuerste-Henry ---
Pushed to 21.05.x for 21.05.09
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 17:11:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 16:11:23 +0000
Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on
every cron run
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to stable |Pushed to oldstable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 18:44:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 17:44:49 +0000
Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history'
button to patron privacy tab in opac
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526
Barbara Johnson changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |barbara.johnson at bedfordtx.g
| |ov
--- Comment #4 from Barbara Johnson ---
All the functionality of the buttons worked correctly. I think the layout of
the buttons looks fine.
Here are my observations from testing:
1. I had to enable the AnonymousPatron sys pref in order to make the test plan
work.
2. I think the first sentence under the 'Immediate deletion' heading should be
changed. The word 'your' is not needed and makes the sentence read awkwardly.
Also I would change 'here' to 'below' since there are now three button options.
I think this text would be more clear:
Whatever privacy rule you choose, you can delete all your checkout and hold
history immediately by clicking below.
3. Once you have cleared your holds history from the privacy tab and then go to
the holds history tab it states that "You have never placed a hold from this
library." That is not really true - the holds history either has never been
kept or has been cleared. The Checkout history tab displays 'No data available
in table' when there is no checkout history. Maybe the text on the Holds
history tab should be the same or similar.
4. The pre-patch behavior with the single 'Immediate deletion' button includes
the following text - Please note, the last person to return an item is tracked
for the management of items returned damaged. This still needs to be included
so that the patron is aware of it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:09:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 18:09:31 +0000
Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history'
button to patron privacy tab in opac
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526
--- Comment #5 from Lucas Gass ---
Created attachment 128974
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128974&action=edit
Bug 29526: (follow-up) Put delete buttons in HTML table
Current status: Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:18:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 18:18:14 +0000
Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also
affect holds history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 128975
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128975&action=edit
Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable
This patch adds the 'filter_by_anonymizable' method, and tests for it. A
new DBIC relationship is added as well to the OldReserve schema file.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ t/db_dependent/Koha/Old/Holds.t
=> SUCCESS: Tests pass!
3. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:18:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 18:18:19 +0000
Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also
affect holds history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525
--- Comment #3 from Tomás Cohen Arazi ---
Created attachment 128976
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128976&action=edit
Bug 29525: Make batch_anonymise.pl deal with holds
This patch makes the batch_anonymise.pl script handle holds too. It does
so by leveraging on the newly introduced method 'filter_by_anonymizable'
and also 'anonymize'.
To test:
1. Have a patron with two past holds.
2. Make sure they are a few days back:
$ koha-mysql kohadev
> UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY);
3. Run:
$ kshell
k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v
=> SUCCESS: You see something like:
Checkouts and holds before 2022-01-01 will be anonymised.
0 checkouts anonymised.
2 holds anonymised.
4. Repeat 3
=> SUCCESS: They are already anonymized. You see
Checkouts and holds before 2022-01-01 will be anonymised.
0 checkouts anonymised.
0 holds anonymised.
5. Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:18:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 18:18:26 +0000
Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also
affect holds history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525
--- Comment #4 from Tomás Cohen Arazi ---
Created attachment 128977
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128977&action=edit
Bug 29525: (follow-up) Adapt OPAC text to mention holds
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:27:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 18:27:02 +0000
Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:27:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 18:27:04 +0000
Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128965|0 |1
is obsolete| |
Attachment #128966|0 |1
is obsolete| |
--- Comment #5 from Lucas Gass ---
Created attachment 128978
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128978&action=edit
Bug 29780: Add Koha::Old::Holds->anonymize
This patch adds a handy method for anonymizing a Koha::Old::Holds
resultset. It is planned to be used on bug 29526.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Old/Holds.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:27:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 18:27:10 +0000
Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780
--- Comment #6 from Lucas Gass ---
Created attachment 128979
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128979&action=edit
Bug 29780: Unit tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:35:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 18:35:29 +0000
Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also
affect holds history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:38:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 18:38:09 +0000
Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746
--- Comment #14 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #11)
> I don't think "Koha::Result::Boolean" is good. What is then a Koha::Result?
I thought of writing Koha::Result as a generic class with the messages bit, and
then Koha::Result::Boolean, Koha::Result::Integer, inherit from it.
Are you willing to submit a follow-up renaming it to Koha::Result or similar?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:10:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 19:10:06 +0000
Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use
capturing groups in substitutions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873
--- Comment #8 from Andrew Fuerste-Henry ---
Adding some details to the test plan, to spare others having to think about it
:)
1 - have a record with 245a "the best book ever"
2 - create a modification template to copy and replace the 245a to the 245a,
using regex
3 - in your regex, match "(.+\b)best(.+)" and replace with "$1worst$2"
4 - perform a batch mod on your record, end up with "$1worst$2" as your literal
title
5) Apply the patch and try again, this time the capture group should
yield the expected results.
6) Run t/SimpleMARC.t and confirm the tests still pass.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:13:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 19:13:38 +0000
Subject: [Koha-bugs] [Bug 29781] New: Allow item batch modification to use
capturing groups in regex option
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781
Bug ID: 29781
Summary: Allow item batch modification to use capturing groups
in regex option
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: andrew at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
Bug 23873 seeks to make capturing groups usable in batch record mod. We should
do the same with items.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:13:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 19:13:38 +0000
Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use
capturing groups in substitutions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=29781
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:19:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 19:19:52 +0000
Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use
capturing groups in substitutions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:19:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 19:19:55 +0000
Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use
capturing groups in substitutions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128432|0 |1
is obsolete| |
--- Comment #9 from Andrew Fuerste-Henry ---
Created attachment 128980
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128980&action=edit
Bug 23873: Unit tests
This patch adds a unit test for capture groups support in
Koha::SimpleMARC.
Test plan
1) Run the test prior to applying the capture groups fix, note it fails.
2) Apply teh capture groups fix patch
3) Run the test again, it should now pass
Signed-off-by: Andrew Fuerste-Henry
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:19:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 19:19:59 +0000
Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use
capturing groups in substitutions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128433|0 |1
is obsolete| |
--- Comment #10 from Andrew Fuerste-Henry ---
Created attachment 128981
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128981&action=edit
Bug 23873: Enable capture groups in MarcModificationTemplates
This patch adds support for regular expression capture groups in
MarcModificationTemplates.
We escape double quotes in the replacement string, then quote the whole
string before applying the `ee` modifier to the final regex application.
See
https://blog.james.rcpt.to/2010/10/25/perl-search-and-replace-using-variables/
for further details.
Test plan
1) Attempt to use capture groups in your regular expression based
MarcModificationTemplate and note it does not work.
2) Apply the patch and try again, this time the capture group should
yield the expected results.
3) Run t/SimpleMARC.t and confirm the tests still pass.
Signed-off-by: Andrew Fuerste-Henry
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:03:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 23:03:16 +0000
Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history'
button to patron privacy tab in opac
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526
--- Comment #6 from Lucas Gass ---
Created attachment 128982
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128982&action=edit
Bug 29526: (follow-up) change wording on opac-holdshistory.tt when table is
empty
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:06:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 23:06:38 +0000
Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history'
button to patron privacy tab in opac
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526
--- Comment #7 from Lucas Gass ---
Thanks for testing Barbara!
> 2. I think the first sentence under the 'Immediate deletion' heading should
> be changed. The word 'your' is not needed and makes the sentence read
> awkwardly. Also I would change 'here' to 'below' since there are now three
> button options. I think this text would be more clear:
I addressed this in a follow-up, the wording should be clearer now.
> 3. Once you have cleared your holds history from the privacy tab and then go
> to the holds history tab it states that "You have never placed a hold from
> this library." That is not really true - the holds history either has never
> been kept or has been cleared. The Checkout history tab displays 'No data
> available in table' when there is no checkout history. Maybe the text on
> the Holds history tab should be the same or similar.
I provided a follow-up to change the text on opac-holdshistory.tt to be more
truthful. It should say 'No data available' now if you have no holds history.
> 4. The pre-patch behavior with the single 'Immediate deletion' button
> includes the following text - Please note, the last person to return an item
> is tracked for the management of items returned damaged. This still needs
> to be included so that the patron is aware of it.
This text has not been changed but in order to see it the StoreLastBorrower
system preference must be turned on.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:13:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 23:13:15 +0000
Subject: [Koha-bugs] [Bug 29782] New: Missing entries for display locations
in HTML customizations
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782
Bug ID: 29782
Summary: Missing entries for display locations in HTML
customizations
Change sponsored?: ---
Product: Koha
Version: 21.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: mik at adminkuhn.ch
QA Contact: testopia at bugs.koha-community.org
In Koha menu "Tools > HTML customizations" it is possible to create new entries
for various display locations.
Given the Koha instance has two languages, "English (en)" and "Deutsch
Deutschland (de-DE)" an entry will show three tabs:
* Default
* English (en)
* Deutsch Deutschland (de-DE)
If you fill just text into the "Content" field of the actual language tabs you
will be prompted with a popup saying "Please specify a title for Default".
In fact I don't know why such a "title" is needed at all (see also bug 29515),
but OK I fill one in, but do not fill any content into the "Content" field of
the Default tab because I don't want or need no default content. Now it's
possible to save.
The content of tab "English (en)" and "Deutsch Deutschland (de-DE)" will show
up in the OPAC when changing to the respective language.
But Koha menu "Tools > HTML customizations" will NOT show any entry for the
display location you have created! So you are not able to change its content or
delete it.
The problem doesn't happen if you enter text in the "Content" field of the
Default tab.
This means
1. It is not clear why the default tab is mandatory.
2. It shouldn't be possible to save the entry for a display location without
entering text in the "Content" field of the Default tab if the consequence is
that there won't be no entry for the display location in the end.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:17:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 23:17:31 +0000
Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to
notice templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #20 from David Cook ---
(This is just a side note but I wonder if another way of doing this would be
implementing a TTL mechanism.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:19:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 23:19:05 +0000
Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history'
button to patron privacy tab in opac
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526
--- Comment #8 from Barbara Johnson ---
I will test again tomorrow. One other thing I noticed - The tab on the left
side with all the account options displays 'Your holds history.' But the
buttons on the privacy page display as 'Your hold history.' One is plural and
one is singular - should they match?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:39:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jan 2022 23:39:05 +0000
Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in
HTML customizations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |critical
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:12:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 00:12:15 +0000
Subject: [Koha-bugs] [Bug 20417] Remove OpacCloud system preference and
feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20417
--- Comment #4 from David Cook ---
Actually, I think Gaetan is right about it being removed.
If you look at ./opac/opac-tags_subject.pl and
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags_subject.tt, you'll see this
was originally designed as an experimental French feature.
The opac-tags_subject.pl page just seems to be a neglected version of
opac-tags.pl, which doesn't actually work as designed if you have user tagging
turned on.
It might be worthwhile to add removing OpacBrowser at the same time as
OpacCloud since it also appears to be an experimental French-only feature
according to ./misc/cronjobs/build_browser_and_cloud.pl and
https://wiki.koha-community.org/wiki/Opac_browse_feature
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:12:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 00:12:28 +0000
Subject: [Koha-bugs] [Bug 20417] Remove OpacCloud (and OpacBrowser) system
preference and feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20417
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Remove OpacCloud system |Remove OpacCloud (and
|preference and feature |OpacBrowser) system
| |preference and feature
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:14:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 00:14:08 +0000
Subject: [Koha-bugs] [Bug 20417] Remove OpacCloud (and OpacBrowser) system
preference and feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20417
--- Comment #5 from David Cook ---
I had a library recently want to use OpacBrowser but the system preference
description is misleading.
If we don't remove this functionality, I think we should change the system
preference names and descriptions to reflect the actual functionality.
Otherwise, I think people are just getting confused by this.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:30:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 00:30:08 +0000
Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD
incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:30:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 00:30:12 +0000
Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD
incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128881|0 |1
is obsolete| |
--- Comment #3 from David Cook ---
Created attachment 128983
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128983&action=edit
Bug 29764: Fix incorrect EmbedItems RecordProcessor filter POD
This patch makes the usage POD for the EmbedItems filter actually be
usable. The filter is used in opac-ISBDdetail.pl and the POD is updated
to how it is used there.
Not much to test.
Signed-off-by: David Cook
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:37:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 00:37:52 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
item from a group of titles
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|dcook at prosentient.com.au |testopia at bugs.koha-communit
| |y.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:54:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 00:54:10 +0000
Subject: [Koha-bugs] [Bug 29774] Self registration notification management
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29774
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 03:57:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 02:57:25 +0000
Subject: [Koha-bugs] [Bug 25705] Viewing all serials issues should not
require serials permissions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25705
--- Comment #3 from David Cook ---
I don't think that I'll be working on this one, but it would be great to see an
improvement in this area.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 04:01:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 03:01:28 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
hidden by OpacHiddenItems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704
--- Comment #2 from David Cook ---
Still an issue in master
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 04:03:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 03:03:44 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
hidden by OpacHiddenItems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704
--- Comment #3 from David Cook ---
It should also take into account OpacSuppression
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 06:02:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 05:02:14 +0000
Subject: [Koha-bugs] [Bug 29783] New: Account lockout message appears
incorrectly for blank userid
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783
Bug ID: 29783
Summary: Account lockout message appears incorrectly for blank
userid
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Authentication
Assignee: koha-bugs at lists.koha-community.org
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
CC: dpavlin at rot13.org
If a Koha instance has a borrower with an blank/empty userid and login_attempts
over the threshold defined by FailedLoginAttempts, a user will see "Error: This
account has been locked!" when visiting the staff interface for the first time
and without supplying any login details.
This is because we're doing a Koha::Patrons->find with an empty string!
The solution is very simple...
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 06:02:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 05:02:24 +0000
Subject: [Koha-bugs] [Bug 29783] Account lockout message appears incorrectly
for blank userid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 06:09:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 05:09:51 +0000
Subject: [Koha-bugs] [Bug 29783] Account lockout message appears incorrectly
for blank userid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 06:09:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 05:09:55 +0000
Subject: [Koha-bugs] [Bug 29783] Account lockout message appears incorrectly
for blank userid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783
--- Comment #1 from David Cook ---
Created attachment 128984
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128984&action=edit
Bug 29783: Add account lockout patron userid lookup condition
This patch checks that $q_userid is not blank before trying to
do a patron lookup. This prevents a spurrious account locked
message from appearing to the user when there is a user in Koha
that has an empty userid and too many login_attempts.
Test plan:
0) Do not apply the patch yet
1) Set system preference FailedLoginAttempts to 3
2) Modify a borrower to have an empty userid and 10 login_attempts
e.g. update borrowers set userid = '', login_attempts = 10 where cardnumber =
23529001223636;
3) Visit the staff interface (e.g. http://localhost:8081/)
4) Note the message "Error: This account has been locked!" even
though you have not tried to log in
5) Apply the patch
6) Visit the staff interface (e.g. http://localhost:8081/)
7) Note that there is no error message about your account
being locked
8) Profit.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:57:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 06:57:35 +0000
Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending
suggestions are visible only if the current library has suggestions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
Depends on| |25033
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033
[Bug 25033] Counts of suggestions are confusing
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:57:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 06:57:35 +0000
Subject: [Koha-bugs] [Bug 25033] Counts of suggestions are confusing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |29571
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571
[Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if
the current library has suggestions
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 06:59:30 +0000
Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending
suggestions are visible only if the current library has suggestions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |22.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 06:59:32 +0000
Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending
suggestions are visible only if the current library has suggestions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571
--- Comment #13 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 06:59:34 +0000
Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to
BorrowerMandatory/Unwanted fields system preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |22.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 06:59:37 +0000
Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to
BorrowerMandatory/Unwanted fields system preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591
--- Comment #7 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 06:59:39 +0000
Subject: [Koha-bugs] [Bug 29604] Term highlighting adds unwanted pseudo
element in the contentblock of OPAC details page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |22.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 06:59:41 +0000
Subject: [Koha-bugs] [Bug 29604] Term highlighting adds unwanted pseudo
element in the contentblock of OPAC details page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604
--- Comment #4 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 06:59:44 +0000
Subject: [Koha-bugs] [Bug 29729] If serials_stats.pl returns no results
dataTables get angry
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |22.05.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 06:59:46 +0000
Subject: [Koha-bugs] [Bug 29729] If serials_stats.pl returns no results
dataTables get angry
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729
--- Comment #5 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:19:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:19:19 +0000
Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in
HTML customizations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |24387
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #1 from Fridolin Somers ---
Indeed I reproduce the bug.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387
[Bug 24387] Rename News tool
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:19:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:19:19 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |29782
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782
[Bug 29782] Missing entries for display locations in HTML customizations
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:21:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:21:02 +0000
Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in
HTML customizations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782
--- Comment #2 from Fridolin Somers ---
I think it comes from :
https://git.koha-community.org/Koha-community/Koha/src/commit/9a8ea2e46da6c788a633383b81cce70c9323f750/tools/additional-contents.pl#L120
I think we should deleted only if both title and content are empty.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:24:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:24:59 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
20.05.xx to 20.11.04-1
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|major |critical
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:43:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:43:40 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
20.05.xx to 20.11.04-1
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267
--- Comment #26 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #25)
>
> Is there a way we could fix this once and for all? Or at least provide
> information/warning to users?
We can eventually run this query and display a warning on the about page if
some tables are not using "Dynamic".
SELECT table_name,row_format FROM information_schema.tables WHERE
table_schema='koha_kohadev' AND row_format != "Dynamic";
A link to a wiki page explaining the problem and providing a solution would be
great as well.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:44:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:44:47 +0000
Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for
OPAC suggestion fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Failed QA
--- Comment #20 from Fridolin Somers ---
(In reply to Fridolin Somers from comment #19)
> Ah atomic update script needs to be updated to match new DBRev system.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:54:15 +0000
Subject: [Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped
in selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |22.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:54:17 +0000
Subject: [Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped
in selector
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876
--- Comment #7 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:54:19 +0000
Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated
barcode in 0001 option
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |22.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:54:22 +0000
Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated
barcode in 0001 option
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689
--- Comment #12 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:54:24 +0000
Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to master
Version(s)| |22.05.00
released in| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 07:54:27 +0000
Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693
--- Comment #7 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 09:24:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 08:24:06 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
20.05.xx to 20.11.04-1
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267
--- Comment #27 from Katrin Fischer ---
Could it make sense to stop the installer until the tables have been fixed?
Like we do for missing dependencies?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 09:25:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 08:25:20 +0000
Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for
OPAC suggestion fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296
--- Comment #21 from Katrin Fischer ---
(In reply to Fridolin Somers from comment #20)
> (In reply to Fridolin Somers from comment #19)
> > Ah atomic update script needs to be updated to match new DBRev system.
So far it was not mandatory, maybe we should add to coding
guidelines/communicate - we have a lot of old database updates out there. :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 09:26:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 08:26:20 +0000
Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in
HTML customizations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782
--- Comment #3 from Katrin Fischer ---
We also had agreed that the title should not be mandatory, see:
Bug 29515 - Don't require title for HTML customizations
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 10:38:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 09:38:50 +0000
Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in
HTML customizations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=29778
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 10:38:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 09:38:50 +0000
Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries
for additional languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=29782
CC| |fridolin.somers at biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:12:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:12:08 +0000
Subject: [Koha-bugs] [Bug 29784] New: Adding Action Log tips to Manual
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29784
Bug ID: 29784
Summary: Adding Action Log tips to Manual
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Documentation
Assignee: koha-bugs at lists.koha-community.org
Reporter: kelly at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
There is a super handy chart in the Koha Report Wiki that helps users
understand what fields need what information when running the log viewer. This
is an extremely useful chart and one that would benefit from being in the
manual as well. If a user went to the log viewer page in the Staff Interface,
it would be nice if they did need help, the "Help" button would bring them to
the manual where the instructions on how to use the log viewer and the handy
chart information could live together.
This is the chart I am referring to:
https://wiki.koha-community.org/wiki/SQL_Reports_Library#action_logs
Currently, this is all that lives in the manual for using the logs:
https://koha-community.org/manual//21.05/en/html/tools.html#log-viewer
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:20:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:20:52 +0000
Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on
the way?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390
--- Comment #4 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #3)
> Any advice, Jonathan, as to best way to proceed here ?
About? The atomic updates look good to me.
There are some typos I am going to fix.
One thing maybe:
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml:
authorised_value: Unititle
"Unititle" does not exist in the AV list of the sample data.
What else would be needed?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:21:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:21:18 +0000
Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693
Andrew Nugged changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nugged at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:21:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:21:35 +0000
Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on
the way?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390
--- Comment #5 from Jonathan Druart ---
Created attachment 128985
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128985&action=edit
Bug 29390: Fix syntax error in atomic update
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:26:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:26:49 +0000
Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated
barcode in 0001 option
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689
Andrew Nugged changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nugged at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:27:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:27:58 +0000
Subject: [Koha-bugs] [Bug 29785] New: Koha::Object->messages must be renamed
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785
Bug ID: 29785
Summary: Koha::Object->messages must be renamed
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart+koha at gmail.com
Reporter: jonathan.druart+koha at gmail.com
QA Contact: testopia at bugs.koha-community.org
It will conflict with other ->messages methods, it's too generic.
Bug 29230 needs Koha::Patron->messages to return Koha::Patron::Messages for
instance.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:28:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:28:17 +0000
Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from
template notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |29785
--- Comment #13 from Jonathan Druart ---
I opened bug 29785 to rename it.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785
[Bug 29785] Koha::Object->messages must be renamed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:28:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:28:17 +0000
Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |29230
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230
[Bug 29230] Patron's messages not accessible from template notices
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:35:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:35:55 +0000
Subject: [Koha-bugs] [Bug 29786] New: Holds to pull report shows incorrect
item for item level holds
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786
Bug ID: 29786
Summary: Holds to pull report shows incorrect item for item
level holds
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Reports
Assignee: koha-bugs at lists.koha-community.org
Reporter: nick at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
When running holds to pull it can show the wrong item for an item level hold.
This is because we simply get the first barcode from the list of items that can
fill the hold.
The issue seems to come from 'get_items_that_can_fill' in Koha::Holds
This does not take into account that an item level hold can only be filled by
one item
To recreate:
1 - Find a record with many items available
2 - Place an item level hold for an item on the record, not the one with lowest
itemnumber
3 - Run 'Hold to pull' report
4 - Note the barcode does not match
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:38:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:38:09 +0000
Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:38:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:38:13 +0000
Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785
--- Comment #1 from Jonathan Druart ---
Created attachment 128986
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128986&action=edit
Bug 29785: Rename Koha::Object->message with ->object_messages
It will conflict with other ->messages methods, it's too generic.
Bug 29230 needs Koha::Patron->messages to return Koha::Patron::Messages for
instance.
Test plan:
Confirm that the tests modified by this patch still pass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:38:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:38:23 +0000
Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from
template notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |BLOCKED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:42:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:42:36 +0000
Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item
for item level holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:42:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:42:39 +0000
Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item
for item level holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786
--- Comment #1 from Nick Clemens ---
Created attachment 128987
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128987&action=edit
Bug 29786: Unit tests
I add a new test for the case of an item level hold, and additionally
adjust later tests to use a title level hold.
I also fix a typo where the comment says item 1 when it means item 2
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:42:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:42:43 +0000
Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item
for item level holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786
--- Comment #2 from Nick Clemens ---
Created attachment 128988
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128988&action=edit
Bug 29786: Select only specific items for item level holds
This patch adjusts get_items_that_can_fill to make two requests:
first the list of items for item-level holds
second the list of biblionumbers for title-level holds
This stops the report from pulling more items for item-level hold
This patch also removes the aliases used in the code - while readability
is a bit harder, it allows for using 'me' in get_items_that_can_fill
Otherwise, this routine would need a parameter to know what we called the
table.
To test:
1 - Find a record with many items available
2 - Place an item level hold for an item on the record, not the one with lowest
itemnumber
3 - Run 'Hold to pull' report
4 - Note the barcode does not match
5 - Apply patch
6 - Reload report
7 - It matches!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:43:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:43:07 +0000
Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item
for item level holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:57:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:57:00 +0000
Subject: [Koha-bugs] [Bug 29787] New: Add plugin version to plugin search
results
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787
Bug ID: 29787
Summary: Add plugin version to plugin search results
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Plugin architecture
Assignee: koha-bugs at lists.koha-community.org
Reporter: tomascohen at gmail.com
QA Contact: testopia at bugs.koha-community.org
When you search for a plugin it doesn't tell which version it is going to
install.
Additionally, it would be great if instead of just an 'install' button, they
mutated to 'upgrade' or 'reinstall' if that applies. Otherwise you don't know
what's going on.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:58:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jan 2022 13:58:48 +0000
Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andrew at bywatersolutions.com
| |,
| |jonathan.druart+koha at gmail.
| |com,
| |kyle at bywatersolutions.com,
| |martin.renvoize at ptfs-europe
| |.com,
| |nick at bywatersolutions.com
--- Comment #1 from Tomás Cohen Arazi