From bugzilla-daemon at bugs.koha-community.org Sat Jan 1 13:27:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jan 2022 12:27:12 +0000 Subject: [Koha-bugs] [Bug 29778] New: Deleted additional_contents remain visible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Bug ID: 29778 Summary: Deleted additional_contents remain visible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We have had 2 reports about this on the mailing list from 3 different people so far. It was not possible yet to determine the cause: https://lists.katipo.co.nz/pipermail/koha/2021-December/057161.html https://lists.katipo.co.nz/pipermail/koha/2021-December/057186.html I've tried to replicate on master, but no luck so far. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 1 14:08:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jan 2022 13:08:45 +0000 Subject: [Koha-bugs] [Bug 28832] [21.05] Batch modification always clears permanent_location if it is mapped in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28832 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch modification always |[21.05] Batch modification |clears permanent_location |always clears |if it is mapped in |permanent_location if it is |frameworks |mapped in frameworks --- Comment #17 from Katrin Fischer --- I missed that this was for an older version only - I have added to the description to make it more visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 12:30:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 11:30:53 +0000 Subject: [Koha-bugs] [Bug 27978] Marc modification templates should allow for copying an entire field to a field/subfield and vice versa In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27978 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 12:31:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 11:31:45 +0000 Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 12:32:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 11:32:03 +0000 Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications templates are not added in an ordered way In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 15:55:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 14:55:27 +0000 Subject: [Koha-bugs] [Bug 29778] Deleted additional_contents remain visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #1 from Katrin Fischer --- I have managed to find the steps to make this bug visible: 1) Install an additional language, like de-DE 2) Activate language 3) Add a new HTML customization entry * Fill in default and Englis * Fill in the additional installed language * Save 4) Verify the contents show as they should 5) Delete the entry 6) Verify the content remain for the additional language This can also be verified by running: select * from additional_contents; In my case I deleted everything else and now only this entry remains that is not visible from the GUI: +-------+---------------------+---------------------+-------------------+------------+-------+---------+-------+--------------+---------------------+----------------+--------+----------------+ | idnew | category | code | location | branchcode | title | content | lang | published_on | updated_on | expirationdate | number | borrowernumber | +-------+---------------------+---------------------+-------------------+------------+-------+---------+-------+--------------+---------------------+----------------+--------+----------------+ | 7 | html_customizations | OpacMainUserBlock_6 | OpacMainUserBlock | NULL | test | test | de-DE | 2022-01-02 | 2022-01-02 01:46:58 | NULL | NULL | 51 | +-------+---------------------+---------------------+-------------------+------------+-------+---------+-------+--------------+---------------------+----------------+--------+----------------+ Updating severity as this means people have no way to change or remove unwanted content - we need to fix this and also include a database update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 15:56:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 14:56:07 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents is incomplete and leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Deleted additional_contents |Deleting |remain visible |additional_contents is | |incomplete and leaves | |entries for additional | |languages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 15:58:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 14:58:18 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Deleting |Deleting |additional_contents is |additional_contents leaves |incomplete and leaves |entries for additional |entries for additional |languages |languages | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:10:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:10:37 +0000 Subject: [Koha-bugs] [Bug 27189] Unable to delete patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27189 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |MOVED --- Comment #3 from Katrin Fischer --- We finally tracked this down to a DBD::mysql::db do failed: Row size too large. error on the borrower_modifications table. The failed update would have added the extended_attributes column which than caused the issue on patron deletion. I am reclosing this, but with a link to bug 28267. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:13:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:13:45 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #25 from Katrin Fischer --- It looks like the borrower_modifications table can also be affected as we had this one failing with the known "Row size too large." error: $DBversion = "16.12.00.001"; if ( CheckVersion($DBversion) ) { $dbh->do(q{ ALTER TABLE borrower_modifications ADD COLUMN extended_attributes text DEFAULT NULL AFTER privacy }); print "Upgrade to $DBversion done (Bug 17767 - Let Koha::Patron::Modification handle extended attributes)\n"; SetVersion($DBversion); } Is there a way we could fix this once and for all? Or at least provide information/warning to users? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:13:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:13:59 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27189 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:13:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:13:59 +0000 Subject: [Koha-bugs] [Bug 27189] Unable to delete patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27189 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28267 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:14:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:14:51 +0000 Subject: [Koha-bugs] [Bug 29756] No Place hold button on OPAC details page if number of items exceeds OpacMaxItemsToDisplay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29756 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:18:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:18:15 +0000 Subject: [Koha-bugs] [Bug 29774] Self registration notification management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29774 --- Comment #1 from Katrin Fischer --- If you require email verification there won't be a patron account added immediately, so there is no borrowernumber the notice could be linked to. The patron account is only created after the user has clicked on the link in the email. But you might be referring to a different workflow? Maybe using the patron import tool or the ACCTDETAILS email? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:19:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:19:42 +0000 Subject: [Koha-bugs] [Bug 29769] Claim return status cannot be changed without checking item in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29769 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24279 Version|21.05 |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:19:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:19:42 +0000 Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29769 [Bug 29769] Claim return status cannot be changed without checking item in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:22:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:22:32 +0000 Subject: [Koha-bugs] [Bug 24115] patron import tool should have option to not overwrite specific fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24115 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- Hi, I believe this is a duplicate to bug 27883 which implemented this in 21.11. *** This bug has been marked as a duplicate of bug 27883 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:22:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:22:32 +0000 Subject: [Koha-bugs] [Bug 27883] Add ability to preserve patron field from being overwritten by import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27883 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans at phe.gov.uk --- Comment #27 from Katrin Fischer --- *** Bug 24115 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:27:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:27:22 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 --- Comment #56 from Katrin Fischer --- (In reply to Cab Vinton from comment #55) > Will this enhancement be available from the staff interface? i.e., Tools > > Export data (.../cgi-bin/koha/tools/export.pl) >From looking at the patch set this will only appear in the command line script. But as this has been waiting a while now, I suggest we file a separate report for making this available on GUI side. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:29:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:29:23 +0000 Subject: [Koha-bugs] [Bug 29768] hidepatronname hides guarantor name on borrower edit screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29768 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:31:26 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master --- Comment #1 from Katrin Fischer --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:34:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:34:21 +0000 Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 --- Comment #5 from Katrin Fischer --- I agree with only giving this note with -v as at the moment if you have scheduled this on a server with multiple instances where the pref is turned off intentionally, it creates quite a bit of noise. It's not a fatal one I think, so would fit the description of -v, just referring to a configuration issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 16:37:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 15:37:33 +0000 Subject: [Koha-bugs] [Bug 29739] Add a staff counterpart for OPACURLOpenInNewWindow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29739 --- Comment #1 from Katrin Fischer --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:08:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:08:48 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128587|0 |1 is obsolete| | Attachment #128588|0 |1 is obsolete| | Attachment #128589|0 |1 is obsolete| | Attachment #128590|0 |1 is obsolete| | --- Comment #15 from Björn Nylén --- Created attachment 128948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128948&action=edit Bug 27208: Add the ability to delay pickup notices. This bug adds the ability to delay sending a pickup notice. This can be done in two ways, either by a fixed configurable delay of all pickup notices or a time selectable by staff at checkin. This is controlled by two new system preferences, PickupNoticeDelayMode and PickupNoticeDelayDuration. A delayed notice will also be visible in the patron notice log. To test: 1. Apply patch and run updatedatabase.pl to add new column to message_queue. 2. Check in items with holds with different delay modes ('no delay','fixed delay','selectable by staff'). 3. Check the patron notice logs to check notice delay. Delayed notices have status 'pending, delayed until...' 4. Expected behaviour is: 'No delay': No notices are delayed. 'Fixed delay': All pickup notices are delayed by the no of hours set in PickupNoticeDelayDuration. 'Delay selectable by staff': Pickup notice is delayed until the time set in UI. If no delay is set, notice will not be delayed. Also note the warning at the checkin page when a delay is set. 5. Run process_message_queue.pl before and after the delay times above. Notices without delay are sent immediatly, delayed notices are only sent after the set time. 6. Tests should pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:08:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:08:52 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #16 from Björn Nylén --- Created attachment 128949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128949&action=edit Bug 27208: Atomicupdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:08:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:08:57 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #17 from Björn Nylén --- Created attachment 128950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128950&action=edit Bug 27208: Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:09:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:09:01 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #18 from Björn Nylén --- Created attachment 128951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128951&action=edit Bug 27208: Unit tests This commit adds unit test for changes in C4/Letters.pm and C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:11:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:11:13 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 --- Comment #19 from Björn Nylén --- Updated patch. Behavior is now controlled by PickupNoticeDelayMode and allows either a fixed delay or one set by the librarian at checkin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:36:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:36:50 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128836|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 128953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128953&action=edit Bug 29736: Don't return empty clubs There is an error when placing a hold for a club without members: Uncaught TypeError: err.responseJSON.error is undefined It seems that we should remove clubs without members from the search. Test plan: Create 1 club xx with 2 patrons Create 1 club xxx with 1 patron and cancel their enrolment Create 1 club xxxx without patron Place a hold for club "x", only the first one should be returned with this patch. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:36:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:36:53 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128837|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 128954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128954&action=edit Bug 29736: Restore searching Without this patch, the list will always display all clubs. To test: 1. Have two clubs, with enrollemnts: - Cthulhu fans - The Shadow Out of Time fans 2. Search for the letter c => FAIL: You get both results 3. Apply this patch 4. Repeat 2 => SUCCESS: Only Cthulhu is returned 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:36:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:36:58 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128838|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 128955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128955&action=edit Bug 29736: (QA follow-up) No need to delete all clubs There's no real need to delete all the existing clubs in the tests. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:37:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:37:06 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:39:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:39:30 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #28 from Katrin Fischer --- Sorry Nick, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29043: Don't load items unless a p[atron has been chosen on request.pl Using index info to reconstruct a base tree... M reserve/request.pl Falling back to patching base and 3-way merge... Auto-merging reserve/request.pl CONFLICT (content): Merge conflict in reserve/request.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 29043: Don't load items unless a p[atron has been chosen on request.pl The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-29043-Dont-load-items-unless-a-patron-has-been-vtn8py.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:43:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:43:40 +0000 Subject: [Koha-bugs] [Bug 29320] Use OverDrive availability API V2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:43:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:43:44 +0000 Subject: [Koha-bugs] [Bug 29320] Use OverDrive availability API V2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29320 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126920|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 128956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128956&action=edit Bug 29320: Update OverDrive availability to V2 This patch updates the call to overdrive_proxy to allow passing a version and updates the code to use V2 for availability To test: 1 - Enable OverDrive integration by setting the sysprefs 2 - Log in to your overdrive account in the Koha opac 3 - Perform a search and note availability display 4 - Confirm you can checkout/hold/return books 5 - Apply patch 6 - Repeat search and test functionality 7 - Note that title with '0 out of 0 copies available' now say 'Currently unavailable' Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 2 17:45:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jan 2022 16:45:01 +0000 Subject: [Koha-bugs] [Bug 29320] Use OverDrive availability API V2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29320 --- Comment #4 from Katrin Fischer --- Obviously I couldn't test this, but fully trusting Owen on the functional testing and I am confident that these code changes won't have any side effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 11:35:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 10:35:24 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 11:35:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 10:35:28 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 --- Comment #2 from Jonathan Druart --- Created attachment 128957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128957&action=edit Bug 29778: Prevent orphan additional contents When deleting a content, only the main one (lang="default") is removed, which leads to orphan contents in the DB that are still displayed on the UI. Test plan: 0. Don't apply this patch 1. Create some contents, translate them in different languages 2. Delete some of them => Note that they are still displayed on the UI and that the entries with lang!="default" are still in the DB 3. Apply this patch 4. Repeat 1 5. Run updatedatabase 6. Delete from of the contents => Note that the orphan entries created before you applied the patch have been removed and that the "delete" behaviour is now working correnctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 11:35:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 10:35:48 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 11:45:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 10:45:04 +0000 Subject: [Koha-bugs] [Bug 28919] When placing a multi-hold from results in staff pickup location is empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |tomascohen at gmail.com |com | Status|In Discussion |ASSIGNED --- Comment #19 from Jonathan Druart --- Tomas, I think you are the best placed to finish the work here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:09:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:09:16 +0000 Subject: [Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Jonathan Druart --- Hi Hayley, what you are describing is the correct behaviour, the row in import_items should be there. The problem here is that, depending on the DBMS version, there is an error creating the row and it's missing. I should have added more information as I don't remember exactly the context, but a guess is that it may be an error with a more recent version, like MySQL 8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:11:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:11:41 +0000 Subject: [Koha-bugs] [Bug 29749] Clean up OpacStarRatings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29749 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- Lucas, is this patch ready for testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:14:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:14:58 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #11 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #10) > Although it looks good to me on itself, we have a clash with > Koha::Object::messages. > > cc: Tomas In my opinion Koha::Object->messages should be renamed. ->_messages maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:16:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:16:52 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #11) > (In reply to Marcel de Rooy from comment #10) > > Although it looks good to me on itself, we have a clash with > > Koha::Object::messages. > > > > cc: Tomas > > In my opinion Koha::Object->messages should be renamed. ->_messages maybe? Maybe, but you need to think of an accessor? Or maybe bug 29746 is the way to avoid it completely? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:29:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:29:51 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #31 from Jonathan Druart --- Hayley, your dev box is not configured correctly for selenium tests. You should first install Selenium::Remote::Driver. However there is a bug as the tests should return green even if the module is not installed. But it's not related to these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:33:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:33:31 +0000 Subject: [Koha-bugs] [Bug 29779] New: selenium/regressions.t fails if Selenium lib is not installed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779 Bug ID: 29779 Summary: selenium/regressions.t fails if Selenium lib is not installed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org t/db_dependent/selenium/regressions.t .. 1/7 Label not found for "last SKIP" at /usr/share/perl/5.28/Test/More.pm line 1370. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:33:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:33:47 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #32 from Jonathan Druart --- (In reply to Jonathan Druart from comment #31) > However there is a bug as the tests should return green even if the module > is not installed. But it's not related to these patches. Opened bug 29779. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:33:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:33:51 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29779 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:33:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:33:51 +0000 Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium lib is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:40:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:40:03 +0000 Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium lib is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:40:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:40:07 +0000 Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium lib is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779 --- Comment #1 from Jonathan Druart --- Created attachment 128958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128958&action=edit Bug 29779: Make selenium tests return green even if lib is missing Some selenium tests are not correctly written and they fail is Selenium::Remote::Driver is missing. Test plan: 1. Remove the lib rm `pmpath Selenium::Remote::Driver` 2. prove t/db_dependent/selenium/ should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:41:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:41:23 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #42 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #41) > (In reply to Jonathan Druart from comment #20) > > Do we move forward with this patch or abandon it? It's now or never. > > Or with bug 20988, maybe one day. > > +1 to move forward. Even without t() > > Thanks for fixes. > > Would the replacing of the be easy latter? Or does that set them in > stone because it would be too hard to tell the that have a role in > the layout or CSS vs these ones? (that influence our translation system to > break down the strings) We can still keep the spans and use t(). Why would that be a problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 12:54:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 11:54:47 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #9) > (In reply to Tomás Cohen Arazi from comment #8) > > (In reply to Marcel de Rooy from comment #7) > > > +sub multivalue_preference { > > > + my ( $self, $preference ) = @_; > > > + > > > + my $syspref = $self->preference($preference) // q{}; > > > + my $values = [ split qr{\|}, $syspref ]; > > > + > > > + return $values; > > > +} > > > > > > I agree that we need a parameter here to pass other separators. > > > Multi value, multi sepa :) > > > > Counter proposal: > > 1. Accept this as-is > > 2. Implement a nice UI to abstract users from the separator being used > > 3. Migrate sysprefs into using this > > Point 1: No ! :) > Point 2: Fine with me. > Point 3: Great. (Just gradually move away from sending the sepa param.) > > You need 5 mins to do the thing. We need 5 years for the rest ;) Well, it is always the same chicken-egg situation: one proposes something, for enhancing things, and waits for feedback before moving into changing all the things. And some people want you to do all the things to get convinced of the idea. It's a hard one. I'm fine with ad-hoc splitting code for now. But this is something we could do better, specially point 2. Plus, I don't think there are that many sysprefs that require this (many == more than 20). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:02:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 12:02:01 +0000 Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 29464 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:02:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 12:02:01 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #11 from Tomás Cohen Arazi --- *** Bug 29570 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:02:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 12:02:54 +0000 Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:03:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 12:03:11 +0000 Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED --- Comment #3 from Tomás Cohen Arazi --- I forgot where this was at, sorry :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:03:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 12:03:59 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|dcook at prosentient.com.au |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 13:55:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 12:55:32 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:32:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:32:02 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:36:06 +0000 Subject: [Koha-bugs] [Bug 29780] New: Add Koha::Old::Holds->anonymize Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Bug ID: 29780 Summary: Add Koha::Old::Holds->anonymize Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Add high-level methods to anonymize holds history as needed by bug 29526. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:36:17 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29526 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:36:17 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29780 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 [Bug 29780] Add Koha::Old::Holds->anonymize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:36:41 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:36:45 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128812|0 |1 is obsolete| | Attachment #128813|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 128959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128959&action=edit Bug 29018: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:36:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:36:49 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 --- Comment #11 from Jonathan Druart --- Created attachment 128960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128960&action=edit Bug 29018: Make DELETE /patrons/:patron_id check things When the route was implemented, the checks were overlooked. This patch adds checks for: - Guarantees - Debts - Current checkouts Any of those will block deletion, as it should. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail, the route misses checks 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! The three conditions prevent deletion! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:39:07 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:39:11 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128921|0 |1 is obsolete| | Attachment #128922|0 |1 is obsolete| | Attachment #128923|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 128961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128961&action=edit Bug 28020: Unit tests The unhandled_exception() Mojo helper didn't have proper tests. As this bug is adding a slight behavior change, I tried to add some. As it relies on the OpenAPI plugin, it cannot be done the usual way using Mojo::Lite. So I picked a route and forced an exception through mocking to be able to write tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/unhandled_exceptions.t => FAIL: The unhandled_exception() helper doesn't return an error_code in the response payload. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:39:15 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 --- Comment #13 from Jonathan Druart --- Created attachment 128962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128962&action=edit Bug 28020: Add error_code to error responses This patch adds the *error_code* attribute to the error response definition. This way it can be added when returning an error. I also made a sample usage of it on the generic unhandled_exception helper, which the unit tests on this patchset expect. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/unhandled_exceptions.t => FAIL: The unhandled_exception() helper doesn't return an error_code in the response payload. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:39:20 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 --- Comment #14 from Jonathan Druart --- Created attachment 128963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128963&action=edit Bug 28020: (follow-up) Add docs about error_code on the API This patch intends to be a guide for inserting Markdown documentation for error codes. The idea is that it can be copied and pasted as-is in new routes. And adapted to new error codes. To test: 1. Apply this patch 2. Run: $ npx redoc-cli at 0.10.4 bundle --cdn --output index.html \ api/v1/swagger/swagger.yaml => SUCCESS: It builds correctly 3. Open index.tml on your browser 4. Pick a route, and see the 500 status description includes information about the possible `error_code` values. 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:39:47 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 128964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128964&action=edit Bug 29780: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:39:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:39:50 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 128965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128965&action=edit Bug 29780: Add Koha::Old::Holds->anonymize This patch adds a handy method for anonymizing a Koha::Old::Holds resultset. It is planned to be used on bug 29526. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:42:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:42:22 +0000 Subject: [Koha-bugs] [Bug 25387] Avoid merge different type of authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25387 --- Comment #14 from marion.durand at biblibre.com --- Hi ! In my understanding (I can be wrong), Marcel is saying that we shouldn't only allow merging when the losing record is unused, because if we notice two record we want to merge and both of them are used, we will have to manually relink them (to make one used and the other not). And only then we can merge the record. So it's not the actual merging that would be a problem but the process before, to make the merge possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:46:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:46:43 +0000 Subject: [Koha-bugs] [Bug 28734] Koha::Biblio->get_marc_notes should parse authorised values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #32 from Jonathan Druart --- (In reply to Pablo AB from comment #31) > Will be backported to 21.05.x? Yes, it should be backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:48:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:48:40 +0000 Subject: [Koha-bugs] [Bug 29665] Claims Returned status cannot be removed if BlockReturnofLostItems set to Block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29665 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Andrew Fuerste-Henry --- Marking as duplicate of broader bug. *** This bug has been marked as a duplicate of bug 29769 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 14:48:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 13:48:40 +0000 Subject: [Koha-bugs] [Bug 29769] Claim return status cannot be changed without checking item in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29769 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- *** Bug 29665 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:18:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 14:18:51 +0000 Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan period if borrower has an 'unfound' hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102 --- Comment #5 from Nick Clemens --- (In reply to Christopher Brannon from comment #4) > I'm using a sandbox, and I haven't applied the patch yet and I am not > running into the problem in step 5. It just checks out the item and removes > the hold. Ah, I described it in initial comment "and there are other holds" When set to dynamic we check: $threshold = $items_count + $decreaseLoanHighHoldsValue; $holds->count() <= $threshold items_count will be 0 (none holdable) but holds count is still 1, so not over the threshold Amended steps below: step 4 - place title level holds for 2 patrons step 5 - attempt to checkout to one of the patrons who have a hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 14:35:35 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128964|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi --- Created attachment 128966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128966&action=edit Bug 29780: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:38:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 14:38:37 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com --- Comment #9 from Jonathan Druart --- +use overload bool => \&as_bool; I didn't notice that the first time I read this patch, and it's awesome! I will provide you a QA feedback soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:39:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 14:39:27 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart --- If we are using Koha::Result::Boolean for Koha::Patron->safe_to_delete we certainly need to implement it for Koha::Item->safe_to_delete as well (same time, same push). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:42:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 14:42:08 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #10 from Jonathan Druart --- (In reply to Jonathan Druart from comment #9) > +use overload bool => \&as_bool; > > I didn't notice that the first time I read this patch, and it's awesome! > > I will provide you a QA feedback soon. And, to explain a bit more: """ use Koha::Result::Boolean; sub ok { return Koha::Result::Boolean->new(1)->add_message({message => "this is not an error"}); } sub nok { return Koha::Result::Boolean->new(0)->add_message({message => "this is an error"}); } if ( ok() ) { say "all good"; } unless ( nok() ) { say "there was an error"; } """ => will display "all good" and "there was an error" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:46:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 14:46:29 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #11 from Jonathan Druart --- I don't think "Koha::Result::Boolean" is good. What is then a Koha::Result? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:48:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 14:48:43 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #9) > +use overload bool => \&as_bool; > > I didn't notice that the first time I read this patch, and it's awesome! > > I will provide you a QA feedback soon. Thank you! That was my feeling when I noticed overload existed as well :-D (In reply to Jonathan Druart from comment #11) > I don't think "Koha::Result::Boolean" is good. What is then a Koha::Result? Right, I was not sure about the name. Maybe I'm going too far thinking we could need another result types. I'd go with whatever to be honest. Koha::Result sounds correct as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 15:49:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 14:49:18 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 --- Comment #9 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #4) > Created attachment 128837 [details] [review] > Bug 29736: Restore searching Oops, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:05:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:05:30 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:07:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:07:50 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 128967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128967&action=edit Bug 29526: Add a way for patrons to delete their hold history The same way we have a button to immediately delete the checkouts history in the OPAC, we should have a similar option for the holds history. This patch implements that. To test: 1. Have a patron with some old checkouts and old holds. 2. Have OPACPrivacy, OPACHoldsHistory and opacreadinghistory enabled. 3. Notice in the OPAC the patron has some old checkouts and holds. 4. Use the Privacy tab to clean checkouts => SUCCESS: They are still cleaned as before this patch 5. Try to clean the old holds => SUCCESS: They are cleaned! 6. Add some old checkouts and holds 7. Use the new 'All' button => SUCCESS: All cleaned 8. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:09:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:09:02 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Tomás Cohen Arazi --- This works correctly. I have doubts about the buttons on the page and the layout. Any ideas are welcome! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:11:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:11:09 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > If we are using Koha::Result::Boolean for Koha::Patron->safe_to_delete we > certainly need to implement it for Koha::Item->safe_to_delete as well (same > time, same push). Sure, if we have consensus on things, I can do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:21:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:21:06 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 --- Comment #4 from Tomás Cohen Arazi --- Just added some more tests, for the empty restultset case, which returns the weird '0E0' value instead of plain zero [1], and wanted to highlight it, as I stumbled upon it on bug 29526. [1] https://stackoverflow.com/questions/13358793/why-does-dbis-do-method-return-0e0-if-zero-rows-were-affected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:21:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:21:47 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29780 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 [Bug 29780] Add Koha::Old::Holds->anonymize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:21:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:21:47 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:21:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:21:55 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:33:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:33:31 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:33:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:33:34 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125497|0 |1 is obsolete| | Attachment #125498|0 |1 is obsolete| | Attachment #125499|0 |1 is obsolete| | Attachment #126591|0 |1 is obsolete| | --- Comment #21 from Nick Clemens --- Created attachment 128968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128968&action=edit Bug 28633: DB update This adds the field to necessary tables and updates API and columns def -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:33:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:33:38 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #22 from Nick Clemens --- Created attachment 128969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128969&action=edit Bug 28633: Add preferred name field to patrons This patch adds a new field 'preferred_name' to the patron record. Additionally it adds a method 'effective_name' to choose the preferred name if present and fall back to firstname The 'firstname' is displayed as 'First name' on the details page, with id/class patron_first_name to allow ajusting via JS/CSS if library wants to highlight/hide the non-preferred name PatronAutoComplete/ysearch is updated to use 'effective_name' method To test: 1 - Apply patches 2 - Update database and restart all, clear browser cache 3 - Load a patron in staff module 4 - Confirm you see and can add a preferred name 5 - Confirm the preferred name and first name now displays on patron details 6 - Remove first name from patron record and confirm it no longer shows 7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to confirm you can make new field required or hidden 8 - Sign in as patron to opac 9 - Confirm preferred name shows 10 - Edit account on opac and confirm field is present 11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had firstname 12 - Perform checkout and patron search using preferred_name, confirm patron is found 13 - Enable PatronAutoComplete system preference 14 - Type patron's surname into Checkout or patron search but don't hit enter 15 - Confirm patron is displayed with 'preferred_name' in the preview -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:33:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:33:42 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #23 from Nick Clemens --- Created attachment 128970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128970&action=edit Bug 28633: DO NOT PUSH Schema Changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:45:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:45:23 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:45:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:45:26 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128474|0 |1 is obsolete| | Attachment #128475|0 |1 is obsolete| | Attachment #128476|0 |1 is obsolete| | --- Comment #29 from Nick Clemens --- Created attachment 128971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128971&action=edit Bug 29043: Don't load items unless a p[atron has been chosen on request.pl This patch moves the code that we sh9ould run if there is no patron to the head of the biblio loop. If we have no patron we execute this and go to the next loop. A few variables that were being passed to the template in the loop are moved outside - no reason to overwrite each loop To test: 1 - Browse to a bib in the staff client 2 - Click on the holds tab 3 - Note loading time 4 - Add 500 items to bib 5 - Note loading time - it takes longer 6 - Note items are not displayed 7 - Apply patch 8 - Reload page - is much faster 9 - Find/choose a patron 10 - Confirm items are loaded correctly Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:45:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:45:30 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #30 from Nick Clemens --- Created attachment 128972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128972&action=edit Bug 29043: Prune dead code Remove sort_borrowerlist as it was not used Remove "time" for form name I don't see nay reason we needed this Remove messagetransfert from template Never passed in code Remove totalcount variable Assigned and never referenced Remove 'alreadyres'/'alreadyreserved' from template All references in coide were in template - never set or passed Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:45:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:45:34 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #31 from Nick Clemens --- Created attachment 128973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128973&action=edit Bug 29043: Remaining bug is the incorrect title "Place a hold on No title" This version takes account of the batch-mode. I only just add the line: $template->param( biblio => $biblio ) if scalar @biblionumbers == 1; inside the foreach loop. All my other patch-fixes are obsolete. Signed-off-by: Samu Heiskanen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 16:52:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 15:52:48 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #13 from Jonathan Druart --- "Return value" sounds better to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 17:11:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 16:11:11 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.09 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #14 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 17:11:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 16:11:23 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 18:44:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 17:44:49 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #4 from Barbara Johnson --- All the functionality of the buttons worked correctly. I think the layout of the buttons looks fine. Here are my observations from testing: 1. I had to enable the AnonymousPatron sys pref in order to make the test plan work. 2. I think the first sentence under the 'Immediate deletion' heading should be changed. The word 'your' is not needed and makes the sentence read awkwardly. Also I would change 'here' to 'below' since there are now three button options. I think this text would be more clear: Whatever privacy rule you choose, you can delete all your checkout and hold history immediately by clicking below. 3. Once you have cleared your holds history from the privacy tab and then go to the holds history tab it states that "You have never placed a hold from this library." That is not really true - the holds history either has never been kept or has been cleared. The Checkout history tab displays 'No data available in table' when there is no checkout history. Maybe the text on the Holds history tab should be the same or similar. 4. The pre-patch behavior with the single 'Immediate deletion' button includes the following text - Please note, the last person to return an item is tracked for the management of items returned damaged. This still needs to be included so that the patron is aware of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:09:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 18:09:31 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #5 from Lucas Gass --- Created attachment 128974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128974&action=edit Bug 29526: (follow-up) Put delete buttons in HTML table Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:18:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 18:18:14 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 128975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128975&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:18:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 18:18:19 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 128976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128976&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev > UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY); 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:18:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 18:18:26 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 128977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128977&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:27:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 18:27:02 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:27:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 18:27:04 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128965|0 |1 is obsolete| | Attachment #128966|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 128978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128978&action=edit Bug 29780: Add Koha::Old::Holds->anonymize This patch adds a handy method for anonymizing a Koha::Old::Holds resultset. It is planned to be used on bug 29526. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:27:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 18:27:10 +0000 Subject: [Koha-bugs] [Bug 29780] Add Koha::Old::Holds->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 --- Comment #6 from Lucas Gass --- Created attachment 128979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128979&action=edit Bug 29780: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:35:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 18:35:29 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 19:38:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 18:38:09 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #11) > I don't think "Koha::Result::Boolean" is good. What is then a Koha::Result? I thought of writing Koha::Result as a generic class with the messages bit, and then Koha::Result::Boolean, Koha::Result::Integer, inherit from it. Are you willing to submit a follow-up renaming it to Koha::Result or similar? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:10:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 19:10:06 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 --- Comment #8 from Andrew Fuerste-Henry --- Adding some details to the test plan, to spare others having to think about it :) 1 - have a record with 245a "the best book ever" 2 - create a modification template to copy and replace the 245a to the 245a, using regex 3 - in your regex, match "(.+\b)best(.+)" and replace with "$1worst$2" 4 - perform a batch mod on your record, end up with "$1worst$2" as your literal title 5) Apply the patch and try again, this time the capture group should yield the expected results. 6) Run t/SimpleMARC.t and confirm the tests still pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:13:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 19:13:38 +0000 Subject: [Koha-bugs] [Bug 29781] New: Allow item batch modification to use capturing groups in regex option Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Bug ID: 29781 Summary: Allow item batch modification to use capturing groups in regex option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Bug 23873 seeks to make capturing groups usable in batch record mod. We should do the same with items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:13:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 19:13:38 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29781 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:19:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 19:19:52 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:19:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 19:19:55 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128432|0 |1 is obsolete| | --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 128980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128980&action=edit Bug 23873: Unit tests This patch adds a unit test for capture groups support in Koha::SimpleMARC. Test plan 1) Run the test prior to applying the capture groups fix, note it fails. 2) Apply teh capture groups fix patch 3) Run the test again, it should now pass Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 3 20:19:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 19:19:59 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128433|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 128981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128981&action=edit Bug 23873: Enable capture groups in MarcModificationTemplates This patch adds support for regular expression capture groups in MarcModificationTemplates. We escape double quotes in the replacement string, then quote the whole string before applying the `ee` modifier to the final regex application. See https://blog.james.rcpt.to/2010/10/25/perl-search-and-replace-using-variables/ for further details. Test plan 1) Attempt to use capture groups in your regular expression based MarcModificationTemplate and note it does not work. 2) Apply the patch and try again, this time the capture group should yield the expected results. 3) Run t/SimpleMARC.t and confirm the tests still pass. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:03:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 23:03:16 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #6 from Lucas Gass --- Created attachment 128982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128982&action=edit Bug 29526: (follow-up) change wording on opac-holdshistory.tt when table is empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:06:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 23:06:38 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #7 from Lucas Gass --- Thanks for testing Barbara! > 2. I think the first sentence under the 'Immediate deletion' heading should > be changed. The word 'your' is not needed and makes the sentence read > awkwardly. Also I would change 'here' to 'below' since there are now three > button options. I think this text would be more clear: I addressed this in a follow-up, the wording should be clearer now. > 3. Once you have cleared your holds history from the privacy tab and then go > to the holds history tab it states that "You have never placed a hold from > this library." That is not really true - the holds history either has never > been kept or has been cleared. The Checkout history tab displays 'No data > available in table' when there is no checkout history. Maybe the text on > the Holds history tab should be the same or similar. I provided a follow-up to change the text on opac-holdshistory.tt to be more truthful. It should say 'No data available' now if you have no holds history. > 4. The pre-patch behavior with the single 'Immediate deletion' button > includes the following text - Please note, the last person to return an item > is tracked for the management of items returned damaged. This still needs > to be included so that the patron is aware of it. This text has not been changed but in order to see it the StoreLastBorrower system preference must be turned on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:13:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 23:13:15 +0000 Subject: [Koha-bugs] [Bug 29782] New: Missing entries for display locations in HTML customizations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Bug ID: 29782 Summary: Missing entries for display locations in HTML customizations Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mik at adminkuhn.ch QA Contact: testopia at bugs.koha-community.org In Koha menu "Tools > HTML customizations" it is possible to create new entries for various display locations. Given the Koha instance has two languages, "English (en)" and "Deutsch Deutschland (de-DE)" an entry will show three tabs: * Default * English (en) * Deutsch Deutschland (de-DE) If you fill just text into the "Content" field of the actual language tabs you will be prompted with a popup saying "Please specify a title for Default". In fact I don't know why such a "title" is needed at all (see also bug 29515), but OK I fill one in, but do not fill any content into the "Content" field of the Default tab because I don't want or need no default content. Now it's possible to save. The content of tab "English (en)" and "Deutsch Deutschland (de-DE)" will show up in the OPAC when changing to the respective language. But Koha menu "Tools > HTML customizations" will NOT show any entry for the display location you have created! So you are not able to change its content or delete it. The problem doesn't happen if you enter text in the "Content" field of the Default tab. This means 1. It is not clear why the default tab is mandatory. 2. It shouldn't be possible to save the entry for a display location without entering text in the "Content" field of the Default tab if the consequence is that there won't be no entry for the display location in the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:17:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 23:17:31 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #20 from David Cook --- (This is just a side note but I wonder if another way of doing this would be implementing a TTL mechanism.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:19:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 23:19:05 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #8 from Barbara Johnson --- I will test again tomorrow. One other thing I noticed - The tab on the left side with all the account options displays 'Your holds history.' But the buttons on the privacy page display as 'Your hold history.' One is plural and one is singular - should they match? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 00:39:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jan 2022 23:39:05 +0000 Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:12:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 00:12:15 +0000 Subject: [Koha-bugs] [Bug 20417] Remove OpacCloud system preference and feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20417 --- Comment #4 from David Cook --- Actually, I think Gaetan is right about it being removed. If you look at ./opac/opac-tags_subject.pl and koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags_subject.tt, you'll see this was originally designed as an experimental French feature. The opac-tags_subject.pl page just seems to be a neglected version of opac-tags.pl, which doesn't actually work as designed if you have user tagging turned on. It might be worthwhile to add removing OpacBrowser at the same time as OpacCloud since it also appears to be an experimental French-only feature according to ./misc/cronjobs/build_browser_and_cloud.pl and https://wiki.koha-community.org/wiki/Opac_browse_feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:12:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 00:12:28 +0000 Subject: [Koha-bugs] [Bug 20417] Remove OpacCloud (and OpacBrowser) system preference and feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20417 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove OpacCloud system |Remove OpacCloud (and |preference and feature |OpacBrowser) system | |preference and feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:14:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 00:14:08 +0000 Subject: [Koha-bugs] [Bug 20417] Remove OpacCloud (and OpacBrowser) system preference and feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20417 --- Comment #5 from David Cook --- I had a library recently want to use OpacBrowser but the system preference description is misleading. If we don't remove this functionality, I think we should change the system preference names and descriptions to reflect the actual functionality. Otherwise, I think people are just getting confused by this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:30:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 00:30:08 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:30:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 00:30:12 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128881|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 128983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128983&action=edit Bug 29764: Fix incorrect EmbedItems RecordProcessor filter POD This patch makes the usage POD for the EmbedItems filter actually be usable. The filter is used in opac-ISBDdetail.pl and the POD is updated to how it is used there. Not much to test. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:37:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 00:37:52 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|dcook at prosentient.com.au |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 01:54:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 00:54:10 +0000 Subject: [Koha-bugs] [Bug 29774] Self registration notification management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29774 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 03:57:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 02:57:25 +0000 Subject: [Koha-bugs] [Bug 25705] Viewing all serials issues should not require serials permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25705 --- Comment #3 from David Cook --- I don't think that I'll be working on this one, but it would be great to see an improvement in this area. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 04:01:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 03:01:28 +0000 Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles hidden by OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704 --- Comment #2 from David Cook --- Still an issue in master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 04:03:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 03:03:44 +0000 Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles hidden by OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704 --- Comment #3 from David Cook --- It should also take into account OpacSuppression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 06:02:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 05:02:14 +0000 Subject: [Koha-bugs] [Bug 29783] New: Account lockout message appears incorrectly for blank userid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 Bug ID: 29783 Summary: Account lockout message appears incorrectly for blank userid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org If a Koha instance has a borrower with an blank/empty userid and login_attempts over the threshold defined by FailedLoginAttempts, a user will see "Error: This account has been locked!" when visiting the staff interface for the first time and without supplying any login details. This is because we're doing a Koha::Patrons->find with an empty string! The solution is very simple... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 06:02:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 05:02:24 +0000 Subject: [Koha-bugs] [Bug 29783] Account lockout message appears incorrectly for blank userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 06:09:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 05:09:51 +0000 Subject: [Koha-bugs] [Bug 29783] Account lockout message appears incorrectly for blank userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 06:09:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 05:09:55 +0000 Subject: [Koha-bugs] [Bug 29783] Account lockout message appears incorrectly for blank userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 --- Comment #1 from David Cook --- Created attachment 128984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128984&action=edit Bug 29783: Add account lockout patron userid lookup condition This patch checks that $q_userid is not blank before trying to do a patron lookup. This prevents a spurrious account locked message from appearing to the user when there is a user in Koha that has an empty userid and too many login_attempts. Test plan: 0) Do not apply the patch yet 1) Set system preference FailedLoginAttempts to 3 2) Modify a borrower to have an empty userid and 10 login_attempts e.g. update borrowers set userid = '', login_attempts = 10 where cardnumber = 23529001223636; 3) Visit the staff interface (e.g. http://localhost:8081/) 4) Note the message "Error: This account has been locked!" even though you have not tried to log in 5) Apply the patch 6) Visit the staff interface (e.g. http://localhost:8081/) 7) Note that there is no error message about your account being locked 8) Profit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:57:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 06:57:35 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |25033 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 [Bug 25033] Counts of suggestions are confusing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:57:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 06:57:35 +0000 Subject: [Koha-bugs] [Bug 25033] Counts of suggestions are confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29571 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 06:59:30 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 06:59:32 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 --- Comment #13 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 06:59:34 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 06:59:37 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 06:59:39 +0000 Subject: [Koha-bugs] [Bug 29604] Term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 06:59:41 +0000 Subject: [Koha-bugs] [Bug 29604] Term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 06:59:44 +0000 Subject: [Koha-bugs] [Bug 29729] If serials_stats.pl returns no results dataTables get angry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 07:59:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 06:59:46 +0000 Subject: [Koha-bugs] [Bug 29729] If serials_stats.pl returns no results dataTables get angry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:19:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:19:19 +0000 Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24387 CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- Indeed I reproduce the bug. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:19:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:19:19 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 [Bug 29782] Missing entries for display locations in HTML customizations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:21:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:21:02 +0000 Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 --- Comment #2 from Fridolin Somers --- I think it comes from : https://git.koha-community.org/Koha-community/Koha/src/commit/9a8ea2e46da6c788a633383b81cce70c9323f750/tools/additional-contents.pl#L120 I think we should deleted only if both title and content are empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:24:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:24:59 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:43:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:43:40 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #26 from Jonathan Druart --- (In reply to Katrin Fischer from comment #25) > > Is there a way we could fix this once and for all? Or at least provide > information/warning to users? We can eventually run this query and display a warning on the about page if some tables are not using "Dynamic". SELECT table_name,row_format FROM information_schema.tables WHERE table_schema='koha_kohadev' AND row_format != "Dynamic"; A link to a wiki page explaining the problem and providing a solution would be great as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:44:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:44:47 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #20 from Fridolin Somers --- (In reply to Fridolin Somers from comment #19) > Ah atomic update script needs to be updated to match new DBRev system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:54:15 +0000 Subject: [Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped in selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:54:17 +0000 Subject: [Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped in selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:54:19 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in 0001 option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:54:22 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in 0001 option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 --- Comment #12 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:54:24 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 08:54:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 07:54:27 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 09:24:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 08:24:06 +0000 Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from 20.05.xx to 20.11.04-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #27 from Katrin Fischer --- Could it make sense to stop the installer until the tables have been fixed? Like we do for missing dependencies? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 09:25:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 08:25:20 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 --- Comment #21 from Katrin Fischer --- (In reply to Fridolin Somers from comment #20) > (In reply to Fridolin Somers from comment #19) > > Ah atomic update script needs to be updated to match new DBRev system. So far it was not mandatory, maybe we should add to coding guidelines/communicate - we have a lot of old database updates out there. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 09:26:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 08:26:20 +0000 Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 --- Comment #3 from Katrin Fischer --- We also had agreed that the title should not be mandatory, see: Bug 29515 - Don't require title for HTML customizations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 10:38:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 09:38:50 +0000 Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29778 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 10:38:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 09:38:50 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29782 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:12:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:12:08 +0000 Subject: [Koha-bugs] [Bug 29784] New: Adding Action Log tips to Manual Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29784 Bug ID: 29784 Summary: Adding Action Log tips to Manual Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There is a super handy chart in the Koha Report Wiki that helps users understand what fields need what information when running the log viewer. This is an extremely useful chart and one that would benefit from being in the manual as well. If a user went to the log viewer page in the Staff Interface, it would be nice if they did need help, the "Help" button would bring them to the manual where the instructions on how to use the log viewer and the handy chart information could live together. This is the chart I am referring to: https://wiki.koha-community.org/wiki/SQL_Reports_Library#action_logs Currently, this is all that lives in the manual for using the logs: https://koha-community.org/manual//21.05/en/html/tools.html#log-viewer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:20:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:20:52 +0000 Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #4 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #3) > Any advice, Jonathan, as to best way to proceed here ? About? The atomic updates look good to me. There are some typos I am going to fix. One thing maybe: installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml: authorised_value: Unititle "Unititle" does not exist in the AV list of the sample data. What else would be needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:21:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:21:18 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:21:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:21:35 +0000 Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #5 from Jonathan Druart --- Created attachment 128985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128985&action=edit Bug 29390: Fix syntax error in atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:26:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:26:49 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in 0001 option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:27:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:27:58 +0000 Subject: [Koha-bugs] [Bug 29785] New: Koha::Object->messages must be renamed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Bug ID: 29785 Summary: Koha::Object->messages must be renamed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org It will conflict with other ->messages methods, it's too generic. Bug 29230 needs Koha::Patron->messages to return Koha::Patron::Messages for instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:28:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:28:17 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29785 --- Comment #13 from Jonathan Druart --- I opened bug 29785 to rename it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 [Bug 29785] Koha::Object->messages must be renamed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:28:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:28:17 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29230 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 [Bug 29230] Patron's messages not accessible from template notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:35:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:35:55 +0000 Subject: [Koha-bugs] [Bug 29786] New: Holds to pull report shows incorrect item for item level holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Bug ID: 29786 Summary: Holds to pull report shows incorrect item for item level holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When running holds to pull it can show the wrong item for an item level hold. This is because we simply get the first barcode from the list of items that can fill the hold. The issue seems to come from 'get_items_that_can_fill' in Koha::Holds This does not take into account that an item level hold can only be filled by one item To recreate: 1 - Find a record with many items available 2 - Place an item level hold for an item on the record, not the one with lowest itemnumber 3 - Run 'Hold to pull' report 4 - Note the barcode does not match -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:38:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:38:09 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:38:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:38:13 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 --- Comment #1 from Jonathan Druart --- Created attachment 128986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128986&action=edit Bug 29785: Rename Koha::Object->message with ->object_messages It will conflict with other ->messages methods, it's too generic. Bug 29230 needs Koha::Patron->messages to return Koha::Patron::Messages for instance. Test plan: Confirm that the tests modified by this patch still pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:38:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:38:23 +0000 Subject: [Koha-bugs] [Bug 29230] Patron's messages not accessible from template notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:42:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:42:36 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:42:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:42:39 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 --- Comment #1 from Nick Clemens --- Created attachment 128987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128987&action=edit Bug 29786: Unit tests I add a new test for the case of an item level hold, and additionally adjust later tests to use a title level hold. I also fix a typo where the comment says item 1 when it means item 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:42:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:42:43 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 --- Comment #2 from Nick Clemens --- Created attachment 128988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128988&action=edit Bug 29786: Select only specific items for item level holds This patch adjusts get_items_that_can_fill to make two requests: first the list of items for item-level holds second the list of biblionumbers for title-level holds This stops the report from pulling more items for item-level hold This patch also removes the aliases used in the code - while readability is a bit harder, it allows for using 'me' in get_items_that_can_fill Otherwise, this routine would need a parameter to know what we called the table. To test: 1 - Find a record with many items available 2 - Place an item level hold for an item on the record, not the one with lowest itemnumber 3 - Run 'Hold to pull' report 4 - Note the barcode does not match 5 - Apply patch 6 - Reload report 7 - It matches! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:43:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:43:07 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:57:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:57:00 +0000 Subject: [Koha-bugs] [Bug 29787] New: Add plugin version to plugin search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787 Bug ID: 29787 Summary: Add plugin version to plugin search results Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org When you search for a plugin it doesn't tell which version it is going to install. Additionally, it would be great if instead of just an 'install' button, they mutated to 'upgrade' or 'reinstall' if that applies. Otherwise you don't know what's going on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 14:58:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 13:58:48 +0000 Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com --- Comment #1 from Tomás Cohen Arazi --- I haven't checked if it is actually possible with the gitlab/github APIs. Just reporting this needs improvement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:06:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:06:18 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:06:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:06:21 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128987|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 128989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128989&action=edit Bug 29786: Unit tests I add a new test for the case of an item level hold, and additionally adjust later tests to use a title level hold. I also fix a typo where the comment says item 1 when it means item 2 Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:06:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:06:24 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128988|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 128990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128990&action=edit Bug 29786: Select only specific items for item level holds This patch adjusts get_items_that_can_fill to make two requests: first the list of items for item-level holds second the list of biblionumbers for title-level holds This stops the report from pulling more items for item-level hold This patch also removes the aliases used in the code - while readability is a bit harder, it allows for using 'me' in get_items_that_can_fill Otherwise, this routine would need a parameter to know what we called the table. To test: 1 - Find a record with many items available 2 - Place an item level hold for an item on the record, not the one with lowest itemnumber 3 - Run 'Hold to pull' report 4 - Note the barcode does not match 5 - Apply patch 6 - Reload report 7 - It matches! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:12:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:12:44 +0000 Subject: [Koha-bugs] [Bug 29729] If serials_stats.pl returns no results dataTables get angry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:16:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:16:25 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:19:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:19:01 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:20:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:20:59 +0000 Subject: [Koha-bugs] [Bug 28216] Fix vendor list group by in serials statistics wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:22:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:22:53 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:24:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:24:55 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:37:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:37:51 +0000 Subject: [Koha-bugs] [Bug 29788] New: Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Bug ID: 29788 Summary: Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 29746 Same as bug 29765 for the existing Koha::Item->safe_to_delete Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 [Bug 29746] Add a handy Koha::Result::Boolean class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:37:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:37:51 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:37:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:37:51 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29788 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:41:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:41:11 +0000 Subject: [Koha-bugs] [Bug 29789] New: Unused $error in cataloguing/additem.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 Bug ID: 29789 Summary: Unused $error in cataloguing/additem.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org my $error = $input->param('error'); It should be removed as $error is used later but not related to this variable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:41:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:41:58 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:42:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:42:02 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 --- Comment #1 from Jonathan Druart --- Created attachment 128991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128991&action=edit Bug 29789: Remove unused $error from cataloguing/additem.pl my $error = $input->param('error'); It should be removed as $error is used later but not related to this variable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:42:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:42:18 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:42:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:42:24 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 [Bug 29789] Unused $error in cataloguing/additem.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:42:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:42:24 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:44:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:44:35 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:44:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:44:47 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 15:46:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 14:46:23 +0000 Subject: [Koha-bugs] [Bug 29679] Reports result menu shows too many dividers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:00:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:00:29 +0000 Subject: [Koha-bugs] [Bug 29790] New: Deleting serial items fail without warning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 Bug ID: 29790 Summary: Deleting serial items fail without warning Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org If the deletion of a serial item failed, the UI does not provide a warning/error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:00:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:00:41 +0000 Subject: [Koha-bugs] [Bug 29790] Deleting serial items fail without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:00:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:00:41 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 [Bug 29790] Deleting serial items fail without warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:12:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:12:25 +0000 Subject: [Koha-bugs] [Bug 29790] Deleting serial items fail without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:12:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:12:29 +0000 Subject: [Koha-bugs] [Bug 29790] Deleting serial items fail without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 --- Comment #1 from Jonathan Druart --- Created attachment 128992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128992&action=edit Bug 29790: Restore warning if deletion of serial item fails If the deletion of a serial item failed, the UI did not provide a warning/error message. Test plan: 0. Create a new subscription with "Create an item record when receiving this serial" 1. Receive a new item, set a barcode 2. Check it out 3. Select the item you have received in the serial item list (page "Serial collection information") and click "Delete selected issues" 4. Tick "Delete the associated items" and confirm the deletion => Without this patch the deletion fail but the UI does not warn it => With this patch applied you see a warning "one or more associated items could not be deleted at this time." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:16:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:16:43 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:16:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:16:47 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 --- Comment #1 from Jonathan Druart --- Created attachment 128993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128993&action=edit Bug 29788: Make Koha::Item->safe_to_delete use Koha::Result::Boolean This patch reuse the (awesome) Koha::Result::Boolean module to retrieve the return of Koha::Item->safe_to_delete. Test plan: Try to delete an item that has previously been checked out and confirm that you are still blocked. Try using the cronjobs, the item and biblio detail pages, as well as the batch delete item tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:19:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:19:07 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:19:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:19:11 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128814|0 |1 is obsolete| | Attachment #128815|0 |1 is obsolete| | Attachment #128816|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 128994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128994&action=edit Bug 29741: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:19:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:19:16 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #14 from Jonathan Druart --- Created attachment 128995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128995&action=edit Bug 29741: Add Koha::Patron->safe_to_delete This patchset adds a handy method for checking if a patron meets the conditions to be deleted. This conditions are: - Has no linked guarantees - Has no pending debts - Has no current checkouts - Is not the system-configured anonymous user To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => FAIL: Of course heh 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass, conditions are validated and the right string is returned on each case 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:19:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:19:20 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #15 from Jonathan Druart --- Created attachment 128996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128996&action=edit Bug 29741: (follow-up) Make DELETE /patrons use the new validation method This patch adapts the route so it uses the newly introduced Koha::Patron->safe_to_delete method. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Note: There's a trivial behavior change, in which the 'anonymous patron' use case is caugh eariler than the ->delete call. I left the exception catch block just in case, who knows :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:20:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:20:08 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:20:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:20:13 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128882|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 128997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128997&action=edit Bug 29746: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:20:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:20:19 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128883|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 128998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128998&action=edit Bug 29746: Add Koha::Result::Boolean This patch introduces a new OO class that can be used as return value from methods that need to return boolean values, but also provide some feedback. This last bit is implemented using Koha::Object::Message objects that can carry valuable information. This class can also implement a `to_api()` method so it is suitable for API usage. And so the Koha::Object::Message class. Will be done as needed. If some other result types are required, then we can move some of the messaging logic to a top-level Koha::Result class this one inherits from (and the new one as well, say, Integer?). To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/Koha/Result/Boolean.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:20:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:20:47 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:20:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:20:51 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128928|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 128999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128999&action=edit Bug 29765: Make Koha::Patron->safe_to_delete use Koha::Result::Boolean This patch makes the safe_to_delete method in Koha::Patron return this new object type instead of a plain string. This way we have a consistent way to deal with 'can_*'-like methods return values when feedback is needed. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: The adjusted tests pass. Tests cover the boolean context eval and also the carried messages, that include the same string code that was returned originally. 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:20:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:20:55 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128929|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 129000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129000&action=edit Bug 29765: Adjust DELETE /patrons/:patron_id controller This patch adjusts the only current place using the Koha::Patron->safe_to_delete method to the new return value. There should be no behavior change To test: 1. Apply the previous patches 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail, because of the change, the controller is broken 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! No test tweak required, no behavior change 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:21:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:21:22 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:21:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:21:27 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128941|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 129001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129001&action=edit Bug 29772: Regression tests Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:21:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:21:30 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128942|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 129002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129002&action=edit Bug 29772: Make DELETE /patrons/:patron_id return error codes This patch makes the controller add the error_code attribute on error conditions payload. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Boo, the API doesn't include the error_code attribute on the error responses for the DELETE /patrons/:patron_id route 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! error_code is included in the response! 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:21:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:21:34 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128943|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 129003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129003&action=edit Bug 29772: (follow-up) Document error codes Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:23:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:23:53 +0000 Subject: [Koha-bugs] [Bug 29791] New: KohaOpacLanguage cookie should set the secure flag if using https Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791 Bug ID: 29791 Summary: KohaOpacLanguage cookie should set the secure flag if using https Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:24:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:24:02 +0000 Subject: [Koha-bugs] [Bug 29791] KohaOpacLanguage cookie should set the secure flag if using https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:24:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:24:43 +0000 Subject: [Koha-bugs] [Bug 29791] KohaOpacLanguage cookie should set the secure flag if using https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791 --- Comment #1 from Kyle M Hall --- Created attachment 129004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129004&action=edit Bug 29791 - KohaOpacLanguage cookie should set the secure flag if using https -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:28:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:28:07 +0000 Subject: [Koha-bugs] [Bug 29791] KohaOpacLanguage cookie should set the secure flag if using https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25360 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:28:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:28:07 +0000 Subject: [Koha-bugs] [Bug 25360] Use secure flag for CGISESSID cookie In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25360 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29791 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:33:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:33:30 +0000 Subject: [Koha-bugs] [Bug 29791] KohaOpacLanguage cookie should set the secure flag if using https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea --- To test, the headers should have value set-cookie: secure; for the language cookie, when the site is using https. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:44:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:44:15 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:44:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:44:17 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:44:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:44:37 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129005&action=edit Bug 29789: Remove unused $error from cataloguing/additem.pl my $error = $input->param('error'); It should be removed as $error is used later but not related to this variable. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:49:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:49:41 +0000 Subject: [Koha-bugs] [Bug 29790] Deleting serial items fail without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:49:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:49:43 +0000 Subject: [Koha-bugs] [Bug 29790] Deleting serial items fail without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128992|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 16:50:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 15:50:12 +0000 Subject: [Koha-bugs] [Bug 29790] Deleting serial items fail without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129006&action=edit Bug 29790: Restore warning if deletion of serial item fails If the deletion of a serial item failed, the UI did not provide a warning/error message. Test plan: 0. Create a new subscription with "Create an item record when receiving this serial" 1. Receive a new item, set a barcode 2. Check it out 3. Select the item you have received in the serial item list (page "Serial collection information") and click "Delete selected issues" 4. Tick "Delete the associated items" and confirm the deletion => Without this patch the deletion fail but the UI does not warn it => With this patch applied you see a warning "one or more associated items could not be deleted at this time." Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 17:05:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 16:05:08 +0000 Subject: [Koha-bugs] [Bug 15792] Double-clicking the 'renew' button on circulation.pl will double-charge account management fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15792 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 17:13:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 16:13:34 +0000 Subject: [Koha-bugs] [Bug 15792] Double-clicking the 'renew' button on circulation.pl will double-charge account management fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15792 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 18:09:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 17:09:20 +0000 Subject: [Koha-bugs] [Bug 29756] No Place hold button on OPAC details page if number of items exceeds OpacMaxItemsToDisplay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29756 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 13654 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 18:09:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 17:09:20 +0000 Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many items to display unless viewing them all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Owen Leonard --- *** Bug 29756 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 18:53:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 17:53:48 +0000 Subject: [Koha-bugs] [Bug 29791] KohaOpacLanguage cookie should set the secure flag if using https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:05:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:05:08 +0000 Subject: [Koha-bugs] [Bug 19887] Two Factor Authentication: Google Authenticator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19887 Ola Andersson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ola.andersson at ltu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:06:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:06:28 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Ola Andersson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ola.andersson at ltu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:07:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:07:44 +0000 Subject: [Koha-bugs] [Bug 21741] branch transfers checked in at wrong branch could be clearer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21741 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- As of 21.05, this results in a clear message of "Wrong transfer detected" and a chance to re-route the item correctly or just cancel the transfer. I don't have the bug that changed this in front of me, but I'm closing this one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:15:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:15:58 +0000 Subject: [Koha-bugs] [Bug 29792] New: Transfers created from Wrong Transfer checkin are not sent if modal is dismissed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Bug ID: 29792 Summary: Transfers created from Wrong Transfer checkin are not sent if modal is dismissed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 23092 To recreate: 1 - have an item in transit from Branch A to Branch B 2 - check the item in at Branch A 3 - get a Wrong Transfer message, click Print Slip or OK 4 - query the branchtransfers table, see that your original transfer was cancelled and a new one was made, confirm that new transfer has a datesent value 5 - repeat steps 1-3, but instead of clicking one of the buttons click outside of the modal to make it go away 6 - query the branchtransfers table, see that your original transfer was cancelled and a new one was made, confirm that new transfer DOES NOT HAVE a datesent value So that transfer is just hanging out as requested and the item needs to get checked in again to get it sent. This is a change in behavior, as before bug 23092 the second transfer would be sent immediately even if one clicked away from the modal without selecting anything. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 [Bug 23092] Add 'daterequested' to the transfers table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:15:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:15:58 +0000 Subject: [Koha-bugs] [Bug 23092] Add 'daterequested' to the transfers table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:22:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:22:08 +0000 Subject: [Koha-bugs] [Bug 29774] Self registration notification management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29774 --- Comment #2 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > If you require email verification there won't be a patron account added > immediately, so there is no borrowernumber the notice could be linked to. > The patron account is only created after the user has clicked on the link in > the email. > > But you might be referring to a different workflow? Maybe using the patron > import tool or the ACCTDETAILS email? Isn't there another e-mail that goes to patrons after verification, and when staff create a patron account? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:26:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:26:46 +0000 Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many items to display unless viewing them all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #14 from Christopher Brannon --- Why is the status on this bug blocked? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:28:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:28:12 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29148 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 [Bug 29148] Holds to Pull doesn't reflect item-level holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:28:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:28:12 +0000 Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 [Bug 29786] Holds to pull report shows incorrect item for item level holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:49:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:49:05 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 --- Comment #1 from Andrew Fuerste-Henry --- I should have included that one must have TransfersBlockCirc turned off in order to click away from the modal without selecting something. Also, scanning in another barcode without addressing the modal has the same effect as clicking away from it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:51:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:51:16 +0000 Subject: [Koha-bugs] [Bug 29793] New: Commenting "listen" biblioserver in KOHA_CONF crashes about.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29793 Bug ID: 29793 Summary: Commenting "listen" biblioserver in KOHA_CONF crashes about.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi To replicate: 1. Comment out or delete ... from your Koha config file 2. Navigate to staff client /cgi-bin/koha/about.pl 3. Observe error 500 4. Check error logs, see Can't use an undefined value as a HASH reference at C4/Context.pm line 536. Question: If you are using ElasticSearch, is it still necessary to have Zebra related configurations in KOHA_CONF? Bug appears after Bug 28306 commit 4605304f62228172be094393875625b1e9666bda -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:52:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:52:37 +0000 Subject: [Koha-bugs] [Bug 29793] Commenting "listen" biblioserver in KOHA_CONF crashes about.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29793 --- Comment #1 from Lari Taskula --- (In reply to Lari Taskula from comment #0) > Can't use an undefined value as a HASH reference at C4/Context.pm line 536. The correct line as of 442fb97155285ff4063cdd6279328ebed62ea6d4 is 534 not 536. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 19:58:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 18:58:31 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org --- Comment #2 from Jason Robb --- This is causing disruption in our consortial setting. It is not uncommon to check an item in multiple times. It is also not uncommon for a library to overlook prompts without clicking the buttons on those prompts. Before, if a library checked in an item returning home twice consecutively, it remained in transit. Now, if a library checks in an item returning home twice consecutively, it gets taken out of transit and the item appears Available at the wrong library. As the behavior has changed, this has led to a non-trivial amount of items in our catalog showing Available when they were thought to be in transit. It would be great if the previous behavior were restored, where any number of check-ins on a returning item kept it in transit to its home library (unless something else derails it like a newly placed hold). Otherwise, this creates a large amount of previously unnecessary work to track and retrigger transfers that were mistakenly canceled due to multiple check-ins. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:22:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:22:55 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 129007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129007&action=edit Bug 29746: (it-doesn't-hurt follow-up) More tests In an attempt to add (even) more tests for this library, we wanted to add tests for the return values initialization and then hit a wall when trying to add tests: Test::More tries to compare in string context first [1], and when you force integer context (by using cmp_ok + '==') it tells '==' is not overridden for the class. So this patch adds those tests, and also the overloaded '==' operator that is required for such tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/Result/Boolean.t => SUCCESS: Tests pass 3. Sign off :-D [1] https://metacpan.org/pod/Test::More#Overloaded-objects Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:23:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:23:37 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25755 Depends on| |24434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:23:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:23:37 +0000 Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:23:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:23:37 +0000 Subject: [Koha-bugs] [Bug 25755] Add a Koha::Item->request_transfer method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25755 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29792 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:26:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:26:50 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:26:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:26:53 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 --- Comment #3 from Nick Clemens --- Created attachment 129008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129008&action=edit Bug 29792: Automatically send wrong transfers Bug 24434 reinstated the 'updateWrongTransfer' call here, but made the assertion that the transfer should not be sent until 'Ok' was clicked. I see how unsent transfers are useful for rotation, but I believe for wrong trasnfer we shouldn't require a confirm or print. If a library does want to, the 'transfersblockcirc' system preference will enforce clicking the button to continue To test: 1 - have an item in transit from Branch A to Branch B 2 - check the item in at Branch A 3 - get a Wrong Transfer message, click Print Slip or OK 4 - query the branchtransfers table, see that your original transfer was cancelled and a new one was made, confirm that new transfer has a datesent value 5 - repeat steps 1-3, but instead of clicking one of the buttons click outside of the modal to make it go away 6 - query the branchtransfers table, see that your original transfer was cancelled and a new one was made, confirm that new transfer DOES NOT HAVE a datesent value 7 - Apply patch 8 - Repeat the check in 9 - New transfer is generated and has 'datesent' set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:30:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:30:31 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 --- Comment #4 from AspenCat Team --- We have not seen reports of this yet, but I can definitely see this being an issue for our consortium. There will be times that items do get checked in multiple times, and that would create some of the same havoc that Jason is talking about - Bob Bennhoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:35:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:35:38 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:35:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:35:41 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129008|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 129009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129009&action=edit Bug 29792: Automatically send wrong transfers Bug 24434 reinstated the 'updateWrongTransfer' call here, but made the assertion that the transfer should not be sent until 'Ok' was clicked. I see how unsent transfers are useful for rotation, but I believe for wrong trasnfer we shouldn't require a confirm or print. If a library does want to, the 'transfersblockcirc' system preference will enforce clicking the button to continue To test: 1 - have an item in transit from Branch A to Branch B 2 - check the item in at Branch A 3 - get a Wrong Transfer message, click Print Slip or OK 4 - query the branchtransfers table, see that your original transfer was cancelled and a new one was made, confirm that new transfer has a datesent value 5 - repeat steps 1-3, but instead of clicking one of the buttons click outside of the modal to make it go away 6 - query the branchtransfers table, see that your original transfer was cancelled and a new one was made, confirm that new transfer DOES NOT HAVE a datesent value 7 - Apply patch 8 - Repeat the check in 9 - New transfer is generated and has 'datesent' set Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:36:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:36:11 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:41:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:41:40 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128993|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129010&action=edit Bug 29788: Make Koha::Item->safe_to_delete use Koha::Result::Boolean This patch reuse the (awesome) Koha::Result::Boolean module to retrieve the return of Koha::Item->safe_to_delete. Test plan: Try to delete an item that has previously been checked out and confirm that you are still blocked. Try using the cronjobs, the item and biblio detail pages, as well as the batch delete item tool. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:50:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:50:27 +0000 Subject: [Koha-bugs] [Bug 29794] New: delete_items.pl missing include Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Bug ID: 29794 Summary: delete_items.pl missing include Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz To reproduce: 1. Choose an item that is checked out and copy its barcode 2. Run: $ kshell k$ perl misc/cronjobs/delete_items.pl --verbose \ --where "barcode='39999000010831'" => FAIL: It explodes with: Can't locate object method "find" via package "Koha::Items"... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:50:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:50:40 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Blocks| |29788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:50:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:50:40 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 [Bug 29794] delete_items.pl missing include -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:55:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:55:58 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:56:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:56:03 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129011&action=edit Bug 29794: Add missing include in delete_items.pl This patch adds a missing include so the script is no longer broken. To test: 1. Choose an item that is checked out and copy its barcode 2. Run: $ kshell k$ perl misc/cronjobs/delete_items.pl --verbose \ --where "barcode='39999000010831'" => FAIL: It explodes with: Can't locate object method "find" via package "Koha::Items"... 3. Apply this patch 4. Repeat 2 => SUCCESS: You get: Where statement: where barcode='39999000010831' Item '549' not deleted: book_on_loan 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 20:56:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 19:56:08 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129012&action=edit Bug 29794: (follow-up) Add license -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 21:05:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 20:05:59 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Tomás Cohen Arazi --- I added 29794, which I found while testing this. The results are: - biblio/item views works as expected => SUCCESS - delete_items.pl => SUCCESS/FAIL: The check works, deletion is prevented, but the error message prints the Koha::Object::Message reference. It should be calling ->message in line 86.- batch delete. It also felt like we could do a join on multiple messages too? This last one is not a blocker of course. => FAIL: There's a problem with Koha/UI/Table/Builder/Items.pm line 111 calling 'ne' on the 'safe_to_delete' output (Koha::Result::Boolean). I tried a fast fix (checking the attribute was 'safe_to_delete' and evaluating in boolean context) but it turned out it broke blocking_errors.inc and I got out of fuel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 21:07:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 20:07:36 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129010|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi --- Created attachment 129013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129013&action=edit Bug 29788: Make Koha::Item->safe_to_delete use Koha::Result::Boolean This patch reuse the (awesome) Koha::Result::Boolean module to retrieve the return of Koha::Item->safe_to_delete. Test plan: Try to delete an item that has previously been checked out and confirm that you are still blocked. Try using the cronjobs, the item and biblio detail pages, as well as the batch delete item tool. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 21:08:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 20:08:42 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #3) > => SUCCESS/FAIL: The check works, deletion is prevented, but the error > message prints the Koha::Object::Message reference. It should be calling > ->message in line 86.- batch delete. It also felt like we could do a join on > multiple messages too? This last one is not a blocker of course. Fixed inline on the rebased patch (on top of the bug 29746 follow-up). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 21:35:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 20:35:19 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 22:29:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 21:29:39 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 22:29:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 21:29:42 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 --- Comment #3 from Lucas Gass --- Created attachment 129014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129014&action=edit Bug 29794: Add missing include in delete_items.pl This patch adds a missing include so the script is no longer broken. To test: 1. Choose an item that is checked out and copy its barcode 2. Run: $ kshell k$ perl misc/cronjobs/delete_items.pl --verbose \ --where "barcode='39999000010831'" => FAIL: It explodes with: Can't locate object method "find" via package "Koha::Items"... 3. Apply this patch 4. Repeat 2 => SUCCESS: You get: Where statement: where barcode='39999000010831' Item '549' not deleted: book_on_loan 5. Sign off :-D Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 22:29:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 21:29:45 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129012|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 129015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129015&action=edit Bug 29794: (follow-up) Add license Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 22:30:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 21:30:15 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Attachment #129011|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 22:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 21:31:26 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 23:09:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 22:09:21 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- This is all working fine but the private lists add this bit: Private which creates a display like this: Lists that include this title: list1 Private | list2 To me, that looks a little confusing. Would something like this be better? Lists that include this title: list1(Private) | list2 Also, lists are pipe separated on the detail page and comma separated on the results page. Should this be consistent? Maybe even make them CSS pseudo elements but perhaps we need Bug 27613 to get in first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 23:19:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 22:19:49 +0000 Subject: [Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- Do you think in Case B the link should include the target="_blank" attribute so it opens in a new window? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 23:32:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 22:32:24 +0000 Subject: [Koha-bugs] [Bug 29795] New: if branchcode is included in PatronSelfRegistrationBorrowerMandatoryField it should default to an empty value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Bug ID: 29795 Summary: if branchcode is included in PatronSelfRegistrationBorrowerMandatoryField it should default to an empty value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate; 1. Set branch code as a PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self reg form and look at the Home library field, it defaults to the first choice alphabetically 3. Fill out the other required fields and the captcha. Don't change the branchcode value. 4. Submit the form, it submits. 5. If branchcode is required it should default to an empty value and force the user to make a choice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 23:33:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 22:33:02 +0000 Subject: [Koha-bugs] [Bug 29795] if branchcode is included in PatronSelfRegistrationBorrowerMandatoryField it should default to an empty value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 23:48:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 22:48:01 +0000 Subject: [Koha-bugs] [Bug 29795] if branchcode is included in PatronSelfRegistrationBorrowerMandatoryField it should default to an empty value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 23:48:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 22:48:04 +0000 Subject: [Koha-bugs] [Bug 29795] if branchcode is included in PatronSelfRegistrationBorrowerMandatoryField it should default to an empty value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 --- Comment #1 from Lucas Gass --- Created attachment 129016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129016&action=edit Bug 29795: add empty value for branchcode on self-reg form 1. Set branch code as a PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self reg form and look at the Home library field, it defaults to the first choice alphabetically 3. Fill out the other required fields and the captcha. Don't change the branchcode value. 4. Submit the form, it submits. 5. If branchcode is required it should default to an empty value and force the user to make a choice. 6. Apply patch 7. Repeat 1-3 8. Now you cannot submit the form unless you choose a branchcode 9. Make sure it still works normally when branchcode is not in PatronSelfRegistrationBorrowerMandatoryField -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 23:54:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 22:54:27 +0000 Subject: [Koha-bugs] [Bug 29795] if branchcode is included in PatronSelfRegistrationBorrowerMandatoryField it should default to an empty value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 4 23:57:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jan 2022 22:57:00 +0000 Subject: [Koha-bugs] [Bug 29795] if branchcode is included in PatronSelfRegistrationBorrowerMandatoryField it should default to an empty value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Creates an empty value and release notes| |defaults to it when | |PatronSelfRegistrationBorro | |werMandatoryField includes | |branchcode. This forces | |self registering users to | |make a choice for | |branchcode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 01:46:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 00:46:42 +0000 Subject: [Koha-bugs] [Bug 29630] Failure on selenium 01-installation.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29630 --- Comment #3 from Fridolin Somers --- Same for https://jenkins.koha-community.org/view/master/job/Koha_Master/1877/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 05:45:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 04:45:04 +0000 Subject: [Koha-bugs] [Bug 29796] New: Cannot create new patron accounts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29796 Bug ID: 29796 Summary: Cannot create new patron accounts Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jhenderson at nsd.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hello, My Koha installation suddenly will no longer allow me to create patron accounts. The first prompt I receive is: "Something went wrong when creating the patron. Check the logs." When I open the plack-intranet-log I see this: [2022/01/04 20:42:19] [WARN] Patron creation failed! - {UNKNOWN}: DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at /usr/share/koha/lib/Koha/Patron.pm line 354 I am honestly stumped, I was not having this problem before and I haven't changed any settings that would have caused this. Thankfully, I can use the self-registration feature as a workaround right now until this can get fixed. I can provide additional details if needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 09:03:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 08:03:52 +0000 Subject: [Koha-bugs] [Bug 29796] Cannot create new patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29796 --- Comment #1 from Katrin Fischer --- Hi Jeremiah, what is your exact Koha version? Were there any problems/errors shown during the update? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 09:13:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 08:13:52 +0000 Subject: [Koha-bugs] [Bug 29793] Commenting "listen" biblioserver in KOHA_CONF crashes about.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29793 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- I'd say we move this code into the eval: my $host = _common_config($server, 'listen')->{content}; my $serverinfo = _common_config($server, 'serverinfo'); my $user = $serverinfo->{user}; my $password = $serverinfo->{password}; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 09:27:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 08:27:59 +0000 Subject: [Koha-bugs] [Bug 29796] Cannot create new patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #2 from Jonathan Druart --- Works for me on 21.11.01. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 09:44:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 08:44:14 +0000 Subject: [Koha-bugs] [Bug 29796] Cannot create new patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29796 --- Comment #3 from Katrin Fischer --- Just to make sure, when did it happen and did you run update that caused this? Which was the previous version? As Joubu said it works in new installations, so we need to dig a bit deeper here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 09:57:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 08:57:30 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28255 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 09:57:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 08:57:30 +0000 Subject: [Koha-bugs] [Bug 28255] Follow up to bug 23463 - use item_object in misc/cronjobs/delete_items.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28255 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29794 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 09:58:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 08:58:45 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 --- Comment #5 from Jonathan Druart --- Does nobody use this script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 10:01:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 09:01:23 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 10:01:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 09:01:27 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129015|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 129017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129017&action=edit Bug 29794: (follow-up) Add license Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 10:09:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 09:09:31 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 --- Comment #6 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #3) > It also felt like we could do a join on > multiple messages too? This last one is not a blocker of course. I don't know. Either we should restrict "messages" to only 1 message (do we use more so far?), or we should have a new method in the module to ease the retrieval of a single message. I don't think we should restrict to 1 message only, even if we are not using more than 1 now, we could later. Maybe we could have something like: sub get_unique_message_str { my ( $self ) = @_; croak "There are more than one message" if @{$self->{_messages}} > 1; return @{$deleted->messages}[0]->messages } But that's for a separate bug report anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 10:10:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 09:10:01 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 --- Comment #7 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #3) > It also felt like we could do a join on > multiple messages too? This last one is not a blocker of course. I don't know. Either we should restrict "messages" to only 1 message (do we use more so far?), or we should have a new method in the module to ease the retrieval of a single message. I don't think we should restrict to 1 message only, even if we are not using more than 1 now, we could later. Maybe we could have something like: sub get_unique_message_str { my ( $self ) = @_; croak "There are more than one message" if @{$self->{_messages}} > 1; return @{$self->messages}[0]->messages } But that's for a separate bug report anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 10:34:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 09:34:59 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 10:35:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 09:35:03 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 --- Comment #8 from Jonathan Druart --- Created attachment 129018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129018&action=edit Bug 29788: Fix batch delete item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 10:35:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 09:35:28 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 --- Comment #9 from Jonathan Druart --- Lot of errors in my first patch, sorry about that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 10:38:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 09:38:20 +0000 Subject: [Koha-bugs] [Bug 29797] New: Background job detail for batch delete items not listing the itemnumbers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Bug ID: 29797 Summary: Background job detail for batch delete items not listing the itemnumbers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 28445 If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 10:38:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 09:38:20 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 [Bug 29797] Background job detail for batch delete items not listing the itemnumbers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 10:41:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 09:41:09 +0000 Subject: [Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 10:41:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 09:41:13 +0000 Subject: [Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 --- Comment #1 from Jonathan Druart --- Created attachment 129019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129019&action=edit Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 13:17:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 12:17:58 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- I'm getting this error when running updatedatabase: ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table 'additional_contents' is specified twice, both as a target for 'DELETE' and as a separate source for data at /kohadevbox/koha/C4/Installer.pm line 738 My "About" page says: MySQL version: mysql Ver 15.1 Distrib 10.3.31-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 13:21:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 12:21:46 +0000 Subject: [Koha-bugs] [Bug 27013] Display an image of barcode on slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27013 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #3 from Katrin Fischer --- Hi Severine, does Owen's tip work for you or is there a feature missing that we should add? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 13:24:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 12:24:55 +0000 Subject: [Koha-bugs] [Bug 29732] Check alert in cataloguing authorities should be a static message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 13:25:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 12:25:34 +0000 Subject: [Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be printed without text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 [Bug 13545] Add barcode image generator service -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 13:25:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 12:25:34 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20676 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 [Bug 20676] svc/barcode should allow barcode to be printed without text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 13:26:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 12:26:39 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #17 from Katrin Fischer --- Maybe I missed it, but I think this would be great to have in the manual as it makes it possible to add scannable information to slips -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 13:29:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 12:29:21 +0000 Subject: [Koha-bugs] [Bug 20894] Feature request: pass barcode width and height as parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 [Bug 13545] Add barcode image generator service -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 13:29:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 12:29:21 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 [Bug 20894] Feature request: pass barcode width and height as parameters to /svc/barcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 13:43:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 12:43:30 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at dataly.gr --- Comment #2 from George Veranis --- I confirm that problem exist on version 20.05 and after for all unimarc installations. And the problem should be on template onesubject at UNIMARCslimUtils.xsl on opac , at intranet is working as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 13:58:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 12:58:20 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 14:08:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 13:08:23 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #36 from Owen Leonard --- Warning from the QA tool: FAIL C4/Utils/DataTables/TablesSettings.pm FAIL pod *** WARNING: =head3 without preceding higher level in file C4/Utils/DataTables/TablesSettings.pm *** WARNING: =head3 without preceding higher level in file C4/Utils/DataTables/TablesSettings.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 14:08:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 13:08:31 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 14:08:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 13:08:34 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124309|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 14:09:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 13:09:00 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129020&action=edit Bug 28932: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 14:09:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 13:09:04 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129021&action=edit Bug 28932: Fix duplicate next_action & prev_action This patch fixes the duplicate buttons issue. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Illrequests.t => FAIL: Tests fail 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 14:11:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 13:11:58 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |andrew at bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.08 released in| | --- Comment #11 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 14:12:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 13:12:20 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 14:13:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 13:13:44 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 --- Comment #4 from Tomás Cohen Arazi --- I found this bug when trying an ILL backend recently. My previous attempts all used a completely decoupled graph, so never saw this before. What I was seeing was that buttons were showed randomly. With this patch most of that is gone, I still see only one button show/hide on refresh. Will try to dig a bit more. It is probably a problem with my graph, or another use case not covered by this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 14:14:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 13:14:37 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 --- Comment #5 from Tomás Cohen Arazi --- I splitted the patch in two, so it is easier to spot the problem and how the patch fixes it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 14:16:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 13:16:22 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #37 from Owen Leonard --- This change results in a JS error on the page, 'Uncaught TypeError: can't access property "columns", table_settings is undefined' --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt @@ -328,10 +328,9 @@ Acquisitions › Koha var MSG_NO_FUND_SELECTED = _("No fund selected."); $(document).ready(function() { $('span.hint').hide(); - var columns_settings;// = [% TablesSettings.GetColumns( 'acqui', 'histsearch', 'histsearcht', 'json' ) | $raw %]; KohaTable("table_orders", { "bPaginate": false - }, columns_settings ); + }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 14:29:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 13:29:13 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #38 from Owen Leonard --- (In reply to Owen Leonard from comment #37) > This change results in a JS error on the page, 'Uncaught TypeError: can't > access property "columns", table_settings is undefined' Fixed in a later patch, or a false alarm? I'm going through them in smaller chunks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 15:07:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 14:07:00 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in 0001 option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 --- Comment #13 from Manos PETRIDIS --- In my installation (single active branch/library, not a lending library, less than 9999 new items per month, autoBarcode set to yymm0001) I've used the following SQL statement to fill missing barcodes. Should you decide to use it, please remember to first check it thourougly and change "ABC" with your own branch code. I know it will leave gaps in the barcode sequence, but I don't really mind it. UPDATE items SET barcode = CONCAT ( 'ABC' ,lpad(substring(extract(YEAR FROM datelastseen), 3, 2), 2, 0) ,lpad(extract(month FROM datelastseen), 2, 0) ,lpad(1 + itemnumber - ( SELECT T.INI FROM ( SELECT min(i.itemnumber) AS ini ,extract(YEAR FROM i.datelastseen) AS DTE_YY ,extract(month FROM i.datelastseen) AS DTE_MM FROM items i WHERE i.homebranch = 'ABC' GROUP BY extract(YEAR FROM i.datelastseen) ,extract(month FROM i.datelastseen) ) T WHERE T.dte_yy = extract(YEAR FROM datelastseen) AND T.DTE_MM = extract(MONTH FROM datelastseen) ), 4, 0) ) WHERE items.homebranch = 'ABC' AND barcode IS NULL; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 15:28:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 14:28:07 +0000 Subject: [Koha-bugs] [Bug 27013] Display an image of barcode on slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27013 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 [Bug 13545] Add barcode image generator service -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 15:28:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 14:28:07 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27013 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27013 [Bug 27013] Display an image of barcode on slips -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 15:38:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 14:38:05 +0000 Subject: [Koha-bugs] [Bug 29798] New: [DOCS] Improve explanation of Allow auto-renewal button in Patron edit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29798 Bug ID: 29798 Summary: [DOCS] Improve explanation of Allow auto-renewal button in Patron edit Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: aude.charillon at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The description in the manual is currently confusing: it does not specify that this applies only if automatic renewal is set up in the circulation rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 15:39:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 14:39:30 +0000 Subject: [Koha-bugs] [Bug 29798] [DOCS] Improve explanation of Allow auto-renewal button in Patron edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29798 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |aude.charillon at ptfs-europe. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 15:46:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 14:46:23 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128967|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes --- Created attachment 129027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129027&action=edit Bug 29526: Add a way for patrons to delete their hold history The same way we have a button to immediately delete the checkouts history in the OPAC, we should have a similar option for the holds history. This patch implements that. To test: 1. Have a patron with some old checkouts and old holds. 2. Have OPACPrivacy, OPACHoldsHistory and opacreadinghistory enabled. 3. Notice in the OPAC the patron has some old checkouts and holds. 4. Use the Privacy tab to clean checkouts => SUCCESS: They are still cleaned as before this patch 5. Try to clean the old holds => SUCCESS: They are cleaned! 6. Add some old checkouts and holds 7. Use the new 'All' button => SUCCESS: All cleaned 8. Sign off :-D Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 15:46:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 14:46:27 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128974|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes --- Created attachment 129028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129028&action=edit Bug 29526: (follow-up) Put delete buttons in HTML table Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 15:46:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 14:46:31 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128982|0 |1 is obsolete| | --- Comment #11 from PTFS Europe Sandboxes --- Created attachment 129029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129029&action=edit Bug 29526: (follow-up) change wording on opac-holdshistory.tt when table is empty Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 15:48:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 14:48:38 +0000 Subject: [Koha-bugs] [Bug 29799] New: Z39.50 additional fields for authorities in search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29799 Bug ID: 29799 Summary: Z39.50 additional fields for authorities in search results Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: viliam.polonec at snk.sk QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Add preference with additional fields for authorities search results via Z39.50 like bibliographic records. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 15:49:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 14:49:36 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Barbara Johnson --- Everything worked, the wording has improved and the layout looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 16:30:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 15:30:27 +0000 Subject: [Koha-bugs] [Bug 29796] Cannot create new patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29796 --- Comment #4 from Jeremiah --- I was originally running 21.05, currently, I am running 21.11.01.000. During the update, I was not seeing any errors. Also, I was experiencing this right before I updated to the new version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 16:36:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 15:36:02 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 --- Comment #3 from Rafael Antonio --- I have tried to compare UNIMARCslimUtils release 20 and release 18 but it seems there is no difference on template onesubject. Testing intranet UNIMARCslimUtils on OPAC it does not work. So the only way is to try to find the bug or reson for such. As you can see this is the result on OPAC Country: Portugal. Publication: Lisboa : Gabinete da Inspecção-Geral do Trabalho, 1992 Subject - Topical Name: 9504 | 11070 | 9501 | 9200 | 11252 | 11305 | 8439 | 6383 | 8128 And similar display for Intranet Country: Portugal. Publication: Lisboa : Gabinete da Inspecção-Geral do Trabalho, 1992 Subject - Topical Name: Inspecção-Geral do Trabalho | Relatório | Inspecção do trabalho | Higiene do trabalho | Saúde no trabalho | Segurança no trabalho | Doença profissional | Acidente de trabalho | Dados estatisticos Who can help? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 16:46:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 15:46:26 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 16:46:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 15:46:29 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 --- Comment #4 from Jonathan Druart --- Created attachment 129038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129038&action=edit Bug 29778: Remove DBMS error ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table 'additional_contents' is specified twice, both as a target for 'DELETE' and as a separate source for data at /kohadevbox/koha/C4/Installer.pm line 738 Happened on MariaDB 10.1 and 10.3, not 10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 16:55:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 15:55:58 +0000 Subject: [Koha-bugs] [Bug 29796] Cannot create new patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29796 --- Comment #5 from Katrin Fischer --- Did you make any local changes, including *UserJs? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 16:59:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 15:59:20 +0000 Subject: [Koha-bugs] [Bug 29796] Cannot create new patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29796 --- Comment #6 from Jonathan Druart --- You should see more info in the log files, can you post the full stacktrace? Also, do you see the problem with other patron's category? Did you try to create a new category and a patron using it? Does it work if you edit an existing patron? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 17:33:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 16:33:41 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in 0001 option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 --- Comment #14 from Manos PETRIDIS --- ...oops, thoroughly! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 17:37:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 16:37:44 +0000 Subject: [Koha-bugs] [Bug 29800] New: Add option to calculate fines when an item is marked lost Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29800 Bug ID: 29800 Summary: Add option to calculate fines when an item is marked lost Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We have the system preferences CalculateFinesOnReturn and CalculateFinesOnBackdate to make Koha calculate overdue fines as an item is returned, either in place of or in addition to the fines cron. However, if one marks an item as lost and has MarkLostItemAsReturned enabled, the issue will be ended without an overdue fine being calculated. We should add the option to calculate an overdue fine at the moment of marking an item lost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 18:33:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 17:33:08 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com Keywords|Manual |Manual-updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 18:38:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 17:38:51 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Catherine E. Ingram changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catherine.ingram at cedarparkt | |exas.gov --- Comment #12 from Catherine E. Ingram --- This is a bug that is costing my staff time every day. If we receive an order of 30 books and have to go into Acquisitions and click "received" on each title - it is much easy to find the titles when they are in alphabetical order. Otherwise it is a hunt and seek when the titles are listed in random order. So it might take anywhere from a few extra minutes for a small order to an extra 10 minutes for a larger order. Thank you, Catherine Ingram -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 18:39:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 17:39:24 +0000 Subject: [Koha-bugs] [Bug 29570] unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Catherine E. Ingram changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catherine.ingram at cedarparkt | |exas.gov --- Comment #4 from Catherine E. Ingram --- This is a bug that is costing my staff time every day. If we receive an order of 30 books and have to go into Acquisitions and click "received" on each title - it is much easy to find the titles when they are in alphabetical order. Otherwise it is a hunt and seek when the titles are listed in random order. So it might take anywhere from a few extra minutes for a small order to an extra 10 minutes for a larger order. Thank you, Catherine Ingram -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 18:40:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 17:40:08 +0000 Subject: [Koha-bugs] [Bug 29180] System preference RequestOnOpac should be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29180 --- Comment #12 from Aude Charillon --- Changes for this bug are now incorporated in the manual. Here are the changes made: renamed system preference RequestOnOpac to OPACHoldRequests in OPAC preferences, OPAC and Implementation checklist (see https://gitlab.com/koha-community/koha-manual/-/commit/f669393bf840c9e0b0a4cf54e38bff4fb289c8d5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 19:19:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 18:19:05 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 19:19:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 18:19:08 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128957|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 129040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129040&action=edit Bug 29778: Prevent orphan additional contents When deleting a content, only the main one (lang="default") is removed, which leads to orphan contents in the DB that are still displayed on the UI. Test plan: 0. Don't apply this patch 1. Create some contents, translate them in different languages 2. Delete some of them => Note that they are still displayed on the UI and that the entries with lang!="default" are still in the DB 3. Apply this patch 4. Repeat 1 5. Run updatedatabase 6. Delete from of the contents => Note that the orphan entries created before you applied the patch have been removed and that the "delete" behaviour is now working correnctly. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 19:19:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 18:19:11 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129038|0 |1 is obsolete| | --- Comment #6 from Lucas Gass --- Created attachment 129041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129041&action=edit Bug 29778: Remove DBMS error ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table 'additional_contents' is specified twice, both as a target for 'DELETE' and as a separate source for data at /kohadevbox/koha/C4/Installer.pm line 738 Happened on MariaDB 10.1 and 10.3, not 10.6 Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 19:27:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 18:27:41 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 19:28:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 18:28:43 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 19:29:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 18:29:05 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #39 from Owen Leonard --- More notes: - On the bibliographic detail page, the default sort column doesn't work correctly. Why are there so many columns to configure when they don't exist in the table? - On the overdues page the default sort order and default display length aren't applied. - Holds to pull: Column configuration doesn't seem to work. - Holds history: 'Uncaught TypeError: can't access property "filter", table_settings.columns is undefined' - Notice template: Column configuration doesn't work. Columns selected to be hidden are not hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 19:30:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 18:30:06 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 19:43:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 18:43:57 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #13 from Barbara Johnson --- +1 It has negatively impacted our workflow as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 19:45:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 18:45:30 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 19:45:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 18:45:33 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128680|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 129042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129042&action=edit Bug 29704: Add a triggered option to holds_reminder.pl This patch adds an option to only trigger notices matching the number of days waiting specified You will need to define HOLD_REMINDER notices for the specific branch of the patron and ensure the patron has hold reminder notices in their messaging preferences TO test: 1 - Place a hold for a patron and check in to confirm 2 - Set the waiting date back a few days: update reserves set waitingdate = DATE_SUB(CURDATE(), INTERVAL 5 DAY); 3 - Run the cron and see that patron would be notified if running for 4 days weaiting perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 4 - Apply patch 5 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 --triggered 6 - Note patron would not be notified 7 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 5 --triggered 8 - Note patron is notified when days waiting matches exactly Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 20:06:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 19:06:15 +0000 Subject: [Koha-bugs] [Bug 29801] New: Holds reminder cron not finding notice for all libraries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29801 Bug ID: 29801 Summary: Holds reminder cron not finding notice for all libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: nick at bywatersolutions.com Depends on: 28153 When running the holds reminder cron, it will give a "no letter found" error if the only HOLDS_REMINDER email is for all libraries rather than a specific library. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 [Bug 28153] Add 'Hold reminder' messaging preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 20:06:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 19:06:15 +0000 Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29801 [Bug 29801] Holds reminder cron not finding notice for all libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 20:11:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 19:11:49 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass --- confirmed that this issue still exists in master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 20:20:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 19:20:51 +0000 Subject: [Koha-bugs] [Bug 29796] Cannot create new patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29796 --- Comment #7 from Jeremiah --- I did not make any changes to the internal files. Sure I will post more: [2022/01/05 07:16:49] [WARN] Patron creation failed! - {UNKNOWN}: DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at /usr/share/koha/lib/Koha/Patron.pm line 354 [2022/01/05 07:17:11] [WARN] Subroutine CORE::GLOBAL::time redefined at /usr/share/perl5/Test/MockTime.pm line 20, line 755. [2022/01/05 07:17:11] [WARN] Prototype mismatch: sub CORE::GLOBAL::time () vs none at /usr/share/perl5/Test/MockTime.pm line 20, line 755. [2022/01/05 07:17:11] [WARN] Subroutine CORE::GLOBAL::localtime redefined at /usr/share/perl5/Test/MockTime.pm line 21, line 755. [2022/01/05 07:17:11] [WARN] Prototype mismatch: sub CORE::GLOBAL::localtime (;$) vs none at /usr/share/perl5/Test/MockTime.pm line 21, line 755. [2022/01/05 07:17:11] [WARN] Subroutine CORE::GLOBAL::gmtime redefined at /usr/share/perl5/Test/MockTime.pm line 22, line 755. [2022/01/05 07:17:11] [WARN] Prototype mismatch: sub CORE::GLOBAL::gmtime (;$) vs none at /usr/share/perl5/Test/MockTime.pm line 22, line 755. [2022/01/05 07:31:19] [WARN] Patron creation failed! - {UNKNOWN}: DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at /usr/share/koha/lib/Koha/Patron.pm line 354 [2022/01/04 14:10:09] [WARN] Patron creation failed! - {UNKNOWN}: DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at /usr/share/koha/lib/Koha/Patron.pm line 346 [2022/01/04 14:10:09] [WARN] Use of uninitialized value $newdata{"emailpro"} in pattern match (m//) at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl line 479. [2022/01/04 14:10:09] [WARN] Use of uninitialized value $newdata{"B_email"} in pattern match (m//) at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl line 482. [2022/01/04 14:11:02] [WARN] Patron creation failed! - {UNKNOWN}: DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at /usr/share/koha/lib/Koha/Patron.pm line 346 [2022/01/04 14:11:02] [WARN] Use of uninitialized value $newdata{"emailpro"} in pattern match (m//) at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl line 479. [2022/01/04 14:11:02] [WARN] Use of uninitialized value $newdata{"B_email"} in pattern match (m//) at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl line 482. [2022/01/04 14:12:22] [WARN] Patron creation failed! - {UNKNOWN}: DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at /usr/share/koha/lib/Koha/Patron.pm line 346 [2022/01/04 14:12:22] [WARN] Use of uninitialized value $newdata{"emailpro"} in pattern match (m//) at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl line 479. [2022/01/04 14:12:22] [WARN] Use of uninitialized value $newdata{"B_email"} in pattern match (m//) at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl line 482. [2022/01/04 15:23:29] [WARN] Patron creation failed! - {UNKNOWN}: DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at /usr/share/koha/lib/Koha/Patron.pm line 346 [2022/01/04 15:23:29] [WARN] Use of uninitialized value $newdata{"emailpro"} in pattern match (m//) at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl line 479. [2022/01/04 15:23:29] [WARN] Use of uninitialized value $newdata{"B_email"} in pattern match (m//) at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl line 482. [2022/01/04 15:26:19] [WARN] Patron creation failed! - {UNKNOWN}: DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at /usr/share/koha/lib/Koha/Patron.pm line 346 [2022/01/04 15:26:22] [WARN] error at after DATA: 5.2.252 SendAsDenied; xxxxxx at xxxx.org not allowed to send as root at localhost; STOREDRV.Submission.Exception:SendAsDeniedException.MapiExceptionSendAsDenied; Failed to process message due to a permanent exception with message Cannot submit message. 0.35250:97610000, 1.36674:0A000000, 1.61250:00000000, 1.45378:02000000, 1.44866:7C1C0000, 1.36674:0E000000, 1.61250:00000000, 1.45378:811C0000, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 20:26:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 19:26:42 +0000 Subject: [Koha-bugs] [Bug 20988] [OMNIBUS] Internationalization: wrap all translatable text inside t() calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 --- Comment #63 from Victor Grousset/tuxayo --- Did you mean Joubu that in order to check, the wrapping script (https://github.com/jajm/koha-i18n) should be used on the syspref template. And then a global counter can be added in the t sub in Koha/Template/Plugin/I18N.pm ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 20:26:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 19:26:43 +0000 Subject: [Koha-bugs] [Bug 29802] New: biblionumber in OPACHiddenItems breaks opac lists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802 Bug ID: 29802 Summary: biblionumber in OPACHiddenItems breaks opac lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When biblionumber is in the opachiddenitems preference the query to find hidden items dies: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'biblionumber' in where clause is ambiguous [for Statement "SELECT `me`.`itemnumber`, `me`.`biblionumber`, `me`.`biblioitemnumber`, `me`.`barcode`, `me`.`dateaccessioned`, `me`.`booksellerid`, `me`.`homebranch`, `me`.`price`, `me`.`replacementprice`, `me`.`replacementpricedate`, `me`.`datelastborrowed`, `me`.`datelastseen`, `me`.`stack`, `me`.`notforloan`, `me`.`damaged`, `me`.`damaged_on`, `me`.`itemlost`, `me`.`itemlost_on`, `me`.`withdrawn`, `me`.`withdrawn_on`, `me`.`itemcallnumber`, `me`.`coded_location_qualifier`, `me`.`issues`, `me`.`renewals`, `me`.`reserves`, `me`.`restricted`, `me`.`itemnotes`, `me`.`itemnotes_nonpublic`, `me`.`holdingbranch`, `me`.`timestamp`, `me`.`location`, `me`.`permanent_location`, `me`.`onloan`, `me`.`cn_source`, `me`.`cn_sort`, `me`.`ccode`, `me`.`materials`, `me`.`uri`, `me`.`itype`, `me`.`more_subfields_xml`, `me`.`enumchron`, `me`.`copynumber`, `me`.`stocknumber`, `me`.`new_status`, `me`.`exclude_from_local_holds_priority`, `branchtransfers`.`branchtransfer_id`, `branchtransfers`.`itemnumber`, `branchtransfers`.`daterequested`, `branchtransfers`.`datesent`, `branchtransfers`.`frombranch`, `branchtransfers`.`datearrived`, `branchtransfers`.`datecancelled`, `branchtransfers`.`tobranch`, `branchtransfers`.`comments`, `branchtransfers`.`reason`, `branchtransfers`.`cancellation_reason`, `reserves`.`reserve_id`, `reserves`.`borrowernumber`, `reserves`.`reservedate`, `reserves`.`biblionumber`, `reserves`.`branchcode`, `reserves`.`desk_id`, `reserves`.`notificationdate`, `reserves`.`reminderdate`, `reserves`.`cancellationdate`, `reserves`.`cancellation_reason`, `reserves`.`reservenotes`, `reserves`.`priority`, `reserves`.`found`, `reserves`.`timestamp`, `reserves`.`itemnumber`, `reserves`.`waitingdate`, `reserves`.`expirationdate`, `reserves`.`lowestPriority`, `reserves`.`suspend`, `reserves`.`suspend_until`, `reserves`.`itemtype`, `reserves`.`item_level_hold`, `reserves`.`non_priority` FROM `items` `me` LEFT JOIN `branchtransfers` `branchtransfers` ON `branchtransfers`.`itemnumber` = `me`.`itemnumber` LEFT JOIN `reserves` `reserves` ON `reserves`.`itemnumber` = `me`.`itemnumber` WHERE ( ( ( `biblionumber` NOT IN ( ?, ?, ?, ?, ?, ? ) OR `biblionumber` IS NULL ) AND `itemlost` = ? AND ( `itype` NOT IN ( ?, ? ) OR `itype` IS NULL ) AND ( `location` NOT IN ( ?, ? ) OR `location` IS NULL ) AND `me`.`biblionumber` = ? AND 1=1 ) ) ORDER BY `me`.`itemnumber`" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 20:31:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 19:31:57 +0000 Subject: [Koha-bugs] [Bug 29801] Holds reminder cron not finding notice for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29801 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28153 |15986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 [Bug 15986] Add a script for sending hold waiting reminder notices https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 [Bug 28153] Add 'Hold reminder' messaging preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 20:31:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 19:31:57 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29801 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29801 [Bug 29801] Holds reminder cron not finding notice for all libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 20:31:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 19:31:57 +0000 Subject: [Koha-bugs] [Bug 28153] Add 'Hold reminder' messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29801 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29801 [Bug 29801] Holds reminder cron not finding notice for all libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 20:33:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 19:33:41 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #43 from Victor Grousset/tuxayo --- It would add some clutter in the templates. Would adding a class to the that tells it's semantic be worth it? In case it's not, no big deal the patch can be tested as it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 21:01:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 20:01:31 +0000 Subject: [Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 --- Comment #3 from Alex Buckley --- Back from leave and working on this bug now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 22:01:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 21:01:53 +0000 Subject: [Koha-bugs] [Bug 29803] New: Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Bug ID: 29803 Summary: Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios Change sponsored?: --- Product: Koha Version: 21.11 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: martinbmorris at gmail.com QA Contact: testopia at bugs.koha-community.org After upgrading to 21.11 from 21.05, locally cover images stopped loading on the details page for an individual biblio. They still load in a listing of multiple biblios. Additionally, images from the locally running Coce server load without problems. Example of multiple listing where covers show as normal: https://katalogo.biblioteko.ca/cgi-bin/koha/opac-search.pl?q=au:%22Doyle%2C%20Arthur%20Conan%22 Example of individual biblio where locally stored cover doesn't load: https://katalogo.biblioteko.ca/cgi-bin/koha/opac-detail.pl?biblionumber=2189&query_desc=au%3A%22Doyle%2C%20Arthur%20Conan%22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 23:29:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 22:29:51 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 23:29:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 22:29:54 +0000 Subject: [Koha-bugs] [Bug 29767] Add options to runtime parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29767 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128889|0 |1 is obsolete| | --- Comment #7 from Lucas Gass --- Created attachment 129043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129043&action=edit Bug 29767: SQL Koha reports and variable of database table << name|table_name>> 'Insert runtime parameter' has now more options for the SQL reports : 'cash register', 'debit types' and 'credit types' Test plan: 1)Home > Reports > Create from SQL 2)Click on 'Insert runtime parameter' and notice the current options 3)Apply patch and repeat 2) 4)New parameters are now available 5)A simple SQL request to try 'credit_types' option : SELECT * FROM account_credit_types WHERE code = <> Signed-off-by: Lucas Gass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 23:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 22:37:26 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 5 23:37:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 22:37:29 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128630|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 129044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129044&action=edit Bug 29717: Remove unecessary DT manipulations from tools/additional-contents.pl DBIC handles DateTime correctly, no need for this output_pref call. Test plan: Create a new content, set the dates, confirm they are set correctly Modify the content, modify the dates, confirm they are stored correctly Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:16:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:16:11 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 --- Comment #22 from Fridolin Somers --- (In reply to Katrin Fischer from comment #21) > (In reply to Fridolin Somers from comment #20) > > (In reply to Fridolin Somers from comment #19) > > > Ah atomic update script needs to be updated to match new DBRev system. > > So far it was not mandatory, maybe we should add to coding > guidelines/communicate - we have a lot of old database updates out there. :) Ah I see its is described in : https://wiki.koha-community.org/wiki/Database_updates I understand it is mandatory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:08 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:10 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 --- Comment #15 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:12 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:15 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 --- Comment #12 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:17 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:20 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #16 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:22 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:25 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 --- Comment #18 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:29 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:32 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:34 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:35:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:35:36 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:48:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:48:48 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:48:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:48:52 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128577|0 |1 is obsolete| | --- Comment #2 from Samu Heiskanen --- Created attachment 129045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129045&action=edit Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t and prove t/db_dependent/Koha/CirculationRules/* Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:51:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:51:15 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:51:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:51:17 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:51:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:51:50 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:51:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:51:56 +0000 Subject: [Koha-bugs] [Bug 29503] GET /patrons should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29503 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Group|Koha security | Component|Koha |REST API Product|Koha security |Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 00:53:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jan 2022 23:53:27 +0000 Subject: [Koha-bugs] [Bug 29503] GET /patrons should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29503 --- Comment #10 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #7) > I'm lowering the severity because, as bug 29509 highlights, we actually > require all _borrowers_ permissions to use the route (iincluding > view_borrower_infos_from_any_libraries). > > But those permissions are too high for using the routes on the API, and this > bug (and bug 29506) will prevent leakages when time comes. I wrote this and forgot to change the 'Product'. Sorry for that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 01:03:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 00:03:02 +0000 Subject: [Koha-bugs] [Bug 29503] GET /patrons should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29503 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 01:03:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 00:03:05 +0000 Subject: [Koha-bugs] [Bug 29503] GET /patrons should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29503 --- Comment #11 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 01:03:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 00:03:07 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 01:03:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 00:03:10 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 --- Comment #12 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 01:03:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 00:03:12 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 01:03:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 00:03:14 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 01:07:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 00:07:59 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 01:08:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 00:08:06 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 01:47:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 00:47:01 +0000 Subject: [Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 --- Comment #4 from Alex Buckley --- Created attachment 129046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129046&action=edit Bug 29761: Batch patron modification page should display patrons once if the same ID is inputted multiple times If a cardnumber, SMS number, or borrower number is inputted multiple times then the batch patron modification page should not display that patron multiple times. Test plan: 1. Create three text files that list card numbers, SMS numbers, and borrower numbers for three patrons. Example lists are below, notice in each there is one number duplicated: Card numbers: 23529000035676 23529000651225 23529000080862 23529000035676 Borrower numbers: 19 49 7 49 SMS numbers: 2125551212 2125551212 2125551213 2125551214 2. Enable sending of SMS messages: * Set SMSSendDriver system preference to Email 3. Make sure the cardnumbers, borrower numbers, and SMS numbers listed above belong to patrons in your Koha 4. Go to Tools > Batch patron modification 5. Upload lists of cardnumbers, SMS numbers, and borrower numbers above, and confirm the following is happening in the batch patron modification page: - Upload the text file of cardnumbers. Notice one patron is displayed twice - Paste in the list of cardnumbers. Notice one patron is displayed twice - Upload the text file of SMS numbers. Notice one patron is displayed twice - Paste in the list of SMS numbers. Notice one patron is displayed twice - Upload the text file of borrower numbers. Notice one patron is displayed twice - Paste in the list of borrower numbers. Notice one patron is displayed twice 6. Apply patch and restart services 7. Repeat step 5 and this time observe that the patron record is not duplicated in the batch patron modification page Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 01:49:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 00:49:00 +0000 Subject: [Koha-bugs] [Bug 29761] Patron batch modification tool - duplicated information on the listing page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |23291 --- Comment #5 from Alex Buckley --- Ready for testing! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 [Bug 23291] Patron batch modification based on SMS number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 01:49:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 00:49:00 +0000 Subject: [Koha-bugs] [Bug 23291] Patron batch modification based on SMS number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23291 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29761 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29761 [Bug 29761] Patron batch modification tool - duplicated information on the listing page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 02:22:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 01:22:33 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Text to go in the| |Adds the patron category to release notes| |the holds queue on | |view_holdsqueue.tt Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 02:22:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 01:22:57 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 02:23:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 01:23:01 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 --- Comment #2 from Lucas Gass --- Created attachment 129047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129047&action=edit Bug 29760: Show patron category on view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category 3. Apply patch 4. Look again, you can now see the patron category in the patron column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 02:23:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 01:23:16 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 07:05:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 06:05:21 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |23463 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 07:05:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 06:05:21 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 [Bug 29794] delete_items.pl missing include -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 07:06:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 06:06:37 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 --- Comment #7 from Fridolin Somers --- Bug 23463 replaced DelItemCheck() with Koha::Items->find() and $item->safe_delete It should have impact the includes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 07:08:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 06:08:48 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 07:12:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 06:12:39 +0000 Subject: [Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin Somers --- Maybe we need a new component for Koha as a Mojolicious app. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 08:55:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 07:55:00 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 10:12:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 09:12:09 +0000 Subject: [Koha-bugs] [Bug 24074] Access directory UX improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24074 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- I was thinking maybe we could add a name to the config, something like: /etc/koha/sites/koha/print/ /etc/koha/sites/koha/logs/ Then in the tool we could show the names as an accordion list or as tabs, and when you click on a name you see only the files belonging to that name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:06:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:06:47 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |fridolin.somers at biblibre.co | |m --- Comment #21 from Tomás Cohen Arazi --- Found in production: [2021/12/09 10:20:29] [ERROR] PUT /api/v1/holds/499056/pickup_location: unhandled exception (Koha::Exceptions::Object::MethodNotCoveredByTests)<branchcode is not covered by tests! Please, allow this patches in, until we decide about wantarray. It is weird not to fix an obvious bug because there's a long term refactoring being discussed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:09:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:09:34 +0000 Subject: [Koha-bugs] [Bug 29804] New: Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Bug ID: 29804 Summary: Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Due to bug 28871, there's a problem in production when checking if a pickup location is valid using Koha::Hold->is_pickup_location_valid. I file this bug because the other one is blocked and is not clear what path it will take, but this is affecting users. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:09:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:09:47 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28871 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:09:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:09:47 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29804 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:19:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:19:07 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:19:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:19:11 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129048&action=edit Bug 29804: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:19:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:19:14 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129049&action=edit Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding This trivial patch acknowledges the fact bug 28871 is probably not going to be pushed, and changes the method so it, internally, uses Koha::Item->pickup_locations and Koha::Biblio->pickup_locations in scalar context. This is probably the correct solution as the discussion on bug 28883 points towards the future removal of the use of wantarray altogether, eventually. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: It explodes as we see in production, with: The method Koha::Libraries->branchcode is not covered by tests! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:19:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:19:24 +0000 Subject: [Koha-bugs] [Bug 29805] New: Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Bug ID: 29805 Summary: Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It looks like this important database update is failing for MySql 5.7 because it lacks support of REGEXP_REPLACE. Upgrade to 21.05.00.016 [14:16:28]: Bug 24387 - Rename opac_news with additional_contents ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: FUNCTION koha.biblioteca.REGEXP_REPLACE does not exist at /usr/share/koha/lib/C4/Installer.pm line 738 Are we still supporting 5.7? If not, should we highlight that somewhere? We currently only list MariaDB versions on the wiki linked from release notes: https://wiki.koha-community.org/wiki/System_requirements_and_recommendations We are still listing MySQL here: https://koha-community.org/download-koha/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:20:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:20:27 +0000 Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:26:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:26:38 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |lucas at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:27:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:27:37 +0000 Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 --- Comment #1 from Katrin Fischer --- 5.7 is in Ubuntu Bionic/18.04: https://packages.ubuntu.com/search?keywords=mysql&searchon=names&suite=all§ion=all -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:38:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:38:57 +0000 Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:45:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:45:35 +0000 Subject: [Koha-bugs] [Bug 29806] New: ->pickup_locations should always be called in scalar context Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Bug ID: 29806 Summary: ->pickup_locations should always be called in scalar context Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The Koha::{Biblio|Item}->pickup_locations methods internally use Koha::Libraries->empty, which doesn't honour list context (bug 28871). When called in list context, if the Koha::Libraries resultset was built using ->empty, then things will explode, as exposed by bug 29804. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:45:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:45:56 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28871 Depends on| |29804 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:45:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:45:56 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 [Bug 29806] ->pickup_locations should always be called in scalar context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:45:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:45:56 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29806 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:54:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:54:42 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #1 from Tomás Cohen Arazi --- I did a: $ git grep '\->pickup_locations' and my (manual) findings are: Koha/Biblio.pm: ok Koha/Biblios.pm: ok Koha/Item.pm: ok Koha/REST/V1/Biblios.pm: ok Koha/REST/V1/Holds.pm: boo Koha/Template/Plugin/Branches.pm: boo reserve/request.pl: boo t/db_dependent/Koha/Biblio.t: ok t/db_dependent/Koha/Biblios.t: ok t/db_dependent/Koha/Hold.t: ok t/db_dependent/Koha/Item.t: ok t/db_dependent/Template/Plugin/Branches.t: ok t/db_dependent/api/v1/holds.t: ok Working on fixes... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:54:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:54:44 +0000 Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 [Bug 29778] Deleting additional_contents leaves entries for additional languages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:54:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:54:44 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:55:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:55:11 +0000 Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:55:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:55:11 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:58:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:58:49 +0000 Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 11:58:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 10:58:53 +0000 Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 --- Comment #2 from Jonathan Druart --- Created attachment 129050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129050&action=edit Bug 29805: Fix 21.05.00.016 for MySQL 5.7 MySQL 5.7 is in Ubuntu 18.04 and does not support REGEXP_REPLACE. We can easily rewrite it in Perl instead of dropping support on this Ubuntu LTS version. Test plan: checkout a commit prior to 21.05.00.016 Create a notice template with <> [%opac_news.content %] << opac_news.content>> [% opac_news.content %] Note that ISSUESLIP has already occurrence of 'opac_news.' git checkout a branch with master + this patch Run `updatedatabase` and notice that the 'opac_news.' occurrences have been replaced with 'additional_contents.' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:05:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:05:05 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28955 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:05:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:05:05 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29691 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:06:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:06:32 +0000 Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:32:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:32:58 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #21) > Found in production: > > [2021/12/09 10:20:29] [ERROR] PUT /api/v1/holds/499056/pickup_location: > unhandled exception (Koha::Exceptions::Object::MethodNotCoveredByTests)< method Ko > ha::Libraries->branchcode is not covered by tests! > > Please, allow this patches in, until we decide about wantarray. It is weird > not to fix an obvious bug because there's a long term refactoring being > discussed... I filed 29804 to avoid delays for the releases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:49:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:49:14 +0000 Subject: [Koha-bugs] [Bug 29807] New: Branches template doesn't handle empty lists correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Bug ID: 29807 Summary: Branches template doesn't handle empty lists correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The current code, given an 'item' or a 'biblio' param, makes 'pickup_locations' set @pickup_locations an empty list. After that, there's a check for emptiness, in which case it populates the @libraries variable with ALL PICKUP LOCATIONS, which is totally wrong! This is a bug introduced by bug 24350. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:49:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:49:27 +0000 Subject: [Koha-bugs] [Bug 27970] Koha::Template::Plugin::Branches->pickup_location is failing due to unexpected behavior of Koha::Libraries->new->empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27970 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 29807 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:49:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:49:27 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson at kreablo.se --- Comment #1 from Tomás Cohen Arazi --- *** Bug 27970 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:49:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:49:44 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:51:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:51:18 +0000 Subject: [Koha-bugs] [Bug 27970] Koha::Template::Plugin::Branches->pickup_location is failing due to unexpected behavior of Koha::Libraries->new->empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27970 --- Comment #2 from Tomás Cohen Arazi --- Thanks for the report, Andreas, I'm sorry I didn't notice it earlier. Working on a fix based on your findings, on bug 29807. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:51:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:51:21 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:51:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:51:24 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127542|0 |1 is obsolete| | Attachment #127543|0 |1 is obsolete| | Attachment #128425|0 |1 is obsolete| | --- Comment #16 from Owen Leonard --- Created attachment 129051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129051&action=edit Bug 27613: Change pipe seperated online resource links to psuedo elements To test: 1. Have a record with many 856 links 2. Look at the links on both the results and detail pages. 3. Look at the '|' and notice it is outside any HTML element, making it hard to remove. 4. Apply the patch and regenerate the CSS 5. Look at both the pages again and notice that the '|' is now a psuedo element. 6. It should look identical to the way it did without the patch 7. Switch the system pref OPACURLOpenInNewWindow to 'do' and make sure the the links look and function right still. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:51:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:51:28 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #17 from Owen Leonard --- Created attachment 129052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129052&action=edit Bug 27613: (follow-up) Modify additional repeating entries for consistency This patch makes further changes to the detail and results XSLT in the OPAC so that previously pipe-separated fields are styled with CSS. The following tags are modified on the detail page: 020 ISBN 022 ISSN 050 LOC classification 060 NLM classification 082 DDC classification 084 Other classification 130/240/730 Uniform titles 246 Other title 336 Content type 337 Media type 338 Carrier type 385 Audience 508 Production credits 583 Action note 586 Awards 655 Genre/Form 700/710/711 Contained works 700/710/711 Related works 770 Supplement 772 Supplement to 856 Online resources These are modified on the results page: 028 Publisher number 246 Other title To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In order to better see the effect of the CSS change you can add something ike this to your OPACUserCSS system preference: .resource_list li::after { content: "♦"; } View catalog search results and detail pages for records which contain repeated entries from the tag list above. The entries should be separated by "|" without customization, or the symbol from your OPACUserCSS if you specified one. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:51:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:51:32 +0000 Subject: [Koha-bugs] [Bug 27613] Pipe separated online resource links are hard to customize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #18 from Owen Leonard --- Created attachment 129053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129053&action=edit Bug 27613: (follow-up) add authors and contributors Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:51:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:51:41 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:51:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:51:44 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129048|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 129054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129054&action=edit Bug 29804: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:51:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:51:49 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129049|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 129055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129055&action=edit Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding This trivial patch acknowledges the fact bug 28871 is probably not going to be pushed, and changes the method so it, internally, uses Koha::Item->pickup_locations and Koha::Biblio->pickup_locations in scalar context. This is probably the correct solution as the discussion on bug 28883 points towards the future removal of the use of wantarray altogether, eventually. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: It explodes as we see in production, with: The method Koha::Libraries->branchcode is not covered by tests! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:56:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:56:03 +0000 Subject: [Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:56:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:56:50 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 [Bug 29806] ->pickup_locations should always be called in scalar context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:56:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:56:50 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 [Bug 29807] Branches template doesn't handle empty lists correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:59:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:59:42 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:59:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:59:45 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129056&action=edit Bug 29807: Regression tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 12:59:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 11:59:49 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129057&action=edit Bug 29807: Make Branches plugin handle empty pickup locations list This patch makes the plugin handle empty Koha::Biblio->pickup_locations and Koha::Item->pickup_locations correctly. It does so by explicitly calling ->as_list. It also restores the logic that was changed by 6cd1ffab4e491349c99769018a7df33dc8a8aabf so, now that ->empty is handled correctly, it doesn't return ALL the pickup locations when the item/biblio doesn't have valid pickup locations. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Template/Plugin/Branches.t => FAIL: Awful error 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:00:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:00:19 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Branches template doesn't |Branches template plugin |handle empty lists |doesn't handle empty lists |correctly |correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:01:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:01:28 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The Branches TT plugin had release notes| |wrong logic in it, that | |made it crash, or display | |wrong pickup locations when | |the item/biblio didn't have | |any valid pickup location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:03:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:03:45 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #2 from Tomás Cohen Arazi --- Koha/Template/Plugin/Branches.pm solved on bug 29807. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:14:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:14:55 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #32 from Tomás Cohen Arazi --- This patch introduces a warning on tests: $ prove t/db_dependent/Template/Plugin/Branches.t Use of uninitialized value $branchcode in concatenation (.) or string at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 35. I'm not sure if it is ok to call GetName with no branchcode param. Maybe it should explode in those cases as it is obviously a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:27:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:27:31 +0000 Subject: [Koha-bugs] [Bug 29808] New: Stock rotation fails to advance when an item is checked out from the branch that is the next stage Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 Bug ID: 29808 Summary: Stock rotation fails to advance when an item is checked out from the branch that is the next stage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When an item is advanced we generate a transfer to the next branch. If the item is already at that branch we receive the transfer If an item is issued, an exception is thrown when receiving a transfer To recreate: 1 - Enable StockRotation system preference 2 - Browse to Tools->Stock rotation->New Rota and create a new rota, set as cyclical 3 - Manage->stages and add two stages, each with 0 day duration 4 - Manage->items - add an item 5 - Checkout the item from the first branch of rotation 6 - Tools->Stock rotation->Manage->items->move to next stage 7 - Error: [Transfer item is currently checked out] at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:31:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:31:08 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |tomascohen at gmail.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:32:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:32:29 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129058&action=edit Bug 29806: Call ->as_list for ->pickup_locations on request.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:32:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:32:33 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 129059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129059&action=edit Bug 29806: Regression tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:32:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:32:37 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 129060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129060&action=edit Bug 29806: Fix POST /holds use of pickup_locations This patch makes Koha::Item->pickup_locations and Koha::Biblio->pickup_locations explicitly call ->as_list in list context. This way we workaround bug 28871. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail, the route gives a 500 (unhandled exception) 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass, the route correctly returns a 400 with a message about the pickup location being invalid 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:34:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:34:59 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:43:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:43:28 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:43:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:43:31 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 --- Comment #1 from Nick Clemens --- Created attachment 129061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129061&action=edit Bug 29808: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:43:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:43:34 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 --- Comment #2 from Nick Clemens --- Created attachment 129062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129062&action=edit Bug 29808: Do not receive transfer for checked out items This patch adds a check to StockRotationItem->advance to check if an item is checked out from the destination branch. If so, we do not receive the transfer To test: 1 - Enable StockRotation system preference 2 - Browse to Tools->Stock rotation->New Rota and create a new rota, set as cyclical 3 - Manage->stages and add two stages, each with 0 day duration 4 - Manage->items - add an item 5 - Checkout the item from the first branch of rotation 6 - Tools->Stock rotation->Manage->items->move to next stage 7 - Error: [Transfer item is currently checked out] at /usr/share/perl5/Exception/Class/Base.pm line 88 8 - Check in the item at first branch 9 - Checkout the item from the second stage branch 10 - Apply patch 11 - Tools->Stock rotation->Manage->items->move to next stage 12 - No error! 13 - Check in item at second branch 14 - Checkout from first branch 15 - Tools->Stock rotation->Manage->items->move to next stage 16 - Still no error! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:43:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:43:42 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart+koha at gmail. | |com Text to go in the| |This development makes our release notes| |error responses include an | |`error_code` that will be | |documented on each route, | |allowing better API usage | |on error conditions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:43:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:43:53 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:45:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:45:22 +0000 Subject: [Koha-bugs] [Bug 29809] New: StockRotationItems->itemnumber is poorly named Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 Bug ID: 29809 Summary: StockRotationItems->itemnumber is poorly named Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This subroutine returns a Koha::Item object - not an itemnumber Leads to fun lines of code like: $sr_item->itemnumber->itemnumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:51:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:51:43 +0000 Subject: [Koha-bugs] [Bug 29810] New: Add embed options documentation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Bug ID: 29810 Summary: Add embed options documentation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com The current spec document does not detail how x-koha-embed headers can be used to include related data in queries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 13:53:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 12:53:01 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The release notes| |Koha::Biblio->pickup_locati | |ons and | |Koha::Item->pickup_location | |methods don't always honour | |list context. Because of | |this, when used, they | |should assume scalar | |context. If list context | |was required, the developer | |needs to explicitly chain a | |->as_list call. | | | |This patch | |tracks the uses of this | |methods and adjusts | |accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:00:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:00:27 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This development introduces release notes| |a new library, | |Koha::Result::Boolean, that | |will be used in method that | |need to return a boolean, | |but could also want to | |carry some more information | |such as the reason for a | |'false' return value. | | | |A | |Koha::Result::Boolean | |object will be evaluated as | |a boolean in bool context, | |while retaining its object | |nature and methods. | | | |For | |example, suppose a $patron | |object should not be | |deleted because the patron | |it represents has a | |guarantee: | | | |``` | | if ( | |$patron->safe_to_delete ) { | | ... } | |``` | | | |will eval to | |false, and the code will do | |what we expect. | | | |If our | |code really wanted to know | |*why* it cannot be | |deleted, we can do: | | | |``` | | | | my $result = | |$patron->safe_to_delete; | | | | unless ( $result ) { | | | | Koha::Exceptions->throw( | |"Cannot delete, errors: " . | |join( ', ', map | |{$_->message} | |@{$result->messages} ) ); | | | | } | |``` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:08:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:08:39 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #1 from Owen Leonard --- The image is loading but it is hidden. I notice you have some CSS loading twice in your OPAC: Do you have a custom stylesheet defined somewhere? In the OpacAdditionalStylesheet system preference perhaps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:12:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:12:46 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #1 from Martin Renvoize --- Created attachment 129063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129063&action=edit Bug 29810: Add summary of x-koha-embed header to api spec -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:12:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:12:49 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #2 from Martin Renvoize --- Created attachment 129064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129064&action=edit Bug 29810: Document x-koha-embed header on patrons endpoints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:24:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:24:22 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:24:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:24:26 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129056|0 |1 is obsolete| | Attachment #129057|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 129065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129065&action=edit Bug 29807: Regression tests Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:24:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:24:29 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 --- Comment #5 from Owen Leonard --- Created attachment 129066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129066&action=edit Bug 29807: Make Branches plugin handle empty pickup locations list This patch makes the plugin handle empty Koha::Biblio->pickup_locations and Koha::Item->pickup_locations correctly. It does so by explicitly calling ->as_list. It also restores the logic that was changed by 6cd1ffab4e491349c99769018a7df33dc8a8aabf so, now that ->empty is handled correctly, it doesn't return ALL the pickup locations when the item/biblio doesn't have valid pickup locations. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Template/Plugin/Branches.t => FAIL: Awful error 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:27:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:27:49 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129063|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 129067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129067&action=edit Bug 29810: Add summary of x-koha-embed header to api spec -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:27:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:27:52 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129064|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 129068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129068&action=edit Bug 29810: Document x-koha-embed header on patrons endpoints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:27:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:27:57 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #5 from Martin Renvoize --- Created attachment 129069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129069&action=edit Bug 29810: Document x-koha-embed header on checkouts endpoints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:28:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:28:01 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #6 from Martin Renvoize --- Created attachment 129070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129070&action=edit Bug 29810: Document x-koha-embed header on biblios endpoints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:28:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:28:04 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #7 from Martin Renvoize --- Created attachment 129071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129071&action=edit Bug 29810: Document x-koha-embed header on cash registers endpoints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:28:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:28:08 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #8 from Martin Renvoize --- Created attachment 129072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129072&action=edit Bug 29810: Document x-koha-embed header on libraries endpoints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:28:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:28:11 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 --- Comment #9 from Martin Renvoize --- Created attachment 129073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129073&action=edit Bug 29810: Document x-koha-embed header on orders endpoints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:28:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:28:30 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:28:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:28:36 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:28:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:28:37 +0000 Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129050|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 129074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129074&action=edit Bug 29805: Fix 21.05.00.016 for MySQL 5.7 MySQL 5.7 is in Ubuntu 18.04 and does not support REGEXP_REPLACE. We can easily rewrite it in Perl instead of dropping support on this Ubuntu LTS version. Test plan: checkout a commit prior to 21.05.00.016 Create a notice template with <> [%opac_news.content %] << opac_news.content>> [% opac_news.content %] Note that ISSUESLIP has already occurrence of 'opac_news.' git checkout a branch with master + this patch Run `updatedatabase` and notice that the 'opac_news.' occurrences have been replaced with 'additional_contents.' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:30:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:30:23 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129018|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 129075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129075&action=edit Bug 29788: Fix batch delete item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:30:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:30:40 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds release notes| |documentation of the | |different embed options the | |REST API provides. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:32:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:32:18 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129013|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 129076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129076&action=edit Bug 29788: Make Koha::Item->safe_to_delete use Koha::Result::Boolean This patch reuse the (awesome) Koha::Result::Boolean module to retrieve the return of Koha::Item->safe_to_delete. Test plan: Try to delete an item that has previously been checked out and confirm that you are still blocked. Try using the cronjobs, the item and biblio detail pages, as well as the batch delete item tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:32:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:32:22 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129075|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 129077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129077&action=edit Bug 29788: Fix batch delete item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:33:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:33:21 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129054|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 129078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129078&action=edit Bug 29804: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:33:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:33:25 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129055|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 129079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129079&action=edit Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding This trivial patch acknowledges the fact bug 28871 is probably not going to be pushed, and changes the method so it, internally, uses Koha::Item->pickup_locations and Koha::Biblio->pickup_locations in scalar context. This is probably the correct solution as the discussion on bug 28883 points towards the future removal of the use of wantarray altogether, eventually. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => FAIL: It explodes as we see in production, with: The method Koha::Libraries->branchcode is not covered by tests! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:34:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:34:01 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Nice work... no regressions, bug is fixed.. QA script happy.. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:36:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:36:26 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129065|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 129080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129080&action=edit Bug 29807: Regression tests Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:36:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:36:30 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129066|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 129081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129081&action=edit Bug 29807: Make Branches plugin handle empty pickup locations list This patch makes the plugin handle empty Koha::Biblio->pickup_locations and Koha::Item->pickup_locations correctly. It does so by explicitly calling ->as_list. It also restores the logic that was changed by 6cd1ffab4e491349c99769018a7df33dc8a8aabf so, now that ->empty is handled correctly, it doesn't return ALL the pickup locations when the item/biblio doesn't have valid pickup locations. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Template/Plugin/Branches.t => FAIL: Awful error 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:37:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:37:02 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Clear correction of code, covered by tests.. no regressions, tests passing, qa script happy Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:42:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:42:53 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129061|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 129082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129082&action=edit Bug 29808: Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:42:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:42:57 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129062|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 129083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129083&action=edit Bug 29808: Do not receive transfer for checked out items This patch adds a check to StockRotationItem->advance to check if an item is checked out from the destination branch. If so, we do not receive the transfer To test: 1 - Enable StockRotation system preference 2 - Browse to Tools->Stock rotation->New Rota and create a new rota, set as cyclical 3 - Manage->stages and add two stages, each with 0 day duration 4 - Manage->items - add an item 5 - Checkout the item from the first branch of rotation 6 - Tools->Stock rotation->Manage->items->move to next stage 7 - Error: [Transfer item is currently checked out] at /usr/share/perl5/Exception/Class/Base.pm line 88 8 - Check in the item at first branch 9 - Checkout the item from the second stage branch 10 - Apply patch 11 - Tools->Stock rotation->Manage->items->move to next stage 12 - No error! 13 - Check in item at second branch 14 - Checkout from first branch 15 - Tools->Stock rotation->Manage->items->move to next stage 16 - Still no error! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:43:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:43:17 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- Going straight for QA on this one.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:44:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:44:08 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Fix works as expected and I can see exactly how/where I introduced the issue (Thanks for spotting and fixing it Nick!). Covered by new unit tests, tests passing, no regressions found and fixes the bug reported. QA script also happy, Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:46:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:46:28 +0000 Subject: [Koha-bugs] [Bug 29811] New: misc/export_records.pl add possibility to export with timestamp option on authority record type Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29811 Bug ID: 29811 Summary: misc/export_records.pl add possibility to export with timestamp option on authority record type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: thibaud.guillot at biblibre.com QA Contact: testopia at bugs.koha-community.org misc/export_records.pl got many options, include bibs export based on a certain timestamp but it doesn't exist for authority record type. It can be interresting to add this option for authority according to the timestamp field (modification_time) already present in the database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:47:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:47:50 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 --- Comment #23 from Katrin Fischer --- Yes, but we didn't point it out in QA for old patches, only for new ones. I'll add a note to the next QA email. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:54:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:54:26 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 --- Comment #13 from Katrin Fischer --- I am late here, but thx a lot for fixing it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:56:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:56:11 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128617|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 129084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129084&action=edit Bug 29648: Holds history - no sort because of desc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 14:58:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 13:58:51 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|unable to sort |Unable to sort |pending_orders table on |pending_orders table on |parcel.pl by summary column |parcel.pl by summary column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:00:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:00:38 +0000 Subject: [Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 --- Comment #3 from Katrin Fischer --- (In reply to Lucas Gass from comment #2) > Do you think in Case B the link should include the target="_blank" attribute > so it opens in a new window? Might be something people argue about. I really like the idea of it opening in a separate tab as this has less surprise and you are leaving the current site. Others might argue that they want the catalog and the website to be perceived as the same website? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:00:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:00:41 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128624|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart --- Created attachment 129085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129085&action=edit Bug 29648: Notice template - only sort -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:01:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:01:00 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #42 from Jonathan Druart --- (In reply to Owen Leonard from comment #39) > More notes: > > - On the bibliographic detail page, the default sort column doesn't work > correctly. Why are there so many columns to configure when they don't exist > in the table? It seems to work for me, I selected "holdings_holdinbranch" and the table is sorted by "Home library". The table settings is listing all the columns that can be displayed, but only the non-empty columns are displayed. For instance if none of your items have $u, then the "URL" column won't be displayed. > - On the overdues page the default sort order and default display length > aren't applied. This table has the stateSave flag on. You need to remove the local storage item before trying it. > - Holds to pull: Column configuration doesn't seem to work. I have selected 50 and "patron" and it's working for me. Can you detail? > - Holds history: 'Uncaught TypeError: can't access property "filter", > table_settings.columns is undefined' Oops, fixed! > - Notice template: Column configuration doesn't work. Columns selected to be > hidden are not hidden. Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:03:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:03:16 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:05:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:05:41 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 --- Comment #1 from Martin Renvoize --- Created attachment 129086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129086&action=edit Bug 29809: Rename item relation accessor from itemnumber This patch renames the item relation accessor method in StockRotationItem to 'item' from 'itemnumber' to more clearly reflect that the method returns a Koha::Item object and not an itemnumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:05:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:05:45 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 --- Comment #2 from Martin Renvoize --- Created attachment 129087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129087&action=edit Bug 29809: Update stockration tool to reflect method name change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:05:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:05:56 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:06:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:06:05 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:06:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:06:19 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 --- Comment #3 from Martin Renvoize --- Hopefully that catches all spots -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:08:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:08:30 +0000 Subject: [Koha-bugs] [Bug 29811] misc/export_records.pl add possibility to export with timestamp option on authority record type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29811 --- Comment #1 from Thibaud Guillot --- Created attachment 129088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129088&action=edit BUG 29811 : add timestamp option on authority record type According to the timestamp option for bibs record type I added the timestamp option for authority records. Timestamp is already present in database on field "modification_time" Test Plan : 1 - Be sure to have authority record type for easiest test create one 2 - Execute script export_records.pl in your koha/misc directory and choose a date (example yesterday if you just created an authority right now).(see export_records.pl -h for help) 3 - Timestamp option has no effect on authority record type 4 - Execute script again but choose the date of tomorrow for example 5 - Same result 6 - Apply this patch 7 - Play again steps 2 and 4 8 - On step 2 you will see only your authorities created today (because script show you authority has changes since the date you choose in option) and for step 4 you must see an empty file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:08:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:08:58 +0000 Subject: [Koha-bugs] [Bug 29774] Self registration notification management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29774 --- Comment #3 from Katrin Fischer --- When staff create an account manually ACCTDETAILS can be sent, but has some issues. You have to make sure certain fields are filled in before saving hte first time or it won't be sent. To my knowledge there is no email after verfification. Maybe you could do as a customization/using patron emailer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:09:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:09:05 +0000 Subject: [Koha-bugs] [Bug 29811] misc/export_records.pl add possibility to export with timestamp option on authority record type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29811 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:12:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:12:36 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #43 from Jonathan Druart --- Created attachment 129089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129089&action=edit Bug 29648: Fix occurrences of GetColumns We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:12:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:12:43 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127877|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize --- Created attachment 129090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129090&action=edit Bug 21729: DB changes Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Florian Bontemps Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:12:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:12:49 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127878|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 129091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129091&action=edit Bug 21729: DBIC schema changes Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Florian Bontemps Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:12:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:12:52 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:12:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:12:54 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127879|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 129092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129092&action=edit Bug 21729: Keep expiration date set when placing a hold The expiration date picked by the patron (or librarian) when placing a hold is lost when a waiting hold is reverted. We need a separate DB field to store this value and restore it when needed: patron_expiration_date The new behaviours are now: Create a hold and specify an expiration date: expirationdate=patron_expiration_date Fill the hold: expiration_date is calculated expiration_date set to the calculated value or to patron_expiration_date if anterior patron_expiration_date not modified Revert the waiting status: expirationdate set back to patron_expiration_date Cancel expire reserves: if < expirationdate OR < patron_expiration_date Note: This change should not be needed but won't hurt Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Florian Bontemps Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:12:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:12:59 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127880|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize --- Created attachment 129093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129093&action=edit Bug 21729: Simplify non-existent expiration date No change in behaviour expected by this patch. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Florian Bontemps Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:13:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:13:05 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128761|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize --- Created attachment 129094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129094&action=edit Bug 21729: Add tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:13:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:13:22 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|tomascohen at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:13:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:13:56 +0000 Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #47 from Martin Renvoize --- All working as expected, code is clear. QA scripts happy, includes unit tests.. which read well and are passing. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:16:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:16:13 +0000 Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128382|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 129095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129095&action=edit Bug 27868: Add expiration date to holds awaiting pickup To test: 1. Have some holds awaiting pickup, also have some holds that have been waiting longer than the ReservesMaxPickUpDelay is set to. 2. Go to /cgi-bin/koha/circ/waitingreserves.pl 3. There is no expiration date 4. Apply patch and restart_all 5. Now there should be a Expiration date column, make sure you can see it in both Holds waiting and Holds waiting over X days 6. Make sure all the columns Waiting Since, Date hold placed, and expiration date still sort correctly 6. Go to Table settings, and make sure all the columns hide correctly for both of the holds_awaiting_pickup tables ( holdst & holdso ) Note: This patch also corrects 2 other small problems 1. Corrects a problem where the table settings did not account for the checkbox column at the beginnning of each table 2. Removes the title-string class and uses data-order to sort Waiting Since, Date hold placed, and expiration date ( see Bug 27934 ) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:16:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:16:54 +0000 Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Nice improvement, works as expected.. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:21:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:21:22 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #13 from Jonathan Druart --- Tests are failing for me t/DateUtils.t .. 20/79 # Failed test 'dt_from_string with no offset assumes "local"' # at t/DateUtils.t line 160. # got: '1325462399' # expected: '1325455199' # Failed test 'dt_from_string with UTC prescribed as Z' # at t/DateUtils.t line 164. # got: '1325462399' # expected: '1325455199' # Looks like you failed 2 tests of 6. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:24:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:24:42 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 --- Comment #24 from Jonathan Druart --- I volunteered at the time to adjust before push, I was RM. I can help if you want, but it's trivial to switch from the old to the new version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:31:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:31:58 +0000 Subject: [Koha-bugs] [Bug 29161] Holds to pull should show item level holds only if available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29161 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29148 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 [Bug 29148] Holds to Pull doesn't reflect item-level holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:31:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:31:58 +0000 Subject: [Koha-bugs] [Bug 29148] Holds to Pull doesn't reflect item-level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29148 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29161 [Bug 29161] Holds to pull should show item level holds only if available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:32:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:32:30 +0000 Subject: [Koha-bugs] [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|olli-antti.kivilahti at jns.fi |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:37:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:37:25 +0000 Subject: [Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 --- Comment #4 from Lucas Gass --- > Might be something people argue about. I really like the idea of it opening > in a separate tab as this has less surprise and you are leaving the current > site. Others might argue that they want the catalog and the website to be > perceived as the same website? I typically set links to open in a different tab if it is a different domain but I also think you are right about libraries wanting the OPAC and library website to be perceived as one. It's always possible to add the attribute via jQuery -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:39:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:39:25 +0000 Subject: [Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:39:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:39:28 +0000 Subject: [Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128139|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 129096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129096&action=edit Bug 29616: Replace library information popup in the OPAC with a modal This patch modifies the OPAC bibliographic detail page so that information stored in libraries' "OPAC info" field can be displayed in a modal window instead of in a tooltip. This will make it more readable, especially for libraries with so much info content that the popup can disappear off the bottom of the page. To test, apply the patch and make sure you have at least one library configured according to each of these: A. One with both branches.branchurl and branches.opac_info B. One with branches.branchurl but not branches.opac_info C. One with branches.opac_info but not branches.branchurl D. One with neither branches.branchurl nor branches.opac_info View the bibliographic detail page in the OPAC for title(s) which have holdings from the libraries you configured above. In the holdings table, check the behavior of the library name in the "Current library" or "Home library" columns * - Case A: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer, a "Visit web site" button should take you to the correct URL. - Case B: The library name appears as a link without an icon. Clicking the link takes you to the correct URL. - Case C: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer there is no "Visit web site" button. - Case D: The library name is plain text. * Display of "Current library" and/or "Home library" is controlled by the OpacLocationBranchToDisplay system preference. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:46:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:46:51 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:46:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:46:55 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129076|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi --- Created attachment 129097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129097&action=edit Bug 29788: Make Koha::Item->safe_to_delete use Koha::Result::Boolean This patch reuse the (awesome) Koha::Result::Boolean module to retrieve the return of Koha::Item->safe_to_delete. Test plan: Try to delete an item that has previously been checked out and confirm that you are still blocked. Try using the cronjobs, the item and biblio detail pages, as well as the batch delete item tool. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:47:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:47:00 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129077|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi --- Created attachment 129098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129098&action=edit Bug 29788: Fix batch delete item Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:53:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:53:36 +0000 Subject: [Koha-bugs] [Bug 29161] Holds to pull should show item level holds only if available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29161 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Andrew Fuerste-Henry --- After some testing, this issue is a side effect of bug 29786. The patch there will correct this. *** This bug has been marked as a duplicate of bug 29786 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:53:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:53:36 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |minna.kivinen at hamk.fi --- Comment #5 from Andrew Fuerste-Henry --- *** Bug 29161 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 15:56:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 14:56:13 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #2 from Martin Morris --- Thanks for the reply. I do have some custom CSS which I had previously stripped out (from OpacAdditionalStylesheet and any other possible field), which didn't help at all. I do also have a custom Coce server, hosted on the same machine, and I have now discovered that if I disable that the local cover images display correctly. Is this a bug in 21.11 which causes a conflict between a locally hosted Coce server and locally stored cover images perhaps? It worked perfectly under 21.05 and the previous versions of Koha I had used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 16:02:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 15:02:14 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 --- Comment #15 from Tomás Cohen Arazi --- Tested the different places, including Order.t tests. Things I found were fixed by Jonathan. QA script is happy, signing off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 16:17:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 15:17:32 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #3 from Owen Leonard --- Looks like it's working now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 16:19:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 15:19:59 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 16:20:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 15:20:02 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 --- Comment #6 from Lucas Gass --- Created attachment 129099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129099&action=edit Bug 21652: Only set waitingdate to today if there is no waitingdate already 1- Find or create a hold with a waitingdate other than today 2- Check the item in to generate a new hold alert 3- Select "Confirm and Print" 4- Verify that the waiting date has changed to the current date 5- Apply patch 6- Try 1-3 again, if a waitingdate already exists it should not change 7. Try an item with no waitingdate, it should properly update to today -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 16:25:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 15:25:55 +0000 Subject: [Koha-bugs] [Bug 29473] [DOCS 21.11] Documentation changes for 21.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29473 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 16:35:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 15:35:16 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #4 from Martin Morris --- Only if I disable Coce, and I do very much want/need that to be working as well. So I wouldn't want to close this bug until that issue is resolved in case it's not just my system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:05:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:05:21 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:05:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:05:24 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129099|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 129100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129100&action=edit Bug 21652: Only set waitingdate to today if there is no waitingdate already 1- Find or create a hold with a waitingdate other than today 2- Check the item in to generate a new hold alert 3- Select "Confirm and Print" 4- Verify that the waiting date has changed to the current date 5- Apply patch 6- Try 1-3 again, if a waitingdate already exists it should not change 7. Try an item with no waitingdate, it should properly update to today Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:13:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:13:16 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 theminh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the-minh.luong at inlibro.com Status|Needs Signoff |Signed Off --- Comment #2 from theminh --- I tested the patch and everything seems to work! Attribute C is not displayed when I am in a library other than mine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:16:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:16:39 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 --- Comment #3 from theminh --- I tested the patch and everything seems to work! Attribute C is not displayed when I am in a library other than mine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:18:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:18:54 +0000 Subject: [Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:18:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:18:57 +0000 Subject: [Koha-bugs] [Bug 29802] biblionumber in OPACHiddenItems breaks opac lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29802 --- Comment #1 from Nick Clemens --- Created attachment 129101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129101&action=edit Bug 29802: add 'me' to filter_by_visible_in_opac query This patch prefixes all of the fields in OpacHiddenItems with "me." before searching. Unit tests added to cover this case1 To test: 1 - Create a public list 2 - Set OpacHiddenItems to: biblionumber: [1] 3 - Attempt to view list in OPAC 4 - Booom 5 - Aply patch 6 - Reload list 7 - Success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:39:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:39:11 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:39:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:39:15 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124174|0 |1 is obsolete| | Attachment #124271|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 129102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129102&action=edit Bug 29809: Rename item relation accessor from itemnumber This patch renames the item relation accessor method in StockRotationItem to 'item' from 'itemnumber' to more clearly reflect that the method returns a Koha::Item object and not an itemnumber. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:39:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:39:18 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #8 from Nick Clemens --- Created attachment 129103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129103&action=edit Bug 29809: Update stockration tool to reflect method name change Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:39:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:39:21 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #9 from Nick Clemens --- Created attachment 129104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129104&action=edit Bug 28909: (follow-up) Update test for warning and rename variable Variable was updated for params, need to update declaration too Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:39:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:39:58 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #5 from Owen Leonard --- (In reply to Owen Leonard from comment #1) > rel="stylesheet"> > href="/opac-tmpl/bootstrap/css/opac.css" /> > > Do you have a custom stylesheet defined somewhere? In the > OpacAdditionalStylesheet system preference perhaps? The source for that page still has two links to opac.css. I think that's the cause. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 17:54:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 16:54:23 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode width and height parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Feature request: pass |Add barcode width and |barcode width and height as |height parameters to |parameters to /svc/barcode |/svc/barcode --- Comment #1 from Owen Leonard --- Is width an option? I don't see it: https://metacpan.org/pod/GD::Barcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 18:05:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 17:05:36 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #6 from Martin Morris --- I have now stripped out all customisation of the OPAC css and the source shows that is now absent. Upon reenabling Coce the local cover image again fails to display. Will leave the catalogue like this while investigating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 18:46:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 17:46:31 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 18:52:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 17:52:13 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:05:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:05:22 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:16:17 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:16:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:16:36 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127937|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:16:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:16:56 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127938|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:17:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:17:19 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:17:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:17:37 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:17:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:17:58 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127941|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:18:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:18:14 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127942|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:18:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:18:21 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:18:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:18:29 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:19:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:19:07 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 129105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129105&action=edit Bug 29495: Unit Tests Test plan 1. Run updated tests prior to applying new patches.. pass 2. Run updated tests after applying new patches.. pass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:19:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:19:15 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 129106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129106&action=edit Bug 29495: Drop issue_id constraint from return_claims This patch removes the issue_id constraint from return_claims. Due to the nature of our dual table approach to checkouts/old_checkouts we can't safely hae this constraint and not lose data. Prior to this commit, when an item is checked in we move the checkout from checkouts to old_checkouts.. this therefore triggers the delete of the issue_id from the return_claims table as described by the foreign key constraint. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:19:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:19:26 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 129107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129107&action=edit Bug 29495: DBIC Schema Rebuild Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:19:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:19:35 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 129109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129109&action=edit Bug 29495: Add DBIC relationships back into Schema This patch adds the relationship accessors back into the affected Schema classes, now below the fold so they are retained during dbic rebuilds. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:19:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:19:47 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 129110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129110&action=edit Bug 29495: Add code level constraint replacement This patch adds a check in Koha::Checkouts::ReturnClaim::store to replace the database level foreign key check. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:19:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:19:59 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 129111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129111&action=edit Bug 29495: Update relationship methods This patch updates the relationship methods found in Koha::Checkouts::ReturnClaim so that they are prefetchable and embeddable on the API. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:20:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:20:12 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 129112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129112&action=edit Bug 29495: (follow-up) Use 'item' relationship This patch adds the missing 'item' relationship in Checkouts::ReturnClaim and then uses it from the resolve method. This improve the reliability of the resolution code so it works when the item has already been checked in (without having to check Old::Checkouts). Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:20:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:20:35 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 129113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129113&action=edit Bug 29495: Add relation tests This patch adds missing tests for relationship accessors in the ReturnClaim class. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:24:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:24:26 +0000 Subject: [Koha-bugs] [Bug 29812] New: C4::Context not included, but used in Koha::Token Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 Bug ID: 29812 Summary: C4::Context not included, but used in Koha::Token Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:24:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:24:35 +0000 Subject: [Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:26:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:26:10 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:26:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:26:14 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:26:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:26:41 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129114&action=edit Bug 29704: Add a triggered option to holds_reminder.pl This patch adds an option to only trigger notices matching the number of days waiting specified You will need to define HOLD_REMINDER notices for the specific branch of the patron and ensure the patron has hold reminder notices in their messaging preferences TO test: 1 - Place a hold for a patron and check in to confirm 2 - Set the waiting date back a few days: update reserves set waitingdate = DATE_SUB(CURDATE(), INTERVAL 5 DAY); 3 - Run the cron and see that patron would be notified if running for 4 days weaiting perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 4 - Apply patch 5 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 --triggered 6 - Note patron would not be notified 7 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 5 --triggered 8 - Note patron is notified when days waiting matches exactly Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:27:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:27:34 +0000 Subject: [Koha-bugs] [Bug 29813] New: skeleton.pl missing semicolon Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Bug ID: 29813 Summary: skeleton.pl missing semicolon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:28:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:28:57 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:29:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:29:49 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:29:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:29:56 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129115&action=edit Bug 29813: Add missing semicolon in skeleton.pl This has no effect as it is not causing problems. But. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:31:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:31:21 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:54:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:54:23 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:54:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:54:32 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128843|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 19:55:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 18:55:52 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129116&action=edit Bug 29702: Fetch group libraries in a single call The current code gets all group members, then loops through and fetches the library if there is a branchcode, or recursively calls itself if a group. This slows down performance. We can utilize the 'libraries' method to get all child libraries at once, then make a check for child groups separately To recreate: 1 - Add 100 items to a biblio 2 - Define a library group as a hold group 3 - Add all libraries to the group 4 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Any library' 5 - place a hold on the record and note load time after patron is selected 6 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Patrons hold group' 7 - place a hold, note longer load time after patron selection 8 - Apply patch 9 - note improvement 10 - prove -v t/db_dependent/Koha/Libraries.t Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 20:21:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 19:21:27 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 --- Comment #4 from Tomás Cohen Arazi --- We could try using closure tables to optimize even further. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 20:23:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 19:23:33 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 20:56:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 19:56:56 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 20:56:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 19:56:59 +0000 Subject: [Koha-bugs] [Bug 29397] Add a select2 wrapper for the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127320|0 |1 is obsolete| | Attachment #127321|0 |1 is obsolete| | Attachment #127322|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 129117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129117&action=edit Bug 29397: Add .kohaSelect select2 wrapper function This patch adds a kohaSelect wrapper function to simplify paging/infinite scrolling with select2 using the Koha RESTful api's. Invoke select2 select boxes as you normally would from JS, but instead of calling .select2(config) use .kohaSelect(config). If an 'ajax' property is defined in your config object, we wrap the transport such that responses include a pagination key as expected by select2. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 21:10:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 20:10:36 +0000 Subject: [Koha-bugs] [Bug 29191] Linking biblio headings to authorities doesn't work with subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 21:15:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 20:15:55 +0000 Subject: [Koha-bugs] [Bug 28628] Elasticsearch - Heading search form does'nt match related indexed heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28628 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29191 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 21:15:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 20:15:55 +0000 Subject: [Koha-bugs] [Bug 29191] Linking biblio headings to authorities doesn't work with subdivisions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29191 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28628 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 21:24:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 20:24:56 +0000 Subject: [Koha-bugs] [Bug 28693] Main heading box not populated in search authorities from bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28693 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27737 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 21:24:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 20:24:56 +0000 Subject: [Koha-bugs] [Bug 27737] Tag editor for authority lookup broken in authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27737 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28693 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 21:28:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 20:28:15 +0000 Subject: [Koha-bugs] [Bug 28693] Main heading box not populated in search authorities from bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28693 --- Comment #3 from Fridolin Somers --- Seems linked to Bug 27737 I can't reproduce the bug with Koha 20.11.12 Is it still valid ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 21:38:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 20:38:09 +0000 Subject: [Koha-bugs] [Bug 27527] Plugin hooks to create additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27527 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27033 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 6 21:38:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 20:38:09 +0000 Subject: [Koha-bugs] [Bug 27033] Add plugin hook to add a big link in staff home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27033 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27527 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 00:02:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 23:02:37 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 00:02:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 23:02:41 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128679|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 129118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129118&action=edit Bug 6734: Show location in serials history table Opac: On a record(Serials) details the location wasn't displayed on the "Normal view" and "Full history" tabs Test plan: 1)Intranet: Make sure to have at least two different Serials/Subscriptions on the same record with the field 'location' filled in 2)Opac: Find your Serials/Subscriptions 3)Click 'More details' and notice the 3 tabs : Normal view, Brief history, Full history 4)Go to 'Normal view' and 'Full history' to notice that 'location' is missing 5)Apply patch, refresh your browser & repeat 4) 6)The location is now visible Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 00:12:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 23:12:31 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 00:12:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 23:12:35 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122883|0 |1 is obsolete| | --- Comment #31 from Chris Cormack --- Created attachment 129119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129119&action=edit Bug 7021: patron category in the statistics table This patch populates the koha.statistics.usercode with borrowers.categorycode where it is easily available. Currently for statistics.type 'issue' OR 'localuse' OR 'renew'. Supplied a script to UPDATE the old statistics records. Have fun! To test: 1. Add loan for patron. 2. Check statistics table => 'usercode' column for this issue should now contain patrons categorycode To test add_statistics_borrowers_categorycode.pl: 1. Run add_statistics_borrowers_categorycode.pl 2. Check statistics table => all statistics which are type 'issue' OR 'localuse' OR 'renew' should now contain patrons categorycode in 'usercode' column Also prove that tests in t/db_dependent/Circulation.t still pass. Rebased-by: Emmi Takkinen Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 00:13:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 23:13:01 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129119|0 |1 is obsolete| | --- Comment #32 from Chris Cormack --- Created attachment 129120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129120&action=edit Bug 7021: patron category in the statistics table This patch populates the koha.statistics.usercode with borrowers.categorycode where it is easily available. Currently for statistics.type 'issue' OR 'localuse' OR 'renew'. Supplied a script to UPDATE the old statistics records. Have fun! To test: 1. Add loan for patron. 2. Check statistics table => 'usercode' column for this issue should now contain patrons categorycode To test add_statistics_borrowers_categorycode.pl: 1. Run add_statistics_borrowers_categorycode.pl 2. Check statistics table => all statistics which are type 'issue' OR 'localuse' OR 'renew' should now contain patrons categorycode in 'usercode' column Also prove that tests in t/db_dependent/Circulation.t still pass. Rebased-by: Emmi Takkinen Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 00:14:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 23:14:18 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122881|0 |1 is obsolete| | --- Comment #33 from Chris Cormack --- Created attachment 129121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129121&action=edit Bug 7021: Reintroduce usercode column This patch reintroduces usercode column to statistics table. To test: 1. Apply patch and update database 2. Confirm there's column usercode in statistics table Sponsored-by: Koha-Suomi Oy Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 00:14:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jan 2022 23:14:23 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129120|0 |1 is obsolete| | --- Comment #34 from Chris Cormack --- Created attachment 129122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129122&action=edit Bug 7021: patron category in the statistics table This patch populates the koha.statistics.usercode with borrowers.categorycode where it is easily available. Currently for statistics.type 'issue' OR 'localuse' OR 'renew'. Supplied a script to UPDATE the old statistics records. Have fun! To test: 1. Add loan for patron. 2. Check statistics table => 'usercode' column for this issue should now contain patrons categorycode To test add_statistics_borrowers_categorycode.pl: 1. Run add_statistics_borrowers_categorycode.pl 2. Check statistics table => all statistics which are type 'issue' OR 'localuse' OR 'renew' should now contain patrons categorycode in 'usercode' column Also prove that tests in t/db_dependent/Circulation.t still pass. Rebased-by: Emmi Takkinen Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 01:06:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 00:06:33 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Set serial issue default |Define serial's collection |values when creating a |code in the subscription |subscription in | |serials/subscription-add.pl | Status|Patch doesn't apply |ASSIGNED --- Comment #22 from Alex Buckley --- Hi all, I think the best step forward for this is to split the functionality on this bug report into separate smaller reports. That being the case I'm changing this one to only cover defining serial's collection codes in the subscription. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 01:06:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 00:06:54 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101913|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 01:07:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 00:07:04 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101914|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 01:07:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 00:07:13 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 01:07:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 00:07:37 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 --- Comment #23 from Alex Buckley --- Created attachment 129123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129123&action=edit Bug 23352: Database changes Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 01:07:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 00:07:55 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 --- Comment #24 from Alex Buckley --- Created attachment 129124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129124&action=edit Bug 23352: Updated schema file Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 01:08:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 00:08:14 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 --- Comment #25 from Alex Buckley --- Created attachment 129125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129125&action=edit Bug 23352: Set default collection code when creating subscription The default collection code set in the subscription will be applied if item records are created when receiving the serial. Test plan: 1. Apply 3 patches 2. Run updatedatabase.pl and restart services 3. Create a subscription: - Tick the 'Create an item record when receiving this serial' radio button - Select values in the Location, Collection code and Item type dropdowns - Save the subscription 4. Confirm the Location, and Collection code default values you choose in #3 are displaying in the 'Information' tab of page that's loaded 5. Receive the serial: - Click 'Receive' - Change the status dropdown from 'Expected' to 'Arrived' - Confirm the 'Collection Code', 'Shelving location' and 'Koha item type' dropdowns are pre-filled with the values you defined in #3 6. Run unit test t/db_dependent/Serials.t Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 01:08:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 00:08:36 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #26 from Alex Buckley --- Ready for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 02:06:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 01:06:28 +0000 Subject: [Koha-bugs] [Bug 29814] New: Unwanted dashes added to authorities Zebra indexing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29814 Bug ID: 29814 Summary: Unwanted dashes added to authorities Zebra indexing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com In Zebra authorities configuration, when using index_heading the subdivisions are joined with two dashes. You can see this when looking at what is indexed : https://wiki.koha-community.org/wiki/Troubleshooting_Zebra#Which_indexes_are_defined.3F For example : field 250 $a Cinéma $x Films $y France $z 2010 Shows : Cinéma--Films--France--2010 And a search "Cinéma Films France 2010" on main heading does not find this record. It comes from https://git.koha-community.org/Koha-community/Koha/src/commit/895fc88605f7381218b38463be17531a06403c1a/etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl#L438 Anyone knows where this comes from and how it is supposed to work ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 02:06:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 01:06:51 +0000 Subject: [Koha-bugs] [Bug 29814] Unwanted dashes added to authorities Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29814 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 02:09:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 01:09:30 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 02:41:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 01:41:03 +0000 Subject: [Koha-bugs] [Bug 29815] New: Pre-populate 'Date acquired' field when receiving serial Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Bug ID: 29815 Summary: Pre-populate 'Date acquired' field when receiving serial Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org When receiving serial issues the 952$d (Date acquired) field should be pre-populated with the current date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 02:41:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 01:41:24 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when receiving serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23352 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 02:41:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 01:41:24 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29815 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 02:51:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 01:51:55 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when receiving serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #1 from Alex Buckley --- Created attachment 129126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129126&action=edit Bug 29815: Pre-fill 952$d (Date acquired) when receiving serial items Test plan: 1. Create a subscription - Select the 'Create an item record when receiving this serial' 2. Receive the serial 3. After changing the status from 'Expected' to 'Arrived' notice that the 'd - Date acquired' is not set until you click on that field 4. Apply patch and restart services 5. Receive the serial again and notice this time today's date is pre-populated in 'd - Date acquired' Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 02:52:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 01:52:31 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when receiving serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored --- Comment #2 from Alex Buckley --- Ready for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 02:54:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 01:54:42 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when receiving serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 02:55:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 01:55:05 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when receiving serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #3 from Alex Buckley --- Created attachment 129127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129127&action=edit Bug 29815: Pre-fill 952$d (Date acquired) when receiving serial items Test plan: 1. Create a subscription - Select the 'Create an item record when receiving this serial' 2. Receive the serial 3. After changing the status from 'Expected' to 'Arrived' notice that the 'd - Date acquired' is not set until you click on that field 4. Apply patch and restart services 5. Receive the serial again and notice this time today's date is pre-populated in 'd - Date acquired' Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 05:13:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 04:13:26 +0000 Subject: [Koha-bugs] [Bug 23450] Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101930|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 05:13:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 04:13:55 +0000 Subject: [Koha-bugs] [Bug 23450] Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450 --- Comment #4 from Alex Buckley --- Created attachment 129128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129128&action=edit Bug 23450: Display serial and subscription price in biblio detail page The 'Subscription' tab should display: - Total subscription price (based on what's set in the linked order) - Serial price based on what's set in the 952$g (items.price) Test plan: 1. Create a subscription - Tick the 'Create an item record when receiving this serial' radiobutton 2. Create an order, linking it to a subscription, set: - Quantity: 2 - Vendor price: 3 3. Receive the serial 4. Set the 952$g (normal purchase price) as 5 5. Visit the biblio detail page 6. View the 'Subscription' tab and confirm that: 'Total subscription cost is: 6.00' 'Issue price' in the table is 5.00 Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 08:30:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 07:30:13 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 08:30:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 07:30:17 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129115|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 129129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129129&action=edit Bug 29813: Add missing semicolon in skeleton.pl This has no effect as it is not causing problems. But. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 08:48:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 07:48:14 +0000 Subject: [Koha-bugs] [Bug 29816] New: Document patron emailer cronjob Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29816 Bug ID: 29816 Summary: Document patron emailer cronjob Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org misc/cronjobs/patron_emailer.pl was introduced by Bug 16149, but as far as I can tell it is not documented in the manual. Sorry if I missed it. I'd say documenting this is extra important, since it is a cool feature that is not visible from the Koha GUI (but see also Bug 27452.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 08:48:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 07:48:53 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 08:48:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 07:48:59 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129059|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 129130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129130&action=edit Bug 29806: Regression tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 08:49:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 07:49:04 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129058|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 129131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129131&action=edit Bug 29806: Call ->as_list for ->pickup_locations on request.pl Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 08:49:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 07:49:10 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129060|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 129132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129132&action=edit Bug 29806: Fix POST /holds use of pickup_locations This patch makes Koha::Item->pickup_locations and Koha::Biblio->pickup_locations explicitly call ->as_list in list context. This way we workaround bug 28871. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail, the route gives a 500 (unhandled exception) 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass, the route correctly returns a 400 with a message about the pickup location being invalid 5. Sign off :-D Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 09:34:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 08:34:32 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 09:47:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 08:47:02 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #23 from Katrin Fischer --- We are using this script not only in migrations, but also for our nightly updates from the union catalog. Since we updated the server from 18.11 to 20.11 we are seeing the error every night. I'd be really glad to see this resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 09:48:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 08:48:46 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 09:58:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 08:58:35 +0000 Subject: [Koha-bugs] [Bug 20105] Ability to allow article requests without an existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20105 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Ability to allow Article |Ability to allow article |Request to be without an |requests without an |attached record |existing record --- Comment #2 from Katrin Fischer --- Still something that would be really helpful for a lot of libraries. Activating the "free form" for article requests should still be probably be optional. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 10:27:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 09:27:58 +0000 Subject: [Koha-bugs] [Bug 27033] Add plugin hook to add a big link in staff home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27033 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #10 from Jonathan Druart --- Shouldn't this be actually replaced with bug 15326? Aleisha rewrote it to add a new "page" type of additional contents. It would be a core feature, and plugins could simply add new contents by adding rows to the DB tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 10:46:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 09:46:35 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #10 from Andrew Isherwood --- Hi Nick, I think you've attached your patches to the wrong bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 11:29:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 10:29:32 +0000 Subject: [Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Depends on| |18124 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18124 [Bug 18124] CSRF tokens must be limited to user's session -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 11:29:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 10:29:32 +0000 Subject: [Koha-bugs] [Bug 18124] CSRF tokens must be limited to user's session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 [Bug 29812] C4::Context not included, but used in Koha::Token -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 11:30:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 10:30:44 +0000 Subject: [Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 11:30:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 10:30:49 +0000 Subject: [Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 --- Comment #1 from Jonathan Druart --- Created attachment 129134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129134&action=edit Bug 29812: Add missing use C4::Context in Koha::Token Caused by bug 18124. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 11:31:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 10:31:00 +0000 Subject: [Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 11:45:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 10:45:44 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 11:57:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 10:57:29 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #33 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:01:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:01:47 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle at bywatersolutions.com --- Comment #45 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:03:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:03:00 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #14 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #10) > (In reply to Lucas Gass from comment #9) > > Tests pass and sorting works so I signed off. Making the Summary/title > > sortable again will happen in Bug 29570? > > Yes, that's much more complex to solve. (In reply to Tomás Cohen Arazi from comment #11) > *** Bug 29570 has been marked as a duplicate of this bug. *** Why is this marked as duplicate? We are not solving the problem for the summary column (and so the sort by title) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:05:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:05:51 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #14) > (In reply to Tomás Cohen Arazi from comment #10) > > (In reply to Lucas Gass from comment #9) > > > Tests pass and sorting works so I signed off. Making the Summary/title > > > sortable again will happen in Bug 29570? > > > > Yes, that's much more complex to solve. > > (In reply to Tomás Cohen Arazi from comment #11) > > *** Bug 29570 has been marked as a duplicate of this bug. *** > > Why is this marked as duplicate? We are not solving the problem for the > summary column (and so the sort by title) duplicate status has been reverted, I missed that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:12:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:12:15 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #11 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:12:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:12:34 +0000 Subject: [Koha-bugs] [Bug 29289] 'Show fines to guarantor' should have its own id on patron detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29289 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:14:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:14:05 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:15:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:15:06 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:15:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:15:09 +0000 Subject: [Koha-bugs] [Bug 29604] Term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:15:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:15:13 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128397|0 |1 is obsolete| | Attachment #128398|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 129136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129136&action=edit Bug 29464: Regression tests Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:15:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:15:20 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #17 from Jonathan Druart --- Created attachment 129137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129137&action=edit Bug 29464: Make GET /acquisitions/orders honour sorting When bug 20212 was pushed, we lost (didn't dig enough to find out how) the sorting feature for this route. This is mainly because biblio+biblioitems filtering prevents the route to use plain $c->objects->search, so it has baked a custom version of it. In this case, it missed the call to the dbic_merge_sorting helper, that takes care of reading the query parameters and inject the sorting attributes to the resultset. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => FAIL: Tests fail, sorting doesn't actually work 3. Apply this patch 4. Repeat 2 => SUCCESS: Sorting works! 5. Test sorting the pending orders on parcel.tt 6. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:15:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:15:36 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:15:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:15:40 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:17:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:17:22 +0000 Subject: [Koha-bugs] [Bug 29729] If serials_stats.pl returns no results dataTables get angry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:18:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:18:04 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:19:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:19:42 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:20:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:20:36 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in 0001 option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #15 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:20:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:20:56 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:21:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:21:01 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129045|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 129138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129138&action=edit Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t and prove t/db_dependent/Koha/CirculationRules/* Signed-off-by: Samu Heiskanen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:22:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:22:20 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:22:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:22:59 +0000 Subject: [Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped in selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:23:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:23:51 +0000 Subject: [Koha-bugs] [Bug 29810] Add embed options documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29810 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Martin Renvoize --- Grr.. looks like collectionFormat support requires a newer version of JSON::Validator so this breaks our embeds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:26:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:26:08 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #14 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:27:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:27:04 +0000 Subject: [Koha-bugs] [Bug 28020] Error responses should return a code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:27:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:27:04 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Bug 29772 depends on bug 28020, which changed state. Bug 28020 Summary: Error responses should return a code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28020 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:27:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:27:43 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:27:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:27:46 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128989|0 |1 is obsolete| | Attachment #128990|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 129139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129139&action=edit Bug 29786: Unit tests I add a new test for the case of an item level hold, and additionally adjust later tests to use a title level hold. I also fix a typo where the comment says item 1 when it means item 2 Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:27:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:27:50 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 --- Comment #7 from Jonathan Druart --- Created attachment 129140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129140&action=edit Bug 29786: Select only specific items for item level holds This patch adjusts get_items_that_can_fill to make two requests: first the list of items for item-level holds second the list of biblionumbers for title-level holds This stops the report from pulling more items for item-level hold This patch also removes the aliases used in the code - while readability is a bit harder, it allows for using 'me' in get_items_that_can_fill Otherwise, this routine would need a parameter to know what we called the table. To test: 1 - Find a record with many items available 2 - Place an item level hold for an item on the record, not the one with lowest itemnumber 3 - Run 'Hold to pull' report 4 - Note the barcode does not match 5 - Apply patch 6 - Reload report 7 - It matches! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:28:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:28:22 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #17 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:29:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:29:20 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 --- Comment #18 from Kyle M Hall --- Backported as part of a combo with 29018. I'd rather not leave 21.11 in a half-finished state for this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:29:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:29:55 +0000 Subject: [Koha-bugs] [Bug 29746] Add a handy Koha::Result::Boolean class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:29:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:29:56 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Bug 29765 depends on bug 29746, which changed state. Bug 29746 Summary: Add a handy Koha::Result::Boolean class https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:29:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:29:56 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Bug 29788 depends on bug 29746, which changed state. Bug 29746 Summary: Add a handy Koha::Result::Boolean class https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29746 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:31:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:31:14 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:31:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:31:14 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Bug 29772 depends on bug 29765, which changed state. Bug 29765 Summary: Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:31:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:31:38 +0000 Subject: [Koha-bugs] [Bug 29772] Make DELETE /patrons/:patron_id return error codes in error conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29772 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:32:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:32:08 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:34:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:34:15 +0000 Subject: [Koha-bugs] [Bug 29503] GET /patrons should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #12 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:35:35 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 12:37:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 11:37:04 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:14:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:14:18 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:14:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:14:21 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128868|0 |1 is obsolete| | Attachment #128869|0 |1 is obsolete| | Attachment #128870|0 |1 is obsolete| | Attachment #128871|0 |1 is obsolete| | Attachment #128872|0 |1 is obsolete| | Attachment #128873|0 |1 is obsolete| | --- Comment #68 from Kyle M Hall --- Created attachment 129141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129141&action=edit Bug 27946: Add article_requests.debit_id and ARTICLE_REQUEST account debit type Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:14:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:14:31 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #69 from Kyle M Hall --- Created attachment 129142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129142&action=edit Bug 27946: DBIC schema changes [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:14:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:14:35 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #70 from Kyle M Hall --- Created attachment 129143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129143&action=edit Bug 27946: Add article request fee to circulation rules This patch adds a new circulation rule: article requests fee. It can be set per library and category. To test: 1. Try setting sdifferent numeric values, change, and delete them => SUCCESS: Things work as expected 2. Make sure rules are loaded correctly when re-entering the circ rules page => SUCCESS: All good 3. Verify the data on the DB is stored as it should on each of your tests: $ koha-mysql kohadev > SELECT * FROM circulation_rules \ WHERE rule_name='article_request_fee'; => SUCCESS: All good (remember NULL => 'All' in the UI) 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:14:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:14:38 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #71 from Kyle M Hall --- Created attachment 129144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129144&action=edit Bug 27946: Article request fee methods in Koha::Patron This patch adds article_request_fee() and add_article_request_fee_if_needed() methods to Koha::Patron. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:14:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:14:42 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #72 from Kyle M Hall --- Created attachment 129145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129145&action=edit Bug 27946: Make Koha::ArticleRequest->request add a fee if required This patch makes the ->request method add a fee for the patron if required. It relies on methods defined in Koha::Patron for the task. The debit line is linked to the AR if applies. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:14:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:14:46 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #73 from Kyle M Hall --- Created attachment 129146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129146&action=edit Bug 27946: Add UI handling of AR fees This patch: - Adds a notice about the fee to be charged to the patron (staff and OPAC) - Adds the right UI description for ARTICLE_REQUEST_FEE debit types in the UI. To test: 1. Have some article request fee rules 2. Play with placing an article request in OPAC and staff => SUCCESS: You see a message about the fee => SUCCESS: The fees are correctly applied to the patron 3. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:14:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:14:50 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 --- Comment #74 from Kyle M Hall --- Created attachment 129147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129147&action=edit Bug 27946: (QA follow-up) Remove 'scan' terminology, requests may not be scans Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:24:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:24:05 +0000 Subject: [Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:24:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:24:09 +0000 Subject: [Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129134|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129148&action=edit Bug 29812: Add missing use C4::Context in Koha::Token Caused by bug 18124. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:27:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:27:19 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:27:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:27:24 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129044|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:35:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:35:09 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129149&action=edit Bug 29717: Remove unecessary DT manipulations from tools/additional-contents.pl DBIC handles DateTime correctly, no need for this output_pref call. Test plan: Create a new content, set the dates, confirm they are set correctly Modify the content, modify the dates, confirm they are stored correctly Signed-off-by: Lucas Gass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:36:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:36:31 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | --- Comment #6 from Tomás Cohen Arazi --- Please rebase. It like it but doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 13:37:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 12:37:53 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #38 from Tomás Cohen Arazi --- Can anyone QA this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:07:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:07:23 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:07:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:07:27 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128865|0 |1 is obsolete| | Attachment #128866|0 |1 is obsolete| | Attachment #128867|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 129150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129150&action=edit Bug 29757: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:07:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:07:51 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 --- Comment #5 from Kyle M Hall --- Created attachment 129151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129151&action=edit Bug 29757: Add filters for reversable offsets This patch adds filtering methods for (non)reversable offsets. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Account/Offsets.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:07:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:07:54 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 --- Comment #6 from Kyle M Hall --- Created attachment 129152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129152&action=edit Bug 29757: (QA follow-up) POD fixes This patch adds POD, fixes the existing one in the file, and also renames reversable => reversible as required by the QA scripts. If this name change is problematic, I can revert it and resubmit my follow-up. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:16:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:16:02 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:16:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:16:06 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128437|0 |1 is obsolete| | Attachment #128438|0 |1 is obsolete| | Attachment #128439|0 |1 is obsolete| | Attachment #128440|0 |1 is obsolete| | Attachment #128441|0 |1 is obsolete| | Attachment #128442|0 |1 is obsolete| | Attachment #128443|0 |1 is obsolete| | Attachment #128444|0 |1 is obsolete| | Attachment #128445|0 |1 is obsolete| | --- Comment #39 from Nick Clemens --- Created attachment 129153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129153&action=edit Bug 29605: Add missing constraints from bug 15067 This patch fixes a missed update to kohastructure.sql. To test: 1. Checkout prior to bug 15067 (ab270c026be06f08745a14d1aea992877d20f812) would work. 2. Run: $ reset_all 3. Checkout v21.11.00 4. Run: $ updatedatabase $ koha-mysql kohadev > SHOW CREATE TABLE language_subtag_registry; => SUCCESS: There's UNIQUE KEY uniq_lang (subtag, type) 5. Run: > SHOW CREATE TABLE language_descriptions; => SUCCESS: There's UNIQUE KEY uniq_desc (subtag, type, lang) 6. Run: > SHOW CREATE TABLE language_rfc4646_to_iso639; => SUCCESS: There's UNIQUE KEY uniq_code (rfc4646_subtag, iso639_2_code) 7. Replicate a fresh install. Run: $ reset_all 8. Repeat 4, 5 and 6 => FAIL: The UNIQUE constraints are not there! 9. Apply this patch 10. Run: $ reset_all 11. Repeat 8 => SUCCESS: The UNIQUE constraints are there! 12. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:16:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:16:10 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #40 from Nick Clemens --- Created attachment 129154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129154&action=edit Bug 29605: (follow-up) Add language_script_mapping primary key Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:16:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:16:14 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #41 from Nick Clemens --- Created attachment 129155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129155&action=edit Bug 29605: Missing FK on tmp_holdsqueue.borrowernumber (tmp_holdsqueue_ibfk_3) Bad copy paste on the foreign_key_exists condition Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:16:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:16:18 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #42 from Nick Clemens --- Created attachment 129156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129156&action=edit Bug 29605: account_offsets.type is not null Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:16:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:16:21 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #43 from Nick Clemens --- Created attachment 129157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129157&action=edit Bug 29605: additional_contents.code Added 100 on 210600016, but 20 in kohastructure Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:16:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:16:25 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #44 from Nick Clemens --- Created attachment 129158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129158&action=edit Bug 29605: additional_contents.lang Up to 50 on bug 23797 but bug 24387 switched it back to 25 (bad resolution conflict) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:16:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:16:29 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #45 from Nick Clemens --- Created attachment 129159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129159&action=edit Bug 29605: search_marc_map.marc_type NOT NULL was missing when MODIFY Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:16:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:16:33 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #46 from Nick Clemens --- Created attachment 129160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129160&action=edit Bug 29605: language_script_mapping.language_subtag cannot be null It's a PK now Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:16:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:16:36 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #47 from Nick Clemens --- Created attachment 129161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129161&action=edit Bug 29605: branchtransfers.cancellation_reason reason and cancellation_reason was inversed, and the enum values were lower cases Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:27:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:27:18 +0000 Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26947 --- Comment #48 from Nick Clemens --- Bug 26947 - that might help for the future -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:27:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:27:18 +0000 Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29605 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:29:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:29:22 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:29:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:29:26 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128874|0 |1 is obsolete| | Attachment #128875|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 129162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129162&action=edit Bug 29759: Unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:29:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:29:57 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #4 from Kyle M Hall --- Created attachment 129163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129163&action=edit Bug 29759: Make cancelling an AR refund This patch makes the Koha::ArticleRequest->cancel method perform a refund if it applies. The sequence is: - Find refundable (potentially partial) payments against the fee - Generate a refund for the refundable amount - Reduce the fee to zero => RESULT: the patron owes nothing, any credits applied to the debit are refunded. 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => FAIL: Nothing is refunded 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Refunds take place! 5. Try on the UI => SUCCESS: All good 6. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:32:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:32:07 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:34:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:34:49 +0000 Subject: [Koha-bugs] [Bug 29818] New: Cannot save subscription frequency with no display order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29818 Bug ID: 29818 Summary: Cannot save subscription frequency with no display order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Go to Manage Frequencies (/cgi-bin/koha/serials/subscription-frequencies.pl) 2 - create a new frequency, don't enter a value for display order 3 - try to save, get an error: C4::Serials::Frequency::AddSubscriptionFrequency(): DBI Exception: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'displayorder' at row 1 at /kohadevbox/koha/serials/subscription-frequencies.pl line 89 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:36:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:36:00 +0000 Subject: [Koha-bugs] [Bug 20944] Add routes to add credits to a patron's account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29453 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:36:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:36:00 +0000 Subject: [Koha-bugs] [Bug 29453] Add routes to fetch patron credits/debits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29453 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:42:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:42:33 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:47:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:47:27 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129005|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 129164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129164&action=edit Bug 29789: Remove unused $error from cataloguing/additem.pl my $error = $input->param('error'); It should be removed as $error is used later but not related to this variable. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:55:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:55:27 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:57:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:57:48 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:57:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:57:52 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128724|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:58:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:58:13 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 129165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129165&action=edit Bug 18540: Handle indexing sort title only when needed This patch moves the code that generates the xsl for MARC21 biblio sorting to it's own template that is only called when specified in the xml To test: 1 - xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl 2 - git diff 3 - Note that authority-zebra-indexdefs.xsl now has 245 Title:s info 4 - Apply patch 5 - xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl 6 - git diff 7 - There are lines added about title sort, but no 245 block 8 - xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 9 - git diff 10 - Note lines changes to ...title_sort 11 - 245 block does not change Signed-off-by: Hayley Pelham Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:58:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:58:17 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 129166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129166&action=edit Bug 18540: (QA follow-up) Only mention index_sort_title if defined This patch makes the generated xslt not mention index_sort_title unless the entry is defined on the xml file. Otherwise there's a call to Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 14:58:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 13:58:21 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 129167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129167&action=edit Bug 18540: Update MARC21 biblio XSL file I ran the xsltproc on both MARC21 and UNIMARC files (biblios and authorities). With my follow-up the only changed one is this one. I skipped NORMARC as it is supposed to be removed by now (so unused in Norway). Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:01:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:01:39 +0000 Subject: [Koha-bugs] [Bug 29519] One should be able to resolve a return claim at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:08:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:08:22 +0000 Subject: [Koha-bugs] [Bug 29790] Deleting serial items fail without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:08:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:08:26 +0000 Subject: [Koha-bugs] [Bug 29790] Deleting serial items fail without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129006|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 129168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129168&action=edit Bug 29790: Restore warning if deletion of serial item fails If the deletion of a serial item failed, the UI did not provide a warning/error message. Test plan: 0. Create a new subscription with "Create an item record when receiving this serial" 1. Receive a new item, set a barcode 2. Check it out 3. Select the item you have received in the serial item list (page "Serial collection information") and click "Delete selected issues" 4. Tick "Delete the associated items" and confirm the deletion => Without this patch the deletion fail but the UI does not warn it => With this patch applied you see a warning "one or more associated items could not be deleted at this time." Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:12:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:12:32 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:12:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:12:36 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129097|0 |1 is obsolete| | Attachment #129098|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 129169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129169&action=edit Bug 29788: Make Koha::Item->safe_to_delete use Koha::Result::Boolean This patch reuse the (awesome) Koha::Result::Boolean module to retrieve the return of Koha::Item->safe_to_delete. Test plan: Try to delete an item that has previously been checked out and confirm that you are still blocked. Try using the cronjobs, the item and biblio detail pages, as well as the batch delete item tool. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:12:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:12:45 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 --- Comment #17 from Kyle M Hall --- Created attachment 129170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129170&action=edit Bug 29788: Fix batch delete item Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:18:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:18:14 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129141|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize --- Created attachment 129171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129171&action=edit Bug 27946: Add article_requests.debit_id and ARTICLE_REQUEST account debit type Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:18:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:18:18 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129142|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize --- Created attachment 129172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129172&action=edit Bug 27946: DBIC schema changes [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:18:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:18:22 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129143|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize --- Created attachment 129173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129173&action=edit Bug 27946: Add article request fee to circulation rules This patch adds a new circulation rule: article requests fee. It can be set per library and category. To test: 1. Try setting sdifferent numeric values, change, and delete them => SUCCESS: Things work as expected 2. Make sure rules are loaded correctly when re-entering the circ rules page => SUCCESS: All good 3. Verify the data on the DB is stored as it should on each of your tests: $ koha-mysql kohadev > SELECT * FROM circulation_rules \ WHERE rule_name='article_request_fee'; => SUCCESS: All good (remember NULL => 'All' in the UI) 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:18:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:18:26 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129144|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize --- Created attachment 129174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129174&action=edit Bug 27946: Article request fee methods in Koha::Patron This patch adds article_request_fee() and add_article_request_fee_if_needed() methods to Koha::Patron. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:18:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:18:31 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129145|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize --- Created attachment 129175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129175&action=edit Bug 27946: Make Koha::ArticleRequest->request add a fee if required This patch makes the ->request method add a fee for the patron if required. It relies on methods defined in Koha::Patron for the task. The debit line is linked to the AR if applies. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:18:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:18:36 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129146|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize --- Created attachment 129176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129176&action=edit Bug 27946: Add UI handling of AR fees This patch: - Adds a notice about the fee to be charged to the patron (staff and OPAC) - Adds the right UI description for ARTICLE_REQUEST_FEE debit types in the UI. To test: 1. Have some article request fee rules 2. Play with placing an article request in OPAC and staff => SUCCESS: You see a message about the fee => SUCCESS: The fees are correctly applied to the patron 3. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:18:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:18:40 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129147|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize --- Created attachment 129177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129177&action=edit Bug 27946: (QA follow-up) Remove 'scan' terminology, requests may not be scans Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:20:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:20:51 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #82 from Martin Renvoize --- A nice simplification here, good plan splitting the cancellation stuff into it's own bug. I'd have loved to have seen this at the item type level rather than just at patron category/library branch level.. certainly that would be the use case in the UK. But.. it all works as designed right now for me, doesn't cause any regressions and is well tested. QA scripts are happy too.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:23:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:23:56 +0000 Subject: [Koha-bugs] [Bug 29819] New: Allow setting AR fees at item type level Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29819 Bug ID: 29819 Summary: Allow setting AR fees at item type level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 27946 introduced circulation rules to allow charging for article requests. It was done by relying on circulation rules on a per-branch and category basis. It would be great to define it at item type level as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:24:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:24:02 +0000 Subject: [Koha-bugs] [Bug 29819] Allow setting AR fees at item type level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29819 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 [Bug 27946] Add a charge per article request to patron categories -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:24:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:24:02 +0000 Subject: [Koha-bugs] [Bug 27946] Add a charge per article request to patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27946 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29819 [Bug 29819] Allow setting AR fees at item type level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:24:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:24:17 +0000 Subject: [Koha-bugs] [Bug 29819] Allow setting AR fees at item type level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29819 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:28:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:28:41 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129150|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 129178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129178&action=edit Bug 29757: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:28:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:28:45 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129151|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 129179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129179&action=edit Bug 29757: Add filters for reversable offsets This patch adds filtering methods for (non)reversable offsets. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Account/Offsets.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:28:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:28:49 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129152|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 129180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129180&action=edit Bug 29757: (QA follow-up) POD fixes This patch adds POD, fixes the existing one in the file, and also renames reversable => reversible as required by the QA scripts. If this name change is problematic, I can revert it and resubmit my follow-up. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:29:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:29:13 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 --- Comment #10 from Martin Renvoize --- All looks good to me, adding my accounts hat stamp here too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:30:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:30:43 +0000 Subject: [Koha-bugs] [Bug 28677] Add the word "calendar" to the description for ExpireReservesOnHolidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28677 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual-updated CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:38:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:38:33 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129162|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 129181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129181&action=edit Bug 29759: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:38:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:38:36 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129163|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 129182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129182&action=edit Bug 29759: Make cancelling an AR refund This patch makes the Koha::ArticleRequest->cancel method perform a refund if it applies. The sequence is: - Find refundable (potentially partial) payments against the fee - Generate a refund for the refundable amount - Reduce the fee to zero => RESULT: the patron owes nothing, any credits applied to the debit are refunded. 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => FAIL: Nothing is refunded 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Refunds take place! 5. Try on the UI => SUCCESS: All good 6. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:39:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:39:54 +0000 Subject: [Koha-bugs] [Bug 29819] Allow setting AR fees at item type level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29819 --- Comment #1 from Tomás Cohen Arazi --- Questions: - Do we need a fulfillment step at checkin? i.e. if an item that can fulfill the request is scanned, then it is informed to the staff, and assigned to the AR. - In that case, wouldn't it make more sense to charge the fee when the AR is 'accepted'? Because if you have a default fee for the biblio-level itype, and then the staff assigns a specific item, then the fee may differ? - I understand not all AR need to be fulfilled by specific items, because the library might have already scanned things. In that case, how it should behave? Maybe for another bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:43:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:43:09 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #75 from Katrin Fischer --- Could we do something like an overwrite option? We use the default descriptions when the lib/lib_opac are empty and we use the description of those, if they are set? The other things is me wondering if using authorized value would not only be a temporary solution, making it necessary soon to move debarment types to their own table to be more flexible with configuration. In this case we could have a column for the description too - it would be even a little easier. And we could then develop the table further to have more columns that make the behavior of a debarment more granular (block renewals, block issuing, block holds, which category types can it be applied to, etc.). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:54:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:54:38 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:54:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:54:42 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129130|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 129183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129183&action=edit Bug 29806: Regression tests Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:54:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:54:46 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129131|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 129184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129184&action=edit Bug 29806: Call ->as_list for ->pickup_locations on request.pl Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:54:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:54:50 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129132|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 129185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129185&action=edit Bug 29806: Fix POST /holds use of pickup_locations This patch makes Koha::Item->pickup_locations and Koha::Biblio->pickup_locations explicitly call ->as_list in list context. This way we workaround bug 28871. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail, the route gives a 500 (unhandled exception) 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass, the route correctly returns a 400 with a message about the pickup location being invalid 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:54:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:54:55 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #12 from Jonathan Druart --- Created attachment 129186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129186&action=edit Bug 29806: (follow-up) Call ->as_list for ->pickup_locations on request.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:56:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:56:27 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #7 from Martin Renvoize --- hmm.. I'm still not 100% sure of this. Scenario 1 1. Article request placed, fee added 2. Article request cancelled, fee cancelled (currently appears as a refund) Scenario 2 1. Article request placed, fee added 2. Patron pays full amount 3. Article request cannot be fulfilled so is cancelled 4. Paid fee is refunded.. I feel like this should be linked to the 'payment' rather than the original 'charge' ? Scenario 3 1. Article request placed, fee added 2. Patron pays some amount 3. Article request is cancelled 4. Patron is 'refunded' the amount paid (but it links to the charge, not the payment) 5. Patron is also 'refunded' the outstanding amount (again, links to the charge) I think these could end up rather confusing in the accounts screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:57:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:57:11 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #8 from Martin Renvoize --- This gives us an opportunity to create something consistent for lost item charge refunds too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 15:59:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 14:59:04 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #7) > hmm.. I'm still not 100% sure of this. > > Scenario 1 > 1. Article request placed, fee added > 2. Article request cancelled, fee cancelled (currently appears as a refund) > > Scenario 2 > 1. Article request placed, fee added > 2. Patron pays full amount > 3. Article request cannot be fulfilled so is cancelled > 4. Paid fee is refunded.. I feel like this should be linked to the 'payment' > rather than the original 'charge' ? > > Scenario 3 > 1. Article request placed, fee added > 2. Patron pays some amount > 3. Article request is cancelled > 4. Patron is 'refunded' the amount paid (but it links to the charge, not the > payment) > 5. Patron is also 'refunded' the outstanding amount (again, links to the > charge) > > I think these could end up rather confusing in the accounts screen. Nice catch! I think it is clear this needs to point to the payment! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:03:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:03:49 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #26 from Jonathan Druart --- All good for me, however I would remove the comments you added in the kohastructure.sql. We usually don't adjust the comment in the atomic update, so people we still hve the TODO even if we fix the name of the column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:05:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:05:32 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:05:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:05:36 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128655|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 129187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129187&action=edit Bug 29336: Identify the fields with wrong length (or name) first This report will fix the bad lengths first. And mark the 'bad' names with a TODO for follow-up. Bad name means: refers to value, should be category. Scanning kohastructure.sql. Note: Bug 29347 has been opened to fix the names. Test plan: Search for another AV category field with length<>32. Bonus: Reinstall and check database. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:05:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:05:41 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128656|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 129188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129188&action=edit Bug 29336: Database revision Resizes the six fields identified earlier: additional_fields.authorised_value_category 16=>32 auth_subfield_structure.authorised_value 10=>32 auth_tag_structure.authorised_value 10=>32 club_template_enrollment_fields.authorised_value_category 16=>32 club_template_fields.authorised_value_category 16=>32 marc_tag_structure.authorised_value 10=>32 Test plan: Run dbrev, check database. Bonus: Connect an AV category with a long name to a authority subfield. Check if you see its values in the authority editor. (This was the way I found the problem.) Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:05:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:05:49 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #29 from Jonathan Druart --- Created attachment 129189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129189&action=edit Bug 29336: Remove TODOs Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:09:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:09:58 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WORKSFORME --- Comment #56 from Tomás Cohen Arazi --- Let's close this one, and focus on removing the use of wantarray in Koha::Objects instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:09:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:09:58 +0000 Subject: [Koha-bugs] [Bug 28886] Remove uses of ->as_list from the codebase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28886 Bug 28886 depends on bug 28883, which changed state. Bug 28883 Summary: Koha::Objects->_new_from_dbic doesn't work correctly in list context https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:10:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:10:32 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |WORKSFORME --- Comment #23 from Tomás Cohen Arazi --- Let's close this one, and focus on removing the use of wantarray in Koha::Objects instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:10:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:10:32 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Bug 24857 depends on bug 28871, which changed state. Bug 28871 Summary: Koha::Objects->empty doesn't work correctly in list context https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:11:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:11:36 +0000 Subject: [Koha-bugs] [Bug 28871] Koha::Objects->empty doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24857 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:11:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:11:36 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28871 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28871 [Bug 28871] Koha::Objects->empty doesn't work correctly in list context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:12:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:12:04 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:21:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:21:55 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #8 from Jonathan Druart --- Unit tests are missing. Note that you could simply have a 1 line patch with: waitingdate => $self->waitingdate || $today->ymd, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:23:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:23:28 +0000 Subject: [Koha-bugs] [Bug 29751] [DOCS] Document how linking from Koha to the manual works In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29751 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:30:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:30:17 +0000 Subject: [Koha-bugs] [Bug 28332] Requesting Mana token with accented name fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28332 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #10 from Jonathan Druart --- Alex, I've tried with "✔ ❤ ★" and I get an error from the server: "An error occurred, mana server returned: Internal Server Error". Do you have access to the test server to investigate what's happening? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:35:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:35:42 +0000 Subject: [Koha-bugs] [Bug 29820] New: Print summary just show 20 items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Bug ID: 29820 Summary: Print summary just show 20 items Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mhby87 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 129190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129190&action=edit List print summary After upgrade from 21.05 to 21.11, print summary for check out items just show 20 rows only. For example, patron borrow 500 item, but print summary show 20 items list. How to show all check out items in patron print summary. Thank you -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:41:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:41:31 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #1) > This has no effect as it is not causing problems. But. But? It's not needed if it's the last statement of the block. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:41:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:41:54 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:41:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:41:59 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129129|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 129191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129191&action=edit Bug 29813: Add missing semicolon in skeleton.pl This has no effect as it is not causing problems. But. Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:42:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:42:20 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 --- Comment #5 from Jonathan Druart --- It's not a bug IMO, but don't want to argue more than 5 seconds here :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:43:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:43:29 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:43:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:43:33 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128940|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 129192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129192&action=edit Bug 29758: Get rid of warning in members/boraccount.pl This patch removes a noisy warning found in production logs. To test: 1. Run: $ tail -f /var/log/koha/kohadev/plack-intranet-error.log 2. Open the 'Accounting' tab for a patron, then click on 'Transactions' => FAIL: You see this kind of warning in the logs: [WARN] CGI::param called in list context from... 3. Apply this patch 4. Repeat 2 (change tab and go back) => SUCCESS: No more warning! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:55:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:55:17 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:55:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:55:22 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128911|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 129193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129193&action=edit Bug 18320: Remove patroncards/edit-layout.pl warnings This patch removes warnings generated by the script itself. To test: - Go to Tools › Patron card creator › Manage layouts and Tools › Patron card creator › New layout - Add a new layout, adit existing. => FAIL: Warnings logged by edit-layout.pl - Apply this patch - Go to Tools › Patron card creator › Manage layouts and Tools › Patron card creator › New layout - Add a new layout, adit existing. => SUCCESS: No warnings generated by edit-layout.pl - Sign off :-D Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:55:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:55:28 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128912|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 129194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129194&action=edit Bug 18320: Remove calls to CGI->param from the templates in patron cards This patch removes calls to CGI->param from within the templates (patroncards-errors.inc) and passes error_* variables with the same codes from the controllers to the template instead. This way we can be sure CGI->param is not called in list context. To test, try those pages and see they don't show warnings anymore. Verify that error situations still show the error messages. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:55:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:55:47 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 16:58:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 15:58:52 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Summary|Add barcode width and |Add barcode size parameters |height parameters to |to /svc/barcode |/svc/barcode | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:04:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:04:21 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:04:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:04:28 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:13:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:13:32 +0000 Subject: [Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129096|0 |1 is obsolete| | --- Comment #6 from The Minh Luong --- Created attachment 129195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129195&action=edit Bug 29616: Replace library information popup in the OPAC with a modal This patch modifies the OPAC bibliographic detail page so that information stored in libraries' "OPAC info" field can be displayed in a modal window instead of in a tooltip. This will make it more readable, especially for libraries with so much info content that the popup can disappear off the bottom of the page. To test, apply the patch and make sure you have at least one library configured according to each of these: A. One with both branches.branchurl and branches.opac_info B. One with branches.branchurl but not branches.opac_info C. One with branches.opac_info but not branches.branchurl D. One with neither branches.branchurl nor branches.opac_info View the bibliographic detail page in the OPAC for title(s) which have holdings from the libraries you configured above. In the holdings table, check the behavior of the library name in the "Current library" or "Home library" columns * - Case A: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer, a "Visit web site" button should take you to the correct URL. - Case B: The library name appears as a link without an icon. Clicking the link takes you to the correct URL. - Case C: The library name appears as a link with an "info" icon. Clicking it shows the library information in a modal window. In the modal footer there is no "Visit web site" button. - Case D: The library name is plain text. * Display of "Current library" and/or "Home library" is controlled by the OpacLocationBranchToDisplay system preference. Signed-off-by: Lucas Gass Signed-off-by: The Minh Luong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:19:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:19:03 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128581|0 |1 is obsolete| | --- Comment #3 from The Minh Luong --- Created attachment 129196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129196&action=edit Bug 29706: Hide items that cannot be held by default when placing hold on OPAC This patch adds a 'holdable' and 'unholdable' class to the rows of the table Additionally I rename the 'backgroundcolor' field to 'onloan' as that is what it contains. Note: Out of the box, there is no css associated with this class I add a div around the table to allow hiding the new buttons as well when optiuons are hidden It would be nice in the future to utilise a Koha table here, however, it is complicated by multi-holds To test: 1 - Add a number of items to a record, ensuring they belong to different libraries 2 - Set 'Default checkout, hold and return policy'->'Hold policy' to 'From home library' 3 - Sign in to opac and attempt to placehold on the record 4 - Click 'show more options' and 'a specificitem' 5 - Note holds table includes items that cannot be held 6 - Apply patch 7 - Reload holds page 8 - Note items that cannot be heldare hidden 9 - Click 'Show unholdable items' and note they appear 10 - Click 'Hide unholdable items' and veriofy they hide 11 - Test with multi holds Signed-off-by: The Minh Luong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:22:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:22:36 +0000 Subject: [Koha-bugs] [Bug 29576] Add streetype to fields which can be copied from guarantor to guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128248|0 |1 is obsolete| | --- Comment #2 from The Minh Luong --- Created attachment 129197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129197&action=edit Bug 34874: Add streettype and B_streettype to PrefillGuaranteeField To test : 1) modify PrefillGuaranteeField system preference 2) road type for main and alternate addresses aren't in the list 3) Apply patch 4) Redo 1, now they are https://bugs.koha-community.org/show_bug.cgi?id=29576 Signed-off-by: The Minh Luong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:25:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:25:42 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:25:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:25:45 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 --- Comment #2 from Owen Leonard --- Created attachment 129198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129198&action=edit Bug 20894: Add barcode size parameters to /svc/barcode This patch adds a couple of new parameters to the barcode generator service: "modulesize," which controls the size of QRcodes*, and "height," which can be applied to all other barcode types. * The "modulesize" number refers to the pixel dimensions of each black and white square in the generated QRcode. The dimensions in "squares" of the QR code depends on how much data is being encoded. For QRcodes, one default parameters is used: An error-correction level of "M" (Medium, https://en.wikipedia.org/wiki/QR_code#Error_correction). To test, apply the patch and restart services. Test various settings to confirm that barcodes are displayed correctly: http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=QRcode&modulesize=3&barcode=https%3A%2F%2Fkoha-community.org http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=QRcode&modulesize=6&barcode=https%3A%2F%2Fkoha-community.org http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Code39&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Code39&height=20&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=COOP2of5&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=IATA2of5&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Industrial2of5&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=ITF&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=Matrix2of5&height=50&barcode=32000000203734 http://127.0.0.1:8081/cgi-bin/koha/svc/barcode?type=NW7&height=50&barcode=32000000203734 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:37:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:37:04 +0000 Subject: [Koha-bugs] [Bug 29821] New: Add interface for generating barcodes using svc/barcode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29821 Bug ID: 29821 Summary: Add interface for generating barcodes using svc/barcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: barton at bywatersolutions.com, testopia at bugs.koha-community.org Depends on: 20894 Created attachment 129199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129199&action=edit Screenshot showing the proposed interface svc/barcode is a hidden feature without an web interface for testing its features. To give users the information they need to be able to integrate barcodes into, for instance, notices, we should offer an interface for testing the output of barcode generation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 [Bug 20894] Add barcode size parameters to /svc/barcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:37:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:37:04 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29821 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29821 [Bug 29821] Add interface for generating barcodes using svc/barcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:38:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:38:44 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:50:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:50:25 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the length of release notes| |the field definitions in | |the database for several | |authorised_value and | |authorised_value_category | |columns as they are too | |short. It changes the value | |to varchar(32). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 17:58:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 16:58:40 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #32 from Jonathan Druart --- Created attachment 129200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129200&action=edit Bug 29043: [ALTERNATIVE PATCH] Don't fetch biblios info unless a patron is picked If we haven't picked a patron or a club yet we don't need to fetch biblios, items and holdability infos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:02:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:02:19 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #33 from Jonathan Druart --- I am late here and I was not aware of these patches when I wrote bug 29660. I have tried to rebase bug 29660 on top of this but it's very tricky. This patch is suggesting to do the minimum required to not fetch the infos if we don't need to (no club or patron selected). Please read this patch with `git show -w HEAD` and you will notice there are only ~10 lines. It will help a lot if we can move forward with this version as I will be able to rebase easily bug 29660 on top of it. I haven't stressed the patch much but the simple use cases work so far. Will be back to it next week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:02:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:02:58 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #34 from Jonathan Druart --- @ reserve/request.pl:201 @ $template->param( multi_hold => $multi_hold, ); +# If we are coming from the search result and only 1 is selected +$biblionumber ||= $biblionumbers[0] unless $multi_hold; # If we have the borrowernumber because we've performed an action, then we # don't want to try to place another reserve. if ($borrowernumber_hold && !$action) { @ reserve/request.pl:299 @ $template->param( messageclub => $messageclub ); +if ( $club_hold or $borrowernumber_hold ) { # FIXME launch another time GetMember perhaps until (Joubu: Why?) my $patron = Koha::Patrons->find( $borrowernumber_hold ); @ reserve/request.pl:692 @ foreach my $biblionumber (@biblionumbers) { push @biblioloop, \%biblioloopiter; } $template->param( biblioloop => \@biblioloop ); $template->param( no_reserves_allowed => $no_reserves_allowed ); -$template->param( biblionumbers => join('/', @biblionumbers) ); $template->param( exceeded_maxreserves => $exceeded_maxreserves ); $template->param( exceeded_holds_per_record => $exceeded_holds_per_record ); $template->param( subscriptionsnumber => CountSubscriptionFromBiblionumber($biblionumber)); +} elsif ( ! $multi_hold ) { + my $biblio = Koha::Biblios->find( $biblionumber ); + $template->param( biblio => $biblio ); +} +if ( $multi_hold ) { + $template->param( biblionumbers => join('/', @biblionumbers) ); +} else { + $template->param( biblionumber => $biblionumber || $biblionumbers[0] ); +} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:04:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:04:07 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29043 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:04:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:04:07 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29660 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 [Bug 29660] reserve/request.pl should not deal with biblioitem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:04:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:04:14 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:04:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:04:59 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 [Bug 29136] Patron search on request.pl has performance and display issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:04:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:04:59 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29660 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 [Bug 29660] reserve/request.pl should not deal with biblioitem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:05:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:05:47 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 [Bug 29562] CanItemBeReserved should take patron and item objects as parameters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:05:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:05:47 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29660 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 [Bug 29660] reserve/request.pl should not deal with biblioitem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:36:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:36:28 +0000 Subject: [Koha-bugs] [Bug 29711] Release date not passed as ISO to about.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- I can't replicate this on master and using KTD. Does this only apply for a specific version? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:38:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:38:02 +0000 Subject: [Koha-bugs] [Bug 29821] Add interface for generating barcodes using svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29821 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:38:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:38:05 +0000 Subject: [Koha-bugs] [Bug 29821] Add interface for generating barcodes using svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29821 --- Comment #1 from Owen Leonard --- Created attachment 129201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129201&action=edit Bug 29821: Add interface for generating barcodes using svc/barcode This patch adds a new page providing an interface for generating barcodes using svc/barcode. A form allows the user to choose various parameters and see the resulting barcode image. To test, apply the patch and rebuild the staff interface SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to the "Tools" home page. Follow the link to "Barcode image generator." - On the barcode image generator page, confirm that there is a "Barcode image generator" link in the sidebar and that it is displayed with bold text. - Test the features of the form: - Enter a numeric value in the "Barcode" field and tab out of the field or click "Show barcode" button. A barcode of type "Code39" should be shown with the text of the barcode included in the image below the barcode. - A text area below the barcode image should show the HTML used to generate the preview image. - Clicking in this textarea should automatically add the contents to the clipboard. You should be shown a message, "HTML copied to the clipboard." - Check the "hide text" checkbox. The barcode should be redisplayed without the text. - Check that changing the "barcode height" value is reflected correctly in the barcode image. - Try adding non-numeric data in the "Barcode" field. You should be shown an error message, "Barcodes of type [type] must be numeric." - Test these other numeric barcode types: Code39, COOP2of5, EAN13, EAN8, IATA2of5, Industrial2of5, ITF, Matrix2of5, NW7, UPCA, and UPCE. Note that EAN13, EAN8, UPCA, and UPCE expect specific patterns. Test values (found here: https://barcode.tec-it.com/en/UPCE): EAN13: 978020137962 EAN8: 9031101 UPCA: 72527273070 UPCE: 0123456 - Change the barcode type to "QRcode." - The form should change, hiding the "Hide text" checkbox and showing a new ranger slider for "QR Code module size." - The barcode field should now be labeled "Text, URL, or barcode, etc" - The barcode field hint should change to a hint about QRcode dimensions. - Changing the "module size" slider should change the size of the generated QR code. As you change the slider the selected value should be reflected in the box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 18:45:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 17:45:23 +0000 Subject: [Koha-bugs] [Bug 29822] New: Add checkboxes to the system preference DefaultPatronSearchFields to eliminate errors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Bug ID: 29822 Summary: Add checkboxes to the system preference DefaultPatronSearchFields to eliminate errors Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com As Koha did with system preferences such as borrower mandatory fields and borrower unwanted fields, it would be helpful and avoid searching errors if the system preference, DefaultPatronSearchFields would also use checkboxes. These checkboxes will allow users to easily choose which fields Koha should use for searching. Currently, if a user puts a value in this field that is not valid, searching for patrons will be broken. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 19:18:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 18:18:44 +0000 Subject: [Koha-bugs] [Bug 29823] New: Prohibit the same borrowerfield to be checked in the conflicting system preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29823 Bug ID: 29823 Summary: Prohibit the same borrowerfield to be checked in the conflicting system preferences Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There are two system preferences for determining what fields show and don't show during self-registration. It would be nice when a library chose a "mandatory" field in the mandatory sys preference, that this field would not be available to check in the "unwanted" field option and vice versa. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 19:20:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 18:20:10 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #13 from Tomás Cohen Arazi --- Hi! Thanks for the follow-up. Strictly speaking, Koha::Biblios->pickup_locations IS list context aware so this wouldn't be needed. I skipped it because of that reason, but that was before I wrote to koha-devel with my suggestion that we call ->as_list explicitly all the time. So, this patch is welcome and good to be included! (In reply to Jonathan Druart from comment #12) > Created attachment 129186 [details] [review] > Bug 29806: (follow-up) Call ->as_list for ->pickup_locations on request.pl > > Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 19:20:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 18:20:21 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 19:20:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 18:20:44 +0000 Subject: [Koha-bugs] [Bug 29823] Prohibit the same borrowerfield to be checked in the conflicting system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29823 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 19:35:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 18:35:08 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #20 from Tomás Cohen Arazi --- Is there room for different storage backends here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 19:41:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 18:41:36 +0000 Subject: [Koha-bugs] [Bug 28201] Add API routes to create biblio record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28201 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Tomás Cohen Arazi --- I like where this is going, but I think this needs some more thinking. In my opinion: - The request body should include the raw record - Content/Type should tell the controller how it should handle the raw record in terms of serialization format (i.e. application/marcxml+xml, application/marc-in-json, etc) - The framework should be passed as a header. I propose x-koha-cataloguing-fw to ease your work. - We still need the 'biblio_metadata.schema' attribute, put it in some header as well: x-koha-metadata-schema. Let me know if you will have time to do it. This is a nice goal for 22.05 :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 19:45:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 18:45:28 +0000 Subject: [Koha-bugs] [Bug 29823] Prohibit the same borrowerfield to be checked in the conflicting system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29823 --- Comment #1 from Kelly McElligott --- Or a warning that requested settings may be conflicting between x and y sys prefs? I see that this could be the case outside of even self-registration, like borrower mandatory and borrower wanted system preferences also. It would be nice if this was consistent with these coupled system preferences BorrowerUnwantedField BorrowerMandatoryField PatronSelfRegistrationBorrowerUnwantedField PatronSelfRegistrationBorrowerMandatoryField -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 20:17:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 19:17:13 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add checkboxes to the |Use table column selection |system preference |modal for |DefaultPatronSearchFields |DefaultPatronSearchFields |to eliminate errors |preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 20:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 19:31:26 +0000 Subject: [Koha-bugs] [Bug 28450] Make Account summary print tables configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29820 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 [Bug 29820] Print summary just show 20 items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 20:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 19:31:26 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master Severity|enhancement |normal Depends on| |28450 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 [Bug 28450] Make Account summary print tables configurable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 20:33:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 19:33:17 +0000 Subject: [Koha-bugs] [Bug 28876] No renewal before advisory text not wrapped in selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28876 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds more release notes| |s to the user summary | |page in the OPAC so that | |information about the | |renewal status can be | |targeted with CSS or JS. It | |adds each with a | |"usr-msg" class for general | |styling and a specific | |class for each renewal | |message, for example: | | | |Not | |renewable (on | |hold) | | | |These | |classes are added: | | | |- | |no-renew-hold: Not | |renewable (on hold) | |- | |no-renew-too-many: Not | |renewable (too many | |renewals) | |- | |no-renew-unseen: Item must | |be renewed at the library | |- | |no-renew-overdue: Not | |allowed (overdue) | |- | |no-renew-too-late: No | |longer renewable | |- | |auto-renew-fines: Automatic | |renewal failed, you have | |unpaid fines | |- | |auto-renew-expired: | |Automatic renewal failed, | |your account is expired | |- | |no-renewal-before: No | |renewal before [date] | |- | |automatic-renewal: | |Automatic renewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 20:33:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 19:33:44 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 20:47:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 19:47:46 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 20:47:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 19:47:49 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 --- Comment #1 from Owen Leonard --- Created attachment 129202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129202&action=edit Bug 29820: Set paging option using boolean instead of string Bug 28450, "Make Account summary print tables configurable," added DataTables to the print summary view. The updated page includes the wrong option: "paging": "false", It should be: "paging": false, Because DataTables expects that option to be boolean (true or false). To test, apply the patch and check out to a patron who has more than 20 checkouts and more than 20 holds. - From the toolbar, click Print -> Print summary. - On the acount summary page, confirm that the "Items checked out" and "Pending holds" tables show ALL entries, not just the first 20. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 20:52:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 19:52:13 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #76 from Martin Renvoize --- (In reply to Katrin Fischer from comment #75) > Could we do something like an overwrite option? > > We use the default descriptions when the lib/lib_opac are empty and we use > the description of those, if they are set? > Nope, that would still break translations as Jonathan suggests. The issue is that you cant define that default for each language.. only a single language. > The other things is me wondering if using authorized value would not only be > a temporary solution, making it necessary soon to move debarment types to > their own table to be more flexible with configuration. In this case we > could have a column for the description too - it would be even a little > easier. This development doesn't use AV's specifically for the reasons you suggest. > > And we could then develop the table further to have more columns that make > the behavior of a debarment more granular (block renewals, block issuing, > block holds, which category types can it be applied to, etc.). I've been waiting years for the AV translations proof work to work their way through.. their holding up a whole plethora of bugs including this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 21:14:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 20:14:40 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #2 from Tomás Cohen Arazi --- I love this, but breaks the API and I couldn't easily find why. To reproduce the failure: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail with a 500. What I found using Postman: - $biblio_id is not always defined in the call to AddReserve, should be using $biblio->id instead - This were the first tests we wrote for the API, and are super weird, including the DELETE FROM reserves. Maybe is a problem with the tests themselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 21:28:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 20:28:37 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Being bold here and upgrading Tomas's signoff to QA. There aren't many people capable of testing ILL to the degree Tomas clearly has.. and we're using this in production already here ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 21:28:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 20:28:48 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 --- Comment #7 from Martin Renvoize --- Being bold here and upgrading Tomas's signoff to QA. There aren't many people capable of testing ILL to the degree Tomas clearly has.. and we're using this in production already here ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 21:32:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 20:32:27 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to Patron Card Creator - Patron Search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #4 from The Minh Luong --- Created attachment 129203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129203&action=edit Bug 28726 - Add sort1 and sort2 to patron card creator - patron search. Also adds a select all / clear all and checkboxes. Signed-off-by: The Minh Luong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 21:37:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 20:37:39 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from Wrong Transfer checkin are not sent if modal is dismissed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 --- Comment #6 from Martin Renvoize --- Leaving a note to self for when I QA properly next week. Why are we changing the signature for request_transfer here? The idea was to keep the methods singularly focused with defined exceptions. In short, shouldn't we be chaining the returned trans ft er request with a call to transit... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 21:42:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 20:42:45 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #7) > Being bold here and upgrading Tomas's signoff to QA. > > There aren't many people capable of testing ILL to the degree Tomas clearly > has.. and we're using this in production already here ;) I agree. I hesitated because of the issue I was seeing on my backend, but it turned out it was because of a bad override if REQ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 22:03:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 21:03:04 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #77 from Katrin Fischer --- I thought we could do it similar to account types, just with the addition of allowing to overwrite the standard description. If the overwrite is empty, we use what is in the templates. So we could keep the standard ones translatable. For the table vs AV - I was didn't read far enough - sorry. But... if we are no longer translating an AV... shoudl this not be a little easier in terms of 'hugeness' of development? Maybe it would be easier to start here doing something similar than we have for itemtypes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 22:08:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 21:08:56 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 22:15:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 21:15:06 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 22:47:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 21:47:32 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when receiving serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 22:47:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 21:47:35 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when receiving serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129127|0 |1 is obsolete| | --- Comment #4 from Samu Heiskanen --- Created attachment 129204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129204&action=edit Bug 29815: Pre-fill 952$d (Date acquired) when receiving serial items Test plan: 1. Create a subscription - Select the 'Create an item record when receiving this serial' 2. Receive the serial 3. After changing the status from 'Expected' to 'Arrived' notice that the 'd - Date acquired' is not set until you click on that field 4. Apply patch and restart services 5. Receive the serial again and notice this time today's date is pre-populated in 'd - Date acquired' Sponsored-By: Brimbank Library, Australia Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 22:48:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 21:48:50 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the-minh.luong at inlibro.com --- Comment #3 from The Minh Luong --- (In reply to Lucas Gass from comment #2) > Created attachment 129047 [details] [review] > Bug 29760: Show patron category on view_holdsqueue.tt > > To test: > 1. Have some holds and build the holds queue. > 2. Go to view_holdsqueue.tt, there is no patron category > 3. Apply patch > 4. Look again, you can now see the patron category in the patron column I tested and the patch seems to work according to the test plan. However, I think that it would be better to have a Patron Category column, instead of having the patron category inside the patron column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 23:30:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 22:30:25 +0000 Subject: [Koha-bugs] [Bug 29824] New: Allow for quick spine labels to be editable for printing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29824 Bug ID: 29824 Summary: Allow for quick spine labels to be editable for printing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be handy if you could edit quick spine labels after you generate them. In some case you may want to remove to character or add a line break. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 23:36:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 22:36:46 +0000 Subject: [Koha-bugs] [Bug 29824] Allow for quick spine labels to be editable for printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29824 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 23:36:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 22:36:49 +0000 Subject: [Koha-bugs] [Bug 29824] Allow for quick spine labels to be editable for printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29824 --- Comment #1 from Lucas Gass --- Created attachment 129205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129205&action=edit Bug 29824: Allow editing of quick spine labels To test: 1. Apply patch 2. Go to the quick spine label tool and enter a barcode of an item with a itemcallnumber 3. Notice the 'Edit this label' button at the bottom of the page, click it 4. Edit the itemcallnumber in some way: add some line breaks, remove some, insert some new characters, remove some characters. 5. You can now print the label with your edits. Note: This changes nothing in the database, if you relaod the same item/itemcallnumer it will have returned to its original form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 23:37:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 22:37:33 +0000 Subject: [Koha-bugs] [Bug 29824] Allow for quick spine labels to be editable for printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29824 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds the ability to edit release notes| |quick spine labels after | |they have been generated. Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 23:41:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 22:41:56 +0000 Subject: [Koha-bugs] [Bug 29824] Allow for quick spine labels to be editable for printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29824 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 23:50:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 22:50:55 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at dataly.gr Assignee|timothy_alexis.vass at ub.lu.s |gveranis at dataly.gr |e | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 23:54:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 22:54:02 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Adds a column to the search |Adds an new action to the release notes|results to show a MARC |authority search results to |preview in a modal window |show a MARC preview in a |on the same page. |modal window on the same | |page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 23:59:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 22:59:51 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 7 23:59:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 22:59:55 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 --- Comment #6 from George Veranis --- Created attachment 129206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129206&action=edit Bug 28247: (folow up) Add a MARC preview action to Authority search results To test: 1) Do an authority search 2) On Actions button click to see the available actions and click on "MARC preview" action. 3) A modal window open and confirm that the correct details are shown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 00:07:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 23:07:42 +0000 Subject: [Koha-bugs] [Bug 11442] Show dashes (--) between Subject (Marc 6XX) subfields in authority cataloging plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11442 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 00:30:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 23:30:08 +0000 Subject: [Koha-bugs] [Bug 20615] add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #1 from George Veranis --- Hi Patrick, That you asked as a bug it seems that on the latest version of Koha has already be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 00:32:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 23:32:08 +0000 Subject: [Koha-bugs] [Bug 20615] add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #2 from George Veranis --- Created attachment 129207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129207&action=edit The screenshot shows that on edit mode it has the number of records are connected to the authority record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 00:33:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 23:33:14 +0000 Subject: [Koha-bugs] [Bug 20615] add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Assignee|gveranis at dataly.gr |koha-bugs at lists.koha-commun | |ity.org Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 00:38:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 23:38:30 +0000 Subject: [Koha-bugs] [Bug 15723] Add preview marc in authority results authorities-home.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15723 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |gveranis at dataly.gr --- Comment #1 from George Veranis --- *** This bug has been marked as a duplicate of bug 28247 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 00:38:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 23:38:30 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca --- Comment #7 from George Veranis --- *** Bug 15723 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 00:42:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Jan 2022 23:42:41 +0000 Subject: [Koha-bugs] [Bug 29825] New: Preview of authority record on edit mode as MARC formatted view Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 Bug ID: 29825 Summary: Preview of authority record on edit mode as MARC formatted view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: gveranis at dataly.gr QA Contact: testopia at bugs.koha-community.org While a librarian is cataloguing an authority record by using the framework cannot check the full view of the record in MARC structure way before saving. That patch will add a new action on edit mode in order to show on a new window a preview of MARC record that will be saved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:06:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:06:03 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 --- Comment #25 from Fridolin Somers --- (In reply to Jonathan Druart from comment #24) > I volunteered at the time to adjust before push, I was RM. > I can help if you want, but it's trivial to switch from the old to the new > version. OK I'll do it also. Just wanted a confirmation :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:06:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:06:12 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:09:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:09:05 +0000 Subject: [Koha-bugs] [Bug 27033] Add plugin hook to add a big link in staff home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27033 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #11 from Fridolin Somers --- Sure, lets close *** This bug has been marked as a duplicate of bug 27527 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:09:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:09:05 +0000 Subject: [Koha-bugs] [Bug 27527] Plugin hooks to create additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27527 --- Comment #5 from Fridolin Somers --- *** Bug 27033 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:30:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:30:10 +0000 Subject: [Koha-bugs] [Bug 29454] Stash itemtypes in plugin objects to reduce DB calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Stash branches and |Stash itemtypes in plugin |itemtypes in plugin objects |objects to reduce DB calls |to reduce DB calls | CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:31:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:31:35 +0000 Subject: [Koha-bugs] [Bug 29454] Stash itemtypes in plugin objects to reduce DB calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454 --- Comment #7 from Fridolin Somers --- Maybe add an early return q{} if itemtypecode is undefined, to avoid warning in concatenation : my $cache_key = $want_parent ? "Itemtype_parent_description:".$itemtypecode : "Itemtype_description:" . $itemtypecode; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:33:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:33:48 +0000 Subject: [Koha-bugs] [Bug 29826] New: Remove warning in t/db_dependent/Template/Plugin/Branches.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Bug ID: 29826 Summary: Remove warning in t/db_dependent/Template/Plugin/Branches.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 26587 added a concatenation that sends a warning if var is undef : $ prove t/db_dependent/Template/Plugin/Branches.t Use of uninitialized value $branchcode in concatenation (.) or string at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 35. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:34:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:34:02 +0000 Subject: [Koha-bugs] [Bug 29826] Remove warning in t/db_dependent/Template/Plugin/Branches.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |fridolin.somers at biblibre.co | |m Status|NEW |ASSIGNED Depends on| |26587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 [Bug 26587] Cache libraries in Branches TT plugin to improve performance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:34:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:34:02 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 [Bug 29826] Remove warning in t/db_dependent/Template/Plugin/Branches.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:34:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:34:28 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 --- Comment #34 from Fridolin Somers --- (In reply to Tomás Cohen Arazi from comment #32) > This patch introduces a warning on tests: > $ prove t/db_dependent/Template/Plugin/Branches.t > Use of uninitialized value $branchcode in concatenation (.) or string at > /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 35. > > I'm not sure if it is ok to call GetName with no branchcode param. Maybe it > should explode in those cases as it is obviously a bug. I've created Bug 29826 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:35:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:35:24 +0000 Subject: [Koha-bugs] [Bug 29826] Useless warning in t/db_dependent/Template/Plugin/Branches.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove warning in |Useless warning in |t/db_dependent/Template/Plu |t/db_dependent/Template/Plu |gin/Branches.t |gin/Branches.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:37:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:37:20 +0000 Subject: [Koha-bugs] [Bug 29826] Useless warning in t/db_dependent/Template/Plugin/Branches.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 02:37:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 01:37:25 +0000 Subject: [Koha-bugs] [Bug 29826] Useless warning in t/db_dependent/Template/Plugin/Branches.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 --- Comment #1 from Fridolin Somers --- Created attachment 129208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129208&action=edit Bug 29826: Remove warning in t/db_dependent/Template/Plugin/Branches.t Bug 26587 added a concatenation that sends a warning if var is undef : $ prove t/db_dependent/Template/Plugin/Branches.t Use of uninitialized value $branchcode in concatenation (.) or string at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 35. This patch adds an early return empty string when GetName is called without $branchcode Test plan : 1) Run t/db_dependent/Template/Plugin/Branches.t without patch 2) Run with the patch to see warning disappear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 08:43:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 07:43:55 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 --- Comment #2 from Mohd Hafiz Yusoff --- Created attachment 129209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129209&action=edit List print summary after patch Patch tested by me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 08:46:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 07:46:28 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Mohd Hafiz Yusoff changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Mohd Hafiz Yusoff --- Created attachment 129202 [details] [review] Bug 29820: Set paging option using boolean instead of string Bug 28450, "Make Account summary print tables configurable," added DataTables to the print summary view. The updated page includes the wrong option: "paging": "false", It should be: "paging": false, Because DataTables expects that option to be boolean (true or false). To test, apply the patch and check out to a patron who has more than 20 checkouts and more than 20 holds. - From the toolbar, click Print -> Print summary. - On the acount summary page, confirm that the "Items checked out" and "Pending holds" tables show ALL entries, not just the first 20. Signed-off-by: Mohd Hafiz Yusoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 21:42:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 20:42:47 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when receiving serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- I am not sure about this one as it changes the behavior of one item form making it inconsistent with the others in cataloguing and acq. Also, if you leave the date accessioned empty, it is automatically set to today's date without any interaction needed. It's here: https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Item.pm#L117 On the other hand that's not obvious to the user. Maybe we should change the behavior of the other forms as well? Add a hint? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 21:51:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 20:51:01 +0000 Subject: [Koha-bugs] [Bug 27033] Add plugin hook to add a big link in staff home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27033 --- Comment #12 from Katrin Fischer --- I am not sure if the CMS is solving this; I think this was to add new module style links to the start page? And possibly add them to the 'More' menu as well? I think it could still be done with the js hook if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:01:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:01:25 +0000 Subject: [Koha-bugs] [Bug 29827] New: Update or remove outdated README.txt in /etc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29827 Bug ID: 29827 Summary: Update or remove outdated README.txt in /etc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/README.txt It describes some files that don't exist: * koha-production.xml * koha-testing.xml These are the production and testing configurations for zebrasrv and for Koha. The first part of each file specifies Zebra server names, indexing configuration files, and query language configurations. Koha configuration directives follow. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:11:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:11:52 +0000 Subject: [Koha-bugs] [Bug 29751] [DOCS] Document how linking from Koha to the manual works In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29751 --- Comment #1 from Katrin Fischer --- We keep a mapping of every template file with a help link to the section in the manual it links to in https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Manual.pm When new pages are added, this file has to be added to as well. Or when we add more specific documentation of a new feature, maybe the docs team should update the linking as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:16:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:16:36 +0000 Subject: [Koha-bugs] [Bug 29828] New: If no content is added to news/additional content entries, they are silently not saved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Bug ID: 29828 Summary: If no content is added to news/additional content entries, they are silently not saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: Add a new news or HTML customization entry, fill in the title for one or more languages. Leave content empty. Save. The entry hasn't been saved. There is no error and nothing visible in the logs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:27:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:27:01 +0000 Subject: [Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Depends on| |29805 Summary|If no content is added to |If no content is added to |news/additional content |default, but a translation, |entries, they are silently |news/additional content |not saved |entries don't show in list See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29778 --- Comment #1 from Katrin Fischer --- I think I got it now - the problem is a little different, but bad. Updated step by step: 1) Add a new html customization or news entry 2) Fill in the title for default, leave content empty 3) Fill in title and content for English 4) Save 5) Verify the new entry doesn't show in the list of entries 6) Run select idnew, category, code, location, title, lang from additional_contents order by code, lang; 7) Verify your entry is in the database Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:27:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:27:01 +0000 Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:27:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:27:01 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29828 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:29:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:29:05 +0000 Subject: [Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29805 |24387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:29:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:29:05 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:29:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:29:05 +0000 Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29828 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:30:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:30:43 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:30:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:30:43 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 [Bug 29778] Deleting additional_contents leaves entries for additional languages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:32:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:32:54 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:32:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:32:58 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129040|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 129218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129218&action=edit Bug 29778: Prevent orphan additional contents When deleting a content, only the main one (lang="default") is removed, which leads to orphan contents in the DB that are still displayed on the UI. Test plan: 0. Don't apply this patch 1. Create some contents, translate them in different languages 2. Delete some of them => Note that they are still displayed on the UI and that the entries with lang!="default" are still in the DB 3. Apply this patch 4. Repeat 1 5. Run updatedatabase 6. Delete from of the contents => Note that the orphan entries created before you applied the patch have been removed and that the "delete" behaviour is now working correnctly. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:33:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:33:03 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129041|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 129219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129219&action=edit Bug 29778: Remove DBMS error ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Table 'additional_contents' is specified twice, both as a target for 'DELETE' and as a separate source for data at /kohadevbox/koha/C4/Installer.pm line 738 Happened on MariaDB 10.1 and 10.3, not 10.6 Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:34:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:34:04 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 --- Comment #9 from Katrin Fischer --- Bug 29828 shows another vector of creating database entries for additional contents that are not visible in the GUI - ideally we should have fixes for both in the next releases! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:39:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:39:52 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:39:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:39:56 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129202|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 129220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129220&action=edit Bug 29820: Set paging option using boolean instead of string Bug 28450, "Make Account summary print tables configurable," added DataTables to the print summary view. The updated page includes the wrong option: "paging": "false", It should be: "paging": false, Because DataTables expects that option to be boolean (true or false). To test, apply the patch and check out to a patron who has more than 20 checkouts and more than 20 holds. - From the toolbar, click Print -> Print summary. - On the acount summary page, confirm that the "Items checked out" and "Pending holds" tables show ALL entries, not just the first 20. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:40:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:40:37 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 --- Comment #5 from Katrin Fischer --- Thx for the quick fix, Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:45:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:45:16 +0000 Subject: [Koha-bugs] [Bug 29818] Cannot save subscription frequency or numbering pattering without display order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29818 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot save subscription |Cannot save subscription |frequency with no display |frequency or numbering |order |pattering without display | |order --- Comment #1 from Katrin Fischer --- Confirmed on master. Same issue for numbering patterns without display order. I have also tested on 20.11 and there it's possible to save the entries with the display order being empty. So something must have changed and the field should not be mandatory or cause such an ugly error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:48:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:48:25 +0000 Subject: [Koha-bugs] [Bug 29570] Unable to sort pending_orders table on parcel.pl by summary column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29570 --- Comment #5 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #3) > I forgot where this was at, sorry :-D 1) Create a basket 2) Create orders 3) Close basket 4) Receive shipment 5) Enter invoice information 6) You should see your pending orders 7) Verify the 'Summary' column is no longer sortable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:50:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:50:31 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:50:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:50:33 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129104|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:50:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:50:36 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:50:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:50:38 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:52:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:52:45 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer --- Hi Nick, you accidentally attached patches to bug 28909 - including a follow-up with a typo in the bug number. Can you please check? I have fixed the attachments on the other bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:53:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:53:19 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124271|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:55:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:55:10 +0000 Subject: [Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #11 from Katrin Fischer --- I am really sorry I lost sight of this one, Andrew. I'll do better. Could you please rebase? 124271 - Bug 28909: Fix handling if backend doesn't support Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28909: Fix handling if backend doesn't support error: sha1 information is lacking or useless (Koha/Illrequest.pm). error: could not build fake ancestor Patch failed at 0001 Bug 28909: Fix handling if backend doesn't support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 22:59:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 21:59:41 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #35 from Katrin Fischer --- Hi Emmi, thx for taking on this old bug! I still like the idea. Can you explain why you are using usercode instead of categorycode or similar? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:00:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:00:24 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:06:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:06:37 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 --- Comment #5 from Katrin Fischer --- Comment on attachment 129118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129118 Bug 6734: Show location in serials history table Review of attachment 129118: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6734&attachment=129118) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-serial-issues.tt @@ +132,5 @@ > [% END %] > >

[% subscription_LOO.branchname | html %]

> + [% IF ( subscription_LOO.location ) %] > +

Location : [% AuthorisedValues.GetByCode( 'LOC', subscription_LOO.location, 1 ) | html | html_line_break %]

I believe the html_line_break is not needed here as every subscription can only have one location assigned and there should not be any line breaks to convert. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:07:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:07:37 +0000 Subject: [Koha-bugs] [Bug 7021] Add patron category to the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|patron category in the |Add patron category to the |statistics table |statistics table -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:10:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:10:48 +0000 Subject: [Koha-bugs] [Bug 28693] Main heading box not populated in search authorities from bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28693 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- I believe this is a duplicate of bug 28812, fixed in: 21.11.00,21.05.04,20.11.10 *** This bug has been marked as a duplicate of bug 28812 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:10:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:10:48 +0000 Subject: [Koha-bugs] [Bug 28812] Authority tag editor only copies $a from record to search form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernard.scaife at ptfs-europe. | |com --- Comment #19 from Katrin Fischer --- *** Bug 28693 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:14:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:14:41 +0000 Subject: [Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894 --- Comment #3 from Katrin Fischer --- (In reply to Owen Leonard from comment #1) > Is width an option? I don't see it: https://metacpan.org/pod/GD::Barcode There is a width parameter in the source code, but I haven't tested if it can be used: https://metacpan.org/dist/GD-Barcode/source/Barcode.pm#L60 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:21:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:21:40 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28180 --- Comment #7 from Katrin Fischer --- I've tested this with BywaterSolutions Coce server and for me it's the other way around. When both Coce and local covers are available, only the local cover shows on the detail page. The result page shows both. I wonder if that has to do with bug 28180 - linking them just in case. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:21:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:21:40 +0000 Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the images on the detail pages in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:23:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:23:30 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #8 from Katrin Fischer --- For testing: https://bywatersolutions.com/education/koha-tutorial-cover-images-koha-opac-coce-server -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:29:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:29:13 +0000 Subject: [Koha-bugs] [Bug 29799] Z39.50 additional fields for authorities in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29799 --- Comment #1 from Katrin Fischer --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:32:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:32:55 +0000 Subject: [Koha-bugs] [Bug 29783] Account lockout message appears incorrectly for blank userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 --- Comment #2 from Katrin Fischer --- Hi David, 2 things here: 1) How did you manage to add a user with an empty userid? Using the GUI and using the patron import tool this should always be automatically generated if not given. We can use SQL for the test of course. 2) You write in your test plan: 1) Set system preference FailedLoginAttempts to 3 2) Modify a borrower to have an empty userid and 10 login_attempts So in this case the user account SHOULD be locked, shouldn't it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:40:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:40:06 +0000 Subject: [Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer --- I saw this and I think I have been looking up that error in SQL at some point. I wonder if it got broken maybe by a change of sequence in parameters? Instead of removing it, I think the "duplicate item barcode" should go into import_items.import_error that is NULL in Hayley's test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:50:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:50:19 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #11 from Katrin Fischer --- I think Tomas is right about that we should make the prefs all behave the same (using the same separator) as this is a nuisance right now and requires constant 'looking up' of the syntax to use for each. Having a nice GUI component would make it even nicer. I am always a little doubful about wrapping a one liner in perl into an additional method. Basically this: my $values = [ split qr{\|}, $syspref ]; So I see a lot of gain in making things more consistent and refining the GUI, but I am not sure as it is right now a separate method is really required? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:52:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:52:58 +0000 Subject: [Koha-bugs] [Bug 25387] Avoid merge different type of authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25387 --- Comment #15 from Katrin Fischer --- (In reply to marion.durand from comment #14) > Hi ! > In my understanding (I can be wrong), Marcel is saying that we shouldn't > only allow merging when the losing record is unused, because if we notice > two record we want to merge and both of them are used, we will have to > manually relink them (to make one used and the other not). And only then we > can merge the record. > > So it's not the actual merging that would be a problem but the process > before, to make the merge possible. I think the relinking of records of the same authority type is a solved problem. I was thinking about use cases where we could safely allow merging of different auhority types where the relinking is much harder because the MARC fields are not the same in MARC21 for different. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 8 23:53:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 22:53:36 +0000 Subject: [Koha-bugs] [Bug 25387] Avoid merge different type of authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25387 --- Comment #16 from Katrin Fischer --- ... for different types of entries (think of 100/110/111 etc.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:02:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:02:00 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:02:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:02:04 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123970|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 129221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129221&action=edit Bug 11750: Hide patron's attributes on overdue list if needed If a patron's attributes is limited to some libraries, we must apply this limit on the overdue list view. Test plan: 1. Create the following patron attributes: A that is not searchable B is searchable and does not have library limitation C is searchable and is limited to another library than yours 2. On the right part of the overdue list view you must see B only Without this patch C is displayed as well. Signed-off-by: The Minh Luong Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:06:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:06:01 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 --- Comment #5 from Katrin Fischer --- Created attachment 129222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129222&action=edit Bug 11750: (QA follow-up) Remove unconditional warn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:07:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:07:55 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 --- Comment #6 from Katrin Fischer --- Thx for testing, The Minh Luong. I have added your sign-off line to the patch: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129221 Please have a look at how you can do this yourself using git or the sandboxes and let us know if we can help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:11:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:11:02 +0000 Subject: [Koha-bugs] [Bug 29829] New: Standardize multi-value system preferences to use | as separator Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29829 Bug ID: 29829 Summary: Standardize multi-value system preferences to use | as separator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org A lot of our system preferences use | to separate multiple values, but some don't, which makes handling them a little bit harder than it needs to be. Examples: ILS-DI:AuthorizedIPs NotesToHide z3950AuthorAuthFields DefaultLongOverdueSkipLostStatuses -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:11:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:11:02 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29829 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:23:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:23:06 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #12 from Tomás Cohen Arazi --- I always prefer to have a high level method that you just call without knowing how it is internally implemented, and the POD tells you what it will return. It is consistent with some other methods we have for accessing sysprefs even. I don't want the callers to need to know how that syspref needs to be splitter, the same way I think it is non sense for end users to need to worry about that on the front end If there is consensus, I can spend a few hours migrating all sysprefs to use the same separator. Keep in mind that we might need to escape whichever separator we pick on sysprefs that used a different one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:27:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:27:43 +0000 Subject: [Koha-bugs] [Bug 29791] KohaOpacLanguage cookie should set the secure flag if using https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:27:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:27:47 +0000 Subject: [Koha-bugs] [Bug 29791] KohaOpacLanguage cookie should set the secure flag if using https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129004|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 129223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129223&action=edit Bug 29791: KohaOpacLanguage cookie should set the secure flag if using https To test, the headers should have value set-cookie: secure; for the language cookie, when the site is using https. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:27:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:27:51 +0000 Subject: [Koha-bugs] [Bug 29791] KohaOpacLanguage cookie should set the secure flag if using https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791 --- Comment #4 from Katrin Fischer --- Created attachment 129224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129224&action=edit Bug 29791: (follow-up) Add missing comma in previous line Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:28:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:28:26 +0000 Subject: [Koha-bugs] [Bug 29791] KohaOpacLanguage cookie should set the secure flag if using https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29791 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- I couldn't test with https, but have verified the cookie is set correctly with my follow-up patch on http. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:32:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:32:51 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #13 from Katrin Fischer --- I am more thinking of people coming new to the project - it's really hard to learn all the 'internals' already right now. You have to get familiar with a whole lot of things. That's just another perspective. I wonder if some prefs have chosen the separator because of the contents not containing it or because the way they are used makes it easier to use them like that (ILS-DI:AuthorizedIPs maybe?) I have filed a separate bug for the prefs - bug 29829, so maybe we could move the discussion about the 'end user side' there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 00:41:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Jan 2022 23:41:43 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #13) > I have filed a separate bug for the prefs - bug 29829, so maybe we could > move the discussion about the 'end user side' there. Great idea. My point was to start a discussion about all this, do we are in a good track. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:04:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:04:08 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Katrin Fischer --- i had a look at the XSLT code here, but it is a bit complicated. Adding Frido as he might have more UNIMARC knowledge than I. If you compare files, please note that there are 2 versions of UNIMARCslimUtils.xsl - one on staff and one on OPAC side. So maybe comparing those 2 would give some more hints. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:05:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:05:50 +0000 Subject: [Koha-bugs] [Bug 29796] Cannot create new patron accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29796 --- Comment #8 from Katrin Fischer --- Hi Jeremiah, could you please also make these tests as Jonathan suggests? > Also, do you see the problem with other patron's category? Did you try to > create a new category and a patron using it? Does it work if you edit an > existing patron? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:07:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:07:30 +0000 Subject: [Koha-bugs] [Bug 29608] Editing numbering patterns does require full serials permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29608 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:09:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:09:58 +0000 Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users associated with that budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 --- Comment #8 from Katrin Fischer --- Would someone be willing to step up and write the necessary tests here so we can get this bug fixed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:13:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:13:05 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 --- Comment #5 from Rafael Antonio --- I am not so sure if the problem is on XSLT file or any perl function that was changed and this can be a side efect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:13:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:13:20 +0000 Subject: [Koha-bugs] [Bug 29613] Set focus for cursor to barcode field on course reserves add items and batch add items pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29613 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- Same for me, I tested this on 20.11 and the current development version. The cursor is always in the barcode field for me. Eliana, please provide your exact version if this problem still persists. Please also try to remove all your changes from OpacUserJs and test without them to make sure it's not another change interfering. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:14:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:14:27 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 --- Comment #6 from Katrin Fischer --- The display is rendered from the MARCXML record in the database using XSLT. There are some replacements where authorised values are linked to fields, but they should not be to blame here I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:17:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:17:21 +0000 Subject: [Koha-bugs] [Bug 29573] MARC framework subfield visibility doesn't work for 5xx displayed on the "Title notes" tab in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MARC Framework Subfields |MARC framework subfield |Visibility Setting Not |visibility doesn't work for |Obeyed for 5XX |5xx displayed on the "Title | |notes" tab in OPAC --- Comment #5 from Katrin Fischer --- Hi Lye, I believe there is no easy fix for this then currently. I have amended the bug title a little to make it more clear where the problem is. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:21:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:21:10 +0000 Subject: [Koha-bugs] [Bug 14907] Item search: Call Numbers in Item search results are ordered alphabetically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #5 from Katrin Fischer --- (In reply to Owen Leonard from comment #2) > The item search table is rendered server-side, so all sorting happens > server-side. This eliminates some of our standard sorting methods, like > embedding a sortable string in a title tag. > > Renaming the column "cn_sort" has the right effect for the purposes of > sorting: The column name "cn_sort" is passed to the query and the rows are > sorted correctly by call number. > > Unfortunately this breaks the column filter: "cn_sort" is an ambiguous > column name for the purposes of the query because of biblioitems.cn_sort. > I'm not sure if there is a good way to handle this besides adding some > conditional code specific to these columns. > > Suggestions welcome! Hi Owen, does that mean we should expect similar issues for date sorting for server side rendered tables? Or is it something specific to how this table was implemented? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:25:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:25:47 +0000 Subject: [Koha-bugs] [Bug 29559] Update creates "unexpected type" entries for standard codes in debit and credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 --- Comment #8 from Katrin Fischer --- I think we could do better, but it might just be too late now. I believe that in the history of Koha we sometimes had negative/positive values in the amount, that did look almost the same in the interface (apart from some color coding issues) and the math accounted for that. And that these are probably among those that didn't get migrated correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:25:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:25:55 +0000 Subject: [Koha-bugs] [Bug 29559] Update creates "unexpected type" entries for standard codes in debit and credit types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29559 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:40:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:40:38 +0000 Subject: [Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- It might get too late and I might be misunderstanding it all, but I am not sure if this fix is in the right spot. Instead of introducing the onloan special case to the general method in Object.pm, would the solution not be to add it to the $properties_hashref? 321 $item->{cn_source} = delete $item->{'items.cn_source'}; # Because of C4::Biblio::_disambiguate 322 delete $item->{'items.cn_sort'}; # Because of C4::Biblio::_disambiguate 323 $item->{itemnumber} = $itemnumber; 324 $item->{biblionumber} = $biblionumber; 325 326 my $existing_cn_sort = $item_object->cn_sort; # set_or_blank will reset cn_sort to undef as we are not passing it 327 # We rely on Koha::Item->store to modify it if itemcallnumber or cn_source is modified 328 $item_object = $item_object->set_or_blank($item); 279 =head3 $object->set_or_blank( $properties_hashref ) 280 281 $object->set_or_blank( 282 { 283 property1 => $property1, 284 property2 => $property2, 285 property3 => $propery3, 286 } 287 ); 288 289 If not listed in $properties_hashref, the property will be set to the default 290 value defined at DB level, or nulled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:41:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:41:55 +0000 Subject: [Koha-bugs] [Bug 27887] Patrons should not receive overdue notices for claimed returns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 01:54:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 00:54:31 +0000 Subject: [Koha-bugs] [Bug 29160] Default Framework Report Yields Empty Download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29160 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Katrin Fischer --- Hi Charles, I have tested your report on 20.11 and the current development version and results displayed and download worked correctly. Do you still see the issue? You might want to consider updating to a newer version if you haven't yet, as 20.05 is quite old and no longer maintained. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 02:01:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 01:01:20 +0000 Subject: [Koha-bugs] [Bug 29237] When deleting funds from an inactive budget, the results page returns to a different budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29237 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|20.05 |master --- Comment #1 from Katrin Fischer --- Confirmed on master. For the sample database: 1) Go to Administration > Budgets 2) Duplicate the existing budget and set it to inactive 4) Select the inactive budget and click on it, to see linked funds 5) Delete a fund 6) Verify you are now on the active budget, where the fund is still there As Valerlie says this is quite dangerous and might easily lead people to delete the wrong funds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 02:01:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 01:01:33 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 02:01:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 01:01:36 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129125|0 |1 is obsolete| | --- Comment #27 from Samu Heiskanen --- Created attachment 129225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129225&action=edit Bug 23352: Set default collection code when creating subscription The default collection code set in the subscription will be applied if item records are created when receiving the serial. Test plan: 1. Apply 3 patches 2. Run updatedatabase.pl and restart services 3. Create a subscription: - Tick the 'Create an item record when receiving this serial' radio button - Select values in the Location, Collection code and Item type dropdowns - Save the subscription 4. Confirm the Location, and Collection code default values you choose in #3 are displaying in the 'Information' tab of page that's loaded 5. Receive the serial: - Click 'Receive' - Change the status dropdown from 'Expected' to 'Arrived' - Confirm the 'Collection Code', 'Shelving location' and 'Koha item type' dropdowns are pre-filled with the values you defined in #3 6. Run unit test t/db_dependent/Serials.t Sponsored-By: Brimbank Library, Australia Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 02:55:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 01:55:38 +0000 Subject: [Koha-bugs] [Bug 29801] Holds reminder cron not finding notice for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29801 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 28797 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 02:55:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 01:55:38 +0000 Subject: [Koha-bugs] [Bug 28797] Hold reminder email should use All Libraries notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28797 --- Comment #1 from Katrin Fischer --- *** Bug 29801 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 02:56:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 01:56:47 +0000 Subject: [Koha-bugs] [Bug 29830] New: Superlibrarian unable to delete patron list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29830 Bug ID: 29830 Summary: Superlibrarian unable to delete patron list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: jendayi30 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I'm currently unable to delete patron lists that someone else has created even though I have superlibrarian privileges. I am able to delete patron lists that I originally created, but not patron lists that someone else has created. As superlibrarian, I should have the ability to delete all patron lists on our system, if needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 03:00:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 02:00:55 +0000 Subject: [Koha-bugs] [Bug 29830] Superlibrarian unable to delete patron list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29830 --- Comment #1 from Katrin Fischer --- Hi JaTara, can you explain your use case a bit? If a patron list is shared, it can be used by others, but probably only still be deleted by the creator of the list. I am not sure if a superlibrarian should be able to interfere here, as these lists could be considered personal, like the entries of a cart or a list of bibliographic records. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 03:11:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 02:11:07 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129123|0 |1 is obsolete| | --- Comment #28 from Samu Heiskanen --- Created attachment 129226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129226&action=edit Bug 23352: Database changes Sponsored-By: Brimbank Library, Australia Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 03:12:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 02:12:41 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129124|0 |1 is obsolete| | --- Comment #29 from Samu Heiskanen --- Created attachment 129227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129227&action=edit Bug 23352: Updated schema file Sponsored-By: Brimbank Library, Australia Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 03:13:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 02:13:54 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129225|0 |1 is obsolete| | --- Comment #30 from Samu Heiskanen --- Created attachment 129228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129228&action=edit Bug 23352: Set default collection code when creating subscription The default collection code set in the subscription will be applied if item records are created when receiving the serial. Test plan: 1. Apply 3 patches 2. Run updatedatabase.pl and restart services 3. Create a subscription: - Tick the 'Create an item record when receiving this serial' radio button - Select values in the Location, Collection code and Item type dropdowns - Save the subscription 4. Confirm the Location, and Collection code default values you choose in #3 are displaying in the 'Information' tab of page that's loaded 5. Receive the serial: - Click 'Receive' - Change the status dropdown from 'Expected' to 'Arrived' - Confirm the 'Collection Code', 'Shelving location' and 'Koha item type' dropdowns are pre-filled with the values you defined in #3 6. Run unit test t/db_dependent/Serials.t Sponsored-By: Brimbank Library, Australia Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 11:52:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 10:52:13 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 11:52:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 10:52:17 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129118|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 129230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129230&action=edit Bug 6734: Show location in serials history table Opac: On a record(Serials) details the location wasn't displayed on the "Normal view" and "Full history" tabs Test plan: 1)Intranet: Make sure to have at least two different Serials/Subscriptions on the same record with the field 'location' filled in 2)Opac: Find your Serials/Subscriptions 3)Click 'More details' and notice the 3 tabs : Normal view, Brief history, Full history 4)Go to 'Normal view' and 'Full history' to notice that 'location' is missing 5)Apply patch, refresh your browser & repeat 4) 6)The location is now visible Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 11:52:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 10:52:20 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in serials history table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 --- Comment #7 from Katrin Fischer --- Created attachment 129231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129231&action=edit Bug 6734: (QA follow-up) Fix punctuation and TT filters * Changes Location : to Location: * Removes html_line_break filter, as location is not multi-line Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 11:53:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 10:53:00 +0000 Subject: [Koha-bugs] [Bug 6734] Show location in full and brief subscription history in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show location in serials |Show location in full and |history table |brief subscription history | |in OPAC -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:02:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:02:08 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 --- Comment #7 from Katrin Fischer --- I see that there is different styling with the Private being no link, grey and italic, but I still feel some urge to add (). Maybe this would also be nicer for screen readers? Lists that include this title: list1 (Private) | list2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:04:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:04:13 +0000 Subject: [Koha-bugs] [Bug 25705] Make it possible to view full serials history in staff without serials permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25705 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Viewing all serials issues |Make it possible to view |should not require serials |full serials history in |permissions |staff without serials | |permissions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:06:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:06:00 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:06:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:06:04 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128983|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 129232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129232&action=edit Bug 29764: Fix incorrect EmbedItems RecordProcessor filter POD This patch makes the usage POD for the EmbedItems filter actually be usable. The filter is used in opac-ISBDdetail.pl and the POD is updated to how it is used there. Not much to test. Signed-off-by: David Cook Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:09:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:09:34 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 --- Comment #5 from Katrin Fischer --- I can't test this with Overdrive, but trusting Nick, Andrew and Owen have tested this. Code changes pass QA tools and are limited to the Overdrive files so there should be no side-effects on other parts of the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:10:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:10:53 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:10:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:10:57 +0000 Subject: [Koha-bugs] [Bug 29686] Adapt OverDrive for new fulfillment API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128628|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 129233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129233&action=edit Bug 29686: Adapt Koha to use new fulfillment API for OverDrive This patch modifies the checkout_download_url routine in WebSerivce::ILS::OverDrive::Patron We now directly hit the fulfillment endpoint with redirects disabled and fetch the URL The overdrive.js is modified to use a single 'Get item' button for all checked out items and to refer to the fulfillment page To test: 1 - Enable all OverDrive system preferences 2 - Search on opac and confirm OD results returned 3 - Checkout an item 4 - Confirm you have the new 'Get item' button on 'OverDrive account' tab on opac-user.pl 5 - Confirm the 'Get item' button works NOTE: Most items will also show the 'Get item' button in results, however, magazines may not as each checkout has a unique 'reserve id' and the 'parent' id is not checked in our current code Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:14:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:14:46 +0000 Subject: [Koha-bugs] [Bug 29831] New: Fix incorrect use of _() in .js files Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29831 Bug ID: 29831 Summary: Fix incorrect use of _() in .js files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr We need to make sure that we are using __() in .js files, instead of the _() from .tt files. >From bug 29688 comment 2: background-job-progressbar.js: humanMsg.displayMsg( '

' + _('Import of record(s) failed: ') + textStatus + '


'+xml.responseText, { className: 'humanError' } ); calendar.js: is_date_after: _("Validation error to be shown, i.e. End date must come after start date") checkouts.js: $(selected_option).text(_("%s (current status)").format($(selected_option).text())); datatables.js: var search_title = _("%s search").format(title); holds.js: _("This pickup location is not allowed according to circulation rules") + letter.js: $(sms_counter).html(length + "/" + sms_limit + _(" characters")); onboarding.js:function _(s) { return s; } // dummy function for gettext pages/results.js: div.find(".hint").html(_("Coce image from Amazon.com")); pages/results.js: div.find(".hint").html(_("Coce image from Google Books")); pages/results.js: div.find(".hint").html(_("Coce image from Open Library")); pages/tags-review.js: // window.alert(_("AJAX approved tag: ") + tag); pages/tags-review.js: // window.alert(_("AJAX rejected tag: ") + tag); pages/tags-review.js: $('#test_button').html("" +_(" Test")); pages/tags-review.js: // window.alert(_("Click detected on ") + event.target + ": " + $(event.target).html); rotating-collections.js: if(confirm(_("Are you sure you want to delete this rotating collection?"))){ xmlControlfield.js: alert(_("AJAX error: receiving data from %s").format(settings.url)); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:15:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:15:18 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 --- Comment #3 from Katrin Fischer --- I've split the other appearances Joubu found into a separate bug 29831 so this can be pushed before string freeze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:16:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:16:47 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:16:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:16:51 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128463|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 129234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129234&action=edit Bug 29688: Incorrect use of _() in holds.js Bug 29404 moved code from request.tt into holds.js, and I didn't know about the _() vs. __(). This patch fixes that. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:17:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:17:23 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer --- Moving directly to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:17:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:17:44 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29831 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:17:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:17:44 +0000 Subject: [Koha-bugs] [Bug 29831] Fix incorrect use of _() in .js files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29831 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29688 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:21:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:21:22 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:21:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:21:25 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128848|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 129235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129235&action=edit Bug 29722: Add more sample quotes This patch adds sample quotes from women, women of colour, trans women, Black and Indigenous women, and people who weren't US Presidents! To test: 1. Install a fresh Koha and import sample quotes 2. Go to Tools -> Quote editor 3. Confirm the quotes show Sponsored-by: Catalyst IT Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:22:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:22:27 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #5 from Katrin Fischer --- I was aiming to mostly work on bug fixes... but this is kind of a bug fix for me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:27:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:27:33 +0000 Subject: [Koha-bugs] [Bug 29763] Patron information - terminology: borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29763 --- Comment #1 from Katrin Fischer --- I think this is a difficult one. Using borrowernumber makes people make the connection to the database field named the same and to the URL parameter they see in a lot of places. Adding the borrowernumber to the patron information was, I seem to remember, done to help people make that connection. If we did change it, maybe using something like "Patron ID" would make it more obvious that this is an internal thing. But I am not sure we might not cause more confusion... on the other hand in translation I think we do use "Benutzernummer" in some places at least for borrowernumber. Maybe we need both: List of Patron IDs (borrowernumber) ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:30:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:30:39 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 --- Comment #5 from Katrin Fischer --- Hi Hayley, I think you can do the following: Before applying the patch: - turn on PrefillItem system preference - confirm SubfieldsToUseWhenPrefill system preference is empty - create an item, confirm no values are prefilled for next item - set at least one subfield in SubfieldsToUseWhenPrefill - create an item, confirm specified subfield(s) get prefilled for next item Apply patch: - create an item, confirm it behaves the same as before with your defined subfield getting prefilled - Empty SubfieldsToUseWhenPrefill system preferene - create an item, confirm that now all item subfields are prefilled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:41:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:41:21 +0000 Subject: [Koha-bugs] [Bug 29663] Document expected behavior of Prefill Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29663 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29661, 29662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29661 [Bug 29661] PreFillItem should not apply to duplicated items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:41:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:41:21 +0000 Subject: [Koha-bugs] [Bug 29661] PreFillItem should not apply to duplicated items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29663 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29663 [Bug 29663] Document expected behavior of Prefill Item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:41:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:41:21 +0000 Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields when SubfieldsToUseWhenPrefill is null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29663 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29663 [Bug 29663] Document expected behavior of Prefill Item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:43:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:43:52 +0000 Subject: [Koha-bugs] [Bug 15121] runreport.pl cronjob ought to let you specify multiple email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15121 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 12:44:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 11:44:28 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 --- Comment #6 from Katrin Fischer --- Can this please be pushed before next string freeze? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 14:09:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 13:09:41 +0000 Subject: [Koha-bugs] [Bug 27887] Patrons should not receive overdue notices for claimed returns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27887 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 14:10:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 13:10:27 +0000 Subject: [Koha-bugs] [Bug 27550] "Duplicate budget" does not keep users associated with that budget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27550 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 14:24:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 13:24:11 +0000 Subject: [Koha-bugs] [Bug 29832] New: Make library column in desk list sortable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 Bug ID: 29832 Summary: Make library column in desk list sortable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be nice, if the list of desks under Administration > circulation desks was sortable by library. Requires UseCirculationDesks to be turned on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 20:43:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 19:43:50 +0000 Subject: [Koha-bugs] [Bug 29830] Superlibrarian unable to delete patron list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29830 --- Comment #2 from JaTara Barnes --- I currently have 3 patron lists in our system and I don't know which of our 80+ staff member(s) created it, nor is there an easy way of finding out. Also, if one of those staff members resigns / retires without deleting the patron lists they've created, then we're potentially left with a bunch of lists that literally no one is able to delete. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 22:21:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 21:21:24 +0000 Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Hayley Pelham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Hayley Pelham --- Setting back to Signed off after feedback from Katrin - thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 22:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 21:37:26 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 9 22:37:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Jan 2022 21:37:29 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129206|0 |1 is obsolete| | --- Comment #8 from Samu Heiskanen --- Created attachment 129236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129236&action=edit Bug 28247: (folow up) Add a MARC preview action to Authority search results To test: 1) Do an authority search 2) On Actions button click to see the available actions and click on "MARC preview" action. 3) A modal window open and confirm that the correct details are shown. Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 02:28:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 01:28:30 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 04:20:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 03:20:08 +0000 Subject: [Koha-bugs] [Bug 29783] Account lockout message appears incorrectly for blank userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29783 --- Comment #3 from David Cook --- (In reply to Katrin Fischer from comment #2) > Hi David, > > 2 things here: > > 1) How did you manage to add a user with an empty userid? Using the GUI and > using the patron import tool this should always be automatically generated > if not given. We can use SQL for the test of course. I'm not sure how it happened. My guess would be some migration script. For testing, I used SQL. > 2) > You write in your test plan: > 1) Set system preference FailedLoginAttempts to 3 > 2) Modify a borrower to have an empty userid and 10 login_attempts > > So in this case the user account SHOULD be locked, shouldn't it? Yes, the user account should be locked. The purpose of that test is to see whether or not that user account is being used automatically by Koha without any user input. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 05:45:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 04:45:16 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when receiving serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129204|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 05:46:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 04:46:43 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when receiving serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 --- Comment #6 from Alex Buckley --- Created attachment 129237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129237&action=edit Bug 29815: Pre-populate 'Date acquired' field when adding/editing items This patch pre-fills the 952$d (Date acquired) item subfield on page load. Users can still click on the field to fill this subfield. Test plan: 1. Visit a biblio. Add an item, observe on page load the 'Date acquired' subfield is empty 2. Visit a subscription. Receive a serial, observe after setting the serial status to 'Arrived' the item form loads with an empty 'Date acquired' subfield 3. Apply patch and restart services 4. Repeat step 1 and confirm now on page load the 'Date acquired' subfield populates with today's date 5. Delete the populated 'Date acquired' subfield value. Click in the field and confirm the field is populated and the calendar input displays 6. Delete the 'Date acquired' subfield value again. Confirm that tabbing from a different field into the date acquired field behaves the same as click 7. Repeat step 2. This time confirm on page load the 'Date acquired' subfield contains the current date 8. Delete the populated 'Date acquired' subfield value. Click in the field and confirm it is populated 9. Delete the populated 'Date acquired' subfield value. Tab to the field from another field and confirm it behaves the same as click 10. Visit a biblio. Edit an item with a date acquired value in the past. Confirm the date acquired value is unchanged after saving. Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 05:47:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 04:47:27 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when receiving serial In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Alex Buckley --- Hi Samu and Katrin, Thank you for your testing and QA. Katrin, I have gone with your suggestion of changing the other forms to work the same as the serial edit one. To do this I have edited the dateaccessioned plugin itself. I think this one is ready to test again now. Thanks! Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 05:48:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 04:48:31 +0000 Subject: [Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when adding/editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Pre-populate 'Date |Pre-populate 'Date |acquired' field when |acquired' field when |receiving serial |adding/editing items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 05:57:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 04:57:48 +0000 Subject: [Koha-bugs] [Bug 29833] New: Gateway Timeout for Overdues Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29833 Bug ID: 29833 Summary: Gateway Timeout for Overdues Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mhby87 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 129238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129238&action=edit Gateway Timeout for Overdues Gateway Timeout After upgrade from 21.05 to 21.11, Overdues report in Circulaiton module too long to generate and result is Gateway Timeout. Thank you -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 07:57:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 06:57:17 +0000 Subject: [Koha-bugs] [Bug 7021] Add patron category to the statistics table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #36 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #35) > Hi Emmi, > > thx for taking on this old bug! I still like the idea. Can you explain why > you are using usercode instead of categorycode or similar? I decided to leave it as is, since I thought it would make it more clear we are talking about patrons categorycode who made the checkout/renew/return. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:04:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:04:47 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:04:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:04:49 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 --- Comment #26 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:04:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:04:52 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:04:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:04:54 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:04:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:04:56 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:04:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:04:59 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:05:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:05:01 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:05:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:05:03 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:05:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:05:05 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:05:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:05:08 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:05:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:05:10 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:05:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:05:12 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:05:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:05:14 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:05:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:05:17 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 08:33:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 07:33:33 +0000 Subject: [Koha-bugs] [Bug 29834] New: Add PATCH route for items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29834 Bug ID: 29834 Summary: Add PATCH route for items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: johanna.raisa at koha-suomi.fi Creating a PATCH route as in the documentation: https://wiki.koha-community.org/wiki/Items_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 09:10:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 08:10:37 +0000 Subject: [Koha-bugs] [Bug 29835] New: 2FA - ask for the password when 2FA is disabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29835 Bug ID: 29835 Summary: 2FA - ask for the password when 2FA is disabled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org The user should confirm by 2FA deactivation by entering their password. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 09:24:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 08:24:22 +0000 Subject: [Koha-bugs] [Bug 29835] 2FA - ask for the password when 2FA is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 [Bug 28786] Two-factor authentication for staff client - TOTP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 09:24:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 08:24:22 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29835 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29835 [Bug 29835] 2FA - ask for the password when 2FA is disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 09:26:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 08:26:06 +0000 Subject: [Koha-bugs] [Bug 29836] New: 2FA - provide a REST API challenge route Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29836 Bug ID: 29836 Summary: 2FA - provide a REST API challenge route Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Depends on: 28786 We need a challenge route that will take the TOTP and generate a token (JWT?) in case of success. This token will be passed in the header of the other requests. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 [Bug 28786] Two-factor authentication for staff client - TOTP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 09:26:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 08:26:06 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29836 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29836 [Bug 29836] 2FA - provide a REST API challenge route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 09:38:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 08:38:54 +0000 Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many items to display unless viewing them all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 --- Comment #15 from Marcel de Rooy --- (In reply to Christopher Brannon from comment #14) > Why is the status on this bug blocked? Comment11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 09:44:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 08:44:35 +0000 Subject: [Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |testopia at bugs.koha-communit | |y.org Status|Failed QA |Signed Off --- Comment #15 from Marcel de Rooy --- Back to SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 09:51:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 08:51:49 +0000 Subject: [Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Marcel de Rooy --- (In reply to Alex Buckley from comment #5) > Hi there, > > In bug 26346 I've added the ability to create public lists that are only > editable by staff, but viewable by all. > > Question: Rather than add a 'Share' button in the staff client would it be > the cleaner solution to revert bug 28959 , and add a third category of > 'Restricted' which is viewable by all in the staff client, and by staff > users in the OPAC? > > I'm not sure what the best practice is for reverting patches that have been > upstreamed? Fun, I commented on bug 28959 earlier that we were on the "wrong track" there. But Restricted is imho not directly a candidate for a new category. It sounds more like a security thing on lists. (Similarly, Shared is still no category, but a more limited implementation using private lists.) This whole thing with public lists and staff users is duplicated on several reports still, and hunts us already for years. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 09:55:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 08:55:50 +0000 Subject: [Koha-bugs] [Bug 29437] 500 error when performing a catalog search for an ISBN13 with no valid ISBN10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29437 --- Comment #23 from Marcel de Rooy --- (In reply to Victor Grousset/tuxayo from comment #22) > Hi, I'll try to backport this for 20.11. > > Thanks Marcel for digging into this, how should this change be used? How can > I use it to solve the conflicts due to bug 29319 missing? > Or maybe it's a whole alternative patch? > > Another way: does bug 29319 seems like a risky backport to you? The odd > thing is that I can catalogue search stuff that begins with digits without > getting errors. In other words, I don't reproduce the issue. 29319 seems quite innocent to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 09:56:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 08:56:26 +0000 Subject: [Koha-bugs] [Bug 29319] Errors when doing a cataloging search which starts with a number + letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29319 --- Comment #13 from Marcel de Rooy --- (In reply to Fridolin Somers from comment #12) > I prefer not to push on 20.11.x to keep stable behavior in cataloguing Please explain this. Whats your problem with this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 09:58:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 08:58:56 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 --- Comment #7 from George Veranis --- For the moment I solve that problem by using the template "tag_subject" from the MARC21slimUtils.xsl and it works fine. and adding also the same codes and subdivCodes from template tag_onesubject that seems to have the problem, but my xslt knowledge is not the best at the moment to solve it or to understand what is wrong, so I decided to use the same template as MARC21. : /cgi-bin/koha/opac-search.pl?q=an: /cgi-bin/koha/opac-search.pl?q=su: abcdfijkmpnptvxyz ijknpxyz -- | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:19:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:19:27 +0000 Subject: [Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:19:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:19:30 +0000 Subject: [Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 --- Comment #2 from Jonathan Druart --- Created attachment 129239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129239&action=edit Bug 29828: Prevent additional content to be created without default When creating or editing an additional content, the form is submitted if only the title of the 'default' tab is filled in. We should submit the form only if both title and content exist. Test plan: Create a new content using text editor (codemirror) Confirm that the form is submitted only if title and content from the default tab are not empty Try again with wysiwyg (tinymce) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:29:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:29:28 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at dataly.gr Assignee|koha-bugs at lists.koha-commun |gveranis at dataly.gr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:31:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:31:12 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:31:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:31:16 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127828|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 129240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129240&action=edit Bug 29458: Reorder login elements Make masthead.inc modal and opac-auth follow the order of the login elements on the homepage. Test plan: Enable prefs for reset password and self registration. Fill additional contents for login instructions. Logout on OPAC. Click Login from your account on top bar. Click Login button on the home page (right side, in the middle). Verify that these two forms correspond with the home page login. Signed-off-by: Marcel de Rooy Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:31:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:31:37 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #8 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #6) > Please rebase. It like it but doesn't apply. Easy fix :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:35:35 +0000 Subject: [Koha-bugs] [Bug 29837] New: JS error during installer Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 Bug ID: 29837 Summary: JS error during installer Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 28376, 28982 Uncaught ReferenceError: _ is not defined the _() function is called from calendar.inc, but calendar.inc is included before the definition of this function in installer-intranet-bottom.inc Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 [Bug 28376] Flatpickr introduction for datetime picker https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 [Bug 28982] Use Flatpickr on onboarding pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:35:35 +0000 Subject: [Koha-bugs] [Bug 28376] Flatpickr introduction for datetime picker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 [Bug 29837] JS error during installer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:35:35 +0000 Subject: [Koha-bugs] [Bug 28982] Use Flatpickr on onboarding pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 [Bug 29837] JS error during installer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:36:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:36:36 +0000 Subject: [Koha-bugs] [Bug 29837] JS error during installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:36:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:36:41 +0000 Subject: [Koha-bugs] [Bug 29837] JS error during installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 --- Comment #1 from Jonathan Druart --- Created attachment 129241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129241&action=edit Bug 29837: Remove JS error during installer Uncaught ReferenceError: _ is not defined the _() function is called from calendar.inc, but calendar.inc is included before the definition of this function in installer-intranet-bottom.inc Test plan: Confirm that the JS error is gone -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:36:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:36:58 +0000 Subject: [Koha-bugs] [Bug 29837] JS error during installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:40:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:40:00 +0000 Subject: [Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 --- Comment #3 from Katrin Fischer --- Hi Joubu, I am not sure that fixes the problem. The problem is translations again, because if there is no default entry, the entry won't show in the list at all. This will just force you to enter a default text. I think it should work without, in case you want to add content only for a specific language, as you could do that with news before too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:49:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:49:04 +0000 Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 --- Comment #7 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #5) > I agree with only giving this note with -v as at the moment if you have > scheduled this on a server with multiple instances where the pref is turned > off intentionally, it creates quite a bit of noise. > > It's not a fatal one I think, so would fit the description of -v, just > referring to a configuration issue. I dont oppose pushing it for the sake of multiple instances (where some instances would have enhanced messaging and others might not). But suppressing a warn that tells you that you are running a script that wouldnt do anything, is imo generally not what we should do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:49:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:49:32 +0000 Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:49:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:49:36 +0000 Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127680|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 129242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129242&action=edit Bug 29054: Add verbose check for warn in advance_notices.pl To test: 1) Set EnhancedMessagingPreferences to Don't allow 2) In the koha-shell, run misc/cronjobs/advance_notices.pl -c 3) Note that you see the warning "The "EnhancedMessagingPreferences" syspref is off... etc." 4) Apply the patch and restart services 5) In the koha-shell, run misc/cronjobs/advance_notices.pl -c and note the warning no longer shows 6) Still in the shell, run misc/cronjobs/advance_notices.pl -c -v and note the warning does show Sponsored-by: Catalyst IT Signed-off-by: Fridolin Somers Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:49:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:49:46 +0000 Subject: [Koha-bugs] [Bug 29054] Stop warns from advance_notices.pl if not running in verbose mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 10:51:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 09:51:23 +0000 Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 --- Comment #24 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #21) > Tomas or Marcel, any chance for a follow-up? I would be very happy to review any follow-ups, Tomas :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 11:02:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 10:02:04 +0000 Subject: [Koha-bugs] [Bug 29319] Errors when doing a cataloging search which starts with a number + letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29319 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #14 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #13) > (In reply to Fridolin Somers from comment #12) > > I prefer not to push on 20.11.x to keep stable behavior in cataloguing > > Please explain this. Whats your problem with this patch? Sorry I don't remember well. My wish was to keep 20.11.x really stable. I let the decision to Victor , actual release maintainer of 20.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 11:04:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 10:04:01 +0000 Subject: [Koha-bugs] [Bug 29319] Errors when doing a cataloging search which starts with a number + letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29319 --- Comment #15 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #13) > (In reply to Fridolin Somers from comment #12) > > I prefer not to push on 20.11.x to keep stable behavior in cataloguing > > Please explain this. Whats your problem with this patch? Sorry I don't remember well. My wish was to keep 20.11.x really stable. I let the decision to Victor Grousset, actual release maintainer of 20.11.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 11:06:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 10:06:40 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 --- Comment #11 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > Bug 29828 shows another vector of creating database entries for additional > contents that are not visible in the GUI - ideally we should have fixes for > both in the next releases! Please backport with this comment in mind! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 11:16:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 10:16:31 +0000 Subject: [Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 --- Comment #5 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > I saw this and I think I have been looking up that error in SQL at some > point. I wonder if it got broken maybe by a change of sequence in parameters? > > Instead of removing it, I think the "duplicate item barcode" should go into > import_items.import_error that is NULL in Hayley's test. Hum, might be. But this is since commit 1dba9c6409d78cb1f90de6c1300cb5b63fb1b851 Date: Wed Oct 10 14:21:22 2012 -0500 Bug 7131: teach MARC import how to overlay items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 11:17:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 10:17:36 +0000 Subject: [Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 --- Comment #6 from Jonathan Druart --- Looking at the code this 'import_error' column is empty for the last 9 years. Not sure it makes much sense to have this single error now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 11:35:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 10:35:20 +0000 Subject: [Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 --- Comment #7 from Katrin Fischer --- (In reply to Jonathan Druart from comment #6) > Looking at the code this 'import_error' column is empty for the last 9 > years. Not sure it makes much sense to have this single error now. Well, I deal a lot with old versions, I guess (and been around too long). Duplicate barcodes might appear without overlaying as well, just importing new data. Would it be hard to move it to the error message? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 11:58:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 10:58:32 +0000 Subject: [Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 --- Comment #8 from Jonathan Druart --- Created attachment 129243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129243&action=edit Bug 28152: Log the "duplicate item barcode" error Looking at the code this 'import_error' column is empty for the last 9 years. Not sure it makes much sense to have this single error now. commit 1dba9c6409d78cb1f90de6c1300cb5b63fb1b851 Date: Wed Oct 10 14:21:22 2012 -0500 Bug 7131: teach MARC import how to overlay items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 11:58:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 10:58:48 +0000 Subject: [Koha-bugs] [Bug 28152] Hidden error when importing an item with an existing itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Jonathan Druart --- I failed to provide tests for this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:03:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:03:56 +0000 Subject: [Koha-bugs] [Bug 29838] New: No string interpolation when expected in t/db_dependent/ImportBatch.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29838 Bug ID: 29838 Summary: No string interpolation when expected in t/db_dependent/ImportBatch.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org -my $batch3_clean = $dbh->do('SELECT * FROM import_records WHERE import_batch_id = "$id_import_batch3"'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:04:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:04:47 +0000 Subject: [Koha-bugs] [Bug 29838] No string interpolation when expected in t/db_dependent/ImportBatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:04:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:04:52 +0000 Subject: [Koha-bugs] [Bug 29838] No string interpolation when expected in t/db_dependent/ImportBatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29838 --- Comment #1 from Jonathan Druart --- Created attachment 129244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129244&action=edit Bug 29838: Fix string interpolation in ImportBatch.t Test plan: Tests should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:09:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:09:49 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:09:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:09:52 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127966|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:10:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:10:42 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129245&action=edit Bug 29562: Adjust CanItemBeReserved to take objects Most of the changes here are simple, this can be read to view the changes Testing that holds can be placed via staff client, and opac, and are disallowed when expected is the best test plan, beyond running the unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:10:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:10:47 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 129246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129246&action=edit Bug 29562: (follow-up) Fix API controller This patch fixes tests failures due to bad checks in the controller. The tests deserve to be rewritten. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:23:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:23:19 +0000 Subject: [Koha-bugs] [Bug 24841] REST API should check if patron is restricted/debarred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24841 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tomás Cohen Arazi --- What is the status for this? My two cents would be: We have a header that is used here: x-koha-override: 'any', that will tell the controller to override blocker conditions. We could add a check like: if ( $patron->debarred ) { return $c->render( status => 400, ... ) unless $override_restricted_patron; } This is a workaround to the fact we don't have the 'holdability' routes on the API. Because if we wanted to implement the staff hold request flow with the API, we would certainly need to: - Ask if a hold can be placed - Prompt the user for confirmation, telling there are things to override - Actually place the hold, overridding checks So, as Nick says, we could also say this route shouldn't be checking things unless they are hard blockers for Koha's core business logic, and what's missing is the patron's (OPAC) perspective, or a route to check the situation for feedback. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:23:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:23:32 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:23:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:23:36 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #9 from Jonathan Druart --- Created attachment 129247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129247&action=edit Bug 29803: Prevent local cover image to be hidden if Coce is enabled If Coce is enabled by no image are returned by the service, then no other image will be displayed (actually un-hidden) The getURL is returning early if no image is returned by the service and the "done" flag is never set. Test plan: Add a local cover image to a bibliographic record (ktd biblionumber=14 is good) Set CoceHost = http://coce.bywatersolutions.com Select all CoceProviders Enable OpacCoce => If no image is returned by Coce then the local image should be displayed anyway -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:23:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:23:57 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |unspecified Assignee|oleonard at myacpl.org |jonathan.druart+koha at gmail. | |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:31:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:31:19 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #10 from Jonathan Druart --- Created attachment 129248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129248&action=edit Bug 29803: Do not wait for the images more than 5 seconds In case of the previous bug, the page was calling the callback function every 100ms, endlessly. We should add a test to prevent future similar problem. Test plan: Remove the previous patch "Prevent local cover image to be hidden if Coce is enabled" Recreate the test plan => You should see the local image displayed after 5 seconds, and a log in the JS console -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:33:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:33:49 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch makes the release notes| |cataloging reservoir search | |results a configurable | |DataTable. This adds column | |configuration, export, and | |sorting. The empty edition | |and date columns are | |removed, and an import data | |column is added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:41:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:41:58 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 12:53:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 11:53:54 +0000 Subject: [Koha-bugs] [Bug 29839] New: elastic search non default authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29839 Bug ID: 29839 Summary: elastic search non default authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es ElasticSearch is not able to index authorities no configured at koha as default, rebuild gets this error Can't locate object method "type" via package "Can't call method "tag" on an undefined value at /usr/share/koha/lib/C4/Heading.pm line 71. " (perhaps you forgot to load "Can't call method "tag" on an undefined value at /usr/share/koha/lib/C4/Heading.pm line 71. "?) at rebuild_elasticsearch.pl line 312. If a customer has added a new authoriy like 147, ES is not able to index it, it is not a very common issue, but it could happen. Authorities at koha are hardcoded and you can 't add on web admin Kindest regards -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:04:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:04:30 +0000 Subject: [Koha-bugs] [Bug 29837] JS error during installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:04:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:04:33 +0000 Subject: [Koha-bugs] [Bug 29837] JS error during installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129241|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 129249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129249&action=edit Bug 29837: Remove JS error during installer Uncaught ReferenceError: _ is not defined the _() function is called from calendar.inc, but calendar.inc is included before the definition of this function in installer-intranet-bottom.inc Test plan: Confirm that the JS error is gone Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:08:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:08:00 +0000 Subject: [Koha-bugs] [Bug 13654] Cannot place a hold for biblio with too many items to display unless viewing them all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:11:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:11:11 +0000 Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:11:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:11:16 +0000 Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129250&action=edit Bug 29787: Add plugin version to plugin search results This patch adds a new column to plugins search results: 'Latest version'. It takes the tag_name in both GitHub and GitLab cases and passes it to the template. To test: 1. Have this on your koha-conf.xml file: ByWater Solutions bywatersolutions github Theke Solutions thekesolutions gitlab PTFS Europe ptfs-europe github 2. Restart all services: $ restart_all 3. Search for the term 'barclaycard' => SUCCESS: You get results from PTFS Europe (Github) => FAIL: They don't include plugin version 4. Search for the term 'innreach' => SUCCESS: You get results from Theke (Gitlab) => FAIL: They don't include plugin version 5. Apply this patch 6. Repeat 2-4 => SUCCESS: Results show up => SUCCESS: Results include the plugin version 7. Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:11:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:11:29 +0000 Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:13:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:13:36 +0000 Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787 --- Comment #3 from Tomás Cohen Arazi --- I didn't go as far as including the upgrade button, because we need more information about the plugins to be able to do that. In particular, we don't store the plugin 'name' (as in koha-plugin-kitchensink) anywhere, and the same for the plugin URL. So if there are overlaps between vendors/devs things could get messy. Kyle and I are thinking about it, and will submit a different bug for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:26:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:26:08 +0000 Subject: [Koha-bugs] [Bug 29832] Make library column in desk list sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:33:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:33:22 +0000 Subject: [Koha-bugs] [Bug 29832] Make library column in desk list sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:33:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:33:25 +0000 Subject: [Koha-bugs] [Bug 29832] Make library column in desk list sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 --- Comment #1 from Owen Leonard --- Created attachment 129251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129251&action=edit Bug 29832: Make library column in desk list sortable This patch makes minor updates to the DataTable configuration on the Circulation Desks Administration page. Redundant options are removed and existing options are updated to use current DataTables syntax. To test, apply the patch and make sure that the UseCirculationDesks system preference is enabled. - Go to Administration -> Circulation desks. - Add multiple circulation desks if necessary, at multiple libraries. - The "Desk" column should be sorted by default, and the "Actions" column should not be sortable. - The "Library" column should be sortable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:39:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:39:57 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #5 from Jonathan Druart --- Created attachment 129252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129252&action=edit Bug 29562: Fix DecreaseLoanHighHolds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:40:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:40:10 +0000 Subject: [Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #1 from Owen Leonard --- George is this something you're working on? If so please assign it to yourself and mark the bug ASSIGNED. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:40:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:40:26 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #6 from Jonathan Druart --- DecreaseLoanHighHolds.t was failing, with this patch it's now passing but I am not sure the changes are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:45:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:45:15 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > DecreaseLoanHighHolds.t was failing, with this patch it's now passing but I > am not sure the changes are correct. Ha! I missed that tests file! The patch looks correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:49:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:49:41 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 --- Comment #11 from Marcel de Rooy --- > Bug 29757: Add filters for reversable offsets https://whichiscorrect.com/reversible-or-reversable/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:54:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:54:46 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129252|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:54:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:54:48 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129245|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:54:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:54:51 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129246|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:55:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:55:21 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 129253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129253&action=edit Bug 29562: Adjust CanItemBeReserved and checkHighHolds to take objects Most of the changes here are simple, this can be read to view the changes Testing that holds can be placed via staff client, and opac, and are disallowed when expected is the best test plan, beyond running the unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:55:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:55:26 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 129254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129254&action=edit Bug 29562: (follow-up) Fix API controller This patch fixes tests failures due to bad checks in the controller. The tests deserve to be rewritten. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:55:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:55:30 +0000 Subject: [Koha-bugs] [Bug 29562] CanItemBeReserved should take patron and item objects as parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 129255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129255&action=edit Bug 29562: Fix DecreaseLoanHighHolds.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 13:55:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 12:55:54 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CanItemBeReserved should |Pass objects to |take patron and item |CanItemBeReserved and |objects as parameters |checkHighHolds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:02:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:02:28 +0000 Subject: [Koha-bugs] [Bug 29840] New: opac-reserve explodes if invalid biblionumber is passed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29840 Bug ID: 29840 Summary: opac-reserve explodes if invalid biblionumber is passed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org An error message should be displayed instead. Can't call method "holds" on an undefined value at /kohadevbox/koha/opac/opac-reserve.pl line 172 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:02:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:02:38 +0000 Subject: [Koha-bugs] [Bug 29840] opac-reserve explodes if invalid biblionumber is passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29562 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:02:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:02:38 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29840 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:04:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:04:04 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #10 from Marcel de Rooy --- + is( abs $patron->account->balance, $payed_amount, 'The patron has been refunded the right value' ); Frowning by intuition. abs ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:04:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:04:30 +0000 Subject: [Koha-bugs] [Bug 29840] opac-reserve explodes if invalid biblionumber is passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:04:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:04:34 +0000 Subject: [Koha-bugs] [Bug 29840] opac-reserve explodes if invalid biblionumber is passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29840 --- Comment #1 from Jonathan Druart --- Created attachment 129256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129256&action=edit Bug 29840: Deal with non-existing biblionumber in opac-reserve We should not explode if the biblionumber passed in not in DB. Test plan: Hit /cgi-bin/koha/opac-reserve.pl?biblionumber=42424 and notice the error message. Without this patch you got Can't call method "holds" on an undefined value at /kohadevbox/koha/opac/opac-reserve.pl line 172 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:06:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:06:10 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #11) > > Bug 29757: Add filters for reversable offsets > > https://whichiscorrect.com/reversible-or-reversable/ Right, the original implementation used reversable. I think I forgot to correct the commit subject -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:07:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:07:11 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #11 from Jonathan Druart --- Created attachment 129257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129257&action=edit Bug 29562: Test $item instead of $itemNum -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:09:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:09:41 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #12 from Jonathan Druart --- I focused on: 1. Making sure the $item or $patron object was not modified in DB between the fetch and the CanItemBeReserved call (which could lead to wrong calculation). And haven't found any. 2. Call to CanItemBeReserved with undefined $item or $patron, that could explode. But I am not sure it would be a regression anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:12:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:12:52 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #13 from Jonathan Druart --- To be consistent we should do the same change for CanBookBeReserved IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:13:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:13:05 +0000 Subject: [Koha-bugs] [Bug 29841] New: Pass objects to CanBookBeReserved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29841 Bug ID: 29841 Summary: Pass objects to CanBookBeReserved Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Same as bug 29562, for consistency. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:13:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:13:05 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29841 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:16:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:16:46 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:16:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:16:49 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:16:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:16:52 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128977|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:16:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:16:54 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:17:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:17:24 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 129258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129258&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:17:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:17:29 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 129259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129259&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev > UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY); 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:17:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:17:33 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 129260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129260&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:20:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:20:34 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:20:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:20:39 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129253|0 |1 is obsolete| | Attachment #129254|0 |1 is obsolete| | Attachment #129255|0 |1 is obsolete| | Attachment #129257|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 129261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129261&action=edit Bug 29562: Adjust CanItemBeReserved and checkHighHolds to take objects Most of the changes here are simple, this can be read to view the changes Testing that holds can be placed via staff client, and opac, and are disallowed when expected is the best test plan, beyond running the unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:20:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:20:43 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #15 from Jonathan Druart --- Created attachment 129262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129262&action=edit Bug 29562: (follow-up) Fix API controller This patch fixes tests failures due to bad checks in the controller. The tests deserve to be rewritten. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:20:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:20:49 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #16 from Jonathan Druart --- Created attachment 129263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129263&action=edit Bug 29562: Fix DecreaseLoanHighHolds.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:20:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:20:53 +0000 Subject: [Koha-bugs] [Bug 29562] Pass objects to CanItemBeReserved and checkHighHolds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29562 --- Comment #17 from Jonathan Druart --- Created attachment 129264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129264&action=edit Bug 29562: Test $item instead of $itemNum Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:28:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:28:12 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #35 from Jonathan Druart --- Nick, will this alternative patch answers your needs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:36:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:36:49 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #8 from Tomás Cohen Arazi --- Sorry for the noise, just learnt about Koha::Objects->filter_by_last_update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:36:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:36:58 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129258|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:37:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:37:02 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129259|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:37:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:37:06 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129260|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:37:26 +0000 Subject: [Koha-bugs] [Bug 29842] New: Item should be removed from rotating collection when item is deleted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29842 Bug ID: 29842 Summary: Item should be removed from rotating collection when item is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Blocks: 18606 To recreate: 1: add an item to a rotating collection 2: delete that item (either via batch delete or via single item delete) 3: confirm your rotating collection no longer shows in the staff interface (rotating_collections/addItems.pl) 4: select * from collections_tracking for your collection, confirm your item is still listed there 5: attempt to transfer your rotating collection, get a big angry error: Can't locate object method "rethrow" via package "Can't call method "request_transfer" on an undefined value at /kohadevbox/koha/C4/RotatingCollections.pm line 451. " (perhaps you forgot to load "Can't call method "request_transfer" on an undefined value at /kohadevbox/koha/C4/RotatingCollections.pm line 451. "?) at /kohadevbox/koha/C4/RotatingCollections.pm line 504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 [Bug 18606] Move rotating collections code to Koha::Object -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:37:26 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29842 [Bug 29842] Item should be removed from rotating collection when item is deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:37:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:37:33 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 129265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129265&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:37:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:37:39 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 129266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129266&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev > UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY); 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:37:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:37:45 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 129267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129267&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:40:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:40:40 +0000 Subject: [Koha-bugs] [Bug 21051] CGI::param called in list context when editing a patron card layout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21051 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 18320 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:40:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:40:40 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 --- Comment #12 from Jonathan Druart --- *** Bug 21051 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:40:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:40:41 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Bug 29771 depends on bug 21051, which changed state. Bug 21051 Summary: CGI::param called in list context when editing a patron card layout https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21051 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:47:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:47:24 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #7 from Jonathan Druart --- The only good way to fix this bug is to remove the ugly line 816 $template->param(%data); And pass the patron object to the template. Lot of changes are needed template-side however. I can do it if there are commitments for quick SO and QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:48:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:48:23 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:57:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:57:20 +0000 Subject: [Koha-bugs] [Bug 26587] Cache libraries in Branches TT plugin to improve performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew at bywatersolutions.com --- Comment #35 from Andrew Fuerste-Henry --- Enhancement, not backporting to 21.05. Please ask if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 14:57:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 13:57:21 +0000 Subject: [Koha-bugs] [Bug 29826] Useless warning in t/db_dependent/Template/Plugin/Branches.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Bug 29826 depends on bug 26587, which changed state. Bug 26587 Summary: Cache libraries in Branches TT plugin to improve performance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:05:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:05:17 +0000 Subject: [Koha-bugs] [Bug 23149] Unsuspend button in staff interface is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23149 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 29060 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:05:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:05:17 +0000 Subject: [Koha-bugs] [Bug 29060] Use modal for suspending holds until a date from the holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #7 from Owen Leonard --- *** Bug 23149 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:13:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:13:24 +0000 Subject: [Koha-bugs] [Bug 19844] Z39.50 additional fields for authorities in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19844 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|add new column in the |Z39.50 additional fields |authorities Z39.50 search |for authorities in search |result page |results Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:13:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:13:31 +0000 Subject: [Koha-bugs] [Bug 29799] Z39.50 additional fields for authorities in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29799 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 19844 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:13:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:13:31 +0000 Subject: [Koha-bugs] [Bug 19844] Z39.50 additional fields for authorities in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19844 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viliam.polonec at snk.sk --- Comment #1 from Owen Leonard --- *** Bug 29799 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:21:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:21:11 +0000 Subject: [Koha-bugs] [Bug 29843] New: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Bug ID: 29843 Summary: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org This bug is the checkouts counterpart for bug 29525 and bug 29780. The pattern implemented there seems cleaner than the current implementation, so giving it a try so we clean things even further. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:22:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:22:13 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:28:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:28:41 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:28:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:28:41 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:28:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:28:45 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129266|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi --- Created attachment 129268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129268&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev > UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY); 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:33:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:33:41 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129269&action=edit Bug 29843: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:33:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:33:45 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129270&action=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:33:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:33:50 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129271&action=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:34:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:34:03 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:41:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:41:47 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #14 from Martin Renvoize --- Interesting.. on k-t-d I can't replicate your failures..? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:51:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:51:18 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 129272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129272&action=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 15:52:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 14:52:50 +0000 Subject: [Koha-bugs] [Bug 29613] Set focus for cursor to barcode field on course reserves add items and batch add items pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29613 --- Comment #5 from Eliana --- Katrin was right, it was another bit of our JQuery that was causing this issue. My bad! This bug is no long relevant. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:03:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:03:00 +0000 Subject: [Koha-bugs] [Bug 29457] Fee Cancellation records the wrong manager_id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29457 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | --- Comment #46 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:11:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:11:46 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02,21.05.08 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Andrew Fuerste-Henry --- 21.11 log shows this was pushed to 21.11.02. Pushed to 21.05.x for 21.05.08. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:11:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:11:52 +0000 Subject: [Koha-bugs] [Bug 29436] Cannot reorder facets in staff interface elasticsearch configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29436 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:17:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:17:15 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129265|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:17:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:17:18 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129267|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:17:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:17:21 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:17:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:17:52 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 129273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129273&action=edit Bug 29843: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:19:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:19:51 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129269|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi --- Created attachment 129274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129274&action=edit Bug 29843: Unit tests This patch adds unit tests for the introduced methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:19:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:19:55 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129270|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi --- Created attachment 129275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129275&action=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:19:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:19:59 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129271|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi --- Created attachment 129276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129276&action=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:20:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:20:04 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129272|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi --- Created attachment 129277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129277&action=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:20:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:20:11 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 129278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129278&action=edit Bug 29843: Use in tools/cleanborrowers.pl This patch makes tools/cleanborrowers.pl use the new methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:22:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:22:14 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #13 from Marcel de Rooy --- Still looking here a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:22:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:22:59 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #11 from Marcel de Rooy --- Still looking -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:38:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:38:00 +0000 Subject: [Koha-bugs] [Bug 29696] "Suggest for purchase" missing biblio link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29696 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:38:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:38:59 +0000 Subject: [Koha-bugs] [Bug 29588] Yesterday and tomorrow in datepicker don't translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29588 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #17 from Andrew Fuerste-Henry --- Missing dependency, not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:41:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:41:49 +0000 Subject: [Koha-bugs] [Bug 29390] Authorised values: Why not adding the FK on the way? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 --- Comment #6 from Marcel de Rooy --- Coming back here soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:46:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:46:49 +0000 Subject: [Koha-bugs] [Bug 29604] Term highlighting adds unwanted pseudo element in the contentblock of OPAC details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29604 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:52:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:52:45 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #11 from Martin Morris --- Hello there Both patches applied, and that worked! Many thanks for your efforts on resolving this bug. Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 16:52:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 15:52:52 +0000 Subject: [Koha-bugs] [Bug 29729] If serials_stats.pl returns no results dataTables get angry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29729 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | CC| |andrew at bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:00:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:00:52 +0000 Subject: [Koha-bugs] [Bug 29591] Add autorenew_checkouts to BorrowerMandatory/Unwanted fields system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29591 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | --- Comment #9 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:01:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:01:31 +0000 Subject: [Koha-bugs] [Bug 26975] Reindent authorities editor template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:01:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:01:35 +0000 Subject: [Koha-bugs] [Bug 26975] Reindent authorities editor template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116267|0 |1 is obsolete| | Attachment #116268|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 129279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129279&action=edit Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:01:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:01:40 +0000 Subject: [Koha-bugs] [Bug 26975] Reindent authorities editor template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 --- Comment #8 from Owen Leonard --- Created attachment 129280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129280&action=edit Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:01:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:01:50 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #8 from Andrew Nugged --- Great note from Katrin, I agree that the best solution is to replace: in members/paycollect.pl: $template->param(%$borrower); with something like: $template->param(borrower_data => $borrower); and in members/memberentry.pl: $template->param(%data); with something like: $template->param(borrower_data => \%data ); and then we need to update .tt files accordingly with all keys which were used from those %data/%$borrower directly-mapped ones. Jonathan, I can toss this to Petro to do again, and Tomás can SO and you QA then...? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:04:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:04:09 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #15 from Martin Renvoize --- humm.. my local branch misses the unit tests.. wonder why.. I can replicate now I've grabbed the patches here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:10:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:10:12 +0000 Subject: [Koha-bugs] [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:13:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:13:48 +0000 Subject: [Koha-bugs] [Bug 29689] Update to 21.11 broken auto-generated barcode in 0001 option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29689 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #16 from Andrew Fuerste-Henry --- Missing dependency, not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:14:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:14:28 +0000 Subject: [Koha-bugs] [Bug 29693] CodeMirror broken on additional_contents.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29693 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew at bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry --- Missing dependency, not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:17:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:17:17 +0000 Subject: [Koha-bugs] [Bug 24415] Authority enhancement - Improve access to tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |26975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 [Bug 26975] Reindent authorities editor template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:17:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:17:17 +0000 Subject: [Koha-bugs] [Bug 26975] Reindent authorities editor template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415 [Bug 24415] Authority enhancement - Improve access to tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 17:22:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 16:22:41 +0000 Subject: [Koha-bugs] [Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca --- Comment #11 from Noémie Labine --- Still valid ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 18:02:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 17:02:31 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to hold notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a configurable time |Add a configurable time |delay feature to notice |delay feature to hold |templates |notice templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 18:02:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 17:02:38 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to hold notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 18:42:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 17:42:16 +0000 Subject: [Koha-bugs] [Bug 24415] Authority enhancement - Improve access to tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 18:42:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 17:42:19 +0000 Subject: [Koha-bugs] [Bug 24415] Authority enhancement - Improve access to tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415 --- Comment #2 from Owen Leonard --- Created attachment 129281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129281&action=edit Bug 24415: Authority enhancement - Improve access to tabs This patch makes style changes to the authority record editor in order to make it easier to navigate among tabs and tags. This change matches the one made to the basic MARC editor in Bug 22045. Tabs are now part of the page's toolbar, which floats as the page scrolls. In addition to the numbered tabs, there is also a section showing in-page links to the MARC tags which are available on that page. To test, apply the patch and clear your browser cache if necessary. Open a blank or existing record in the authority record editor. Test the redesigned tabs, the floating toolbar, and the in-page tag links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 18:53:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 17:53:10 +0000 Subject: [Koha-bugs] [Bug 29732] Check alert in cataloguing authorities should be a static message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28694 Depends on|28694 |24415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415 [Bug 24415] Authority enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 [Bug 28694] Check alert in cataloguing should be a static message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 18:53:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 17:53:10 +0000 Subject: [Koha-bugs] [Bug 24415] Authority enhancement - Improve access to tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29732 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732 [Bug 29732] Check alert in cataloguing authorities should be a static message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 18:53:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 17:53:10 +0000 Subject: [Koha-bugs] [Bug 28694] Check alert in cataloguing should be a static message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29732 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29732 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29732 [Bug 29732] Check alert in cataloguing authorities should be a static message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 19:34:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 18:34:48 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 129282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129282&action=edit [21.05.x] Bug 29018: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 19:34:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 18:34:53 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 129283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129283&action=edit [21.05.x] Bug 29018: Make DELETE /patrons/:patron_id check things When the route was implemented, the checks were overlooked. This patch adds checks for: - Guarantees - Debts - Current checkouts Any of those will block deletion, as it should. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail, the route misses checks 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! The three conditions prevent deletion! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 19:53:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 18:53:49 +0000 Subject: [Koha-bugs] [Bug 29832] Make library column in desk list sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 19:53:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 18:53:53 +0000 Subject: [Koha-bugs] [Bug 29832] Make library column in desk list sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29832 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129251|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 129284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129284&action=edit Bug 29832: Make library column in desk list sortable This patch makes minor updates to the DataTable configuration on the Circulation Desks Administration page. Redundant options are removed and existing options are updated to use current DataTables syntax. To test, apply the patch and make sure that the UseCirculationDesks system preference is enabled. - Go to Administration -> Circulation desks. - Add multiple circulation desks if necessary, at multiple libraries. - The "Desk" column should be sorted by default, and the "Actions" column should not be sortable. - The "Library" column should be sortable. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 19:54:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 18:54:40 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 --- Comment #17 from Tomás Cohen Arazi --- The last patches should apply to 20.11 as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 20:02:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 19:02:30 +0000 Subject: [Koha-bugs] [Bug 29844] New: Remove uses of wantarray in Koha::Objects Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Bug ID: 29844 Summary: Remove uses of wantarray in Koha::Objects Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org They proved problematic, specially for template usage. Devs requiring list assignment should rely on ->as_list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 20:03:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 19:03:17 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28883 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 20:03:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 19:03:17 +0000 Subject: [Koha-bugs] [Bug 28883] Koha::Objects->_new_from_dbic doesn't work correctly in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28883 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29844 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 20:34:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 19:34:58 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 [Bug 29844] Remove uses of wantarray in Koha::Objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 20:34:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 19:34:58 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | CC| |jonathan.druart+koha at gmail. | |com Depends on| |29804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 20:35:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 19:35:24 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29804 |29806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 [Bug 29806] ->pickup_locations should always be called in scalar context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 20:35:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 19:35:24 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29844 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 [Bug 29844] Remove uses of wantarray in Koha::Objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 20:35:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 19:35:24 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 [Bug 29844] Remove uses of wantarray in Koha::Objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 20:54:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 19:54:06 +0000 Subject: [Koha-bugs] [Bug 29680] Reports menu 'Show SQL code' wrong border radius In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29680 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 21:02:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 20:02:48 +0000 Subject: [Koha-bugs] [Bug 20615] add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #3 from Patrick Robitaille --- Hello, My need is to see this information in the edit mode page also not just in the authority details page. Thanks, Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 21:19:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 20:19:59 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129285&action=edit Bug 29844: Remove use of wantarray from Koha::Objects This patch removes the use of `wantarray` from the following methods in the Koha::Objects class: - search - search_related In both cases, the change is trivial. And the tests get the 'list context' portion removed as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Caveat: we broke many things by removing the feature. Check follow-up patches as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 21:20:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 20:20:03 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129286&action=edit Bug 29844: Fix t/db_dependent/Koha/* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 21:21:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 20:21:08 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Tomás Cohen Arazi --- Ok, I did the easy part :-D Team work is welcome on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 21:28:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 20:28:06 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129285|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi --- Created attachment 129287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129287&action=edit Bug 29844: Remove use of wantarray from Koha::Objects This patch removes the use of `wantarray` from the following methods in the Koha::Objects class: - search - search_related In both cases, the change is trivial. And the tests get the 'list context' portion removed as well. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Caveat: we broke many things by removing the feature. Check follow-up patches as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 21:47:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 20:47:04 +0000 Subject: [Koha-bugs] [Bug 20615] add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #4 from George Veranis --- Hi Patrick, On edit mode of an authority as you can check also at the attached screenshot already exist . Can you please provide me more explanation , or maybe a screenshot , where you expect to have that info that you need ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 22:39:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 21:39:42 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 --- Comment #19 from Sarah Cornell --- I'm just stopping by to poke this bug back into life. We're still interested in reordering title, firstname, surname, and othername values in patron details. Not sure how else I can help, though! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:07:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:07:30 +0000 Subject: [Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #18 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:10:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:10:56 +0000 Subject: [Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:11:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:11:13 +0000 Subject: [Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gveranis at dataly.gr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:11:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:11:49 +0000 Subject: [Koha-bugs] [Bug 29825] Preview of authority record on edit mode as MARC formatted view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29825 --- Comment #2 from George Veranis --- Yes you are right, I just did that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:12:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:12:28 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:26:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:26:17 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:38:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:38:44 +0000 Subject: [Koha-bugs] [Bug 29845] New: Styling OverDrive buttons is difficult Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Bug ID: 29845 Summary: Styling OverDrive buttons is difficult Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some librarians would like style the buttons on the Dverdrive results page differently from one another. I realized this is somewhat difficult to do at the moment because each of those buttons are built by JavaScript and don't include a unique class name or ID. Those buttons are the check-in, check-out, place hold, cancel hold, and download as buttons. If they had an ID it would make it easy to style them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:43:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:43:00 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes an error that |This fixes an error that release notes|causes the most circulated |causes the most circulated |items report to fail when |items report to fail when |run on a database with SQL |run on a database with SQL |mode ONLY_FULL_GROUP_BY and |mode ONLY_FULL_GROUP_BY and |in struct SQL mode. |in strict SQL mode. CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:47:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:47:53 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #9 from Fridolin Somers --- Do we still need "DISTINCT" on biblio.title ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:52:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:52:02 +0000 Subject: [Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:52:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:52:05 +0000 Subject: [Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 --- Comment #1 from Lucas Gass --- Created attachment 129288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129288&action=edit Bug 29845: add IDs to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold, and download as buttons, none of them contain ID's. 4. Apply patch 5. Repeat 3 again but this time they should all contain an ID which makes them much easier to style. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 10 23:56:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 22:56:51 +0000 Subject: [Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds ID's to the action release notes| |buttons on the OverDrive | |results page in order to | |make them easier to | |individually style. Patch complexity|--- |Trivial patch Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 00:29:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 23:29:03 +0000 Subject: [Koha-bugs] [Bug 19379] Selenium test for the list workflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19379 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 00:30:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Jan 2022 23:30:17 +0000 Subject: [Koha-bugs] [Bug 19379] Selenium test for the list workflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19379 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |alexbuckley at catalyst.net.nz --- Comment #2 from Alex Buckley --- Opps accidentally removed myself as assignee. I aim to revisit this in the near future and rebase and potentially rework this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 01:41:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 00:41:39 +0000 Subject: [Koha-bugs] [Bug 29060] Use modal for suspending holds until a date from the holds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29060 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Please look at changes from Bug 29737 "Fix suspend from hold list" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 01:42:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 00:42:35 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 --- Comment #7 from Fridolin Somers --- Thanks a lot Owen for release notes :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 02:29:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 01:29:15 +0000 Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909 --- Comment #27 from David Cook --- Unless I'm missing something, this doesn't take into account OpacSuppression. Is that right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 02:59:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 01:59:31 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 09:15:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 08:15:34 +0000 Subject: [Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 --- Comment #20 from Jonathan Druart --- (In reply to Jonathan Druart from comment #16) > When no_html is passed, the spans won't appear and the elements won't be > hidden. Title elements cannot contain other html tags, and that's why we have the no_html option. If we want a fully working solution we should have a syspref that defines how patron's names are displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 09:47:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 08:47:27 +0000 Subject: [Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #7 from Alex Buckley --- (In reply to Marcel de Rooy from comment #6) > (In reply to Alex Buckley from comment #5) > > Hi there, > > > > In bug 26346 I've added the ability to create public lists that are only > > editable by staff, but viewable by all. > > > > Question: Rather than add a 'Share' button in the staff client would it be > > the cleaner solution to revert bug 28959 , and add a third category of > > 'Restricted' which is viewable by all in the staff client, and by staff > > users in the OPAC? > > > > I'm not sure what the best practice is for reverting patches that have been > > upstreamed? > > Fun, I commented on bug 28959 earlier that we were on the "wrong track" > there. > But Restricted is imho not directly a candidate for a new category. It > sounds more like a security thing on lists. (Similarly, Shared is still no > category, but a more limited implementation using private lists.) > > This whole thing with public lists and staff users is duplicated on several > reports still, and hunts us already for years. Hi Marcel, Thanks for your reply. Just to make sure I'm understanding correctly, it sounds like, in your view, lists viewable to staff would be best implemented as a private list. That has a 'share' button so the user can search for, and select, those staff members they want the list visible for? Am I understanding that correctly? Thanks Alex -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 10:01:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 09:01:41 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 10:01:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 09:01:44 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 --- Comment #1 from George Veranis --- Created attachment 129289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129289&action=edit Bug20362: Direct link to authority records missing in staff detail view (1xx , 7xx) I added a magnigying glass icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 10:02:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 09:02:16 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 10:13:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 09:13:19 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |jonathan.druart+koha at gmail. | |com Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 10:37:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 09:37:55 +0000 Subject: [Koha-bugs] [Bug 29846] New: Missing documentation system preferences for Overdrive Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29846 Bug ID: 29846 Summary: Missing documentation system preferences for Overdrive Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: mik at adminkuhn.ch QA Contact: testopia at bugs.koha-community.org There are four system preferences that are not documented in the Koha manual. * OverDriveAuthName * OverDriveUsername * OverDrivePasswordRequired * OverDriveWebsiteID Some hints are given in https://bywatersolutions.com/education/overdrive-integration-in-koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 11:18:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 10:18:32 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #5 from Jonathan Druart --- Created attachment 129290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129290&action=edit Bug 29844: Fix ->search occurrences and some more... There are lot of inconsistencies in our ->search calls. We could simplify some of them, but not in this patch. Here we want to prevent regressions as much as possible and so don't add unecessary changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 11:51:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 10:51:01 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129290|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 129291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129291&action=edit Bug 29844: Fix ->search occurrences and some more... There are lot of inconsistencies in our ->search calls. We could simplify some of them, but not in this patch. Here we want to prevent regressions as much as possible and so don't add unecessary changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 11:56:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 10:56:44 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|jonathan.druart+koha at gmail. |tomascohen at gmail.com |com | --- Comment #7 from Jonathan Druart --- Ok so, what do we do now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 13:24:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 12:24:33 +0000 Subject: [Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 --- Comment #8 from Marcel de Rooy --- If I am reading the comment from Jeremy again (from 2017..) and my response in 2017, they could have used private lists shared between the needed staff members at that time already (but using OPAC) without the need for any code changes. I think there is a report about adding code for supporting shared lists in staff too. But I would certainly not oppose a permission scheme that allows selected staff members to view *some* lists. Just another road. In the past we were very cautious here in view of privacy issues though. But there should be ways to address that and inform users accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 13:26:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 12:26:15 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #8 from Marcel de Rooy --- Tomas, you flexibility is unparalleled :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 13:52:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 12:52:41 +0000 Subject: [Koha-bugs] [Bug 29284] Koha dies when an analytics search fails in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29284 --- Comment #13 from Martin Renvoize --- Doesn't 20.11 need this too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 13:53:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 12:53:49 +0000 Subject: [Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #118 from Martin Renvoize --- Any chance of having this for 20.11 now that 29284 is in master and 21.11 and 21.05? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 13:57:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 12:57:46 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 129292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129292&action=edit Bug 29844: Some more uncaught cases Some more cases found using $ git grep '\->search(' | grep -v -e '\->as_list' -e '\->get_column' \ | grep '@' and then manually looking at them. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 14:07:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 13:07:18 +0000 Subject: [Koha-bugs] [Bug 29159] UNIMARC update from IFLA for new Koha installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29159 Koha Team University Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr, | |laurence.rault at biblibre.com | |, | |thibault.keromnes at univ-pari | |s8.fr --- Comment #2 from Koha Team University Lyon 3 --- Hi Igor, just for information, the French user group KohaLa sponsored a development for that. It should be submitted in a few weeks/months. Sonia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 14:28:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 13:28:03 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129292|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi --- Created attachment 129293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129293&action=edit Bug 29844: Some more uncaught cases Some more cases found using $ git grep '\->search(' | grep -v -e '\->as_list' -e '\->get_column' \ | grep '@' and then manually looking at them. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 14:32:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 13:32:01 +0000 Subject: [Koha-bugs] [Bug 20615] add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #5 from Patrick Robitaille --- Hi, In the screenshot you added, you are at the authority details page. Here you can see the number of notices attached. What I would like is that when we click on 'Edit' and switch to the authority's edit page to also have this information that shows the number of records attached on that page. Is it clearer to you? I added a screenshot to this task Thanks, Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 14:34:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 13:34:01 +0000 Subject: [Koha-bugs] [Bug 20615] add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #6 from Patrick Robitaille --- Created attachment 129294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129294&action=edit Authority edit page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 14:38:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 13:38:05 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Tomás Cohen Arazi --- I'm running (again) the test suite on my computer. But we really need Frido here. This is a candidate to get pushed early so we catch any outstanding issues timely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 14:47:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 13:47:25 +0000 Subject: [Koha-bugs] [Bug 20615] add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gveranis at dataly.gr |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 14:48:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 13:48:11 +0000 Subject: [Koha-bugs] [Bug 20615] add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 --- Comment #7 from George Veranis --- Yes, now is more clear , sorry to not understand it earlier ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 14:48:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 13:48:29 +0000 Subject: [Koha-bugs] [Bug 20615] add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 14:58:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 13:58:28 +0000 Subject: [Koha-bugs] [Bug 29847] New: Koha::Patron::HouseboundProfile->housebound_visits should return a resultset Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 Bug ID: 29847 Summary: Koha::Patron::HouseboundProfile->housebound_visits should return a resultset Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org This method incorrectly converts the underlying resultset into an arrayref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 14:58:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 13:58:46 +0000 Subject: [Koha-bugs] [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com Depends on| |29844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 [Bug 29844] Remove uses of wantarray in Koha::Objects -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 14:58:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 13:58:46 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29847 [Bug 29847] Koha::Patron::HouseboundProfile->housebound_visits should return a resultset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:01:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:01:42 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129293|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi --- Created attachment 129295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129295&action=edit Bug 29844: Some more uncaught cases Some more cases found using $ git grep '\->search(' | grep -v -e '\->as_list' -e '\->get_column' \ | grep '@' and then manually looking at them. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:02:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:02:29 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #14 from Marcel de Rooy --- What I still have trouble with here most, is that the two filter methods have a generic name but they relate to debits. We could use: my $total_reversible = $debit->debit_offsets->filter_by_reversible->total; But what if we want to filter credits? my $total_reversible = $credit->credit_offsets->filter_by_reversible->total; That would make no sense; the code refers to credit_id and amount < 0. So, in other words, does the name really reflect what we are doing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:05:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:05:46 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #14) > What I still have trouble with here most, is that the two filter methods > have a generic name but they relate to debits. > > We could use: > my $total_reversible = $debit->debit_offsets->filter_by_reversible->total; > > But what if we want to filter credits? > my $total_reversible = $credit->credit_offsets->filter_by_reversible->total; > That would make no sense; the code refers to credit_id and amount < 0. > > So, in other words, does the name really reflect what we are doing? I agree. Martin and I have been talking about subclassing Koha::Acount::Line(s) so we have proper classes for debits and credits. In that case, we could move those methods there. I'm fine with a method name change. I ran out of ideas, though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:26:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:26:19 +0000 Subject: [Koha-bugs] [Bug 29741] Add Koha::Patron->safe_to_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew at bywatersolutions.com --- Comment #19 from Andrew Fuerste-Henry --- Enhancement, not pushed to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:26:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:26:20 +0000 Subject: [Koha-bugs] [Bug 29742] Make deletemem.pl use Koha::Patron->safe_to_delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29742 Bug 29742 depends on bug 29741, which changed state. Bug 29741 Summary: Add Koha::Patron->safe_to_delete https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:26:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:26:21 +0000 Subject: [Koha-bugs] [Bug 29765] Make Koha::Patron->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765 Bug 29765 depends on bug 29741, which changed state. Bug 29741 Summary: Add Koha::Patron->safe_to_delete https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29741 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:29:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:29:46 +0000 Subject: [Koha-bugs] [Bug 29503] GET /patrons should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29503 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com --- Comment #13 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:33:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:33:05 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 --- Comment #16 from Marcel de Rooy --- Created attachment 129296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129296&action=edit Bug 29757: (QA follow-up) Remove abs from the test Obviously abs has two sides, and we could allow wrong results. We can be more precise here. Trivial exercise. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:33:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:33:29 +0000 Subject: [Koha-bugs] [Bug 29757] Add filter_by_non_reversible/reversible methods for offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29757 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129296|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Comment on attachment 129296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129296 Bug 29757: (QA follow-up) Remove abs from the test Oops -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:33:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:33:49 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #12 from Marcel de Rooy --- Created attachment 129297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129297&action=edit Bug 29757: (QA follow-up) Remove abs from the test Obviously abs has two sides, and we could allow wrong results. We can be more precise here. Trivial exercise. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:34:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:34:15 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #13 from Marcel de Rooy --- Created attachment 129298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129298&action=edit Bug 29759: (QA follow-up) Remove abs from the test Obviously abs has two sides, and we could allow wrong results. We can be more precise here. Trivial exercise. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:34:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:34:36 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129297|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Comment on attachment 129297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129297 Bug 29757: (QA follow-up) Remove abs from the test Wrong bug number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:35:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:35:10 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #15 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #9) > (In reply to Martin Renvoize from comment #7) > > hmm.. I'm still not 100% sure of this. > > > > Scenario 1 > > 1. Article request placed, fee added > > 2. Article request cancelled, fee cancelled (currently appears as a refund) > > > > Scenario 2 > > 1. Article request placed, fee added > > 2. Patron pays full amount > > 3. Article request cannot be fulfilled so is cancelled > > 4. Paid fee is refunded.. I feel like this should be linked to the 'payment' > > rather than the original 'charge' ? > > > > Scenario 3 > > 1. Article request placed, fee added > > 2. Patron pays some amount > > 3. Article request is cancelled > > 4. Patron is 'refunded' the amount paid (but it links to the charge, not the > > payment) > > 5. Patron is also 'refunded' the outstanding amount (again, links to the > > charge) > > > > I think these could end up rather confusing in the accounts screen. > > Nice catch! I think it is clear this needs to point to the payment! Still looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 15:44:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 14:44:23 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #16 from Marcel de Rooy --- Martin, what about scenario 4: Fee charged 10 Paid 2 Paid 3 Cancelled Now we cannot link to "the payment" because we have two payments. We can split the credit because we want to link to all individual payments. But I feel that does not make much sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:01:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:01:45 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 129299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129299&action=edit [21.05.x] Bug 29506: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:01:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:01:49 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 129300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129300&action=edit [21.05.x] Bug 29506: Make objects.search call search_limited if present This patch makes objects.search implicitly update the passed *$result_set* to use search_limited. This way no object leaks could happen without noticing. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail because search_limited is not used 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Results are correctly filtered based on userenv! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:01:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:01:54 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 129301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129301&action=edit [21.05.x] Bug 29506: (follow-up) Adapt GET /patrons This patch makes GET /patrons rely on this new behavior from the objects.search helper. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:07:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:07:30 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #17 from Marcel de Rooy --- Bit out of scope, but anyway: When I have an AR fee, I pay an amount, and then void the payment on Transactions, I can afterwards issue a refund on the voided credit. Should that really be possible? Similarly, I can do Void payment on the Refund. Huh? Then i can click Pay on Payment from library to patron. Huh? Not sure if we should allow all these actions which can really mess up the whole balance? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:18:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:18:19 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #18 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #16) > Martin, what about scenario 4: > > Fee charged 10 > Paid 2 > Paid 3 > Cancelled > > Now we cannot link to "the payment" because we have two payments. We can > split the credit because we want to link to all individual payments. But I > feel that does not make much sense? Having the impression that the argument of confusing transactions definitely applies on voiding individual offsets here. I would go for the cumulative credit that Tomas implemented. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:23:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:23:20 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 --- Comment #19 from Marcel de Rooy --- And as a final note: If we could rework $accountline->cancel someday, we could perhaps move this code out of the article requests domain. $debit_accountline->cancel(); Cancel a charge. It will mark the debit as 'cancelled' by updating its status to 'CANCELLED'. Charges that have been fully or partially paid cannot be cancelled. Since we can void payments as well, it would be nice to allow cancelling of partially paid debit account lines. Moving the add_credit/reduce thing to where it really belongs. In the meantime this looks good enough to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:25:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:25:12 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:25:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:25:16 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129181|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy --- Created attachment 129302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129302&action=edit Bug 29759: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:25:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:25:20 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129182|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy --- Created attachment 129303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129303&action=edit Bug 29759: Make cancelling an AR refund This patch makes the Koha::ArticleRequest->cancel method perform a refund if it applies. The sequence is: - Find refundable (potentially partial) payments against the fee - Generate a refund for the refundable amount - Reduce the fee to zero => RESULT: the patron owes nothing, any credits applied to the debit are refunded. 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequest.t => FAIL: Nothing is refunded 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Refunds take place! 5. Try on the UI => SUCCESS: All good 6. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:25:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:25:24 +0000 Subject: [Koha-bugs] [Bug 29759] Refund credit when cancelling an article request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129298|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy --- Created attachment 129304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129304&action=edit Bug 29759: (QA follow-up) Remove abs from the test Obviously abs has two sides, and we could allow wrong results. We can be more precise here. Trivial exercise. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:25:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:25:50 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:58:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:58:35 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126566|0 |1 is obsolete| | --- Comment #793 from Marcel de Rooy --- Created attachment 129305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129305&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:58:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:58:45 +0000 Subject: [Koha-bugs] [Bug 28886] Remove uses of ->as_list from the codebase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28886 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Tomás Cohen Arazi --- We decided to actually use ->as_list all over the place :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:58:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:58:47 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126568|0 |1 is obsolete| | --- Comment #794 from Marcel de Rooy --- Created attachment 129306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129306&action=edit Bug 19532: Updated schema files Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:58:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:58:59 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126569|0 |1 is obsolete| | --- Comment #795 from Marcel de Rooy --- Created attachment 129307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129307&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:59:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:59:11 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126570|0 |1 is obsolete| | --- Comment #796 from Marcel de Rooy --- Created attachment 129308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129308&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:59:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:59:23 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126571|0 |1 is obsolete| | --- Comment #797 from Marcel de Rooy --- Created attachment 129309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129309&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:59:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:59:35 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126572|0 |1 is obsolete| | --- Comment #798 from Marcel de Rooy --- Created attachment 129310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129310&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 16:59:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 15:59:52 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126573|0 |1 is obsolete| | --- Comment #799 from Marcel de Rooy --- Created attachment 129311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129311&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:00:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:00:06 +0000 Subject: [Koha-bugs] [Bug 28906] Koha::Items->filter_by_visible_in_opac doesn't honour list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28906 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29844 Resolution|--- |INVALID Status|BLOCKED |RESOLVED --- Comment #13 from Tomás Cohen Arazi --- We decided to actually drop support for wantarray altogether in Koha::Objects. See bug 29844. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:00:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:00:05 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126574|0 |1 is obsolete| | --- Comment #800 from Marcel de Rooy --- Created attachment 129312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129312&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:00:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:00:06 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28906 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:00:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:00:23 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126575|0 |1 is obsolete| | --- Comment #801 from Marcel de Rooy --- Created attachment 129313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129313&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:00:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:00:43 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126576|0 |1 is obsolete| | --- Comment #802 from Marcel de Rooy --- Created attachment 129314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129314&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:01:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:01:10 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126577|0 |1 is obsolete| | --- Comment #803 from Marcel de Rooy --- Created attachment 129315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129315&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:01:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:01:24 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126578|0 |1 is obsolete| | --- Comment #804 from Marcel de Rooy --- Created attachment 129316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129316&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:01:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:01:36 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126579|0 |1 is obsolete| | --- Comment #805 from Marcel de Rooy --- Created attachment 129317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129317&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:01:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:01:51 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126580|0 |1 is obsolete| | --- Comment #806 from Marcel de Rooy --- Created attachment 129318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129318&action=edit Bug 19532: (follow-up) Fix calls, tests, syspref settings, checks Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:02:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:02:06 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #807 from Marcel de Rooy --- Created attachment 129319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129319&action=edit Bug 19532: (QA follow-up) Enable XSLT statuses translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:02:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:02:52 +0000 Subject: [Koha-bugs] [Bug 29785] Koha::Object->messages must be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:04:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:04:29 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #808 from Marcel de Rooy --- I rebased what we had. Didnt check yet. Katrin, Fridolin, Aleisha, David, Victor: When can we work on this patch set this month? Would be handy to plan our actions now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:21:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:21:10 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:24:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:24:04 +0000 Subject: [Koha-bugs] [Bug 27320] Add collection and shelving location options to MARC export tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27320 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:42:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:42:53 +0000 Subject: [Koha-bugs] [Bug 26764] schema.koha-community.org 'display all' ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26764 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org --- Comment #6 from Michael Adamyk --- I wasn't able to use Katrin's link, but I did find the issue posted on GitHub. https://github.com/schemaspy/schemaspy/issues/771 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:44:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:44:13 +0000 Subject: [Koha-bugs] [Bug 27892] api/v1/acquisitions_vendors.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27892 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:46:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:46:53 +0000 Subject: [Koha-bugs] [Bug 27892] api/v1/acquisitions_vendors.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27892 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC|madamyk at ckls.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 17:59:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 16:59:36 +0000 Subject: [Koha-bugs] [Bug 29848] New: Add option to increase fund warnings when met Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29848 Bug ID: 29848 Summary: Add option to increase fund warnings when met Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When setting up a fund, one can provide an amount and/or percentage of money expended beyond which to warn the user. Once that limit has been exceeded, all subsequent orders against that will generate a warning. It would be helpful if the warning popup provided an easy interface with which to increase the warning amount and / or percentage. That would allow the user to do something like set a warning for 50% and, upon reaching that, increase the percentage to 75% in order to get a future warning at another significant point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 18:01:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 17:01:33 +0000 Subject: [Koha-bugs] [Bug 29849] New: Add ability to dismiss fund warning for a session Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29849 Bug ID: 29849 Summary: Add ability to dismiss fund warning for a session Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When setting up a fund, one can provide an amount and/or percentage of money expended beyond which to warn the user. Once that limit has been exceeded, all subsequent orders against that will generate a warning. It would be helpful to be able to dismiss this warning and have Koha remember that for the session, so subsequent orders against the same fund do not repeat the message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 18:10:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 17:10:12 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #10 from Michael Hafen --- (In reply to Fridolin Somers from comment #9) > Do we still need "DISTINCT" on biblio.title ? Maybe so; depends on how likely it is that separate biblios will have the same title, and whether the library would want those separate records grouped together. In my case, we'd probably want the records grouped together. I tried the query in MySQL 8.0 with and without the 'DISTINCT', and there was 1 row difference. Though my case is probably not typical, being a school district with a bunch of schools that migrated from separate databases into one instance of Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 18:54:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 17:54:51 +0000 Subject: [Koha-bugs] [Bug 29850] New: Identical values to choose from in preference "todaysIssuesDefaultSortOrder" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29850 Bug ID: 29850 Summary: Identical values to choose from in preference "todaysIssuesDefaultSortOrder" Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: mik at adminkuhn.ch QA Contact: testopia at bugs.koha-community.org In the German translation Koha system preference "todaysIssuesDefaultSortOrder" offers two identical values to choose from: * von neuestem nach ältestem * von neuestem nach ältestem The first one should in fact be * von ältestem zu neuestem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 19:04:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 18:04:54 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- Can you please remove the comment, " https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129320&action=edit Bug 29840: Deal with non-existing biblionumber in opac-reserve We should not explode if the biblionumber passed in not in DB. Test plan: Hit /cgi-bin/koha/opac-reserve.pl?biblionumber=42424 and notice the error message. Without this patch you got Can't call method "holds" on an undefined value at /kohadevbox/koha/opac/opac-reserve.pl line 172 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 19:46:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 18:46:26 +0000 Subject: [Koha-bugs] [Bug 10814] Add a link to shelving locations / LOC authorised value for pointing to a map or similar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10814 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon --- *** This bug has been marked as a duplicate of bug 737 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 19:46:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 18:46:26 +0000 Subject: [Koha-bugs] [Bug 737] Map of library in search system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=737 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #8 from Christopher Brannon --- *** Bug 10814 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:13:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:13:19 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129266|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:13:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:13:44 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129267|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:14:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:14:37 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129268|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:14:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:14:53 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129273|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:17:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:17:20 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129266|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:17:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:17:31 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129267|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:17:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:17:37 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:18:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:18:36 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 129321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129321&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:18:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:18:45 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 129322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129322&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev > UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY); 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:18:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:18:53 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 129323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129323&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:27:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:27:15 +0000 Subject: [Koha-bugs] [Bug 737] Map of library in search system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=737 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #9 from Christopher Brannon --- Would love to see this get some steam behind it again. I could easily see an authorized value category with codes to urls for specific locations in the library. This would work great as we could limit codes to specific libraries. Then we would just need a table linking the item to a code, and make this selectable in item editing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:27:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:27:28 +0000 Subject: [Koha-bugs] [Bug 737] Map of library in search system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=737 --- Comment #10 from Christopher Brannon --- Would love to see this get some steam behind it again. I could easily see an authorized value category with codes to urls for specific locations in the library. This would work great as we could limit codes to specific libraries. Then we would just need a table linking the item to a code, and make this selectable in item editing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:28:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:28:27 +0000 Subject: [Koha-bugs] [Bug 29851] New: Prevent cancellation by patron of certain holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29851 Bug ID: 29851 Summary: Prevent cancellation by patron of certain holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We have partner libraries using the ILL module with a backend that generates holds. If the patron cancels the hold via the OPAC, it fouls up the ILL workflow. It'd be great to have a method to prevent these holds from being cancelled by the patron (without preventing patron-instigated cancellation of *all* holds). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 20:54:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 19:54:58 +0000 Subject: [Koha-bugs] [Bug 29852] New: Add option to exclude certain types of url in check-url-quick.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29852 Bug ID: 29852 Summary: Add option to exclude certain types of url in check-url-quick.pl Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at collecto.ca QA Contact: testopia at bugs.koha-community.org Hi, It would be nice to exclude certain urls from the check-url-quick.pl script such as urls which are searchable via a proxy. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 21:03:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 20:03:20 +0000 Subject: [Koha-bugs] [Bug 737] Map of library in search system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=737 --- Comment #11 from Christopher Brannon --- Actually, instead of linking specific items to maps, I would suggest that perhaps there could be some way of specifying a specific combination of branch and shelving location in the Authorized Values table that, if matched on a item in the record details, an symbol appears next to the shelving location that patrons can click on to show the map in a model. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 21:30:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 20:30:58 +0000 Subject: [Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 21:31:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 20:31:01 +0000 Subject: [Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129288|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 129324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129324&action=edit Bug 29845: add IDs to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold, and download as buttons, none of them contain ID's. 4. Apply patch 5. Repeat 3 again but this time they should all contain an ID which makes them much easier to style. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 21:31:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 20:31:09 +0000 Subject: [Koha-bugs] [Bug 737] Map of library in search system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=737 --- Comment #12 from Christopher Brannon --- Still chewing on this. You wouldn't have to have a separate table to link libraries, shelving locations and maps, if you created specific shelving locations for each library, limiting that location to that library. That would create a long shelving locations table, but it would mean not creating a new table, and if you are limiting to the library, that library is only seeing their shelving locations. Theoretically, that would work. With each unique shelving location code, I would create a separate Authorized Value in a category like SHELVINGMAPS, and use the same shelving location code, and provide the url. In jQuery, I would find the itemnumber, get the shelving code, and then link the map. This would be more ideal if it were built in. Better yet, if I am going to the trouble of creating individual shelving locations for each library, why not take advantage of the icons for that location. It would be great if we could upload our own images for a custom icon, and just define the map in the shelving location. (Unless the icons for shelving locations are actually used somewhere.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 21:35:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 20:35:36 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |alexbuckley at catalyst.net.nz Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 22:07:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 21:07:15 +0000 Subject: [Koha-bugs] [Bug 29852] Add option to exclude certain types of url in check-url-quick.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29852 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 22:19:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 21:19:34 +0000 Subject: [Koha-bugs] [Bug 29419] Suggest for purchase clears item type, quantity, library and reason if bib exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin Somers --- When pushing master, had a little conflict because of Bug 26296 But changes are not related, not on same line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 22:20:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 21:20:05 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #33 from Hayley Pelham --- Hi Jonathan, Thanks for letting me know. I've gone through and followed this: https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha And made sure to install that module now. I can get a server running, but get an exception when trying to prove the test: org.openqa.selenium.firefox.NotConnectedException: Unable to connect to host 127.0.0.1 on port 7055 after 45000 ms So I may have to leave the testing here to someone else. Are the Selenium wiki docs up to date? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 22:42:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 21:42:21 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #11 from Fridolin Somers --- (In reply to Michael Hafen from comment #10) > (In reply to Fridolin Somers from comment #9) > > Do we still need "DISTINCT" on biblio.title ? > > Maybe so; depends on how likely it is that separate biblios will have the > same title, and whether the library would want those separate records > grouped together. > In my case, we'd probably want the records grouped together. I tried the > query in MySQL 8.0 with and without the 'DISTINCT', and there was 1 row > difference. Though my case is probably not typical, being a school district > with a bunch of schools that migrated from separate databases into one > instance of Koha. Is there then a need to group by biblionumber ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 22:43:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 21:43:04 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #12 from Fridolin Somers --- Ah that is strange. Looks like callnumber is not displayed in result table. This has been added by Bug 10154 as a filter, but looks there there is no need to add in the SELECT. Can someone confirm ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 22:52:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 21:52:46 +0000 Subject: [Koha-bugs] [Bug 29557] Auto renew notices should handle failed renewal due to patron expiration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- While pushing master, I've moved note in dbrev into a "say $out". Renders better : kohadev-koha at kohadevbox:/kohadevbox/koha$ ./installer/data/mysql/updatedatabase.pl Upgrade to 21.12.00.006 [21:50:56]: Bug 29557 - Add auto_account_expired to AUTO_RENEWALS notice Please update your AUTO_RENEWALS notice manually if you have changed or translated it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:04:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:04:22 +0000 Subject: [Koha-bugs] [Bug 29508] GET /patrons/:patron_id should use Koha::Patrons->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29508 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com --- Comment #10 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:04:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:04:39 +0000 Subject: [Koha-bugs] [Bug 29506] objects.search should call search_limited if present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29506 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.08 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #17 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:45:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:45:14 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Passed QA |Failed QA --- Comment #6 from Fridolin Somers --- QA tools returns : FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt FAIL filters missing_filter at line 59 ( The [% pref_MARCOverlayRules_link | $KohaSpan %] preference is not set, don't forget to enable it for rules to take effect.) I'm opening a new report for the usage of KohaSpan + filters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:48:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:48:55 +0000 Subject: [Koha-bugs] [Bug 29853] New: Text needs HTML filter before KohaSpan filter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29853 Bug ID: 29853 Summary: Text needs HTML filter before KohaSpan filter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Usage of Template Toolkit plugin KohaSpan as filter is actually : Group [% added.title | $KohaSpan class = 'name' | $raw %] created. But KohaSpan filter does not escape HTML characters. Whe should filter HTML then KohaSpan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:49:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:49:16 +0000 Subject: [Koha-bugs] [Bug 29853] Text needs HTML filter before KohaSpan filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29853 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29589 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:49:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:49:16 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29853 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:49:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:49:26 +0000 Subject: [Koha-bugs] [Bug 29853] Text needs HTML filter before KohaSpan filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29853 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:27 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:30 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 --- Comment #17 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:32 +0000 Subject: [Koha-bugs] [Bug 29419] Suggest for purchase clears item type, quantity, library and reason if bib exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:35 +0000 Subject: [Koha-bugs] [Bug 29419] Suggest for purchase clears item type, quantity, library and reason if bib exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:37 +0000 Subject: [Koha-bugs] [Bug 29557] Auto renew notices should handle failed renewal due to patron expiration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:39 +0000 Subject: [Koha-bugs] [Bug 29557] Auto renew notices should handle failed renewal due to patron expiration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:42 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:44 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:46 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:48 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 --- Comment #18 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:51 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:53 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:55 +0000 Subject: [Koha-bugs] [Bug 29790] Deleting serial items fail without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:51:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:51:58 +0000 Subject: [Koha-bugs] [Bug 29790] Deleting serial items fail without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 11 23:56:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 22:56:21 +0000 Subject: [Koha-bugs] [Bug 29853] Text needs HTML filter before KohaSpan filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29853 --- Comment #1 from Fridolin Somers --- > git grep '$KohaSpan' -- koha-tmpl/ koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt: [% added.library.branchname | $KohaSpan class = 'name' | $raw %] added to group. koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt: Group [% added.title | $KohaSpan class = 'name' | $raw %] created. koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt: Group [% deleted.title | $KohaSpan class = 'name' | $raw %] has been deleted. koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt: [% deleted.library | $KohaSpan class = 'name' | $raw %] has been removed from group. koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt: A group with the title [% error_duplicate_title | $KohaSpan class = 'name' | $raw %] already exists. We can reproduce in library groups page : Create a new library group with title : Mygroupe Save the form. You see a message box with : Group Mygrou -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 00:17:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Jan 2022 23:17:55 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 --- Comment #11 from AspenCat Team --- Since this works - YAY, could this be applied to batch item modification (such as changing a captured group in the call number and changing it to upper case)? I tried in sandbox after patch applied and did not work, should it have? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 01:59:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 00:59:15 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #15 from Victor Grousset/tuxayo --- Missing dependencies for 20.11.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 06:51:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 05:51:53 +0000 Subject: [Koha-bugs] [Bug 29853] Text needs HTML filter before KohaSpan filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29853 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 06:51:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 05:51:57 +0000 Subject: [Koha-bugs] [Bug 29853] Text needs HTML filter before KohaSpan filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29853 --- Comment #2 from Fridolin Somers --- Created attachment 129325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129325&action=edit Bug 29853: Add HTML filter before KohaSpan filter Usage of Template Toolkit plugin KohaSpan as filter is actually : Group [% added.title | $KohaSpan class = 'name' | $raw %] created. But KohaSpan filter does not escape HTML characters. Whe should filter HTML then KohaSpan. This patch adds TT html filter before KohaSpan. Also replaces in Javascript html() with text() to ensure special caracters are still encoded. See https://api.jquery.com/text/ Test plan : 1) Create a library with name Libra'rie 2) Create a library group with name Grou'pe 3) Play with this group 4) Add library 5) Remove library 6) Edit group 7) Delete group 8) Each time check that &apos, is not interpreted as single quote -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 06:55:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 05:55:35 +0000 Subject: [Koha-bugs] [Bug 29853] Text needs HTML filter before KohaSpan filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29853 --- Comment #3 from Fridolin Somers --- Maybe we should have a coding guide line for this. Is see it is quite different for SMTP servers : $("#delete_confirm_dialog").html( _("You are about to delete the '%s' SMTP server.").format(smtp_server_name) ); https://git.koha-community.org/Koha-community/Koha/src/commit/a6ef152db9e71805efe8e7dd6b2f8549da0f65b4/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt#L392 Looks better for translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 07:13:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 06:13:04 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- + } else { + @libraries = Koha::Libraries->search( { pickup_location => 1 }, { order_by => ['branchname'] } ) + unless @libraries; Do we still need "unless @libraries" ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 07:32:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 06:32:28 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #19 from Fridolin Somers --- Ah Test suite fails on t/db_dependent/Reserves.t : https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/505/testReport/ I see it needs to be fixed like t/db_dependent/Circulation/IsItemIssued.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 07:33:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 06:33:05 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 --- Comment #20 from Fridolin Somers --- Created attachment 129326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129326&action=edit Bug 29788: Fix t/db_dependent/Reserves.t Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 07:55:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 06:55:52 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 --- Comment #13 from Fridolin Somers --- (In reply to Tomás Cohen Arazi from comment #11) > I'm running (again) the test suite on my computer. But we really need Frido > here. This is a candidate to get pushed early so we catch any outstanding > issues timely. I totally agree with this change. I started programming with Java so I like chained calls this->that->then->other(). Looks like we have catched a lot of occurencies. I agree to pushed early yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 08:32:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 07:32:14 +0000 Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 09:09:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 08:09:40 +0000 Subject: [Koha-bugs] [Bug 29854] New: ES timeout is not configurable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29854 Bug ID: 29854 Summary: ES timeout is not configurable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com Using the sandboxes system I am getting a timeout during the commit request. This is the 'request_timeout' parameter that is defaulting to 30 https://metacpan.org/pod/Search::Elasticsearch::Role::Cxn#request_timeout Setting it to 60 resolved the problem. We should make this value configurable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 09:44:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 08:44:11 +0000 Subject: [Koha-bugs] [Bug 29855] New: Add a repeated subfield with a MARC modification template Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29855 Bug ID: 29855 Summary: Add a repeated subfield with a MARC modification template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org It seems it is not possible to add a repeated subfield with MARC Modification template with the current options. Ex : it should be possible to create a 099$tBOOK field, then create an other $t (ex: $tCD) in the same 099 field (not in a new 099), to obtain 099$BOOK$tCD -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 09:46:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 08:46:34 +0000 Subject: [Koha-bugs] [Bug 29856] New: Make the ES config more flexible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Bug ID: 29856 Summary: Make the ES config more flexible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 09:50:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 08:50:48 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 09:50:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 08:50:52 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 --- Comment #1 from Jonathan Druart --- Created attachment 129327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129327&action=edit Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section 60 Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 09:51:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 08:51:28 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, tomascohen at gmail.com --- Comment #2 from Jonathan Druart --- Can I get this patch pushed quickly please? It will help to fix the BibLibre's sandboxes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 10:22:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 09:22:55 +0000 Subject: [Koha-bugs] [Bug 29857] New: We must stringify our exceptions correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Bug ID: 29857 Summary: We must stringify our exceptions correctly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 21022 We must have a generic full_message method in the Koha::Exceptions base class to display all the info we have about the exception. The current state is bad as we are displaying the "description" of the exception but it does not contain useful information. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 [Bug 21022] Exceptions should skip stringifying if message manually passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 10:22:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 09:22:55 +0000 Subject: [Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 [Bug 29857] We must stringify our exceptions correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 10:30:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 09:30:42 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129327|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 129328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129328&action=edit Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section 60 Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 10:34:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 09:34:31 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #1 from Jonathan Druart --- Created attachment 129329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129329&action=edit Bug 29857: Make the exception classes inherit from the base class We have a base class Koha::Exceptions::Exception but it's not used in most of our exception classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 10:34:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 09:34:34 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #2 from Jonathan Druart --- Created attachment 129330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129330&action=edit Bug 29857: Provide a generic full_message method for our exceptions We pass useful information when throwing exceptions, but we don't display them! We must display all the details we need when the exception is stringified. Test plan: Use the following snippet: use Koha::Exceptions::Elasticsearch; Koha::Exceptions::Elasticsearch::BadResponse->throw( type => "a good type", details => "and some details" ); Execute it without and with the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 10:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 09:35:53 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com --- Comment #3 from Jonathan Druart --- [Bad response received when submitting request to Elasticsearch] vs Exception 'Koha::Exceptions::Elasticsearch::BadResponse' thrown 'Bad response received when submitting request to Elasticsearch' with type => a good type, details => and some details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 10:58:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 09:58:56 +0000 Subject: [Koha-bugs] [Bug 29854] ES timeout is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29854 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 29856 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 10:58:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 09:58:56 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 --- Comment #4 from Jonathan Druart --- *** Bug 29854 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 12:13:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 11:13:45 +0000 Subject: [Koha-bugs] [Bug 29858] New: Item.pm "Use of uninitialized value" warn when $field var is NULL Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29858 Bug ID: 29858 Summary: Item.pm "Use of uninitialized value" warn when $field var is NULL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: stalkernoid at gmail.com Reporter: stalkernoid at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 12:14:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 11:14:34 +0000 Subject: [Koha-bugs] [Bug 29858] Item.pm "Use of uninitialized value" warn when $field var is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29858 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 12:14:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 11:14:37 +0000 Subject: [Koha-bugs] [Bug 29858] Item.pm "Use of uninitialized value" warn when $field var is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29858 --- Comment #1 from Peter Vashchuk --- Created attachment 129331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129331&action=edit Bug 29858: NULL $field var causing "Use of uninitialized value" warn Some fields might be null which causes "Use of uninitialized value in string eq at .../Koha/Item.pm line 639." warn. This patch prevents this warn to get thrown by checking if the field is defined first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 12:42:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 11:42:38 +0000 Subject: [Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 12:42:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 11:42:42 +0000 Subject: [Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129324|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 129332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129332&action=edit Bug 29845: add IDs to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold, and download as buttons, none of them contain ID's. 4. Apply patch 5. Repeat 3 again but this time they should all contain an ID which makes them much easier to style. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 13:14:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 12:14:10 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #809 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #808) > I rebased what we had. Didnt check yet. > > Katrin, Fridolin, Aleisha, David, Victor: When can we work on this patch set > this month? Would be handy to plan our actions now. +1 Time is sparse, but I'll try to make it work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 13:19:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 12:19:20 +0000 Subject: [Koha-bugs] [Bug 29613] Set focus for cursor to barcode field on course reserves add items and batch add items pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29613 --- Comment #6 from Katrin Fischer --- Thx for the feedback, Eliana, had this happen myself before. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 13:29:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 12:29:36 +0000 Subject: [Koha-bugs] [Bug 29836] 2FA - provide a REST API challenge route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29836 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:03:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:03:17 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:04:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:04:58 +0000 Subject: [Koha-bugs] [Bug 29835] 2FA - ask for the password when 2FA is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29835 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:09:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:09:42 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:09:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:09:47 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128578|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:09:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:09:51 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128530|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:09:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:09:55 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:09:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:09:58 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:10:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:10:01 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128533|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:10:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:10:05 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:11:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:11:01 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 129339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129339&action=edit Bug 29690: Add eval on metadata record fetch in details.pl when invalid MARCXML Bug 23846 added support for invalid MARCXML. But now page details.pl fails again with software error. This comes from several Koha::Biblio calling $self->metadata->record without eval. Test plan : 1) Create a biblio record with invalid MARCXML (see Bug 29690) In koha-testing-docker there is biblionumber=369 2) Go to page cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx 3) You see the page with a message : There is an error with this bibliographic record, the view may be degraded. Error: Invalid data, cannot decode metadata object ... Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:11:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:11:06 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 129340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129340&action=edit Bug 29690: (follow-up) Catch other cases This patch catches the rest of the cases in Koha::Biblio where `->metadata->record` may fail. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:11:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:11:11 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 129341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129341&action=edit Bug 29690: Unit test for get_components_query Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:11:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:11:16 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 129342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129342&action=edit Bug 29690: Always warn if something is wrong with the metadata Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:11:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:11:21 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 129343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129343&action=edit Bug 29690: Add selenium test Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:11:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:11:26 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 129344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129344&action=edit Bug 29690: (follow-up) Add eval on metadata record fetch in get_marc_authors() Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:11:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:11:30 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 129345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129345&action=edit Bug 29690: Fix tests count Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:13:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:13:28 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |testopia at bugs.koha-communit | |y.org --- Comment #41 from Tomás Cohen Arazi --- I saw David's signature so was about to PQA it, but it seems it was NSO. Not sure what is the status. Adding my signature as it does the job, looks correct, tests pass and the QA scripts are happy. My only doubt is about Koha::Biblio calling warn... I'm still trying to figure if it should use the logger instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:45:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:45:43 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Christofer Zorn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christofer.zorn at ajaxlibrary | |.ca --- Comment #2 from Christofer Zorn --- I'd like to bump this change. We were under reporting our active users because our report was counting when the lastseen date was between two dates, however we had 3000+ active users in the system missed because of the null. If the lastseen date is updated on a SIP connection or CKO, it certainly should be updated when the patron registers. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:55:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:55:21 +0000 Subject: [Koha-bugs] [Bug 29859] New: Favor iterators over as_list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Bug ID: 29859 Summary: Favor iterators over as_list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 29844 On bug 29844 we decided to remove wantarray from Koha::Objects->search. Reviewing the difference occurrences I found some unnecessary uses of ->as_list, where iterators should be used instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 [Bug 29844] Remove uses of wantarray in Koha::Objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:55:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:55:21 +0000 Subject: [Koha-bugs] [Bug 29844] Remove uses of wantarray in Koha::Objects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 [Bug 29859] Favor iterators over as_list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:57:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:57:19 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:57:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:57:24 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 --- Comment #1 from Jonathan Druart --- Created attachment 129346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129346&action=edit Bug 29859: Use iterator instead of as_list On bug 29844 we decided to remove wantarray from Koha::Objects->search. Reviewing the difference occurrences I found some unnecessary uses of ->as_list, where iterators should be used instead. This patch only removes the obvious places, not the tricky ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:57:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:57:37 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 14:57:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 13:57:54 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 --- Comment #2 from Jonathan Druart --- There is a non-squashed version on https://gitlab.com/joubu/Koha/-/tree/bug_29859 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:07:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:07:34 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129328|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 129347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129347&action=edit Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section 60 Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:08:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:08:20 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize --- This is nice and works as described. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:13:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:13:16 +0000 Subject: [Koha-bugs] [Bug 29860] New: Useless warnings in regressions.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29860 Bug ID: 29860 Summary: Useless warnings in regressions.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: 1. Run: $ kshell k$ prove t/db_dependent/selenium/regressions.t => FAIL: You see several item-level_itypes set but no itemtype set for item (985) at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 905. and Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:13:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:13:49 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #4 from Martin Renvoize --- This seems a solid improvement to me.. honestly I've found our exceptions confusing to work with.. creating new ones and all the classes all over the place.. this works towards making them all consistent at least. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:16:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:16:19 +0000 Subject: [Koha-bugs] [Bug 29860] Useless warnings in regressions.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29860 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129348&action=edit Bug 29860: Remove item type-related warnings To test: 1. Run: $ kshell k$ prove t/db_dependent/selenium/regressions.t => FAIL: You see several item-level_itypes set but no itemtype set for item (985) at /kohadevbox/koha/Koha/Schema/Result/Item.pm line 905. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more item type warnings 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:16:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:16:56 +0000 Subject: [Koha-bugs] [Bug 29852] Add option to exclude certain types of url in check-url-quick.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29852 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:19:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:19:49 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:33:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:33:07 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrew at bywatersolutions.com --- Comment #17 from Andrew Fuerste-Henry --- We're not fully mirroring circ history behavior. For checkout history, if a patron is set to Never they get anonymized as soon as the item is returned. Here, if a patron is set to Never we're still waiting for the cron to anonymize them. We should anonymize their holds as soon as they move to old_reserves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:33:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:33:35 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:33:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:33:39 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129347|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi --- Created attachment 129349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129349&action=edit Bug 29856: Make the ES config more flexible I need to add a 'request_timeout' entry to the ES configuration to fix some timeout problems on the sandboxes. Instead of hard coding this new option it seems preferable to be flexible and allow different options to be passed from the config file. Test plan: Add to the $KOHA_CONF, inside the elasticsearch section 60 Rebuild the ES index koha-elasticsearch --rebuild kohadev Change the value of the timeout to 1 Rebuild the index It should fail (with a quite bad error 'Bad response received when submitting request to Elasticsearch') Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:37:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:37:31 +0000 Subject: [Koha-bugs] [Bug 29861] New: Store and display the date on which a hold was fulfilled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29861 Bug ID: 29861 Summary: Store and display the date on which a hold was fulfilled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The patron hold history page shows the date a hold was placed, expired, waiting, or cancelled. But for a hold that was successfully fulfilled, we don't have an easy way of showing the date on which the fulfillment happened. We should create reserves.fulfillmentdate (and old_reserves.fulfillment date) and show that on holdshistory.pl. It's helpful data that users will like to see. Right now, one must rely on either old_reserves.timestamp (which can change) or a rough match on borrowernumber, itemnumber, and timetamp in the old_issues table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:37:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:37:44 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 --- Comment #8 from Tomás Cohen Arazi --- FTR: It seems Search::Elasticsearch doesn't break on weird/invalid configurations passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:41:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:41:34 +0000 Subject: [Koha-bugs] [Bug 29859] Favor iterators over as_list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129346|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 129350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129350&action=edit Bug 29859: Use iterator instead of as_list On bug 29844 we decided to remove wantarray from Koha::Objects->search. Reviewing the difference occurrences I found some unnecessary uses of ->as_list, where iterators should be used instead. This patch only removes the obvious places, not the tricky ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:42:14 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:42:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:42:17 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129289|0 |1 is obsolete| | --- Comment #3 from George Veranis --- Created attachment 129351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129351&action=edit Bug20362: Direct link to authority records missing in staff detail view (1xx , 7xx) I added a magnigying glass icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:45:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:45:51 +0000 Subject: [Koha-bugs] [Bug 29862] New: TestBuilder.t fails with ES enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Bug ID: 29862 Summary: TestBuilder.t fails with ES enabled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: kohadev-koha at kohadevbox:/kohadevbox/koha$ prove t/db_dependent/TestBuilder.t t/db_dependent/TestBuilder.t .. 7/15 Invalid MARC field expression: nHiaHpae3NgZlIHLjw1aOK4orw_8D8Af9R8WOo4cDSyifeMJyb2e_s2UzLX_EJHr7i01S1P4uyRIwHzyQRp2xogLJamtpafxr73jNPmoKuxhtgbEUhXuNUdUWG8GquTLhIHSNixvJCboujpzt6j2f8T5AcSxSbfPiNhKaAkMufwMVzQmsW26LUo3Y1cedm_aN9yQ9cwxNIqiwSjH1CiUg3IP2iwQSZdUJg57uCmDCcexDc6CDix at /kohadevbox/koha/C4/Biblio.pm line 306. # Looks like you planned 12 tests but ran 6. # Failed test 'Tests for delete method' # at t/db_dependent/TestBuilder.t line 302. Can't call method "biblionumber" on an undefined value at t/db_dependent/TestBuilder.t line 281. # Looks like your test exited with 11 just after 8. t/db_dependent/TestBuilder.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 8/15 subtests Test Summary Report ------------------- t/db_dependent/TestBuilder.t (Wstat: 2816 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 11 Parse errors: Bad plan. You planned 15 tests but ran 8. Files=1, Tests=8, 26 wallclock secs ( 0.02 usr 0.00 sys + 18.06 cusr 5.22 csys = 23.30 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 15:49:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 14:49:37 +0000 Subject: [Koha-bugs] [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 --- Comment #44 from Jonathan Druart --- Created attachment 129352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129352&action=edit Bug 29648: Remove default sort order for detail On the detail view the number of columns changed, we cannot use the default sort order here. It certainly can be done on a different way but I prefer to postpone it for now and see later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 16:17:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 15:17:03 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|tomascohen at gmail.com |m.de.rooy at rijksmuseum.nl --- Comment #52 from Marcel de Rooy --- Starting QA here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 16:26:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 15:26:10 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129289|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 16:34:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 15:34:04 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 16:34:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 15:34:10 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129289|0 |1 is obsolete| | Attachment #129351|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 129353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129353&action=edit Bug 20362: Direct link to authority records missing in staff detail view (1xx , 7xx) I added a magnigying glass icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 16:35:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 15:35:06 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Andrew Fuerste-Henry from comment #17) > We're not fully mirroring circ history behavior. For checkout history, if a > patron is set to Never they get anonymized as soon as the item is returned. > Here, if a patron is set to Never we're still waiting for the cron to > anonymize them. We should anonymize their holds as soon as they move to > old_reserves. This is getting complex: if we anonymize same-day holds... we are gonna break the max holds per day circ rule calculation! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 16:46:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 15:46:36 +0000 Subject: [Koha-bugs] [Bug 21074] (just a try) Display sparql data from wikidata or bnf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21074 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 16:49:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 15:49:21 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #19 from Tomás Cohen Arazi --- Ok, the current behavior is that only 'active' holds count towards the max: my $today_holds = Koha::Holds->search({ borrowernumber => $borrowernumber, reservedate => dt_from_string->date }); if (!$params->{ignore_hold_counts} && defined $holds_per_day && $holds_per_day ne '' && $today_holds->count() >= $holds_per_day ) { return { status => 'tooManyReservesToday', limit => $holds_per_day }; } so moving on with this, with no behavior change on the calculation. Phew. Should the whole feature have an on/off switch? Something like OPACHoldsPrivacy on/off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 16:49:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 15:49:35 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 16:54:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 15:54:21 +0000 Subject: [Koha-bugs] [Bug 29863] New: Show requested transfers in the holdings table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29863 Bug ID: 29863 Summary: Show requested transfers in the holdings table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When there is a requested transfer on an item, we should show that in the item's status in the holdings table on /catalogue/detail.pl. Right now, the requested transfer can only be seen in the Transfers to Send report in circulation. Maybe instead of "Available" they could say "Transfer requested to [branch]"? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 17:09:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 16:09:24 +0000 Subject: [Koha-bugs] [Bug 29863] Show requested transfers in the holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29863 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 17:10:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 16:10:33 +0000 Subject: [Koha-bugs] [Bug 29863] Show requested transfers in the holdings table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29863 --- Comment #1 from Michael Adamyk --- +1 This bug makes it difficult for consortiums to track requested transfers, since they really only appear on the Transfers to Send report for each branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 17:15:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 16:15:39 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129047|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 129354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129354&action=edit Bug 29760: Add patron category column to view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category column 3. Apply patch 4. Look again, there should now be a column for 'Patron category' showing both the caterory name and the category code. 5. Make sure you can sort and filter by this new column 6. Go to table settings and make sure you can properly hide this column and all other columns in the Holds queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 17:15:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 16:15:48 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #20 from Andrew Fuerste-Henry --- Right now these sysprefs come into play: OPACPrivacy determines whether or not patrons can access the My Privacy tab on which these settings are changed. OPACHoldsHistory determines whether or not patrons can see their hold history, if it is kept. (opacreadinghitory, a separate syspref, determines whether or not they can see checkout history). intranetreadinghistory determines whether or not staff members can see BOTH checkout and hold history on that staff side, if kept. I don't feel these *need* changes for this bug to move forward, but in the long run I'd like to see a new IntranetHoldsHistory syspref to split staff interface holds visibility out of intranetreadinghistory. If we want to give patrons the ability to control holds history without controlling checkout history (or vice versa), I'd be inclined to accomplish that by adding options to OPACPrivacy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 17:54:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 16:54:23 +0000 Subject: [Koha-bugs] [Bug 29864] New: Cannot create fund from the Funds page unless at least one fund already exists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29864 Bug ID: 29864 Summary: Cannot create fund from the Funds page unless at least one fund already exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - go to Budgets (/admin/aqbudgetperiods.pl) 2 - have just one active budget that contains no funds 3 - confirm the Actions button for your budget contains "Add a fund," but don't click it 4 - go to Funds (/admin/aqbudgets.pl) 5 - confirm there is no way to create a fund, only a New Budget button 6 - back on Budgets, use the add a fund option to add a fund 7 - reload Funds, see you now have New, Edit, and Planning buttons and New contains an option for New Fund -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 18:02:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 17:02:39 +0000 Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 18:02:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 17:02:43 +0000 Subject: [Koha-bugs] [Bug 28993] Switch magnifying class in staff detail pages to FA icon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28993 --- Comment #3 from Owen Leonard --- Created attachment 129355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129355&action=edit Bug 28993: Switch magnifying class in staff detail pages to FA icon This patch modifies the staff interface's bibliographic detail XSL so that a Font Awesome is used instead of a magnifying glass image when listing authority subject headings. The patch also corrects two other places where the image is used so that the image can be removed. Some markup from authorities.detail.tt is removed because it appears to be unused (a copy and paste from catalogue/detail.tt). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - To view the changes to the staff interface bibliographic detail page, locate a record which has at least one subject heading which is linked to a subject authority record. - The subject heading link should be followed by a magifying glass (Font Awesome) icon which links to the authority record's detail page. - View a similar change to the MARC detail page for the record. Confirm that the subject headings are followed by a link to the authority detail page. - Follow the authority search link to locate and view an authority record. The information on the authority detail page should be correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 18:12:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 17:12:29 +0000 Subject: [Koha-bugs] [Bug 29287] Display of funds on acquisitions home is not consistent with display on funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29287 --- Comment #4 from Andrew Fuerste-Henry --- To test: 1 - have a budget with at least 3 funds, one of which is a sub-fund to another 2 - create and receive orders such that each fund has one expected and one complete order 3 - go to acqui-home.pl, compare values to those found on aqbudgets.pl, find them different 4 - apply patch, reload pages 5 - compare acqui-home.pl and aqbudgets.pl again, be joyful -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 18:13:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 17:13:51 +0000 Subject: [Koha-bugs] [Bug 26058] Add ability for AllowHoldsOnPatronsPossessions to be limited by item type, collection code or shelving location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26058 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 18:15:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 17:15:02 +0000 Subject: [Koha-bugs] [Bug 29287] Display of funds on acquisitions home is not consistent with display on funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29287 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 18:15:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 17:15:06 +0000 Subject: [Koha-bugs] [Bug 29287] Display of funds on acquisitions home is not consistent with display on funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29287 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126595|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 129356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129356&action=edit Bug 29287: Add child funds to display of parent funds on acqui home Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 18:20:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 17:20:19 +0000 Subject: [Koha-bugs] [Bug 737] Map of library in search system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=737 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 18:20:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 17:20:47 +0000 Subject: [Koha-bugs] [Bug 737] Map of library in search system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=737 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 18:29:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 17:29:58 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 18:46:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 17:46:20 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #13 from Michael Hafen --- (In reply to Fridolin Somers from comment #12) > Ah that is strange. > Looks like callnumber is not displayed in result table. > This has been added by Bug 10154 as a filter, but looks there there is no > need to add in the SELECT. > Can someone confirm ? I would guess that that is intended. The call number shows in the filters, and probably isn't necessary in the results table. If someone wants it there though, it can be added. Here or in an enhancement bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 19:21:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 18:21:04 +0000 Subject: [Koha-bugs] [Bug 29865] New: Wrong includes in circ/returns.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 Bug ID: 29865 Summary: Wrong includes in circ/returns.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Super trivial, duplicated lines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 19:21:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 18:21:20 +0000 Subject: [Koha-bugs] [Bug 29865] Wrong includes in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |17600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 19:21:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 18:21:20 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 [Bug 29865] Wrong includes in circ/returns.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 19:23:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 18:23:08 +0000 Subject: [Koha-bugs] [Bug 29865] Wrong includes in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 19:23:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 18:23:12 +0000 Subject: [Koha-bugs] [Bug 29865] Wrong includes in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129357&action=edit Bug 29865: Fix duplicate includes in circ/returns.pl Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 19:24:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 18:24:45 +0000 Subject: [Koha-bugs] [Bug 29838] No string interpolation when expected in t/db_dependent/ImportBatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29838 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 19:24:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 18:24:50 +0000 Subject: [Koha-bugs] [Bug 29838] No string interpolation when expected in t/db_dependent/ImportBatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29838 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129244|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129358&action=edit Bug 29838: Fix string interpolation in ImportBatch.t Test plan: Tests should return green Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 19:25:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 18:25:26 +0000 Subject: [Koha-bugs] [Bug 29838] No string interpolation when expected in t/db_dependent/ImportBatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29838 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 19:25:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 18:25:32 +0000 Subject: [Koha-bugs] [Bug 29838] No string interpolation when expected in t/db_dependent/ImportBatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29838 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129358|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 19:25:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 18:25:55 +0000 Subject: [Koha-bugs] [Bug 29865] Wrong includes in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 19:41:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 18:41:31 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com CC| |fridolin.somers at biblibre.co | |m, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:10:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:10:57 +0000 Subject: [Koha-bugs] [Bug 29866] New: Notices and Slips presentation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29866 Bug ID: 29866 Summary: Notices and Slips presentation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org I'm wondering if the way notices and slips is presented could benefit from some change. Currently, when you go to look at notices and slips, you see absolutely everything (All libraries). And when you select a library, you see only notices and slips that are specific to that library. I'm wondering if this would be a better model: Initial view is just the default notices and slips (to all libraries), and not including those specific to a library. If you select a library, you see that library's specific custom slips, and you see in gray or blue or some other color, all the other default slips that are not customized. Next to which is a button to create a duplicate of that notice or slip for that library. When you click it, it duplicates that notice/slip for that library, and it shows in the same format/color as the other custom notices/slips for that library. Custom notices/slips would have a button next to them that would allow you to delete. If you click that, after a confirmation, the custom slip would be deleted, and the page would update, with that notice/slip now showing as the default instead of custom. Defaults would not be editable from with the view of a specific library. You would have to select the defaults view again to edit those. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:22:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:22:57 +0000 Subject: [Koha-bugs] [Bug 29867] New: Reindent authorized values administration template Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Bug ID: 29867 Summary: Reindent authorized values administration template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org I would like to update the authorized values administration template so that it has consistent indentation. It needs to have some tabs replaced with spaces and to have trailing spaces removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:23:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:23:12 +0000 Subject: [Koha-bugs] [Bug 29868] New: Add Koha::Old::Hold->anonymize Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Bug ID: 29868 Summary: Add Koha::Old::Hold->anonymize Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Found the need to anonymize from Koha::Hold->cancel, and in this case using an iterator would be overkill as I already have the Koha::Old::Hold object in place as the return value from $self->_move_to_old... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:23:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:23:44 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |Needs Signoff Blocks| |29525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:23:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:23:44 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 [Bug 29868] Add Koha::Old::Hold->anonymize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:25:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:25:23 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129359&action=edit Bug 29868: Add Koha::Old::Hold->anonymize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:27:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:27:47 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129359|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129360&action=edit Bug 29868: Add Koha::Old::Hold->anonymize This patch introduces a new method in Koha::Old::Hold. The method is fully covered by tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:31:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:31:17 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:31:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:31:22 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #1 from Owen Leonard --- Created attachment 129361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129361&action=edit Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:31:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:31:28 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 --- Comment #2 from Owen Leonard --- Created attachment 129362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129362&action=edit Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:33:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:33:55 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 129363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129363&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:47:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:47:36 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:49:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:49:58 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 129364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129364&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required This patch makes cancelling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, cancelling a hold, noticing it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:52:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:52:37 +0000 Subject: [Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #14 from Tomás Cohen Arazi --- Lets axe this syspref :-D It is exactly the same thing as if we set a global max_holds for all libraries, all itypes and all categories. If it is not the same, then we need to fix it. This is probably due to the lack of flexibility on the circ rules UI. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:56:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:56:31 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #23 from Tomás Cohen Arazi --- Andrew and testers, this follow-up patch covers the 'cancelling a hold' use case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 20:58:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 19:58:36 +0000 Subject: [Koha-bugs] [Bug 15792] Double-clicking the 'renew' button on circulation.pl will double-charge account management fee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15792 --- Comment #3 from Benjamin Daeuber --- (In reply to Owen Leonard from comment #2) > Rather than try to address this in the template I wonder if it would make > sense to add a check to the renewal process to abort the process if the > patron's expiration date is already set to the date calculated by the > renew_account? I agree with this. There's really no reason I can think of the renew to the same day. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 21:43:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 20:43:16 +0000 Subject: [Koha-bugs] [Bug 29869] New: Add Koha::Hold->fulfill Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Bug ID: 29869 Summary: Add Koha::Hold->fulfill Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org This method will overtake C4::Reserves::ModReserveFill. It will store 'FULFILL' in the action_logs table as well (to solve the FIXME that cna be found in the old method). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 21:43:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 20:43:23 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fulfill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29525 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 21:43:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 20:43:23 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fulfill -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 23:00:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 22:00:37 +0000 Subject: [Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 --- Comment #7 from Fridolin Somers --- We agreed to remove the marcflavour parameter in dev meeting https://wiki.koha-community.org/wiki/Development_IRC_meeting_5_January_2022 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 12 23:44:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Jan 2022 22:44:15 +0000 Subject: [Koha-bugs] [Bug 29870] New: Notice not delivered by default smtp server Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29870 Bug ID: 29870 Summary: Notice not delivered by default smtp server Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: gveranis at dataly.gr QA Contact: testopia at bugs.koha-community.org When you have one default smtp server configuration at koha_conf.xml (we called 'A' ) and another smtp server (we called 'B') at administration UI with two libraries that one of them is set it to default and the other set it to the smtp server 'B' then when the process_message_queue.pl is executing in order to send notices, users from library with the default server not receiving anything , but the users from library with the 'B' smtp server receive everything. The configurations between the two smtp servers A and B are the same, just one time we have passed as default on xml and the other as smtp server from UI , it seems that from UI the functions etc is working better that to get values for the object from xml. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 01:10:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 00:10:33 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #14 from Fridolin Somers --- (In reply to Michael Hafen from comment #13) > (In reply to Fridolin Somers from comment #12) > > Ah that is strange. > > Looks like callnumber is not displayed in result table. > > This has been added by Bug 10154 as a filter, but looks there there is no > > need to add in the SELECT. > > Can someone confirm ? > > I would guess that that is intended. The call number shows in the filters, > and probably isn't necessary in the results table. > > If someone wants it there though, it can be added. Here or in an > enhancement bug. I propose removing from select here, instead of group_concat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 01:28:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 00:28:44 +0000 Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 05:52:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 04:52:08 +0000 Subject: [Koha-bugs] [Bug 29565] selenium/regressions.t can fail on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Not fixed, Koha_Master/1885 00:58:27 koha_1 | # Looks like you planned 18 tests but ran 1. 00:58:27 koha_1 | 00:58:27 koha_1 | # Failed test 'Encoding in session variables' 00:58:27 koha_1 | # at t/db_dependent/selenium/regressions.t line 300. 00:58:27 koha_1 | Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 285. 00:58:27 koha_1 | # Looks like your test exited with 2 just after 6. 00:58:27 koha_1 | [23:58:24] t/db_dependent/selenium/regressions.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 05:52:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 04:52:36 +0000 Subject: [Koha-bugs] [Bug 29565] selenium/regressions.t can fail on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29565 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > @ t/lib/Selenium.pm:50 @ sub new { > ); > bless $self, $class; > $self->add_error_handler; > - $self->driver->set_implicit_wait_timeout(5000); > + $self->driver->set_implicit_wait_timeout(1000); > return $self; > } > > This patch suggests to simply double the timeout. 5000*2=1000?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:14:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:14:34 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #42 from Jonathan Druart --- Thinking a bit more about it. We decided to not explode on detail.pl to provide a nice message to the end user. But we decided to not care about the other views, there is a script already to catch such problems, etc. Here I am wondering if we are not actually fixing the problem at the wrong level. Methods should not deal with the errors (or we are going to add checks everywhere), it's controller's job to catch the error IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:18:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:18:14 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #43 from Jonathan Druart --- Minor but worth noting: the patches rename $marc with $record. It should actually be $marc_record I think, $record is too generic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:21:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:21:40 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #44 from Jonathan Druart --- Created attachment 129365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129365&action=edit Bug 29690: [ALTERNATIVE PATCH] Prevent detail.pl to crash if MARCXLM in invalid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:22:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:22:23 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #45 from Jonathan Druart --- (In reply to Jonathan Druart from comment #44) > Created attachment 129365 [details] [review] > Bug 29690: [ALTERNATIVE PATCH] Prevent detail.pl to crash if MARCXLM in > invalid Tomas, Martin, Fridolin, what about this patch? It would obsolete the other patches except the selenium tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:29:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:29:54 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #24 from Jonathan Druart --- Next time please provide a change for the different occurrences. We are modifying only 1 dropdown when we have several in the codebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:30:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:30:19 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:30:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:30:25 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128091|0 |1 is obsolete| | Attachment #128092|0 |1 is obsolete| | Attachment #128093|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 129366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129366&action=edit Bug 24866: Display budget hierarchy in the budget dropdown menu used when placing a new order The rendering of SELECT elements is up to the browser. But Bug 16123 CSS code 'style="padding-left: xx' doesn't work on modern browsers. This patch replace CSS style attribute with   html entity. On supported platforms TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2020) 3. Add a fund to this budget (ie : Book) 4. Add a sub-fund to fund Book (ie : Adult fiction) You will have this hierarchy : Budget 2020 |____ Book |_____ Adult fiction 5. Go to the Acquisition module 6. Select a vendor and create a new basket 7. Place an order 8. Check the budget dropdown menu BEFORE PATCH Book Adult fiction OR Book Adult fiction AFTER PATCH Book Adult fiction Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:30:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:30:30 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 --- Comment #26 from Jonathan Druart --- Created attachment 129367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129367&action=edit Bug 24866: (follow-up) Replaced tabulations by dashes The rendering of SELECT elements is up to the browser. But Bug 16123 CSS code 'style="padding-left: xx' doesn't work on modern browsers. Based on the previous contribution, this fix replaces CSS style attribute with dashes, creating a leveled structure that should work with most browsers. Tested on Linux Ubuntu with Firefox 94.0, Chromium 95.0.4 and Opera 81.0.1 TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2022) 3. Add a fund to this budget (ie : Book) 4. Add a sub-fund to fund Book (ie : Fiction) 5. Add another sub-fund, this time to sub-fund Book (ie : Adult fiction) You will have this hierarchy : Budget 2022 |____ Book |_____ Fiction |_____ Adult fiction 6. Go to the Acquisition module 7. Select a vendor and create a new basket 8. Place an order 9. Check the budget dropdown menu BEFORE PATCH Book Fiction Adult fiction OR Book Fiction Adult fiction AFTER PATCH Book -- Fiction -- -- Adult fiction Co-authored-by: Didier Gautheron Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:30:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:30:37 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 --- Comment #27 from Jonathan Druart --- Created attachment 129368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129368&action=edit Bug_24866: Changed $raw for html for extra safety Same test plan as before Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:31:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:31:22 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129368|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 129369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129369&action=edit Bug 24866: Changed $raw for html for extra safety Same test plan as before Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:35:53 +0000 Subject: [Koha-bugs] [Bug 29646] Bad or repeated opac-password-recovery attempt crashes on wrong borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:35:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:35:57 +0000 Subject: [Koha-bugs] [Bug 29646] Bad or repeated opac-password-recovery attempt crashes on wrong borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128270|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 129370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129370&action=edit Bug 29646: Fix undefined category crash in opac-password-recovery The crash is a result of a not found borrower. This is typically a bad or repeated recovery attempt. Test plan: Do a password recovery. Use the mailed URL twice. Without this patch, the second attempt crashes. With this patch, the second attempt shows an error dialog. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:40:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:40:36 +0000 Subject: [Koha-bugs] [Bug 29646] Bad or repeated opac-password-recovery attempt crashes on wrong borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29646 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:42:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:42:50 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #4 from Alex Buckley --- Created attachment 129371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129371&action=edit Bug 22827: Add age dependency on other fields than dateaccessioned A new agefield has been added to the 'Automatic item modifications by age' tool. The options for the agefield are: replacementpricedate, datelastborrowed, datelastseen, damaged_on, itemlost_on, withdrawn_on If no option is selected then Koha will default to using dateaccessioned. Test plan: 1. Go to: Tools > Catalog > Automatic item modifications by age 2. Observe there is a new 'Age field' dropdown in the rule form. 3. Create a rule, set the values: - 'Age in days' = 20 - 'Substitutions': 'items.barcode' = 'test' fields - 'Age field' = 'items.datelastseen' - Save the rule 4. Confirm the 'List of rules' page displays 'items.datelastseen' in the 'Age field' column 5. Add another rule: - 'Age in days' = 1 - 'Substitutions': 'items.barcode' = 'test2' - Leave 'Age field' = 'Choose an age field' - Save the rule 6. Confirm the 'List of rules' page displays 'items.dateaccesioned' in the 'Age field' column for that second rule 7. Confirm you can delete rules 8. Edit a record: - Make the items.dateaccessioned less than 20 days ago (so rule 1 is false) - Make the items.datelastseen more than 1 day ago (so rule 2 is true) 9. Run the automatic_items_modification_by_age.pl: - sudo koha-shell - cd misc/cronjobs - ./automatic_item_modification_by_age.pl -v 10. Confirm the item has it's barcode set to 'test2' 11. Run unit tests: - sudo koha-shell - cd t - prove db_dependent/Item/AutomaticItemModificationByAge.t -v Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:44:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:44:11 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|ASSIGNED |Needs Signoff --- Comment #5 from Alex Buckley --- Ready for testing. In my patchset the fields in comment #1 are hardcoded. Please let me know if there is a way to fetch datetime items columns without having to hardcode them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:46:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:46:58 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:48:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:48:43 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #16 from Jonathan Druart --- (In reply to Martin Renvoize from comment #15) > humm.. my local branch misses the unit tests.. wonder why.. > > I can replicate now I've grabbed the patches here. I am still getting the same failure, patches from bug 29403 and bug 29718 applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 06:57:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 05:57:19 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #17 from Jonathan Druart --- Shouldn't we mock the timezone here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:00:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:00:18 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #18 from Jonathan Druart --- Created attachment 129372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129372&action=edit Bug 29718: Mock the timezone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:01:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:01:30 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128826|0 |1 is obsolete| | Attachment #128827|0 |1 is obsolete| | Attachment #128828|0 |1 is obsolete| | Attachment #128829|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart --- Created attachment 129373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129373&action=edit Bug 29403: Unit tests Add a unit test for proper iso date handling Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:01:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:01:36 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #38 from Jonathan Druart --- Created attachment 129374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129374&action=edit Bug 29403: Match the whole string This patch wraps the constructed regex such that we expect the entire regex to match and don't allow leading or trailing garbage. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:01:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:01:47 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #39 from Jonathan Druart --- Created attachment 129375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129375&action=edit Bug 29403: Fix api/v1/patrons.t t::lib::Dates::compare expects either correct DateTime objects, or a system formatted datetime strings to be passed.. but as we're testing the API, we are consistently using RFC3339 strings for date-times and ISO8601 strings for dates. We need to therefore pre-process the strings into DateTime objects for the comparison. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:01:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:01:55 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #40 from Jonathan Druart --- Created attachment 129376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129376&action=edit Bug 29403: Fix unit test for bug 29718 Including a 'T' is actually valid for ISO date format, I was being naughty and writing the test to follow our code rather than writing the test to conform to the ISO spec first time around. Now we are properly supporting 'T' in ISO dates with bug 29718, we need to update the test here to properly reflect an invalid ISO date string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:26:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:26:10 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #7 from Jonathan Druart --- Not a big deal I think, but prior to this patch we were actually removing faster as the "default" was 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:27:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:27:26 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #8 from Jonathan Druart --- Also note that with this patch the script will now fail (displaying the help) if the flag is called without value. I don't think we should backport this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:30:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:30:55 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:30:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:30:59 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128704|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 129377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129377&action=edit Bug 28962: Add del-unv-selfreg to crontab We also add a test by inserting a simulated borrower modification record in the same table which should not be deleted. NOTE: This patch fixes the del-unv-selfreg parameter in the cleanup db script. It did not even do what it promised :) Test plan: Verify if the crontab change is correct. Run t/db_dependent/Members.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:40:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:40:03 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #46 from Fridolin Somers --- (In reply to Jonathan Druart from comment #45) > (In reply to Jonathan Druart from comment #44) > > Created attachment 129365 [details] [review] [review] > > Bug 29690: [ALTERNATIVE PATCH] Prevent detail.pl to crash if MARCXLM in > > invalid > > Tomas, Martin, Fridolin, what about this patch? It would obsolete the other > patches except the selenium tests. Hi, I like this shorter patch. We deal with a regression, I think the most simple fix is the best. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:42:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:42:39 +0000 Subject: [Koha-bugs] [Bug 28943] Lower the risk of accidental patron deletion by cleanup_database.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #14 from Jonathan Druart --- Isn't supporting "0" actually a feature? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 07:56:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 06:56:53 +0000 Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #37 from Jonathan Druart --- What's next? Should we go with the proposed patches or think something else? (In reply to Jonathan Druart from comment #29) > What about having it more generic? At least the naming to start. > > We will want to "expand" itemtypes as well for instance. > Do we really need the whole Koha::AV object or do we finally only need the > description? > > It's similar to the 'columns_to_str' methods I introduced on bug 27526 (yes > Tomas, I know you told me already), where we want to have stringified values > of object's attributes. This comment didn't get a reply, and I still think it's what we need here. A stringified version of codes seem sensible. It will work for AVs, branchcode, itemtypes, etc. However it will bring the problem of translatability (but same problem will appear with the current version). In a first step we only want to support AVs so this problem is for later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:13:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:13:19 +0000 Subject: [Koha-bugs] [Bug 29871] New: Remove marcflavour param in Koha::Biblio->get_marc_* Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Bug ID: 29871 Summary: Remove marcflavour param in Koha::Biblio->get_marc_* Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Remove marcflavour param in Koha::Biblio->get_marc_* We use system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:13:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:13:36 +0000 Subject: [Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_* In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Depends on| |29652 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:13:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:13:36 +0000 Subject: [Koha-bugs] [Bug 29652] Move Koha::Biblio->get_marc_* to Koha::Biblio::Metadata In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29652 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_* -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:13:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:13:49 +0000 Subject: [Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_* In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:13:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:13:49 +0000 Subject: [Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:19:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:19:12 +0000 Subject: [Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove marcflavour param in |Remove marcflavour param in |Koha::Biblio->get_marc_* |Koha::Biblio->get_marc_note | |s -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:19:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:19:18 +0000 Subject: [Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:20:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:20:12 +0000 Subject: [Koha-bugs] [Bug 28943] Lower the risk of accidental patron deletion by cleanup_database.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943 --- Comment #15 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #14) > Isn't supporting "0" actually a feature? Hmm. Theoretically perhaps? I would have said No in absolute sense, were it not for the code part stripping the time by ->ymd. So yes, I you run with 0 at e.g. 23:00, you only remove things from yesterday (still a potential disaster); which might be what you want when using the temp category. If you run at 01:00, you remove everything except the last hour; which might not be what you like (too quick). But I think that the risk of deleting almost all patrons (no temp category) outweighs the gain of running 0 at 23:00 with temp category. So, in short: No we should not support 0 as a feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:20:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:20:48 +0000 Subject: [Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 --- Comment #1 from Fridolin Somers --- Created attachment 129378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129378&action=edit Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes Test plan : Display a biblio record with some MARC notes in details page and basket, OPAC and staff Run prove t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:21:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:21:22 +0000 Subject: [Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:21:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:21:26 +0000 Subject: [Koha-bugs] [Bug 29871] Remove marcflavour param in Koha::Biblio->get_marc_notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129378|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 129379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129379&action=edit Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes Test plan : Display a biblio record with some MARC notes in details page and basket, OPAC and staff Run prove t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:22:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:22:00 +0000 Subject: [Koha-bugs] [Bug 29865] Wrong includes in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:22:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:22:06 +0000 Subject: [Koha-bugs] [Bug 29865] Wrong includes in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129357|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 129380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129380&action=edit Bug 29865: Fix duplicate includes in circ/returns.pl Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:22:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:22:25 +0000 Subject: [Koha-bugs] [Bug 29865] Wrong includes in circ/returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29865 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:23:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:23:16 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #810 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #809) > (In reply to Marcel de Rooy from comment #808) > > I rebased what we had. Didnt check yet. > > > > Katrin, Fridolin, Aleisha, David, Victor: When can we work on this patch set > > this month? Would be handy to plan our actions now. > > +1 > > Time is sparse, but I'll try to make it work. Thanks Katrin. And the others? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:25:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:25:15 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:25:19 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129339|0 |1 is obsolete| | Attachment #129340|0 |1 is obsolete| | Attachment #129341|0 |1 is obsolete| | Attachment #129342|0 |1 is obsolete| | Attachment #129343|0 |1 is obsolete| | Attachment #129344|0 |1 is obsolete| | Attachment #129345|0 |1 is obsolete| | Attachment #129365|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart --- Created attachment 129381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129381&action=edit Bug 29690: Add selenium test Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:25:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:25:24 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #48 from Jonathan Druart --- Created attachment 129382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129382&action=edit Bug 29690: Prevent detail.pl to crash if MARCXLM in invalid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:27:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:27:08 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:27:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:27:11 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 --- Comment #29 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:27:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:27:14 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:27:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:27:16 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:27:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:27:19 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:27:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:27:21 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 --- Comment #9 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:33:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:33:11 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #10 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > Not a big deal I think, but prior to this patch we were actually removing > faster as the "default" was 1. This is arguable. First, saying that "default" is 1 leans on the true value (not a great feature). But more importantly, the crontab did not include this flag. So unless an admin added it, the records were not deleted at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:33:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:33:25 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #49 from Fridolin Somers --- Small typo in commit message : "if MARCXLM in invalid" => MARCXML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:34:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:34:44 +0000 Subject: [Koha-bugs] [Bug 28962] Unverified self registrations should be removed shortly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #11 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > Also note that with this patch the script will now fail (displaying the > help) if the flag is called without value. I don't think we should backport > this. Agreed. Moving to enh. (Altough it fixes a bug..) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:47:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:47:21 +0000 Subject: [Koha-bugs] [Bug 28420] Allow login via AzureAD OpenID-Connect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #22 from Eugene Espinoza --- Hi Mark! For the masthead.inc in 21.05, it seem is not clickable, the code in your patch below: I checked on the googleopenidconnect a link, we have the following below: So, I adjusted that for azuread, now it's clickable, below is the code: Can the code be adjusted for 21.05? Best, -eugene -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:57:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:57:51 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 08:57:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 07:57:55 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #53 from Marcel de Rooy --- Created attachment 129383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129383&action=edit Bug 28786: (QA follow-up) Fix qa warnings FAIL members/two_factor_auth.pl FAIL file permissions File must have the exec flag FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt FAIL filters missing_filter at line 42 (

Account: [% issuer %]

) missing_filter at line 43 (

Key: [% key_id %]

) missing_filter at line 54 ( ) FAIL Koha/Auth/TwoFactorAuth.pm FAIL pod coverage POD is missing for 'new' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 09:02:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 08:02:43 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129383|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy --- Created attachment 129384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129384&action=edit Bug 28786: (QA follow-up) Fix qa warnings FAIL members/two_factor_auth.pl FAIL file permissions File must have the exec flag FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt FAIL filters missing_filter at line 42 (

Account: [% issuer %]

) missing_filter at line 43 (

Key: [% key_id %]

) missing_filter at line 54 ( ) missing_filter at line 58 ( ) FAIL Koha/Auth/TwoFactorAuth.pm FAIL pod coverage POD is missing for 'new' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 09:04:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 08:04:02 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #55 from Marcel de Rooy --- Skipping this one (no big deal): FAIL installer/data/mysql/atomicupdate/two-fa.perl FAIL git manipulation The file has been added and deleted in the same patchset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 09:16:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 08:16:14 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Eugene Espinoza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf at yahoo.com --- Comment #3 from Eugene Espinoza --- Hi! There are several known security vulnerabilities in jsTree 1.0-rc3, please see: https://snyk.io/vuln/npm:jstree. Can the importance be changed from P5-low to P1-high? and from normal to critical? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 09:16:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 08:16:48 +0000 Subject: [Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 --- Comment #15 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #14) > Lets axe this syspref :-D > > It is exactly the same thing as if we set a global max_holds for all > libraries, all itypes and all categories. If it is not the same, then we > need to fix it. This is probably due to the lack of flexibility on the circ > rules UI. It should intentionally not be the same. The all libraries is mislabelled and we need to fix it. It should be a fallback if no other rules are set for a library, not an "overall libraries". The GUI is bad. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 09:36:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 08:36:17 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #19 from Martin Renvoize --- You are indeed right, we needed to mock the timezone.. what I was still trying to wrap my head around was a) what timezone we should pick and b) if it should affect all the existing tests in any way and what the actual times should end up as for the tests.. Looks like you've given that some thought :).. I'll take a look and confirm now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 09:39:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 08:39:10 +0000 Subject: [Koha-bugs] [Bug 29155] Upgrade jquery version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 Eugene Espinoza changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf at yahoo.com --- Comment #2 from Eugene Espinoza --- Addendum for vulnerability for Jquery 3.4.1 (OPAC): https://snyk.io/vuln/npm:jquery at 3.4.1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:10:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:10:04 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128653|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 129385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129385&action=edit Bug 29718: Support ISO8601 Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:10:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:10:08 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128654|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 129386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129386&action=edit Bug 29718: (QA follow-up) Make 'T' check case insensative Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:10:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:10:12 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128658|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 129387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129387&action=edit Bug 29718: (QA follow-up) Add optional offset handling ISO8601 optionally supports timezone offsets. If a timezone is ommited, we should assume 'local' time (Which in our case is instance configuration time), if we are passed 'Z' or 'z' we should set timezone to 'UTC', otherwise we should set the timezone to the passed offset. Whilst ISO8601 does NOT support AM/PM, I left that intact as it has historical relevance in Koha and we share the ISO parsing with SQL type parsing amongth other things. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:10:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:10:15 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128840|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 129388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129388&action=edit Bug 29718: Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:10:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:10:19 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129372|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 129389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129389&action=edit Bug 29718: Mock the timezone Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:10:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:10:23 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #25 from Martin Renvoize --- Created attachment 129390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129390&action=edit Bug 29718: (QA follow-up) Remove duplicate test I'd inadvertantly introduced the exact same test twice! This patch removes the duplicate and annotates the test to clarify the timezone handling expectations. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:11:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:11:57 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Martin Renvoize --- I've tested Jonathans follow-up and added another of my own to annotate the tests and remove a duplicate. Setting to Signed off to get QA attention as I think we're ready for a last technical eye here now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:30:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:30:23 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129373|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize --- Created attachment 129391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129391&action=edit Bug 29403: Unit tests Add a unit test for proper iso date handling Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:30:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:30:27 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129374|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize --- Created attachment 129392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129392&action=edit Bug 29403: Match the whole string This patch wraps the constructed regex such that we expect the entire regex to match and don't allow leading or trailing garbage. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:30:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:30:30 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129375|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 129393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129393&action=edit Bug 29403: Fix api/v1/patrons.t t::lib::Dates::compare expects either correct DateTime objects, or a system formatted datetime strings to be passed.. but as we're testing the API, we are consistently using RFC3339 strings for date-times and ISO8601 strings for dates. We need to therefore pre-process the strings into DateTime objects for the comparison. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:30:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:30:34 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129376|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize --- Created attachment 129394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129394&action=edit Bug 29403: Fix unit test for bug 29718 Including a 'T' is actually valid for ISO date format, I was being naughty and writing the test to follow our code rather than writing the test to conform to the ISO spec first time around. Now we are properly supporting 'T' in ISO dates with bug 29718, we need to update the test here to properly reflect an invalid ISO date string. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:31:26 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #45 from Martin Renvoize --- Just a minor rebase to fix the test count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 10:58:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 09:58:34 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #6 from Martin Renvoize --- I've not read the patch here yet.. but to answer your question.. you can introspect the Koha::Object.. see https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Object.pm#L129 for an example. But.. I'm not sure if it's worth the overhead/extra code lines here if I'm honest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 11:23:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 10:23:49 +0000 Subject: [Koha-bugs] [Bug 26635] Expand authorised values in REST API call In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #38 from Tomás Cohen Arazi --- We name itemtype => item_type_id, branchcode => library_id, etc. We do that so we can do things like: x-koha-embed: item_type,library So we already have a generic way if doing it. You just add a method that returns the thing and add an embed definition on the API. The problem is, frameworks define how attributes are mapped to avs, and as such you cannot know in advance what you would need to embed. And even if you know in advance that some attribute is married to an av, it could happen that there isn't a match just because (of data). So maybe one item has a corresponding av, and the other doesn't, on a resultset. It felt (some time ago already) that it was better to return a structure in which you could query for the descriptions. I'm ok with whatever we decide, as long as it is practical and consistent. And we can use so we can push bug 8179 to master, which is hurting the sponsors for a year already. Bug 8179 needs some more polishing for sure, but uncertainty made it get stuck. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 11:58:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 10:58:32 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #56 from Marcel de Rooy --- There are several issues. Some are blockers, some could be dealt with on follow-up reports, as is already the case for storing the secret. [1] This code pattern looks wrong: my $secret = Koha::AuthUtils::generate_salt( 'weak', 16 ); my $auth = Koha::Auth::TwoFactorAuth->new( { patron => $logged_in_user, secret => $secret } ); my $secret32 = $auth->generate_secret32; What you do with generate_secret32 is effectively wasting your own secret. Note that Auth::GoogleAuth uses 16 random numbers 0-31 to create a new secret. If you pass a secret, GoogleAuth will convert it to base32 internally. The synopsis in the module is wrong too. This is a blocker. But simple to correct. [2] The randomizer (which we should not use) depends on Math::Random::MT. This module says: This algorithm has a very uniform distribution and is good for modelling purposes but do not use it for cryptography. As long as we pass our own stronger secrets, no worries. See [1]. [3] Martin refers earlier to Authen::OATH. I follow him there, but no blocker. [4] The argument used before "Also, it can generate QR codes out-of-the-box" is currently actually an issue. It creates a link like https://chart.googleapis.com/chart?&cht=qr with the secret as a URL GET parameter. That's obviously unsafe! Furthermore, this Google API has been deprecated for some years already. https://developers.google.com/chart/infographics/docs/qr_codes We could use the $return_otpauth parameter to create the QR code ourselves. Personally, I would not use this in its current form. But I would propose to solve this issue on a follow-up report. [5] This one I did not yet fully tackle. But I have the impression that we have an issue in C4/Auth now. A few times already I had to login twice. This MIGHT be a blocker. Needs still investigation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 12:11:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 11:11:13 +0000 Subject: [Koha-bugs] [Bug 29872] New: Article requests: Include information on host record in article requests table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29872 Bug ID: 29872 Summary: Article requests: Include information on host record in article requests table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If an article request is placed on an analytical record, it would be very helpful to display the information about the host record in the table of article requests. A first step would be to display the information from 773 and maybe create a search link for the record using the title or number from $w. If we can look-up the host record on server side, we could also provide a link with the biblionumber could also be provided. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 12:17:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 11:17:21 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #4 from Owen Leonard --- The best way to get this bug moving is to test and sign off on the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 12:33:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 11:33:18 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Summary|Add Koha::Hold->fulfill |Add Koha::Hold->fill CC| |kyle at bywatersolutions.com --- Comment #1 from Tomás Cohen Arazi --- ->fill, I meant ->fill :-D. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:01:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:01:07 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:32:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:32:45 +0000 Subject: [Koha-bugs] [Bug 29873] New: 2FA: Generate QR code without exposing secret via HTTP GET Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Bug ID: 29873 Summary: 2FA: Generate QR code without exposing secret via HTTP GET Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org See bug 28786. The Google Charts API shows the secret in the src of the image. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:33:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:33:04 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #57 from Marcel de Rooy --- Opened bug 29873 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:33:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:33:23 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 [Bug 28786] Two-factor authentication for staff client - TOTP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:33:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:33:23 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:33:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:33:54 +0000 Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff client - omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:33:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:33:54 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476 [Bug 20476] Two factor authentication for the staff client - omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:35:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:35:02 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:47:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:47:45 +0000 Subject: [Koha-bugs] [Bug 29874] New: Remove unused method C4::SIP::ILS::Item::fill_reserve Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Bug ID: 29874 Summary: Remove unused method C4::SIP::ILS::Item::fill_reserve Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The method is only mentioned when it is defined in the codebase. Likely unused, as C4::Circulation::AddIssue already fills the hold if required. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:48:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:48:02 +0000 Subject: [Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29869 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fill -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:48:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:48:02 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:52:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:52:24 +0000 Subject: [Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:53:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:53:07 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:53:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:53:11 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129395&action=edit Bug 29869: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:53:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:53:16 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129396&action=edit Bug 29869: Add Koha::Hold->fill This patch introduces a new method for marking a hold as filled. The code is the result of tracking the following methods in C4::Reserves: - ModReserveFill - GetReserveFee - ChargeReserveFee To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:53:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:53:20 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 129397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129397&action=edit Bug 29869: Make ModReserveFill a (temporary) wrapper for Koha::Hold->fill Before diving into removing ModReserveFill, I propose this: In order to perform real-life testing of the new Koha::Hold->fill method, this patch makes the ModReserveFill method, just call the new one. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/api/v1/holds.t \ t/db_dependent/Reserves* \ t/db_dependent/Circulation* \ t/db_dependent/SIP/* => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:53:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:53:24 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 129398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129398&action=edit Bug 29869: Remove C4::Reserves::ModReserveFill -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:58:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:58:03 +0000 Subject: [Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129399&action=edit Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve This patch removes the unused method. Likely a leftover from ancient ages. AddIssue already fills the hold and is called in the Checkout.pm library. To test: 1. Run: $ git grep fill_reserve => FAIL: Notice it is only mentioned in the line that defines it 2. Apply this patch 3. Repeat 1 => SUCCESS: Removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:59:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:59:49 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 13:59:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 12:59:49 +0000 Subject: [Koha-bugs] [Bug 17728] Move C4::Reserves code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fill -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 14:01:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 13:01:02 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |jonathan.druart+koha at gmail. | |com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 14:04:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 13:04:20 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 129400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129400&action=edit Bug 29869: Teach log viewer about FILL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 14:37:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 13:37:35 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #7 from Martin Renvoize --- All looks solid to me, and I like that you specify the log action more clearly. Unfortunately, the unit tests patch wont apply for me.. sha1 issues. Otherwise I'm happy to SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 14:52:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 13:52:08 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Marcel de Rooy --- Will give it a go -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 14:56:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 13:56:22 +0000 Subject: [Koha-bugs] [Bug 29866] Notices and Slips presentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29866 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #1 from Owen Leonard --- I don't work with a lot of different notices, but I think this sounds like it could be a nice improvement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 14:58:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 13:58:39 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED Assignee|david.roberts at ptfs-europe.c |oleonard at myacpl.org |om | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:14:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:14:48 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:14:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:14:53 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65036|0 |1 is obsolete| | --- Comment #14 from Owen Leonard --- Created attachment 129401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129401&action=edit Bug 7374: Add remote image option for authorized values This patch adds the option of using a remote image for an authorized value, just as you can with item types. To test, apply the patch and go to Administration -> Authorized values. - Click "CCODE" to view the collection authorized values. - Edit a collection code. - In the form, under "Choose an icon," there should now be a "Remote image" tab. - Enter a remote image url, e.g. https://via.placeholder.com/50/FF0000/FFFFFF.png - Click "Save." - After the page redirects to the list of collection codes you should see your image in the table next to the code you edited. - Test that you can still edit a collection to set "No image" or to use one of the local image sets. - Test that remote images can also be added when adding a new collection. - Make sure "ccode" is in the "AdvancedSearchTypes" sytem preference. - Go to the catalog's advanced search page and click the "Collection" tab. - You should see your collection image in the list of collections. - Perform the same check in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:15:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:15:21 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29867 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 [Bug 29867] Reindent authorized values administration template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:15:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:15:21 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 [Bug 7374] Add remote image option for authorized values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:20:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:20:40 +0000 Subject: [Koha-bugs] [Bug 29875] New: Update text on MaxReserves system preference to describe functionality. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Bug ID: 29875 Summary: Update text on MaxReserves system preference to describe functionality. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently, this syspref reads "Patrons can only have (X) holds at once." I would update that to: "Patrons can have a maximum of (X) holds at once. Leave blank or set to zero to disable." I've just confirmed this behavior on master: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron We've got discussion of this syspref generally over in 25643, but unless we're moving it in the near future we should at least make it clear and accurate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:20:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:20:40 +0000 Subject: [Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29875 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:25:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:25:41 +0000 Subject: [Koha-bugs] [Bug 25996] Changes to debarments should be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:41:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:41:44 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #2 from Marcel de Rooy --- Created attachment 129402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129402&action=edit Bug 29873: Create QR code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:43:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:43:18 +0000 Subject: [Koha-bugs] [Bug 29876] New: Style report id in report results heading Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Bug ID: 29876 Summary: Style report id in report results heading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 24834 Created attachment 129403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129403&action=edit Screenshot showing the updated interface I find the inclusion of the report id in the heading of the SQL report results page to be confusing because it can look like it is showing the number of results. I think adding some style to it would help. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24834 [Bug 24834] Display report number after running -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:43:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:43:18 +0000 Subject: [Koha-bugs] [Bug 24834] Display report number after running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24834 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29876 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 [Bug 29876] Style report id in report results heading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:46:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:46:06 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #3 from Marcel de Rooy --- Work in progress. But should give you an idea. Works for me. But needs some POD, unit testing, dependency registering. It uses Imager::QRCode, packaged for Debian in libimager-qrcode-perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:46:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:46:18 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:46:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:46:33 +0000 Subject: [Koha-bugs] [Bug 29877] New: MaxReserves should be enforced consistently between staff interface and API Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Bug ID: 29877 Summary: MaxReserves should be enforced consistently between staff interface and API Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To test: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron via staff interface, but the second is blocked 4 - confirm you can place 1 for a patron via API, but the second is blocked 5 - set maxreserves to 0 6 - confirm you can place any number of holds for the patron via the staff interface 7 - confirm you can place 0 holds for your patron via the API 8 - set maxreserves to blank 9 - confirm you can place any number of holds for the patron 10 - confirm you can place 0 holds for your patron via the API We should make the API treat zero and blank as un-set, as the staff interface does. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:46:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:46:33 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29877 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:46:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:46:33 +0000 Subject: [Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29877 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:48:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:48:29 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Instead of calling the release notes| |(deprecated) Google Charts | |API and exposing our | |secret, we create the image | |ourself and push it as a | |data uri in the src | |attribute of the image | |(inline image). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:48:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:48:38 +0000 Subject: [Koha-bugs] [Bug 29876] Style report id in report results heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:48:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:48:41 +0000 Subject: [Koha-bugs] [Bug 29876] Style report id in report results heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 --- Comment #1 from Owen Leonard --- Created attachment 129404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129404&action=edit Bug 29876: Style report id in report results heading This patch makes minor changes to the template and adds some CSS to style the report id portion of the page heading. To test, apply the patch and go to Reports -> Saved SQL reports. - Run any report. - On the results page, confirm that the report id portion of the page heading is styled and labeled "Report number." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:50:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:50:22 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:50:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:50:24 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129400|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:50:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:50:28 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129395|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:50:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:50:31 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129396|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:50:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:50:34 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129397|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:50:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:50:37 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129398|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:51:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:51:04 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 129405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129405&action=edit Bug 29869: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:51:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:51:09 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 129406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129406&action=edit Bug 29869: Add Koha::Hold->fill This patch introduces a new method for marking a hold as filled. The code is the result of tracking the following methods in C4::Reserves: - ModReserveFill - GetReserveFee - ChargeReserveFee To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:51:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:51:14 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 129407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129407&action=edit Bug 29869: Make ModReserveFill a (temporary) wrapper for Koha::Hold->fill Before diving into removing ModReserveFill, I propose this: In order to perform real-life testing of the new Koha::Hold->fill method, this patch makes the ModReserveFill method, just call the new one. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/api/v1/holds.t \ t/db_dependent/Reserves* \ t/db_dependent/Circulation* \ t/db_dependent/SIP/* => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:51:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:51:20 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 129408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129408&action=edit Bug 29869: Remove C4::Reserves::ModReserveFill -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:51:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:51:24 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 129409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129409&action=edit Bug 29869: Teach log viewer about FILL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:54:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:54:09 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 [Bug 29868] Add Koha::Old::Hold->anonymize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:54:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:54:09 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fill -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:57:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:57:05 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 --- Comment #4 from Tomás Cohen Arazi --- Resubmitted and made it dependent on bug 29869 as they both add tests to Koha/Hold.t and the count is always gonna be a problem :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:58:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:58:04 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #24 from Tomás Cohen Arazi --- Ok, bug adds Koha::Hold->fill with tests, bells and whistles. I will now make it anonymize the same way we did with Koha:Hold->cancel. And we are done :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:58:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:58:47 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #7) > All looks solid to me, and I like that you specify the log action more > clearly. > > Unfortunately, the unit tests patch wont apply for me.. sha1 issues. > > Otherwise I'm happy to SO Reordered the whole tree. Sorry for that, and thanks for looking at this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 16:01:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 15:01:12 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | Status|NEW |ASSIGNED Component|Hold requests |REST API CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 16:01:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 15:01:19 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 15:56:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 14:56:09 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129360|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129410&action=edit Bug 29868: Add Koha::Old::Hold->anonymize This patch introduces a new method in Koha::Old::Hold. The method is fully covered by tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 16:16:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 15:16:12 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129411&action=edit Bug 29877: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 16:16:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 15:16:20 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129412&action=edit Bug 29877: Make POST /holds handle maxreserves correctly The current implementation doesn't consider the following values for the syspref: undef and 0. The tests mistakenly didn't cover them. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail, obvious warnings about comparing undefined values too. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. You can try on Postman as well => SUCCESS: Behavior is correct! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 16:16:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 15:16:59 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 16:31:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 15:31:04 +0000 Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 16:31:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 15:31:08 +0000 Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 --- Comment #5 from Owen Leonard --- Created attachment 129413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129413&action=edit Bug 29057: [alternate] Use font awesome icons on request.pl This patch offers an alternate take on using Font Awesome icons on the holds page in place of images as links. To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 16:41:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 15:41:09 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 16:41:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 15:41:12 +0000 Subject: [Koha-bugs] [Bug 29760] Show patron category in Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129354|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 129414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129414&action=edit Bug 29760: Add patron category column to view_holdsqueue.tt To test: 1. Have some holds and build the holds queue. 2. Go to view_holdsqueue.tt, there is no patron category column 3. Apply patch 4. Look again, there should now be a column for 'Patron category' showing both the caterory name and the category code. 5. Make sure you can sort and filter by this new column 6. Go to table settings and make sure you can properly hide this column and all other columns in the Holds queue. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:10:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:10:49 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:10:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:10:52 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129411|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 129415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129415&action=edit Bug 29877: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:10:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:10:56 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129412|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 129416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129416&action=edit Bug 29877: Make POST /holds handle maxreserves correctly The current implementation doesn't consider the following values for the syspref: undef and 0. The tests mistakenly didn't cover them. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail, obvious warnings about comparing undefined values too. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. You can try on Postman as well => SUCCESS: Behavior is correct! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:17:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:17:52 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129405|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 129417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129417&action=edit Bug 29869: Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:17:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:17:56 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129406|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 129418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129418&action=edit Bug 29869: Add Koha::Hold->fill This patch introduces a new method for marking a hold as filled. The code is the result of tracking the following methods in C4::Reserves: - ModReserveFill - GetReserveFee - ChargeReserveFee To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:18:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:18:00 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129407|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 129419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129419&action=edit Bug 29869: Make ModReserveFill a (temporary) wrapper for Koha::Hold->fill Before diving into removing ModReserveFill, I propose this: In order to perform real-life testing of the new Koha::Hold->fill method, this patch makes the ModReserveFill method, just call the new one. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/api/v1/holds.t \ t/db_dependent/Reserves* \ t/db_dependent/Circulation* \ t/db_dependent/SIP/* => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:18:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:18:04 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129408|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 129420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129420&action=edit Bug 29869: Remove C4::Reserves::ModReserveFill Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:18:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:18:08 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129409|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 129421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129421&action=edit Bug 29869: Teach log viewer about FILL Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:22:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:22:47 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #19 from Martin Renvoize --- Great to see unit tests, I like the method you've used, adding tests, replacing the internals of the original method, then finally removing the original method.. it meant I could run tests at each point before applying subsequent patches. All works well at every stage.. feeling confident Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:23:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:23:56 +0000 Subject: [Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129399|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 129422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129422&action=edit Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve This patch removes the unused method. Likely a leftover from ancient ages. AddIssue already fills the hold and is called in the Checkout.pm library. To test: 1. Run: $ git grep fill_reserve => FAIL: Notice it is only mentioned in the line that defines it 2. Apply this patch 3. Repeat 1 => SUCCESS: Removed. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:26:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:26:24 +0000 Subject: [Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- I agree... I can't find any uses of this method. I believe we handle all this inside the relevant Koha:: methods that trigger fulfilment now instead. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:56:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:56:15 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 17:56:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 16:56:18 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129410|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 129423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129423&action=edit Bug 29868: Add Koha::Old::Hold->anonymize This patch introduces a new method in Koha::Old::Hold. The method is fully covered by tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:23:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:23:54 +0000 Subject: [Koha-bugs] [Bug 29872] Article requests: Include information on host record in article requests table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29872 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:24:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:24:25 +0000 Subject: [Koha-bugs] [Bug 29872] Article requests: Include information on host record in article requests table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29872 --- Comment #1 from Marcel de Rooy --- Guess you are already aware of the redirection feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:34:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:34:25 +0000 Subject: [Koha-bugs] [Bug 29878] New: Use multiple select widget for AdvancedSearchTypes system preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Bug ID: 29878 Summary: Use multiple select widget for AdvancedSearchTypes system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The AdvancedSearchTypes system preference asks for pipe-delimited text, which isn't very user-friendly. We can use a multiple-select widget (as used for OpacAdvSearchOptions for example) to allow the user to select one or more predefined options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:48:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:48:05 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:48:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:48:08 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:48:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:48:11 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129322|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:48:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:48:15 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129323|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:48:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:48:18 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:49:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:49:19 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 129424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129424&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:49:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:49:25 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 129425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129425&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev > UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY); 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:49:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:49:31 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 129426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129426&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:49:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:49:36 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 129427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129427&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required This patch makes cancelling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, cancelling a hold, noticing it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:49:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:49:42 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 129428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129428&action=edit Bug 29525: Make Koha::Hold->fill anonymize if required This patch makes filling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, notice it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:56:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:56:26 +0000 Subject: [Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:56:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:56:29 +0000 Subject: [Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 --- Comment #1 from Owen Leonard --- Created attachment 129429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129429&action=edit Bug 29878: Use multiple select widget for AdvancedSearchTypes system preference This patch updates system preferences so that the AdvancedSearchTypes preference uses a multiple-select widget. This lets users select one or more checkboxes in a dropdown rather than requiring that they enter pipe-delimited text. To test, apply the patch and run updatedatabase. - Go to Administration -> System Preferences and search for 'AdvancedSearchTypes' - The input should be styled as a multiple-select widget. Test that you can select one, more, or all of the options. - Test that your selections are saved successfully and that the changes are reflected on the OPAC and staff interface advanced search pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:58:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:58:44 +0000 Subject: [Koha-bugs] [Bug 29876] Style report id in report results heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:58:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:58:47 +0000 Subject: [Koha-bugs] [Bug 29876] Style report id in report results heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129404|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 129430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129430&action=edit Bug 29876: Style report id in report results heading This patch makes minor changes to the template and adds some CSS to style the report id portion of the page heading. To test, apply the patch and go to Reports -> Saved SQL reports. - Run any report. - On the results page, confirm that the report id portion of the page heading is styled and labeled "Report number." Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 18:59:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 17:59:48 +0000 Subject: [Koha-bugs] [Bug 29876] Style report id in report results heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29876 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #3 from Lucas Gass --- This is makes it much more clear, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 19:13:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 18:13:44 +0000 Subject: [Koha-bugs] [Bug 29879] New: Make sure objects moved to old_* is not tried to be saved again Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29879 Bug ID: 29879 Summary: Make sure objects moved to old_* is not tried to be saved again Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org When a checkout or a hold is completed, Koha moves the issues/reserves row to their old_* counterpart. We are leaning towards chaining calls to simplify code, but calling methods like Koha::Hold->cancel or Koha::Hold->fill should somehow mark the current object so trying to store it by mistake should raise an exception. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 19:13:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 18:13:47 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 19:14:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 18:14:00 +0000 Subject: [Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 19:14:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 18:14:03 +0000 Subject: [Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129429|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 129431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129431&action=edit Bug 29878: Use multiple select widget for AdvancedSearchTypes system preference This patch updates system preferences so that the AdvancedSearchTypes preference uses a multiple-select widget. This lets users select one or more checkboxes in a dropdown rather than requiring that they enter pipe-delimited text. To test, apply the patch and run updatedatabase. - Go to Administration -> System Preferences and search for 'AdvancedSearchTypes' - The input should be styled as a multiple-select widget. Test that you can select one, more, or all of the options. - Test that your selections are saved successfully and that the changes are reflected on the OPAC and staff interface advanced search pages. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 19:14:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 18:14:51 +0000 Subject: [Koha-bugs] [Bug 29879] Make sure objects moved to old_* is not tried to be saved again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29879 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29525 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 19:14:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 18:14:51 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29879 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29879 [Bug 29879] Make sure objects moved to old_* is not tried to be saved again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 19:42:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 18:42:18 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com, | |wainuiwitikapark at catalyst.n | |et.nz --- Comment #6 from Lucas Gass --- I see the button does include a title attribute of 'Search' which is good but does that cover all accessibility cases? Should this not also include an aria-label for screen readers and mobile devices? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 19:55:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 18:55:13 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tomás Cohen Arazi --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:01:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:01:53 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:01:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:01:57 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129424|0 |1 is obsolete| | --- Comment #30 from Andrew Fuerste-Henry --- Created attachment 129432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129432&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:02:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:02:00 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129425|0 |1 is obsolete| | --- Comment #31 from Andrew Fuerste-Henry --- Created attachment 129433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129433&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev > UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY); 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:02:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:02:04 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129426|0 |1 is obsolete| | --- Comment #32 from Andrew Fuerste-Henry --- Created attachment 129434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129434&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:02:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:02:09 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129427|0 |1 is obsolete| | --- Comment #33 from Andrew Fuerste-Henry --- Created attachment 129435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129435&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required This patch makes cancelling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, cancelling a hold, noticing it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:02:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:02:13 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129428|0 |1 is obsolete| | --- Comment #34 from Andrew Fuerste-Henry --- Created attachment 129436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129436&action=edit Bug 29525: Make Koha::Hold->fill anonymize if required This patch makes filling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, notice it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:09:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:09:56 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:15:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:15:10 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:19:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:19:07 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:19:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:19:10 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 129437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129437&action=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:21:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:21:01 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:21:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:21:05 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129274|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:21:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:21:07 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129275|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:21:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:21:12 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:21:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:21:15 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129277|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:21:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:21:19 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129278|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:21:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:21:51 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 129438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129438&action=edit Bug 29843: Unit tests This patch adds unit tests for the introduced methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:21:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:21:57 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 129439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129439&action=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:22:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:22:05 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 129440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129440&action=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:22:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:22:12 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 129441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129441&action=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:22:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:22:18 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 129442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129442&action=edit Bug 29843: Use in tools/cleanborrowers.pl This patch makes tools/cleanborrowers.pl use the new methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:26:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:26:38 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29525 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:26:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:26:38 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29869 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fill -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:42:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:42:39 +0000 Subject: [Koha-bugs] [Bug 29880] New: Add_items permission needed for patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29880 Bug ID: 29880 Summary: Add_items permission needed for patrons Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jendayi30 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently, the edit_items permission allows users to both add and edit items. We have a central department that does all the library processing and we'd like to ensure that only the staff in that department be allowed to add items in order to ensure consistency and quality in our records. Ideally, the central department would be able to use the add_items and edit_items option and our staff on the campuses would be able to edit_items only (combined with the edit_items_restricted option). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:45:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:45:37 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:45:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:45:37 +0000 Subject: [Koha-bugs] [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:47:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:47:36 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129437|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 129443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129443&action=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:48:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:48:45 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129443|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 129444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129444&action=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:49:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:49:12 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 --- Comment #5 from Andrew Fuerste-Henry --- Added a sentence: "Additional limits may apply based on circulation rules." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:49:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:49:16 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129440|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:49:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:49:35 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129441|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:49:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:49:49 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129442|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:50:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:50:02 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129438|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:50:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:50:09 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:51:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:51:58 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 129445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129445&action=edit Bug 29843: Unit tests This patch adds unit tests for the introduced methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:52:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:52:04 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 129446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129446&action=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:52:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:52:13 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 129447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129447&action=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:52:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:52:21 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 129448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129448&action=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 20:52:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 19:52:30 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 129449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129449&action=edit Bug 29843: Use in tools/cleanborrowers.pl This patch makes tools/cleanborrowers.pl use the new methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 21:58:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 20:58:02 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 21:58:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 20:58:06 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 129450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129450&action=edit Bug 29843: Unit tests This patch adds unit tests for the introduced methods. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 21:58:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 20:58:09 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 129451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129451&action=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 21:58:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 20:58:13 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 129452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129452&action=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 21:58:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 20:58:17 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #11 from Andrew Fuerste-Henry --- Created attachment 129453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129453&action=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 21:58:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 20:58:20 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #12 from Andrew Fuerste-Henry --- Created attachment 129454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129454&action=edit Bug 29843: Use in tools/cleanborrowers.pl This patch makes tools/cleanborrowers.pl use the new methods. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 22:18:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 21:18:54 +0000 Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- I like Owen's patch. The only thing I would say is that the use of the using the 'fa-rotate-90 fa-fast-foward' icon in the 'Toggle set to lowest priority' column looks awkward. Is it nessesary to have it in the ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 22:49:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 21:49:38 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Andrew Fuerste-Henry --- I followed the test plan successfully except: - your directions are inconsistent. To make step 8 work, the rule in step 3 should use dateaccessioned and the rule in step 5 should use datelastseen - I get a messy error on the test at the end. I don't have a clue what this means, so it could be my error: Cannot detect source of 't/db_dependent/Item/AutomaticItemModificationByAge'! at /usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 256. TAP::Parser::IteratorFactory::detect_source(TAP::Parser::IteratorFactory=HASH(0x55d2dc3c5c48), TAP::Parser::Source=HASH(0x55d2dc292438)) called at /usr/share/perl/5.32/TAP/Parser/IteratorFactory.pm line 211 TAP::Parser::IteratorFactory::make_iterator(TAP::Parser::IteratorFactory=HASH(0x55d2dc3c5c48), TAP::Parser::Source=HASH(0x55d2dc292438)) called at /usr/share/perl/5.32/TAP/Parser.pm line 472 TAP::Parser::_initialize(TAP::Parser=HASH(0x55d2dc030148), HASH(0x55d2dc03fee0)) called at /usr/share/perl/5.32/TAP/Object.pm line 55 TAP::Object::new("TAP::Parser", HASH(0x55d2dc03fee0)) called at /usr/share/perl/5.32/TAP/Object.pm line 130 TAP::Object::_construct(TAP::Harness=HASH(0x55d2dbad1678), "TAP::Parser", HASH(0x55d2dc03fee0)) called at /usr/share/perl/5.32/TAP/Harness.pm line 852 TAP::Harness::make_parser(TAP::Harness=HASH(0x55d2dbad1678), TAP::Parser::Scheduler::Job=HASH(0x55d2dc268728)) called at /usr/share/perl/5.32/TAP/Harness.pm line 651 TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x55d2dbad1678), TAP::Parser::Aggregator=HASH(0x55d2dbad2128), TAP::Parser::Scheduler=HASH(0x55d2dc2686f8)) called at /usr/share/perl/5.32/TAP/Harness.pm line 743 TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x55d2dbad1678), TAP::Parser::Aggregator=HASH(0x55d2dbad2128), "t/db_dependent/Item/AutomaticItemModificationByAge.t") called at /usr/share/perl/5.32/TAP/Harness.pm line 558 TAP::Harness::__ANON__() called at /usr/share/perl/5.32/TAP/Harness.pm line 571 TAP::Harness::runtests(TAP::Harness=HASH(0x55d2dbad1678), "t/db_dependent/Item/AutomaticItemModificationByAge.t") called at /usr/share/perl/5.32/App/Prove.pm line 548 App::Prove::_runtests(App::Prove=HASH(0x55d2dba9c538), HASH(0x55d2dbf17978), "t/db_dependent/Item/AutomaticItemModificationByAge.t") called at /usr/share/perl/5.32/App/Prove.pm line 506 App::Prove::run(App::Prove=HASH(0x55d2dba9c538)) called at /usr/bin/prove line 13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 22:50:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 21:50:03 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #8 from Andrew Fuerste-Henry --- That said, I'm super excited to see a patch here and am eager to test again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 22:52:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 21:52:03 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #9 from Alex Buckley --- (In reply to Andrew Fuerste-Henry from comment #8) > That said, I'm super excited to see a patch here and am eager to test again! Thanks Andrew. Hmm I'll fix up those 2 problems and attach a new patch to this ASAP! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 23:31:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 22:31:12 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 13 23:31:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 22:31:16 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129444|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi --- Created attachment 129455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129455&action=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 00:18:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Jan 2022 23:18:26 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Christopher Brannon --- I'm testing on a sandbox, and before I add the patch, everything work right. But when I add the patch, if I try to edit an existing CCODE, it acts like it is creating a new value instead of editing the existing one. All fields are blank. This patch is messing with existing functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 01:38:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 00:38:49 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 01:40:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 00:40:30 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |In patron notices table, release notes| |notices are now shown in a | |modal dialog instead of | |inline in the table. | |The | |"Resend" button is shown in | |the modal window controls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 02:09:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 01:09:34 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 02:09:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 01:09:38 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 --- Comment #1 from Lucas Gass --- Created attachment 129456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129456&action=edit Bug 24220: Move OpacMoreSearches to HTML customizations in additional-contents To test: 1- Before applying the patch add some content to the system preference OpacMoreSearches 2- Apply patch 3- restart_all and updatedatabase 4. Go to additional-content.pl ( HTML customizations ) 5. You should now see your content from the system preference under OpacMoreSearches in HTML customizations 6. Try searching for the system preference, OpacMoreSeaches. It has been removed and you should not be able to find it. 7. Try changing/removing/adding content from OpacMoreSearches in HTML customizations 8. Make sure your edits are reflected when you look at the OpacMoreSearch area in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 02:10:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 01:10:02 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 02:21:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 01:21:58 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129456|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 129457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129457&action=edit Bug 24220: Move OpacMoreSearches to HTML customizations in additional-contents To test: 1- Before applying the patch add some content to the system preference OpacMoreSearches 2- Apply patch 3- restart_all and updatedatabase 4. Go to additional-content.pl ( HTML customizations ) 5. You should now see your content from the system preference under OpacMoreSearches in HTML customizations 6. Try searching for the system preference, OpacMoreSeaches. It has been removed and you should not be able to find it. 7. Try changing/removing/adding content from OpacMoreSearches in HTML customizations 8. Make sure your edits are reflected when you look at the OpacMoreSearch area in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 02:37:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 01:37:19 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #31 from Fridolin Somers --- I've fixed a bit wiki page : https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file The perl file must contain "return" and have execute permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 02:53:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 01:53:00 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #32 from Fridolin Somers --- Created attachment 129458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129458&action=edit Bug 20076: (RM follow-up) Fix default value in installer/data/mysql/mandatory/sysprefs.sql Previous patch changed default value to 1 in atomicupdate, do the same in installer/data/mysql/mandatory/sysprefs.sql Also to be consistant, sets options = NULL instead of '' in atomicupdate Also removed useless added empty line in /misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 02:53:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 01:53:56 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:11:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:11:57 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129458|0 |1 is obsolete| | --- Comment #33 from Fridolin Somers --- Created attachment 129459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129459&action=edit Bug 20076: (RM follow-up) Fix system preference boolean logic A Yes/No system preference must use 1 for Yes and 0 for No. So "Send" for 1/Yes and "Don't send" for 0/No. We add too much problems with double-negation boolean system preferences (such as dontmerge). Previous patch changed default value to 1 in atomicupdate, do the same in installer/data/mysql/mandatory/sysprefs.sql Also to be consistant, sets options = NULL instead of '' in atomicupdate Also removed useless added empty line in /misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:15 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:17 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #34 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:19 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:22 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 --- Comment #18 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:24 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:26 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 --- Comment #11 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:29 +0000 Subject: [Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:31 +0000 Subject: [Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:33 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:35 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 --- Comment #11 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:38 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:40 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 --- Comment #21 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:42 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:44 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:46 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:38:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:38:49 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 03:54:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 02:54:39 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Tomás Cohen Arazi --- (In reply to Andrew Fuerste-Henry from comment #5) > Added a sentence: "Additional limits may apply based on circulation rules." Great. Hope Katrin signs it so it can be added before string freeze! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 04:07:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 03:07:29 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129371|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 04:08:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 03:08:09 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 --- Comment #10 from Alex Buckley --- Created attachment 129460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129460&action=edit Bug 22827: Add age dependency on other fields than dateaccessioned A new agefield has been added to the 'Automatic item modifications by age' tool. The options for the agefield are: replacementpricedate, datelastborrowed, datelastseen, damaged_on, itemlost_on, withdrawn_on If no option is selected then Koha will default to saving 'agefield' = items.dateaccessioned Similarly, if a Koha instance has an old item rule without 'agefield' defined then Koha will default to using 'items.dateaccessioned'. This is confirmed by the AutomaticItemModificationByAge.t unit test. Test plan: 1. Go to: Tools > Catalog > Automatic item modifications by age 2. Observe there is a new 'Age field' dropdown in the rule form. 3. Create a rule, set the values: - 'Age in days' = 20 - Leave 'Age field' = 'Choose an age field' - 'Substitutions': 'items.barcode' = 'test' - Save the rule 4. Confirm the 'List of rules' page displays 'items.dateaccessioned in the 'Age field' column 5. Add another rule: - 'Age in days' = 2 - 'Age field' = 'items.datelastseen' - 'Substitutions': 'items.barcode' = 'test2' - Save the rule 6. Confirm the 'List of rules' page displays 'items.datelastseen' in the 'Age field' column for that second rule 7. Add some more rules and confirm you can delete them 8. Edit a record: - Make the items.dateaccessioned = 3 day ago (so rule 1 is false) - Make the items.datelastseen = 3 days ago (so rule 2 is true) 9. Run the automatic_items_modification_by_age.pl: - sudo koha-shell - cd misc/cronjobs - ./automatic_item_modification_by_age.pl -v -c 10. Confirm the item has it's barcode set to 'test2' 11. Run unit tests: - sudo koha-shell - prove t/db_dependent/Items/AutomaticItemModificationByAge.t -v Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 04:19:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 03:19:41 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #11 from Alex Buckley --- Hi Andrew and Martin, Martin: Thank you for your reply in comment #6. My concerns with hard coding were: 1. Everytime a datetime column is added to the items table then the community would have to remember to update this hardcoded list of columns. 2. If an existing datetime column is removed/renamed then the hardcoded list would have to be updated otherwise my alterations to C4::Items->ToggleNewStatus() would throw an error. As the hardcoded list determines what column is queried. But as you say doing an introspect of the koha::Object may not be worthwhile. So I have left the hardcoded list for now. I'm happy to add it later though if that is what QA wants. Andrew: I have corrected the test plan. That error you encountered was because my test plan noted an incorrect unit test filepath. So it was not your error :) Could you please re-test now? Many thanks! Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 04:43:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 03:43:31 +0000 Subject: [Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #9 from Alex Buckley --- (In reply to Marcel de Rooy from comment #8) > If I am reading the comment from Jeremy again (from 2017..) and my response > in 2017, they could have used private lists shared between the needed staff > members at that time already (but using OPAC) without the need for any code > changes. > > I think there is a report about adding code for supporting shared lists in > staff too. > > But I would certainly not oppose a permission scheme that allows selected > staff members to view *some* lists. Just another road. In the past we were > very cautious here in view of privacy issues though. But there should be > ways to address that and inform users accordingly. Hi Marcel, Thanks for your reply. Yep, that makes sense. I may revisit this and try to submit a patch for it, separately from my work on bug 26346. But will leave the assignee as 'koha-bugs at lists.koha-community.org' for now and set it back to 'Assigned', in case someone else wants to work on it. Thanks, Alex -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 04:44:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 03:44:14 +0000 Subject: [Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #10 from Alex Buckley --- Correction: Set it back to 'New'! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 07:43:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 06:43:41 +0000 Subject: [Koha-bugs] [Bug 29881] New: libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Bug ID: 29881 Summary: libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com to test... - attempt to install koha-common pkg on deb12 confirm error... The following packages have unmet dependencies: koha-common : Depends: libdbd-sqlite2-perl but it is not installable - apply patch, rebuild new package - install new koha-common pkg on deb12 successfully -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 07:44:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 06:44:09 +0000 Subject: [Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=4269 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 07:44:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 06:44:09 +0000 Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29881 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 07:47:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 06:47:58 +0000 Subject: [Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 07:48:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 06:48:02 +0000 Subject: [Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 --- Comment #1 from Mason James --- Created attachment 129461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129461&action=edit Bug 29881: libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) to test... - attempt to install koha-common pkg on deb12 confirm error... The following packages have unmet dependencies: koha-common : Depends: libdbd-sqlite2-perl but it is not installable - apply patch, rebuild new package - install new koha-common pkg on deb12 successfully -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 07:59:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 06:59:42 +0000 Subject: [Koha-bugs] [Bug 29882] New: remove unrequired package definitions in list-deps script Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Bug ID: 29882 Summary: remove unrequired package definitions in list-deps script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com to test... - apply patch, rebuild new package - install new koha-common pkg on successfully -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:01:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:01:53 +0000 Subject: [Koha-bugs] [Bug 29882] remove unrequired package definitions in list-deps script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:01:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:01:57 +0000 Subject: [Koha-bugs] [Bug 29882] remove unrequired package definitions in list-deps script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 --- Comment #1 from Mason James --- Created attachment 129462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129462&action=edit Bug 29882 - remove unrequired package definitions in list-deps script to test... - apply patch, rebuild new package - install new koha-common pkg successfully -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:26:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:26:57 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #36 from Marcel de Rooy --- + my $type = ref($self); + + $type =~ s|Schema::Result::||; + return $type . "s"; Frowning. Educated guess? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:27:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:27:34 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #37 from Marcel de Rooy --- Out of scope, but heh: libraries_where_can_see_patrons This is a really awful name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:29:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:29:24 +0000 Subject: [Koha-bugs] [Bug 28670] api/v1/patrons_holds.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28670 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- Still valid : https://jenkins.koha-community.org/view/master/job/Koha_Master_D11_CPAN/510/testReport/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:33:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:33:08 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #38 from Marcel de Rooy --- +sub accessible { + my ($self) = @_; + + return $self->_get_objects_class->search_limited( + { + map { $_ => $self->$_ } + $self->_result->result_source->primary_columns + } + )->count > 0 + ? 1 + : 0; +} At first glance this looks like a great performance killer. If we are in the singular object already, it should be very cheap to see if user A has access. Okay, we might have to duplicate a bit of code in accessible and search_limited to make that work, but save performance. Which might be a more important gain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:38:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:38:25 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #39 from Marcel de Rooy --- - return unless $self->accessible; + return unless $self->is_accessible_in_context($params); Not sure if this is an improvement. Access probably always needs a context, so it seems implicit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:38:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:38:38 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- I impacted wiki page https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:40:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:40:44 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #40 from Marcel de Rooy --- -sub accessible { +sub is_accessible_in_context { my ($self) = @_; - return $self->_get_objects_class->search_limited( - { - map { $_ => $self->$_ } - $self->_result->result_source->primary_columns - } - )->count > 0 - ? 1 - : 0; + return 1; } This happens in the last patch (from another author). This mystifies matters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:43:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:43:21 +0000 Subject: [Koha-bugs] [Bug 29838] No string interpolation when expected in t/db_dependent/ImportBatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29838 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Patch obsolete by mistake ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:45:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:45:09 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #41 from Marcel de Rooy --- +sub is_accessible_in_context { + my ( $self, $params ) = @_; + + # FIXME? It felt tempting to return 0 instead + # but it would mean needing to explicitly add the 'user' + # param in all tests... + return 1 + unless $params->{user}; + + my $consumer = $params->{user}; + return $consumer->can_see_patron_infos($self); +} User, consumer, patron. Unclear. The FIXME tells me that we should think a little bit more about what we really want to do here? We should obviously try to avoid adding it like this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:45:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:45:15 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:45:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:45:22 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:47:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:47:02 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #42 from Marcel de Rooy --- Looking at the complete patch set, this raises enough questions to consider it as not ready for production. Should we discuss this in a larger audience? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:54:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:54:59 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:55:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:55:34 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #4 from Fridolin Somers --- Oups t/db_dependent/Koha/IssuingRules.t fails. We can remove the file. And there is still t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t. We should simply rename forder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:58:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:58:24 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:58:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:58:28 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129455|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 129463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129463&action=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 08:58:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 07:58:37 +0000 Subject: [Koha-bugs] [Bug 29875] Update text on MaxReserves system preference to describe functionality. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:00:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:00:41 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 --- Comment #5 from Fridolin Somers --- (In reply to Fridolin Somers from comment #4) > Oups > > t/db_dependent/Koha/IssuingRules.t fails. > We can remove the file. > > And there is still > t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t. > We should simply rename forder. I mean t/db_dependent/Circulation/IssuingRules I move maxsuspensiondays.t to parent folder and remove IssuingRules folder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:10:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:10:52 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:10:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:10:56 +0000 Subject: [Koha-bugs] [Bug 29705] Test suite has some IssuingRules left-overs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29705 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129138|0 |1 is obsolete| | --- Comment #6 from Fridolin Somers --- Created attachment 129464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129464&action=edit Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t prove t/db_dependent/Koha/CirculationRules/* prove t/db_dependent/Circulation/maxsuspensiondays.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:11:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:11:04 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:11:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:11:16 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #27 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:12:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:12:42 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:12:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:12:44 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:12:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:12:46 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:12:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:12:48 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:12:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:12:51 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:12:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:12:53 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:13:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:13:36 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #28 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #5) > Also.. being slightly picky.. I'd update the comment lines that explain the > regex's.. > > # iso or sql format are yyyy-dd-mm[ hh:mm:ss]" > > and > > # Add the faculative time part [hh:mm[:ss]] Even more picky. What about spelling? Facultative? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:18:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:18:43 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #29 from Marcel de Rooy --- (?[Zz]$)|((?[\+|\-])(?[01][0-9]|2[0-3]):(?[0-5][0-9])) What slightly confuses is that we use the names hours and minutes here while we also use hour and minute. It is not completely clear that the hours and minutes belong to the tz offset. Better name? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:49:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:49:12 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #30 from Marcel de Rooy --- The UTC offset is appended to the time in the same way that 'Z' was above, in the form ±[hh]:[mm], ±[hh][mm], or ±[hh]. So we should be able to specify +02, +0200 as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 09:50:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 08:50:22 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #5 from Eugene Espinoza --- I am trying this out in the Koha sandboxes, it seems the patches are not being applied when I check in the git.log. I tried various combinations. I tried for Enter repository url: https://gitlab.com/koha-dev/koha-dev https://gitlab.com/koha-dev/koha-dev/-/tree/bug-11783-upgrade-jstree https://gitlab.com/koha-dev/koha-dev.git And for branch, either "bug-11783-upgrade-jstree" or "https://gitlab.com/koha-dev/koha-dev/-/tree/bug-11783-upgrade-jstree". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:36:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:36:59 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:37:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:37:03 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129385|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy --- Created attachment 129465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129465&action=edit Bug 29718: Support ISO8601 Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:37:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:37:07 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129386|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy --- Created attachment 129466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129466&action=edit Bug 29718: (QA follow-up) Make 'T' check case insensative Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:37:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:37:11 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129387|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy --- Created attachment 129467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129467&action=edit Bug 29718: (QA follow-up) Add optional offset handling ISO8601 optionally supports timezone offsets. If a timezone is ommited, we should assume 'local' time (Which in our case is instance configuration time), if we are passed 'Z' or 'z' we should set timezone to 'UTC', otherwise we should set the timezone to the passed offset. Whilst ISO8601 does NOT support AM/PM, I left that intact as it has historical relevance in Koha and we share the ISO parsing with SQL type parsing amongth other things. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:37:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:37:14 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129388|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy --- Created attachment 129468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129468&action=edit Bug 29718: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:37:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:37:17 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129389|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy --- Created attachment 129469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129469&action=edit Bug 29718: Mock the timezone Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:37:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:37:21 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129390|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy --- Created attachment 129470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129470&action=edit Bug 29718: (QA follow-up) Remove duplicate test I'd inadvertantly introduced the exact same test twice! This patch removes the duplicate and annotates the test to clarify the timezone handling expectations. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:37:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:37:25 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #37 from Marcel de Rooy --- Created attachment 129471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129471&action=edit Bug 29718: (QA follow-up) ISO 8601 allows +02 and +0200 The UTC offset is appended to the time in the form: ±[hh]:[mm], ±[hh][mm], or ±[hh] Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:45:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:45:39 +0000 Subject: [Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #4 from Sophie MEYNIEUX --- I think there is two distinct points : 1/ The ability to define preferences 2/ Central activation/desactivation of notifications 1/ Should always be on (see bug 20405) 2/ Could be a preference system. Scripts that send notices must check if on before sending, whatever preferences are. This will allow to suspend temporarily notifications without changing parameters. At the moment, when preferences are set, if you disable EnhancedMessagingPreferences, you can't see how preferences are configured in admin interface, but notices are still sent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:45:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:45:50 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #46 from Marcel de Rooy --- QA: Having a look here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:52:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:52:54 +0000 Subject: [Koha-bugs] [Bug 29883] New: Uninitialized value warning when GetAuthorisedValues gets called with no parameters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883 Bug ID: 29883 Summary: Uninitialized value warning when GetAuthorisedValues gets called with no parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: stalkernoid at gmail.com Reporter: stalkernoid at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:54:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:54:07 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #47 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #0) > Our dt_from_string regex for time is optional.. as such we allow for > non-matches.. but we don't check that the string as a whole matches a valid > date/datetime string.. thus we don't fail when we should. A first observation: The bug title is not matching this description. This description is much wider than the title is suggesting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:58:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:58:16 +0000 Subject: [Koha-bugs] [Bug 29883] Uninitialized value warning when GetAuthorisedValues gets called with no parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:58:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:58:19 +0000 Subject: [Koha-bugs] [Bug 29883] Uninitialized value warning when GetAuthorisedValues gets called with no parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883 --- Comment #1 from Peter Vashchuk --- Created attachment 129472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129472&action=edit Bug 29883: avoid uninitialized value warn in GetAuthorisedValues sub GetAuthorisedValues is defined with optional parameter $category but it is instantly interpolated without preventing "Use of uninitialized value $category in concatenation (.) or string at .../C4/Koha.pm line 491." warning. As category param is optional, we can avoid throwing that warn as it is something that can happen and is not an actual error: C<$category> returns authorized values for just one category (optional). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 10:59:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 09:59:18 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #48 from Marcel de Rooy --- - t::lib::Dates::compare( $updated_on_got, $updated_on_expected, 'updated_on values matched' ); + t::lib::Dates::compare( + dt_from_string( $updated_on_got, 'rfc3339' ), + dt_from_string( $updated_on_expected, 'rfc3339' ), + 'updated_on values matched' + ); But what does t::lib::Dates? sub compare { my ( $got, $expected ) = @_; my $dt_got = dt_from_string($got); my $dt_expected = dt_from_string($expected); my $diff = $dt_got->epoch - $dt_expected->epoch; if ( abs($diff) <= 5 ) { return 0 } return $diff > 0 ? 1 : -1; } So $got en $expected should be strings, right? Does this actually show that we miss a parameter in sub compare, and we are solving it by twisting the test instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 11:01:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 10:01:50 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #49 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #21) > (In reply to Fridolin Somers from comment #19) > > I revert from master > > Ideally we prefer to not revert but fix. It will get messy if you revert > every time jenkins is failing after a push :) Sure ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 11:02:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 10:02:46 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #50 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #15) > In my opinion we should not backport those patches. Seems to be wise. Will mark this as enh. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 11:08:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 10:08:59 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #51 from Marcel de Rooy --- t::lib::Dates::compare expects either correct DateTime objects, or a system formatted datetime strings to be passed.. but as we're testing the API, we are consistently using RFC3339 strings for date-times and ISO8601 strings for dates. We need to therefore pre-process the strings into DateTime objects for the comparison. See comment48 Imo this sub needs more attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 11:15:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 10:15:17 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #52 from Marcel de Rooy --- commit dfcb2b8071582a55e35c47926d4b5c1b8b2a9a59 Author: Jonathan Druart Date: Fri Aug 25 17:56:52 2017 -0300 Bug 19176: Compare the number of seconds when comparing dates in tests Five years go fast. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 11:18:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 10:18:18 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #35 from Thibaud Guillot --- Thanks for the review Fridolin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 11:27:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 10:27:48 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #53 from Marcel de Rooy --- Including a 'T' is actually valid for ISO date format, I was being naughty and writing the test to follow our code rather than writing the test to conform to the ISO spec first time around. Now we are properly supporting 'T' in ISO dates with bug 29718, we need to update the test here to properly reflect an invalid ISO date string. - $dt0 = dt_from_string('2021-11-03T10:16:59+00:00', 'iso'); + $dt0 = dt_from_string('2021-11-03T10:16:59Z+00:00', 'iso'); This is rather unclear. The changes do not reflect the description. You dont do anything with T here. Adding the Z is making the test pass by failure on the combination of Z and +00. I will add a comment on this line and another one to clarify. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 11:35:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 10:35:39 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #54 from Marcel de Rooy --- Created attachment 129473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129473&action=edit Bug 29403: (QA follow-up) Add comments why test should fail Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 11:40:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 10:40:05 +0000 Subject: [Koha-bugs] [Bug 29883] Uninitialized value warning when GetAuthorisedValues gets called with no parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 11:49:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 10:49:46 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #55 from Marcel de Rooy --- Setting the status to FQA for now. Please adjust or provide feedback on earlier comments. I have various tests failing but could not quickly decide if that relates to this patch set. Please provide evidence that all tests using dt_from_string still pass. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 11:49:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 10:49:55 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart+koha at gmail. |m.de.rooy at rijksmuseum.nl |com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 11:50:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 10:50:38 +0000 Subject: [Koha-bugs] [Bug 29838] No string interpolation when expected in t/db_dependent/ImportBatch.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129358|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 12:37:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 11:37:07 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Owen Leonard --- I've tested this again in my local test system and I can't reproduce that problem. I wonder if it could be an issue with the sandbox? I'm going to put this back to "Needs signoff" in the hopes that someone can try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 12:41:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 11:41:59 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #20 from Tomás Cohen Arazi --- It applies cleanly on latest master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 12:53:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 11:53:54 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #38 from Martin Renvoize --- Nice call regards +02 vs +02:00 and +0200.. I hadn't spotted that.. and.. it turns out I've been spelling facultative wrong my entire life.. lol. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 13:06:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 12:06:08 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|dt_from_string should fail |dt_from_string should fail |if passed an rfc3339 |if passed more data than |formatted string when 'iso' |expected for the format |is selected as dateformat | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 13:08:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 12:08:00 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #58 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #56) > There are several issues. Some are blockers, some could be dealt with on > follow-up reports, as is already the case for storing the secret. > > [1] This code pattern looks wrong: > my $secret = Koha::AuthUtils::generate_salt( 'weak', 16 ); > my $auth = Koha::Auth::TwoFactorAuth->new( { patron => $logged_in_user, > secret => $secret } ); > my $secret32 = $auth->generate_secret32; > What you do with generate_secret32 is effectively wasting your own secret. > Note that Auth::GoogleAuth uses 16 random numbers 0-31 to create a new > secret. > If you pass a secret, GoogleAuth will convert it to base32 internally. > The synopsis in the module is wrong too. > This is a blocker. But simple to correct. Indeed, good catch. I think it's a leftover of a first version. > [2] The randomizer (which we should not use) depends on Math::Random::MT. > This module says: This algorithm has a very uniform distribution and is good > for modelling purposes but do not use it for cryptography. > As long as we pass our own stronger secrets, no worries. See [1]. Sorry, you lost me here. Which randomizer module? > [3] Martin refers earlier to Authen::OATH. I follow him there, but no > blocker. Why? Did you see my answer on comment 23? On the other hand if we do not longer use the QR code generator from Auth::GoogleAuth there is no bad reason to not switch. But what are your good reasons to switch then? :) > [4] The argument used before "Also, it can generate QR codes out-of-the-box" > is currently actually an issue. It creates a link like > https://chart.googleapis.com/chart?&cht=qr with the secret as a URL GET > parameter. That's obviously unsafe! > Furthermore, this Google API has been deprecated for some years already. > https://developers.google.com/chart/infographics/docs/qr_codes > > We could use the $return_otpauth parameter to create the QR code ourselves. > Personally, I would not use this in its current form. But I would propose to > solve this issue on a follow-up report. Agreed, I will be happy to test it. > [5] This one I did not yet fully tackle. But I have the impression that we > have an issue in C4/Auth now. A few times already I had to login twice. > This MIGHT be a blocker. Needs still investigation. Hum, I didn't experience it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 13:13:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 12:13:04 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #56 from Martin Renvoize --- * I've adapted the bug title as requested. * Before the last submission, I ran the test suite for db_dependant/api/* and everything is passing. I also ran a few other tests that included dt_from_string.. but not all.. nothing failed so far * The compare function is indeed a bit of a fudge.. but one from quite a while ago.. I'm not sure if we should be attempting to fix that here or not.. I'm also not entirely happy with the shared ISO/SQL/Fallback behaviour.. we're still not being explicit in our iso support (We're allowing for am/pm which is not allowed in ISO). Not sure what more to do here.. happy to discus for clarifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 13:14:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 12:14:26 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #59 from Jonathan Druart --- Created attachment 129474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129474&action=edit Bug 28786: Don't pass unecessary secret to constructor This is a leftover what a misunderstanding I had at first reading the module's pod, generate_secret32 does not generate the base-32 version of the secret we passed in parameter to the constructor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 13:14:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 12:14:55 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #57 from Martin Renvoize --- OK, Running the whole test suite against this now.. will report back -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:00:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:00:50 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129448|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:00:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:00:54 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129449|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:00:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:00:57 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129445|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:01:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:01:00 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129446|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:01:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:01:04 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129447|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:01:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:01:39 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 129475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129475&action=edit Bug 29843: Unit tests This patch adds unit tests for the introduced methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:01:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:01:43 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 129476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129476&action=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:01:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:01:49 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 129477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129477&action=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:01:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:01:54 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 129478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129478&action=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:01:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:01:58 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 129479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129479&action=edit Bug 29843: Use in tools/cleanborrowers.pl This patch makes tools/cleanborrowers.pl use the new methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:07:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:07:06 +0000 Subject: [Koha-bugs] [Bug 26296] Use new table column selection modal for OPAC suggestion fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:07:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:07:07 +0000 Subject: [Koha-bugs] [Bug 29695] Centralize columns' descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29695 Bug 29695 depends on bug 26296, which changed state. Bug 26296 Summary: Use new table column selection modal for OPAC suggestion fields https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26296 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:07:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:07:54 +0000 Subject: [Koha-bugs] [Bug 29747] Cataloguing upload plugin broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29747 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:23:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:23:04 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:23:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:23:08 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129457|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 129480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129480&action=edit Bug 24220: Move OpacMoreSearches to HTML customizations in additional-contents To test: 1- Before applying the patch add some content to the system preference OpacMoreSearches 2- Apply patch 3- restart_all and updatedatabase 4. Go to additional-content.pl ( HTML customizations ) 5. You should now see your content from the system preference under OpacMoreSearches in HTML customizations 6. Try searching for the system preference, OpacMoreSeaches. It has been removed and you should not be able to find it. 7. Try changing/removing/adding content from OpacMoreSearches in HTML customizations 8. Make sure your edits are reflected when you look at the OpacMoreSearch area in the OPAC. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:27:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:27:58 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:28:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:28:02 +0000 Subject: [Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129460|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry --- Created attachment 129481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129481&action=edit Bug 22827: Add age dependency on other fields than dateaccessioned A new agefield has been added to the 'Automatic item modifications by age' tool. The options for the agefield are: replacementpricedate, datelastborrowed, datelastseen, damaged_on, itemlost_on, withdrawn_on If no option is selected then Koha will default to saving 'agefield' = items.dateaccessioned Similarly, if a Koha instance has an old item rule without 'agefield' defined then Koha will default to using 'items.dateaccessioned'. This is confirmed by the AutomaticItemModificationByAge.t unit test. Test plan: 1. Go to: Tools > Catalog > Automatic item modifications by age 2. Observe there is a new 'Age field' dropdown in the rule form. 3. Create a rule, set the values: - 'Age in days' = 20 - Leave 'Age field' = 'Choose an age field' - 'Substitutions': 'items.barcode' = 'test' - Save the rule 4. Confirm the 'List of rules' page displays 'items.dateaccessioned in the 'Age field' column 5. Add another rule: - 'Age in days' = 2 - 'Age field' = 'items.datelastseen' - 'Substitutions': 'items.barcode' = 'test2' - Save the rule 6. Confirm the 'List of rules' page displays 'items.datelastseen' in the 'Age field' column for that second rule 7. Add some more rules and confirm you can delete them 8. Edit a record: - Make the items.dateaccessioned = 3 day ago (so rule 1 is false) - Make the items.datelastseen = 3 days ago (so rule 2 is true) 9. Run the automatic_items_modification_by_age.pl: - sudo koha-shell - cd misc/cronjobs - ./automatic_item_modification_by_age.pl -v -c 10. Confirm the item has it's barcode set to 'test2' 11. Run unit tests: - sudo koha-shell - prove t/db_dependent/Items/AutomaticItemModificationByAge.t -v Sponsored-By: Catalyst IT Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:32:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:32:39 +0000 Subject: [Koha-bugs] [Bug 22153] Automatic item modifications by age: Boolean options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22153 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:37:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:37:11 +0000 Subject: [Koha-bugs] [Bug 29794] delete_items.pl missing include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29794 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:38:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:38:31 +0000 Subject: [Koha-bugs] [Bug 29737] Cannot suspend holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29737 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #9 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:40:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:40:51 +0000 Subject: [Koha-bugs] [Bug 29778] Deleting additional_contents leaves entries for additional languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29778 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:41:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:41:09 +0000 Subject: [Koha-bugs] [Bug 29391] Improve output of reservoir search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29391 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 14:55:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 13:55:33 +0000 Subject: [Koha-bugs] [Bug 29553] Holds: Can't call method "notforloan" on an undefined value when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29553 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:03:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:03:23 +0000 Subject: [Koha-bugs] [Bug 29789] Unused $error in cataloguing/additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29789 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:04:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:04:20 +0000 Subject: [Koha-bugs] [Bug 29790] Deleting serial items fail without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29790 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:04:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:04:39 +0000 Subject: [Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:05:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:05:07 +0000 Subject: [Koha-bugs] [Bug 29688] Incorrect use of _() in holds.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #7 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:10:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:10:02 +0000 Subject: [Koha-bugs] [Bug 29419] Suggest for purchase clears item type, quantity, library and reason if bib exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29419 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:11:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:11:54 +0000 Subject: [Koha-bugs] [Bug 17127] Can't hide MARC21 500 and others with NotesToHide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17127 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #18 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:13:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:13:45 +0000 Subject: [Koha-bugs] [Bug 29557] Auto renew notices should handle failed renewal due to patron expiration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #9 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:16:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:16:07 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29884 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 [Bug 29884] Missing test in api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:16:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:16:07 +0000 Subject: [Koha-bugs] [Bug 29884] New: Missing test in api/v1/patrons.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Bug ID: 29884 Summary: Missing test in api/v1/patrons.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 28632 t::lib::Dates::compare( $updated_on_got, $updated_on_expected, 'updated_on values matched' ); compare is not calling is() or ok(), it's caller job to do it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 [Bug 28632] patrons.t fragile on slow boxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:16:17 +0000 Subject: [Koha-bugs] [Bug 29856] Make the ES config more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29856 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:17:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:17:40 +0000 Subject: [Koha-bugs] [Bug 29685] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items on opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:18:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:18:35 +0000 Subject: [Koha-bugs] [Bug 29840] opac-reserve explodes if invalid biblionumber is passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29840 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:18:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:18:50 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:18:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:18:54 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 --- Comment #1 from Jonathan Druart --- Created attachment 129482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129482&action=edit Bug 29884: Run missing test in api/v1/patrons.t compare is not calling is() or ok(), it's caller job to do it. Test plan: prove t/db_dependent/api/v1/patrons.t should still return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:19:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:19:35 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29884 --- Comment #58 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #48) > - t::lib::Dates::compare( $updated_on_got, $updated_on_expected, > 'updated_on values matched' ); > + t::lib::Dates::compare( > + dt_from_string( $updated_on_got, 'rfc3339' ), > + dt_from_string( $updated_on_expected, 'rfc3339' ), > + 'updated_on values matched' > + ); > > But what does t::lib::Dates? > > sub compare { > my ( $got, $expected ) = @_; > my $dt_got = dt_from_string($got); > my $dt_expected = dt_from_string($expected); > my $diff = $dt_got->epoch - $dt_expected->epoch; > if ( abs($diff) <= 5 ) { return 0 } > return $diff > 0 ? 1 : -1; > } > > So $got en $expected should be strings, right? > Does this actually show that we miss a parameter in sub compare, and we are > solving it by twisting the test instead? Will fix on bug 29884. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 [Bug 29884] Missing test in api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:19:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:19:35 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 [Bug 29403] dt_from_string should fail if passed more data than expected for the format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:19:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:19:51 +0000 Subject: [Koha-bugs] [Bug 29840] opac-reserve explodes if invalid biblionumber is passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29840 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:19:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:19:55 +0000 Subject: [Koha-bugs] [Bug 29840] opac-reserve explodes if invalid biblionumber is passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29840 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129320|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129483&action=edit Bug 29840: Deal with non-existing biblionumber in opac-reserve We should not explode if the biblionumber passed in not in DB. Test plan: Hit /cgi-bin/koha/opac-reserve.pl?biblionumber=42424 and notice the error message. Without this patch you got Can't call method "holds" on an undefined value at /kohadevbox/koha/opac/opac-reserve.pl line 172 Signed-off-by: Owen Leonard Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:20:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:20:11 +0000 Subject: [Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #30 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:20:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:20:18 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:20:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:20:22 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 --- Comment #9 from Nick Clemens --- Created attachment 129484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129484&action=edit Bug 21652: Unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:20:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:20:26 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129100|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 129485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129485&action=edit Bug 21652: Only set waitingdate to today if there is no waitingdate already 1- Find or create a hold with a waitingdate other than today 2- Check the item in to generate a new hold alert 3- Select "Confirm and Print" 4- Verify that the waiting date has changed to the current date 5- Apply patch 6- Try 1-3 again, if a waitingdate already exists it should not change 7. Try an item with no waitingdate, it should properly update to today Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:22:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:22:01 +0000 Subject: [Koha-bugs] [Bug 29491] Improve display of notices in patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29491 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:22:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:22:42 +0000 Subject: [Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:24:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:24:47 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 --- Comment #21 from Nick Clemens --- (In reply to Tomás Cohen Arazi from comment #20) > Is there room for different storage backends here? Yes, this patch provides only 'Directory' but see Koha::Storage for documentation on defining in koha conf and provide another Adapter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:25:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:25:06 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129393|0 |1 is obsolete| | Attachment #129394|0 |1 is obsolete| | Attachment #129473|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart --- Created attachment 129486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129486&action=edit Bug 29403: Fix api/v1/patrons.t t::lib::Dates::compare expects either correct DateTime objects, or a system formatted datetime strings to be passed.. but as we're testing the API, we are consistently using RFC3339 strings for date-times and ISO8601 strings for dates. We need to therefore pre-process the strings into DateTime objects for the comparison. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:25:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:25:11 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #60 from Jonathan Druart --- Created attachment 129487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129487&action=edit Bug 29403: Fix unit test for bug 29718 Including a 'T' is actually valid for ISO date format, I was being naughty and writing the test to follow our code rather than writing the test to conform to the ISO spec first time around. Now we are properly supporting 'T' in ISO dates with bug 29718, we need to update the test here to properly reflect an invalid ISO date string. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:25:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:25:16 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #61 from Jonathan Druart --- Created attachment 129488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129488&action=edit Bug 29403: (QA follow-up) Add comments why test should fail Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:26:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:26:50 +0000 Subject: [Koha-bugs] [Bug 29530] When NumSavedReports is set, show value in pull down of entries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:27:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:27:13 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:27:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:27:54 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:27:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:27:58 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127131|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:28:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:28:01 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127132|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:28:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:28:04 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127478|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:28:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:28:40 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 129489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129489&action=edit Bug 28238: Add tests Add specific tests for the tag itemcallnumber in GetAvailability output. Sponsored-by: University Lyon 3 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:28:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:28:45 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 129490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129490&action=edit Bug 28238: Add itemcallnumber to ils-di GetAvailability output Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:28:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:28:47 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #36 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:28:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:28:50 +0000 Subject: [Koha-bugs] [Bug 28238] Add itemcallnumber to ILS-DI GetAvailability output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28238 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 129491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129491&action=edit Bug 28238: (follow-up) Add itemcallnumber to ILS-DI GetAvailability output for unavailable items Providing the call number for ILS-DI GetAvailability output is useful for libraries that use discovery tools. Patrons often don't check further for the call number, and then they don't have it when they look for the item. It could also be use full to have this call number when the item isn't available (to make a request for it for instance). Test plan: 1. Enable the ILS-DI system preference 2. Locate a record with multiple items and make sure they have call numbers for each item and that some are unavailable 3. Test these URLs: [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[BIBLIONUMBER]&id_type=biblio and [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[ITEMNUMBER]&id_type=item (Where the [OPACBASEURL] is the OPAC URL of your test instance, [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of your choice.) 4. Apply the patch 5. Run the queries from step 3 again - all the results should now have the tag itemcallnumber (not only the available's ones) Example: 840.08 COR R Sponsored-by: University Lyon 3 https://bugs.koha-community.org/show_bug.cgi?id=28238 Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:31:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:31:48 +0000 Subject: [Koha-bugs] [Bug 29552] flatpickr quick shortcuts should be 'Disabled' for invalid dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | CC| |kyle at bywatersolutions.com --- Comment #22 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:32:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:32:24 +0000 Subject: [Koha-bugs] [Bug 29735] Remove flatpickr instantiations from .js files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:34:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:34:01 +0000 Subject: [Koha-bugs] [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #19 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:35:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:35:25 +0000 Subject: [Koha-bugs] [Bug 29736] Error when placing a hold for a club without members In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29736 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:39:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:39:01 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:39:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:39:12 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:39:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:39:20 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:39:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:39:27 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:39:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:39:33 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:39:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:39:39 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:39:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:39:44 +0000 Subject: [Koha-bugs] [Bug 29813] skeleton.pl missing semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:40:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:40:44 +0000 Subject: [Koha-bugs] [Bug 29702] all_libraries routine in library groups make a DB call per member of group In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:41:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:41:28 +0000 Subject: [Koha-bugs] [Bug 29717] Too many DateTime manipulation in tools/additional-contents.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:57:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:57:06 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:57:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:57:11 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129475|0 |1 is obsolete| | --- Comment #25 from Andrew Fuerste-Henry --- Created attachment 129492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129492&action=edit Bug 29843: Unit tests This patch adds unit tests for the introduced methods. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:57:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:57:16 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129476|0 |1 is obsolete| | --- Comment #26 from Andrew Fuerste-Henry --- Created attachment 129493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129493&action=edit Bug 29843: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts This patch implements high-level methods for: * Filtering a Koha::Old::Checkouts resultset so only anonymizable rows are left * Anonymizing the rows in a resultset To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:57:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:57:20 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129477|0 |1 is obsolete| | --- Comment #27 from Andrew Fuerste-Henry --- Created attachment 129494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129494&action=edit Bug 29843: Use in batch_anonymise.pl This patch makes the batch_anonymise.pl cronjob script use the newly introduced methods instead of the old ones. To test: 1. Try the tool => SUCCESS: No behavior change 2. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:57:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:57:24 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129478|0 |1 is obsolete| | --- Comment #28 from Andrew Fuerste-Henry --- Created attachment 129495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129495&action=edit Bug 29843: Use in opac/opac-privacy.pl This patch makes the opac/opac-privacy.pl OPAC page use the new anonymize method. To test: 1. Have some checked-in materiales 2. Have OPACPrivacy enabled 3. Notice your checkouts history contains what you expect 4. Go to 'your privacy' 5. Click on 'Delete checkout history' => SUCCESS: It works, no crash. 6. Sign off :-D Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:57:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:57:28 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129479|0 |1 is obsolete| | --- Comment #29 from Andrew Fuerste-Henry --- Created attachment 129496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129496&action=edit Bug 29843: Use in tools/cleanborrowers.pl This patch makes tools/cleanborrowers.pl use the new methods. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:58:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:58:02 +0000 Subject: [Koha-bugs] [Bug 22157] HideLostItems items still show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22157 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |nick at bywatersolutions.com Status|NEW |RESOLVED --- Comment #2 from Nick Clemens --- Fixed by bug 24254 *** This bug has been marked as a duplicate of bug 24254 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 15:58:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 14:58:02 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #66 from Nick Clemens --- *** Bug 22157 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 16:20:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 15:20:37 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 16:20:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 15:20:43 +0000 Subject: [Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 16:43:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 15:43:27 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 16:54:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 15:54:36 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Nick Clemens --- bug 23991 - I ran the script to generate random suggesstions - I can see them - apply patch, I don't see them If I load from library link on homepage, I see them but if i change library using pulldown I can't the 'all libraries' link form homepage does not work either http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?branchcode=FFL&displayb[…]eptedby=&accepteddate_from=&accepteddate_to=&budgetid=__ANY__ that shows nothing http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?branchcode=FFL That shows things Logs show this often: [2022/01/14 15:21:34] [WARN] Use of uninitialized value in string eq at /kohadevbox/koha/suggestion/suggestion.pl line 113. [2022/01/14 15:21:34] [WARN] Use of uninitialized value $v in string eq at /kohadevbox/koha/suggestion/suggestion.pl line 115. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 16:56:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 15:56:57 +0000 Subject: [Koha-bugs] [Bug 29885] New: Add the option to customise Z39.50 searches Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29885 Bug ID: 29885 Summary: Add the option to customise Z39.50 searches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: jake.deery at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, Foremost, this is my first bug report. If the community has preferences on how this system is best used, please do let me know, and I'll be happy to learn! One of our customers recently asked me to file this bug report. Their exact comments were: "Also, I wondered if it would be worth to put this on the bugzilla as a desired implementation in one of the coming Koha versions, to add Title series and Publisher. I can imagine other libraries also finding this useful. And to have the option to 'hide' fields from the Z39.50/SRU search form that are not relevant to a certain library (maybe in the same way you can now hide certain columns from showing in e.g. the item record)." I think it would be a great Koha enhancement to be able to pick which attributes are used in Z39.50 / SRU searches, hide/remove unnecessary values, and even add custom search attributes as required. If anyone has anything to add/suggest, please be my guest, and take the floor! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 16:57:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 15:57:10 +0000 Subject: [Koha-bugs] [Bug 29885] Add the option to customise Z39.50 searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29885 Jake Deery changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 16:59:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 15:59:55 +0000 Subject: [Koha-bugs] [Bug 29886] New: Add Koha::Suggestions->search_limited Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Bug ID: 29886 Summary: Add Koha::Suggestions->search_limited Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org SearchSuggestion does filtering on IndependentBranches, etc. We need to implement Koha::Suggestions->search_limited that does that as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:00:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:00:12 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 [Bug 29886] Add Koha::Suggestions->search_limited -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:00:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:00:12 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Blocks| |23991 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:17:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:17:42 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #78 from Andrew Fuerste-Henry --- Initial notes (more to follow): - Items WERE NOT created when receiving orders in a basket set to Create Items On Receiving for orders created either on an existing bib or a new bib (not tied to a subscription or purchase suggestion). - For orders tied to a purchase suggestion, the purchase suggestion link displays as "(suggestion #undefined)" and the link doesn't work (points to /cgi-bin/koha/suggestion/suggestion.pl?suggestionid=undefined&op=show) - on /acqui/orderreceive.pl?multiple_orders, the list of all selected order numbers is ugly. it shows like "[Vendor] [basket] (order #27667,27673)." With a lot of orders, it's not nice to look at. Do we need to list them all? Could we at least add spaces so it breaks across lines? - when increasing the quantity received for an order from a basket set to create items when cataloging, we got this warning: "Order 27690: Warning, you have entered more items than expected. Items will not be created." This is technically true, but seems unneeded. We didn't ever expect this order to make items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:21:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:21:32 +0000 Subject: [Koha-bugs] [Bug 22535] Use Link Shortcuts when creating reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22535 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |nick at bywatersolutions.com Status|NEW |RESOLVED --- Comment #2 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 5697 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:21:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:21:32 +0000 Subject: [Koha-bugs] [Bug 5697] Automatic linking in guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5697 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #33 from Nick Clemens --- *** Bug 22535 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:38:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:38:28 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29878 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:38:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:38:28 +0000 Subject: [Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17018 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 [Bug 17018] Split AdvancedSearchTypes for staff and OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:38:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:38:54 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:38:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:38:57 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 --- Comment #1 from Owen Leonard --- Created attachment 129497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129497&action=edit Bug 17018: Split AdvancedSearchTypes for staff and OPAC This patch adds a new system preference, OpacAdvancedSearchTypes, as an OPAC-specific version of the AdvancedSearchTypes preference. Values from AdvancedSearchTypes are copied to OpacAdvancedSearchTypes so that behavior is consistent. To test, apply the patch and run the database update process. - Go to Administration -> System preferences. - Search for AdvancedSearchTypes. You should get two results, one for the OPAC preference and one for the staff interface. - Check that the OpacAdvancedSearchTypes settings match the AdvancedSearchTypes settings. - View the advanced search pages in the staff interface and OPAC to confirm that the tabs look correct. - Change the OpacAdvancedSearchTypes and AdvancedSearchTypes settings to be different and confirm that each is applied separately to each interface. - Enable the OpacTopissue system preference. - View the "Most popular" page in the OPAC. - The OpacAdvancedSearchTypes settings should be reflected in the "Refine your search" sidebar: If "Collection" is checked, a filter for collection should appear. If "Item types" is checked, a filter for item types should appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:40:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:40:26 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:40:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:40:31 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128971|0 |1 is obsolete| | Attachment #128972|0 |1 is obsolete| | Attachment #128973|0 |1 is obsolete| | Attachment #129200|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart --- Created attachment 129498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129498&action=edit Bug 29043: Don't fetch biblios info unless a patron is picked If we haven't picked a patron or a club yet we don't need to fetch biblios, items and holdability infos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:41:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:41:56 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #37 from Jonathan Druart --- @ reserve/request.pl:199 @ $template->param( multi_hold => $multi_hold, ); +# If we are coming from the search result and only 1 is selected +$biblionumber ||= $biblionumbers[0] unless $multi_hold; # If we have the borrowernumber because we've performed an action, then we # don't want to try to place another reserve. if ($borrowernumber_hold && !$action) { @ reserve/request.pl:297 @ $template->param( messageclub => $messageclub ); +# Load the hold list if +# - we are searching for a patron or club and found one +# - we are not searching for anything +if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold ) + || ( !$findborrower && !$findclub ) ) +{ # FIXME launch another time GetMember perhaps until (Joubu: Why?) my $patron = Koha::Patrons->find( $borrowernumber_hold ); @ reserve/request.pl:771 @ foreach my $biblionumber (@biblionumbers) { $template->param( biblioloop => \@biblioloop ); $template->param( no_reserves_allowed => $no_reserves_allowed ); -$template->param( biblionumbers => join('/', @biblionumbers) ); $template->param( exceeded_maxreserves => $exceeded_maxreserves ); $template->param( exceeded_holds_per_record => $exceeded_holds_per_record ); $template->param( subscriptionsnumber => CountSubscriptionFromBiblionumber($biblionumber)); +} elsif ( ! $multi_hold ) { + my $biblio = Koha::Biblios->find( $biblionumber ); + $template->param( biblio => $biblio ); +} +if ( $multi_hold ) { + $template->param( biblionumbers => join('/', @biblionumbers) ); +} else { + $template->param( biblionumber => $biblionumber || $biblionumbers[0] ); +} # pass the userenv branch if no pickup location selected $template->param( pickup => $pickup || C4::Context->userenv->{branch} ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:42:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:42:08 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #38 from Jonathan Druart --- Rebased and fixed a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:56:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:56:45 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127883|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry --- Created attachment 129499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129499&action=edit Bug 29483: Unit tests This patch updates the AllowRenewalIfOtherItemsAvailable tests to remove deletion of all data, and create specific circ rules for this test. It adjust several other tests that were relying on the rules from this test, so thy too create their opwn specific rules. Additionally, we add tests to cover the case of mutliple items on the record, and some items cannot fill some reserves. What is uncovered here is that the same patron is checked twice, so two holds can be filled, but they only satisfy a single patron Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:56:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:56:50 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127884|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry --- Created attachment 129500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129500&action=edit Bug 29483: Check ItemsAnyAvailableAndNotRestricted once per patron ItemsAnyAvailableAndNotRestricted can take a long time and create nested loops. We can check it once per patron, however, this requires us to flip the loops. Since an item can only be used once, we now add a check to see if this item has already been assigned to a borrower. To test: 1 - Find or create a biblio with 100 items 2 - Place ten 'Next available' holds on a biblio 3 - Set preference 'AllowRenewalIfOtherItemsAvailable' to 'Allow' Set circ rules 'On shelf holds allowed' to 'If any unavailable' 4 - Checkout one of the items to a patron, backdated to be overdue 5 - Note a long loading time for the patron's checkouts 6 - Apply patch, restart_all 7 - Patron loads much faster Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:56:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:56:54 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127885|0 |1 is obsolete| | --- Comment #15 from Andrew Fuerste-Henry --- Created attachment 129501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129501&action=edit Bug 29483: Further improve performance of script This patch adds a few tests to cover more cases, and to highlight current functionality. The script only allows renewal if all outstanding holds can be filled by available items. This means we can return as soon as we have determined that not all holds can be filled. I add FIXME and some explanatory comments - I will file a follow-up bug for those, but I feel we can accept these improvements to the performance and deal with the issues of how it 'should' work versus how it does work on another report. To test: 1 - prove -v t/db_dependent/Circulation.t Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:57:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:57:40 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Attachment #129453|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:57:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:57:41 +0000 Subject: [Koha-bugs] [Bug 29887] New: Create system preference IndependentBranchesLoggedInLibrary Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Bug ID: 29887 Summary: Create system preference IndependentBranchesLoggedInLibrary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently if IndependentBranches is turned on it makes it so staff cannot switch branches or 'Set library' unless they are a superlibrarian. Some libraries like this aspect of IndependentBranches but don't want everything else that comes with turning on IndependentBranches. A new system pref 'IndependentBranchesLoggedInLibrary' would allow libraries to utilize this aspect of IndependentBranches without having to turn on everything else that comes with that system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:57:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:57:50 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129454|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:57:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:57:58 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129499|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:58:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:58:06 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129500|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:58:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:58:14 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129501|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 17:58:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 16:58:50 +0000 Subject: [Koha-bugs] [Bug 29483] AllowRenewalIfOtherItemsAvailable has poor performance for records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29483 --- Comment #16 from Andrew Fuerste-Henry --- Accidentally put a signoff for another bug here. I've now *actually* signed off here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 18:12:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 17:12:12 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 18:12:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 17:12:15 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129417|0 |1 is obsolete| | Attachment #129418|0 |1 is obsolete| | Attachment #129419|0 |1 is obsolete| | Attachment #129420|0 |1 is obsolete| | Attachment #129421|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 129502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129502&action=edit Bug 29869: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 18:13:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 17:13:03 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #22 from Kyle M Hall --- Created attachment 129503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129503&action=edit Bug 29869: Add Koha::Hold->fill This patch introduces a new method for marking a hold as filled. The code is the result of tracking the following methods in C4::Reserves: - ModReserveFill - GetReserveFee - ChargeReserveFee To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 18:13:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 17:13:07 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #23 from Kyle M Hall --- Created attachment 129504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129504&action=edit Bug 29869: Make ModReserveFill a (temporary) wrapper for Koha::Hold->fill Before diving into removing ModReserveFill, I propose this: In order to perform real-life testing of the new Koha::Hold->fill method, this patch makes the ModReserveFill method, just call the new one. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/api/v1/holds.t \ t/db_dependent/Reserves* \ t/db_dependent/Circulation* \ t/db_dependent/SIP/* => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 18:13:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 17:13:10 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #24 from Kyle M Hall --- Created attachment 129505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129505&action=edit Bug 29869: Remove C4::Reserves::ModReserveFill Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 18:13:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 17:13:13 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #25 from Kyle M Hall --- Created attachment 129506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129506&action=edit Bug 29869: Teach log viewer about FILL Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 18:13:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 17:13:17 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #26 from Kyle M Hall --- Created attachment 129507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129507&action=edit Bug 29869: (QA follow-up) import t::lib::Mocks for Hold.t for mock_preference Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 18:52:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 17:52:26 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129508&action=edit Bug 29886: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 18:52:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 17:52:51 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129509&action=edit Bug 29886: Add Koha::Suggestions->search_limited Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 18:53:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 17:53:28 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |nick at bywatersolutions.com Assignee|jonathan.druart+koha at gmail. |tomascohen at gmail.com |com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:09:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:09:00 +0000 Subject: [Koha-bugs] [Bug 29888] New: ->search_limited logic breaks searches Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29888 Bug ID: 29888 Summary: ->search_limited logic breaks searches Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org When writing unit tests for bug 29886, in which I was moving bug 23991 addtion of Koha::Suggestions->search_limited I noticed a problem with how the query is amended to deal with limitations: instead of relying on chained searches, it tries (badly) to tweak the passed parameters. This line was disturbing to me: $params->{branchcode} = { -or => [ $userenv->{branch}, '' ] }; it means any query on branchcode will be overwritten! (another bug could be filed to discuss that '' in there). I propose to revisit the current ->search_limited implementations, and fix them: $ git grep 'sub search_limited' Koha/ArticleRequests.pm:sub search_limited { Koha/Patron/Discharge.pm:sub search_limited { Koha/Patrons.pm:sub search_limited { Koha/Reviews.pm:sub search_limited { -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:09:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:09:23 +0000 Subject: [Koha-bugs] [Bug 29888] ->search_limited logic breaks searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29888 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29886 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:09:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:09:23 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29888 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:33:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:33:20 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #15 from Michael Hafen --- Looking at things again, only the title, rank, id and $colfield columns reach the template. All the other columns in the SELECT clause (all the GROUP_CONCATs except $colfield) could probably be dropped. Also, the $colfield column should probably be pulled out of the GROUP_CONCAT since it's also added to the GROUP BY clause. Also, grouping by biblionumber is required, because the report contains a link to the biblio record. Coming back to the question about DISTINCT. I had to look up how it works; it seems I didn't understand it completely. It works like the GROUP BY clause for all the columns in the SELECT clause. Given that it should probably be dropped for the sake of performance. I tried running the query again, with and without the DISTINCT, and there was no difference in the number or rows returned. I don't know what I was doing before, but I think the previous runs were flawed; this result makes more sense. This amounts to a big change in the patch, and the status should probably be moved back to Needs Signoff if the patch is updated. Which I think it should be at this point; I really didn't understand this report completely when I started this. So I'm going to go and work up another patch now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:37:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:37:26 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128684|0 |1 is obsolete| | --- Comment #16 from Michael Hafen --- Created attachment 129510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129510&action=edit Bug 28977: Add GROUP_CONCAT to some of the selected columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:37:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:37:40 +0000 Subject: [Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:41:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:41:01 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128072|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:41:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:41:05 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128073|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:41:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:41:08 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128074|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:41:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:41:11 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128075|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:41:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:41:14 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128071|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:41:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:41:53 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 129511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129511&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:41:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:41:58 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 129512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129512&action=edit Bug 23991: Remove SearchSuggestion tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:42:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:42:04 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 129513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129513&action=edit Bug 23991: (QA follow-up) Save some DB queries This patch makes the suggestion-related pages rely on array size instead of querying the DB each time they need to. In the case of suggestion/suggestion.pl it goes from 4 COUNT(*) to 1. To test, with KTD: 1. Run on the host machine: $ docker exec -ti koha_db_1 bash $ mysql -ppassword > SET GLOBAL general_log_file='/var/log/mysql/mycustom.log'; > SET GLOBAL log_output = 'FILE'; > SET GLOBAL general_log = 'ON'; > \q $ tail -f /var/log/mysql/mycustom.log | grep suggestions 2. Visit the different pages changed on this bug => SUCCESS: Some queries 3. Apply this patch 4. Repeat 2 => SUCCESS: Less queries! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 19:47:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 18:47:51 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #30 from Tomás Cohen Arazi --- Nick, I stripped the Koha::Suggestions->search_limited and moved to 29886. I found issues when writing unit tests for it, and they might be responsible for the problems you found. I have attached a new patchset, which is the same as before, without that. But given the fact I fixed some issues on how ->search_limited worked, it might be good if you could re-test. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 20:33:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 19:33:31 +0000 Subject: [Koha-bugs] [Bug 29889] New: Incorrect library check in patron message deletion logic Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Bug ID: 29889 Summary: Incorrect library check in patron message deletion logic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 21757 If you DON'T have AllowAllMessageDeletion enabled, message deletion is supposed to be limited by library: Staff from the same library can delete each other's messages, but not messages left by other libraries. At some point the logic around the display of the "Delete" link got changed, I think by Bug 21757. Now the check compares the branchcode of the staff member who left the message with the branchcode of the patron: patron_message.branchcode == patron.branchcode I think this is meant to compare patron_message.branchcode to the logged-in library. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 [Bug 21757] Patron detail script (moremember.pl) cleanup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 20:33:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 19:33:31 +0000 Subject: [Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29889 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 [Bug 29889] Incorrect library check in patron message deletion logic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 20:39:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 19:39:21 +0000 Subject: [Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 20:48:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 19:48:06 +0000 Subject: [Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 20:48:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 19:48:09 +0000 Subject: [Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 --- Comment #1 from Owen Leonard --- Created attachment 129514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129514&action=edit Bug 29889: Incorrect library check in patron message deletion logic This patch corrects the logic controlling whether a patron message on the circulation or patron details page has a "Delete" link. An error in the logic prevented messages from being removed by staff who should have been authorized to do so. To reproduce the bug, check that your AllowAllMessageDeletion preference is disabled. - In the staff client, check out to a patron whose home library doesn't match the library you're logged in at. - Add a message to the patron's account. - You should see no "Delete" link next to the newly-added message. - If you edit the patron so that their home library matches the library you're logged in at the delete link will appear. To test, apply the patch and follow the steps above. The delete link should aways appear if the message was left by someone logged in at the same library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 21:01:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 20:01:22 +0000 Subject: [Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 21:01:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 20:01:25 +0000 Subject: [Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128635|0 |1 is obsolete| | Attachment #128636|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 129515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129515&action=edit Bug 29719: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 21:01:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 20:01:29 +0000 Subject: [Koha-bugs] [Bug 29719] onloan dates are cleared from items when importing and overlaying In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29719 --- Comment #5 from Nick Clemens --- Created attachment 129516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129516&action=edit Bug 29719: Do not clear onloan value when not passed in MARC We blank the field to prevent users from setting it during import, but this has the affect of blanking it in the DB. This patch replaces the onloan field when not passed in to 'ModItemFromMARC' to preserve the value To test: 1 - Check an item out to a paron 2 - Export the item using Tools->Export data 3 - Stage the record for import 4 - Match on 999c and replace items 5 - Import the batch 6 - View the record and note item is checked out and Available 7 - In the DB note the onloan value is now null 8 - Check in the item 9 - Apply patch 10 - Repeat 1-5 11 - View the record and note item is checked out 12 - In the DB note the onloan value matches the due date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 21:42:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 20:42:51 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 21:43:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 20:43:02 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 23:15:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 22:15:59 +0000 Subject: [Koha-bugs] [Bug 19342] Show private list on detail page in OPAC when user is logged in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19342 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose --- *** This bug has been marked as a duplicate of bug 29621 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 23:15:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 22:15:59 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca --- Comment #8 from Caroline Cyr La Rose --- *** Bug 19342 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 23:17:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 22:17:46 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #1 from Lucas Gass --- Created attachment 129517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129517&action=edit Bug 29887: Add system preference IndependentBranchesLoggedInLibrary To test: 1. Have a user who has staff access and circulate privileges but is not a super librarian 2. Apply the patches and run updatedatabase.pl 3. From a superlibrarian account enable IndependentBranches and IndependentBranchesLoggedInLibrary set to Yes. 4. Also turn on the system preference 'CircSidebar' 5. Prepare to login as the non-superlibrarian user. Before logging on notice on auth.tt there is no dropdown allowing you to choose a branch. 6. Log in as the non-superlibrarian. 7. In the top left hand corner notice you are logged in under that users homebranch. 8. Click the dropdown, there is no link for 'Set library'. 9. Go to circulation-home.pl, there is no link for 'Set library' under the heading 'Circulation' 10. With 'CircSidebar' turned on look at the left navigation bar on some of the circulation pages ( Holds queue, Holds to pull, Holds awaiting pickup ). There should be no 'Set library' link on any of these pages. 11. Direct your browser to /cgi-bin/koha/circ/set-library.pl and notice there is no option to change your logged in branch 12. From a superlibrarian account, Turn off IndependentBranches but leave IndependentBranchesLoggedInLibrary set to Yes. 13. Repeat steps 5-11. Nothing should change, the non-superlibrarian should still see no 'Set library' links. 14. From a superlibrarian account, Turn on IndependentBranches and IndependentBranchesLoggedInLibrary set to No 15. Going through steps 5-11 again the non-superlibrarian should see all of the 'Set library' links and be able to successfully switch branches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 23:34:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 22:34:48 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #2 from Lucas Gass --- Created attachment 129518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129518&action=edit Bug 29887: database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 23:44:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 22:44:06 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 14 23:46:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Jan 2022 22:46:44 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 01:25:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 00:25:46 +0000 Subject: [Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 01:47:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 00:47:16 +0000 Subject: [Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 --- Comment #2 from Tomás Cohen Arazi --- What is it used for? Test::DBIx::Class? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 03:17:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 02:17:45 +0000 Subject: [Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 --- Comment #3 from Mason James --- (In reply to Tomás Cohen Arazi from comment #2) > What is it used for? Test::DBIx::Class? i think its only used for the ./misc/cronjobs/create_koc_db.pl file, see BZ-4269 create_koc_db.pl can use both sqlite2 and sqlite3, so no upgrade problem to deb12 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 04:59:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 03:59:54 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #6 from Eugene Espinoza --- Before signing this one off, just want to post my observation. Regarding "There should be an expanded tree menu at the top of the authority" means I am in the details page of the authority record. Because after searching for an authority record, I am presented with search results and when I go to the details page (/cgi-bin/koha/opac-authoritiesdetail.pl), that's the time I see a tree-like structure in the authorities. When I inspect the element for it, I see class "jstree-icon jstree-ocl" screenshot here: https://issuances-library.senate.gov.ph/sites/default/files/2022-01/jstree_screenshot.png. I can confirm that this is also present in MARC view as well as in the Administration panel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 05:35:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 04:35:52 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #30 from Fridolin Somers --- Does not apply. Is first patch obsolete ? Applying only patch with "Bug 20390: ..." does not work eather. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 06:18:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 05:18:44 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 06:32:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 05:32:09 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #27 from Jonathan Druart --- > C4::Reserves::_FixPriority({ biblionumber => $self->biblionumber }); Calling a C4 method from Koha is bad. Calling a private method from outside the module is very bad. Calling a private C4 method from Koha is very very bad... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 06:41:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 05:41:17 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #413 from Fridolin Somers --- Arf, this is somehow linked to other feature in development : Bug 24857 - Add ability to group items for records Bug 24023 - Add ability to create bundles of items Bug 28854 - [ALTERNATIVE] Add ability to create bundles of items We should think on how not put too much complexity in the system (already really complex). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 06:43:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 05:43:26 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 --- Comment #462 from Fridolin Somers --- What a complex situation. This also linked to Bug 15516 - Allow to place a hold on first available item from a group of titles And maybe a bit to Bug 15565 - Place multiple item-level holds at once for the same record Holds system is already really complex, we must be careful what we add in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 07:46:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 06:46:16 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 --- Comment #8 from Fridolin Somers --- Hi, This is a very strange feature in UNIMARC XSLT that aim to look for several $9 in authority fields. We should remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 07:50:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 06:50:20 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #7 from Fridolin Somers --- (In reply to Lucas Gass from comment #6) > I see the button does include a title attribute of 'Search' which is good > but does that cover all accessibility cases? Should this not also include an > aria-label for screen readers and mobile devices? Ah sure. I didn't knew about this. I see we use a lot aria-label="Breadcrumb" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 07:54:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 06:54:21 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 07:54:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 06:54:25 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #8 from Fridolin Somers --- Created attachment 129519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129519&action=edit Bug 29066: (follow-up) add aria-label -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 08:01:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 07:01:52 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 --- Comment #37 from Fridolin Somers --- (In reply to Thibaud Guillot from comment #35) > Thanks for the review Fridolin Your welcome ;) Please add a nice text in "Text to go in the release notes" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 08:24:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 07:24:34 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #811 from Fridolin Somers --- Sure, I'm in. At first look code looks pretty mature. I'll listen to QA team. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 11:33:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 10:33:00 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 --- Comment #9 from Rafael Antonio --- Use of $9 is very important for searching using Thesaurus (authority records). May be we need to review XSLT but if Vearnis fix works we can wait for next release we open to be solved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 12:38:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 11:38:21 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #28 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #27) > > C4::Reserves::_FixPriority({ biblionumber => $self->biblionumber }); > > > Calling a C4 method from Koha is bad. Calling a private method from outside > the module is very bad. Calling a private C4 method from Koha is very very > bad... I copied what was done in ->cancel. Moving _FixPriority to Koha::* is a good thing to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 14:00:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 13:00:50 +0000 Subject: [Koha-bugs] [Bug 20615] Add the link of number of times the authority are used in edit mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|add the link of number of |Add the link of number of |times the authority are |times the authority are |used in edit mode |used in edit mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 14:05:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 13:05:47 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 --- Comment #12 from Katrin Fischer --- (In reply to AspenCat Team from comment #11) > Since this works - YAY, could this be applied to batch item modification > (such as changing a captured group in the call number and changing it to > upper case)? I tried in sandbox after patch applied and did not work, should > it have? Best to file a separate bug for this if there isn't one yet. They can be linked using 'see also'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 14:14:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 13:14:12 +0000 Subject: [Koha-bugs] [Bug 29890] New: Unprivileged route to bib records needs check on OpacSuppression Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 Bug ID: 29890 Summary: Unprivileged route to bib records needs check on OpacSuppression Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: tomascohen at gmail.com Depends on: 24909 Filed because of David's comment on bug 24909: The unprivileged route for bibliographic records needs to take OpacSuppression into account. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909 [Bug 24909] Add unprivileged route to get a bibliographic record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 14:14:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 13:14:12 +0000 Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29890 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 14:23:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 13:23:37 +0000 Subject: [Koha-bugs] [Bug 29891] New: Add Koha::Holds->fix_priorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29891 Bug ID: 29891 Summary: Add Koha::Holds->fix_priorities Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The method should explode if the resultset doesn't belong to the same biblio. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 14:23:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 13:23:59 +0000 Subject: [Koha-bugs] [Bug 29891] Add Koha::Holds->fix_priorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29891 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fill -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 14:23:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 13:23:59 +0000 Subject: [Koha-bugs] [Bug 29869] Add Koha::Hold->fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29891 [Bug 29891] Add Koha::Holds->fix_priorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 15:55:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 14:55:52 +0000 Subject: [Koha-bugs] [Bug 23450] Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 15 15:55:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Jan 2022 14:55:55 +0000 Subject: [Koha-bugs] [Bug 23450] Display issue and subscription price for each issue in subscription tab of /catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23450 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129128|0 |1 is obsolete| | --- Comment #5 from Samu Heiskanen --- Created attachment 129520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129520&action=edit Bug 23450: Display serial and subscription price in biblio detail page The 'Subscription' tab should display: - Total subscription price (based on what's set in the linked order) - Serial price based on what's set in the 952$g (items.price) Test plan: 1. Create a subscription - Tick the 'Create an item record when receiving this serial' radiobutton 2. Create an order, linking it to a subscription, set: - Quantity: 2 - Vendor price: 3 3. Receive the serial 4. Set the 952$g (normal purchase price) as 5 5. Visit the biblio detail page 6. View the 'Subscription' tab and confirm that: 'Total subscription cost is: 6.00' 'Issue price' in the table is 5.00 Sponsored-By: Brimbank Library, Australia Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 16 21:11:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Jan 2022 20:11:05 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date and availability in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #21 from Aleisha Amohia --- Looks like this was signed off so will adjust status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 16 21:47:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Jan 2022 20:47:30 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #812 from Aleisha Amohia --- I started rewriting before Christmas but couldn't get it sorted in time. Will try to pick up again this week or next. Trying to work out the best way to split everything out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 16 23:47:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Jan 2022 22:47:55 +0000 Subject: [Koha-bugs] [Bug 29881] libdbd-sqlite2-perl is unavailable on deb12 (koha-common won't install) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|libdbd-sqlite2-perl is |libdbd-sqlite2-perl is |unavailable on deb12 |unavailable on deb12 |(koha-common wont install) |(koha-common won't install) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 16 23:49:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Jan 2022 22:49:15 +0000 Subject: [Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer --- (In reply to Katrin Fischer from comment #3) > Hi Joubu, I am not sure that fixes the problem. > > The problem is translations again, because if there is no default entry, the > entry won't show in the list at all. This will just force you to enter a > default text. > > I think it should work without, in case you want to add content only for a > specific language, as you could do that with news before too. Can you please have another look? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 01:04:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 00:04:39 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|libdbd-sqlite2-perl is |Remove SQLite2 dependency |unavailable on deb12 | |(koha-common won't install) | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 01:23:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 00:23:22 +0000 Subject: [Koha-bugs] [Bug 28926] Update cpanfile for Mojolicious::Plugin::OpenAPI v2.16 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28926 --- Comment #12 from wainuiwitikapark at catalyst.net.nz --- I will wait until this is pushed to 20.11.x to backport it to 19.11.x.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 03:08:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 02:08:57 +0000 Subject: [Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Thanks, Katrin. I'm a bit overwhelmed by all the different places that need to take into account things like OpacSuppression and OpacHideItems... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 03:57:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 02:57:34 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 04:39:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 03:39:28 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 04:46:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 03:46:04 +0000 Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #39 from David Cook --- (In reply to Martin Renvoize from comment #38) > it turns out I've been spelling facultative wrong my entire life.. lol. I had the same realization a few months ago haha. I never say it in English (I just say optional) but in French I would say/spell it as faculative too haha. Do people use the word "facultative" much in the UK? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 05:47:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 04:47:41 +0000 Subject: [Koha-bugs] [Bug 29892] New: Why Should I Visit Cash.app/Help For Fetching The Right Guidance? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29892 Bug ID: 29892 Summary: Why Should I Visit Cash.app/Help For Fetching The Right Guidance? Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: re0664059 at gmail.com QA Contact: testopia at bugs.koha-community.org Cash.app/Help is a page of Cash App help section where your problems can be sorted out as it comes up with the right troubleshooting measures and solutions to tackle your hurdles and loopholes down with optimum ease. For more updates and assistance, you have to take help by contacting Cash App support geeks. https://www.techjaadu.com/cash-app-support-number/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 08:14:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 07:14:38 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #813 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #812) > I started rewriting before Christmas but couldn't get it sorted in time. > Will try to pick up again this week or next. Trying to work out the best way > to split everything out. Thanks for responding. In order to prevent misunderstandings, are you talking about the current patches or development on top of this patch set? If you are talking about the current set, it would be useless for us to work further on it when you will be rewriting it. Please confirm! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 08:19:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 07:19:54 +0000 Subject: [Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 08:20:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 07:20:13 +0000 Subject: [Koha-bugs] [Bug 29516] Remove dependency on IO::Scalar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29516 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nugged at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 08:31:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 07:31:57 +0000 Subject: [Koha-bugs] [Bug 29892] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29892 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Why Should I Visit |SPAM |Cash.app/Help For Fetching | |The Right Guidance? | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 08:51:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 07:51:33 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #60 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #58) > > [2] The randomizer (which we should not use) depends on Math::Random::MT. > > This module says: This algorithm has a very uniform distribution and is good > > for modelling purposes but do not use it for cryptography. > > As long as we pass our own stronger secrets, no worries. See [1]. > > Sorry, you lost me here. Which randomizer module? See Auth::GoogleAuth: use Math::Random::MT 'rand'; sub generate_secret32 [...] return $self->secret32( join( '', @chars[ map { rand( scalar(@chars) ) } 1 .. 16 ] ) ); Please reread earlier comment. > > [3] Martin refers earlier to Authen::OATH. I follow him there, but no > > blocker. > > Why? Did you see my answer on comment 23? > On the other hand if we do not longer use the QR code generator from > Auth::GoogleAuth there is no bad reason to not switch. But what are your > good reasons to switch then? :) Martin mentions them already. I could only add: the fact that it potentially exposes the secret in a GET parameter, could be reason enough? > > [5] This one I did not yet fully tackle. But I have the impression that we > > have an issue in C4/Auth now. A few times already I had to login twice. > > This MIGHT be a blocker. Needs still investigation. > > Hum, I didn't experience it. I will be testing it still a bit. Will report later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 08:55:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 07:55:00 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #61 from Marcel de Rooy --- -my $secret = Koha::AuthUtils::generate_salt( 'weak', 16 ); -my $auth = Koha::Auth::TwoFactorAuth->new( - { patron => $patron, secret => $secret } ); +my $auth = Koha::Auth::TwoFactorAuth->new({ patron => $patron }); my $secret32 = $auth->generate_secret32; my $ok = $auth->verify($pin_code, 1, $secret32); Actually, this is not what I meant. You let the weak randomizer of Auth::GoogleAuth create a secret by calling generate_secret32. I had in mind to just remove that call. In the assumption that we pass our own secret (hopefully better) from generate_salt? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 09:03:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 08:03:30 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #62 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #58) > (In reply to Marcel de Rooy from comment #48) > > - t::lib::Dates::compare( $updated_on_got, $updated_on_expected, > > 'updated_on values matched' ); > > + t::lib::Dates::compare( > > + dt_from_string( $updated_on_got, 'rfc3339' ), > > + dt_from_string( $updated_on_expected, 'rfc3339' ), > > + 'updated_on values matched' > > + ); > > > > But what does t::lib::Dates? > > > > sub compare { > > my ( $got, $expected ) = @_; > > my $dt_got = dt_from_string($got); > > my $dt_expected = dt_from_string($expected); > > my $diff = $dt_got->epoch - $dt_expected->epoch; > > if ( abs($diff) <= 5 ) { return 0 } > > return $diff > 0 ? 1 : -1; > > } > > > > So $got en $expected should be strings, right? > > Does this actually show that we miss a parameter in sub compare, and we are > > solving it by twisting the test instead? > > Will fix on bug 29884. That seems to be a good fix, but does not fully address my comment. This compare sub runs dt_from_string on its input. So normally I would expect it to have string parameters. The patrons.t test here is doing a dt conversion already with rfc3339. (Compare calls it again.) It would be more consistent if we would pass strings to compare and possibly a type like RFC3339, ISO8601, etc. I am seeing a hardcoded <=5, could be a parameter too or at least a constant? So yes, we are leaving scope here. But compare needs attention, and this patch set triggers it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 09:03:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 08:03:53 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #63 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #57) > OK, Running the whole test suite against this now.. will report back Thanks. Any results? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 11:10:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 10:10:06 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #62 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #60) > (In reply to Jonathan Druart from comment #58) > > > > [2] The randomizer (which we should not use) depends on Math::Random::MT. > > > This module says: This algorithm has a very uniform distribution and is good > > > for modelling purposes but do not use it for cryptography. > > > As long as we pass our own stronger secrets, no worries. See [1]. > > > > Sorry, you lost me here. Which randomizer module? > > See Auth::GoogleAuth: > use Math::Random::MT 'rand'; > sub generate_secret32 > [...] > return $self->secret32( join( '', @chars[ map { rand( scalar(@chars) ) } 1 > .. 16 ] ) ); > Please reread earlier comment. Not sure this is valid, but I will provide a patch anyway. > > > [3] Martin refers earlier to Authen::OATH. I follow him there, but no > > > blocker. > > > > Why? Did you see my answer on comment 23? > > On the other hand if we do not longer use the QR code generator from > > Auth::GoogleAuth there is no bad reason to not switch. But what are your > > good reasons to switch then? :) > > Martin mentions them already. I could only add: the fact that it potentially > exposes the secret in a GET parameter, could be reason enough? I've answered Martin's concerns, they were not valid IMO. I am not willing to rewrite the base of the feature here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 11:10:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 10:10:25 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 11:10:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 10:10:41 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #63 from Jonathan Druart --- Created attachment 129521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129521&action=edit Bug 28786: Don't rely on Auth::GoogleAuth to generate the secret -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 11:12:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 10:12:35 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #64 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #62) > (In reply to Jonathan Druart from comment #58) > > (In reply to Marcel de Rooy from comment #48) > > > - t::lib::Dates::compare( $updated_on_got, $updated_on_expected, > > > 'updated_on values matched' ); > > > + t::lib::Dates::compare( > > > + dt_from_string( $updated_on_got, 'rfc3339' ), > > > + dt_from_string( $updated_on_expected, 'rfc3339' ), > > > + 'updated_on values matched' > > > + ); > > > > > > But what does t::lib::Dates? > > > > > > sub compare { > > > my ( $got, $expected ) = @_; > > > my $dt_got = dt_from_string($got); > > > my $dt_expected = dt_from_string($expected); > > > my $diff = $dt_got->epoch - $dt_expected->epoch; > > > if ( abs($diff) <= 5 ) { return 0 } > > > return $diff > 0 ? 1 : -1; > > > } > > > > > > So $got en $expected should be strings, right? > > > Does this actually show that we miss a parameter in sub compare, and we are > > > solving it by twisting the test instead? > > > > Will fix on bug 29884. > > That seems to be a good fix, but does not fully address my comment. This > compare sub runs dt_from_string on its input. So normally I would expect it > to have string parameters. The patrons.t test here is doing a dt conversion > already with rfc3339. (Compare calls it again.) It would be more consistent > if we would pass strings to compare and possibly a type like RFC3339, > ISO8601, etc. > I am seeing a hardcoded <=5, could be a parameter too or at least a constant? > So yes, we are leaving scope here. But compare needs attention, and this > patch set triggers it. It's not very nice I agree, but dt_from_string accepts DTs :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 11:13:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 10:13:49 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #65 from Jonathan Druart --- '5' doesn't need to be a parameter. It's a global parameter for Jenkins, 1 and 2 was not enough, we push it to 5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 11:20:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 10:20:57 +0000 Subject: [Koha-bugs] [Bug 29885] Add the option to customise Z39.50 searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29885 Mirjam Vantieghem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem at etf.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 11:41:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 10:41:58 +0000 Subject: [Koha-bugs] [Bug 29862] TestBuilder.t fails with ES enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 11:42:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 10:42:03 +0000 Subject: [Koha-bugs] [Bug 29862] TestBuilder.t fails with ES enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 --- Comment #1 from Jonathan Druart --- Created attachment 129522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129522&action=edit Bug 29862: Add missing txn begin/rollback in TestBuilder.t It fixes the tests when SearchEngine=ES t/db_dependent/TestBuilder.t .. 7/15 Invalid MARC field expression: l5ffglZ_upqqcwOvaiyALgXfyJw2Ot2AGRPUsiAPzSFHfd8J_hsnuQ8z75B8RKc_kyo2rFBp8BrPNwcM1FPhc01ngP01HU_Z7Rx1VHfcIcmrifYnjBDWNmYB9N5_4xEnxMH7ZhqC9b2Bz9wf9 wSEmx64x6t5xFFKX at /kohadevbox/koha/C4/Biblio.pm line 306. # Looks like you planned 12 tests but ran 6. # Failed test 'Tests for delete method' # at t/db_dependent/TestBuilder.t line 302. Can't call method "biblionumber" on an undefined value at t/db_dependent/TestBuilder.t line 281. # Looks like your test exited with 11 just after 8. Previous subtest created invalid date in the ES mappings. Test plan: Set SearchEngine=ES and run the tests, they must pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 11:42:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 10:42:21 +0000 Subject: [Koha-bugs] [Bug 29862] TestBuilder.t fails with ES enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|chris at bigballofwax.co.nz |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 12:30:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 11:30:26 +0000 Subject: [Koha-bugs] [Bug 29621] Add link for Lists on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29621 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 12:58:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 11:58:01 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 12:58:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 11:58:07 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 13:14:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 12:14:05 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 13:48:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 12:48:39 +0000 Subject: [Koha-bugs] [Bug 25317] Move translatable strings out of additem.js.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, nugged at gmail.com --- Comment #8 from Jonathan Druart --- > - You should see a note, "NOTE: Fields listed in the 'UniqueItemsFields' system preference will not be copied." Where is coming from this syspref? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 13:53:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 12:53:04 +0000 Subject: [Koha-bugs] [Bug 25317] Move translatable strings out of additem.js.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25317 --- Comment #9 from Jonathan Druart --- (In reply to Jonathan Druart from comment #8) > > - You should see a note, "NOTE: Fields listed in the 'UniqueItemsFields' > system preference will not be copied." > > Where is coming from this syspref? Ok, it's a typo "UniqueItemFields" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:21:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:21:21 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #31 from Jonathan Druart --- Created attachment 129523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129523&action=edit Bug 23991: Fix branchcode and budgetid filtering -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:22:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:22:21 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Jonathan Druart --- (In reply to Nick Clemens from comment #26) > bug 23991 - I ran the script to generate random suggesstions - I can see > them - apply patch, I don't see them > > > If I load from library link on homepage, I see them > but if i change library using pulldown I can't > > the 'all libraries' link form homepage does not work either > > > http://localhost:8081/cgi-bin/koha/suggestion/suggestion. > pl?branchcode=FFL&displayb[…]eptedby=&accepteddate_from=&accepteddate_to=&bud > getid=__ANY__ > that shows nothing > > http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?branchcode=FFL > That shows things > > > Logs show this often: > [2022/01/14 15:21:34] [WARN] Use of uninitialized value in string eq at > /kohadevbox/koha/suggestion/suggestion.pl line 113. > [2022/01/14 15:21:34] [WARN] Use of uninitialized value $v in string eq at > /kohadevbox/koha/suggestion/suggestion.pl line 115. Should be fixed with the last patch. There is certainly more to do to clean this controller and template, but prefer to not rewrite them here and focus on the SearchSuggestion move only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:36:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:36:22 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #64 from Marcel de Rooy --- Too bad that this does not work too with Microsoft Authenticator: https://social.technet.microsoft.com/Forums/en-US/17f742d7-5596-443e-ac1b-0850c393df5e/add-otpauth-protocol-support-to-microsoft-authenticator?forum=MicrosoftAuthenticatorApp Although widely used! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:37:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:37:05 +0000 Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #3 from marion.durand at biblibre.com --- Created attachment 129524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129524&action=edit Bug 28976 : MARC21 Dots from field 100 are omitted in the OPAC and staff client When there is some dot in field 100 (for example when the name have an initials at the end) the dot is omitted in the OPAC ans the staff interface. To test: 1- Find or create a record with a dot in field 100 2a- From the staff interface, search the catalog for your record. Observe that the dot is omitted 2b- From the staff interface, go to the detail page of your record. Observe that the dot is omitted 2c- Repeat step 2a and 2b from the OPAC 3- Apply the patch 4- Repeat step 2. Observe that the dot is now display on all the pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:39:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:39:48 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #5 from Jonathan Druart --- Shouldn't we fix the staff interface's behaviour instead? Considering 0 as infinite looks like a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:41:57 +0000 Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #4 from marion.durand at biblibre.com --- Created attachment 129525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129525&action=edit retab MARC21slimUtils.xsl files replace tab with 4 spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:47:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:47:07 +0000 Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |marion.durand at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:48:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:48:29 +0000 Subject: [Koha-bugs] [Bug 29893] New: ElasticSearch Config UI deletes mappings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 Bug ID: 29893 Summary: ElasticSearch Config UI deletes mappings Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: domm at plix.at When using the Elasticsearch UI /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl to edit search mappings one can quite easily delete a lot of mappings by mistake. To reproduce: * go to /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl * click on the "Authorities" Tab * You should see ~ "67 entries" * enter "Heading-Main" into the search field, you now see ~8 entries ("filtered from 67 entries" * Click "save" Button * Go again to the "Autorities" Tab * You now see ~ "8 entries" * All the other entries have been deleted! What obviously happens is that all entries that where filtered due to the search are not submitted to the backend on save. The backend now interprets the missing entries as entries that shall be deleted. And happily deleted them! This totally breaks the search index (after the next index run, or when adding single items), as (eg in the auth-index) "authtype" is no longer indexed. I currently don't have a 21.11 or later version at hand, so maybe this has already been fixed? To fix this bug we would either have to un-hide the filtered entries before submitting the form; change the backend to not deleted missing entries (which means that the delete-action would have to be implemented a bit different); something else? I guess that the first fix is easier, and would also make sense with regard to how that form works. Greetings, domm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:52:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:52:19 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 --- Comment #1 from Martin Renvoize --- Created attachment 129526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129526&action=edit Bug 29781: This patch adds a unit test for capture groups support in Koha::Items Test plan 1) Run the test prior to applying the capture groups fix, note it fails. 2) Apply the capture groups fix patch 3) Run the test again, it should now pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:52:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:52:23 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 --- Comment #2 from Martin Renvoize --- Created attachment 129527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129527&action=edit Bug 29781: Enable capture groups in batch item modification This patch adds support for regular expression capture groups in MarcModificationTemplates. We escape double quotes in the replacement string, then quote the whole string before applying the `ee` modifier to the final regex application. See https://blog.james.rcpt.to/2010/10/25/perl-search-and-replace-using-variables/ for further details. Test plan 1) Attempt to use capture groups in your regular expression based batch item modification and note it does not work. 2) Apply the patch and try again, this time the capture group should yield the expected results. 3) Run t/SimpleMARC.t and confirm the tests still pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:52:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:52:36 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:53:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:53:23 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 --- Comment #3 from Martin Renvoize --- Created attachment 129528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129528&action=edit Bug 29781: Unit test This patch adds a unit test for capture groups support in Koha::Items Test plan 1) Run the test prior to applying the capture groups fix, note it fails. 2) Apply the capture groups fix patch 3) Run the test again, it should now pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:53:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:53:26 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129527|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 129529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129529&action=edit Bug 29781: Enable capture groups in batch item modification This patch adds support for regular expression capture groups in MarcModificationTemplates. We escape double quotes in the replacement string, then quote the whole string before applying the `ee` modifier to the final regex application. See https://blog.james.rcpt.to/2010/10/25/perl-search-and-replace-using-variables/ for further details. Test plan 1) Attempt to use capture groups in your regular expression based batch item modification and note it does not work. 2) Apply the patch and try again, this time the capture group should yield the expected results. 3) Run t/SimpleMARC.t and confirm the tests still pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:53:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:53:40 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129526|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 14:58:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 13:58:01 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #65 from Marcel de Rooy --- + my $require_2FA = ( C4::Context->preference('TwoFactorAuthentication') && $type ne "OPAC" ) ? 1 : 0; Seems okay, but just intuitively had some doubts if we block too much with $type not equal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:02:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:02:41 +0000 Subject: [Koha-bugs] [Bug 29894] New: Trying to still improve Koha/Auth/TwoFactorAuth Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Bug ID: 29894 Summary: Trying to still improve Koha/Auth/TwoFactorAuth Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Follow-up report on bug 28786 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:03:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:03:09 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #66 from Marcel de Rooy --- Well, I am still seeing some things that I would like to change. But I cant justify them with our coding guidelines. So, I will probably pass QA shortly. Will add a follow-up to replace the last two patches. And experiment a bit further on bug 28984. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:03:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:03:20 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:04:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:04:06 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #67 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #60) > > > [5] This one I did not yet fully tackle. But I have the impression that we > > > have an issue in C4/Auth now. A few times already I had to login twice. > > > This MIGHT be a blocker. Needs still investigation. > > > > Hum, I didn't experience it. > > I will be testing it still a bit. Will report later. Not able to reproduce now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:10:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:10:48 +0000 Subject: [Koha-bugs] [Bug 29895] New: Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Bug ID: 29895 Summary: Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart+koha at gmail.com Reporter: nugged at gmail.com QA Contact: testopia at bugs.koha-community.org To reproduce: 1. get into basket, go find some biblio (i.e. press the "🧺 Add order" button on some biblio) and get into adding items to basket interface, smth /cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1&basketno=1&biblionumber=233 2. press [Add multiple items] button st get the next interface elements with input for the number of items and the [Add] button. 3. add a few, 2 items, by pressing the [Add] button. 4. the modal will blink and 2 items added. 5. Extra interface with "number of items to add" and [Add] button gone, only three buttons again: [Add item] [Clear] [Add multiple items] . 6. but now if to press [Add multiple items] - nothing happens. Looks like the item lost its listener or not mapped to listener when recreated (if so). It seems the issue in koha-tmpl/intranet-tmpl/prog/js/additem.js. One side observation: - if after this to press "Add item" button and add single item, then "Add multiple items" starts to work for one time again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:13:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:13:03 +0000 Subject: [Koha-bugs] [Bug 29895] Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 --- Comment #1 from Andrew Nugged --- Also there typo with quoting in the same additem.js file, notice: name=buttonAddMulti" in line 187: + '' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:15:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:15:32 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #39 from Jonathan Druart --- Created attachment 129530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129530&action=edit Bug 29043: Don't fetch items if when are not on the "Place a hold on" form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:18:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:18:36 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129530|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 129531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129531&action=edit Bug 29043: Don't fetch items if when are not on the 'Place a hold on' form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:19:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:19:05 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 --- Comment #41 from Jonathan Druart --- @ reserve/request.pl:440 @ if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold ) } }; + if ( $club_hold or $borrowernumber_hold ) { my @bibitemloop; my @available_itemtypes; @ reserve/request.pl:673 @ if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold ) } @available_itemtypes = uniq( @available_itemtypes ); - $template->param( available_itemtypes => \@available_itemtypes ); + $template->param( + bibitemloop => \@bibitemloop, + available_itemtypes => \@available_itemtypes + ); + } # existingreserves building my @reserveloop; @ reserve/request.pl:744 @ if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold ) # display infos $template->param( - bibitemloop => \@bibitemloop, itemdata_enumchron => $itemdata_enumchron, itemdata_ccode => $itemdata_ccode, date => $date, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:19:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:19:37 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:19:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:19:41 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128675|0 |1 is obsolete| | --- Comment #9 from Peter Vashchuk --- Created attachment 129532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129532&action=edit Bug 29684: fix warn about not found file js/locale_data.js To reproduce (memberentry.pl): 1) Head over to the patron details page, press edit button to open the memberentry.pl page. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:22:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:22:02 +0000 Subject: [Koha-bugs] [Bug 29895] Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:22:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:22:08 +0000 Subject: [Koha-bugs] [Bug 29895] Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 --- Comment #2 from Jonathan Druart --- Created attachment 129533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129533&action=edit Bug 29895: Fix 'add multiple items' button on neworderempty Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket It has a "visibility: hidden" we are trying to remove setting "display: inline" This is pretty ugly and certainly does not clean the code, but it's too messy and this patch fixes the problem easily. Test plan: Add a new order Click "Add multiple items", enter "2", click "Add". Confirm that you can use the "Add multiple items" again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:22:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:22:20 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick at bywatersolutions.com |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:26:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:26:46 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #68 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #66) > Well, I am still seeing some things that I would like to change. But I cant > justify them with our coding guidelines. What do you have in mind? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:26:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:26:59 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:28:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:28:52 +0000 Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick at bywatersolutions.com |jonathan.druart+koha at gmail. | |com Depends on| |29043 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:28:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:28:52 +0000 Subject: [Koha-bugs] [Bug 29043] Items are processed but not displayed on request.pl before a patron is selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 [Bug 29058] Add option to not load existing holds table automatically -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:29:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:29:02 +0000 Subject: [Koha-bugs] [Bug 29058] Add option to not load existing holds table automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29660 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 [Bug 29660] reserve/request.pl should not deal with biblioitem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:29:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:29:02 +0000 Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with biblioitem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29058 [Bug 29058] Add option to not load existing holds table automatically -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:32:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:32:08 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:32:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:32:13 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #10 from Peter Vashchuk --- Created attachment 129534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129534&action=edit Bug 29684: fix warn about not found file js/locale_data.js To reproduce (paycollect.pl): 1) Prepare or use some existing patron with outstanding fines, go to the accounting section and open page where you make payment towards all fines. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:35:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:35:40 +0000 Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 --- Comment #7 from Marcel de Rooy --- This is what we do with the API secret using Crypt::Eksblowfish::Bcrypt : $self->set( { secret => Koha::AuthUtils::hash_password( $self->{_plain_text_secret} ), client_id => $self->_generate_unused_uuid('client_id'), } Just reading a bit, it seems that AES is preferred over Blowfish. But this is theoretical and about larger texts to encrypt. Since we are only crypting a short secret here, I wonder if we should not stick to Blowfish here and use what we already have instead of yet another module? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:37:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:37:09 +0000 Subject: [Koha-bugs] [Bug 22666] When using authority records in a bibliographic record, the order of the subfields is not sent over In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22666 --- Comment #1 from marion.durand at biblibre.com --- Created attachment 129535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129535&action=edit Bug 25387: The order of authority subfield is not sent over to bibliographic record When creating an authority record there is the possibility to reorder the subfield. However this order is not sent back to the bibliographic records when using this authority in a bibliographic record. This patch make the order of subfield be sent back to bibliographic record when the autority is used. Field that are fill are sent to the begining of the bibliographic record in the same order as in the authority record. Test plan: 1- Find or create an authority record and reorder some subfield 2- Use this authority in a bibliographic record 3- Observe that the order of the subfield is not transferred from the authority record to the bibliographic record 4- Apply the patch 5- Repeat step 1 and 2 again 6- Observe that the order of the subfield is now transferred from the authority record to the bibliographic record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:37:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:37:29 +0000 Subject: [Koha-bugs] [Bug 22666] When using authority records in a bibliographic record, the order of the subfields is not sent over In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22666 marion.durand at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |marion.durand at biblibre.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:39:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:39:14 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #11 from Peter Vashchuk --- Created attachment 129536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129536&action=edit Bug 29684: add honeypot to catch other warnings in the future -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:43:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:43:50 +0000 Subject: [Koha-bugs] [Bug 28998] Encrypt borrowers.secret In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998 --- Comment #8 from Tomás Cohen Arazi --- Question: shouldn't we entirely move the 'secret' column to a separate table and add the table to a deny-list? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:47:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:47:20 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:47:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:47:26 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 --- Comment #1 from Jonathan Druart --- Created attachment 129537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129537&action=edit Bug 29893: Prevent ES mappings UI to remove hidden rows If you are editing ES mappings and you use the DataTable filtering option, the table won't contain all the mappings you have in the DB. If the form is submitted they will be removed and data will be lost! Test plan: Edit ES mappings, filter and submit the form. Confirm that the table are redrawn before the form submission which prevent data loss -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:47:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:47:44 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |unspecified Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 15:56:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 14:56:08 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:02:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:02:18 +0000 Subject: [Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:02:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:02:56 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #69 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #68) > (In reply to Marcel de Rooy from comment #66) > > Well, I am still seeing some things that I would like to change. But I cant > > justify them with our coding guidelines. > > What do you have in mind? Lets do that on the other report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:04:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:04:43 +0000 Subject: [Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #1 from Marcel de Rooy --- I was thinking about if we should pass in the patron's secret and not make it an automatic default. But decided to leave it as-is now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:05:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:05:26 +0000 Subject: [Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #2 from Marcel de Rooy --- I do like to have only a secret parameter and handle the secret/secret32 stuff inside the module only. Expirementing a bit now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:05:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:05:51 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #66 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #63) > (In reply to Martin Renvoize from comment #57) > > OK, Running the whole test suite against this now.. will report back > > Thanks. Any results? All passed, with the exception of a couple of conflict markers that were in a uncommited local file here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:05:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:05:56 +0000 Subject: [Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #3 from Marcel de Rooy --- Throw some exceptions on missing parameters. Trivial edits. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:08:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:08:22 +0000 Subject: [Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #4 from Marcel de Rooy --- Still thinking about what we do now in registering: create secret, pass it out, get it back, etc. Easy way to build the qr but not pass the secret in that process? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:08:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:08:53 +0000 Subject: [Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #5 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #4) > Still thinking about what we do now in registering: create secret, pass it > out, get it back, etc. > Easy way to build the qr but not pass the secret in that process? Obviously the secret is in the qr code. I know.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:10:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:10:01 +0000 Subject: [Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #6 from Marcel de Rooy --- Add some additional tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:23:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:23:32 +0000 Subject: [Koha-bugs] [Bug 29896] New: The datatables api wrapper is ambiguously named - OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29896 Bug ID: 29896 Summary: The datatables api wrapper is ambiguously named - OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: david at davidnind.com, dcook at prosentient.com.au, fridolin.somers at biblibre.com, jonathan.druart+koha at gmail.com, kyle at bywatersolutions.com, oleonard at myacpl.org, tomascohen at gmail.com, victor at tuxayo.net Depends on: 29408 +++ This bug was initially created as a clone of Bug #29408 +++ The dataTables Koha REST wrapper we added recently is badly named.. currently, it's the very unspecific 'api'.. we should start using a consistent naming convention for such JS wrapper functions. In bug 29397 we introduce a minimal select2 wrapper and call it kohaSelect.. I propose we take that as inspiration and rename the dataTables function from 'api' to 'kohaTable'. Thus, creating a new API driven dataTable would become: $(".selector").kohaTable(usual stuff here); Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 [Bug 29408] The datatables api wrapper is ambiguously named -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:23:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:23:32 +0000 Subject: [Koha-bugs] [Bug 29408] The datatables api wrapper is ambiguously named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29896 [Bug 29896] The datatables api wrapper is ambiguously named - OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:23:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:23:40 +0000 Subject: [Koha-bugs] [Bug 29896] The datatables api wrapper is ambiguously named - OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29896 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:29:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:29:43 +0000 Subject: [Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #7 from Marcel de Rooy --- Created attachment 129538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129538&action=edit Bug 29894: Module changes (preliminary) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:30:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:30:00 +0000 Subject: [Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:30:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:30:52 +0000 Subject: [Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 --- Comment #8 from Marcel de Rooy --- Created attachment 129539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129539&action=edit Bug 29894: First draft for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:33:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:33:09 +0000 Subject: [Koha-bugs] [Bug 29896] Sync the functionality of the datatables api wrapper on the OPAC with the Staff Client equivilent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29896 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The datatables api wrapper |Sync the functionality of |is ambiguously named - OPAC |the datatables api wrapper | |on the OPAC with the Staff | |Client equivilent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:33:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:33:27 +0000 Subject: [Koha-bugs] [Bug 29896] Sync the functionality of the datatables api wrapper on the OPAC with the Staff Client equivilent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29896 --- Comment #1 from Martin Renvoize --- Reworking this a bit.. lots of functionality is missing from the OPAC version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:46:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:46:56 +0000 Subject: [Koha-bugs] [Bug 29896] Sync the functionality of the datatables api wrapper on the OPAC with the Staff Client equivilent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29896 --- Comment #2 from Martin Renvoize --- Created attachment 129540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129540&action=edit Bug 29896: Update datatables wrapper in the OPAC This patch updates the datatables api wrapper from 'api' to 'kohaTable' to match the function of the same intention with the name in the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:48:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:48:13 +0000 Subject: [Koha-bugs] [Bug 29896] Sync the functionality of the datatables api wrapper on the OPAC with the Staff Client equivilent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29896 --- Comment #3 from Martin Renvoize --- As far as I can tell.. this wrapper function isn't actually used anywhere in the OPAC as yet.. so I'll leave it here and when we come to use it I can pick the code back up again. We need to implement the column ordering fixes, the match type fixes and the column filters fixes at some point.. assuming we need them at the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:48:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:48:47 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 --- Comment #2 from Thomas Klausner --- I can confirm that the patch provided by Jonathan fixed this bug. Meta-Question: Can / should I set the status of this bug to "signed off" or RESOLVED? Or are status changes only "allowed" for proper team members? Greetings, domm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 16:59:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 15:59:10 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 --- Comment #3 from Jonathan Druart --- Ideally you should submit the patch with your "signed-off-by" line, then switch the status to "Signed Off". https://wiki.koha-community.org/wiki/Sign_off_on_patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 17:07:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 16:07:06 +0000 Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when patrons don't have email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This add syspref to remove release notes| |overdues notification by | |email to staff if user has | |no email address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 18:11:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 17:11:52 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129423|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 129541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129541&action=edit Bug 29868: Add Koha::Old::Hold->anonymize This patch introduces a new method in Koha::Old::Hold. The method is fully covered by tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 18:12:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 17:12:16 +0000 Subject: [Koha-bugs] [Bug 29868] Add Koha::Old::Hold->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Tests passing, QA script happy.. Code all makes sense. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 18:17:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 17:17:09 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #35 from Martin Renvoize --- hmm.. 'Make Koha::Hold->cancel' claims there's nothing to apply here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 20:50:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 19:50:49 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 20:50:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 19:50:54 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129381|0 |1 is obsolete| | --- Comment #50 from Fridolin Somers --- Created attachment 129542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129542&action=edit Bug 29690: Add selenium test Run prove t/db_dependent/selenium/regressions.t on KTD with selenium Signed-off-by: Tomas Cohen Arazi Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 20:51:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 19:51:23 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129382|0 |1 is obsolete| | --- Comment #51 from Fridolin Somers --- Created attachment 129543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129543&action=edit Bug 29690: Prevent detail.pl to crash if MARCXML is invalid Bug 23846 added support for invalid MARCXML. But now page details.pl fails again with software error. This comes from several Koha::Biblio calling $self->metadata->record without eval. Test plan : 1) Create a biblio record with invalid MARCXML (see Bug 29690) In koha-testing-docker there is biblionumber=369 2) Go to page cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx 3) You see the page with a message : There is an error with this bibliographic record, the view may be degraded. Error: Invalid data, cannot decode metadata object ... Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 20:55:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 19:55:24 +0000 Subject: [Koha-bugs] [Bug 29690] Software error in details.pl when invalid MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 --- Comment #52 from Fridolin Somers --- I signoff. Test successful with koha-testing-docker. Fixed number of tests in selenium test file, from 7 to 8. Copied test plan from old patch to new main patch. Fixed typo in main patch message "if MARCXLM in invalid" Go go team :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 21:05:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 20:05:13 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #814 from Aleisha Amohia --- I am talking about the current patchset. My understanding was that as the patches currently are, they are too big and daunting to effectively test and QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 22:17:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 21:17:03 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129435|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 22:17:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 21:17:07 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129436|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 22:17:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 21:17:34 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 129544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129544&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required This patch makes cancelling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, cancelling a hold, noticing it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 17 22:17:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Jan 2022 21:17:39 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 129545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129545&action=edit Bug 29525: Make Koha::Hold->fill anonymize if required This patch makes filling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, notice it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:01:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:01:38 +0000 Subject: [Koha-bugs] [Bug 29862] TestBuilder.t fails with ES enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:42:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:42:14 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #35 from David Cook --- Note that I do not have any intention on working on this again, and I think that it might be a good idea to remove the existing implementation of Koha::RDF... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:50:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:50:37 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- What a big dirty bug ^^ A short release note would be great -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:17 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:19 +0000 Subject: [Koha-bugs] [Bug 28932] Backend overriding status_graph element causes duplicate actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28932 --- Comment #9 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:21 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:24 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #36 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:27 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:29 +0000 Subject: [Koha-bugs] [Bug 29585] "Go to field" in cataloguing alerts is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:31 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:34 +0000 Subject: [Koha-bugs] [Bug 29786] Holds to pull report shows incorrect item for item level holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29786 --- Comment #9 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:37 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:41 +0000 Subject: [Koha-bugs] [Bug 29804] Koha::Hold->is_pickup_location_valid explodes if empty list of pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29804 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:46 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 01:56:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 00:56:49 +0000 Subject: [Koha-bugs] [Bug 29808] Stock rotation fails to advance when an item is checked out from the branch that is the next stage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29808 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 07:07:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 06:07:04 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #37 from Fridolin Somers --- Arf this breaks the unit test t/db_dependent/TestBuilder.t : Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 387. not ok 507 - Testing Koha::Checkouts::ReturnClaims # Failed test 'Testing Koha::Checkouts::ReturnClaims' # at t/db_dependent/TestBuilder.t line 401. # got: '' # expected: 'Koha::Checkouts::ReturnClaim' not ok 508 - Module Koha::Checkouts::ReturnClaims should have koha_object[s]_class method if needed # Failed test 'Module Koha::Checkouts::ReturnClaims should have koha_object[s]_class method if needed' # at t/db_dependent/TestBuilder.t line 404. # got: 'Can't call method "get_from_storage" on an undefined value at t/db_dependent/TestBuilder.t line 403. # ' # expected: '' 1..508 # Looks like you failed 2 tests of 508. Can you have a look please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 07:38:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 06:38:55 +0000 Subject: [Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20846 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 07:38:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 06:38:55 +0000 Subject: [Koha-bugs] [Bug 20846] Suppressed Records Still Appear in Public Lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20846 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29890 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 07:41:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 06:41:20 +0000 Subject: [Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17921 Blocks| |24403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 07:41:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 06:41:20 +0000 Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29890 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 07:41:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 06:41:20 +0000 Subject: [Koha-bugs] [Bug 17921] Shelf Browser does not take OpacSuppression or OpacHiddenItems into consideration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29890 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 07:42:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 06:42:56 +0000 Subject: [Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24403 | --- Comment #2 from Fridolin Somers --- For OpacHideItems, create a new report depending on Bug 24403 omnibus Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 07:42:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 06:42:56 +0000 Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29890 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 07:44:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 06:44:20 +0000 Subject: [Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 --- Comment #3 from Fridolin Somers --- I hope our open-source ILS is mainly used for 100% open-data ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 07:50:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 06:50:33 +0000 Subject: [Koha-bugs] [Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers --- Using OpacSuppression is the only way to hide records without those searchengine side-effects. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 09:21:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 08:21:02 +0000 Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787 --- Comment #4 from Martin Renvoize --- This is where I was hoping bug 24631 would end up.. but not just for version.. but also name, description, compatibility etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 09:21:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 08:21:08 +0000 Subject: [Koha-bugs] [Bug 29787] Add plugin version to plugin search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29787 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24631 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 09:21:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 08:21:08 +0000 Subject: [Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29787 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 10:45:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 09:45:36 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #815 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #814) > I am talking about the current patchset. My understanding was that as the > patches currently are, they are too big and daunting to effectively test and > QA. Thanks for your quick response! We seem to have some kind of misunderstanding here. Note that I do not oppose your breaking it up but it will take you time once again. In view of the patch history I wrote earlier in comment783: "Note that I am not asking you to split it up now." So I was thinking about handling the current set and especially stressing that we would appreciate future submissions in another form. See also comment785. "We do need some coordination to get a patch of this size in." Comment789: "So we had consensus about proceeding on recalls in its current form in view of time elapsed shortly after release." So perhaps you understand now the track that I was on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 11:30:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 10:30:27 +0000 Subject: [Koha-bugs] [Bug 29897] New: Display author identifiers for researchers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Bug ID: 29897 Summary: Display author identifiers for researchers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org For research publications some information about authors could be displayed, like ORCID or SCOPUS ids with a link to the corresponding website. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 11:30:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 10:30:53 +0000 Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es, | |katrin.fischer at bsz-bw.de Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 12:03:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 11:03:40 +0000 Subject: [Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold only updates when printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 12:03:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 11:03:44 +0000 Subject: [Koha-bugs] [Bug 29103] reserves.desk_id for desk of waiting hold only updates when printing new hold slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29103 --- Comment #2 from Nicolas Legrand --- Created attachment 129546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129546&action=edit Bug 29103: Change desk when checking in a waiting reserve A check in should relocate a waiting hold under the current desk. But the current behaviour when confirming the hold is to dismiss the modal, the item is still attached to the preceding desk. This patch mimicks the print and confirm behaviour to trigger the desk change. Plan test: 1. Add some desks to you library (syspref UseCirculationDesks and Administration -> Patrons and circulation -> Circulation desks. 2. Set a desk in your session (Circulation -> Set library and desk) 3. Have some waiting hold attach to a desk (make a hold on a checked out item and return it). 4. Change your current desk. 5. Check in again the item, click on confirm. 6. Go to the item notice detail, it appears as waiting at your first desk. 7. Apply patch. 8. Check in again the item. 9. go to the item notice detail, it should appear at your current desk. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 12:41:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 11:41:36 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #38 from Martin Renvoize --- Created attachment 129547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129547&action=edit Bug 29495: (follow-up) Fix Tests Update DBIC relation types to prevent double issue creation during object build. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 12:54:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 11:54:15 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #414 from Martin Renvoize --- It's not really related to the Bundles stuff.. whilst that development does indeed allow items to be grouped.. the grouping logic is entirely distinct and it's more about the circulation of those bundled sets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:00:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:00:51 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:00:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:00:54 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129086|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 129548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129548&action=edit Bug 29809: Rename item relation accessor from itemnumber This patch renames the item relation accessor method in StockRotationItem to 'item' from 'itemnumber' to more clearly reflect that the method returns a Koha::Item object and not an itemnumber. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:00:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:00:57 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129087|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 129549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129549&action=edit Bug 29809: Update stockration tool to reflect method name change Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:01:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:01:00 +0000 Subject: [Koha-bugs] [Bug 29809] StockRotationItems->itemnumber is poorly named In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29809 --- Comment #7 from Nick Clemens --- Created attachment 129550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129550&action=edit Bug 29809: (follow-up) Update tests and rename variable Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:04:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:04:44 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #39 from Jonathan Druart --- (In reply to Martin Renvoize from comment #38) > Created attachment 129547 [details] [review] > Bug 29495: (follow-up) Fix Tests > > Update DBIC relation types to prevent double issue creation during > object build. Don't push that right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:13:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:13:32 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:13:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:13:35 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129482|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 129551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129551&action=edit Bug 29884: Run missing test in api/v1/patrons.t compare is not calling is() or ok(), it's caller job to do it. Test plan: prove t/db_dependent/api/v1/patrons.t should still return green Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:13:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:13:59 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Assignee|chris at bigballofwax.co.nz |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:14:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:14:15 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Marcel de Rooy --- Trivial. SO+QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:18:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:18:26 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:18:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:18:30 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129391|0 |1 is obsolete| | --- Comment #67 from Marcel de Rooy --- Created attachment 129552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129552&action=edit Bug 29403: Unit tests Add a unit test for proper iso date handling Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:18:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:18:34 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129392|0 |1 is obsolete| | --- Comment #68 from Marcel de Rooy --- Created attachment 129553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129553&action=edit Bug 29403: Match the whole string This patch wraps the constructed regex such that we expect the entire regex to match and don't allow leading or trailing garbage. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:18:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:18:38 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129486|0 |1 is obsolete| | --- Comment #69 from Marcel de Rooy --- Created attachment 129554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129554&action=edit Bug 29403: Fix api/v1/patrons.t t::lib::Dates::compare expects either correct DateTime objects, or a system formatted datetime strings to be passed.. but as we're testing the API, we are consistently using RFC3339 strings for date-times and ISO8601 strings for dates. We need to therefore pre-process the strings into DateTime objects for the comparison. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:18:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:18:42 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129487|0 |1 is obsolete| | --- Comment #70 from Marcel de Rooy --- Created attachment 129555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129555&action=edit Bug 29403: Fix unit test for bug 29718 Including a 'T' is actually valid for ISO date format, I was being naughty and writing the test to follow our code rather than writing the test to conform to the ISO spec first time around. Now we are properly supporting 'T' in ISO dates with bug 29718, we need to update the test here to properly reflect an invalid ISO date string. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy The commit message is misleading here. Look at the Z in the code changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:18:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:18:46 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129488|0 |1 is obsolete| | --- Comment #71 from Marcel de Rooy --- Created attachment 129556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129556&action=edit Bug 29403: (QA follow-up) Add comments why test should fail Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:20:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:20:18 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #72 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #65) > '5' doesn't need to be a parameter. It's a global parameter for Jenkins, 1 > and 2 was not enough, we push it to 5. Please cite me completely :) "Or a constant"? No big deal, but having this as a constant is surely better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:20:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:20:51 +0000 Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more data than expected for the format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 --- Comment #73 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #66) > (In reply to Marcel de Rooy from comment #63) > > (In reply to Martin Renvoize from comment #57) > > > OK, Running the whole test suite against this now.. will report back > > > > Thanks. Any results? > > All passed, with the exception of a couple of conflict markers that were in > a uncommited local file here. Great. Confident enough to pass qa in view of responses etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:40:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:40:21 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #70 from Marcel de Rooy --- While still thinking a bit about the secret going back and forth, I discovered a tiny but serious thing overlooked: the check of the CSRF token in the return. Will add it on a follow-up too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:41:57 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #7 from Eugene Espinoza --- Signing this one off, patch too large to be attached from the sandbox. Tested it and I can see tree-like structure as discussed in test plan and upon reading jstree plugin and also as observed and described in Comment #6. Thanks oleonard! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:53:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:53:04 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #71 from Marcel de Rooy --- Hmm Koha::Token was missing too in use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:57:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:57:14 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:57:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:57:19 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123397|0 |1 is obsolete| | --- Comment #72 from Marcel de Rooy --- Created attachment 129557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129557&action=edit Bug 28786: Add new syspref TwoFactorAuthentication Sponsored-by: Orex Digital Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:57:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:57:24 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123398|0 |1 is obsolete| | --- Comment #73 from Marcel de Rooy --- Created attachment 129558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129558&action=edit Bug 28786: Add new DB column borrowers.secret Sponsored-by: Orex Digital Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:57:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:57:29 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123399|0 |1 is obsolete| | --- Comment #74 from Marcel de Rooy --- Created attachment 129559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129559&action=edit Bug 28786: Add new DB column borrowers.auth_method Sponsored-by: Orex Digital Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:57:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:57:33 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123400|0 |1 is obsolete| | --- Comment #75 from Marcel de Rooy --- Created attachment 129560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129560&action=edit Bug 28786: Add controller script and template Sponsored-by: Orex Digital Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:57:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:57:39 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124844|0 |1 is obsolete| | --- Comment #76 from Marcel de Rooy --- Created attachment 129561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129561&action=edit Bug 28786: Two-factor authentication for staff client - TOTP This patchset introduces the Two-factor authentication (2FA) idea in Koha. It is far for complete, and only implement one way of doing it, but at least it's a first step. The idea here is to offer the librarian user the ability to enable/disable 2FA when logging in to Koha. It will use time-based, one-time passwords (TOTP) as the second factor, an application to handle that will be required. https://en.wikipedia.org/wiki/Time-based_One-Time_Password More developements are possible on top of this: * Send a notice (sms or email) with the code * Force 2FA for librarians * Implementation for OPAC * WebAuthn, FIDO2, etc. - https://fidoalliance.org/category/intro-fido/ Test plan: 0. a. % apt install -y libauth-googleauth-perl && updatedatabase && restart_all b. To test this you will need an app to generate the TOTP token, you can use FreeOTP that is open source and easy to use. 1. Turn on TwoFactorAuthentication 2. Go to your account, click 'More' > 'Manage Two-Factor authentication' 3. Click Enable, scan the QR code with the app, insert the pin code and register 4. Your account now requires 2FA to login! 5. Notice that you can browse until you logout 6. Logout 7. Enter the credential and the pincode provided by the app 8. Logout 9. Enter the credential, no pincode 10. Confirm that you are stuck on the second auth form (ie. you cannot access other Koha pages) 11. Click logout => First login form 12. Enter the credential and the pincode provided by the app Sponsored-by: Orex Digital Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:57:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:57:44 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124845|0 |1 is obsolete| | --- Comment #77 from Marcel de Rooy --- Created attachment 129562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129562&action=edit Bug 28786: Improve readability in C4::Auth::checkauth Sponsored-by: Orex Digital Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:57:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:57:49 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124846|0 |1 is obsolete| | --- Comment #78 from Marcel de Rooy --- Created attachment 129563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129563&action=edit Bug 28786: Correctly inherit from Auth::GoogleAuth Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:57:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:57:54 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124847|0 |1 is obsolete| | --- Comment #79 from Marcel de Rooy --- Created attachment 129564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129564&action=edit Bug 28786: Add tests for checkauth Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:57:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:57:58 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128841|0 |1 is obsolete| | --- Comment #80 from Marcel de Rooy --- Created attachment 129565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129565&action=edit Bug 28786: DO NOT PUSH - DBIx schema changes Added for testing purposes. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:58:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:58:03 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128842|0 |1 is obsolete| | --- Comment #81 from Marcel de Rooy --- Created attachment 129566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129566&action=edit Bug 28786: (QA follow-up) Upgrade atomicupdate to new style Test plan: Run dbrev again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:58:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:58:07 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129384|0 |1 is obsolete| | --- Comment #82 from Marcel de Rooy --- Created attachment 129567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129567&action=edit Bug 28786: (QA follow-up) Fix qa warnings FAIL members/two_factor_auth.pl FAIL file permissions File must have the exec flag FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/two_factor_auth.tt FAIL filters missing_filter at line 42 (

Account: [% issuer %]

) missing_filter at line 43 (

Key: [% key_id %]

) missing_filter at line 54 ( ) missing_filter at line 58 ( ) FAIL Koha/Auth/TwoFactorAuth.pm FAIL pod coverage POD is missing for 'new' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:58:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:58:12 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #83 from Marcel de Rooy --- Created attachment 129568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129568&action=edit Bug 28786: (QA follow-up) Do not call generate_secret32 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:58:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:58:16 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #84 from Marcel de Rooy --- Created attachment 129569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129569&action=edit Bug 28786: (QA follow-up) Check the returned CSRF token We're doing this in the registering stage and at disabling. Test plan: Ënable two-factor auth but logout/login on another tab. You should get the Wrong CSRF token when submitting. Do similar thing while disabling. Verify that you can register / disable when in the same session. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:58:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:58:54 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129474|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 13:59:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 12:59:10 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129521|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 14:04:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 13:04:29 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #85 from Marcel de Rooy --- Great! We have a base for 2FA in staff herewith. Imo we could push this while keeping in mind that several follow-up reports are in the pipeline including encrypting the secret, not exposing the secret via a Google Charts URL, and others. Early push will make us aware of problems in connection to changes in C4/Auth done here. Note: The secret being passed in again has the protection of the CSRF token. It would be nice however to discuss the expiry time of these tokens. We have 8 hours still. Should we be more strict? Open a new report and propose something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 14:04:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 13:04:32 +0000 Subject: [Koha-bugs] [Bug 29482] Terminology: This item belongs to another branch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 14:04:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 13:04:35 +0000 Subject: [Koha-bugs] [Bug 29482] Terminology: This item belongs to another branch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 --- Comment #1 from Owen Leonard --- Created attachment 129570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129570&action=edit Bug 29482: Replace the term branch with library This patch replaces the word "branch" with the word "library" in the self-checkout template, as per terminology guidelines. To test, apply the patch and go to Administration -> System preferences. - Set the "IndependentBranches" preference to "Yes." - Log into the self checkout system using a staff user with permission to do self-checkout but not superlibrarian status. - Try to check out an item which belongs to a library that's different to the one you're logged in with. - You should see a message, "Item cannot be checked out," including the text "This item belongs to another library." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 14:18:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 13:18:10 +0000 Subject: [Koha-bugs] [Bug 11873] Upgrade jstree jQuery plugin to the latest version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 14:32:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 13:32:03 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 14:35:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 13:35:52 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 --- Comment #4 from Thomas Klausner --- Created attachment 129571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129571&action=edit sign-off Sign-off for the patch, after applying it the bug is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 14:36:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 13:36:24 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 Thomas Klausner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 14:39:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 13:39:34 +0000 Subject: [Koha-bugs] [Bug 29893] ElasticSearch Config UI deletes mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29893 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129537|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 14:58:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 13:58:14 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 --- Comment #5 from Andrew Fuerste-Henry --- A quick hypothetical example using this to find call numbers that don't have volume and copy numbers in the correct order. To test: 1: have 2 items with these call numbers: - KF 123 .A987 c. 11 v. 22 - KF 123 .A987 v. 3 c. 1 2: put those items in item batch mod 3: do a regex substitution on call number: - s/(^[A-Z]+ \d+\b)\s+(\.[A-Z]+\d+\b)\s+(c\.\s\d+\b)\s+(v\.\s\d+\b)/$1 $2 $4 $3/ 4: Observe your call numbers are now: - KF 123 .A987 v. 22 c.11 - KF 123 .A987 v. 3 c. 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 15:06:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 14:06:33 +0000 Subject: [Koha-bugs] [Bug 23873] Allow marc modification templates to use capturing groups in substitutions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23873 --- Comment #13 from Andrew Fuerste-Henry --- (In reply to AspenCat Team from comment #11) > Since this works - YAY, could this be applied to batch item modification > (such as changing a captured group in the call number and changing it to > upper case)? I tried in sandbox after patch applied and did not work, should > it have? Good news! There'a already a separate bug for this. I just signed it off: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 15:27:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 14:27:59 +0000 Subject: [Koha-bugs] [Bug 29895] Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 15:28:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 14:28:02 +0000 Subject: [Koha-bugs] [Bug 29895] Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29895 Samu Heiskanen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129533|0 |1 is obsolete| | --- Comment #3 from Samu Heiskanen --- Created attachment 129572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129572&action=edit Bug 29895: Fix 'add multiple items' button on neworderempty Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket It has a "visibility: hidden" we are trying to remove setting "display: inline" This is pretty ugly and certainly does not clean the code, but it's too messy and this patch fixes the problem easily. Test plan: Add a new order Click "Add multiple items", enter "2", click "Add". Confirm that you can use the "Add multiple items" again. Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 15:34:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 14:34:44 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #86 from Jonathan Druart --- (In reply to Jonathan Druart from comment #63) > Created attachment 129521 [details] [review] > Bug 28786: Don't rely on Auth::GoogleAuth to generate the secret Marcel, apparently you removed this change but it was needed IMO. Passing secret to the constructor is useless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 15:50:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 14:50:38 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 15:50:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 14:50:42 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129528|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 129573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129573&action=edit Bug 29781: Unit test This patch adds a unit test for capture groups support in Koha::Items Test plan 1) Run the test prior to applying the capture groups fix, note it fails. 2) Apply the capture groups fix patch 3) Run the test again, it should now pass Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 15:50:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 14:50:45 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129529|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 129574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129574&action=edit Bug 29781: Enable capture groups in batch item modification This patch adds support for regular expression capture groups in MarcModificationTemplates. We escape double quotes in the replacement string, then quote the whole string before applying the `ee` modifier to the final regex application. See https://blog.james.rcpt.to/2010/10/25/perl-search-and-replace-using-variables/ for further details. Test plan 1) Attempt to use capture groups in your regular expression based batch item modification and note it does not work. 2) Apply the patch and try again, this time the capture group should yield the expected results. 3) Run t/SimpleMARC.t and confirm the tests still pass. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 15:57:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 14:57:14 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #87 from Marcel de Rooy --- Yes, I replaced that patch. - my $secret32 = $auth->generate_secret32; + my $secret32 = encode_base32(Koha::AuthUtils::generate_salt("strong", 32)); Base32 encoding is done by the module. You should not use strong in the AuthUtils call! It is too STRONG. Note: if( $strength eq "strong" ){ $source = '/dev/random'; # blocking You dont want it to block on a VM or so when there is not enough randomness/entropy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 15:57:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 14:57:17 +0000 Subject: [Koha-bugs] [Bug 29898] New: Overdues.pm line 663, Use of uninitialized value in string eq Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29898 Bug ID: 29898 Summary: Overdues.pm line 663, Use of uninitialized value in string eq Change sponsored?: --- Product: Koha Version: 20.11 Hardware: PC OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: elias.dehler at thulb.uni-jena.de QA Contact: testopia at bugs.koha-community.org After migrating 37 instances from v19.11 to v20.11.13 the /etc/cron.daily/koha-common logs the following on 7 instances: "Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Overdues.pm line 663." We've checked the settings across the instances and the database. We can't find the root of this warning/error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 15:59:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 14:59:23 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #88 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #86) > Passing > secret to the constructor is useless. Please look at the changes in my generate_secret32 patch. You need to pass the secret, but it is just a Class::Accessor. It will only do something when you call the other methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:01:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:01:49 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #40 from Jonathan Druart --- Created attachment 129575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129575&action=edit Bug 29495: Fix TestBuilder.t Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 387. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:02:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:02:18 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #89 from Marcel de Rooy --- my $auth = Koha::Auth::TwoFactorAuth->new( { patron => $logged_in_user, secret => $secret } ); - my $secret32 = $auth->generate_secret32; my $qr_code_url = - $auth->qr_code( $secret32, $auth->key_id, $auth->issuer, ); + $auth->qr_code( undef, $auth->key_id, $auth->issuer ); # no need to pass secret32 Do note that this qr code call will be replaced too on 29873. Almost ready. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:02:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:02:50 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #41 from Jonathan Druart --- Martin, this patch fixes the failure and don't modify the relation. It seems better to me. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:04:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:04:06 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129402|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 129576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129576&action=edit Bug 29873: Create QR code Instead of using deprecated Google Charts API, and exposing our secret in a GET parameter, we generate QR data ourselves. Test plan: [1] Enable two factor authentication in the prefs. [2] Login in staff. Go to account. Select Manage 2FA. [3] Verify that QR code is displayed. [4] Register the QR in your authenticator app and test 2FA by logging in again. Signed-off-by: Marcel de Rooy Tested with Google Authenticator and FreeOTP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:04:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:04:10 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #5 from Marcel de Rooy --- Created attachment 129577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129577&action=edit Bug 29873: Add unit test Test plan: Run t/db_dependent/Koha/Auth/TwoFactorAuth.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:04:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:04:52 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #6 from Marcel de Rooy --- Still looking at size of QR image (but it works). And impact on Selenium test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:19:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:19:16 +0000 Subject: [Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:28:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:28:38 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- (In reply to Jonathan Druart from comment #5) > Shouldn't we fix the staff interface's behaviour instead? > Considering 0 as infinite looks like a bug. I see your point, but that would break untold numbers of Koha installs. There is long historical precedent of having zero = blank = feature is disabled. If you want to change that, it should be on a separate bug report and will need a database update and many large warnings all over the upgrade notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:31:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:31:17 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #7 from Marcel de Rooy --- Created attachment 129578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129578&action=edit Bug 29873: Adjust QR image size Size parameter 8 results in too big images. Size parameter 4 seems fine. Although I have seen variations in the number of pixels from about 116x116 to 180x180. The documentation is a bit obsure. Test plan: Register again with smaller QR code and logout/login. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:34:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:34:32 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #8 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #6) > Still looking at size of QR image (but it works). And impact on Selenium > test. t/db_dependent/selenium/authentication_2fa.t seems fine to me still. Could you check, Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:34:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:34:43 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:35:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:35:13 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129577|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 129579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129579&action=edit Bug 29873: Add unit test Test plan: Run t/db_dependent/Koha/Auth/TwoFactorAuth.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:35:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:35:17 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129578|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 129580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129580&action=edit Bug 29873: Adjust QR image size Size parameter 8 results in too big images. Size parameter 4 seems fine. Although I have seen variations in the number of pixels from about 116x116 to 180x180. The documentation is a bit obsure. Test plan: Register again with smaller QR code and logout/login. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:37:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:37:31 +0000 Subject: [Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:37:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:37:31 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:43:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:43:54 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #42 from Martin Renvoize --- Seems like a better approach to me :).. I wasn't close enough to TestBuilder to spot where I'd need to do that. Thanks Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:44:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:44:20 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129547|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:50:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:50:15 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #11 from Marcel de Rooy --- Created attachment 129581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129581&action=edit Bug 29873: Update cpanfile Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:50:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:50:58 +0000 Subject: [Koha-bugs] [Bug 29899] New: Visibility of Public Note to Patrons when Placing a Hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Bug ID: 29899 Summary: Visibility of Public Note to Patrons when Placing a Hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There are times that libraries use the public note field to say something specific about the item. This note could be useful to the patrons when they are placing an item-specific hold. For example, say a library has 3 copies of a popular DVD, they are all on the same bibliographic record. Say one of these copies includes the Director's Cut, making it slightly different and noted in the Public Note field. This is something that a patron might want to specifically place a hold on for that reason. Currently, the patron can see the public note when viewing the record and the copies, but this public note is not visible when placing a hold, so the patron doesn't know which copy to pick to get the one with the Director's Cut. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:51:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:51:26 +0000 Subject: [Koha-bugs] [Bug 29899] Visibility of Public Note to Patrons when Placing a Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |jzairo at bywatersolutions.com | |, | |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 16:56:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 15:56:35 +0000 Subject: [Koha-bugs] [Bug 29900] New: API calls should update datelastseen for API patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29900 Bug ID: 29900 Summary: API calls should update datelastseen for API patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Updating the datelastseen on API patrons when the API is called would help prevent those patrons from being accidentally batch deleted due to a lack of actual checkouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:06:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:06:02 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:06:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:06:02 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24857 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:06:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:06:19 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15565 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:06:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:06:19 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24857 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:11:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:11:39 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:12:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:12:34 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #12 from Jonathan Druart --- I would rename ->qr_dataurl with ->qr_code as it actually generates an image. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:16:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:16:20 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Amanda Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:25:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:25:25 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129575|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize --- Created attachment 129582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129582&action=edit Bug 29495: Fix TestBuilder.t Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 387. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:29:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:29:59 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127178|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 129583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129583&action=edit Bug 29385: Catch register_id for payments against fees This patch refactors the pay method in SIP FeePayment such that we consistently pass parameters to both invocations of Koha::Account->pay. It ensure the missing cash_register definition is passed when a set of account lines to pay is defined. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:34:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:34:05 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:34:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:34:45 +0000 Subject: [Koha-bugs] [Bug 29385] Add missing cash register support to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 --- Comment #6 from Martin Renvoize --- Jonathan's patch is much better.. I've replaced my own and signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:35:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:35:04 +0000 Subject: [Koha-bugs] [Bug 20502] Record URL broken, when there is more than one 856 on the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 --- Comment #19 from Jonathan Druart --- This is stuck, how do we move forward? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:41:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:41:02 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 --- Comment #13 from Jonathan Druart --- (In reply to Fridolin Somers from comment #12) > Ah QA tests fail for me : > FAIL t/db_dependent/Koha/Edifact/Order.t > FAIL spelling > segement ==> segment > segement ==> segment Critical bug stuck because of that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:42:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:42:27 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:42:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:42:32 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128419|0 |1 is obsolete| | Attachment #128420|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 129584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129584&action=edit Bug 29670: Unit tests This patch adds unit tests for Koha::Edifact::Order->order_line. We now check that the message segments are created as expected for both the 'ordering' and not 'ordering' case for acquisitions item creation time. Signed-off-by: Jonathan Field Signed-off-by: Katrin Fischer JD amended patch: spelling segement ==> segment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:42:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:42:36 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 --- Comment #15 from Jonathan Druart --- Created attachment 129585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129585&action=edit Bug 29670: Fix EDI for AcqCreateItem = 'placing on order' The AcqCreatItem at order time functionality was broken by bug 27708. This patch resolves that. Test plan. 1) Run the newly created unit tests that prove both settings work Signed-off-by: Jonathan Field Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 17:43:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 16:43:49 +0000 Subject: [Koha-bugs] [Bug 29901] New: Editing purchase suggestions create a new suggestion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29901 Bug ID: 29901 Summary: Editing purchase suggestions create a new suggestion Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: noemie.labine at collecto.ca QA Contact: testopia at bugs.koha-community.org Hi, When a purchase suggestion is created from the OPAC and then edited, the first suggestion is not edited and a new suggestion is created. To recreate : 1. Create a purchase suggestion from the OPAC 2. In the staff interface, edit the suggestion. For exemple, edit the copyright date field and save the change 3. Refresh the OPAC purchase suggestions page 4. Refresh the staff interface purchase suggestions page Results : The first suggestion with the first copyright date is still there and a new suggestion is created with the new copyright date and the same other informations (title, author, etc.) Note : I also tested with the author field and the result is the same, it's not specific to the copyright date field. I also tested on a 21.05 demo site and I have the same problem. Thank you ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 18:56:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 17:56:28 +0000 Subject: [Koha-bugs] [Bug 29899] Visibility of Public Note to Patrons when Placing a Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 18:57:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 17:57:46 +0000 Subject: [Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Visibility of Public Note |Show public note to patrons |to Patrons when Placing a |when placing a hold |Hold | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 19:09:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 18:09:54 +0000 Subject: [Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 19:09:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 18:09:57 +0000 Subject: [Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 --- Comment #1 from Owen Leonard --- Created attachment 129586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129586&action=edit Bug 29899: Show public note to patrons when placing a hold This patch adds public note to the table of information shown about items when placing a hold on a specific item in the OPAC. To test, apply the patch and check Administration -> Circulation and fine rules. You should have at least one patron category/item type configured to allow OPAC item level holds. - Modify an item to add information to the "Public note" field. - Locate that record in the OPAC and place a hold on it. - On the "Placing hold" page, click "Show more options" and "A specific item." - In the table of items you should see a "Notes" column showing the information you added to the item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 19:17:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 18:17:51 +0000 Subject: [Koha-bugs] [Bug 29902] New: While upgrading all empty deleteditems.datelastborrowed turned deleteditems.timestamp to date of upgrade Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29902 Bug ID: 29902 Summary: While upgrading all empty deleteditems.datelastborrowed turned deleteditems.timestamp to date of upgrade Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: edv at hoernergruppe.de QA Contact: testopia at bugs.koha-community.org After upgrading from 19.06 to latest we recognized in our deleted items report a wrong amount of deleted items for 2021. Digging onto the problem we found, that every dataset in deleteditems with an empty deleteditems.datelastborrowed field, caused a deleteditems.timestamp set to the actual date by overwriting the former content of the field. We got the former content back by importing additionally the old database so called "koha_library_old" and the follwing SQL request (2021-12-01 was the date of our upgrade) UPDATE koha_library.deleteditems, koha_library_old.deleteditems SET koha_library.deleteditems.timestamp = koha_library_old.deleteditems.timestamp WHERE koha_library.deleteditems.barcode = koha_library_old.deleteditems.barcode AND koha_library.deleteditems.timestamp LIKE '2021-12-01%'; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 19:21:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 18:21:31 +0000 Subject: [Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 19:21:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 18:21:34 +0000 Subject: [Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129586|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 129587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129587&action=edit Bug 29899: Show public note to patrons when placing a hold This patch adds public note to the table of information shown about items when placing a hold on a specific item in the OPAC. To test, apply the patch and check Administration -> Circulation and fine rules. You should have at least one patron category/item type configured to allow OPAC item level holds. - Modify an item to add information to the "Public note" field. - Locate that record in the OPAC and place a hold on it. - On the "Placing hold" page, click "Show more options" and "A specific item." - In the table of items you should see a "Notes" column showing the information you added to the item. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 19:46:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 18:46:03 +0000 Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need to be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |Small patch --- Comment #2 from Fridolin Somers --- Whaoo super to remove duplicated code. I'll test it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 19:46:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 18:46:47 +0000 Subject: [Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 20:04:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 19:04:44 +0000 Subject: [Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 20:04:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 19:04:48 +0000 Subject: [Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129019|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 129588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129588&action=edit Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 20:05:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 19:05:50 +0000 Subject: [Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129588|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers --- Created attachment 129589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129589&action=edit Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Also add a space character between itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 20:08:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 19:08:43 +0000 Subject: [Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 --- Comment #4 from Fridolin Somers --- > Also add a space character between itemnumbers. I tested with 2 items impossible to delete and notices that itemnumbers do not have a separator. Very small fix so I made it will signing. BTW : Do we even need this itemnumber list ? It is not clear for user that those are itemnumbers and not barcodes. We have a message for each item in "Detailed messages". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 20:15:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 19:15:46 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #44 from Fridolin Somers --- Thanks Martin and Jonathan I understand the keyword "additional_work_needed". UT is now OK : kohadev-koha at kohadevbox:/kohadevbox/koha$ prove t/db_dependent/TestBuilder.t t/db_dependent/TestBuilder.t .. ok All tests successful. Files=1, Tests=15, 42 wallclock secs ( 0.07 usr 0.01 sys + 32.63 cusr 8.45 csys = 41.16 CPU) Result: PASS Tell me if can be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 20:25:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 19:25:52 +0000 Subject: [Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldoldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 20:25:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 19:25:53 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Bug 25551 depends on bug 28632, which changed state. Bug 28632 Summary: patrons.t fragile on slow boxes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 20:25:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 19:25:53 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Bug 29884 depends on bug 28632, which changed state. Bug 28632 Summary: patrons.t fragile on slow boxes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 20:42:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 19:42:12 +0000 Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 20:51:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 19:51:58 +0000 Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement makes each release notes| |hold's expiration date | |visible on the Holds | |Awaiting Pickup page. Since | |this is the date Koha uses | |to decide when a waiting | |hold should expire and be | |cancelled, making it | |visible decreases | |confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 21:00:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 20:00:58 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #816 from Aleisha Amohia --- I see. In the email chain we had discussed reformatting but clearly there was some misunderstanding. I had started rewriting things before Christmas but it was proving to be very difficult to split the patches out into different 'stages' of development. My preference would be to rebase what is on here and bring it up to main, as long as the QA team is happy to coordinate in getting it through. Should I do that then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 21:13:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 20:13:49 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #817 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #816) > I see. In the email chain we had discussed reformatting but clearly there > was some misunderstanding. > > I had started rewriting things before Christmas but it was proving to be > very difficult to split the patches out into different 'stages' of > development. > > My preference would be to rebase what is on here and bring it up to main, as > long as the QA team is happy to coordinate in getting it through. > > Should I do that then? Yes please check my latest rebase (Jan 11). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 21:35:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 20:35:44 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 18 21:36:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 20:36:00 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 00:19:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 23:19:31 +0000 Subject: [Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #9 from Lucas Gass --- I think the follow-up is correct, the aria-label belongs on the button. Now I think the the icon needs the aria-hidden="true" attribute. In fact the QA tool thinks so too: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 169) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 282) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 00:27:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 23:27:11 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 00:27:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Jan 2022 23:27:15 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129497|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 129590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129590&action=edit Bug 17018: Split AdvancedSearchTypes for staff and OPAC This patch adds a new system preference, OpacAdvancedSearchTypes, as an OPAC-specific version of the AdvancedSearchTypes preference. Values from AdvancedSearchTypes are copied to OpacAdvancedSearchTypes so that behavior is consistent. To test, apply the patch and run the database update process. - Go to Administration -> System preferences. - Search for AdvancedSearchTypes. You should get two results, one for the OPAC preference and one for the staff interface. - Check that the OpacAdvancedSearchTypes settings match the AdvancedSearchTypes settings. - View the advanced search pages in the staff interface and OPAC to confirm that the tabs look correct. - Change the OpacAdvancedSearchTypes and AdvancedSearchTypes settings to be different and confirm that each is applied separately to each interface. - Enable the OpacTopissue system preference. - View the "Most popular" page in the OPAC. - The OpacAdvancedSearchTypes settings should be reflected in the "Refine your search" sidebar: If "Collection" is checked, a filter for collection should appear. If "Item types" is checked, a filter for item types should appear. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 02:09:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 01:09:57 +0000 Subject: [Koha-bugs] [Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 --- Comment #13 from David Cook --- (In reply to Tomás Cohen Arazi from comment #6) > We should have separate indexes for OPAC and staff interface. > Probably public_* for the OPAC. We could need some trick for when > OpacHiddenItemsExceptions is matched (i.e. it should display the full thing). This is something I've been thinking about when exporting data from Koha into other systems. OpacSuppression, OpacHiddenItems, OpacHiddenItemsExceptions... these all change behaviour without changing the actual data. With OpacSuppression it doesn't matter too much because it's just on/off, but the other 2 require potentially heavy calculations for updating an index... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 02:12:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 01:12:07 +0000 Subject: [Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 --- Comment #4 from David Cook --- (In reply to Fridolin Somers from comment #3) > I hope our open-source ILS is mainly used for 100% open-data ;) Hahahaha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 02:15:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 01:15:47 +0000 Subject: [Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 --- Comment #5 from David Cook --- (In reply to Fridolin Somers from comment #2) > For OpacHideItems, create a new report depending on Bug 24403 omnibus I don't think I have a report at the moment. I think Tomas has made progress on creating functions to handle OpacHideItems via the Koha::Biblio object, so that's good. OpacSuppression really needs an equivalent. (I think there might also be some performance limitations to the OpacHideItems calculation, but I'm probably not going to work on them...and I'd need to do some profiling to even prove that those limitations exist...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 04:18:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 03:18:11 +0000 Subject: [Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #2) > For OpacHideItems, create a new report depending on Bug 24403 omnibus https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/REST/V1/Biblios.pm#L178 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 04:26:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 03:26:00 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 04:58:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 03:58:54 +0000 Subject: [Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 --- Comment #7 from David Cook --- (In reply to Tomás Cohen Arazi from comment #6) > (In reply to Fridolin Somers from comment #2) > > For OpacHideItems, create a new report depending on Bug 24403 omnibus > > https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/ > REST/V1/Biblios.pm#L178 I've been thinking we could just extend "hidden_in_opac" to include OpacSuppression as well. That might be a better name for this bug report really... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 05:00:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 04:00:52 +0000 Subject: [Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 --- Comment #8 from David Cook --- I have wondered a bit about OpacSuppressionByIPRange with an API although I don't know how much that is used. We don't have stats on it on Hea due to the private nature of the values I think... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 07:43:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 06:43:06 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #30 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #22) > (In reply to Jonathan Druart from comment #21) > > > This one should be pushed along with bug 29390 in my opinion. > > It can go on its own. I agree, so pushing master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:20:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:20:35 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:20:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:20:37 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:20:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:20:39 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:20:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:20:41 +0000 Subject: [Koha-bugs] [Bug 29336] Some authorised_value FKs are too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #31 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:20:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:20:44 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:20:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:20:46 +0000 Subject: [Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #18 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:20:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:20:49 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:20:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:20:51 +0000 Subject: [Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #51 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:20:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:20:53 +0000 Subject: [Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:20:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:20:56 +0000 Subject: [Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:20:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:20:58 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:21:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:21:00 +0000 Subject: [Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 --- Comment #16 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:21:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:21:03 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:21:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:21:06 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:21:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:21:08 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:21:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:21:10 +0000 Subject: [Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:21:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:21:12 +0000 Subject: [Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:21:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:21:15 +0000 Subject: [Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 --- Comment #3 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:21:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:21:17 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:21:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:21:19 +0000 Subject: [Koha-bugs] [Bug 29820] Print summary just show 20 items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:21:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:21:21 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 08:21:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 07:21:23 +0000 Subject: [Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 09:33:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 08:33:40 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #45 from Jonathan Druart --- (In reply to Fridolin Somers from comment #44) > Tell me if can be pushed. Yes, it's ready for push. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 09:46:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 08:46:56 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #818 from Katrin Fischer --- I understand the difficulties of splitting it up now, so totally ok working with the rebased patch set. Thx Marcel and Aleisha for clearing things up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 10:04:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 09:04:35 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #46 from Fridolin Somers --- Pushed master : Bug 29495: Fix TestBuilder.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 10:15:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 09:15:42 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 10:15:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 09:15:45 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129461|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 129591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129591&action=edit Bug 29881: libdbd-sqlite2-perl is unavailable on deb12 (koha-common wont install) to test... - attempt to install koha-common pkg on deb12 confirm error... The following packages have unmet dependencies: koha-common : Depends: libdbd-sqlite2-perl but it is not installable - apply patch, rebuild new package - install new koha-common pkg on deb12 successfully Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:09:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:09:01 +0000 Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:12:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:12:59 +0000 Subject: [Koha-bugs] [Bug 8577] build_holds_queue.pl needs command-line options for help, verbosity, and summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8577 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger --- Looks like the code has been refactored, but there are still two FIXMEs: # FIXME: add command-line options for verbosity and summary # FIXME: expand perldoc, explain intended logic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:18:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:18:23 +0000 Subject: [Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:18:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:18:26 +0000 Subject: [Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129514|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 129592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129592&action=edit Bug 29889: Incorrect library check in patron message deletion logic This patch corrects the logic controlling whether a patron message on the circulation or patron details page has a "Delete" link. An error in the logic prevented messages from being removed by staff who should have been authorized to do so. To reproduce the bug, check that your AllowAllMessageDeletion preference is disabled. - In the staff client, check out to a patron whose home library doesn't match the library you're logged in at. - Add a message to the patron's account. - You should see no "Delete" link next to the newly-added message. - If you edit the patron so that their home library matches the library you're logged in at the delete link will appear. To test, apply the patch and follow the steps above. The delete link should aways appear if the message was left by someone logged in at the same library. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:21:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:21:24 +0000 Subject: [Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #3 from Jonathan Druart --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:21:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:21:31 +0000 Subject: [Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29903 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:23:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:23:30 +0000 Subject: [Koha-bugs] [Bug 28943] Lower the risk of accidental patron deletion by cleanup_database.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128652|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 129593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129593&action=edit Bug 28943: Lower the risk of accidental patron deletion If you do not use a temporary self registration patron category, you should actually make the preference PatronSelfRegistrationExpireTemporaryAccountsDelay empty. As the comment in sysprefs.sql already said, we should not let a zero value in the pref delete patrons too. The module is changed now, the test adjusted and the description of both related sysprefs modified. Test plan: Run t/db_dependent/Members.t Check in Administration the two adjusted OPAC pref descriptions. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:24:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:24:15 +0000 Subject: [Koha-bugs] [Bug 28943] Lower the risk of accidental patron deletion by cleanup_database.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize --- I think Marcle argues the point well and I'm inclined to agree.. As such, I've worked through and tested this. Everyone works as expected and the QA scripts and tests are all happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:24:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:24:21 +0000 Subject: [Koha-bugs] [Bug 28943] Lower the risk of accidental patron deletion by cleanup_database.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28943 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:32:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:32:11 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #166 from Emmi Takkinen --- What's the status of this bug? Is it still Failed QA or could it be changed as Needs Signoff? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:32:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:32:30 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128100|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 129595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129595&action=edit Bug 29561: Remove blank facets This patch strips the blank facets from the ES aggregations, this seems to only affect language fields currently, but could affect any facetable field that can contain blank values To test: 1 - Have Koha running Elasticsearch with standard test data, or add some records with blank values in the 008/35-37 2 - Search for 'a' 3 - Look at the language facets, they should appear normal 4 - Browse to: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=&q=a&sort_by=relevance_dsc&count=20&limit=ln: 5 - Note there is now an 'x' under the Languages facet - to remove a limit you cannot see 6 - Apply patch 7 - Reload 8 - Note the x is not there 9 - Inspect HTML, confirm no blank link under language facets Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:33:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:33:00 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Clear code, reasonable fixme for future reference.. QA scripts happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:33:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:33:57 +0000 Subject: [Koha-bugs] [Bug 29561] Remove blank facet for languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:37:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:37:33 +0000 Subject: [Koha-bugs] [Bug 29837] JS error during installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129249|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 129596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129596&action=edit Bug 29837: Remove JS error during installer Uncaught ReferenceError: _ is not defined the _() function is called from calendar.inc, but calendar.inc is included before the definition of this function in installer-intranet-bottom.inc Test plan: Confirm that the JS error is gone Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:37:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:37:53 +0000 Subject: [Koha-bugs] [Bug 29837] JS error during installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Nice work, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:49:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:49:27 +0000 Subject: [Koha-bugs] [Bug 29156] File missing warning in Koha::UploadedFile should be for permanent files only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128101|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 129597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129597&action=edit Bug 29156: File missing warning in Koha::UploadedFile for permanent files only When an uploaded file is deleted, when file does not exist there is a warning : "Removing record for file.txt within category koha_upload, but file was missing." For temporary files, this warning is noisy. For example when they are in /tmp, system reboot deleted them. I propose to remove this warning for temporary files. Test plan : 1) Upload a temporary and a permanent file via Tools > Upload 2) Delete the file on server 3) Delete the two files from Tools > Upload 4) Look at warning in log files => You see only warning for permanent file Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:49:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:49:51 +0000 Subject: [Koha-bugs] [Bug 29156] File missing warning in Koha::UploadedFile should be for permanent files only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Always good to reduce noise.. this makes sense. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:49:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:49:57 +0000 Subject: [Koha-bugs] [Bug 29156] File missing warning in Koha::UploadedFile should be for permanent files only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:54:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:54:20 +0000 Subject: [Koha-bugs] [Bug 29511] While editing MARC records, subfields appear in varying order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128856|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 129598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129598&action=edit Bug 29511: Sort hash keys This code exists in authorities/authorities.pl and the hash keys are sorted I just do the same here To test: 1 - Find/create a record with 245a 245h populated 2 - Load/reload the record several times and note that fields c and b are ordered randomly 3 - Apply patch 4 - Reload and note c and b are ordered alphabetically 5 - Move subfield h before subfield c 6 - Save and reload 7 - Confirm that existing/filled fields retain order in the MARC record Signed-off-by: Hayley Pelham Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 11:58:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 10:58:34 +0000 Subject: [Koha-bugs] [Bug 29511] While editing MARC records, subfields appear in varying order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- I'm slightly torn here.. but am going to PQA as the code works and is an improvement.. I'll let the RM make the final decision. So.. reasoning. Random hash ordering causes this, and having the keys completely randomly ordered is indeed annoying and inconsistent.. it is considerably better to have the consistent between runs. My minor issue with the alpha sort is that I though, at least some, MARC21 fields have a specified subfield order so it might be 'weird' that they're coming out alphanumerically. I can't see any easy way of doing this however.. and can't even find a definitive reference for subfield ordering of any particular fields.. just mentions in various docs saying they aren't always alpha sorted. In short.. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 12:00:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 11:00:56 +0000 Subject: [Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129589|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 129599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129599&action=edit Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Also add a space character between itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 12:02:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 11:02:00 +0000 Subject: [Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Good catch, works as described now. I agree, itemnumbers may not be the best thing to output.. but trying to output something more meaningful to the end-user may well result in gaps.. itemnumber is definitively going to be defined. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:23:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:23:57 +0000 Subject: [Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 --- Comment #30 from Jonathan Druart --- In MarkIssueReturned we crash if AnonymousPatron is not set to a valid borrowernumber. Here we are setting it to NULL. Both behaviours must be identical. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:26:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:26:53 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #38 from Jonathan Druart --- Same remarks than bug 29843 comment 30 apply here "In MarkIssueReturned we crash if AnonymousPatron is not set to a valid borrowernumber. Here we are setting it to NULL. Both behaviours must be identical." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:29:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:29:19 +0000 Subject: [Koha-bugs] [Bug 29904] New: Serials: Clear 'Automatically set to late' when changing status Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29904 Bug ID: 29904 Summary: Serials: Clear 'Automatically set to late' when changing status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Yes it takes about half a second to clear it, but wouldnt it be marvelous when Koha would do it rightaway? And if we do this a million times, we win 500.000 seconds ! 138 hours ! We could signoff so much more patches :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:33:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:33:15 +0000 Subject: [Koha-bugs] [Bug 29629] Remove two unused intranet MODS XSLT sheets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29629 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:33:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:33:20 +0000 Subject: [Koha-bugs] [Bug 29629] Remove two unused intranet MODS XSLT sheets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29629 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128203|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 129600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129600&action=edit Bug 29629: Remove two unused MODS XSLT stylesheets Follow-up of bug 29556. With thanks to Owen for checking. > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl > These two files appear to be unused. I could only find references to them in .po files. Test plan: git grep MARC21slim2MODS32 git grep MARC21slim2MODS3 Skip the misc/translator/po references. Note in the second grep that you only see that MODS3-1 is used in unapi and C4::Record. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:34:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:34:53 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart --- +
[%# FIXME Add right class, remove br %] +
Easy fixme, should be implemented here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:37:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:37:46 +0000 Subject: [Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:37:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:37:50 +0000 Subject: [Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129422|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 129601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129601&action=edit Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve This patch removes the unused method. Likely a leftover from ancient ages. AddIssue already fills the hold and is called in the Checkout.pm library. To test: 1. Run: $ git grep fill_reserve => FAIL: Notice it is only mentioned in the line that defines it 2. Apply this patch 3. Repeat 1 => SUCCESS: Removed. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:38:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:38:35 +0000 Subject: [Koha-bugs] [Bug 13963] Date picker/widget always requires to click on a day as last action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13963 --- Comment #1 from Owen Leonard --- This interaction is very different now with Flatpickr, can the bug be closed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:40:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:40:01 +0000 Subject: [Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:40:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:40:06 +0000 Subject: [Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129587|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 129602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129602&action=edit Bug 29899: Show public note to patrons when placing a hold This patch adds public note to the table of information shown about items when placing a hold on a specific item in the OPAC. To test, apply the patch and check Administration -> Circulation and fine rules. You should have at least one patron category/item type configured to allow OPAC item level holds. - Modify an item to add information to the "Public note" field. - Locate that record in the OPAC and place a hold on it. - On the "Placing hold" page, click "Show more options" and "A specific item." - In the table of items you should see a "Notes" column showing the information you added to the item. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:40:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:40:12 +0000 Subject: [Koha-bugs] [Bug 12270] Create a directory for templates shared with opac and intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12270 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Architecture, internals, | |and plumbing Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:40:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:40:31 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #90 from Jonathan Druart --- I do agree with the last comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:42:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:42:06 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- Missing POD and tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:50:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:50:33 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 --- Comment #5 from Jonathan Druart --- 113 [% IF ( news_item ) %] 114 • Show all news 115 [% END %] This is not displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:51:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:51:44 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 --- Comment #6 from Jonathan Druart --- The news is not displayed in the translated version of the interface (does not seem related to this patch however). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:55:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:55:55 +0000 Subject: [Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:55:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:55:59 +0000 Subject: [Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129431|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 129603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129603&action=edit Bug 29878: Use multiple select widget for AdvancedSearchTypes system preference This patch updates system preferences so that the AdvancedSearchTypes preference uses a multiple-select widget. This lets users select one or more checkboxes in a dropdown rather than requiring that they enter pipe-delimited text. To test, apply the patch and run updatedatabase. - Go to Administration -> System Preferences and search for 'AdvancedSearchTypes' - The input should be styled as a multiple-select widget. Test that you can select one, more, or all of the options. - Test that your selections are saved successfully and that the changes are reflected on the OPAC and staff interface advanced search pages. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:56:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:56:19 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:56:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:56:22 +0000 Subject: [Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129590|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 129604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129604&action=edit Bug 17018: Split AdvancedSearchTypes for staff and OPAC This patch adds a new system preference, OpacAdvancedSearchTypes, as an OPAC-specific version of the AdvancedSearchTypes preference. Values from AdvancedSearchTypes are copied to OpacAdvancedSearchTypes so that behavior is consistent. To test, apply the patch and run the database update process. - Go to Administration -> System preferences. - Search for AdvancedSearchTypes. You should get two results, one for the OPAC preference and one for the staff interface. - Check that the OpacAdvancedSearchTypes settings match the AdvancedSearchTypes settings. - View the advanced search pages in the staff interface and OPAC to confirm that the tabs look correct. - Change the OpacAdvancedSearchTypes and AdvancedSearchTypes settings to be different and confirm that each is applied separately to each interface. - Enable the OpacTopissue system preference. - View the "Most popular" page in the OPAC. - The OpacAdvancedSearchTypes settings should be reflected in the "Refine your search" sidebar: If "Collection" is checked, a filter for collection should appear. If "Item types" is checked, a filter for item types should appear. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 13:59:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 12:59:34 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #13 from Marcel de Rooy --- Created attachment 129605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129605&action=edit Bug 29873: (follow-up) Rename qr_dataurl As requested by a QA team member. We're moving to qr_code as method name. This is the same name as the method in the underlying base class. Apart from one sed statement, changing to self->SUPER on one line. Test plan: Can you still register, logout and login? Run t/db_dependent/Koha/Auth/TwoFactorAuth.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 14:00:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 13:00:10 +0000 Subject: [Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #14 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #12) > I would rename ->qr_dataurl with ->qr_code as it actually generates an image. Renamed. Added a few POD lines now too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 14:05:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 13:05:23 +0000 Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #15 from Jonathan Druart --- opac-reserve: date in the past can be selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 14:13:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 13:13:45 +0000 Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #4 from Jonathan Druart --- I am not sure the patch is the correct way to fix it. If no value has not been filled in, we shouldn't default. In my opinion we should better improve the way we calculate/retrieve the rules instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 14:15:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 13:15:59 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 14:16:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 13:16:03 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #10 from Marcel de Rooy --- Created attachment 129606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129606&action=edit Bug 29458: (follow-up) Remove FIXME Actually, just leaving the br tag is fine too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 14:17:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 13:17:14 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #11 from Marcel de Rooy --- Owen, could you have a look at the second patch? Would you suggest to add a class and additional css or so instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 14:40:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 13:40:50 +0000 Subject: [Koha-bugs] [Bug 26537] Search does not work when no term in value_builder/unimarc_field_4XX.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128938|0 |1 is obsolete| | --- Comment #16 from Thibaud Guillot --- Created attachment 129607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129607&action=edit Bug 26537 : (follow-up) fix paging of results Also I renamed "es_query" variable for better understanding (this script works with Elastic search but also Zebra) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 14:41:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 13:41:11 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 14:41:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 13:41:15 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127682|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 129608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129608&action=edit Bug 29486: _koha_marc_update_bib_ids no longer needed for GetMarcBiblio This subroutine is ensuring that the biblionumber and biblioitemnumber will be part of the MARC record. We should not need that, unless there is something broken somewhere else. This line has been added by the following commit: commit 4e95e94727b09b33d2f6c597bdd218a59dcc3681 Bug 6789: biblios with many items can result in broken search results link """ To this end, it also moves the fix_biblio_ids portion of get_corrected_marc_record out of rebuild_zebra.pl, and makes it a part of GetMarcBiblio (right before EmbedItemsInMarcBiblio, so the 952s still come last). fix_biblio_ids is kept as a subroutine for the deletion portion of rebuild_zebra.pl, which still uses it. """ But it does not explain why it's better to have it in GetMarcBiblio. If we need it for the reindexation process, we shouldn't impact GetMarcBiblio which is used from several different places. We might then consider adding the fix_biblio_ids call to rebuild_zebra.pl, but I am failing to understand in which cases it could be useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 14:41:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 13:41:19 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 --- Comment #6 from Jonathan Druart --- Created attachment 129609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129609&action=edit Bug 29486: Fix tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 14:41:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 13:41:23 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 --- Comment #7 from Jonathan Druart --- Created attachment 129610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129610&action=edit Bug 29486: Add check in search_for_data_inconsistencies.pl If the MARC record does not contain the correct biblionumber of biblioitemnumber, the script will display the following warning: == Bibliographic records have MARCXML without biblionumber or biblioitemnumber == * Biblionumber 4242 has '1' in 999$c * Biblionumber 4242 has biblioitemnumber '4242' but should be '1' in 999$d => The bibliographic records must have the biblionumber and biblioitemnumber in MARCXML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 15:24:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 14:24:50 +0000 Subject: [Koha-bugs] [Bug 26019] Koha should set SameSite attribute on cookies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019 --- Comment #11 from Owen Leonard --- Would it be a logical first step to explicitly set SameSite to Lax for the cookies we set without a SameSite attribute? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 15:31:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 14:31:24 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129606|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 129612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129612&action=edit Bug 29458: (follow-up) Remove FIXME With some help of Owen Leonard: Regarding the
, you can wrap the submit button in
instead. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 15:32:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 14:32:06 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #13 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #9) > +
[%# FIXME Add right class, > remove br %] > +
> > Easy fixme, should be implemented here. Fixed now with help from Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 15:44:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 14:44:05 +0000 Subject: [Koha-bugs] [Bug 29905] New: Superlibrarians should be able to delete any patron messages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29905 Bug ID: 29905 Summary: Superlibrarians should be able to delete any patron messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Superlibrarians are generally exempted from branch limits, they should be able to delete a message on a patron account left by any library regardless of AllowAllMessageDeletion syspref setting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 15:58:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 14:58:44 +0000 Subject: [Koha-bugs] [Bug 15789] New permission for fine overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15789 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- Looks like this is no longer listed on the ByWater dev funding site, which has moved: http://devs.bywatersolutions.com/# That said, I'd love to see this new permission broken out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:12:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:12:56 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #5 from Martin Renvoize --- What are the next steps here, discussion wise. I'm on board with the change myself and would happily sign off as is.. were there any particular points you wanted to raise/question Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:17:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:17:11 +0000 Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium lib is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128958|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 129615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129615&action=edit Bug 29779: Make selenium tests return green even if lib is missing Some selenium tests are not correctly written and they fail is Selenium::Remote::Driver is missing. Test plan: 1. Remove the lib rm `pmpath Selenium::Remote::Driver` 2. prove t/db_dependent/selenium/ should return green Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:17:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:17:48 +0000 Subject: [Koha-bugs] [Bug 29779] selenium/regressions.t fails if Selenium lib is not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #3 from Martin Renvoize --- All works as expected for me.. signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:40:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:40:04 +0000 Subject: [Koha-bugs] [Bug 29862] TestBuilder.t fails with ES enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129522|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 129616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129616&action=edit Bug 29862: Add missing txn begin/rollback in TestBuilder.t It fixes the tests when SearchEngine=ES t/db_dependent/TestBuilder.t .. 7/15 Invalid MARC field expression: l5ffglZ_upqqcwOvaiyALgXfyJw2Ot2AGRPUsiAPzSFHfd8J_hsnuQ8z75B8RKc_kyo2rFBp8BrPNwcM1FPhc01ngP01HU_Z7Rx1VHfcIcmrifYnjBDWNmYB9N5_4xEnxMH7ZhqC9b2Bz9wf9 wSEmx64x6t5xFFKX at /kohadevbox/koha/C4/Biblio.pm line 306. # Looks like you planned 12 tests but ran 6. # Failed test 'Tests for delete method' # at t/db_dependent/TestBuilder.t line 302. Can't call method "biblionumber" on an undefined value at t/db_dependent/TestBuilder.t line 281. # Looks like your test exited with 11 just after 8. Previous subtest created invalid date in the ES mappings. Test plan: Set SearchEngine=ES and run the tests, they must pass. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:40:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:40:24 +0000 Subject: [Koha-bugs] [Bug 29862] TestBuilder.t fails with ES enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Works for me... signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:46:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:46:39 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca --- Comment #17 from Noémie Labine --- I am currently learning how to test patches on sandboxes so maybe someone else can countercheck, but the patch seems to work fine for me ! I can edit existing values and I don't see any other problems. I'm not gonna change the status for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:46:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:46:56 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:47:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:47:00 +0000 Subject: [Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129240|0 |1 is obsolete| | Attachment #129612|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 129617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129617&action=edit Bug 29458: Reorder login elements Make masthead.inc modal and opac-auth follow the order of the login elements on the homepage. Test plan: Enable prefs for reset password and self registration. Fill additional contents for login instructions. Logout on OPAC. Click Login from your account on top bar. Click Login button on the home page (right side, in the middle). Verify that these two forms correspond with the home page login. Signed-off-by: Marcel de Rooy Signed-off-by: Fridolin Somers Bug 29458: (follow-up) Remove FIXME With some help of Owen Leonard: Regarding the
, you can wrap the submit button in
instead. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:50:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:50:17 +0000 Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need to be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128129|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 129618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129618&action=edit Bug 29609: Centralized code to build the link to a biblio detail page There are 2 prefs that control the default view of biblio detail pages: IntranetBiblioDefaultView for staff and BiblioDefaultView for OPAC. There are as well viewISBD, viewLabeledMARC and viewMARC to allow/don't allow access to those page for staff members. This code need to be in a single place to avoid discrepancy. Test plan: Play with BiblioDefaultView and IntranetBiblioDefaultView and confirm that the links of biblio point to the correct view. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:50:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:50:40 +0000 Subject: [Koha-bugs] [Bug 29609] Links to guess the biblio default view need to be centralized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Nice bit of clean up here.. signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:54:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:54:42 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Jonathan Druart --- Ready for signoff then :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 16:55:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 15:55:46 +0000 Subject: [Koha-bugs] [Bug 29906] New: When changing hold parameters over API (PUT) it forcibly gets to "suspended" state Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Bug ID: 29906 Summary: When changing hold parameters over API (PUT) it forcibly gets to "suspended" state Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: stalkernoid at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This change: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127244&action=diff - my $suspended_until = exists $body->{suspended_until} ? $body->{suspended_until} : $hold->suspend_until; + my $suspended_until = + exists $body->{suspended_until} + ? dt_from_string( $body->{suspended_until}, 'rfc3339' ) + : dt_from_string( $hold->suspend_until, 'iso' ); Breaks passing "undef" in $hold->suspend_until as well as "undef" in $body->{suspended_until} to: my $params = { ... suspend_until => $suspended_until and always comes with date, it has "today date" instead of "udef" because: sub dt_from_string has: return DateTime->now( time_zone => $tz ) unless $date_string; so as a result when you are changing any hold location (for example) from API, it also puts that hold to be suspended. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 17:09:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 16:09:07 +0000 Subject: [Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Depends on| |24850 Assignee|koha-bugs at lists.koha-commun |stalkernoid at gmail.com |ity.org | CC| |nugged at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 17:09:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 16:09:07 +0000 Subject: [Koha-bugs] [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 17:18:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 16:18:57 +0000 Subject: [Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 17:19:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 16:19:00 +0000 Subject: [Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 --- Comment #1 from Peter Vashchuk --- Created attachment 129619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129619&action=edit Bug 29906: fix the forcibly gets to "suspended" state problem which passes "perl false" to $suspended_until as it is, but in case of "perl trush" it calls dt_from_string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 17:21:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 16:21:10 +0000 Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 17:21:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 16:21:14 +0000 Subject: [Koha-bugs] [Bug 29212] Use Flatpickr on OPAC pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29212 --- Comment #16 from Owen Leonard --- Created attachment 129620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129620&action=edit Bug 29212: (follow-up) Add futuredate attribute to date picker This patch adds the "futuredate" attribute to the "Hold not needed after" date field in the OPAC hold process. To test, apply the patch and log into the OPAC. - Locate a bibliographic record and being the process of placing a hold. - Click "Show more options" to display the date fields. - If the OPACAllowHoldDateInFuture system preferences is enabled: - Set "Hold starts on date" to a date in the future. - Trigger the date-picker in the "Hold not needed after" field: You should be limited to dates *after* the date you selected above. - If OPACAllowHoldDateInFuture is disabled: - The "Hold starts on date" will no longer be present. - Trigger the date-picker in the "Hold not needed after" field: You should be limited to dates after today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 17:22:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 16:22:55 +0000 Subject: [Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129619|0 |1 is obsolete| | --- Comment #2 from Peter Vashchuk --- Created attachment 129621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129621&action=edit Bug 29906: fix the forcibly gets to "suspended" state problem which passes "perl false" to $suspended_until as it is, but in case of "perl truth" it calls dt_from_string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 17:45:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 16:45:11 +0000 Subject: [Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129621|0 |1 is obsolete| | --- Comment #3 from Peter Vashchuk --- Created attachment 129622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129622&action=edit Bug 29906: fix the forcibly gets to "suspended" state problem which passes "perl false" to $suspended_until as it is, but in case of "perl truth" it calls dt_from_string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 18:25:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 17:25:32 +0000 Subject: [Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass --- Any chance this will get a backport for 21.11 and 21.05? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 18:26:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 17:26:09 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show due date and |Show due date in item |availability in item search |search results |results | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 18:28:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 17:28:00 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |This enhancement adds the release notes|availability of an item to |due date of an item to the |the item search results |item search results. The |(i.e. shows if checked out, |due date column will also |available on the shelf, or |show when exporting results |not available for checkout |to a CSV file. |for some other reason). If | |checked out, also shows due | |date in item search | |results. Both the new | |availability and due date | |columns will also show when | |exporting results to a CSV | |file. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 18:30:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 17:30:59 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128645|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 129623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129623&action=edit Bug 17748: Show due date and availability in item search results This enhancement adds the availability of an item to the item search results (i.e. shows if checked out or not). If checked out, shows due date in item search results. The due date column will also show when exporting results to a CSV file. To test: 1) Apply patch and restart services 2) Set up two items. Check out Item A to a borrower. Leave Item B as is not checked out, and not unavailable status. 3) Go to Search -> Item search. Scroll down and notice the Availability radio options - Ignore, and Checked out. 4) Leave the Ignore option selected and do a search so that both items show. 5) Confirm the availability and due date columns are showing at the right end of the table. Confirm Item A says Checked out and has a due date. Confirm Item B says available. 6) Export all result to CSV. Confirm the results show in the CSV file as expected. 7) Go to edit your search. Select the 'Checked out' radio option for Availability and submit the search. Confirm only Item A shows in the results (not Item B). Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 18:31:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 17:31:03 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128646|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Created attachment 129624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129624&action=edit Bug 17748: (follow-up) Fix sorting on new columns Confirm tests in t/db_dependent/Items.t still pass. Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 18:31:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 17:31:07 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128647|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 129625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129625&action=edit Bug 17748: (follow-up) Remove availability column Items can now only be filtered by 'Checked out' or 'not' rather than looking at damaged/itemlost/withdrawn/notforloan status. Removed availability column as Checked out items are made clear by the due date column. Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 18:32:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 17:32:05 +0000 Subject: [Koha-bugs] [Bug 17748] Show due date in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #25 from Katrin Fischer --- Added Christian's surname to the sign-off lines, patches still apply cleanly against master. Thx Aleisha for noticing the missed status change! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 18:35:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 17:35:05 +0000 Subject: [Koha-bugs] [Bug 29906] When changing hold parameters over API (PUT) it forcibly gets to "suspended" state In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29906 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129622|0 |1 is obsolete| | --- Comment #4 from Peter Vashchuk --- Created attachment 129626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129626&action=edit Bug 29906: fix the forcibly gets to "suspended" state problem which passes "perl false" to $suspended_until as it is, but in case of "perl truth" it calls dt_from_string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 21:02:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 20:02:33 +0000 Subject: [Koha-bugs] [Bug 29803] Locally stored cover images do not show in detail page for individual biblio, but do show in listing for multiple biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Eliana changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eliana at flo.org --- Comment #12 from Eliana --- I believe we have the same issue as Martin (although we're on 21.05). I tried the troubleshooting suggestions above and they didn't work for me. Wondering what I'm missing here. Covers show in opac-search.pl: https://catalog.helmlib.org/cgi-bin/koha/opac-search.pl?idx=ti&q=Careers+in+psychology+%26+behavioral+health.&limit=&weight_search=1 No covers in opac-detail.pl: https://catalog.helmlib.org/cgi-bin/koha/opac-detail.pl?biblionumber=1253757&query_desc=Careers%20in%20psychology%20%26%20behavioral%20health. The local covers do load in opac-detail.pl sometimes, adding to my confusion: https://catalog.helmlib.org/cgi-bin/koha/opac-detail.pl?biblionumber=1298655&query_desc=1298655 The ones that don't appear seem to blip in and out of existence as the page loads so they're being hidden by something. I've tried disabling JS which didn't solve the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 21:10:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 20:10:54 +0000 Subject: [Koha-bugs] [Bug 29907] New: The 'type' column in the public lists table is redundant Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29907 Bug ID: 29907 Summary: The 'type' column in the public lists table is redundant Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: noemie.labine at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 129627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129627&action=edit 'Type' column In the OPAC when we go to the lists page to see all the lists, there is a column for the 'type' of list. For the public tab, this information is redundant as you are already in the public tab. The 'type' can't be anything else than public... With the private lists tab, the type can change if you have a shared list, but for the public lists there are no other type. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 21:59:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 20:59:07 +0000 Subject: [Koha-bugs] [Bug 29908] New: Warning when empty ClaimReturnedWarningThreshold in patron_messages.inc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29908 Bug ID: 29908 Summary: Warning when empty ClaimReturnedWarningThreshold in patron_messages.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com System preference ClaimReturnedWarningThreshold manages the display of a patron message in case of too many claims. But this preference may be empty. This generates a warning : Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 128. Default value should be considered has 0 or infinite ? Before Bug 27873 code was in templates, bug still applies. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 21:59:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 20:59:14 +0000 Subject: [Koha-bugs] [Bug 29908] Warning when empty ClaimReturnedWarningThreshold in patron_messages.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29908 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27873 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 21:59:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 20:59:14 +0000 Subject: [Koha-bugs] [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29908 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 21:59:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 20:59:31 +0000 Subject: [Koha-bugs] [Bug 29908] Warning when empty ClaimReturnedWarningThreshold in patron_messages.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29908 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 21:59:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 20:59:31 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29908 [Bug 29908] Warning when empty ClaimReturnedWarningThreshold in patron_messages.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 22:15:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 21:15:19 +0000 Subject: [Koha-bugs] [Bug 29909] New: Search failovers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29909 Bug ID: 29909 Summary: Search failovers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org How hard would it be to have patron search fail over to catalog search and vice versa if no results are returned for the first, instead of saying there are no results? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 22:39:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 21:39:54 +0000 Subject: [Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 --- Comment #8 from AspenCat Team --- Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 22:48:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 21:48:38 +0000 Subject: [Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin Somers --- I'm about to push master I was puzzled by test plan until I understood it is without patch, then with patch :) BTW : We may allow superlibrarian to delete any message even when system preference is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:06 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:08 +0000 Subject: [Koha-bugs] [Bug 11750] Overdue report does not limit patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11750 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:10 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:13 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 --- Comment #13 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:15 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:17 +0000 Subject: [Koha-bugs] [Bug 29764] EmbedItems RecordProcessor filter POD incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29764 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:19 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:21 +0000 Subject: [Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806 --- Comment #14 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:24 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:26 +0000 Subject: [Koha-bugs] [Bug 29807] Branches template plugin doesn't handle empty lists correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29807 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:28 +0000 Subject: [Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:16:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:16:30 +0000 Subject: [Koha-bugs] [Bug 29889] Incorrect library check in patron message deletion logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:43:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:43:58 +0000 Subject: [Koha-bugs] [Bug 29482] Terminology: This item belongs to another branch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:44:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:44:02 +0000 Subject: [Koha-bugs] [Bug 29482] Terminology: This item belongs to another branch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129570|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 129628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129628&action=edit Bug 29482: Replace the term branch with library This patch replaces the word "branch" with the word "library" in the self-checkout template, as per terminology guidelines. To test, apply the patch and go to Administration -> System preferences. - Set the "IndependentBranches" preference to "Yes." - Log into the self checkout system using a staff user with permission to do self-checkout but not superlibrarian status. - Try to check out an item which belongs to a library that's different to the one you're logged in with. - You should see a message, "Item cannot be checked out," including the text "This item belongs to another library." Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:47:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:47:39 +0000 Subject: [Koha-bugs] [Bug 29482] Terminology: This item belongs to another branch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (koha-testing-docker): - I couldn't get the user interface message to display by following the test plan: assume there are some other settings required - the message I got was "Sorry, this item cannot be checked out at this station." - Reviewed patch and signed off based on text changed to the correct terminology. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 19 23:51:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 22:51:45 +0000 Subject: [Koha-bugs] [Bug 29482] Terminology: This item belongs to another branch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29482 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This replaces the word release notes| |"branch" with the word | |"library" for a | |self-checkout message, as | |per the terminology | |guidelines. ("This item | |belongs to another branch." | |changed to "This item | |belongs to another | |library".) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:06:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:06:25 +0000 Subject: [Koha-bugs] [Bug 29625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:06:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:06:28 +0000 Subject: [Koha-bugs] [Bug 29625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128183|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 129629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129629&action=edit Bug 29625: Fix var name in Koha::BiblioUtils get_all_biblios_iterator In Koha::BiblioUtils, get_all_biblios_iterator method is a class level method like get_from_biblionumber. So its first arg should be named $class instead of $self. Even if this var in not used. Test plan : 1) Run Elasticsearch full rebuild with and without patch 2) Check all biblio records are in index Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:08:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:08:44 +0000 Subject: [Koha-bugs] [Bug 29625] Wrong var name in Koha::BiblioUtils get_all_biblios_iterator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (koha-testing-docker): - 436 records both before and after the patch is applied and index regenerated using Elasticsearch. - Searched in the staff interface catalogue using * - Same number of records as indexed when using Zebra. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:15:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:15:14 +0000 Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Keywords| |Manual-updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:20:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:20:08 +0000 Subject: [Koha-bugs] [Bug 27684] Serial add is confused by authorized values with a code of '0' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #7 from David Nind --- Changed status to failed QA - see comment #6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:26:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:26:41 +0000 Subject: [Koha-bugs] [Bug 29826] Useless warning in t/db_dependent/Template/Plugin/Branches.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:26:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:26:45 +0000 Subject: [Koha-bugs] [Bug 29826] Useless warning in t/db_dependent/Template/Plugin/Branches.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129208|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 129630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129630&action=edit Bug 29826: Remove warning in t/db_dependent/Template/Plugin/Branches.t Bug 26587 added a concatenation that sends a warning if var is undef : $ prove t/db_dependent/Template/Plugin/Branches.t Use of uninitialized value $branchcode in concatenation (.) or string at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 35. This patch adds an early return empty string when GetName is called without $branchcode Test plan : 1) Run t/db_dependent/Template/Plugin/Branches.t without patch 2) Run with the patch to see warning disappear Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:29:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:29:54 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:29:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:29:58 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129361|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 129631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129631&action=edit Bug 29867: Reindent authorized values administration template This patch performs general template cleanup to authorized values administration: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and go to Administration -> Authorized values. Test that all functionality works correctly: - Adding or deleting categories - Adding, editing, and deleting authorized values. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:30:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:30:01 +0000 Subject: [Koha-bugs] [Bug 29867] Reindent authorized values administration template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29867 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129362|0 |1 is obsolete| | --- Comment #4 from Lucas Gass --- Created attachment 129632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129632&action=edit Bug 29867: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:35:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:35:37 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:35:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:35:41 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129401|0 |1 is obsolete| | --- Comment #18 from Lucas Gass --- Created attachment 129633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129633&action=edit Bug 7374: Add remote image option for authorized values This patch adds the option of using a remote image for an authorized value, just as you can with item types. To test, apply the patch and go to Administration -> Authorized values. - Click "CCODE" to view the collection authorized values. - Edit a collection code. - In the form, under "Choose an icon," there should now be a "Remote image" tab. - Enter a remote image url, e.g. https://via.placeholder.com/50/FF0000/FFFFFF.png - Click "Save." - After the page redirects to the list of collection codes you should see your image in the table next to the code you edited. - Test that you can still edit a collection to set "No image" or to use one of the local image sets. - Test that remote images can also be added when adding a new collection. - Make sure "ccode" is in the "AdvancedSearchTypes" sytem preference. - Go to the catalog's advanced search page and click the "Collection" tab. - You should see your collection image in the list of collections. - Perform the same check in the OPAC. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 00:37:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Jan 2022 23:37:23 +0000 Subject: [Koha-bugs] [Bug 7374] Add remote image option for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374 --- Comment #19 from Lucas Gass --- (In reply to Noémie Labine from comment #17) > I am currently learning how to test patches on sandboxes so maybe someone > else can countercheck, but the patch seems to work fine for me ! I can edit > existing values and I don't see any other problems. > > I'm not gonna change the status for now. Noémie, it worked well for me too! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 01:58:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jan 2022 00:58:16 +0000 Subject: [Koha-bugs] [Bug 21265] Additional step at end of onboarder to enable HEA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- Does it still depend on bug 18888? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 01:59:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jan 2022 00:59:38 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply CC| |victor at tuxayo.net --- Comment #18 from Victor Grousset/tuxayo --- Dependency not blocking anymore but rebase needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 02:03:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jan 2022 01:03:11 +0000 Subject: [Koha-bugs] [Bug 29910] New: Purge old Hea data periodically Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910 Bug ID: 29910 Summary: Purge old Hea data periodically Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hea Assignee: chris at bigballofwax.co.nz Reporter: victor at tuxayo.net QA Contact: jonathan.druart+koha at gmail.com AFAIK it's not purged so we might have misleading information from old libraries than no longer use Koha. So it lessens the trust and the insight Hea gives us. There could be a cron than runs some SQL that deletes submissions that haven't been updated since more than X months. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 08:24:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jan 2022 07:24:25 +0000 Subject: [Koha-bugs] [Bug 29910] Purge old Hea data periodically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29910 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 09:28:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jan 2022 08:28:21 +0000 Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #91 from Marcel de Rooy --- While working on follow-up reports, I still find an issue. Sorry :) The following scheme shows a different response with this patch set and without: [1] Login with a good or bad userid and wrong password (staff). You should get the error Invalid username or password. [2] On this form with the error, login again with the same wrong credentials. You do not get the previous error. Which you should have got! But you will crash on line 87 of mainpage. Can't use an undefined value as a HASH reference at /usr/share/koha/mainpage.pl line 87 Changing status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 20 09:30:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Jan 2022 08:30:34 +0000 Subject: [Koha-bugs] [Bug 29911] New: Default amounts for fee types display with comma in some cases Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29911 Bug ID: 29911 Summary: Default amounts for fee types display with comma in some cases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When CurrencyFormat is set to "FR" and you are manually adding a copier fee or similar to a patron account, the amount will show up with a decimal comma instead of a decimal dot, which won't work correctly. This is because we are missing the on_editing => 1 filter here: maninvoice.tt