[Koha-bugs] [Bug 29018] Deleting patrons from REST API doesn't do any checks or move to deletedborrowers
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Jan 3 14:36:49 CET 2022
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29018
--- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 128960
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128960&action=edit
Bug 29018: Make DELETE /patrons/:patron_id check things
When the route was implemented, the checks were overlooked. This patch
adds checks for:
- Guarantees
- Debts
- Current checkouts
Any of those will block deletion, as it should.
To test:
1. Apply the regression tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: Tests fail, the route misses checks
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! The three conditions prevent deletion!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list