[Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I added 29794, which I found while testing this. The results are:
- biblio/item views works as expected
=> SUCCESS
- delete_items.pl
=> SUCCESS/FAIL: The check works, deletion is prevented, but the error message
prints the Koha::Object::Message reference. It should be calling ->message in
line 86.- batch delete. It also felt like we could do a join on multiple
messages too? This last one is not a blocker of course.
=> FAIL: There's a problem with Koha/UI/Table/Builder/Items.pm line 111 calling
'ne' on the 'safe_to_delete' output (Koha::Result::Boolean). I tried a fast fix
(checking the attribute was 'safe_to_delete' and evaluating in boolean context)
but it turned out it broke blocking_errors.inc and I got out of fuel.

-- 
You are receiving this mail because:
You are watching all bug changes.