[Koha-bugs] [Bug 29788] Make Koha::Item->safe_to_delete return a Koha::Result::Boolean object

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29788

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #3)
> It also felt like we could do a join on
> multiple messages too? This last one is not a blocker of course.

I don't know.
Either we should restrict "messages" to only 1 message (do we use more so
far?), or we should have a new method in the module to ease the retrieval of a
single message.

I don't think we should restrict to 1 message only, even if we are not using
more than 1 now, we could later.

Maybe we could have something like:

sub get_unique_message_str {
    my ( $self ) = @_;
    croak "There are more than one message" if @{$self->{_messages}} > 1;

    return @{$self->messages}[0]->messages
}

But that's for a separate bug report anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.