[Koha-bugs] [Bug 29806] ->pickup_locations should always be called in scalar context

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jan 7 19:20:10 CET 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29806

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi! Thanks for the follow-up. Strictly speaking,
Koha::Biblios->pickup_locations IS list context aware so this wouldn't be
needed. I skipped it because of that reason, but that was before I wrote to
koha-devel with my suggestion that we call ->as_list explicitly all the time.

So, this patch is welcome and good to be included!

(In reply to Jonathan Druart from comment #12)
> Created attachment 129186 [details] [review]
> Bug 29806: (follow-up) Call ->as_list for ->pickup_locations on request.pl
> 
> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list