[Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Jan 13 17:10:56 CET 2022
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877
Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #129412|0 |1
is obsolete| |
--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Created attachment 129416
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129416&action=edit
Bug 29877: Make POST /holds handle maxreserves correctly
The current implementation doesn't consider the following values for the
syspref: undef and 0.
The tests mistakenly didn't cover them.
To test:
1. Apply the regression tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: Tests fail, obvious warnings about comparing undefined values
too.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. You can try on Postman as well
=> SUCCESS: Behavior is correct!
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list