[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #11 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Andrew and Martin, 

Martin: Thank you for your reply in comment #6. My concerns with hard coding
were:

1. Everytime a datetime column is added to the items table then the community
would have to remember to update this hardcoded list of columns.

2. If an existing datetime column is removed/renamed then the hardcoded list
would have to be updated otherwise my alterations to
C4::Items->ToggleNewStatus() would throw an error. As the hardcoded list
determines what column is queried.

But as you say doing an introspect of the koha::Object may not be worthwhile.
So I have left the hardcoded list for now. I'm happy to add it later though if
that is what QA wants.

Andrew: I have corrected the test plan. That error you encountered was because
my test plan noted an incorrect unit test filepath. So it was not your error :)

Could you please re-test now?

Many thanks!
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.