[Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403

--- Comment #48 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
-        t::lib::Dates::compare( $updated_on_got, $updated_on_expected,
'updated_on values matched' );
+        t::lib::Dates::compare(
+            dt_from_string( $updated_on_got,      'rfc3339' ),
+            dt_from_string( $updated_on_expected, 'rfc3339' ),
+            'updated_on values matched'
+        );

But what does t::lib::Dates?

sub compare {
    my ( $got, $expected ) = @_;
    my $dt_got      = dt_from_string($got);
    my $dt_expected = dt_from_string($expected);
    my $diff = $dt_got->epoch - $dt_expected->epoch;
    if ( abs($diff) <= 5 ) { return 0 }
    return $diff > 0 ? 1 : -1;
}

So $got en $expected should be strings, right?
Does this actually show that we miss a parameter in sub compare, and we are
solving it by twisting the test instead?

-- 
You are receiving this mail because:
You are watching all bug changes.