[Koha-bugs] [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403

--- Comment #53 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Including a 'T' is actually valid for ISO date format, I was being
naughty and writing the test to follow our code rather than writing the
test to conform to the ISO spec first time around. Now we are properly
supporting 'T' in ISO dates with bug 29718, we need to update the test
here to properly reflect an invalid ISO date string.
-    $dt0 = dt_from_string('2021-11-03T10:16:59+00:00', 'iso');
+    $dt0 = dt_from_string('2021-11-03T10:16:59Z+00:00', 'iso');

This is rather unclear. The changes do not reflect the description.
You dont do anything with T here.
Adding the Z is making the test pass by failure on the combination of Z and
+00.
I will add a comment on this line and another one to clarify.

-- 
You are receiving this mail because:
You are watching all bug changes.