[Koha-bugs] [Bug 29889] New: Incorrect library check in patron message deletion logic

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29889

            Bug ID: 29889
           Summary: Incorrect library check in patron message deletion
                    logic
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 21757

If you DON'T have AllowAllMessageDeletion enabled, message deletion is supposed
to be limited by library: Staff from the same library can delete each other's
messages, but not messages left by other libraries.

At some point the logic around the display of the "Delete" link got changed, I
think by Bug 21757. Now the check compares the branchcode of the staff member
who left the message with the branchcode of the patron:

patron_message.branchcode == patron.branchcode

I think this is meant to compare patron_message.branchcode to the logged-in
library.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757
[Bug 21757] Patron detail script (moremember.pl) cleanup
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.