[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #32 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Nick Clemens from comment #26)
> bug 23991 - I ran the script to generate random suggesstions - I can see
> them - apply patch, I don't see them
> 
> 
> If I load from library link on homepage, I see them
> but if i change library using pulldown I can't 
> 
> the 'all libraries' link form homepage does not work either
> 
> 
> http://localhost:8081/cgi-bin/koha/suggestion/suggestion.
> pl?branchcode=FFL&displayb[…]eptedby=&accepteddate_from=&accepteddate_to=&bud
> getid=__ANY__
> that shows nothing
> 
> http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?branchcode=FFL
> That shows things
> 
> 
> Logs show this often:
> [2022/01/14 15:21:34] [WARN] Use of uninitialized value in string eq at
> /kohadevbox/koha/suggestion/suggestion.pl line 113.
> [2022/01/14 15:21:34] [WARN] Use of uninitialized value $v in string eq at
> /kohadevbox/koha/suggestion/suggestion.pl line 115.

Should be fixed with the last patch.

There is certainly more to do to clean this controller and template, but prefer
to not rewrite them here and focus on the SearchSuggestion move only.

-- 
You are receiving this mail because:
You are watching all bug changes.