[Koha-bugs] [Bug 28975] Holds queue lists can show holds from all libraries even with IndependentBranches

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975

--- Comment #2 from The Minh Luong <the-minh.luong at inlibro.com> ---
Created attachment 129810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129810&action=edit
Bug 28975: Holds queue lists can show holds from all libraries even with
IndependentBranches

When using IndependentBranches, usually all branches are removed from the
drop-down menus. But in the Holds Queue page, there is the possibility to
choose "All branches". From there, you can see holds for patrons from other
branches and even click on the names of the patrons to access their file and
see their information (!!).

To recreate :
1) Activate IndependentBranches, IndependentBranchesPatronModifications and
IndependentBranchesTransfers
2) Create a staff user with limited permissions (NOT a superlibrarian),
including holds permissions. Here are mine as an example
  - circulate (all)
  - catalogue
  - borrowers
    - delete_borrowers
    - edit_borrowers
  - reserveforothers (all)
  - reports (all)
3) Create (or make sure you already have) a patron in another branch (we'll
call them patron X)
4) Place a hold for patron X on an available item from their own library
5) Run misc/cronjobs/holds/build_holds_queue.pl
6) Go to Circulation > Holds queue and make sure you can see the hold
7) Log in as your limited staff patron
8) Go to Circulation > Holds queue
9) In the drop-down menu, choose "All" and click Submit
-- Patron X and their hold appear in the list
10) Click on patron X's name
-- You can access patron X's file and see their information
11) Apply the patch.
12) Notice that the "All" option is no longer available for the limited patron.
Limited patrons can't see holds from other libraries anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.