[Koha-bugs] [Bug 29949] Remove use of title-numeric sorting routine from OPAC datatables JS

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jan 26 13:33:15 CET 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29949

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 129824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129824&action=edit
Bug 29949: Remove use of title-numeric sorting routine from OPAC datatables JS

This patch removes the use of a specific "title-numeric" sorting routine
from the DataTables configuration of the "Most popular" table. We can
use a "data-order" attribute instead.

The patch also removes the now unused code from our custom DataTables JS
file in both the OPAC and the staff interface (where it was unused).

To test, apply the patch and make sure the OpacTopissue system
preference is enabled.

- In the OPAC, view the "Most popular" page.
- Change the filter settings, if necessary, to get multiple results.
- In the results table, confirm that sorting by number of checkouts
  still works correctly.

A search of the code for instances of "title-numeric" should return only
one in a comment in the official DataTables library.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list